selune
9e6e0b8df1
* wip(render): reconcile completed material and image pipeline source with 0.20 (#5493) Source-only integration reference for staged review, not a merge-ready aggregate. Donor: 0xlillith/solidcraft@aea20b0115. Upstream:858e5995d6. Retain original CPU/material contracts and explicit GPU donor provenance in docs/render-materials-lab.md (#2067, #2191, #2780, #3306). Preserve released format migrations and current navigation/startup/shell behavior. New saved records use pending descriptors. The physical-card descriptor follows the maintainer's material-engineering-cards naming request, with a legacy-lab format-29 regression. Replace raw new panel hosts with shared containers. Repository checks, complete workspace/all-target Clippy, and the independent physical/resource authoring checks pass for this source. The fresh full local CI invocation has reached test compilation and is not yet complete. Do not transfer donor native output or prior test totals to this integration. Generated review screenshots, video, package ZIP and machine logs remain at the immutable personal evidence pin. Uncommitted geometric displacement is backed up separately, not silently included. No kernel/vendor change, direct main write, release or independent contributor-branch rewrite. Co-authored-by: Christian Svensson <blue@cmd.nu> * test(cli): pin the Compact camera-sample admission diagnostic (#5493) The bounded request still refuses 1024x1024x64 samples before host initialization and writes no output. Update only the stale expected diagnostic to the existing Compact budget wording; production limits and code are unchanged. Exact-tree CLI regression suite: 14 passed, 0 failed. The full repository gate has been invoked separately and is not yet complete. * Normalize UI container violation paths across platforms Report repository-relative paths with forward slashes so diagnostics and the existing nested-package regression assertions agree on Windows and Unix. Keep the container detection rules unchanged. Validation: official ui-containers gate and all seven focused xtask tests passed; rustfmt and diff checks passed. Only xtask/dependencies were compiled; no application build or heavy tests. (cherry picked from commit44b58d8e10) * fix(render): preserve camera contracts and correct acceptance regressions (#5493) Preserve Design view.apply semantics with a separate strict Render camera command. Retain existing translations when English-only aliases collide; add material-axis entries and camera-specific pitch labels. Compare complete validated engineering cards and retain job handles before cancellation. Focused and native acceptance is pinned to treef8a423b21f. Full CI has been invoked separately and is not claimed green. Landing follows the render integration policy in #5493. * fix(render): resolve showcase licence and upstream resource hygiene (#5493) Record SychPL's explicit MIT OR Apache-2.0 grant, retaining source/model bytes and the Ubuntu lettering notice. Remove 80 absent attribution rows, personal fork records, dead delivery attributes and three fork/resource-only workflows. Existing xtask assets now performs bounded offline hash checks and rejects orphan render attribution; no parallel draft CI or package installation. Original authoring reproduction remains explicit. Scoped xtask tests, assets, Clippy, formatting and prepared SELENE validation pass; no application or renderer-wide result is inferred. * fix(render): align saved bounds and progressive sample resolution (#5493) Address review r4364211669/r4364211677/r4364211681/r4364211691/r4364211695. Persisted light/frame domains respect the existing 1e9 document bound; related LED/rectangle/direction cases use the same bound. Workstation primary resolve shares the 4096 admission cap and film counters use checked conversions. Exact candidate: 485 CPU render tests, 21 render document tests and strict scoped Clippy pass, including positive boundary round trips and 2048/4096 end-to-end checkpoints. No released format/migration edits, relaxed test limits or full-stack acceptance claim. * wip(render): isolate optional resources and harden sample handling (#5493) Review work in progress: opt-in encoded render library with reproducible runtime catalog exports; native-only robust dependency through the workspace; checked bloom slices; per-sample point-light diagnostics; independent area-light spatial/film keys. Resource-module binaries in both configurations, generation, Cargo production feature graphs and attribution checks pass. Full engine/render regression and combined acceptance are pending: do not merge this donor as a constituent or treat scoped resource proof as runtime acceptance. * fix(gpu): preserve donor allocations through the scope-safety repair (#5722) Port the native-validated #5723 scope-cleanup correction into the experimental donor, retaining its adaptive, volume, aging, photographic and bloom allocations. Same reverse-drain helper and regression cases; the donor combination still needs its own compile/test gate and is not covered retroactively by render-base results. * claim: #1369 * Reject unknown pending concepts after format folding (#1369) * test(render): close bounded sampling and bloom review regressions (#5493) Validate the optional-resource/lighting/dependency donor at its exact tree. Required Vulkan GPU 127/0/3; CPU renderer 487/0; engine Render 72/0; document render 21/0; lean library 7/0; strict scoped Clippy, assets/layers/lists/containers and lean-engine WASM pass. Preserve original failed controller/typing attempts. This is the draft donor/disposition source, not a replacement for constituent render PRs or final main acceptance. * wip(render): preserve stable aging target validation candidate Exact staged source from prior review work on donor3b892eab5e. This is a recovery/review checkpoint, NOT accepted delivery. An actual command-path regression currently fails because the selected executor refuses ordered surface aging. No assertion, capability or admission limit is weakened. Native/UI/full combination acceptance remains pending. Saved/runtime split adds one pending descriptor and retains original file scope; no main/render branch is changed. * test(render): preserve numeric setup intent at the admitted coordinate bound Follow up jyviko review on #5494 without weakening the corrected saved-coordinate contract. The positive clicked fixture uses 1e9 instead of inadmissible 2e9; explicit out-of-range cases still refuse, and the full saved setup round-trips through JSON and the native container. Exact-source Render workspace 95/0 and strict all-target UI Clippy pass. This does not incorporate the separately failing stable-aging candidate or claim full current-render acceptance. * test(render): use the real GPU executor for saved aging Move successful native cold-reopen Check/Start coverage from the CPU-backed protocol fixture into the production GPU executor tests. Verify capture-index changes preserve the stable target and that enabling aging changes both PNG and raw EXR output. Retain explicit, allocation-free refusal coverage for executors without aging support. Production capabilities and admission checks are unchanged. * fix(render): persist stable identities for targeted aging (#5493) Separate saved RenderBodyTarget identities from captured mesh ordinals. Reject legacy ambiguous targets, resolve Check/Start after visibility changes and preserve native reopening, copies and undo. Unsupported executors still refuse; real AMD Vulkan regression completes saved aging after reordered capture. Source tree6b84c8adpasses document 23, engine Render 75, GPU effects 5 and Render UI 95 with no failures; scoped strict Clippy, WASM and repository gates pass. Fresh CLI/native reopen and clean/aged GPU exports pass with identical physical totals and inspected actual images. Whole current-render integration is separate. * fix(render): reconcile combined CPU/GPU contracts on current upstream Unify captured resources/status and CPU-vs-GPU request schemas after the real two-parent integration; remove obsolete duplicate Vulkan selector and retain combined platform-filter regression. Deduplicate only identical or superseded test definitions, retaining the stronger card metadata and reserved-executor assertions. No assertions, admission limits or feature refusals are weakened. All targets of render dependencies, GPU, engine, UI, CLI and native app pass cargo check with raytrace-cpu and bundled-render-library at treec70d00d1. Native executable tests and full current-source acceptance remain pending. This is a private integration rehearsal for subsequent constituent PRs, not an aggregate official render/main merge. * test(render): retain one complete host lifetime regression set Deduplicate byte-identical DropProbe/task-lifetime tests and retain the adapted environment/texture ownership regressions with every assertion and complete memory estimate. Keep the registered-geometry admission regression once; only struct field order differed. Replace a one-element diagnostic loop with its equivalent block, preserving all wrap/width assertions. Test-only integration repair. Formatting and diff checks pass; refreshed executable validation is required. No production behavior, limits, assertions or ignores changed. * fix(doc): recognize the proven format-29 card descriptor alias Normalize only the historical format-29 physical-material-cards spelling, and only when material-engineering-cards is registered. Admission and migration de-duplication use the same identity. Unknown concepts, wrong versions and incapable readers still refuse before mutation. Six controlled-history Rust regressions and actual CLI migration/no-clobber acceptance pass. No version, released migration or CI changes. Refs #5793, #1369, #5493. * test(render): preserve grounding refusal before explicit instance moves Update the two Render binding fixtures for upstream first-occurrence grounding. Verify grounded movement refuses without changing document/history, then explicitly unground through the public command before the intended move. Retain every target, resource, copy and persistence assertion. Refs #5493. --------- Co-authored-by: Christian Svensson <blue@cmd.nu> Co-authored-by: Victor Santos Oliveira <56417388+Vittuu@users.noreply.github.com> Co-authored-by: cfaulkingham <colin.faulkingham@gmail.com>
9.4 KiB
Handoff to the render/materials implementation thread
Scope of this contribution
This PR provides English planning content under docs/render-materials/ and native SELENE authoring resources plus development tools under assets/render/selene/, with exact attribution rows. It changes no application command, shader, renderer backend or native document format. The SELENE continuation reconstructs geometry, assemblies and appearances in a derivative through existing SolidCraft commands; the broader catalog remains a specification backlog. The integration base is the user's lab/render-materials branch at the recorded revision. Do not replace it with a newer upstream snapshot as a side effect of integrating this package.
Immediate implementation tasks
| Order | Task | Acceptance |
|---|---|---|
| 1 | Inventory the actual landed backend and settings support. | Mark each CAP record present, partial or missing with evidence; concept rows remain unavailable. |
| 2 | Define versioned appearance, rig, environment and shot resource contracts. | Units, roles, inheritance, locks, provenance and capability requirements round-trip. |
| 3 | Implement a read-only preset resolver and atomic apply through the engine. | The same resolved request reaches UI, CLI and MCP; unsupported input leaves the scene unchanged. |
| 4 | Bind a small representative material/lighting/environment set. | Authored resources, thumbnails and tests demonstrate the claimed capabilities. |
| 5 | Connect library, contextual inspector and final-job preflight. | A first-time user can apply a scene, change a finish, undo and reproduce output. |
| 6 | Establish raw/finished image and numeric reference scenes. | Saved manifests identify source, executor, resources and color treatment. |
| 7 | Bind quality profiles with explicit budgets and resource admission. | Converged, unconverged, canceled and unsupported outcomes are distinguishable. |
| 8 | Integrate SELENE role bindings and procedural lunar stages. | Native hash, model scale, source ownership and material assignments pass review. |
| 9 | Publish the first validated content pack. | Availability is driven by actual resource and executor support. |
| 10 | Develop animation and dynamics in its own implementation arc. | Analytic fixtures and physical contacts pass before producing the throw/catch demo. |
Architecture boundaries
Required UI alignment
Use UI_INTEGRATION.md and ui-integration.json before wiring the library or inspector. The audit compared the fixed 0.18.2 integration base with upstream 0.18.4 at 728f753b8094e1a54c5cc8b7e453982afa028023, read-only. Preserve the implemented shell: one Render workspace and RENDER ribbon tab, current SCENE/IMAGE groups, shared Floating/Docked layouts, approved icons, theme tokens and UI kit. The selected Render tab uses render_ink on render_soft; its icons keep their semantic palettes.
Extend the existing Appearance/LocalLibrary consumer and current render commands. Library categories are local navigation; Quick/Detailed/Expert are inspector disclosures. A future result canvas, Render picking/gizmos and migration from the fixed 285-point settings container to the shared Panel are explicit integration tasks. Do not describe them as current support. Reconcile the pinned mappings with the implementation that actually lands in this fork, without replacing its fixed base.
The twelve prepared SELENE shots now have exact three-profile quality recommendations in the demo flow. Its current state remains unbound, and opening the standalone swatch input must create a fresh isolated document. Runtime validation includes theme/layout/scaling, keyboard, scope, draft, lock and multi-document behavior as specified in the UI acceptance matrix.
Layer and state ownership
Follow the existing layer direction: rendering primitives and capability contracts remain below the document/engine layers; persisted scene intent belongs at the appropriate document boundary; commands orchestrate changes; UI panels display and invoke commands. Keep device/windowing/UI dependencies out of lower layers according to AGENTS.md. Use the existing navigation handler for all new render views.
JSON in this package is a specification format, not a requirement to load unvalidated dictionaries inside the Rust application. Design typed Rust data with finite-value checks, caps, version migration, resource hashes and errors. Bound array lengths, resource size, recursion, texture allocation and loop work before execution. Unknown fields, unavailable features and unresolved resources need clear outcomes; do not silently discard them.
Do not use Python as an application dependency. The supplied validator is a development tool. Do not introduce a second settings implementation in the UI or bypass the command registry to apply catalog entries.
Stable identity and migrations
Treat concept IDs as durable. Resource versions can evolve without renumbering the concept. An authored material is a versioned realization of a concept, potentially with several executor bindings. A new optical interpretation that changes expected behavior requires a new resource revision and revalidation, not an invisible edit to all saved shots.
Preserve the old ID ranges when moving from the previous planning inventory. Use English display names and searchable aliases where helpful. The retained LUZ prefix is an identifier compatibility decision, not a request for Spanish UI text.
Prepared files available now
Use assets/render/selene as the prepared resource authority. It contains 48 original recipes with current opaque PBR projections and separate advanced intent, one executable 48-swatch command script, 33 semantic roles, 10 stages and 12 shot recipes. These are authoring resources; do not advertise them as a validated production library or import the pack as scalar solidcraft-library/1 data.
tools/prepare.py inspects native identity and assembly metadata, makes an unreviewed body-role template, and compiles an opaque overlay only after source and target review. It emits the documented appearance.assign envelope, preserving physical materials. tools/validate_prepared.py checks the prepared package. Both are Python development tools, not application dependencies.
The active source lock is pinned_native and selects the unchanged, owner-supplied SELENE-showcase.solidcraft. Its exact identity, provenance, notices and executor compatibility are recorded in SOURCE.md. Source-container mechanism bindings now exist; the derivative's mechanism work, electronics reconstruction and native build tool use the admitted source. Continue verifying exact evaluated targets, joint movement and final-model evidence on the chosen executor. Do not substitute the historical selene-bindings.json IDs or infer full-model acceptance from source admission and isolated fixtures.
Suggested first resource slice
Select exact concept IDs after the material registry is bound, covering: neutral dielectric, coated plastic, clear glass, colored absorbing glass, brushed aluminum, stainless steel, painted steel, sparse-flake paint, rubber, silicone, FDM polymer, PCB solder mask, copper trace, wood with directional grain, a wood coat, LED diffuser, light-guide polymer, solar-cell assembly appearance, thermal blanket and mare/highland regolith.
Pair these with neutral product, dark housing, metal strip, glass bright-field, PCB, wood, LED and spacecraft rigs; use simple physical stages before complex rooms. Publish only the subset supported end to end. Specialized material names must not mask unimplemented optical behavior.
SELENE-specific dependencies
The still demo needs precise geometry/tessellation, layered surfaces, stable physical mapping, transparent container optics, sampled emitters for LED views, terrain detail, one-Sun ownership, linear color/output and memory-safe quality settings. The future dynamics layer should reuse existing kinematic studies, IK, links, traces and export. It additionally needs verified independent vial bodies, explicit closure and grasp state, collision proxies, mass/inertia, contact, joint actuation, granular approximation choices, analytic verification, immutable bakes and shutter-time sampling.
Do not make animation a prerequisite for the still. Do not advertise the animation as physically verified because it follows a parabola visually: release velocity, rotation, contacts, constraints, mass changes and storage also need evidence.
Publication and validation
Use roadmap.json for the broader F00–F12 and S01–S06 sequence. The current PR's validation report is VALIDATION.md. Package validation checks the specification and its references; renderer/physics validation remains work for the corresponding implementation.
Before merge, run the repository's required checks in an environment with the required Rust toolchain and dependencies. ATTRIBUTION.md is embedded by the UI and can expand the CI scope even though this contribution contains no application behavior change. Do not report a successful cargo xtask ci run unless it actually completed on the submitted tree.