mirror of
https://github.com/bherbruck/solidcraft.git
synced 2026-11-08 13:01:52 +00:00
JEREMY
2de99c728e
* Sheet metal: a corner relief no longer depends on the order the corners are cut in The corner reliefs are planned against the base as it is before any of them is cut, and the two reliefs at the ends of one edge are compared with each other. Before, every relief was cut into the base as it went, so the corner after it saw the relief of the corner before it: the square relief reaches further from its corner than the round one does (4 / cos(α / 2) against 4), so on a short edge it was left out where the round one was cut, and which of the two corners kept its relief depended on the order the flanges were made in. The reliefs themselves are unchanged: a round about the corner through the angle the base fills there, or the square with that side (a kite where the corner is not square, its cuts square to the two edges). What is new is that they are planned first and cut together, so that a corner's relief depends on the base and on the other reliefs, and not on the order they are cut in. Two reliefs that would overlap are still refused, now with a note that says so. Covered: the four relief shapes at corners of 60° and 120°, with the flanges of equal and of unequal height, through the kernel and through the engine (where the flat pattern and the DXF keep one clean loop). Co-Authored-By: Claude Code <noreply@anthropic.com> * Sheet metal: cover the corner reliefs at a corner that is not square The engine and the UI had no test at all for a base whose corners are 60° and 120°: the flat pattern, the DXF, the unfold and the rule manager's own square relief were all untested there. They work; this says so. Co-Authored-By: Claude Code <noreply@anthropic.com> * Sheet metal: say what happens when a corner relief is left out The guide now says that the reliefs at the corners of one edge are cut together, and that two of them that would overlap leave the second one out. A relief that cannot be cut is reported, not dropped. Co-Authored-By: Claude Code <noreply@anthropic.com> * Sheet metal: write the corner relief's expected corners out The engine test hard-coded the corners of the trimmed base; it works them out instead, and the numbers the test and the sketch share are written with the precision they need. Co-Authored-By: Claude Code <noreply@anthropic.com> --------- Co-authored-by: jeremymiribung-blip <jeremymiribung-blip@users.noreply.github.com> Co-authored-by: Claude Code <noreply@anthropic.com>