mirror of
https://github.com/bherbruck/solidcraft.git
synced 2026-11-06 20:02:16 +00:00
raykholo
7046f7f0e7
* claim: #5523 * Windows resize smoke test: wait for a settled window before hit testing Startup placement can move the window between CheckBorder reading its rect and the hit tests, so correct answers for the new position failed against stale coordinates. Wait for two reads 200 ms apart to agree before the first pass, compare the rect after each pass, and retry the pass (up to three tries) when it moved. A pass with a stable rect fails exactly as before. Fixes #5523
224 lines
12 KiB
PowerShell
224 lines
12 KiB
PowerShell
# Start the Windows app and check its resize border (#1381): as soon as the window exists (before
|
|
# the first frame), Windows' hit test reports a resize edge or corner within the resize-border
|
|
# width of every side and the client area inside it; a maximized window has none; and a real
|
|
# press-and-drag on the bottom edge (SetCursorPos + mouse input) resizes the window.
|
|
#
|
|
# What this can't check on a CI runner (one monitor at 100 %): moving the window between monitors
|
|
# with different scales, and the resize border's width at other scales (unit tests cover the sizes).
|
|
#
|
|
# Usage: tools/windows-resize-smoke.ps1 -Exe target\ci\solidcraft.exe
|
|
param([Parameter(Mandatory = $true)][string]$Exe)
|
|
$ErrorActionPreference = 'Stop'
|
|
|
|
Add-Type @'
|
|
using System;
|
|
using System.Runtime.InteropServices;
|
|
public static class Win {
|
|
[StructLayout(LayoutKind.Sequential)] public struct RECT { public int Left, Top, Right, Bottom; }
|
|
[StructLayout(LayoutKind.Sequential)] public struct POINT { public int X, Y; }
|
|
[DllImport("user32.dll")] public static extern bool GetWindowRect(IntPtr h, out RECT r);
|
|
[DllImport("user32.dll")] public static extern bool SetWindowPos(IntPtr h, IntPtr after, int x, int y, int cx, int cy, uint flags);
|
|
[DllImport("user32.dll")] public static extern IntPtr SendMessageW(IntPtr h, uint msg, IntPtr w, IntPtr l);
|
|
[DllImport("user32.dll")] public static extern bool ShowWindow(IntPtr h, int cmd);
|
|
[DllImport("user32.dll")] public static extern bool IsZoomed(IntPtr h);
|
|
[DllImport("user32.dll")] public static extern bool SetForegroundWindow(IntPtr h);
|
|
[DllImport("user32.dll")] public static extern bool SetCursorPos(int x, int y);
|
|
[DllImport("user32.dll")] public static extern bool GetCursorPos(out POINT p);
|
|
[DllImport("user32.dll")] public static extern void mouse_event(uint flags, int dx, int dy, uint data, UIntPtr extra);
|
|
[DllImport("user32.dll")] public static extern uint GetDpiForWindow(IntPtr h);
|
|
[DllImport("user32.dll")] public static extern int GetSystemMetrics(int i);
|
|
[DllImport("user32.dll")] public static extern int GetSystemMetricsForDpi(int i, uint dpi);
|
|
[DllImport("user32.dll")] public static extern bool IsWindowVisible(IntPtr h);
|
|
[DllImport("user32.dll", CharSet = CharSet.Unicode)] public static extern int GetWindowTextW(IntPtr h, System.Text.StringBuilder s, int n);
|
|
[DllImport("user32.dll", CharSet = CharSet.Unicode)] public static extern int GetClassNameW(IntPtr h, System.Text.StringBuilder s, int n);
|
|
[DllImport("user32.dll")] public static extern uint GetWindowThreadProcessId(IntPtr h, out uint pid);
|
|
public delegate bool EnumProc(IntPtr h, IntPtr l);
|
|
[DllImport("user32.dll")] public static extern bool EnumWindows(EnumProc f, IntPtr l);
|
|
public static string Text(IntPtr h) { var s = new System.Text.StringBuilder(256); GetWindowTextW(h, s, 256); return s.ToString(); }
|
|
public static string Class(IntPtr h) { var s = new System.Text.StringBuilder(256); GetClassNameW(h, s, 256); return s.ToString(); }
|
|
// The process's visible top-level window titled SolidCraft (the app's main window; the
|
|
// process has other top-level windows, such as the IME's).
|
|
public static IntPtr MainWindow(uint pid) {
|
|
IntPtr found = IntPtr.Zero;
|
|
EnumWindows((h, l) => {
|
|
uint p; GetWindowThreadProcessId(h, out p);
|
|
if (p == pid && IsWindowVisible(h) && Text(h).StartsWith("SolidCraft")) { found = h; return false; }
|
|
return true;
|
|
}, IntPtr.Zero);
|
|
return found;
|
|
}
|
|
public static int HitTest(IntPtr h, int x, int y) {
|
|
long l = ((long)(ushort)(short)y << 16) | (long)(ushort)(short)x;
|
|
return (int)SendMessageW(h, 0x0084 /* WM_NCHITTEST */, IntPtr.Zero, new IntPtr(l));
|
|
}
|
|
}
|
|
'@
|
|
|
|
$HT = @{ 1 = 'client'; 10 = 'left'; 11 = 'right'; 12 = 'top'; 13 = 'top-left'; 14 = 'top-right'; 15 = 'bottom'; 16 = 'bottom-left'; 17 = 'bottom-right' }
|
|
$failures = New-Object System.Collections.Generic.List[string]
|
|
function Check([bool]$ok, [string]$what) {
|
|
if ($ok) { Write-Host "ok: $what" } else { Write-Host "FAIL: $what"; $failures.Add($what) }
|
|
}
|
|
function Rect($h) { $r = New-Object Win+RECT; [void][Win]::GetWindowRect($h, [ref]$r); $r }
|
|
|
|
# Every side and corner, `in` px inside the window's outer pixel, and points just past the border.
|
|
function CheckBorder($h, [string]$when) {
|
|
$r = Rect $h
|
|
if ($when -eq 'first sight') {
|
|
$settled = $false
|
|
for ($i = 0; $i -lt 25; $i++) {
|
|
Start-Sleep -Milliseconds 200
|
|
$next = Rect $h
|
|
if ($r.Equals($next)) { $settled = $true; break }
|
|
$r = $next
|
|
}
|
|
if (-not $settled) { throw "$when : window placement did not settle within 5 s" }
|
|
}
|
|
for ($try = 1; $try -le 3; $try++) {
|
|
$r = Rect $h
|
|
$dpi = [Win]::GetDpiForWindow($h)
|
|
# Windows' own resize border at this DPI (SM_CXSIZEFRAME + SM_CXPADDEDBORDER), as the app uses it.
|
|
$b = [Win]::GetSystemMetricsForDpi(32, $dpi) + [Win]::GetSystemMetricsForDpi(92, $dpi)
|
|
$cx = [int](($r.Left + $r.Right) / 2); $cy = [int](($r.Top + $r.Bottom) / 2)
|
|
$l = $r.Left; $t = $r.Top; $rt = $r.Right - 1; $bt = $r.Bottom - 1
|
|
Write-Host "$when : window $($r.Left),$($r.Top) - $($r.Right),$($r.Bottom) at $dpi DPI, border $b px"
|
|
$cases = @(
|
|
@($l, $cy, 10), @(($l + $b - 1), $cy, 10), @(($l + $b), $cy, 1),
|
|
@($rt, $cy, 11), @(($rt - $b + 1), $cy, 11), @(($rt - $b), $cy, 1),
|
|
@($cx, $t, 12), @($cx, ($t + $b - 1), 12), @($cx, ($t + $b), 1),
|
|
@($cx, $bt, 15), @($cx, ($bt - $b + 1), 15), @($cx, ($bt - $b), 1),
|
|
@($l, $t, 13), @($rt, $t, 14), @($l, $bt, 16), @($rt, $bt, 17),
|
|
@(($l + 2 * $b - 1), $t, 13), @($rt, ($bt - 2 * $b + 1), 17),
|
|
@($cx, $cy, 1)
|
|
)
|
|
# Record failures only after confirming these points used a stable window rect.
|
|
$results = foreach ($c in $cases) {
|
|
$got = [Win]::HitTest($h, $c[0], $c[1])
|
|
@{ ok = ($got -eq $c[2]); what = "$when hit test at ($($c[0]), $($c[1])): $($HT[$got]) ($got), want $($HT[$c[2]])" }
|
|
}
|
|
$after = Rect $h
|
|
if (-not $r.Equals($after)) {
|
|
if ($try -lt 3) {
|
|
Write-Host "$when : window rect changed during hit tests; retry $try of 2"
|
|
continue
|
|
}
|
|
Check $false "$when : window rect changed during all 3 hit-test passes"
|
|
return
|
|
}
|
|
Check ($b -ge 1) "$when : a resize border of $b px"
|
|
foreach ($result in $results) { Check $result.ok $result.what }
|
|
return
|
|
}
|
|
}
|
|
|
|
$port = 47901
|
|
$root = Join-Path $env:RUNNER_TEMP 'resize-smoke'
|
|
Remove-Item -Recurse -Force $root -ErrorAction SilentlyContinue
|
|
$settings = Join-Path ([Environment]::GetFolderPath('ApplicationData')) 'SolidCraft\data'
|
|
Remove-Item -Recurse -Force $settings -ErrorAction SilentlyContinue
|
|
$local = Join-Path $root 'local'
|
|
$crashes = Join-Path $root 'crashes'
|
|
New-Item -ItemType Directory -Force $settings, $local, $crashes | Out-Null
|
|
$token = -join ((1..64) | ForEach-Object { '{0:x}' -f (Get-Random -Maximum 16) })
|
|
|
|
$psi = New-Object System.Diagnostics.ProcessStartInfo
|
|
$psi.FileName = (Resolve-Path $Exe).Path
|
|
foreach ($a in @('--sample', '--control', "$port")) { [void]$psi.ArgumentList.Add($a) }
|
|
$psi.UseShellExecute = $false
|
|
$psi.RedirectStandardError = $true
|
|
$psi.RedirectStandardOutput = $true
|
|
$psi.Environment['LOCALAPPDATA'] = $local
|
|
$psi.Environment['SOLIDCRAFT_CRASH_DIR'] = $crashes
|
|
$psi.Environment['SOLIDCRAFT_CONTROL_TOKEN'] = $token
|
|
$p = [System.Diagnostics.Process]::Start($psi)
|
|
$stderr = $p.StandardError.ReadToEndAsync()
|
|
$stdout = $p.StandardOutput.ReadToEndAsync()
|
|
|
|
try {
|
|
# The window as soon as it shows (eframe creates it hidden and shows it after the first frame).
|
|
$h = [IntPtr]::Zero
|
|
$deadline = (Get-Date).AddSeconds(180)
|
|
while ($h -eq [IntPtr]::Zero -and (Get-Date) -lt $deadline -and -not $p.HasExited) {
|
|
$h = [Win]::MainWindow([uint32]$p.Id)
|
|
if ($h -eq [IntPtr]::Zero) { Start-Sleep -Milliseconds 20 }
|
|
}
|
|
if ($h -eq [IntPtr]::Zero) { throw "no window (exited: $($p.HasExited))" }
|
|
Write-Host "window: '$([Win]::Text($h))' class '$([Win]::Class($h))'"
|
|
CheckBorder $h 'first sight'
|
|
|
|
$client = $null
|
|
while (-not $client -and (Get-Date) -lt $deadline -and -not $p.HasExited) {
|
|
try { $client = New-Object System.Net.Sockets.TcpClient('127.0.0.1', $port) } catch { Start-Sleep -Milliseconds 500 }
|
|
}
|
|
if (-not $client) { throw "no control channel (exited: $($p.HasExited))" }
|
|
$client.ReceiveTimeout = 120000
|
|
$stream = $client.GetStream()
|
|
$writer = New-Object System.IO.StreamWriter($stream)
|
|
$writer.AutoFlush = $true
|
|
$reader = New-Object System.IO.StreamReader($stream)
|
|
$writer.WriteLine((@{ id = 1; token = $token; method = 'ui.screenshot'; params = @{ path = (Join-Path $root 'first.png') } } | ConvertTo-Json -Compress))
|
|
Write-Host "first frame: $($reader.ReadLine())"
|
|
|
|
# A known place and size that fits the runner's screen (physical px; the minimum is 960 x 600).
|
|
$sw = [Win]::GetSystemMetrics(0); $sh = [Win]::GetSystemMetrics(1)
|
|
Write-Host "screen: $sw x $sh"
|
|
[void][Win]::SetWindowPos($h, [IntPtr]::Zero, 20, 20, [Math]::Min(1000, $sw - 40), [Math]::Min(620, $sh - 140), 0x0014) # NOZORDER | NOACTIVATE
|
|
Start-Sleep -Milliseconds 500
|
|
CheckBorder $h 'restored'
|
|
|
|
# A real drag on the bottom edge, if this session takes mouse input.
|
|
$before = Rect $h
|
|
[void][Win]::SetForegroundWindow($h)
|
|
$x = [int](($before.Left + $before.Right) / 2); $y = $before.Bottom - 2
|
|
[void][Win]::SetCursorPos($x, $y)
|
|
$pt = New-Object Win+POINT; [void][Win]::GetCursorPos([ref]$pt)
|
|
if ($pt.X -ne $x -or $pt.Y -ne $y) {
|
|
Write-Host "skipped: the drag (this session doesn't move the pointer: at $($pt.X),$($pt.Y))"
|
|
} else {
|
|
Start-Sleep -Milliseconds 300
|
|
[Win]::mouse_event(0x0002, 0, 0, 0, [UIntPtr]::Zero) # LEFTDOWN
|
|
$grow = [Math]::Min(80, $sh - $y - 10)
|
|
for ($i = 1; $i -le 8; $i++) {
|
|
Start-Sleep -Milliseconds 40
|
|
[void][Win]::SetCursorPos($x, $y + [int]($grow * $i / 8))
|
|
[Win]::mouse_event(0x0001, 0, 0, 0, [UIntPtr]::Zero) # MOVE (relative 0: the position above)
|
|
}
|
|
Start-Sleep -Milliseconds 100
|
|
[Win]::mouse_event(0x0004, 0, 0, 0, [UIntPtr]::Zero) # LEFTUP
|
|
Start-Sleep -Milliseconds 500
|
|
$after = Rect $h
|
|
$dh = ($after.Bottom - $after.Top) - ($before.Bottom - $before.Top)
|
|
Check ($dh -ge $grow - 4 -and $after.Top -eq $before.Top) "dragging the bottom edge down $grow px resizes the window (height +$dh, top $($before.Top) -> $($after.Top))"
|
|
}
|
|
|
|
# Maximized: no resize border, the whole window is client area.
|
|
[void][Win]::ShowWindow($h, 3) # SW_MAXIMIZE
|
|
Start-Sleep -Milliseconds 500
|
|
if ([Win]::IsZoomed($h)) {
|
|
# The maximized window's rect overhangs the screen by the hidden frame (Windows' own
|
|
# frame answers there); the screen's left edge is where the pointer can be.
|
|
$r = Rect $h
|
|
$x = [Math]::Max($r.Left, 0) + 1
|
|
$got = [Win]::HitTest($h, $x, [int](($r.Top + $r.Bottom) / 2))
|
|
Check ($got -eq 1) "maximized ($($r.Left),$($r.Top) - $($r.Right),$($r.Bottom)), the screen's left edge is client area ($($HT[$got]))"
|
|
} else {
|
|
Check $false 'the window maximizes'
|
|
}
|
|
[void][Win]::ShowWindow($h, 9) # SW_RESTORE
|
|
Start-Sleep -Milliseconds 500
|
|
CheckBorder $h 'restored again'
|
|
|
|
$writer.WriteLine((@{ id = 2; method = 'app.quit'; params = @{ force = $true } } | ConvertTo-Json -Compress))
|
|
Write-Host "quit: $($reader.ReadLine())"
|
|
$client.Close()
|
|
if (-not $p.WaitForExit(60000)) { throw 'did not exit after app.quit' }
|
|
if ($p.ExitCode -ne 0) { throw ('exit code 0x{0:x}' -f $p.ExitCode) }
|
|
} catch {
|
|
$failures.Add($_.Exception.Message)
|
|
} finally {
|
|
if (-not $p.HasExited) { $p.Kill(); $p.WaitForExit() }
|
|
}
|
|
Write-Host $stderr.Result
|
|
if ($failures.Count -gt 0) { Write-Error ("resize border: " + ($failures -join '; ')) }
|
|
Write-Host 'PASS: resize border'
|