Files
solvecraft/harness/cpp/shim/nlib_crv_offset.cpp
T
bherbruck 2e0d65df7c port(nlib.crv_offset): N_CrvOffsetPtSampling (planar curve offset by point sampling)
Rust port in nurbs::crv_offset, C++ shim with an exact sample-count guard,
solidcore-ffi binding, difftest runner (55 .smc-derived fixtures + 1500
generated), all 1555 cases green, max_rel_err 0.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01V8ohWGLCzFPoZriCeSSero
2026-10-12 18:59:53 -04:00

177 lines
5.1 KiB
C++

// SPDX-License-Identifier: Apache-2.0
// difftest shim for unit `nlib.crv_offset`.
// Wraps upstream N_CrvOffsetPtSampling (source/SMLib/src/NL_CrvOffset.cpp).
//
// sc_nlib_crv_offset_eval(in, n_in, max_samples, out, cap, out_len): `in` holds a curve
// (n p m, n+1 control points x y z w, m+1 knots) then B[3] d deg tan par tol. `out`
// receives the status (0 = ok, else NL_ERROR.eno, cleared before the call; 1000 if the
// flag was set without a number), then on success the offset curve (n p m, used control
// points, used knots).
//
// Upstream casts the per-segment sample count ceil(f1 * gro) to NL_INDEX unchecked, so
// before the call the shim recomputes that count exactly as upstream does (same Bezier
// decomposition, N_CrvOffsetGetMax2ndDeriv on the unit-span segments) and returns
// SC_ERR_ARG when it is not finite or the total exceeds `max_samples`. The Rust wrapper
// validates the curve and parameters (crates/solidcore-ffi/src/units/nlib_crv_offset.rs).
#include "sc_shim.h"
#include <nurbs.h>
#include <NL_Globals.h>
#include <cmath>
#include <vector>
namespace
{
double nl_status(NL_FLAG err)
{
if (err == NL_NO)
return 0.0;
return NL_ERROR.eno != 0 ? (double)NL_ERROR.eno : 1000.0;
}
NL_CURVE* read_crv(const double* in, int64_t* at, NL_STACKS* S)
{
const double* d = in + *at;
NL_INDEX n = (NL_INDEX)d[0];
NL_DEGREE p = (NL_DEGREE)d[1];
NL_INDEX m = (NL_INDEX)d[2];
NL_CURVE* cur = N_AllocCrvAndArrays(n, p, m, S);
if (cur == NULL)
return NULL;
const double* c = d + 3;
NL_CPOINT* Pw;
NL_REAL* U;
N_CrvGetCPtsAndKnots(cur, &Pw, &U);
for (NL_INDEX i = 0; i <= n; i++)
{
Pw[i].x = c[0];
Pw[i].y = c[1];
Pw[i].z = c[2];
Pw[i].w = c[3];
c += 4;
}
for (NL_INDEX i = 0; i <= m; i++)
U[i] = *c++;
*at = (int64_t)(c - in);
return cur;
}
void dump_crv(std::vector<double>& o, NL_CURVE* cur)
{
NL_INDEX n, m;
NL_DEGREE p;
NL_CPOINT* Pw;
NL_REAL* U;
N_CrvGetCPtsDegreeAndKnots(cur, &n, &Pw, &p, &m, &U);
o.push_back((double)n);
o.push_back((double)p);
o.push_back((double)m);
for (NL_INDEX i = 0; i <= n; i++)
{
o.push_back(Pw[i].x);
o.push_back(Pw[i].y);
o.push_back(Pw[i].z);
o.push_back(Pw[i].w);
}
for (NL_INDEX i = 0; i <= m; i++)
o.push_back(U[i]);
}
// true when the sampling count of N_CrvOffsetPtSampling is safe (or never computed).
bool samples_ok(NL_CURVE* curP, NL_VECTOR B, NL_REAL d, NL_DEGREE deg, NL_REAL tol, double max_samples)
{
if (tol == 0.0)
return true; // NL_NUM_ERR before any sampling.
NL_REAL exp = (deg == 1) ? 0.5 : 0.34;
NL_REAL f1 = pow(1.0 / tol, exp);
NL_REAL f2 = 2.0 * (NL_REAL)deg;
if (!std::isfinite(f1))
return false;
if (N_VectorNormalizeRef(&B) == NL_YES)
return true; // fails before sampling.
NL_STACKS SL;
N_InitNurbs(&SL);
NL_CURVE** bez;
NL_INDEX k;
bool ok = true;
if (N_CrvDecomposeBez(curP, &bez, &k, &SL) == NL_NO)
{
double mu = 0.0;
for (NL_INDEX i = 0; i <= k; i++)
{
N_CrvReparamToInterval(bez[i], NL_UNITSPAN);
NL_REAL Muu;
if (N_CrvOffsetGetMax2ndDeriv(bez[i], d, B, &Muu) == NL_YES)
break; // fails before the cast.
NL_REAL num = 0.125 * Muu;
NL_REAL gro = NL_MAX(f2, sqrt(num));
NL_REAL del = ceil(f1 * gro);
if (!(del >= 0.0 && del <= max_samples))
{
ok = false;
break;
}
mu += del;
if (mu > max_samples)
{
ok = false;
break;
}
}
}
N_EndNurbs(&SL);
N_ErrClear();
return ok;
}
} // namespace
SC_EXPORT int32_t sc_nlib_crv_offset_eval(const double* in, int64_t n_in, double max_samples,
double* out, int64_t cap, int64_t* out_len)
{
(void)n_in;
SC_TRY
NL_STACKS S;
N_InitNurbs(&S);
std::vector<double> o;
int64_t at = 0;
int32_t rc = SC_OK;
NL_CURVE* cur = read_crv(in, &at, &S);
if (cur == NULL)
{
rc = SC_ERR_ARG;
}
else
{
const double* prm = in + at;
NL_VECTOR B;
B.x = prm[0];
B.y = prm[1];
B.z = prm[2];
NL_REAL d = prm[3];
NL_DEGREE deg = (NL_DEGREE)prm[4];
NL_FLAG tan = (NL_FLAG)prm[5];
NL_FLAG par = (NL_FLAG)prm[6];
NL_REAL tol = prm[7];
if (!samples_ok(cur, B, d, deg, tol, max_samples))
{
rc = SC_ERR_ARG;
}
else
{
NL_CURVE curQ;
N_CrvInitArrays(&curQ);
N_ErrClear();
NL_FLAG err = N_CrvOffsetPtSampling(cur, B, d, deg, tan, par, tol, &curQ, &S);
o.push_back(nl_status(err));
if (err == NL_NO)
dump_crv(o, &curQ);
}
}
N_EndNurbs(&S);
if (rc != SC_OK)
return rc;
return sc_copy_out(o.data(), (int64_t)o.size(), out, cap, out_len);
SC_CATCH
}