bherbruck a42407ac5c CI: clippy with the C++ feature; fix the lints it finds ...

The clippy job builds without the cpp feature, so the difftest unit runners
(registered only under difftest/cpp) were never linted. Add a clippy step to
the difftest job after the C++ reference build, using --features difftest/cpp
(which also enables solidcore-ffi/cpp; solidcore-ffi/cpp alone does not
compile the runners).

Fix the 9 lints it reports, with no allows and no change to generated inputs
or comparisons (reports byte-identical before and after):
- intersect_surface_tracer: assign_op_pattern, range_plus_one
- surface_surface_cache_p2: indexing_slicing, range_plus_one
- topology_brep_data: items_after_statements, let_and_return, doc_markdown,
  neg_cmp_op_on_partial_ord, indexing_slicing

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNGVDsEXPdxtFSUKma3wKs

2026-10-13 22:38:35 -04:00

..

workflows

CI: clippy with the C++ feature; fix the lints it finds

2026-10-13 22:38:35 -04:00