mirror of https://github.com/bherbruck/solidcraft.git synced 2026-11-07 04:12:15 +00:00

Files

T

selune 9e6e0b8df1 Render workspace: complete experimental ribbon, resources and effects integration (#5493 ) (#5494 )

* wip(render): reconcile completed material and image pipeline source with 0.20 (#5493)

Source-only integration reference for staged review, not a merge-ready aggregate.
Donor: 0xlillith/solidcraft@aea20b0115.
Upstream: 858e5995d6.

Retain original CPU/material contracts and explicit GPU donor provenance in
docs/render-materials-lab.md (#2067, #2191, #2780, #3306). Preserve released
format migrations and current navigation/startup/shell behavior. New saved
records use pending descriptors. The physical-card descriptor follows the
maintainer's material-engineering-cards naming request, with a legacy-lab
format-29 regression. Replace raw new panel hosts with shared containers.

Repository checks, complete workspace/all-target Clippy, and the independent
physical/resource authoring checks pass for this source. The fresh full local
CI invocation has reached test compilation and is not yet complete. Do not
transfer donor native output or prior test totals to this integration.

Generated review screenshots, video, package ZIP and machine logs remain at
the immutable personal evidence pin. Uncommitted geometric displacement is
backed up separately, not silently included. No kernel/vendor change, direct
main write, release or independent contributor-branch rewrite.

Co-authored-by: Christian Svensson <blue@cmd.nu>

* test(cli): pin the Compact camera-sample admission diagnostic (#5493)

The bounded request still refuses 1024x1024x64 samples before host initialization and writes no output. Update only the stale expected diagnostic to the existing Compact budget wording; production limits and code are unchanged. Exact-tree CLI regression suite: 14 passed, 0 failed. The full repository gate has been invoked separately and is not yet complete.

* Normalize UI container violation paths across platforms

Report repository-relative paths with forward slashes so diagnostics and the existing nested-package regression assertions agree on Windows and Unix. Keep the container detection rules unchanged.

Validation: official ui-containers gate and all seven focused xtask tests passed; rustfmt and diff checks passed. Only xtask/dependencies were compiled; no application build or heavy tests.
(cherry picked from commit 44b58d8e10)

* fix(render): preserve camera contracts and correct acceptance regressions (#5493)

Preserve Design view.apply semantics with a separate strict Render camera command. Retain existing translations when English-only aliases collide; add material-axis entries and camera-specific pitch labels. Compare complete validated engineering cards and retain job handles before cancellation.

Focused and native acceptance is pinned to tree f8a423b21f. Full CI has been invoked separately and is not claimed green. Landing follows the render integration policy in #5493.

* fix(render): resolve showcase licence and upstream resource hygiene (#5493)

Record SychPL's explicit MIT OR Apache-2.0 grant, retaining source/model bytes and the Ubuntu lettering notice. Remove 80 absent attribution rows, personal fork records, dead delivery attributes and three fork/resource-only workflows. Existing xtask assets now performs bounded offline hash checks and rejects orphan render attribution; no parallel draft CI or package installation. Original authoring reproduction remains explicit. Scoped xtask tests, assets, Clippy, formatting and prepared SELENE validation pass; no application or renderer-wide result is inferred.

* fix(render): align saved bounds and progressive sample resolution (#5493)

Address review r4364211669/r4364211677/r4364211681/r4364211691/r4364211695. Persisted light/frame domains respect the existing 1e9 document bound; related LED/rectangle/direction cases use the same bound. Workstation primary resolve shares the 4096 admission cap and film counters use checked conversions. Exact candidate: 485 CPU render tests, 21 render document tests and strict scoped Clippy pass, including positive boundary round trips and 2048/4096 end-to-end checkpoints. No released format/migration edits, relaxed test limits or full-stack acceptance claim.

* wip(render): isolate optional resources and harden sample handling (#5493)

Review work in progress: opt-in encoded render library with reproducible runtime catalog exports; native-only robust dependency through the workspace; checked bloom slices; per-sample point-light diagnostics; independent area-light spatial/film keys. Resource-module binaries in both configurations, generation, Cargo production feature graphs and attribution checks pass. Full engine/render regression and combined acceptance are pending: do not merge this donor as a constituent or treat scoped resource proof as runtime acceptance.

* fix(gpu): preserve donor allocations through the scope-safety repair (#5722)

Port the native-validated #5723 scope-cleanup correction into the experimental donor, retaining its adaptive, volume, aging, photographic and bloom allocations. Same reverse-drain helper and regression cases; the donor combination still needs its own compile/test gate and is not covered retroactively by render-base results.

* claim: #1369

* Reject unknown pending concepts after format folding (#1369)

* test(render): close bounded sampling and bloom review regressions (#5493)

Validate the optional-resource/lighting/dependency donor at its exact tree. Required Vulkan GPU 127/0/3; CPU renderer 487/0; engine Render 72/0; document render 21/0; lean library 7/0; strict scoped Clippy, assets/layers/lists/containers and lean-engine WASM pass. Preserve original failed controller/typing attempts. This is the draft donor/disposition source, not a replacement for constituent render PRs or final main acceptance.

* wip(render): preserve stable aging target validation candidate

Exact staged source from prior review work on donor 3b892eab5e. This is a recovery/review checkpoint, NOT accepted delivery. An actual command-path regression currently fails because the selected executor refuses ordered surface aging. No assertion, capability or admission limit is weakened. Native/UI/full combination acceptance remains pending. Saved/runtime split adds one pending descriptor and retains original file scope; no main/render branch is changed.

* test(render): preserve numeric setup intent at the admitted coordinate bound

Follow up jyviko review on #5494 without weakening the corrected saved-coordinate contract. The positive clicked fixture uses 1e9 instead of inadmissible 2e9; explicit out-of-range cases still refuse, and the full saved setup round-trips through JSON and the native container. Exact-source Render workspace 95/0 and strict all-target UI Clippy pass. This does not incorporate the separately failing stable-aging candidate or claim full current-render acceptance.

* test(render): use the real GPU executor for saved aging

Move successful native cold-reopen Check/Start coverage from the CPU-backed protocol fixture into the production GPU executor tests. Verify capture-index changes preserve the stable target and that enabling aging changes both PNG and raw EXR output. Retain explicit, allocation-free refusal coverage for executors without aging support. Production capabilities and admission checks are unchanged.

* fix(render): persist stable identities for targeted aging (#5493)

Separate saved RenderBodyTarget identities from captured mesh ordinals. Reject legacy ambiguous targets, resolve Check/Start after visibility changes and preserve native reopening, copies and undo. Unsupported executors still refuse; real AMD Vulkan regression completes saved aging after reordered capture.

Source tree 6b84c8ad passes document 23, engine Render 75, GPU effects 5 and Render UI 95 with no failures; scoped strict Clippy, WASM and repository gates pass. Fresh CLI/native reopen and clean/aged GPU exports pass with identical physical totals and inspected actual images. Whole current-render integration is separate.

* fix(render): reconcile combined CPU/GPU contracts on current upstream

Unify captured resources/status and CPU-vs-GPU request schemas after the real two-parent integration; remove obsolete duplicate Vulkan selector and retain combined platform-filter regression. Deduplicate only identical or superseded test definitions, retaining the stronger card metadata and reserved-executor assertions. No assertions, admission limits or feature refusals are weakened.

All targets of render dependencies, GPU, engine, UI, CLI and native app pass cargo check with raytrace-cpu and bundled-render-library at tree c70d00d1. Native executable tests and full current-source acceptance remain pending. This is a private integration rehearsal for subsequent constituent PRs, not an aggregate official render/main merge.

* test(render): retain one complete host lifetime regression set

Deduplicate byte-identical DropProbe/task-lifetime tests and retain the adapted environment/texture ownership regressions with every assertion and complete memory estimate. Keep the registered-geometry admission regression once; only struct field order differed. Replace a one-element diagnostic loop with its equivalent block, preserving all wrap/width assertions.

Test-only integration repair. Formatting and diff checks pass; refreshed executable validation is required. No production behavior, limits, assertions or ignores changed.

* fix(doc): recognize the proven format-29 card descriptor alias

Normalize only the historical format-29 physical-material-cards spelling, and only when material-engineering-cards is registered. Admission and migration de-duplication use the same identity. Unknown concepts, wrong versions and incapable readers still refuse before mutation. Six controlled-history Rust regressions and actual CLI migration/no-clobber acceptance pass. No version, released migration or CI changes. Refs #5793, #1369, #5493.

* test(render): preserve grounding refusal before explicit instance moves

Update the two Render binding fixtures for upstream first-occurrence grounding. Verify grounded movement refuses without changing document/history, then explicitly unground through the public command before the intended move. Retain every target, resource, copy and persistence assertion. Refs #5493.

---------

Co-authored-by: Christian Svensson <blue@cmd.nu>
Co-authored-by: Victor Santos Oliveira <56417388+Vittuu@users.noreply.github.com>
Co-authored-by: cfaulkingham <colin.faulkingham@gmail.com>

2026-10-24 14:21:59 +00:00

8.3 KiB

Raw Blame History

Source review and interpretation limits

Research date: 2026-10-22. Exact URLs and source locators are stored in sources.json; each numerical record in profiles.json points to one of those references. Selection and normalization are original work. Supplier publications retain their own rights and are not bundled or relicensed.

Evidence levels

The profiles distinguish typical values, published intervals, lower/upper bounds and explicitly calculated values. A manufacturer datasheet is evidence for the named grade and stated test, not identification of an object from its rendering. No record claims certified design allowables. A public URL and retrieval date are traceability metadata, not a signed source archive or proof that the URL can never change. Verify the relevant current datasheet and certificate before engineering use.

Missing temperature, strain rate, specimen orientation or test method is marked unknown. Published crosshead speed is retained as speed, not guessed strain rate. A source's plus/minus notation is preserved without inventing its confidence level.

Conflicts and exclusions retained for review

Source or material	Treatment
Sandmeyer 304/304L	Use the identified main physical/plate tables; do not average different FAQ values. Typical plate strengths are not minimum-grade specifications.
Elgiloy Nickel 200	Keep the cited metric expansion value; a conflicting imperial entry is not used to create a second inconsistent constant.
SAC305 solder	A field with resistivity units but a conductivity label is excluded rather than silently reinterpreted. Solid alloy data does not identify flux-bearing paste.
PolyLite ABS	Product-page and wiki densities disagree, so density remains unresolved. The suspect modulus unit is not repaired by intuition. The retained XY/Z strengths remain directional.
Isola 370HR	The modulus row cites a flexural test; retain it as flexural modulus, not a complete orthotropic elastic tensor. Dielectric-strength unit entries are not silently reconciled.
Fused silica	A softening value is not used as a melting point; uncertain or inconsistent auxiliary optical entries were excluded.
Amorim TPS	Use the cited aerospace table rather than mix differing values from another brand page. Room-condition reference properties do not prove ablation performance.

Every exclusion stays explicit in the relevant profile. Reference candidates that would imply wrong chemistry were removed during association review: HDPE is not a vinyl-flooring default; a glass profile is not a polymer interlayer; MDF is not an unspecified insulation core. Wrought 6061 may only be an explicitly labelled comparison for an unidentified casting, never a cast-alloy strength certificate.

Materials requiring special treatment

Wood and engineered panels

USDA clear-wood results identify species, moisture and test orientation. Clear specimen means are not graded structural-lumber design values. Their bending modulus is not renamed tensile modulus or combined with an invented Poisson ratio. The specific-gravity basis is retained. For the cited 12% moisture rows, wet mass at the stated specimen volume is derived as SG * 1000 * (1 + 0.12) kg/m3, with 1000 kg/m3 explicitly identified as the water-reference convention. That formula is recorded, checked and not extrapolated to another moisture content.

Birch specimen properties are a veneer/constituent reference, not effective plywood properties. Panel layup, glue, moisture, thickness class and density must be known. MEDITE PREMIER >12 to 19 mm values are bounded panel specifications; the missing board density is not invented. Cork's MDFACADE product name is not confused with medium-density fibreboard.

Printing and composites

Printed PLA/ABS coupon directions and reported spreads remain distinct. Feedstock solid density is not an infilled-part envelope density. SLS PA12 is not automatically a valid MJF material model. TPU density intervals remain intervals.

AS4 fibre data describes a constituent. AS4/8552 unidirectional laminate data requires the stated fibre volume, cure and orientation. Neither describes a woven twill part simply because its texture resembles carbon fibre. The woven aramid surface remains unresolved until a particular fibre/resin/layup is selected.

Electronics, elastomers and coatings

FR-4 dielectric values retain frequency, and expansion retains axis and thermal regime. A solder-mask appearance is not a single FR-4 property card for the whole board. Copper thickness, laminate construction, mask, components and interfaces need separate treatment.

Dragon Skin 20's stress at 100% extension is not Young modulus. A reference casting silicone is not automatically qualified for cable insulation, optical lenses or space seals. Filled potting and IC mould compounds need their actual filler/cure recipe; unfilled casting epoxy is only a labelled comparison.

AZ-93 thermal emittance and solar absorptance retain their coating context and thickness condition. They are not visible RGB, material emission strength or a bulk heat capacity. A coating's nominal application thickness is not an automatic thickness assignment to a CAD model.

Lunar-like resources

The four Exolith datasets are terrestrial laboratory analogues. Grain density, packing density, void ratio, porosity and apparatus-dependent repose angle remain separate. They do not identify a geological site, vacuum condition, internal friction law or reduced-gravity mechanical response. Rock concepts are not assigned loose-soil density merely to increase numeric coverage.

Review backlog

The 294 concepts without an applicable named reference need a selected recipe, grade or multi-material construction. The 306 with candidates still require review of their stated relation and conditions; some references are constituents or explicit comparisons, not effective-property defaults. No numerical completeness percentage is derived from these association counts.

Further evidence is especially needed for actual paint/cure stacks, woven aramid laminates, named glass/polymer optical grades, flexible-cable formulations, filled thermal interfaces, resin systems, foams, friction materials and aerospace-qualified processes. Temperature-dependent curves, fatigue, creep, damping, outgassing and failure envelopes should be added as documented quantities/models, not filled with uncited family averages.

Added source review — 2026-10-22

Eight additional primary supplier/manufacturer references add 43 selected records, bringing the dataset to 59 profiles, 50 source records and 416 numerical records. All 48 authored surfaces now have an explicit reference-candidate relationship. This does not make the 600 concepts numerically complete or identify their actual manufacturing recipe.

PMMA sheet preserves published intervals for stiffness, Poisson ratio, heat capacity, thermal expansion/conductivity and electrical resistivity; no midpoint is selected for elasticity. Rigid PVC stock data does not identify plasticized cable insulation. Kevlar 49 axial fibre data does not establish cured laminate or meta-aramid paper/honeycomb properties; those mappings remain separate.

Sikafloor 161 HC compressive and flexural data retain the 28-day cure at 23 C; its Shore D datum retains the 7-day cure. The manufacturer's mixed-liquid density is not assigned to the cured resin. UV22 retains two different glass-transition ranges, distinguishing UV-only cure from thermal post-cure. Its refractive index is not a spectral model or certified optical transmission curve.

C71 Speedline, Stoving Enamel Hammer and Acrythane SC601 remain named coating candidates with only the published temperature and/or coverage-basis dry-film thickness recorded. Temperature statements without duration are upper-bound manufacturer references, not continuous-use allowables. No cured density, modulus, strength or film mass is inferred from paint package weights, liquid densities, nominal coverage, visual roughness or colour. Those unknowns remain visible.

The inspected Kuhn PVC page contains blank mechanical cells and a hardness row with inconsistent units. Neither is imported. Public reference metadata preserves the source relationship without claiming that an openly accessible supplier page has a permissive dataset licence. No PDF, table layout, prose, logo or image from those publishers is included in this repository.

8.3 KiB Raw Blame History