selune
9e6e0b8df1
* wip(render): reconcile completed material and image pipeline source with 0.20 (#5493) Source-only integration reference for staged review, not a merge-ready aggregate. Donor: 0xlillith/solidcraft@aea20b0115. Upstream:858e5995d6. Retain original CPU/material contracts and explicit GPU donor provenance in docs/render-materials-lab.md (#2067, #2191, #2780, #3306). Preserve released format migrations and current navigation/startup/shell behavior. New saved records use pending descriptors. The physical-card descriptor follows the maintainer's material-engineering-cards naming request, with a legacy-lab format-29 regression. Replace raw new panel hosts with shared containers. Repository checks, complete workspace/all-target Clippy, and the independent physical/resource authoring checks pass for this source. The fresh full local CI invocation has reached test compilation and is not yet complete. Do not transfer donor native output or prior test totals to this integration. Generated review screenshots, video, package ZIP and machine logs remain at the immutable personal evidence pin. Uncommitted geometric displacement is backed up separately, not silently included. No kernel/vendor change, direct main write, release or independent contributor-branch rewrite. Co-authored-by: Christian Svensson <blue@cmd.nu> * test(cli): pin the Compact camera-sample admission diagnostic (#5493) The bounded request still refuses 1024x1024x64 samples before host initialization and writes no output. Update only the stale expected diagnostic to the existing Compact budget wording; production limits and code are unchanged. Exact-tree CLI regression suite: 14 passed, 0 failed. The full repository gate has been invoked separately and is not yet complete. * Normalize UI container violation paths across platforms Report repository-relative paths with forward slashes so diagnostics and the existing nested-package regression assertions agree on Windows and Unix. Keep the container detection rules unchanged. Validation: official ui-containers gate and all seven focused xtask tests passed; rustfmt and diff checks passed. Only xtask/dependencies were compiled; no application build or heavy tests. (cherry picked from commit44b58d8e10) * fix(render): preserve camera contracts and correct acceptance regressions (#5493) Preserve Design view.apply semantics with a separate strict Render camera command. Retain existing translations when English-only aliases collide; add material-axis entries and camera-specific pitch labels. Compare complete validated engineering cards and retain job handles before cancellation. Focused and native acceptance is pinned to treef8a423b21f. Full CI has been invoked separately and is not claimed green. Landing follows the render integration policy in #5493. * fix(render): resolve showcase licence and upstream resource hygiene (#5493) Record SychPL's explicit MIT OR Apache-2.0 grant, retaining source/model bytes and the Ubuntu lettering notice. Remove 80 absent attribution rows, personal fork records, dead delivery attributes and three fork/resource-only workflows. Existing xtask assets now performs bounded offline hash checks and rejects orphan render attribution; no parallel draft CI or package installation. Original authoring reproduction remains explicit. Scoped xtask tests, assets, Clippy, formatting and prepared SELENE validation pass; no application or renderer-wide result is inferred. * fix(render): align saved bounds and progressive sample resolution (#5493) Address review r4364211669/r4364211677/r4364211681/r4364211691/r4364211695. Persisted light/frame domains respect the existing 1e9 document bound; related LED/rectangle/direction cases use the same bound. Workstation primary resolve shares the 4096 admission cap and film counters use checked conversions. Exact candidate: 485 CPU render tests, 21 render document tests and strict scoped Clippy pass, including positive boundary round trips and 2048/4096 end-to-end checkpoints. No released format/migration edits, relaxed test limits or full-stack acceptance claim. * wip(render): isolate optional resources and harden sample handling (#5493) Review work in progress: opt-in encoded render library with reproducible runtime catalog exports; native-only robust dependency through the workspace; checked bloom slices; per-sample point-light diagnostics; independent area-light spatial/film keys. Resource-module binaries in both configurations, generation, Cargo production feature graphs and attribution checks pass. Full engine/render regression and combined acceptance are pending: do not merge this donor as a constituent or treat scoped resource proof as runtime acceptance. * fix(gpu): preserve donor allocations through the scope-safety repair (#5722) Port the native-validated #5723 scope-cleanup correction into the experimental donor, retaining its adaptive, volume, aging, photographic and bloom allocations. Same reverse-drain helper and regression cases; the donor combination still needs its own compile/test gate and is not covered retroactively by render-base results. * claim: #1369 * Reject unknown pending concepts after format folding (#1369) * test(render): close bounded sampling and bloom review regressions (#5493) Validate the optional-resource/lighting/dependency donor at its exact tree. Required Vulkan GPU 127/0/3; CPU renderer 487/0; engine Render 72/0; document render 21/0; lean library 7/0; strict scoped Clippy, assets/layers/lists/containers and lean-engine WASM pass. Preserve original failed controller/typing attempts. This is the draft donor/disposition source, not a replacement for constituent render PRs or final main acceptance. * wip(render): preserve stable aging target validation candidate Exact staged source from prior review work on donor3b892eab5e. This is a recovery/review checkpoint, NOT accepted delivery. An actual command-path regression currently fails because the selected executor refuses ordered surface aging. No assertion, capability or admission limit is weakened. Native/UI/full combination acceptance remains pending. Saved/runtime split adds one pending descriptor and retains original file scope; no main/render branch is changed. * test(render): preserve numeric setup intent at the admitted coordinate bound Follow up jyviko review on #5494 without weakening the corrected saved-coordinate contract. The positive clicked fixture uses 1e9 instead of inadmissible 2e9; explicit out-of-range cases still refuse, and the full saved setup round-trips through JSON and the native container. Exact-source Render workspace 95/0 and strict all-target UI Clippy pass. This does not incorporate the separately failing stable-aging candidate or claim full current-render acceptance. * test(render): use the real GPU executor for saved aging Move successful native cold-reopen Check/Start coverage from the CPU-backed protocol fixture into the production GPU executor tests. Verify capture-index changes preserve the stable target and that enabling aging changes both PNG and raw EXR output. Retain explicit, allocation-free refusal coverage for executors without aging support. Production capabilities and admission checks are unchanged. * fix(render): persist stable identities for targeted aging (#5493) Separate saved RenderBodyTarget identities from captured mesh ordinals. Reject legacy ambiguous targets, resolve Check/Start after visibility changes and preserve native reopening, copies and undo. Unsupported executors still refuse; real AMD Vulkan regression completes saved aging after reordered capture. Source tree6b84c8adpasses document 23, engine Render 75, GPU effects 5 and Render UI 95 with no failures; scoped strict Clippy, WASM and repository gates pass. Fresh CLI/native reopen and clean/aged GPU exports pass with identical physical totals and inspected actual images. Whole current-render integration is separate. * fix(render): reconcile combined CPU/GPU contracts on current upstream Unify captured resources/status and CPU-vs-GPU request schemas after the real two-parent integration; remove obsolete duplicate Vulkan selector and retain combined platform-filter regression. Deduplicate only identical or superseded test definitions, retaining the stronger card metadata and reserved-executor assertions. No assertions, admission limits or feature refusals are weakened. All targets of render dependencies, GPU, engine, UI, CLI and native app pass cargo check with raytrace-cpu and bundled-render-library at treec70d00d1. Native executable tests and full current-source acceptance remain pending. This is a private integration rehearsal for subsequent constituent PRs, not an aggregate official render/main merge. * test(render): retain one complete host lifetime regression set Deduplicate byte-identical DropProbe/task-lifetime tests and retain the adapted environment/texture ownership regressions with every assertion and complete memory estimate. Keep the registered-geometry admission regression once; only struct field order differed. Replace a one-element diagnostic loop with its equivalent block, preserving all wrap/width assertions. Test-only integration repair. Formatting and diff checks pass; refreshed executable validation is required. No production behavior, limits, assertions or ignores changed. * fix(doc): recognize the proven format-29 card descriptor alias Normalize only the historical format-29 physical-material-cards spelling, and only when material-engineering-cards is registered. Admission and migration de-duplication use the same identity. Unknown concepts, wrong versions and incapable readers still refuse before mutation. Six controlled-history Rust regressions and actual CLI migration/no-clobber acceptance pass. No version, released migration or CI changes. Refs #5793, #1369, #5493. * test(render): preserve grounding refusal before explicit instance moves Update the two Render binding fixtures for upstream first-occurrence grounding. Verify grounded movement refuses without changing document/history, then explicitly unground through the public command before the intended move. Retain every target, resource, copy and persistence assertion. Refs #5493. --------- Co-authored-by: Christian Svensson <blue@cmd.nu> Co-authored-by: Victor Santos Oliveira <56417388+Vittuu@users.noreply.github.com> Co-authored-by: cfaulkingham <colin.faulkingham@gmail.com>
4.7 KiB
Runtime surface patterns for the opaque CPU preview
raytrace.surface_effects is an optional bounded runtime request field. Each
entry names one uniquely resolved captured body, an explicit right-handed world
frame in millimetres, three positive repeats in millimetres, roughness amplitude,
and bump amplitude in millimetres. No field is saved into the design, native file,
physical material, texture catalog, or appearance preset.
The original periodic field changes only the opaque surface roughness and shading normal. It does not change vertices, geometric normals, intersections, bounding boxes, body mass, volume, inertia, or shadow occlusion geometry. This is a periodic preview field; it does not load a texture or displace a surface.
Consumer contract
At most 32 effects and reserved slots are admitted. Names are 1–256 UTF-8 bytes, without control characters, and must resolve to exactly one captured mesh. The frame must be finite and orthonormal with positive handedness. Repeats are within 0.001–1,000,000 mm; roughness amplitude is within 0–1; bump amplitude is within 0–1,000 mm, with a maximum analytic gradient L1 bound of 4. Sampling beyond the world/periodic precision bounds refuses. Duplicate and ambiguous selectors, explicit JSON null, nonfinite values, and oversized capacities refuse.
Absent effects preserve the existing path. An explicit empty list stays distinct in the request. Zero-amplitude entries are validated but excluded from the prepared scan and preserve the completed image bytes. Dynamic name/vector capacities in both task options copies and the prepared vector are included in the existing admission sum; the retained request uses its original host budget lease and remains accounted after frame eviction or while handles are held.
The current image consumer scans one prepared binding per continuation and checks cancel/work before mutating the cursor. A completed selection precedes every lighting stage. Each directional, point/spot, rectangular/LED, HDR and isotropic reflection consumer receives the same changed surface and shading normal through the shared hit contract. Original geometric normals still govern ray offsets, visibility and emission sidedness. Emission is added through the existing path throughput and receives no new direct-light sampling behavior.
The state resets at each reflected hit and each new primary sample. Fixed-primary AA reuse is valid only after the effect scan and all shading stages have finished. S/R sampling, sample denominators, coverage, linear accumulation and the final display transform remain in the existing consumer. No alternate pixel encoder, renderer, timer, or host pool is introduced. Public steps retain the four-work-unit bound and existing task/job memory caps.
A nonidentity effect on a body selected for certified planar anisotropy refuses: that model's orientation/rough-axis contract does not yet include these fields. Identity effects remain allowed there. The integrated CPU dielectric consumer also refuses nonidentity effects on its optical boundaries before transport; Snell/Fresnel keeps the original geometric normal. An existing clear-coat layer is preserved when changing substrate roughness for direct lighting. Selecting a coated body for CPU reflection, anisotropy or dielectric transport refuses until a matching layered transport estimator is available.
UI and validation scope
This consumer change admits the field through the existing shared runtime request and documents it in engine preflight. The current visible image controls continue to refuse unexposed effect options. The separately recovered surface/emission editor needs its own port and native acceptance before visible controls can be claimed.
The recovered original source checkpoint authored five math/JSON tests, two completed-image/admission tests, and a host lease lifecycle test. Those original tests are retained. The current port adds strict name/capacity and aggregate lease checks; all analytic-light/HDR combinations against an equivalent constant shared surface; mirror/rough reflection through an emitting secondary hit; a real 32-binding scan with cancellation/work exhaustion; anisotropy overlap refusal; and AA ordered-prefix/coverage/PNG/quantum checks. Existing malformed AA completion cases are retained and extended for surface state.
These are source contracts and written regressions. The recovered checkpoint and this scratch port have not been compiled or executed in this review. Qualification requires the exact candidate's formatting, target layout bound, render CPU ON/OFF tests, engine/UI contracts, Clippy, wasm, actual full project CI, and any newly exposed visible/native flow. Historical unrelated focal successes or full-CI failures remain attached to their original source revisions; they do not qualify this port.