* wip(render): reconcile completed material and image pipeline source with 0.20 (#5493) Source-only integration reference for staged review, not a merge-ready aggregate. Donor: 0xlillith/solidcraft@aea20b0115. Upstream:858e5995d6. Retain original CPU/material contracts and explicit GPU donor provenance in docs/render-materials-lab.md (#2067, #2191, #2780, #3306). Preserve released format migrations and current navigation/startup/shell behavior. New saved records use pending descriptors. The physical-card descriptor follows the maintainer's material-engineering-cards naming request, with a legacy-lab format-29 regression. Replace raw new panel hosts with shared containers. Repository checks, complete workspace/all-target Clippy, and the independent physical/resource authoring checks pass for this source. The fresh full local CI invocation has reached test compilation and is not yet complete. Do not transfer donor native output or prior test totals to this integration. Generated review screenshots, video, package ZIP and machine logs remain at the immutable personal evidence pin. Uncommitted geometric displacement is backed up separately, not silently included. No kernel/vendor change, direct main write, release or independent contributor-branch rewrite. Co-authored-by: Christian Svensson <blue@cmd.nu> * test(cli): pin the Compact camera-sample admission diagnostic (#5493) The bounded request still refuses 1024x1024x64 samples before host initialization and writes no output. Update only the stale expected diagnostic to the existing Compact budget wording; production limits and code are unchanged. Exact-tree CLI regression suite: 14 passed, 0 failed. The full repository gate has been invoked separately and is not yet complete. * Normalize UI container violation paths across platforms Report repository-relative paths with forward slashes so diagnostics and the existing nested-package regression assertions agree on Windows and Unix. Keep the container detection rules unchanged. Validation: official ui-containers gate and all seven focused xtask tests passed; rustfmt and diff checks passed. Only xtask/dependencies were compiled; no application build or heavy tests. (cherry picked from commit44b58d8e10) * fix(render): preserve camera contracts and correct acceptance regressions (#5493) Preserve Design view.apply semantics with a separate strict Render camera command. Retain existing translations when English-only aliases collide; add material-axis entries and camera-specific pitch labels. Compare complete validated engineering cards and retain job handles before cancellation. Focused and native acceptance is pinned to treef8a423b21f. Full CI has been invoked separately and is not claimed green. Landing follows the render integration policy in #5493. * fix(render): resolve showcase licence and upstream resource hygiene (#5493) Record SychPL's explicit MIT OR Apache-2.0 grant, retaining source/model bytes and the Ubuntu lettering notice. Remove 80 absent attribution rows, personal fork records, dead delivery attributes and three fork/resource-only workflows. Existing xtask assets now performs bounded offline hash checks and rejects orphan render attribution; no parallel draft CI or package installation. Original authoring reproduction remains explicit. Scoped xtask tests, assets, Clippy, formatting and prepared SELENE validation pass; no application or renderer-wide result is inferred. * fix(render): align saved bounds and progressive sample resolution (#5493) Address review r4364211669/r4364211677/r4364211681/r4364211691/r4364211695. Persisted light/frame domains respect the existing 1e9 document bound; related LED/rectangle/direction cases use the same bound. Workstation primary resolve shares the 4096 admission cap and film counters use checked conversions. Exact candidate: 485 CPU render tests, 21 render document tests and strict scoped Clippy pass, including positive boundary round trips and 2048/4096 end-to-end checkpoints. No released format/migration edits, relaxed test limits or full-stack acceptance claim. * wip(render): isolate optional resources and harden sample handling (#5493) Review work in progress: opt-in encoded render library with reproducible runtime catalog exports; native-only robust dependency through the workspace; checked bloom slices; per-sample point-light diagnostics; independent area-light spatial/film keys. Resource-module binaries in both configurations, generation, Cargo production feature graphs and attribution checks pass. Full engine/render regression and combined acceptance are pending: do not merge this donor as a constituent or treat scoped resource proof as runtime acceptance. * fix(gpu): preserve donor allocations through the scope-safety repair (#5722) Port the native-validated #5723 scope-cleanup correction into the experimental donor, retaining its adaptive, volume, aging, photographic and bloom allocations. Same reverse-drain helper and regression cases; the donor combination still needs its own compile/test gate and is not covered retroactively by render-base results. * claim: #1369 * Reject unknown pending concepts after format folding (#1369) * test(render): close bounded sampling and bloom review regressions (#5493) Validate the optional-resource/lighting/dependency donor at its exact tree. Required Vulkan GPU 127/0/3; CPU renderer 487/0; engine Render 72/0; document render 21/0; lean library 7/0; strict scoped Clippy, assets/layers/lists/containers and lean-engine WASM pass. Preserve original failed controller/typing attempts. This is the draft donor/disposition source, not a replacement for constituent render PRs or final main acceptance. * wip(render): preserve stable aging target validation candidate Exact staged source from prior review work on donor3b892eab5e. This is a recovery/review checkpoint, NOT accepted delivery. An actual command-path regression currently fails because the selected executor refuses ordered surface aging. No assertion, capability or admission limit is weakened. Native/UI/full combination acceptance remains pending. Saved/runtime split adds one pending descriptor and retains original file scope; no main/render branch is changed. * test(render): preserve numeric setup intent at the admitted coordinate bound Follow up jyviko review on #5494 without weakening the corrected saved-coordinate contract. The positive clicked fixture uses 1e9 instead of inadmissible 2e9; explicit out-of-range cases still refuse, and the full saved setup round-trips through JSON and the native container. Exact-source Render workspace 95/0 and strict all-target UI Clippy pass. This does not incorporate the separately failing stable-aging candidate or claim full current-render acceptance. * test(render): use the real GPU executor for saved aging Move successful native cold-reopen Check/Start coverage from the CPU-backed protocol fixture into the production GPU executor tests. Verify capture-index changes preserve the stable target and that enabling aging changes both PNG and raw EXR output. Retain explicit, allocation-free refusal coverage for executors without aging support. Production capabilities and admission checks are unchanged. * fix(render): persist stable identities for targeted aging (#5493) Separate saved RenderBodyTarget identities from captured mesh ordinals. Reject legacy ambiguous targets, resolve Check/Start after visibility changes and preserve native reopening, copies and undo. Unsupported executors still refuse; real AMD Vulkan regression completes saved aging after reordered capture. Source tree6b84c8adpasses document 23, engine Render 75, GPU effects 5 and Render UI 95 with no failures; scoped strict Clippy, WASM and repository gates pass. Fresh CLI/native reopen and clean/aged GPU exports pass with identical physical totals and inspected actual images. Whole current-render integration is separate. * fix(render): reconcile combined CPU/GPU contracts on current upstream Unify captured resources/status and CPU-vs-GPU request schemas after the real two-parent integration; remove obsolete duplicate Vulkan selector and retain combined platform-filter regression. Deduplicate only identical or superseded test definitions, retaining the stronger card metadata and reserved-executor assertions. No assertions, admission limits or feature refusals are weakened. All targets of render dependencies, GPU, engine, UI, CLI and native app pass cargo check with raytrace-cpu and bundled-render-library at treec70d00d1. Native executable tests and full current-source acceptance remain pending. This is a private integration rehearsal for subsequent constituent PRs, not an aggregate official render/main merge. * test(render): retain one complete host lifetime regression set Deduplicate byte-identical DropProbe/task-lifetime tests and retain the adapted environment/texture ownership regressions with every assertion and complete memory estimate. Keep the registered-geometry admission regression once; only struct field order differed. Replace a one-element diagnostic loop with its equivalent block, preserving all wrap/width assertions. Test-only integration repair. Formatting and diff checks pass; refreshed executable validation is required. No production behavior, limits, assertions or ignores changed. * fix(doc): recognize the proven format-29 card descriptor alias Normalize only the historical format-29 physical-material-cards spelling, and only when material-engineering-cards is registered. Admission and migration de-duplication use the same identity. Unknown concepts, wrong versions and incapable readers still refuse before mutation. Six controlled-history Rust regressions and actual CLI migration/no-clobber acceptance pass. No version, released migration or CI changes. Refs #5793, #1369, #5493. * test(render): preserve grounding refusal before explicit instance moves Update the two Render binding fixtures for upstream first-occurrence grounding. Verify grounded movement refuses without changing document/history, then explicitly unground through the public command before the intended move. Retain every target, resource, copy and persistence assertion. Refs #5493. --------- Co-authored-by: Christian Svensson <blue@cmd.nu> Co-authored-by: Victor Santos Oliveira <56417388+Vittuu@users.noreply.github.com> Co-authored-by: cfaulkingham <colin.faulkingham@gmail.com>
10 KiB
CPU controls in the Render workspace
This incremental panel is built on advanced CPU source tree
6e5db1e64376164878918eb68f1e5b311740afcd. It prepares the same existing
render.preflight and render.start commands. It does not add a renderer, material asset or rendering dependency. The subsequent
numeric setup unit persists the portable subset through RenderSetup.job; see
workspace settings.
Choose CPU ray tracing in Render. Three collapsible sections provide the following controls; the existing AA 1/4/16, lighting presets, shadows and exposure remain available in Single image sampling mode.
Progressive CPU sampling
CPU sampling mode → CPU progressive accumulates samples of the existing CPU integrator. Set samples per pixel from 1 to 64 and the separate CPU sampling seed. Selecting the mode explicitly chooses one primary sample per pass; returning to Single image restores the AA selector without discarding lights or HDR controls. This is camera sampling of the existing integrator, not diffuse global illumination, adaptive sampling or CPU denoising.
The initial progressive path accepts isotropic opaque surfaces and the supported directional, point and spot lighting. Selected reflections require one reflection sample. Area lights, LEDs, dielectric overrides and anisotropy must use Single image; switching modes never silently removes these inputs. Check and Start report an incompatible combination through the same request validation.
Admission allows at most 1,048,576 pixels, dimensions up to 4096, and 16,777,216 pixel × sample evaluations. For example, 1024 × 1024 supports 16 SPP, whereas 64 SPP requires at most 262,144 pixels. Increasing SPP or loading a setup never changes its dimensions automatically. If needed, the panel displays a Use the largest size at this aspect: W × H action; only clicking it resizes the draft. Save applies the same numeric limits without requiring a renderer and leaves invalid drafts intact. Traversal, sampling and image encoding also share the backend's cumulative work budget.
The result canvas shows provisional PNG checkpoints after 1, 2, 4, … samples, before the requested final count. A provisional label includes its SPP and checkpoint sequence; the job identity and captured revision remain unchanged. Checkpoint updates reuse the current pan/zoom. Completion replaces the preview with its final image; cancellation or failure removes the preview and returns to the previous completed result with the same framing. Export final PNG always exports a completed frame, even while a different provisional image is visible. With no completed frame, export remains disabled. The UI keeps one decoded provisional texture and metadata, not additional retained HDR/PNG buffers.
CpuJob.progressive persists the selected sample count and seed. Its absence or
null keeps Single image mode. Save As, Reload, setup switching and design reopen
preserve this option together with embedded HDR, nonedited numeric fields and the
setup's single exposure. The runtime CPU request nests it under
raytrace.progressive; the top-level progressive: true continues to select GPU
path tracing.
CPU controls
| Section | Controls | Runtime limits |
|---|---|---|
| Reflections | Visible body picker and filter, Off / Mirror / Rough, reflection depth and samples | At most 64 exact body names; 1–8 bounces; 1–64 reflection samples. Rough uses each body's existing opaque surface. |
| Environment | None, constant linear RGB radiance, or a checked/embedded Radiance HDR; intensity, HDR rotation and sampling | Intensity 0–64; RGB 0–1; finite rotation within ±1,000,000 radians (displayed as degrees); HDR samples 1/4/16/64. |
| Lights | Preset lighting or custom directional lights; additional point lights | At most eight directional and eight point lights; nonzero directions; linear RGB 0–1 and intensity 0–64. |
Numeric lighting, AA, shadows and constant-environment values are saved with the active CPU method. Exposure uses the setup's one exposure field. Checked HDR bytes and their controls can be embedded through the engine's atomic capture command; body reflection bindings still cause Save to refuse a full job without discarding those inputs. None of these controls changes a body's physical material, geometry or mass. Raster CPU and GPU requests omit the CPU panel's options. Switching methods retains local numeric drafts; Reload or choosing another setup replaces them with the saved active method. Only the selected method's schema is sent.
Body identity and validation
The picker lists visible evaluated bodies and narrows long lists with a filter; it shows at most 256 rows per opening. Empty names, control characters and names longer than 128 UTF-8 bytes cannot be selected. Duplicate visible names and stale model evaluation are refused.
A reflection selection records its document pointer, scene revision and the visible body's ordinal, creator feature and component. Check and Start refuse a binding after a scene change. Confirm this body can refresh the revision only when the same target still occupies the selected identity. If another body has reused its name, remove the old selection and select the desired body explicitly. This prevents a name-only runtime selector from silently following a replacement. The engine still performs final capture and surface compatibility validation.
CPU reflections do not implement a general layered clear-coat transport model. The engine rejects a coated body or face selected for an incompatible reflection path. This panel does not claim diffuse global illumination, caustics or a general glass renderer.
Environment capture
Constant environment supplies secondary reflected/transmitted radiance. It
is not direct diffuse lighting and does not replace the image background.
HDR uses the CPU environment contract: Radiance .hdr, 2:1 panorama, at most
2048 × 1024 pixels and 16 MiB of source bytes, with explicit supported sRGB/D65
primaries. EXR and files without those primaries are refused. Selected rough
reflectors with HDR must meet the engine's fully metallic body/face constraints.
The picker uses the application's existing file dialog. A delayed answer is
accepted only by the same document, revision, setup, method and input selection.
Selecting a file runs render.hdr.inspect; typed paths require Check HDR file.
This checks the full bounded stream without a renderer or document mutation and
records its digest and metadata. Request construction itself does not read files.
Check, Start and Save send the same expected digest, so a changed source
is rejected until an explicit recheck. Cancellation and inspection failure retain
the prior selection. Once a job is captured, later file changes cannot alter its
pixels or export.
Save Setup uses render.settings.capture_hdr for a checked local source, saving
the immutable bytes and complete setup in one undo step. Only success switches the
panel to HDR saved inside this design. Further saves use render.settings.set;
Reload, setup switching and design reopen never need the original path. The CPU
HDR's rotation, intensity and sample count are saved separately from its source
ID. Rotation remains in radians internally; drawing the degree editor does not
round-trip or clamp it. A constant environment and HDR are mutually exclusive.
CPU still requires explicit sRGB/D65 primaries; it never inherits the GPU's optional
assumption for an undeclared source.
The last CPU check stores its exact request and revision and displays the captured HDR dimensions, intensity, rotation, samples and SHA-256. It marks itself stale when the scene or editable request changes. The active job displays its own captured HDR descriptor. These UI records retain metadata, not image buffers or HDR source bytes. Saved HDR bytes belong to the document resource table, not those view records. An embedded source can be used with temporary reflection bindings through the same runtime renderer, but the bindings themselves remain unsaveable. PNG export remains the existing retained-frame export.
Light units and precedence
Directions point toward a light and are normalized by the runtime; a zero vector is invalid. Custom directional lighting replaces the preset directions; an empty custom list deliberately has no directional lights. Selecting a preset clears that custom list. Point lights are added to the chosen directional setup.
Point positions and distances are world millimetres. The reference distance is where the specified intensity applies; the minimum distance bounds inverse-square attenuation and must not exceed the reference. Both distances range from 0.001 to 1,000,000 mm in this panel. Intensities are relative renderer values, not a claim of lumens, watts or calibrated photometric measurements.
Area lights, their sampling/seed and spot cones remain without dedicated panel editors, but valid values loaded from a setup are preserved in Save, Check and Start. Directions retain their original nonzero magnitude; showing a field does not normalize or clamp it. Emission, surface effects, dielectric bindings and anisotropic faces remain runtime API capabilities that this panel explicitly refuses to edit. A later material/optics editor can expose those contracts separately.
Integration and acceptance
This unit includes EN/ES/JA/ZH strings, request-contract regressions for body identity and method isolation, environment bounds and light validation, delayed picker protection, and an extended native UI test that selects a reflection mode, checks and starts the same request, changes the HDR source after capture and compares exported PNG bytes with the retained frame. The progressive UI adds regressions for sequence caching, final publication racing the status read, cancellation/export retention, explicit resolution adjustment, offline Save/Reload, hidden values and reopening progressive setups with embedded HDR.
The author checked Rust formatting, locale-key coverage, whitespace and exact patch replay. No Cargo build, test execution, native launch or visual quality acceptance was performed for this incremental source unit. The integrator must run the combined revision's CI and the native UI/render tests before treating those regressions as passing. CPU controls and the GPU material editor have separate modules and request builders; both must retain their final admission guards when mounted together.