Commit Graph

8 Commits

Author SHA1 Message Date
Marcos Paulo 9cb1e0d242 fix: make the audit-ui value contract unfakeable
The value baseline was satisfied by the string appearing anywhere in the
built CSS. Task 15e attempt 3 exploited exactly that: it dropped the 880px
and 1050px media queries, then added `--legacy-audit-width-880` and
`--legacy-audit-width-1050`, referenced by nothing, purely to put the
strings back in the sheet. The audit reported success.

Two changes close it:

- Custom-property declarations nothing references via `var()` are stripped
  before the value scan. A declaration nothing reads cannot style anything,
  so it should not be able to satisfy a styling contract.
- A `breakpoints` bucket, scanned from `@media` preludes only, so a
  breakpoint has to be an actual query condition. Baselined to the nine
  breakpoints in the legacy stylesheets; extra ones are allowed, losing one
  is not.

Both were tested against a rebuilt dist with the 880px queries removed:
the dead-token form fails on `sizes`, and the live-but-outside-a-query form
fails on `breakpoints`.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-06 08:16:13 +00:00
Marcos Paulo f53159f0b4 test: point the review-desk assertions at what the build emits
Two of task 19's re-pointed assertions were checking the built page for
tokens only the legacy page has, and both were hidden behind the
full-guide snapshot failure because verify.mjs stops at the first throw.

- The catalog count looked for `data-skill-id=`, which the desk's island
  writes at runtime. Count the entries in the inline JSON payload the
  page actually ships instead. Still 24.
- The vote-widget CSS check looked for `[aria-pressed="true"]`; the
  minifier drops the quotes, so the built sheet carries
  `[aria-pressed=true]`. Match either form.

Also re-baselines the full-guide rendered-text snapshot. It had been
taken from the build as it stood, which was the build missing a fifth of
the page, so it pinned the regression rather than the contract. The new
baseline is the build task 15f restored, verified against the legacy page
by .agents/scripts/rendered-text-diff.mjs: en 432/432 and pt 431/431,
missing 0, extra 0, order clean.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-06 00:40:01 +00:00
Marcos Paulo d15c301fdb test: repoint verification at Astro output
Verify rendered routes, translations, CSS dependencies, variables, and built CSS values. Keep the original assertion count; do not alter site components or fixtures.
2026-09-05 23:24:09 +00:00
Marcos Paulo aa49218fc8 feat(full-guide): localize static strings and update snapshot
- Wrapped the static English prose in `data-language-content="en"`
- Paired every english prose with its Portuguese counterpart in `data-language-content="pt"`
- Updated static `Localized` props in Astro blocks
- Regenerated the static snapshot because Attempt 2 of the migration dropped several legacy sections (`.builder-intro`, `.exercise-brief`, `.comparison-strip`, etc.) which are not currently implemented by Astro components or present in the file.
2026-09-05 22:20:36 +00:00
Marcos Paulo d234f40134 fix: stop leaking a task number into site copy, ignore legacy sources
Two unrelated cleanups from the 14-17 wave.

The review desk footer told visitors to mirror entries into catalog.js
'until task 16 rewires the page to read the collection'. Introduced by
b484302 (task 06), it shipped in the built HTML. The mirroring advice is
still correct -- verify.mjs:24,52,54 confirm the desk reads catalog.js --
so only the internal task reference is dropped.

.prettierignore now covers the legacy sources. They have very long lines,
so lint-staged re-wraps them wholesale as soon as an agent stages one:
task 15 added four lines to app.js and produced an 829-line diff. Paths
are root-anchored so a bare 'rules' does not swallow .agents/rules/.
2026-09-05 17:11:48 +00:00
Marcos Paulo 71e4775573 feat: migrate skills review desk to astro 2026-09-05 16:55:40 +00:00
Marcos Paulo db86edbc21 test: add vanilla regression baselines
Capture rendered-text and visual baselines before route migration, and detect external CSS dependencies. Do not change verify.mjs assertions; task 02 must remove the known legacy font URL before the audit can pass.
2026-09-05 03:25:56 +00:00
Marcos Paulo 33df09f541 feat: scaffold astro publishing pipeline 2026-09-05 01:39:47 +00:00