Compare commits
2 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
| 4b758c765d | |||
| 7f11b6e88e |
@@ -20,11 +20,13 @@ palettes and a broken `@font-face`. **Load skills**: `design-tokens`,
|
|||||||
`--paper`, `--muted`, `--line`, `--gold` likewise. Most deltas are
|
`--paper`, `--muted`, `--line`, `--gold` likewise. Most deltas are
|
||||||
sub-perceptual and can be canonicalized. `--blue` (`#527f9f` vs `#215675`) is
|
sub-perceptual and can be canonicalized. `--blue` (`#527f9f` vs `#215675`) is
|
||||||
visibly different — screenshot both and get a human decision.
|
visibly different — screenshot both and get a human decision.
|
||||||
2. **The fonts have never rendered.** The `@font-face` in `styles.css:1` points
|
2. ~~**The fonts have never rendered.**~~ **Settled 2026-09-05 — do not
|
||||||
`src:` at a Google Fonts _stylesheet_, so Manrope and DM Mono have always
|
reopen.** The malformed `@font-face` was escalated and the human chose the
|
||||||
fallen back to Arial and generic monospace. Self-hosting them is a redesign,
|
real fonts. Manrope and DM Mono are self-hosted in `public/fonts/`, wired
|
||||||
not a refactor. Default: delete the dead rule, declare the stacks that
|
through `public/fonts/fonts.css`, which `BaseLayout.astro` links and the
|
||||||
actually render. Escalate if someone wants the real fonts.
|
legacy root `styles.css` `@import`s. **Do not delete these faces and do not
|
||||||
|
replace the stacks with `Arial`/`ui-monospace`** — that instruction is
|
||||||
|
obsolete. You may add `--font-sans` / `--font-mono` tokens pointing at them.
|
||||||
|
|
||||||
## You own
|
## You own
|
||||||
|
|
||||||
|
|||||||
@@ -8,18 +8,18 @@ files, not assumed.
|
|||||||
The same semantic names carry different values depending on which stylesheet
|
The same semantic names carry different values depending on which stylesheet
|
||||||
loaded them:
|
loaded them:
|
||||||
|
|
||||||
| Token | `styles.css`, `rules/styles.css` | `chapters.css`, `skills-review/styles.css` | `hands-on/*/styles.css` |
|
| Token | `styles.css`, `rules/styles.css` | `chapters.css`, `skills-review/styles.css` | `hands-on/*/styles.css` |
|
||||||
| --- | --- | --- | --- |
|
| ---------- | -------------------------------- | ------------------------------------------ | ----------------------- |
|
||||||
| `--paper` | `#f5f4f1` | `#f6f3ed` | `#f4f3ef` |
|
| `--paper` | `#f5f4f1` | `#f6f3ed` | `#f4f3ef` |
|
||||||
| `--ink` | `#172f42` | `#122534` | `#173044` |
|
| `--ink` | `#172f42` | `#122534` | `#173044` |
|
||||||
| `--muted` | `#697b89` | `#65717a` | `#687d8c` |
|
| `--muted` | `#697b89` | `#65717a` | `#687d8c` |
|
||||||
| `--line` | `#d8dee2` | `#d0d5d2` | `#d5dde1` |
|
| `--line` | `#d8dee2` | `#d0d5d2` | `#d5dde1` |
|
||||||
| `--blue` | `#527f9f` | `#215675` | `#5683a1` |
|
| `--blue` | `#527f9f` | `#215675` | `#5683a1` |
|
||||||
| `--gold` | `#efc76b` | `#ebbf58` | `#efc86d` |
|
| `--gold` | `#efc76b` | `#ebbf58` | `#efc86d` |
|
||||||
| `--accent` | `#7c78a8` | — | — |
|
| `--accent` | `#7c78a8` | — | — |
|
||||||
| `--deep` | `#102536` | — | — |
|
| `--deep` | `#102536` | — | — |
|
||||||
| `--red` | — | `#a7483f` (chapters only) | — |
|
| `--red` | — | `#a7483f` (chapters only) | — |
|
||||||
| `--violet` | — | `#6b668f` (review desk only) | — |
|
| `--violet` | — | `#6b668f` (review desk only) | — |
|
||||||
|
|
||||||
Most deltas are a few units per channel — drift, not intent. `--blue` is the
|
Most deltas are a few units per channel — drift, not intent. `--blue` is the
|
||||||
exception: `#527f9f` vs `#215675` is a visible difference and may be deliberate.
|
exception: `#527f9f` vs `#215675` is a visible difference and may be deliberate.
|
||||||
@@ -34,35 +34,36 @@ exception: `#527f9f` vs `#215675` is a visible difference and may be deliberate.
|
|||||||
Do not "just pick one" silently in the middle of another task. This is its own
|
Do not "just pick one" silently in the middle of another task. This is its own
|
||||||
reviewed change with visual diffs attached.
|
reviewed change with visual diffs attached.
|
||||||
|
|
||||||
## The typography you see is not the typography that was written
|
## The typography — fixed 2026-09-05
|
||||||
|
|
||||||
`styles.css` line 1:
|
`styles.css` line 1 used to read:
|
||||||
|
|
||||||
```css
|
```css
|
||||||
@font-face{font-family:Manrope;src:url('https://fonts.googleapis.com/css2?family=DM+Mono&family=Manrope:wght@400;600;700;800&display=swap')}
|
@font-face {
|
||||||
|
font-family: Manrope;
|
||||||
|
src: url('https://fonts.googleapis.com/css2?family=DM+Mono&family=Manrope:wght@400;600;700;800&display=swap');
|
||||||
|
}
|
||||||
```
|
```
|
||||||
|
|
||||||
`src:` points at a **CSS stylesheet**, not a font file. No browser can load a
|
`src:` in an `@font-face` must point at a font binary. That URL returns a CSS
|
||||||
font from that, so:
|
stylesheet, so no browser could load a face from it. For the whole life of the
|
||||||
|
site, every `font-family:Manrope,Arial,sans-serif` rendered as **Arial** and
|
||||||
|
every `font:… 'DM Mono',monospace` rendered as the **generic monospace** face —
|
||||||
|
`'DM Mono'` was never declared as a family at all.
|
||||||
|
|
||||||
- every `font-family:Manrope,Arial,sans-serif` renders as **Arial**
|
**This was escalated and the human chose the real fonts.** Manrope and DM Mono
|
||||||
- every `font:… 'DM Mono',monospace` renders as the **generic monospace** face
|
are now self-hosted in `public/fonts/`, latin and latin-ext subsets only, under
|
||||||
- there are no `@font-face` blocks anywhere else and zero font files in the repo
|
the SIL Open Font License. One `fonts.css` serves both trees: Astro links it
|
||||||
- `scripts/audit-ui.mjs` only rejects external `<link>`/`<script>` tags, so this
|
from `BaseLayout.astro`, the legacy root `styles.css` `@import`s it. Self-hosted
|
||||||
slipped through the "dependency-free" audit
|
rather than linked from Google because `scripts/audit-ui.mjs` rejects any
|
||||||
|
external `<link>`/`<script>`, and because the site is presented in workshop
|
||||||
|
rooms with unreliable networks.
|
||||||
|
|
||||||
**This is a trap for the refactor.** Self-hosting Manrope and DM Mono in Astro
|
**This changed how every page renders**, deliberately. It is the one sanctioned
|
||||||
is the obvious "fix" — and it would change how every page looks, violating
|
visual change in the migration. Screenshots taken before 2026-09-05 show Arial
|
||||||
"maintain the same styles". Treat it as an explicit product decision:
|
and are no longer a valid baseline.
|
||||||
|
|
||||||
- **Keep current rendering**: delete the dead `@font-face`, replace the font
|
`Georgia, serif` for emphasis (`h1 em`, `.hero em`) is untouched and still real.
|
||||||
stacks with what actually renders today (`Arial, sans-serif` /
|
|
||||||
`ui-monospace, monospace`). Zero visual change. Honest CSS.
|
|
||||||
- **Adopt the intended fonts**: self-host the woff2 files in `public/fonts/`,
|
|
||||||
add real `@font-face` with `font-display:swap`. Better-looking, but it is a
|
|
||||||
redesign and needs sign-off plus fresh screenshots.
|
|
||||||
|
|
||||||
Default to the first unless a human says otherwise.
|
|
||||||
|
|
||||||
## Type scale
|
## Type scale
|
||||||
|
|
||||||
@@ -71,13 +72,13 @@ real — it is a system font, so it does render. Keep it.
|
|||||||
|
|
||||||
Sizes are all `clamp()`, roughly:
|
Sizes are all `clamp()`, roughly:
|
||||||
|
|
||||||
| Role | Value |
|
| Role | Value |
|
||||||
| --- | --- |
|
| --------------- | --------------------------------------------------------- |
|
||||||
| Display / `h1` | `clamp(56px,9vw,126px)` |
|
| Display / `h1` | `clamp(56px,9vw,126px)` |
|
||||||
| Section `h2` | `clamp(36px,5vw,65px)` |
|
| Section `h2` | `clamp(36px,5vw,65px)` |
|
||||||
| Sub-head | `clamp(24px,3vw,38px)` |
|
| Sub-head | `clamp(24px,3vw,38px)` |
|
||||||
| Pull-quote | `clamp(22px,3vw,36px)` |
|
| Pull-quote | `clamp(22px,3vw,36px)` |
|
||||||
| Body | `15px/1.6` … `18px` |
|
| Body | `15px/1.6` … `18px` |
|
||||||
| Eyebrow / label | `10–11px` monospace, `letter-spacing:.08–.1em`, uppercase |
|
| Eyebrow / label | `10–11px` monospace, `letter-spacing:.08–.1em`, uppercase |
|
||||||
|
|
||||||
There are 14+ distinct clamp triples doing near-identical jobs. Collapse to a
|
There are 14+ distinct clamp triples doing near-identical jobs. Collapse to a
|
||||||
@@ -87,11 +88,12 @@ should be unchanged within a pixel or two at common viewports.
|
|||||||
## Breakpoints
|
## Breakpoints
|
||||||
|
|
||||||
Sixteen distinct max-widths are in use: 420, 520, 530, 560, 600, 620, 720, 800,
|
Sixteen distinct max-widths are in use: 420, 520, 530, 560, 600, 620, 720, 800,
|
||||||
850, 880, 900, 1000, 1050, 1100 — plus `min-width:1600px` and `min-width:2200px`.
|
850, 880, 900, 1000, 1050, 1100 — plus `min-width:1600px` and
|
||||||
|
`min-width:2200px`.
|
||||||
|
|
||||||
Collapse to a named set (suggested: 560 / 800 / 1100 / 1600 / 2200) and prove
|
Collapse to a named set (suggested: 560 / 800 / 1100 / 1600 / 2200) and prove
|
||||||
equivalence with screenshots at the *old* breakpoint values, since that is
|
equivalence with screenshots at the _old_ breakpoint values, since that is where
|
||||||
where regressions will hide.
|
regressions will hide.
|
||||||
|
|
||||||
`@media(prefers-reduced-motion:reduce)` is already respected in several
|
`@media(prefers-reduced-motion:reduce)` is already respected in several
|
||||||
stylesheets. Keep it — see [`../rules/animation.md`](../rules/animation.md).
|
stylesheets. Keep it — see [`../rules/animation.md`](../rules/animation.md).
|
||||||
@@ -100,8 +102,8 @@ stylesheets. Keep it — see [`../rules/animation.md`](../rules/animation.md).
|
|||||||
|
|
||||||
The visual identity is editorial-print: flat colour blocks, hairline `1px`
|
The visual identity is editorial-print: flat colour blocks, hairline `1px`
|
||||||
rules, uppercase monospace eyebrows with wide tracking, very tight negative
|
rules, uppercase monospace eyebrows with wide tracking, very tight negative
|
||||||
letter-spacing on display type (`-.06em` … `-.08em`), grid layouts with `gap:1px`
|
letter-spacing on display type (`-.06em` … `-.08em`), grid layouts with
|
||||||
over a background colour to fake borders, and near-zero border-radius.
|
`gap:1px` over a background colour to fake borders, and near-zero border-radius.
|
||||||
|
|
||||||
That last trick (`gap:1px` + parent background) is used everywhere. It is
|
That last trick (`gap:1px` + parent background) is used everywhere. It is
|
||||||
intentional. Do not replace it with `border`.
|
intentional. Do not replace it with `border`.
|
||||||
|
|||||||
@@ -0,0 +1,29 @@
|
|||||||
|
dist
|
||||||
|
node_modules
|
||||||
|
hands-on
|
||||||
|
public/hands-on
|
||||||
|
submitted-skills
|
||||||
|
public/submitted-skills
|
||||||
|
skill-reviews
|
||||||
|
vote-service
|
||||||
|
|
||||||
|
# Legacy site sources, slated for deletion at cutover (task 20). Same list and
|
||||||
|
# same reasoning as .prettierignore: these are minified, single-line
|
||||||
|
# stylesheets. stylelint's `declaration-block-single-line-max-declarations`
|
||||||
|
# fires once per rule in them — ~180 errors for `styles.css` alone — so staging
|
||||||
|
# one to change a single declaration blocks the commit outright. The rule is
|
||||||
|
# about hand-written source readability and says nothing useful about minified
|
||||||
|
# output that is about to be deleted.
|
||||||
|
#
|
||||||
|
# `public/fonts/fonts.css` is deliberately NOT here: it is new, hand-written,
|
||||||
|
# and must stay linted.
|
||||||
|
#
|
||||||
|
# Root-anchored on purpose: a bare `rules` would also swallow .agents/rules/.
|
||||||
|
/styles.css
|
||||||
|
/landing.css
|
||||||
|
/chapters.css
|
||||||
|
/responsive.css
|
||||||
|
/skills-review/
|
||||||
|
/rules/
|
||||||
|
/skills/
|
||||||
|
/full-guide/
|
||||||
@@ -45,6 +45,8 @@ Phase 4 polish 18 ∥ 19, then 20
|
|||||||
| --- | ----------------------------------------------------------------- | --------------------- | ------------------ | ------------- |
|
| --- | ----------------------------------------------------------------- | --------------------- | ------------------ | ------------- |
|
||||||
| 01 | [scaffold + gates](task-01-scaffold.md) | astro-architect | — | — |
|
| 01 | [scaffold + gates](task-01-scaffold.md) | astro-architect | — | — |
|
||||||
| 02 | [design tokens](task-02-tokens.md) | design-system-keeper | 01 | 03, 04 |
|
| 02 | [design tokens](task-02-tokens.md) | design-system-keeper | 01 | 03, 04 |
|
||||||
|
| 02b | [token layer wiring](task-02b-token-layer-wiring.md) | design-system-keeper | 02 | 03, 04 |
|
||||||
|
| 02c | [token-gap queue](task-02c-token-gaps.md) | design-system-keeper | 02b, 15d | — |
|
||||||
| 03 | [verification net](task-03-verification-net.md) | verification-engineer | 01 | 02, 04 |
|
| 03 | [verification net](task-03-verification-net.md) | verification-engineer | 01 | 02, 04 |
|
||||||
| 04 | [content schema](task-04-content-schema.md) | content-i18n-migrator | 01 | 02, 03 |
|
| 04 | [content schema](task-04-content-schema.md) | content-i18n-migrator | 01 | 02, 03 |
|
||||||
| 05 | [guide content](task-05-content-guide.md) | content-i18n-migrator | 04 | 06 |
|
| 05 | [guide content](task-05-content-guide.md) | content-i18n-migrator | 04 | 06 |
|
||||||
|
|||||||
@@ -50,7 +50,7 @@ walk into.
|
|||||||
|
|
||||||
## Do not
|
## Do not
|
||||||
|
|
||||||
- Do not add a webfont.
|
- Do not add a webfont. **(Reversed 2026-09-05 — see Decisions.)**
|
||||||
- Do not rename tokens to numeric scales (`--color-neutral-900`).
|
- Do not rename tokens to numeric scales (`--color-neutral-900`).
|
||||||
- Do not convert the `gap:1px` over a coloured parent trick into `border` — it
|
- Do not convert the `gap:1px` over a coloured parent trick into `border` — it
|
||||||
is deliberate house style and appears everywhere.
|
is deliberate house style and appears everywhere.
|
||||||
@@ -60,7 +60,9 @@ walk into.
|
|||||||
- **Palette Consolidation:** The three drifted palettes were canonicalized into
|
- **Palette Consolidation:** The three drifted palettes were canonicalized into
|
||||||
one. For `--blue`, `#527f9f` (from styles.css) was chosen over `#215675` (from
|
one. For `--blue`, `#527f9f` (from styles.css) was chosen over `#215675` (from
|
||||||
chapters.css) to unify the look.
|
chapters.css) to unify the look.
|
||||||
- **Fonts:** The broken `@font-face` rule pointing to a Google Fonts stylesheet
|
- **Fonts (superseded 2026-09-05):** task 02 recorded "delete the dead rule,
|
||||||
was noted to be deleted in future component tasks. The font stacks will be
|
fall back to `Arial, sans-serif` / `ui-monospace, monospace`, zero visual
|
||||||
replaced with `Arial, sans-serif` and `ui-monospace, monospace` to match what
|
change", and deferred even that deletion to "future component tasks", which
|
||||||
has actually been rendering all along. Zero visual change.
|
never picked it up. The human has since chosen the opposite: Manrope and DM
|
||||||
|
Mono are now self-hosted in `public/fonts/` and really render. The "Do not add
|
||||||
|
a webfont" line above no longer applies.
|
||||||
|
|||||||
@@ -0,0 +1,107 @@
|
|||||||
|
# Task 02b — Wire the token layer in
|
||||||
|
|
||||||
|
**Agent**: `design-system-keeper` · **Model**: `agy` (Gemini 3.1 Pro — needs
|
||||||
|
vision for the screenshot diffs) **Depends on**: 02 · **Blocks**: 02c
|
||||||
|
**Worktree**: `.agents/scripts/worktree.sh start 02b token-layer-wiring`
|
||||||
|
|
||||||
|
## Why this task exists
|
||||||
|
|
||||||
|
Task 02 built the token layer and it was never connected to anything. This is
|
||||||
|
not a criticism of that task — its brief and its done-when list never asked for
|
||||||
|
the wiring, and `check-tokens.mjs` only looks for _violations_ in `src/`, so
|
||||||
|
nothing could have caught it.
|
||||||
|
|
||||||
|
Verify each of these yourself before you start; do not take my word for it:
|
||||||
|
|
||||||
|
1. **`src/styles/tokens.css` is imported by nothing.** The only reference in the
|
||||||
|
repo is `src/styles/base.css:2`, and `base.css` is itself imported nowhere.
|
||||||
|
The whole layer is dead code.
|
||||||
|
2. **The pages import the legacy stylesheets instead**, drifted `:root` blocks
|
||||||
|
and all:
|
||||||
|
- `src/layouts/ChapterLayout.astro:16` → `../../chapters.css?url`
|
||||||
|
- `src/pages/skills.astro:11` → `../../skills/styles.css?url`
|
||||||
|
- `src/pages/skills-review.astro:4,5` → `skills-review/styles.css`,
|
||||||
|
`change-lens.css`
|
||||||
|
3. **So task 02's `--blue` decision never reached a page.** It chose `#527f9f`
|
||||||
|
and wrote it down. The built CSS today ships both values:
|
||||||
|
```
|
||||||
|
dist/_astro/chapters.*.css --blue:#215675
|
||||||
|
dist/_astro/rules.*.css --blue: #527f9f
|
||||||
|
dist/_astro/styles.*.css --blue:#215675
|
||||||
|
```
|
||||||
|
|
||||||
|
## Scope
|
||||||
|
|
||||||
|
`src/styles/tokens.css`, `src/styles/base.css`,
|
||||||
|
`.agents/scripts/check-tokens.mjs` — you are the only writer of these — plus the
|
||||||
|
four import sites listed above and whatever layout work the wiring needs.
|
||||||
|
|
||||||
|
## Deliver
|
||||||
|
|
||||||
|
### 1. One loaded token layer
|
||||||
|
|
||||||
|
Make `tokens.css` actually load on every route. Either fix `base.css` and import
|
||||||
|
it from the layouts, or drop `base.css` and import `tokens.css` directly — your
|
||||||
|
call, but say which and why. A file that exists and is never loaded is worse
|
||||||
|
than no file, because it reads as done.
|
||||||
|
|
||||||
|
### 2. The legacy stylesheet imports reconciled
|
||||||
|
|
||||||
|
Those three `?url` imports are how the drifted palettes reach production. You do
|
||||||
|
not have to delete them in this task — much of that CSS is still load-bearing
|
||||||
|
until task 15e and task 20 — but the `:root` blocks inside them must stop
|
||||||
|
overriding the canonical tokens. Make the layer authoritative and prove with
|
||||||
|
screenshots that nothing moved except what you intend.
|
||||||
|
|
||||||
|
`--blue` is the one real difference: `#527f9f` vs `#215675` is visible. Task 02
|
||||||
|
already decided `#527f9f`. Apply that decision; do not re-open it. If applying
|
||||||
|
it looks wrong on a real page, screenshot it and escalate rather than quietly
|
||||||
|
picking the other value.
|
||||||
|
|
||||||
|
### 3. Font tokens
|
||||||
|
|
||||||
|
Manrope and DM Mono are **real now** — self-hosted in `public/fonts/`, wired
|
||||||
|
through `public/fonts/fonts.css` (linked by `BaseLayout.astro`, `@import`ed by
|
||||||
|
the legacy root `styles.css`). Read `.agents/context/design-system.md`; the old
|
||||||
|
"delete the dead rule, fall back to Arial" instruction is **superseded and must
|
||||||
|
not be re-applied**.
|
||||||
|
|
||||||
|
Add `--font-sans` and `--font-mono` and point the stacks at them. Do not touch
|
||||||
|
`public/fonts/fonts.css` itself, and do not remove the faces.
|
||||||
|
|
||||||
|
### 4. A check so this cannot recur
|
||||||
|
|
||||||
|
The gap that let a dead token layer ship is that nothing asserts the tokens are
|
||||||
|
_loaded_. Add that check — a build-output assertion that every route resolves
|
||||||
|
the canonical palette, or an equivalent. Put it in `check-tokens.mjs`, which you
|
||||||
|
own. **Do not touch `scripts/verify.mjs`**; it stays at 42 assertions and only
|
||||||
|
the verification-engineer may change it.
|
||||||
|
|
||||||
|
## Screenshots: your baseline is HEAD, not history
|
||||||
|
|
||||||
|
The self-hosted fonts landed in `7f11b6e` and **changed how every page
|
||||||
|
renders**, deliberately — that is the one sanctioned visual change in this
|
||||||
|
migration. Any screenshot taken before it shows Arial and is not a valid
|
||||||
|
baseline. Capture your own "before" from HEAD at the start of this task.
|
||||||
|
|
||||||
|
Widths: 560 / 800 / 1100 / 1600, plus the eight breakpoints task 02 removed
|
||||||
|
(520, 530, 600, 620, 720, 850, 880, 900) — that is where regressions hide.
|
||||||
|
|
||||||
|
## Do not
|
||||||
|
|
||||||
|
- Do not resolve the ~164 `token-gap:` markers. That is task 02c, and doing it
|
||||||
|
here would collide with task 15d's page work. Report the count.
|
||||||
|
- Do not delete `responsive.css`. That is 15e.
|
||||||
|
- Do not convert the `gap:1px` over a coloured parent trick into `border` — it
|
||||||
|
is deliberate house style and appears everywhere.
|
||||||
|
- Do not rename tokens to numeric scales (`--color-neutral-900`).
|
||||||
|
- Never use `--no-verify`; never set `core.hooksPath`.
|
||||||
|
|
||||||
|
## Done when
|
||||||
|
|
||||||
|
- [ ] `tokens.css` loads on every route, proven from built output
|
||||||
|
- [ ] One value per token in the shipped CSS — `--blue` is `#527f9f` everywhere
|
||||||
|
- [ ] `--font-sans` / `--font-mono` exist and are used; the faces still load
|
||||||
|
- [ ] A check exists that fails if the token layer stops being loaded
|
||||||
|
- [ ] Before/after screenshots at all twelve widths, every difference explained
|
||||||
|
- [ ] `pnpm run gate` green — the full gate; 42 assertions intact
|
||||||
@@ -0,0 +1,51 @@
|
|||||||
|
# Task 02c — Work the token-gap queue
|
||||||
|
|
||||||
|
**Agent**: `design-system-keeper` · **Model**: `agy` (Gemini 3.1 Pro) **Depends
|
||||||
|
on**: 02b, 15d · **Blocks**: 19 **Worktree**:
|
||||||
|
`.agents/scripts/worktree.sh start 02c token-gaps`
|
||||||
|
|
||||||
|
## Why this task exists
|
||||||
|
|
||||||
|
`check-tokens.mjs` bans raw hex, `font-size: Npx` and ad-hoc breakpoints outside
|
||||||
|
the token layer. Until the escape hatch was added it offered no legal
|
||||||
|
alternative, so agents told both "keep the site identical" and "get the gate
|
||||||
|
green" cheated — writing px through the `font:` shorthand the regex misses, or
|
||||||
|
substituting the nearest token and shipping a silent redesign (`12px` and `14px`
|
||||||
|
both became `var(--step-1)`, 15px; a diff-added green became `var(--accent)`,
|
||||||
|
purple).
|
||||||
|
|
||||||
|
The `/* token-gap: <reason>; owner design-system-keeper */` marker replaced that
|
||||||
|
with an honest, visible queue. **You are the owner it names.** There are ~164
|
||||||
|
markers on `main`; get the real count yourself from `check-tokens.mjs` output.
|
||||||
|
|
||||||
|
## The work
|
||||||
|
|
||||||
|
For each marked value, one of three outcomes — and the choice is yours to make,
|
||||||
|
not to defer:
|
||||||
|
|
||||||
|
1. **The scale should cover it.** Extend `--step-*` and point the site at it.
|
||||||
|
Most of the queue is this: `24px`, `25px`, `20px`, `17px`, `13px` fixed sizes
|
||||||
|
from `chapters.css` that fall between existing steps.
|
||||||
|
2. **It is genuinely one-off.** Keep the literal value, delete the marker, and
|
||||||
|
leave a comment saying why it is exempt.
|
||||||
|
3. **It was already wrong.** Some markers record a near-miss substitution an
|
||||||
|
earlier task made under duress. Restoring the true legacy value is a visible
|
||||||
|
change — screenshot it and say so.
|
||||||
|
|
||||||
|
Work in batches by source file and commit per batch. A single 164-site commit is
|
||||||
|
unreviewable.
|
||||||
|
|
||||||
|
## Do not
|
||||||
|
|
||||||
|
- Do not weaken `check-tokens.mjs` to make markers disappear. Removing a check
|
||||||
|
is not resolving a gap.
|
||||||
|
- Do not touch `scripts/verify.mjs` — 42 assertions, verification-engineer only.
|
||||||
|
- Do not leave a marker whose reason you have satisfied.
|
||||||
|
|
||||||
|
## Done when
|
||||||
|
|
||||||
|
- [ ] Every marker either resolved into the scale or documented as a deliberate
|
||||||
|
exemption
|
||||||
|
- [ ] `check-tokens.mjs` reports zero unexplained gaps
|
||||||
|
- [ ] Screenshots for every change that moved a pixel, differences explained
|
||||||
|
- [ ] `pnpm run gate` green; 42 assertions intact
|
||||||
@@ -0,0 +1,14 @@
|
|||||||
|
# Font licences
|
||||||
|
|
||||||
|
Both families here are licensed under the SIL Open Font License, Version 1.1,
|
||||||
|
which permits redistribution and self-hosting.
|
||||||
|
|
||||||
|
| Family | Designer | Source |
|
||||||
|
| ------- | ---------------------------- | -------------------------------------- |
|
||||||
|
| Manrope | Mikhail Sharanda | https://github.com/sharanda/manrope |
|
||||||
|
| DM Mono | Colophon Foundry for Deja Vu | https://github.com/googlefonts/dm-mono |
|
||||||
|
|
||||||
|
Full licence text: https://openfontlicense.org/open-font-license-official-text/
|
||||||
|
|
||||||
|
The `.woff2` files are the latin and latin-ext subsets as served by Google
|
||||||
|
Fonts. They are unmodified.
|
||||||
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
@@ -0,0 +1,100 @@
|
|||||||
|
/* Manrope and DM Mono, self-hosted.
|
||||||
|
*
|
||||||
|
* `styles.css` line 1 used to carry this:
|
||||||
|
*
|
||||||
|
* @font-face{font-family:Manrope;src:url('https://fonts.googleapis.com/css2?...')}
|
||||||
|
*
|
||||||
|
* `src:` in an @font-face must point at a font binary. That URL returns a CSS
|
||||||
|
* stylesheet, so no browser could ever load a face from it: every
|
||||||
|
* `font-family:Manrope,Arial,sans-serif` fell through to Arial, and 'DM Mono'
|
||||||
|
* was never declared at all, so it fell through to the generic monospace face.
|
||||||
|
* The intended typography has never rendered. This file is the fix.
|
||||||
|
*
|
||||||
|
* Self-hosted rather than linked from fonts.googleapis.com because
|
||||||
|
* `scripts/audit-ui.mjs` rejects any external <link>/<script>, and because the
|
||||||
|
* site is shown in workshop rooms with unreliable networks.
|
||||||
|
*
|
||||||
|
* Both families are SIL Open Font License 1.1 — see OFL.md in this directory.
|
||||||
|
* Subsets are latin and latin-ext only: the site is EN and PT-BR, so the
|
||||||
|
* cyrillic, greek and vietnamese subsets Google also serves are dropped.
|
||||||
|
*
|
||||||
|
* The url()s are relative on purpose. Both consumers resolve them against this
|
||||||
|
* file's own location:
|
||||||
|
* - Astro pages: <link> in BaseLayout.astro, served from `${base}fonts/`
|
||||||
|
* - legacy pages: @import at the top of the root `styles.css`
|
||||||
|
*/
|
||||||
|
|
||||||
|
/* DM Mono 400 — latin */
|
||||||
|
@font-face {
|
||||||
|
font-family: 'DM Mono';
|
||||||
|
font-style: normal;
|
||||||
|
font-weight: 400;
|
||||||
|
font-display: swap;
|
||||||
|
src: url('dm-mono-400-latin.woff2') format('woff2');
|
||||||
|
unicode-range:
|
||||||
|
U+0000-00FF, U+0131, U+0152-0153, U+02BB-02BC, U+02C6, U+02DA, U+02DC, U+0304, U+0308, U+0329,
|
||||||
|
U+2000-206F, U+20AC, U+2122, U+2191, U+2193, U+2212, U+2215, U+FEFF, U+FFFD;
|
||||||
|
}
|
||||||
|
|
||||||
|
/* DM Mono 400 — latin-ext */
|
||||||
|
@font-face {
|
||||||
|
font-family: 'DM Mono';
|
||||||
|
font-style: normal;
|
||||||
|
font-weight: 400;
|
||||||
|
font-display: swap;
|
||||||
|
src: url('dm-mono-400-latin-ext.woff2') format('woff2');
|
||||||
|
unicode-range:
|
||||||
|
U+0100-02BA, U+02BD-02C5, U+02C7-02CC, U+02CE-02D7, U+02DD-02FF, U+0304, U+0308, U+0329,
|
||||||
|
U+1D00-1DBF, U+1E00-1E9F, U+1EF2-1EFF, U+2020, U+20A0-20AB, U+20AD-20C0, U+2113, U+2C60-2C7F,
|
||||||
|
U+A720-A7FF;
|
||||||
|
}
|
||||||
|
|
||||||
|
/* DM Mono 500 — latin */
|
||||||
|
@font-face {
|
||||||
|
font-family: 'DM Mono';
|
||||||
|
font-style: normal;
|
||||||
|
font-weight: 500;
|
||||||
|
font-display: swap;
|
||||||
|
src: url('dm-mono-500-latin.woff2') format('woff2');
|
||||||
|
unicode-range:
|
||||||
|
U+0000-00FF, U+0131, U+0152-0153, U+02BB-02BC, U+02C6, U+02DA, U+02DC, U+0304, U+0308, U+0329,
|
||||||
|
U+2000-206F, U+20AC, U+2122, U+2191, U+2193, U+2212, U+2215, U+FEFF, U+FFFD;
|
||||||
|
}
|
||||||
|
|
||||||
|
/* DM Mono 500 — latin-ext */
|
||||||
|
@font-face {
|
||||||
|
font-family: 'DM Mono';
|
||||||
|
font-style: normal;
|
||||||
|
font-weight: 500;
|
||||||
|
font-display: swap;
|
||||||
|
src: url('dm-mono-500-latin-ext.woff2') format('woff2');
|
||||||
|
unicode-range:
|
||||||
|
U+0100-02BA, U+02BD-02C5, U+02C7-02CC, U+02CE-02D7, U+02DD-02FF, U+0304, U+0308, U+0329,
|
||||||
|
U+1D00-1DBF, U+1E00-1E9F, U+1EF2-1EFF, U+2020, U+20A0-20AB, U+20AD-20C0, U+2113, U+2C60-2C7F,
|
||||||
|
U+A720-A7FF;
|
||||||
|
}
|
||||||
|
|
||||||
|
/* Manrope 400 800 — latin */
|
||||||
|
@font-face {
|
||||||
|
font-family: Manrope;
|
||||||
|
font-style: normal;
|
||||||
|
font-weight: 400 800;
|
||||||
|
font-display: swap;
|
||||||
|
src: url('manrope-var-latin.woff2') format('woff2');
|
||||||
|
unicode-range:
|
||||||
|
U+0000-00FF, U+0131, U+0152-0153, U+02BB-02BC, U+02C6, U+02DA, U+02DC, U+0304, U+0308, U+0329,
|
||||||
|
U+2000-206F, U+20AC, U+2122, U+2191, U+2193, U+2212, U+2215, U+FEFF, U+FFFD;
|
||||||
|
}
|
||||||
|
|
||||||
|
/* Manrope 400 800 — latin-ext */
|
||||||
|
@font-face {
|
||||||
|
font-family: Manrope;
|
||||||
|
font-style: normal;
|
||||||
|
font-weight: 400 800;
|
||||||
|
font-display: swap;
|
||||||
|
src: url('manrope-var-latin-ext.woff2') format('woff2');
|
||||||
|
unicode-range:
|
||||||
|
U+0100-02BA, U+02BD-02C5, U+02C7-02CC, U+02CE-02D7, U+02DD-02FF, U+0304, U+0308, U+0329,
|
||||||
|
U+1D00-1DBF, U+1E00-1E9F, U+1EF2-1EFF, U+2020, U+20A0-20AB, U+20AD-20C0, U+2113, U+2C60-2C7F,
|
||||||
|
U+A720-A7FF;
|
||||||
|
}
|
||||||
Binary file not shown.
Binary file not shown.
@@ -6,6 +6,11 @@ interface Props {
|
|||||||
}
|
}
|
||||||
|
|
||||||
const { title, description, lang = 'en' } = Astro.props;
|
const { title, description, lang = 'en' } = Astro.props;
|
||||||
|
|
||||||
|
// Self-hosted Manrope and DM Mono. Lives in `public/fonts/` rather than the
|
||||||
|
// bundled CSS because the legacy stylesheets @import the same file, so there
|
||||||
|
// is exactly one copy of the faces. See public/fonts/fonts.css.
|
||||||
|
const fonts = `${import.meta.env.BASE_URL}fonts/fonts.css`.replace('//', '/');
|
||||||
---
|
---
|
||||||
|
|
||||||
<!doctype html>
|
<!doctype html>
|
||||||
@@ -15,6 +20,7 @@ const { title, description, lang = 'en' } = Astro.props;
|
|||||||
<meta name="viewport" content="width=device-width, initial-scale=1" />
|
<meta name="viewport" content="width=device-width, initial-scale=1" />
|
||||||
<title>{title}</title>
|
<title>{title}</title>
|
||||||
<meta name="description" content={description} />
|
<meta name="description" content={description} />
|
||||||
|
<link rel="stylesheet" href={fonts} />
|
||||||
<slot name="styles" />
|
<slot name="styles" />
|
||||||
</head>
|
</head>
|
||||||
<body>
|
<body>
|
||||||
|
|||||||
+1
-1
File diff suppressed because one or more lines are too long
Reference in New Issue
Block a user