Files

T

Marcos Paulo 48c31dc1b3 build: migrate from npm to pnpm

Ten git worktrees each carried their own 225 MB node_modules (1.1 GB across
five) and paid 11s per `npm ci`. pnpm hardlinks from a shared store: the same
five worktrees cost ~250 MB total, and a fresh install is 4s.

What changed beyond the mechanical rename:

- `overrides` moved to `pnpm-workspace.yaml`. pnpm 11 does not read the `pnpm`
  field in package.json *or* npm's top-level `overrides`, and it fails silently
  — the vite/defu/language-server pins would have quietly stopped applying.
- Build scripts are blocked by default in pnpm; esbuild and sharp are allowed
  explicitly via `allowBuilds` (renamed from `onlyBuiltDependencies` in 11).
- `packageManager` + `engines` pin the toolchain.
- gate.sh rejects a package-lock.json/yarn.lock/bun.lock outright, so an agent
  running `npm install` out of habit fails loudly instead of building a second,
  divergent dependency tree.
- CI bootstraps pnpm with `npm install --global pnpm@11.25.0` rather than
  corepack (unbundled as of Node 25) or pnpm/action-setup (this self-hosted
  act-runner has never run a job; fetching a third-party action is not
  something to discover on the first one).

Two pre-existing CI bugs fixed while in the file:

- the gate installed with `npm install --package-lock=false`, which discarded
  the lockfile the previous session had just fixed.
- the visual-regression step imported `playwright`, which is not a dependency,
  and `visual-regression.mjs` has no compare mode anyway — in CI it overwrote
  its own baselines and passed unconditionally. Removed with a comment; it
  comes back when it can diff.

The `publish` job is now manual (`workflow_dispatch`). During the migration
dist/ holds three HTML files against the live pages branch's ten, so publishing
on every push to main would take the site down to a stub. Restore at task 20.

HANDOVER.md's incident log still says npm where it describes what happened at
the time; that is history, not a missed rename.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

2026-09-05 04:29:42 +00:00

2.5 KiB

Raw Blame History

Task 19 — Re-point the verification contract

Agent: verification-engineer · Model: Codex Depends on: 15, 16 · Parallel with: 18 Worktree: .agents/scripts/worktree.sh start 19 verify-repoint

Goal

All 42 assertions pin the same user-visible facts against the new architecture. Coverage does not fall.

You are the only role permitted to remove an assertion, and every removal needs a written reason.

The three kinds

Kind	Example	What to do
Content presence	`data-phase="plan"`	re-point at `dist/full-guide/index.html`; the token should survive rendering. If it does not, a component dropped content — stop and report
Implementation detail	`const phases`, `renderTree`, `from './catalog.js'`	obsolete as written, but each pins a feature. Replace with an output-level assertion of that feature. Never drop
Asset version	`app.js?v=20260904-vote-widget`	Astro hashes assets — assert the built HTML references a hashed asset

Steps

pnpm run build, then re-point read() calls at dist/.
Work through all 42 in order. For each: does the fact it pins still exist? Yes → re-point. No → content was lost; escalate.
Add rendered-text snapshot assertions for all ten routes so this class of regression is caught structurally, not by string luck.
Confirm check-tokens.mjs and the extended audit-ui.mjs are in pnpm run verify.

Done when

grep -c 'throw new Error' scripts/verify.mjs ≥ the origin/main baseline
Every removal has a one-line reason in this file
Snapshot assertions cover all ten routes
pnpm run gate green, and it fails when you deliberately delete a paragraph from a component (prove the net works, then revert)

Do not

Do not weaken an assertion to make it pass. If it cannot pass, something is broken — that is the assertion doing its job.

2.5 KiB Raw Blame History