From d0ee9c310161e12d8a89601b24d124dced0e4d81 Mon Sep 17 00:00:00 2001
From: CrossProduct <michael.chung@databites.ca>
Date: Thu, 9 Jan 2025 00:27:15 +0000
Subject: [PATCH] Switching to Full FineTuning

---
 finetrainers/cogvideox/__init__.py               |  1 +
 finetrainers/cogvideox/cogvideox_lora.py         |  2 +-
 finetrainers/hunyuan_video/__init__.py           |  1 +
 finetrainers/hunyuan_video/hunyuan_video_lora.py |  2 +-
 finetrainers/ltx_video/__init__.py               |  1 +
 finetrainers/ltx_video/ltx_video_lora.py         |  2 +-
 finetrainers/models.py                           | 13 ++++++-------
 finetrainers/trainer.py                          |  2 +-
 8 files changed, 13 insertions(+), 11 deletions(-)

diff --git a/finetrainers/cogvideox/__init__.py b/finetrainers/cogvideox/__init__.py
index 6a3f826..9a707b8 100644
--- a/finetrainers/cogvideox/__init__.py
+++ b/finetrainers/cogvideox/__init__.py
@@ -1 +1,2 @@
 from .cogvideox_lora import COGVIDEOX_T2V_LORA_CONFIG
+from .cogvideox_lora import COGVIDEOX_T2V_FULL_FINETUNE_CONFIG
\ No newline at end of file
diff --git a/finetrainers/cogvideox/cogvideox_lora.py b/finetrainers/cogvideox/cogvideox_lora.py
index a536cab..63050f2 100644
--- a/finetrainers/cogvideox/cogvideox_lora.py
+++ b/finetrainers/cogvideox/cogvideox_lora.py
@@ -326,7 +326,7 @@ COGVIDEOX_T2V_LORA_CONFIG = {
     "validation": validation,
 }
 
-COGVIDEOX_T2V_SFT_CONFIG = {
+COGVIDEOX_T2V_FULL_FINETUNE_CONFIG = {
     "pipeline_cls": CogVideoXPipeline,
     "load_condition_models": load_condition_models,
     "load_latent_models": load_latent_models,
diff --git a/finetrainers/hunyuan_video/__init__.py b/finetrainers/hunyuan_video/__init__.py
index f4e780d..1ee2837 100644
--- a/finetrainers/hunyuan_video/__init__.py
+++ b/finetrainers/hunyuan_video/__init__.py
@@ -1 +1,2 @@
 from .hunyuan_video_lora import HUNYUAN_VIDEO_T2V_LORA_CONFIG
+from .hunyuan_video_lora import HUNYUAN_VIDEO_T2V_FULL_FINETUNE_CONFIG
\ No newline at end of file
diff --git a/finetrainers/hunyuan_video/hunyuan_video_lora.py b/finetrainers/hunyuan_video/hunyuan_video_lora.py
index 34ce576..d0d8bce 100644
--- a/finetrainers/hunyuan_video/hunyuan_video_lora.py
+++ b/finetrainers/hunyuan_video/hunyuan_video_lora.py
@@ -359,7 +359,7 @@ HUNYUAN_VIDEO_T2V_LORA_CONFIG = {
     "validation": validation,
 }
 
-HUNYUAN_VIDEO_T2V_SFT_CONFIG = {
+HUNYUAN_VIDEO_T2V_FULL_FINETUNE_CONFIG = {
     "pipeline_cls": HunyuanVideoPipeline,
     "load_condition_models": load_condition_models,
     "load_latent_models": load_latent_models,
diff --git a/finetrainers/ltx_video/__init__.py b/finetrainers/ltx_video/__init__.py
index b583686..0476fc6 100644
--- a/finetrainers/ltx_video/__init__.py
+++ b/finetrainers/ltx_video/__init__.py
@@ -1 +1,2 @@
 from .ltx_video_lora import LTX_VIDEO_T2V_LORA_CONFIG
+from .ltx_video_lora import LTX_VIDEO_T2V_FULL_FINETUNE_CONFIG
\ No newline at end of file
diff --git a/finetrainers/ltx_video/ltx_video_lora.py b/finetrainers/ltx_video/ltx_video_lora.py
index 77ec50e..86b60cf 100644
--- a/finetrainers/ltx_video/ltx_video_lora.py
+++ b/finetrainers/ltx_video/ltx_video_lora.py
@@ -322,7 +322,7 @@ LTX_VIDEO_T2V_LORA_CONFIG = {
     "validation": validation,
 }
 
-LTX_VIDEO_T2V_SFT_CONFIG = {
+LTX_VIDEO_T2V_FULL_FINETUNE_CONFIG = {
     "pipeline_cls": LTXPipeline,
     "load_condition_models": load_condition_models,
     "load_latent_models": load_latent_models,
diff --git a/finetrainers/models.py b/finetrainers/models.py
index e753c4a..d3ece75 100644
--- a/finetrainers/models.py
+++ b/finetrainers/models.py
@@ -1,22 +1,21 @@
 from typing import Any, Dict
 
-from .cogvideox import COGVIDEOX_T2V_LORA_CONFIG, COGVIDEOX_T2V_SFT_CONFIG
-from .hunyuan_video import HUNYUAN_VIDEO_T2V_LORA_CONFIG, HUNYUAN_VIDEO_T2V_SFT_CONFIG
-from .ltx_video import LTX_VIDEO_T2V_LORA_CONFIG, LTX_VIDEO_T2V_SFT_CONFIG
-
+from .cogvideox import COGVIDEOX_T2V_LORA_CONFIG, COGVIDEOX_T2V_FULL_FINETUNE_CONFIG
+from .hunyuan_video import HUNYUAN_VIDEO_T2V_LORA_CONFIG, HUNYUAN_VIDEO_T2V_FULL_FINETUNE_CONFIG
+from .ltx_video import LTX_VIDEO_T2V_LORA_CONFIG, LTX_VIDEO_T2V_FULL_FINETUNE_CONFIG
 
 SUPPORTED_MODEL_CONFIGS = {
     "hunyuan_video": {
         "lora": HUNYUAN_VIDEO_T2V_LORA_CONFIG,
-        "sft": HUNYUAN_VIDEO_T2V_SFT_CONFIG,
+        "full-finetune": HUNYUAN_VIDEO_T2V_FULL_FINETUNE_CONFIG,
     },
     "ltx_video": {
         "lora": LTX_VIDEO_T2V_LORA_CONFIG,
-        "sft": LTX_VIDEO_T2V_SFT_CONFIG,
+        "full-finetune": LTX_VIDEO_T2V_FULL_FINETUNE_CONFIG,
     },
     "cogvideox": {
         "lora": COGVIDEOX_T2V_LORA_CONFIG,
-        "sft": COGVIDEOX_T2V_SFT_CONFIG,
+        "full-finetune": COGVIDEOX_T2V_FULL_FINETUNE_CONFIG,
     },
 }
 
diff --git a/finetrainers/trainer.py b/finetrainers/trainer.py
index d843387..b068c5a 100644
--- a/finetrainers/trainer.py
+++ b/finetrainers/trainer.py
@@ -395,7 +395,7 @@ class Trainer:
             ]
         )
 
-        if self.args.training_type == "sft":
+        if self.args.training_type == "full-finetune":
             logger.info("Full Fine Tuning Enabled")
             self._enable_grad_for_components(components=[self.transformer])
         else: