mirror of
https://github.com/storytold/irsa-manager.git
synced 2026-10-09 00:09:43 +00:00
remove finelizer
This commit is contained in:
@@ -109,14 +109,16 @@ func (r *IRSASetupReconciler) reconcileDelete(ctx context.Context, obj *irsav1al
|
|||||||
}
|
}
|
||||||
kubeHandler := handler.NewKubernetesHandler(kubeClient)
|
kubeHandler := handler.NewKubernetesHandler(kubeClient)
|
||||||
kubeHandler.Append(secret)
|
kubeHandler.Append(secret)
|
||||||
err = selfhosted.Delete(ctx, factory)
|
|
||||||
if err != nil {
|
|
||||||
return err
|
|
||||||
}
|
|
||||||
err = kubeHandler.DeleteAll(ctx)
|
err = kubeHandler.DeleteAll(ctx)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return err
|
return err
|
||||||
}
|
}
|
||||||
|
err = selfhosted.Delete(ctx, factory)
|
||||||
|
if err != nil {
|
||||||
|
return err
|
||||||
|
}
|
||||||
|
controllerutil.RemoveFinalizer(obj, irsamanagerFinalizer)
|
||||||
|
|
||||||
return nil
|
return nil
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -52,7 +52,7 @@ var _ = Describe("IRSASetup Controller", func() {
|
|||||||
Namespace: "default",
|
Namespace: "default",
|
||||||
},
|
},
|
||||||
Spec: irsav1alpha1.IRSASetupSpec{
|
Spec: irsav1alpha1.IRSASetupSpec{
|
||||||
Mode: "selfhoted",
|
Mode: "selfhosted",
|
||||||
Discovery: irsav1alpha1.Discovery{
|
Discovery: irsav1alpha1.Discovery{
|
||||||
S3: irsav1alpha1.S3Discovery{
|
S3: irsav1alpha1.S3Discovery{
|
||||||
Region: "ap-northeast-1",
|
Region: "ap-northeast-1",
|
||||||
|
|||||||
Reference in New Issue
Block a user