bugfix irsa truct policy setting

2026-10-09 00:09:43 +00:00 · 2024-05-25 21:54:28 +09:00
parent a3d758a37c
commit 9cc6d08eb5
4 changed files with 26 additions and 7 deletions
@@ -16,8 +16,13 @@ type S3IssuerMeta struct {
 	bucketName string
 }

-func NewS3IssuerMeta(s3 irsav1alpha1.S3Discovery) *S3IssuerMeta {
-	return &S3IssuerMeta{s3.Region, s3.BucketName}
+func NewS3IssuerMeta(s3 *irsav1alpha1.S3Discovery) (*S3IssuerMeta, error) {
+	region := s3.Region
+	bucketName := s3.BucketName
+	if region == "" || bucketName == "" {
+		return nil, fmt.Errorf("s3 region and bucket name must not be empty. region: %s, bucketName: %s", region, bucketName)
+	}
+	return &S3IssuerMeta{region, bucketName}, nil
 }

 func (i *S3IssuerMeta) IssuerHostPath() string {