storytold/lightcraft
2
0
Fork 0
mirror of https://github.com/storytold/lightcraft.git synced 2026-11-07 19:03:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

Light tests allow a level of 8-bit dither (#3779)

Browse Source 
Process V4's tests and the 8-bit dither landed separately, and each
passed its own gate: a flat source now varies by a level, and a ramp can
step back by one. The tests compared exact 8-bit values.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
FredApps
2026-11-05 07:44:24 +01:00
committed by GitHub
parent 8972565249
commit eaef01e986
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/pipeline/src/tests_light.rs
+4 -2
View File
@@ -38,7 +38,8 @@ fn check_luminance_cutoff(chroma: f32, pixel: [f32; 3], expected: [u8; 4]) {
s.light.contrast = 100.0;
s.light.blacks = 80.0;
let image = render(&src, &info, &s, &RenderRequest::fit(64, 64)).image;
assert!(image.data.iter().all(|p| *p == image.data[0]));
// (8-bit output is dithered: a flat source varies by a level)
assert!(image.data.iter().all(|p| p.iter().zip(image.data[0]).all(|(a, b)| a.abs_diff(b) <= 1)));
for (actual, expected) in image.data[0].into_iter().zip(expected) {
assert!(actual.abs_diff(expected) <= 1, "chroma {chroma}: {:?}, expected {expected}", image.data[0]);
}
@@ -311,7 +312,8 @@ fn v3_sliders_move_a_grey_ramp_their_way() {
("light.blacks", -60.0),
] {
let r = shot(id, v);
assert!(r.windows(2).all(|w| luma(w[1]) >= luma(w[0])), "{id} {v}: the ramp is no longer increasing");
// (within a level of 8-bit dither)
assert!(r.windows(2).all(|w| luma(w[1]) >= luma(w[0]) - 1), "{id} {v}: the ramp is no longer increasing");
assert!(r.iter().all(|p| p[0].abs_diff(p[1]) <= 1 && p[1].abs_diff(p[2]) <= 1), "{id} {v}: the ramp is no longer grey");
let diff = |lo: usize, hi: usize| (lo..hi).map(|x| luma(r[x]) - luma(plain[x])).sum::<i32>();
let (dark, light) = (diff(40, 90), diff(170, 220));