storytold/spark
2
0
Fork 0
mirror of https://github.com/storytold/spark.git synced 2026-10-27 08:58:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use FullScreenQuad instead of custom setup (#121)

Browse Source
This commit is contained in:
Noeri Huisman
2025-07-16 18:42:52 +02:00
committed by GitHub
parent f114f73331
commit 1e697b397c
2 changed files with 10 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/PackedSplats.ts
+5 -8
View File
@@ -1,4 +1,5 @@
import * as THREE from "three"; import * as THREE from "three";
import { FullScreenQuad } from "three/addons/postprocessing/Pass.js";
import type { GsplatGenerator } from "./SplatGenerator"; import type { GsplatGenerator } from "./SplatGenerator";
import { type SplatFileType, SplatLoader, unpackSplats } from "./SplatLoader"; import { type SplatFileType, SplatLoader, unpackSplats } from "./SplatLoader";
@@ -498,7 +499,7 @@ export class PackedSplats {
// Prepare and update our material we'll use to render the Gsplats // Prepare and update our material we'll use to render the Gsplats
const material = program.prepareMaterial(); const material = program.prepareMaterial();
PackedSplats.mesh.material = material; PackedSplats.fullScreenQuad.material = material;
return { program, material }; return { program, material };
} }
@@ -579,7 +580,7 @@ export class PackedSplats {
renderer.setRenderTarget(this.target, layer); renderer.setRenderTarget(this.target, layer);
renderer.xr.enabled = false; renderer.xr.enabled = false;
renderer.autoClear = false; renderer.autoClear = false;
renderer.render(PackedSplats.scene, PackedSplats.camera); PackedSplats.fullScreenQuad.render(renderer);
base += SPLAT_TEX_WIDTH * (layerYEnd - layerYStart); base += SPLAT_TEX_WIDTH * (layerYEnd - layerYStart);
} }
@@ -593,14 +594,10 @@ export class PackedSplats {
// Cache for GsplatGenerator programs // Cache for GsplatGenerator programs
static generatorProgram = new Map<GsplatGenerator, DynoProgram>(); static generatorProgram = new Map<GsplatGenerator, DynoProgram>();
// Static Three.js objects for pseudo-compute shader rendering // Static full-screen quad for pseudo-compute shader rendering
static geometry = new THREE.PlaneGeometry(2, 2); static fullScreenQuad = new FullScreenQuad(
static mesh = new THREE.Mesh(
PackedSplats.geometry,
new THREE.RawShaderMaterial({ visible: false }), new THREE.RawShaderMaterial({ visible: false }),
); );
static scene = new THREE.Scene().add(PackedSplats.mesh);
static camera = new THREE.Camera();
} }
// You can use a PackedSplats as a dyno block using the function // You can use a PackedSplats as a dyno block using the function
src/Readback.ts
+5 -8
View File
@@ -1,4 +1,5 @@
import * as THREE from "three"; import * as THREE from "three";
import { FullScreenQuad } from "three/addons/postprocessing/Pass.js";
import { SPLAT_TEX_HEIGHT, SPLAT_TEX_WIDTH } from "./defines"; import { SPLAT_TEX_HEIGHT, SPLAT_TEX_WIDTH } from "./defines";
import { type Dyno, OutputRgba8, dynoBlock } from "./dyno"; import { type Dyno, OutputRgba8, dynoBlock } from "./dyno";
@@ -124,7 +125,7 @@ export class Readback {
} }
const material = program.prepareMaterial(); const material = program.prepareMaterial();
Readback.mesh.material = material; Readback.fullScreenQuad.material = material;
return { program, material }; return { program, material };
} }
@@ -181,7 +182,7 @@ export class Readback {
renderer.setRenderTarget(this.target, layer); renderer.setRenderTarget(this.target, layer);
renderer.xr.enabled = false; renderer.xr.enabled = false;
renderer.autoClear = false; renderer.autoClear = false;
renderer.render(Readback.scene, Readback.camera); Readback.fullScreenQuad.render(renderer);
baseIndex += SPLAT_TEX_WIDTH * layerYEnd; baseIndex += SPLAT_TEX_WIDTH * layerYEnd;
} }
@@ -330,12 +331,8 @@ export class Readback {
// Cache for Rgba8Readback programs // Cache for Rgba8Readback programs
static readbackProgram = new Map<Rgba8Readback, DynoProgram>(); static readbackProgram = new Map<Rgba8Readback, DynoProgram>();
// Static Three.js objects for pseudo-compute shader rendering // Static full-screen quad for pseudo-compute shader rendering
static geometry = new THREE.PlaneGeometry(2, 2); static fullScreenQuad = new FullScreenQuad(
static mesh = new THREE.Mesh(
Readback.geometry,
new THREE.RawShaderMaterial({ visible: false }), new THREE.RawShaderMaterial({ visible: false }),
); );
static scene = new THREE.Scene().add(Readback.mesh);
static camera = new THREE.Camera();
} }