Pre-commit fixes (#44)

* Pre-commit fixes

* Restrict terraform version to < 1.3.0

* fixup! Restrict terraform version to < 1.3.0

* fixup! Restrict terraform version to < 1.3.0

* Pinned min version to 1.1.0, support for nullable

* Update README.md
This commit is contained in:
Rodrigue Koffi
2022-09-27 23:40:14 +02:00
committed by GitHub
parent 9f0b90ab2f
commit 3b1b530050
27 changed files with 128 additions and 145 deletions
+27 -6
View File
@@ -41,6 +41,13 @@ jobs:
matrix:
directory: ${{ fromJson(needs.collectInputs.outputs.directories) }}
steps:
- name: Remove default Terraform
run: rm -rf $(which terraform)
- name: Should fail
continue-on-error: true
run: terraform version
- name: Checkout
uses: actions/checkout@v3
@@ -73,27 +80,37 @@ jobs:
with:
directory: ${{ matrix.directory }}
- name: Pre-commit Terraform ${{ steps.minMax.outputs.minVersion }}
- name: Pre-commit Terraform 1.1.0 #${{ steps.minMax.outputs.minVersion }}
uses: clowdhaus/terraform-composite-actions/pre-commit@v1.6.0
# Run only validate pre-commit check on min version supported
if: ${{ matrix.directory != '.' && steps.changes.outputs.src== 'true' }}
with:
terraform-version: ${{ steps.minMax.outputs.minVersion }}
terraform-version: 1.1.0 # ${{ steps.minMax.outputs.minVersion }}
args: 'terraform_validate --color=always --show-diff-on-failure --files ${{ matrix.directory }}/*'
- name: Pre-commit Terraform ${{ steps.minMax.outputs.minVersion }}
- name: Pre-commit Terraform 1.1.0 #${{ steps.minMax.outputs.minVersion }}
uses: clowdhaus/terraform-composite-actions/pre-commit@v1.6.0
# Run only validate pre-commit check on min version supported
if: ${{ matrix.directory == '.' && steps.changes.outputs.src== 'true' }}
with:
terraform-version: ${{ steps.minMax.outputs.minVersion }}
terraform-version: 1.1.0 #${{ steps.minMax.outputs.minVersion }}
args: 'terraform_validate --color=always --show-diff-on-failure --files $(ls *.tf)'
- if: steps.changes.outputs.src== 'true'
run: terraform version
preCommitMaxVersion:
name: Max TF pre-commit
runs-on: ubuntu-latest
needs: collectInputs
steps:
- name: Remove default Terraform
run: rm -rf $(which terraform)
- name: Should fail
continue-on-error: true
run: terraform version
- name: Checkout
uses: actions/checkout@v3
@@ -125,10 +142,14 @@ jobs:
uses: clowdhaus/terraform-min-max@v1.0.7
if: steps.changes.outputs.src== 'true'
- name: Pre-commit Terraform ${{ steps.minMax.outputs.maxVersion }}
# TODO - remove hardcoded version once optional attributes are resolved/removed
- name: Pre-commit Terraform 1.2.9 # ${{ steps.minMax.outputs.maxVersion }}
uses: clowdhaus/terraform-composite-actions/pre-commit@v1.6.0
if: steps.changes.outputs.src== 'true'
with:
terraform-version: ${{ steps.minMax.outputs.maxVersion }}
terraform-version: 1.2.9 # ${{ steps.minMax.outputs.maxVersion }}
terraform-docs-version: ${{ env.TERRAFORM_DOCS_VERSION }}
tflint-version: ${{ env.TFLINT_VERSION }}
- if: steps.changes.outputs.src== 'true'
run: terraform version