masi/papercraft
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases 18 Wiki Activity

[feature] Feedback: resolved notes and per-page counts are easy to miss #7

New Issue
Closed
opened 2026-10-17 22:14:33 +00:00 by masi · 1 comment
masi commented 2026-10-17 22:14:33 +00:00
Owner
Copy Link
Copy Source

Context: feedback notes on layers.
Expected: get_basic_info.openFeedback and get_feedback surface notes the owner just left.
Actual: notes marked resolved are hidden unless includeResolved:true, and openFeedback was 0 while notes existed on two pages, so a reviewer who relies on the default misses them. get_feedback also takes one pageId, so every page must be queried.
Repro: leave a note on a layer, resolve it, call get_feedback (count 0) and then with includeResolved:true (count 1).
Workaround: query every page with includeResolved:true at session start.
Impact: review notes get lost. Suggest get_basic_info returning per-page counts of open and resolved notes, and a pageId-less project-wide query.

**Context:** feedback notes on layers. **Expected:** `get_basic_info.openFeedback` and `get_feedback` surface notes the owner just left. **Actual:** notes marked resolved are hidden unless `includeResolved:true`, and `openFeedback` was 0 while notes existed on two pages, so a reviewer who relies on the default misses them. `get_feedback` also takes one `pageId`, so every page must be queried. **Repro:** leave a note on a layer, resolve it, call `get_feedback` (count 0) and then with `includeResolved:true` (count 1). **Workaround:** query every page with `includeResolved:true` at session start. **Impact:** review notes get lost. Suggest `get_basic_info` returning per-page counts of open and resolved notes, and a `pageId`-less project-wide query.
masi commented 2026-10-17 23:05:04 +00:00
Author
Owner
Copy Link
Copy Source

Fixed in commit 5169fe6 and released in v0.3.1.

Fixed in commit 5169fe6 and released in v0.3.1.
masi closed this issue 2026-10-17 23:05:08 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
masi
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: masi/papercraft#7
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?