567ee63c7a
New agent tools (98 to 104): - export_site writes a website from frames in one call: plain HTML, Astro, Vue (Nuxt or Vite), React (Next or Vite) or Angular; css, scss or tailwind, and for React vanilla-extract, styled-components or emotion; static pages or a single-page app; a folder per language. Fonts are subset to WOFF2 with metric-matched fallbacks, images are resized, headings follow the outline, pages reflow below the designed width, and _headers, vercel.json, _redirects and .nojekyll cache hashed assets for a year. - get_strings and set_strings treat languages as variable modes: read a page's text for translation, fill a language or a pseudo-locale. - get_context says where the agent is, what is cheap to read next and what lint found, in one call; big reads take maxTokens and report estimatedTokens. - import_html opens a page from a prompt-to-design tool (.html or .zip) as layers. - install_font adds fonts on top of the bundled Inter; text can name one. App: - Present mode plays a page's frames as a prototype: links jump to frames, open overlays, go back or open an address. - Panics are kept in crash.log; release builds keep line tables so its traces name files and lines. - Settings > Canvas is kept between sessions; a keyboard shortcuts sheet; icons in the menus. - Chat: an opencode turn waiting out a rate limit moves on to the fallback model. - The updater checks each download against the SHA-256 GitHub publishes. Fixes: - A NaN or infinite tool argument no longer makes a project unopenable. - Agent paths cannot reach other machines, devices or NTFS streams; a tool writes only its own file type, and fills only a new, empty or earlier export folder. - delegate and imagegen pass each value in its own environment variable, never as shell syntax. - An instance placed inside its own component is refused. - A panic in a tool fails that call instead of closing the app. - An agent call during a drag waits for it, so the undo step stays whole. - Sync holds downloads while the open project has unsaved edits, writes pages atomically, and leaves a page saved while its download was in flight for the next round to merge. Merges repair the tree instead of giving a node two parents or orphaning it. - Share tokens come from the OS random generator. - Imports have a total memory cap; Excalidraw import is linear. - Unused images are freed when a project opens. - Pages that use no added font are still written as format 3, so 0.9.1 can open them. - Code export escapes text, attributes and CSS in one place. CI: a clippy job (warnings do not fail it yet). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01J9PiVCQxc2QYmArFq9VBUX
348 lines
12 KiB
Rust
348 lines
12 KiB
Rust
//! Updater backend: version ordering, installer selection and URL hardening.
|
|
//!
|
|
//! Everything here is a fixture: no network, no downloads.
|
|
|
|
use papercraft::update::{Asset, parse_release, validate_asset};
|
|
|
|
const HOST: &str = "https://github.com";
|
|
const DIGEST: &str = "0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef";
|
|
const DOWNLOAD: &str = "https://github.com/nxtime/papercraft/releases/download";
|
|
|
|
/// A release feed with the given assets.
|
|
fn feed(version: &str, assets: &[(&str, &str)]) -> String {
|
|
let mut list = String::new();
|
|
for (name, url) in assets {
|
|
if !list.is_empty() {
|
|
list.push(',');
|
|
}
|
|
list.push_str(&format!(
|
|
r#"{{"name":"{name}","browser_download_url":"{url}","size":1024,"digest":"sha256:{DIGEST}"}}"#
|
|
));
|
|
}
|
|
format!(
|
|
r#"{{"tag_name":"{version}","body":"notes","draft":false,"prerelease":false,"html_url":"{HOST}/nxtime/papercraft/releases/tag/{version}","assets":[{list}]}}"#
|
|
)
|
|
}
|
|
|
|
/// The download URL of an asset of a release.
|
|
fn url(version: &str, name: &str) -> String {
|
|
format!("{DOWNLOAD}/v{version}/{name}")
|
|
}
|
|
|
|
/// The macOS installer of a release.
|
|
fn macos_asset(version: &str, arch: &str) -> (String, String) {
|
|
let name = format!("papercraft-{version}-macos-{arch}.dmg");
|
|
let asset_url = url(version, &name);
|
|
(name, asset_url)
|
|
}
|
|
|
|
/// The Windows installer of a release.
|
|
fn windows_asset(version: &str, arch: &str) -> (String, String) {
|
|
let name = format!("papercraft-{version}-windows-{arch}.msi");
|
|
let asset_url = url(version, &name);
|
|
(name, asset_url)
|
|
}
|
|
|
|
#[test]
|
|
fn newer_release_is_offered() {
|
|
let json = feed("v0.4.0", &[]);
|
|
let release = parse_release(&json, "0.3.1", "macos", "aarch64")
|
|
.expect("feed parses")
|
|
.expect("a newer release exists");
|
|
assert_eq!(release.version, "0.4.0");
|
|
assert_eq!(release.notes, "notes");
|
|
assert_eq!(
|
|
release.url,
|
|
format!("{HOST}/nxtime/papercraft/releases/tag/v0.4.0")
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn same_version_is_up_to_date() {
|
|
let json = feed("v0.3.1", &[]);
|
|
assert!(
|
|
parse_release(&json, "0.3.1", "macos", "aarch64")
|
|
.expect("feed parses")
|
|
.is_none()
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn older_release_is_up_to_date() {
|
|
let json = feed("v0.3.0", &[]);
|
|
assert!(
|
|
parse_release(&json, "0.3.1", "macos", "aarch64")
|
|
.expect("feed parses")
|
|
.is_none()
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn versions_compare_numerically_not_alphabetically() {
|
|
let json = feed("v0.10.0", &[]);
|
|
assert!(
|
|
parse_release(&json, "0.9.0", "macos", "aarch64")
|
|
.expect("feed parses")
|
|
.is_some(),
|
|
"0.10.0 is newer than 0.9.0"
|
|
);
|
|
let json = feed("v0.2.0", &[]);
|
|
assert!(
|
|
parse_release(&json, "0.10.0", "macos", "aarch64")
|
|
.expect("feed parses")
|
|
.is_none(),
|
|
"0.2.0 is older than 0.10.0"
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn drafts_and_prereleases_are_refused() {
|
|
let draft = feed("v0.4.0", &[]).replace("\"draft\":false", "\"draft\":true");
|
|
assert!(parse_release(&draft, "0.3.1", "macos", "aarch64").is_err());
|
|
|
|
let pre = feed("v0.4.0", &[]).replace("\"prerelease\":false", "\"prerelease\":true");
|
|
assert!(parse_release(&pre, "0.3.1", "macos", "aarch64").is_err());
|
|
}
|
|
|
|
#[test]
|
|
fn malformed_versions_are_refused() {
|
|
let json = feed("not-a-version", &[]);
|
|
assert!(parse_release(&json, "0.3.1", "macos", "aarch64").is_err());
|
|
assert!(parse_release(&json, "also-not-a-version", "macos", "aarch64").is_err());
|
|
assert!(parse_release("{not json", "0.3.1", "macos", "aarch64").is_err());
|
|
}
|
|
|
|
#[test]
|
|
fn macos_picks_the_native_build() {
|
|
let (native, native_url) = macos_asset("0.4.0", "aarch64");
|
|
let (universal, universal_url) = macos_asset("0.4.0", "universal");
|
|
let json = feed(
|
|
"v0.4.0",
|
|
&[
|
|
(native.as_str(), native_url.as_str()),
|
|
(universal.as_str(), universal_url.as_str()),
|
|
],
|
|
);
|
|
let release = parse_release(&json, "0.3.1", "macos", "aarch64")
|
|
.expect("feed parses")
|
|
.expect("a newer release exists");
|
|
let asset = release.asset.expect("a macOS installer");
|
|
assert_eq!(asset.name, native);
|
|
assert_eq!(asset.url, native_url);
|
|
assert_eq!(asset.size, 1024);
|
|
}
|
|
|
|
#[test]
|
|
fn macos_falls_back_to_the_universal_build() {
|
|
let (universal, universal_url) = macos_asset("0.4.0", "universal");
|
|
let (other, other_url) = macos_asset("0.4.0", "x86_64");
|
|
let json = feed(
|
|
"v0.4.0",
|
|
&[
|
|
(other.as_str(), other_url.as_str()),
|
|
(universal.as_str(), universal_url.as_str()),
|
|
],
|
|
);
|
|
let release = parse_release(&json, "0.3.1", "macos", "aarch64")
|
|
.expect("feed parses")
|
|
.expect("a newer release exists");
|
|
let asset = release.asset.expect("a macOS installer");
|
|
assert_eq!(asset.name, universal);
|
|
}
|
|
|
|
#[test]
|
|
fn macos_without_an_installer_reports_no_asset() {
|
|
let json = feed("v0.4.0", &[]);
|
|
let release = parse_release(&json, "0.3.1", "macos", "aarch64")
|
|
.expect("feed parses")
|
|
.expect("a newer release exists");
|
|
assert!(release.asset.is_none(), "no installer for this machine");
|
|
}
|
|
|
|
#[test]
|
|
fn windows_maps_every_architecture() {
|
|
let (x64, x64_url) = windows_asset("0.4.0", "x64");
|
|
let (arm64, arm64_url) = windows_asset("0.4.0", "arm64");
|
|
let (x86, x86_url) = windows_asset("0.4.0", "x86");
|
|
let json = feed(
|
|
"v0.4.0",
|
|
&[
|
|
(x64.as_str(), x64_url.as_str()),
|
|
(arm64.as_str(), arm64_url.as_str()),
|
|
(x86.as_str(), x86_url.as_str()),
|
|
],
|
|
);
|
|
for (arch, expected) in [("x86_64", &x64), ("aarch64", &arm64), ("x86", &x86)] {
|
|
let release = parse_release(&json, "0.3.1", "windows", arch)
|
|
.expect("feed parses")
|
|
.expect("a newer release exists");
|
|
let asset = release.asset.expect("a Windows installer");
|
|
assert_eq!(&asset.name, expected, "windows/{arch}");
|
|
}
|
|
}
|
|
|
|
#[test]
|
|
fn linux_gets_the_release_page_but_no_installer() {
|
|
let json = feed("v0.4.0", &[]);
|
|
let release = parse_release(&json, "0.3.1", "linux", "x86_64")
|
|
.expect("feed parses")
|
|
.expect("a newer release exists");
|
|
assert!(release.asset.is_none(), "no Linux installer is published");
|
|
assert!(release.url.starts_with(HOST));
|
|
}
|
|
|
|
#[test]
|
|
fn cli_and_web_archives_are_never_selected() {
|
|
let cli = "papercraft-cli-0.4.0-macos-aarch64.zip";
|
|
let web = "papercraft-web-0.4.0.zip";
|
|
let json = feed(
|
|
"v0.4.0",
|
|
&[(cli, &url("0.4.0", cli)), (web, &url("0.4.0", web))],
|
|
);
|
|
let release = parse_release(&json, "0.3.1", "macos", "aarch64")
|
|
.expect("feed parses")
|
|
.expect("a newer release exists");
|
|
assert!(release.asset.is_none(), "only archives were published");
|
|
}
|
|
|
|
#[test]
|
|
fn windows_offers_the_installer_and_the_portable_bundle_separately() {
|
|
let (msi, msi_url) = windows_asset("0.4.0", "x64");
|
|
let zip = "papercraft-0.4.0-windows-x64-portable.zip";
|
|
let exe = "papercraft-0.4.0-windows-x64-portable.exe";
|
|
let json = feed(
|
|
"v0.4.0",
|
|
&[(msi.as_str(), msi_url.as_str()), (zip, &url("0.4.0", zip)), (exe, &url("0.4.0", exe))],
|
|
);
|
|
let release = parse_release(&json, "0.3.1", "windows", "x86_64")
|
|
.expect("feed parses")
|
|
.expect("a newer release exists");
|
|
assert_eq!(release.asset.expect("the installer").name, msi);
|
|
let portable = release.portable.expect("the bundle");
|
|
assert_eq!(portable.name, zip);
|
|
assert!(validate_asset(&portable).is_ok());
|
|
}
|
|
|
|
#[test]
|
|
fn a_release_without_a_checksum_cannot_be_downloaded() {
|
|
let asset = Asset {
|
|
name: "papercraft-0.4.0-macos-aarch64.dmg".into(),
|
|
url: url("0.4.0", "papercraft-0.4.0-macos-aarch64.dmg"),
|
|
size: 1024,
|
|
digest: String::new(),
|
|
};
|
|
assert!(validate_asset(&asset).is_err());
|
|
}
|
|
|
|
#[test]
|
|
fn foreign_hosts_are_refused() {
|
|
let name = "papercraft-0.4.0-macos-aarch64.dmg";
|
|
let evil = format!("https://evil.example.com/nxtime/papercraft/releases/download/v0.4.0/{name}");
|
|
let json = feed("v0.4.0", &[(name, &evil)]);
|
|
assert!(parse_release(&json, "0.3.1", "macos", "aarch64").is_err());
|
|
}
|
|
|
|
#[test]
|
|
fn plain_http_is_refused() {
|
|
let name = "papercraft-0.4.0-macos-aarch64.dmg";
|
|
let plain =
|
|
format!("http://github.com/nxtime/papercraft/releases/download/v0.4.0/{name}");
|
|
let json = feed("v0.4.0", &[(name, &plain)]);
|
|
assert!(parse_release(&json, "0.3.1", "macos", "aarch64").is_err());
|
|
}
|
|
|
|
#[test]
|
|
fn credentials_and_ports_are_refused() {
|
|
let name = "papercraft-0.4.0-macos-aarch64.dmg";
|
|
let creds = format!(
|
|
"https://user:pass@github.com/nxtime/papercraft/releases/download/v0.4.0/{name}"
|
|
);
|
|
let json = feed("v0.4.0", &[(name, &creds)]);
|
|
assert!(parse_release(&json, "0.3.1", "macos", "aarch64").is_err());
|
|
|
|
let port = format!(
|
|
"https://github.com:8443/nxtime/papercraft/releases/download/v0.4.0/{name}"
|
|
);
|
|
let json = feed("v0.4.0", &[(name, &port)]);
|
|
assert!(parse_release(&json, "0.3.1", "macos", "aarch64").is_err());
|
|
}
|
|
|
|
#[test]
|
|
fn fragments_are_refused() {
|
|
let name = "papercraft-0.4.0-macos-aarch64.dmg";
|
|
let fragment = format!("{DOWNLOAD}/v0.4.0/{name}#evil");
|
|
let json = feed("v0.4.0", &[(name, &fragment)]);
|
|
assert!(parse_release(&json, "0.3.1", "macos", "aarch64").is_err());
|
|
}
|
|
|
|
#[test]
|
|
fn release_pages_of_other_repositories_are_refused() {
|
|
let json = feed("v0.4.0", &[]).replace(
|
|
&format!("{HOST}/nxtime/papercraft/releases/tag/v0.4.0"),
|
|
"https://github.com/other/repo/releases/tag/v0.4.0",
|
|
);
|
|
assert!(parse_release(&json, "0.3.1", "macos", "aarch64").is_err());
|
|
}
|
|
|
|
#[test]
|
|
fn traversing_asset_names_are_refused() {
|
|
let name = "../../etc/passwd";
|
|
let asset_url = format!("{DOWNLOAD}/v0.4.0/{name}");
|
|
let json = feed("v0.4.0", &[(name, &asset_url)]);
|
|
assert!(parse_release(&json, "0.3.1", "macos", "aarch64").is_err());
|
|
}
|
|
|
|
#[test]
|
|
fn asset_names_must_match_their_url() {
|
|
let name = "papercraft-0.4.0-macos-aarch64.dmg";
|
|
let other = "papercraft-0.4.0-macos-x86_64.dmg";
|
|
let json = feed("v0.4.0", &[(name, &url("0.4.0", other))]);
|
|
assert!(parse_release(&json, "0.3.1", "macos", "aarch64").is_err());
|
|
}
|
|
|
|
#[test]
|
|
fn validate_asset_accepts_an_official_installer() {
|
|
let asset = Asset {
|
|
name: "papercraft-0.4.0-macos-aarch64.dmg".into(),
|
|
url: url("0.4.0", "papercraft-0.4.0-macos-aarch64.dmg"),
|
|
size: 1024,
|
|
digest: DIGEST.into(),
|
|
};
|
|
assert!(validate_asset(&asset).is_ok());
|
|
}
|
|
|
|
#[test]
|
|
fn validate_asset_refuses_archives_and_foreign_urls() {
|
|
let archive = Asset {
|
|
name: "papercraft-cli-0.4.0-macos-aarch64.zip".into(),
|
|
url: url("0.4.0", "papercraft-cli-0.4.0-macos-aarch64.zip"),
|
|
size: 1024,
|
|
digest: DIGEST.into(),
|
|
};
|
|
assert!(validate_asset(&archive).is_err());
|
|
|
|
let foreign = Asset {
|
|
name: "papercraft-0.4.0-macos-aarch64.dmg".into(),
|
|
url: "https://evil.example.com/papercraft-0.4.0-macos-aarch64.dmg".into(),
|
|
size: 1024,
|
|
digest: DIGEST.into(),
|
|
};
|
|
assert!(validate_asset(&foreign).is_err());
|
|
|
|
let traversal = Asset {
|
|
name: "../papercraft-0.4.0-macos-aarch64.dmg".into(),
|
|
url: url("0.4.0", "../papercraft-0.4.0-macos-aarch64.dmg"),
|
|
size: 1024,
|
|
digest: DIGEST.into(),
|
|
};
|
|
assert!(validate_asset(&traversal).is_err());
|
|
|
|
let huge = Asset {
|
|
name: "papercraft-0.4.0-macos-aarch64.dmg".into(),
|
|
url: url("0.4.0", "papercraft-0.4.0-macos-aarch64.dmg"),
|
|
size: 512 * 1024 * 1024,
|
|
digest: DIGEST.into(),
|
|
};
|
|
assert!(validate_asset(&huge).is_err());
|
|
}
|