masi/solvecraft
1
0
Fork 0
mirror of https://github.com/bherbruck/solidcraft.git synced 2026-11-03 02:25:55 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity

Blend refusals name their solidcore issues (#960, #1438, #1439, #430)

Browse Source 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SdcgExNEwfR9CX2RAzp2Pt
This commit is contained in:
Brett Lawson
2026-10-29 00:07:03 +01:00
parent aa77bcabb1
commit 5140556c71
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/smlib/src/core/blend.rs
+4 -4
View File
@@ -14,12 +14,12 @@
//! What the capi asks of fork-only SMLib code that solidcore does not have is
//! [`Error::Unsupported`], refused where the capi would first reach it, so every error before
//! it is the C++ path's:
//! - a curvature-continuous blend (`SetBlendCurveAtThirds`, fork fd3b6a7);
//! - a corner left open (`SetMarkCornerPatches`, fork 60af574);
//! - a variable radius whose law has a corner (`SplitFilletFacesAtRadiusCorners`, fork 6eecf04).
//! - a curvature-continuous blend (`SetBlendCurveAtThirds`, fork fd3b6a7; solidcore#1438);
//! - a corner left open (`SetMarkCornerPatches`, fork 60af574; solidcore#1439);
//! - a variable radius whose law has a corner (`SplitFilletFacesAtRadiusCorners`, fork 6eecf04; solidcore#430, PR #1403).
//!
//! - a blend whose rail leaves its face, which the fork may build over the cliff
//! (`SmFilletCliffOverflow.cpp`, fork 8ba4667) and solidcore always refuses ([`blend_failure`]).
//! (`SmFilletCliffOverflow.cpp`, fork 8ba4667; solidcore#960) and solidcore always refuses ([`blend_failure`]).
//!
//! solidcore's own refusals of code it has not ported (`SolidError::Unported`) are
//! [`Error::Unsupported`] too.
crates/smlib/src/core/blend_tests.rs
+1 -1
View File
@@ -360,7 +360,7 @@ cases!(
fillet_cylinder_rim,
setback_corner,
fillet_variable_linear,
fillet_over_a_cliff: ignore = "solidcore: no cliff overflow (fork 8ba4667)",
fillet_over_a_cliff: ignore = "solidcore#960: no cliff overflow (fork 8ba4667)",
fillet_too_large,
pick_near_nothing,
pick_ambiguous,