masi/solvecraft
1
0
Fork 0
mirror of https://github.com/bherbruck/solidcraft.git synced 2026-11-03 02:25:55 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity

Hover test: allow the first hover half of the index time, not a third (#9638)

Browse Source 
On a loaded runner the hover alone has taken 70 ms against a 190 ms index, which failed
unrelated pull requests. Waiting for the index would still cost all of it.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
bherbruck
2026-10-30 19:41:24 +00:00
committed by GitHub
parent dfdad35d08
commit 56f07a5598
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/ui-egui/src/preselect_tests.rs
+3 -1
View File
@@ -2773,7 +2773,9 @@ fn hovering_a_large_body_does_not_wait_for_its_pick_index() {
h.step(&json!({"move": at})).unwrap();
let hover_ms = t.elapsed().as_secs_f64() * 1000.0;
assert!(matches!(h.app.viewport.hover, Some(crate::viewport::Hit::Face { .. })), "{:?}", h.app.viewport.hover);
assert!(hover_ms < index_ms / 3.0, "the first hover took {hover_ms:.1} ms; making the index takes {index_ms:.1} ms");
// Half, not a third: on a loaded runner the hover alone has taken 70 ms against a 190 ms index.
// Waiting for the index would cost the whole of it, so half still tells the two apart.
assert!(hover_ms < index_ms / 2.0, "the first hover took {hover_ms:.1} ms; making the index takes {index_ms:.1} ms");
}
/// #4452: with Combine open, bodies clicked in the Browser fill its inputs, as clicks on them