003 and 004 passed on one valid body alone. 003 is now the flange less
its M30 groove (stopped clear of the root round, run out through the
chamfer) and three M8 tap drills; 004 is 10/008 less the M16 groove on
the shelled boss, which cuts the wall only. With bboxes. Both hold on
SMLib (worst 1.4e-7 relative).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
It passed on one valid body alone. Each d3 vent goes through the shelled
top skin into the cavity and meets nothing else, so the case is 09/011
less 4 pi 1.5^2 1.5; with the bbox. Holds on SMLib (1e-6 relative).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
010, 011 and 014 passed on one valid body alone. 010 (top rounds in
mitres, shelled open below) and 014 (drafted box with tilted rounds:
every level section loses the same elliptic corner) now check closed-form
volumes, exact counts and bbox (014 also its centre of mass). 011, the
running part shelled 1.5, checks the part less its cavity built feature
by feature, the offset faces meeting sharp at concave edges as in the
rest of the tier (a distance-based offset would differ by 0.3%). All hold
on SMLib (worst 1e-6 relative).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
It passed on one valid body alone. It now checks the chamfer's prism, the
two r2 rounds below it and the columns they carry on up into the chamfer
face (the section's first moment), with exact counts and bbox. Holds on
SMLib (8e-9 relative).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
010, 011 and 012 passed on one valid body alone. 010 (r7 then an r3 chain
round its arc) and 011 (two r5 rounds in a mitre) now check closed-form
volumes, counts and bbox; 012's variable round takes only its edge and
runs on into the vertical round's column, so its volume is graded as the
interval between that end carried on as a constant r5 tube and as its
growing radius. All hold on SMLib (worst 4e-8 relative; 012 at the
growing-radius end).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
010 passed on one valid body alone: it now checks the tier-05 part less
the M16 groove (stopped w above the boss's shoulder, run out at its free
top) and the bbox. Two new cases with closed forms: 018, an M10 cut both
hands, whose crossing grooves leave the material fraction squared
(2 pi L int r m^2 dr, exact for L a whole number of pitches); 019, a
two-start Tr40x14(P7), six pitches of the Tr40x7 section. All hold on
SMLib (worst 2e-6 relative).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
07, 08, 09, 11 and 12 passed on one valid body alone. Each now checks
its volume, bbox and (where derived) counts, area and centre of mass:
the three-section loft is the degree-2 interpolant r = 10 + (z-20)^2/40;
the square-to-circle loft a ruled prismatoid, its mixed area from the
sides ruled to rational quarter arcs; the periodic fit spline the cyclic
C2 chord-length cubic; the pleated skins star polygons on fixed rays,
their crossing integrated exactly per wedge; the cap's union integrated
as y-intervals over x and z. All hold on SMLib (worst 9e-8 relative).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The generator had fallen behind the tree: it no longer wrote 02/021-025,
03/010, 04/011-012 and 09/012-015, and its 07/016 lacked the second round's
tangent_chain. Each is now built in cases.py; the two reporters' scripts
(04/011, 04/012) are kept verbatim in reported.py. Regenerating reproduces
the tree exactly; the only file changes are the generator's own format
(volumes to 9 decimals, one-space indent, a final newline), all under 1e-8
relative.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Three r5 rounds at (60,40,20) set back 8: the volume between the convex
hull of the body on the corner cube's faces and the rounds' prisms (both
bounds closed form or a sampled hull below the true one), the box's bbox,
and SMLib's setback-patch topology (15 faces, 36 edges, 23 vertices).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
FeatureKind::Fillet gains setbacks (serde default: none, omitted when empty),
each a corner vertex and a length expression; a fillet with setbacks is
evaluated by kernel::fillet_setback. Constant-radius exact fillets with
rolling corners only (refused otherwise, in the command and in evaluation).
One distance per corner: SMLib keeps one setback per corner, not per edge.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Each (point, distance) sets back the corner at the body's nearest vertex: its
patch starts that far along every edge there. Tested on the 60 x 40 x 20 box
corner with r5 rounds set back 8 (volume between the convex hull and the
rounds' prisms bounds, 15/36/23 topology, the box's bbox) and on refusals.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
At a pole or apex `EvalSurface::eval` takes the normal from a step beside the
point, trying (+h, +h) first. At the far end of an interval (a sphere's north
pole at u = 1) that step lands past the end, where the extrapolated surface
folds back over the pole, and the normal came out turned over: the pole vertex
shaded dark with a light ring around it (ladder 01/005, every sphere and dome).
Steps now stay inside the active interval of a spline or a revolution's
profile. The pole test checked only that the normal was radial, either way;
it now checks the side too.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Recorded on SMLib replay 2c5baae (screw sweep walls exact and within their
tolerance, the radial sweep, the point solve on long rational surfaces) with
the thread rework: 06/008 (two starts) and 06/009 (runout) now graded and
passing, 06/011-017 new (Tr, Acme, S, ASME buttress, an internal Tr nut,
left hand, the chamfered tip), and 06/003, 004 and 007 grading the extent and
the collar. 132/135 pass; left: 07/013 corner setback, 07/015 G2 corners
(unsupported) and 07/016 three sequential corner rounds.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sizes, designations and the face's size come from ThreadForm (sizes, parse,
format) and suggested_thread_in, per form; the dialog's own trapezoidal and
buttress lists are gone. Acme sizes are listed by designation. The square
thread, which the command refuses (no standard defines it), is not offered.
Editing a thread reopens its form, hand, starts, extent (length or up to, with
its pick), start end, runouts, tip and steep flank, and OK gives them back.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Ladder 06/009 had no way to ask for one: "solid.thread has no runout (vanishing thread)
length". With SMLib's smlib_screw_sweep_radial (replay e7acea1):
- smlib: the FFI binding and Brep::screw_sweep_radial, the profile moved off the axis by a
piecewise linear law of the turn; crate test: a tooth moved out 1 mm over three turns has
A 2π (c turns + ∫ offset dt).
- kernel: sweep_helix_radial, sharing sweep_helix's checks (helix_profile).
- doc: `ease_in`, `ease_out` (a length, or ISO 3508's standard 2.5 P or short 1.25 P) fade the
groove over that length, its section moving out of the material as it turns (outward for a
shaft, inward for a nut). ease_in is at the end the thread starts from. The runout lies past
the full-form length: beyond a square stop, before a shoulder up to its clearance; at a free
end inside the face. Runouts longer than the thread are refused. No end gets one by default,
so saved threads keep their geometry.
The cut is the integral over the turn of the clipped section's 2π∫ r dA: engine test (2.5 P
and 1.25 P between two collars) within the sweep's wall tolerance times the runouts' wall area
(0.029 against a 0.036 mm³ bound), ladder 06/009 (004's shaft, a 2 P runout before the
shoulder) graded in closed form (measured 1.7e-6 off).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
`tip: chamfer` cuts ISO 4753's chamfered end at each free end a modelled external thread
reaches, after the groove, so the last teeth taper into the cone instead of ending in a
ragged first turn: the material outside a cone `chamfer_angle` to the axis (default 45°)
reaching d_f = d - 2 `chamfer_depth` at the face's end (default the external minor diameter,
the largest the standard allows), a revolved ring cut by one boolean per end. Past the end the
ring keeps to the radii the groove's overrun already cuts. An internal thread is refused (its
entry takes the hole's countersink), as is a tip with no free end or on a cosmetic thread.
The cone is axisymmetric and cut after the screw-symmetric groove, so the volume is the stock's
chamfered section with the thread's material fraction: engine test (both ends 45°, and 30°
x 0.5 mm at a shaft's one free end above a collar) within 1e-4, ladder 06/017 (measured
2.4e-7 off).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Ladder 06/008 had no way to ask for one: "solid.thread has no start count". `starts: n` (1 to
8) cuts n grooves of lead n x P, the j-th a j/n turn round from the first (the same helix j
pitches along), in one boolean with their union. A designation that gives the lead
(M16xPh3P1.5, Tr40x14(P7)) gives the starts, and a `starts` that disagrees is refused. The
helix's self-clearance check and the turn limit use the lead.
Over the same length n grooves of lead nP take the volume of one start of pitch P: engine test
(2 and 3 starts, M10xPh3P1.5) within 1e-4 of the closed form, ladder 06/008 graded as 001
(measured 3.5e-7 off).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Only the ISO metric 60° thread existed. Forms now (crates/doc/src/thread_forms.rs, values and
sources in docs/threads.md): ISO metric (ISO 68-1), trapezoidal (ISO 2904 design profile, ISO
2902 sizes), general purpose Acme (ASME B1.5), metric buttress 3°/30° (DIN 513), buttress inch
7°/45° (ASME B1.9 basic profile). Each has its groove as a straight-flanked polygon, its standard
sizes (none for ASME buttress), its designations (M10, M16xPh3P1.5, Tr40x14(P7), S20x4,
1/2-10 ACME, 2.5-8 BUTT) and the size that fits a face. The square thread is refused: no current
standard defines it.
`hand: right | left | both`: a left-handed groove is the screw motion about the reversed axis
rising along it; both cuts the two grooves, crossing, in one boolean. `steep_flank` turns a
buttress. The design diameters are checked against the published tables (ISO 2904/DIN 103,
DIN 513 via IS 4696-3); every form's cut against 2π∫ r w(r) dr per turn to 1e-4 in engine tests
and to 1e-4 in ladder 06/011 to 016 (they measure within 5e-7).
FeatureKind::Thread holds every option the command has (form, hand, starts, ease_in, ease_out,
tip, chamfer_angle, chamfer_depth, steep_flank, all defaulted so saved threads load unchanged);
starts, runouts and the chamfered tip are refused as not built yet. suggested_thread_in takes the
form.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A thread of some length ran from "the end of the face nearest the pick", a coin toss for a
pick in the middle (rig 602's 4 mm thread meant for the free bottom end ran at the head end,
cutting 1.17 mm into the hex), and every thread end at a face end got a one-pitch overrun,
which at a shoulder gouged the material past it (ladder 06/004 cut 0.9% of its volume out of
the collar).
- kernel: material_in_ring, the exact intersection of a body with a ring about a cylinder
face's axis, by an SMLib boolean.
- doc: a face end is free when no material lies past it, over the span the groove's one-pitch
overrun reaches beyond its first pitch, within the radii the groove cuts (a cap, a chamfer
the groove runs out through, a counterbore). At a free end the groove runs out as before; at
a closed one (a shoulder, a head, a blind hole's bottom) it stops with its widest part clear
of it; inside the face it stops square.
- doc: a thread of some length starts at the end nearest `from`, else at the face's only free
end, else at the end the pick lies within a third of the face of; a pick in the middle of a
face whose ends are alike is refused, naming `from`. A length as long as the face runs the
whole face. `up_to` a plane or a point's place along the axis. New fields `from`, `up_to`
default to none, so saved threads keep their meaning where it was not a coin toss.
- engine: solid.thread takes extent (full|length|up_to), from and up_to.
- ladder 06/003 (now with `from`), 004 and 007 are graded by volume and centre of mass in
closed form (a square stop inside material removes exactly length/P turns, the section being
symmetric); rig 602's method says why the thread is at the bottom, tolerance 0.02%.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Form (ISO metric, trapezoidal, Acme, ISO and ASME buttress, square), size and
pitch from the form's list, hand, starts, extent (full, length or up to, with
the end to start from), ease in and out (standard, short or a length), the
chamfered tip and the buttress steep flank. Only the fields that apply are
shown; a form change keeps the options and a manual size's diameter where
the new form lists it. Defaults stay out of the command, so a plain thread
means what it did.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The ISO metric table, the thread on a cylindrical face, the groove shape and the thread
feature's evaluation move from eval.rs to eval_thread.rs, unchanged, before the extents,
forms and starts work changes them.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A face's boundary nodes are its edges', shared with the neighbouring face.
On a nearly straight stretch (the base of a thread flank's corner, clipped by
a hex head's flats, on an iso-line of the helix) refinement met slivers
between consecutive boundary nodes: their centroid, or the middle of their
inner edge, lies on the boundary chord to rounding. Inserting it split the
boundary constraint, and the face was refused ("boundary crosses itself";
rig threads/602, refused while the body was meshed to pick the fillet's
edges). A sliver whose centroid lies on the boundary is now split at its
inner edges' middles, and a refinement point that lands on the boundary is
not inserted.
The 602 engine test assumed the old kernel's faceted thread (over 1000
faces); with SMLib the thread is exact, and the test now checks that the
fillet finishes and removes a little material.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Three new cases in closed form: two through holes touching at a point
(02/021), the stock shelled with no face open (09/012, a sealed void, two
shells) and a dome shelled from its flat base (09/013, its rim the circle
r18). Nine rig cases copied into their tiers: a cylinder grazing a hole's
edge (1279), lips 1e-4 off a base's walls (2928), wall halves merged into a
flange (494), flush chord layers (5197), the horn torus revolve (4007),
crossing pleated loft skins (4623), loft ribs joined to a rounded pad (4092),
a drafted box with rounds shelled (3576) and a shelled dome with its ring
joined back (4847). Golden recorded on SMLib replay 8017df9: 123/128 pass.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A notch cut into a sheet's base is a cut-out, so the base outline that
edge_at and the edge names read has no edge along it: a flange picked on
the notch's bottom edge took the name of the nearest outline edge (the
plate's far edge) and was built on the stretch of it the notch left. A
pick nearer a notch's edge than any outline edge now names no edge, and
the flange runs the base's outline round that notch first, keeping as a
cut-out only what it takes of the flanges, then trims and bends as on any
edge of the outline. The edge of a hole inside the base is refused.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Convert to Sheet Metal keeps a shell's (and a plate's) own thickness, but
the rule's values were evaluated with `Thickness` the rule's: under the
default rule (2.5 mm, bend radius `Thickness`) an L 2 mm thick with its
bend modelled R 2 was rebuilt bent R 2.5, losing 8.58 mm3 (2659.911
against 2668.496), and its gap and reliefs followed 2.5 mm too. The rule
is now evaluated for the sheet's thickness (Document::rule_values_at):
in the conversion once the shell's thickness is known, for a converted
plate, and for the flanges, hems and folds added to an existing sheet.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
solid.mirror and solid.pattern of bodies pushed each copy as a plain body:
no sheet model went with it, so its flat pattern, DXF and bend table were
refused ("`Body1 (2)` is not a sheet metal body"). Each copy now gets its
source's sheet model moved with it (SheetBody::moved). A reflection turns
the frame's handedness over, so a mirrored copy's frame sits on the moved
top face, thickness growing back toward the moved bottom: the same blank,
each bend turning the other way, machining depths taken from the other
face. A sheet feature on the copy rebuilds it in place.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The countersink's cone started 1% of the drilled body's size above the
entry face, widening on to rc + top tan(half) there, so above the face
it cut beyond the countersink's rim: a wall 0.15 mm from the rim was
notched (#5041, 12 faces instead of 10). The tool is now one revolved
profile: the cone from its rim on the face to just inside the bore, and
above the face the rim's own cylinder, as the bore's cylinder runs on
above it. The cone stays the profile's first segment (csink:side:0).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A Combine took its tools in their own component's coordinates and joined
them to a target kept in another component's: a root body joined into a
body of a component turned a quarter turn landed where the turn carries
its root coordinates (#3383, 2 shells and 17000 mm3 instead of one solid
of 16750). Each tool is now moved through its own placement and the
inverse of the target's (component placement, then body offset), as
state_in_frame places bodies, and a combine's cache key follows the
placements so moving a component recomputes it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The case's base is a stadium ring (r 3..5 arcs, centres 20 apart, z 0..2),
as its description and expected volume (2 (80 + 16 pi) for the base) say,
but its extrude picked no profile, and "all profiles" is every drawn region:
the ring and the stadium island inside it. The base came out filled and the
join 1066 mm3. SMLib's union was exact for those operands. The extrude now
picks the ring (the region at (4, 0)).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The record's torus label is a ring torus (major > minor; the validator
refuses any other). SMLib keeps horn and spindle tori: a half disc revolved
about a line through its rim's end is a horn torus, its major radius a
rounding below its minor, and the export wrote it as a torus label the
record then refused (rig sweeps/4007, "ring torus radii"). Such a face is
now its NURBS form, unlabelled, which is its geometry in any case.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
solid.shell refused an empty face list ("select 1…1000 faces"), and the
shell feature found its body from the first face picked. SMLib shells with no
face opened (the void sealed inside, its own shell): the command now takes
`faces: []`, the feature shells the one body there is or the one named
(`body`), and an outside or both-ways shell pushes no open face out of the
cavity. Rig shell/4009 declares the void's shell (`shells: 2`), as its method
says.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Where a face's loops pass a vertex more than once (two holes touching at a
point, a loop through another hole's corner), each pass took its parameters
from the pcurve of the edge leaving it, and the two pcurves round them 1e-14
apart. The triangulation got two nodes 1e-14 apart with constraints crossing
between them and refused the face ("boundary crosses itself"): rig 307, 3092
and 3887. A pass whose parameters agree with the vertex's first pass to that
rounding (1e-9 relative) now takes the first's; farther apart they are two
places of the surface (a seam's two sides, a closed spline's ends).
Rig 494 now fails: its revolved face has a dead-end edge walked down and back
up in one loop, which met the triangulation as a needle 1e-14 wide and now as
the slit it is.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fillet_max bisected the radius down on any error of a candidate fillet,
not only KernelError::TooLarge, and fillet_max_each fell back to one
radius for all on any error of a group or of the combined fillet. A
kernel failure at the radius asked for (or at any candidate) came back
as a smaller radius reported as "the largest that fits".
fillet_max and fillet_max_each now return Result<Option<..>>: only
TooLarge narrows the search or falls back to one radius, and any other
error is passed on. Ok(None) is still "no radius fits". The doc's
FilletFit::Reduce passes the error on. The test of a point with no edge
near it now expects the fillet's own error, not "no radius".
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The pieces of an IGES trim curve run on from one another, and the sewer made
each meeting point one vertex, but left a piece that missed it where it was,
the gap on the vertex's tolerance: an edge 0.01 mm short of its corner, 2000
times the file's resolution, which SMLib refuses (SmTrimmingTools #0, SmBrep
line or clamped B-spline piece that misses it is made to end there exactly;
any other piece that misses keeps its ends, and the gap is reported.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0113gDVmStT5tCGKW9Fxgc5K
A cone face bounded by its base circle and its seam out to the apex and back
turns once round the axis and closes at the apex. add_seams counted the turn
as a loop without a seam and added another, out and back from the same
vertex: the drill point of a turned pin read back from STEP had a sliver
whose boundary crossed itself, and the body would not tessellate (#5193). A
winding loop with a vertex on a pole is left as it is.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0113gDVmStT5tCGKW9Fxgc5K
form::extent took the box of 32 points per edge. A face's NURBS form is built
over that box, so where the boundary peaks between two samples the form
stopped short of its edge: the re-imported rod's bore ended at v = 9.99977
while its intersection with the rod reaches 10, and SMLib found the edge
1.9e-4 off the bore (SmBrep #4, SmEdge #13). Each sample higher or lower
than its neighbours now brackets the edge's extreme there, found by golden
section.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0113gDVmStT5tCGKW9Fxgc5K
form::extent unwrapped each loop of a face from its own first point, so a
hole beside the seam (a cross bore through a rod at the rod's seam angle)
came out a period away from the outer loop. The box over both was more than a
turn, cut to one turn from the hole: the face's NURBS form ran over quarters
3..7 while its seam uses lay at 4 and 8, and SMLib found the re-imported
rod's edge ends outside its face domain (SmBrep #70-#72). Each loop after the
first now goes the whole periods along that keep the face's box smallest.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0113gDVmStT5tCGKW9Fxgc5K
tangent_chain followed tangent edges without looking at their convexity: a boss's concave base
arc that runs on tangentially as the convex rim of the overhang above it (rig fillets/4174,
4369) and a convex outline running into the concave edges under an overhang (4365) were sent to
SMLib as one chain. No round can pass from one side of the faces to the other, the cases'
answers stop at that vertex, and SMLib rightly refused the request (1001 in its Nx2 corner).
A chain no longer runs on into an edge of the other convexity: convex(e, v) tells, from the
second face's natural normal, the loop's direction and the first face's normal, whether the
faces meet at less than 180 degrees inside the body. With SMLib's corner and end fixes this
makes rig 4174, 4365 and 4369 pass with their analytic answers; nothing else changes.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0113gDVmStT5tCGKW9Fxgc5K
Rig case shell/4711 (a 60 x 40 x 10 block, an r3 through hole at (22.5, 7), a 10 x 10 notch on
the front edge, shelled 2 open at the bottom) failed with "SMLib shell: operation: SMLib failed
(status 1027)". The hole is 4 = 2 x 2 from the front face: the hole wall's offset (r5) is tangent
to the front's at (22.5, 2), the walls meet along a line and the cavity would pinch to zero
thickness there, which is no solid. Refusing it is right; the refusal did not say why.
SMLib now refuses an offset whose walls would meet with its own status, SMLIB_ERR_WALLS_TOUCH
(-1110). The smlib crate reads it as Error::WallsTouch; the kernel's offset backend turns it into
a sentence with the wall, as blends turn NoRoom into one: "shell: the 2 mm walls would meet along
a line (between a hole and the side, for example), which leaves no solid there; use a thinner or
thicker wall, or move the feature". Thicker builds too (SMLib shells 4711 at 2.5, the walls
crossing and merging between the hole and the front), so the sentence offers both.
4711 expects that refusal and its message ("outcome": "refused", "refusal"), its "what" and
"method" saying why: the wall is 4 = 2 x 2, the walls meet along a line. Tests: the smlib crate
shells 4711 built from primitives (2 refused as WallsTouch, 1.5 and 2.5 valid), the kernel a
plate whose hole is 3 from its side at 1.5 (refused, with "the 1.5 mm walls would meet along a
line").
Results (run-sc.sh against SMLib a759622's code, which differs from the tree run only in
comments and docs; baseline 858f381fc-5448b9a): rig 410/447 (409
before; 4711 fail -> pass as the refusal, nothing else changed), ladder 109/116 (unchanged),
kernel lib 535 passed / 202 failed (one new test; the same failing set), smlib crate 53 / 2
(one new test; the same failing set).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0113gDVmStT5tCGKW9Fxgc5K
SMLib now builds a round or chamfer whose rail runs off its face across a cliff (an opening's
rim, the body's outline): the blend is made as if its faces continued and what it removes is
subtracted, so it never bridges an opening (owner decision for rig 5158/5181; fork commit
"SMLib, capi: a convex blend overflowing a cliff is subtracted from the body"). The tests that
expected a refusal for such blends now expect the body, each answer from the geometry:
- variable_radius_on_a_box_edge: 2 -> 50 on the 10x20x30 box's top edge builds at
3546.18767939 (circular sections in y = const, the r x r square less the quarter disc,
clipped to the box; rel 1e-4).
- variable_radius_from_a_spline: the "big" law builds at 6000 - 726.5334566720 (de Boor law,
split at the knot and where r crosses 10).
- a_chamfer_meets_sloped_end_planes: chamfer 25 removes 11500 - 4625 * slope
(integral of 40 - 2 * slope * y over z >= y - 5).
- g2_fillet_refuses_invalid_geometry: G2 at 25 builds at 6138.1606889 (the quintic section
with control points at thirds, clipped to 20x20, along 20).
- fillet_max_each_reduces_only_where_the_radius_does_not_fit: both edges take 4, 24438.7317761.
- hostile_inputs_are_errors: chamfer 30 on the cube builds at 1000 (y + z <= 10 along 20);
R50 still fails.
- kernel-cases fillets/1080: the 9 mm chamfer into the openings builds at 3350
(method in expected.json).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0113gDVmStT5tCGKW9Fxgc5K
Cases from the issues filed after #4160, each a synthetic recipe with its own answer
(analysis or invariants); every other issue in the range is listed with why it was skipped.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Cases from the issues filed after #4160, each a synthetic recipe with its own answer
(analysis or invariants); every other issue in the range is listed with why it was skipped.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Cases from the issues filed after #4160, each a synthetic recipe with its own answer
(analysis or invariants); every other issue in the range is listed with why it was skipped.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Cases from the issues filed after #4160, each a synthetic recipe with its own answer
(analysis or invariants); every other issue in the range is listed with why it was skipped.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Where a cut-out's corner touches the outline (a triangle on the sheet's edge in a bend), four
walls meet along the corner's line. The touching sew paired them round the empty wedges and
gave each fan at the corner its own vertex, so a cap kept its outline and the cut-out as two
loops with a vertex each at one point: SMLib refuses that face (coincident vertices, loops
touching: its face tests 32, 38 and 39), and the bend face's two corners, a hair apart in
(u, v), left a boundary no triangulation follows.
The walls are paired round the wedges of material, as SMLib keeps a solid touching itself along
a line: an edge per wedge, the two sharing their end vertices. A face's loops that meet at a
vertex are joined there into one loop through it twice, SMLib's form of such a face.
With SMLib's face builder taking the same profile (an extrusion of the plate and its
cut-out), fixes rig sheet-metal/1095.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit 0bf765aa815a5552e5b090fd8854b1dc7a981e3f)
A loft cut from a block's whole outline (flush with its sides) down to a pad cuts the slab
above it loose: the slab and the rest touch along the outline's four edges, round the pocket
the loft leaves. SMLib keeps the pocket as a void region of its own (its check finds the body
valid): its one runtime shell is the slab's underside and the loft's faces, so the slab's
material shell faces two empty runtime shells, the infinite region's and the pocket's, and so
does the rest's. The export made one record shell per pair of empty and material runtime
shells, so each solid's closed boundary came out as two open shells ("an open, wire or vertex
shell lies in one region").
A record shell is now one material runtime shell, whatever empty shells its faces face. Empty
regions one solid's boundary faces together are one record region: the infinite region where
it is among them, else the void whose outer shell bounds it alone. The pocket, which no record
shell bounds once the solids' shared edges are split, is part of the empty space round them.
Fixes rig sweeps/96-loft-cut-box-sections-pad-first and -top-first.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit 796920968265c57c59f11dd908ec022d53f5c647)
With touching: separate (the default) a join groups the joined body's
pieces by face contact. The groups that hold the material of the body
before the feature stay in it (each unless it touches one already kept;
the first group where the lineage doesn't say), and so do the groups that
touch nothing: a virtual grouping later operations take as one body. Every
other group that touches another along an edge or at a point becomes a
body of its own, and the feature's notice says so. The joined body keeps
its name and never holds an edge or point contact. A join that only
grouped pieces apart gives no notice, so KeptSeparate::Apart is gone.
one_body still keeps every piece in one body.
SMLib's export copies an edge or vertex that touching solids share once
per solid, so the record never listed those contacts:
Brep::region_contacts now takes such copies (the same curve and interval
between vertices at the same points, a vertex at the same point) as the
edge or vertex they share. A contact SMLib leaves out of the topology (the
3612 spoke tangent to its hub) is found on the exact geometry, the least
distance within the record tolerance, and reported as KeptSeparate::
Touching ("along a line or at a point").
The pending format change join-touching-bodies stays: older designs kept
pieces touching along an edge or at a point in one body too. Its notes say
so, and the reopened legacy emboss still expects touching: one_body.
Tests restored to their form before cc49081df and 733d3bd19: kernel-cases
2896-join-arm-end-near-ring-wall-gap (one body of two shells), 3379, 3455
and 3526 (no touching: one_body); the engine tests of posts joined while
apart (twice), two cubes for interference, a ring with a cylinder, the
buried tab and a_join_adds_only_its_sketch's 0.1 mm gap.
join_meeting_nothing_keeps_the_first_body expects one body and no notice.
The #3378 spoke stays 1 mm inside the hub.
New tests: blocks touching along an edge are split with the along-an-edge
notice; blocks apart stay one body without one; a ring with an arm on its
corner edge and a hub apart gives ring and hub in one body and the arm on
its own (doc); the engine's notice for an edge contact; the record's
contacts of cubes sharing an edge or a vertex (kernel).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Each edge is sampled to the chord tolerance on its own, so where two curves of one face run
closer together than their chords sag (the two arcs of a thin lune, the sliver caps of a
joined ring of cylinder segments) the chords crossed although the curves do not, and no
triangulation follows such a boundary ("boundary crosses itself").
After the edges are sampled, every face's boundary is checked for chords that cross another
of the face, in its loop or another, and on a closed surface across whole periods (chords
ending on a pole are left out). The edge segments that cross are halved at their curve
parameter's middle, on the edge, so every face of the edge gets the same new nodes, and the
faces of the edges split are checked again until no chords cross. A boundary still crossing
after 16 rounds, or an edge past its node cap, is an error naming the face and the edges.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BnQawySUFx57iaJZq7z1Fm
(cherry picked from commit d2b2bdb8e2720690d79123a16bc18c768b1598e8)
jyviko