The flags solidcore added since ddfb3895, each a port of a fork commit that SMLIB_REV
(90aabff) already carries, so solidcore and the C++ path agree with them on:
- taper_tangent_corner_planes (WR-521, #1449; tangency-labs/smlib e8f23e0)
- revolve_holed_profile_void (WR-529; 38b4212)
- local_operation_refuses_loose_tangent_edges (WR-530, #402; 23c5b0a)
- extrusion_origin_scaled_zero (WR-511, #1508; tangency-labs/smlib#31)
- boolean_skips_faces_apart (WR-527, #1526/#1527; 60b1c6a)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
`to_arrays` approximates a face surface that is not a B-spline kind as `FlatFromBrep` does:
`ApproximateSurface` within the curves' approximation tolerance (`approx_tol3d`), up to 5
subdivisions, B-splines copied; a failed status or no surface fails the export.
`fixes()` turns on fillet_3x2_mixed_concave_side_edge (#1475),
ssi_singular_start_inside_direction (#1522) and fillet_vertex_error_diagnostics (#1469).
offset_sheet_quarter_cylinder now exports and matches its closed form; its parity with the C++
kernel stays ignored on solidcore#1477 (the quarter arc sweeps to an SmSurfOfExtrusion, not the
fork's SmCylinder).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
Ports smlib PR #27 (merge f64ff8b6) into core/offset.rs::draft: a picked face on a cylinder
(end radii equal, the #27 test) gets the cone `drafted_cone` gives, through the same
LocalOperation as a tilted plane. As in the capi, the outward normal at the face's internal
point (`outward_normal`: STEP inversion, NURBS uv, the surface normal turned with the outer
faceuse) says pin or hole (s = +1 or -1). The hinge circle is the axis on the neutral plane,
at the cylinder's height v0. The radius changes by -s tan(angle) per unit along the pull. The
pull must run along the axis (to 1e-9), and the axis must cross the neutral plane;
otherwise, or when the cone would close within the face, the draft is Error::Unsupported.
The capi's control-point edit and CopyAndAddAnalytics are solidcore's Cone::lean_cylinder
(solidcore#1545), with slope -s tan(angle) (z . pull) about height v0. A cone that is not a
cylinder (smlib#53's turned generators) stays Unsupported: lean_cylinder takes cylinders only.
draft_a_curved_face (R 5, h 10, 0.1 rad: V = pi h (R^2 + R r + r^2) / 3 = 638.3350153968712,
r = R - h tan 0.1) stays ignored on solidcore. lean_cylinder keeps the clone's cylinder flag.
Under the cylinder_rebuild_mean_radius fix SolidCraft runs with, rebuild_step_from_nurb_parameters
then refuses the leaned NURB (SM_ERR 1001). With that fix off, the port meets the closed form,
but the face is still flagged a cylinder ({cylinder: 1, plane: 2} vs C++'s {cone: 1, plane: 2}).
This is a solidcore bug, to be filed.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
Ports smlib PR #17 (merge b0180137) into core/offset.rs::offset_sheet: the refusal of a
closed manifold solid is dropped, so faces that close into a solid (a sphere's one face, a
block's six) give the offset solid. The port also gains the capi's `take` check it was
missing: a result without faces is SMLIB_ERR_EMPTY (Error::Empty), not an empty body.
Tests (closed forms):
- offset_sheet_a_solid un-ignored: 32 * 22 * 12 = 8448, bounds -1 .. (31, 21, 11).
- offset_sheet_a_sphere (PR #17's capi case): r 10 moved out 2, (4/3) pi 12^3.
- offset_sheet_a_sphere_to_its_centre: r 10 moved in 10 leaves no face: Empty, as C++.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
The C++ kernel at develop's pin (9d0fb564) builds both cases that expected a refusal;
each now expects its closed form:
- offset_sheet_a_solid (tangency-labs/smlib#17): the 30 x 20 x 10 block, every face
moved out d = 1, convex edges extended: (a + 2d)(b + 2d)(c + 2d) = 32 * 22 * 12 = 8448,
bounds (-1, -1, -1) to (31, 21, 11), six planes.
- draft_a_curved_face (tangency-labs/smlib#27): the cylinder R = 5, h = 10 drafted
0.1 rad about its base, leaning in, is the frustum of radii R and r = R - h tan 0.1:
V = pi h (R^2 + R r + r^2) / 3 = 638.3350153968712 (a cone and two planes).
C++ meets both within the file's 1e-9 relative. The solidcore side of each is ignored:
core/offset.rs still makes the old capi's refusals (a closed solid in offset_sheet,
planes only in draft). With the offset_sheet refusal dropped, solidcore gives the
block exactly; solidcore has Cone::lean_cylinder (solidcore#1545) for the draft.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk
They fail on develop today (4 native tests, 8 of 83 reference cases), so running them on pull
requests would fail every pull request. Back on pull requests once develop is green. Reverts
0cdc25094.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The single results form compares a whole number exactly (a count). The construction and inspect
cases gave positions and volumes as whole numbers, which the form they were written for compared
within tolerance; they are decimals now. The NPT groove fix makes ladder 06/023 pass: its golden
entry is the passing run (51 faces, 8226.4042 mm3).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The shared core (crates/smlib, the grader, doc eval.rs, engine features.rs and the kernel's core)
is in PATHS-ALL; the new areas' copies of it are dropped, so an area reruns on its own files and the
core reruns them all. sheet-metal also watches the sheet commands, the sheet document and the DXF
writer. 116 commands a case now uses leave EXEMPT; 25 geometry commands are still to cover.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Two branches added a results field in different forms ({step, json} and {command, pointer,
value}). The grader keeps one: a 1-based step, an optional JSON pointer into its answer, and the
value matched as files are, with an optional relative or absolute tolerance. The construction and
inspect cases are rewritten to it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The groove's section was cut square a fixed margin past the crest. The crest cone changes 1 in 32
along the axis across the section's own width, so for NPT (margin 0.015 mm against a 0.028 mm
rise) the section's deeper corner stopped under the cone and each tooth kept a sliver of its
flank: 0.94 mm3 too much on a 1/2-14 NPT. The section's edge now follows the cone at the same
margin.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
167/168: every new case passes against its hand answer but 06/023 (1/2-14 NPT external), whose
groove stops 0.015 mm past the crest at its section's middle, under the crest cone on the section's
deeper side, so a sliver of each tooth's flank stays (0.94 mm3, 1.1e-4). The 139 cases before keep
their statuses and counts; their volumes and areas re-measure within 2e-6 on this SMLib.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Base flange; an edge flange at 90 deg; four made together, the corners closed on the mitre plane
with the rule's gap, at 90, 72 (leaning out, the ends run on along a slant) and 108 deg (leaning
in, cut back); round, rectangular and tear reliefs; a hem; a fold, unfolded and refolded; the
tray's flat pattern (outline size and area, bend lines); a bracket with a hole and a flange on a
flange. K = 0.5, so every volume is T x the flat area. The 108 deg tray is a sheet-metal rig case too.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
From the script's last sheet.flat_pattern result: the outline's size, its area less the
cut-outs', and the bend lines, each matched to its own one of the result's either way round.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
G 1/2 external and Rp 1/2 internal (ISO 228-1 / ISO 7-1, 55 deg) by Pappus turn by turn; R 1/2
and 1/2-14 NPT external and Rc 1/2 internal tapers (1 in 16 from the standard's diameter at the
free end, crests cut by the major or minor cone) by the screw sweep's Jacobian, integrated exactly
(ladder_lib.sweep_removed); an S20x4 run down to a shoulder with its steep flank toward the end and
toward the start, which moves where the groove stops; tip: start, and a Tr20x4 chamfered at its own
30 deg and 2.5 mm; refusals for a Tr chamfer without a depth and for the square form.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1/4-20 UNC (#7, 0.201 in) and Rc 1/2 (17.6) through the stock, 1/4-28 UNF (5.45) blind with a
flat floor, 1/4-18 NPT (10.85) through: a cosmetic thread in a straight hole, so each volume is
the stock less that cylinder. The drills are the catalogue's (Guhring, Yamawa YEU23); each method
gives the standard's minor diameter beside it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The tap maker's 6.8 mm M8 drill, the chamfered tip's ISO 724 d3 with tip: both, and 07/016's
refusal reason were edited into the cases' JSON but not into cases.py, so running it undid them.
Its output now matches the committed cases (to the last rounding digit of two volumes).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A Default row, a 60 mm row, a row without the hole, a height column and rules
that suppress the hole or drive the height, each checked after activation;
preview leaves the design; refusals for a row that cannot build, unknown rows,
columns and features, and a rule a row breaks.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Suppress a hole and the block is whole again; a round moved before the notch
runs the whole edge and is cut by it; deleting a sketch takes its cut and
deleting the block leaves the round and cut failing; roll to the middle gives
the part at that step; edits, compute all and folders, each with a refusal.
The new history area has its KNOWN_FAILING (every case passes) and PATHS.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Brett Lawson