Develop's CI after the a18bbe5 pin (run 41522001173) fails 14 tests that
passed on f916a8d, and passes two listed ones. Each new line says what the
test sees on v1.1.0-alpha; v1.1.0-alpha.1 fixes the setback hole's cause.
shell_tangent_chain_that_opens_every_face_explains_how_to_keep_walls and
oracle 37-pyramid-apex-blend pass and leave their lists.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
On SMLib v1.1.0-alpha, 06/018 makes 597 or 594 edges from the same input:
the union's post-process keeps pointers to edges it has deleted. A golden
entry's `unstable` reason makes the gate compare that case's status only
and name it in its output; recording keeps the reason, and only an edit of
the golden removes it. v1.1.0-alpha.1 fixes the cause and removes the mark.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
Fixed (off the known-failing list): the Mixed corner's peg cases and the concave arc with the front top edge (smlib #123), and the 40° boss junction (smlib #124). Eight cases in all.
New failures, recorded as they are, each with its reason. They passed on f916a8d.
- **Six cases grade a blend seam G0 where G1 (or G2) is wanted,** at the end of the round's contact seam, after smlib #124's End at a smooth vertex. Two of them also shift in volume.
- **Four cases come back unsupported** after smlib #125, which leaves setbacks to the Setback's corners only.
- **Ladder 07/012** makes 9 faces, 20 edges and 13 vertices, where its golden had 8, 18 and 12. Its golden entry is the new result, with the reason added.
Whether each change is by design or a defect is being established. A defect is fixed in solidcore, where the End and the Setback are being brought over (#2364, #2365), not in the frozen SMLib.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
Since f916a8d:
- #120: every target again, plus the warnings fix;
- #121: the Ball's patch as flat kind 6 with its sphere, read by the previous commit;
- #122: tests gated on counts;
- #123: the Mixed corner;
- #124: the End at a smooth vertex;
- #125: four or more rounds, and open setbacks;
- #126: the equal-area thumbweight guard;
- #127: the trunk merge.
The SMLIB_PREBUILT checksums are from the release prebuilt-a18bbe5…, written by `scripts/fetch-smlib.sh --pin`.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
SMLib's flat arrays now carry the corner of three equal rounds as `SURFACE_BALL_PATCH` (kind 6): its net as a NURBS face's block, with its sphere's centre and radius as its definition (ids 36 and 166). The record reads it as `ball_patch {center, radius}`, a label like the analytic kinds, with the net as its `nurbs`. A plain sphere with a form won't do: the net is not a piece of SMLib's sphere NURBS, so SMLib's `IsNurbSurfaceSphere` would refuse it.
Written back, a ball patch is kind 6 with the same definition, which SMLib takes once its net is certified on that sphere. Elsewhere:
- Offsets classify it as its sphere, so its offsets stay exact and collapse at the centre.
- Face kinds count it as a sphere: fillet_three_edges_at_a_corner's corner is now `sphere`, no longer `other`.
- STEP, which has no ball-patch entity, gets the net as the face's B-spline surface, pcurves included.
- Iso curves and SSI of the label are refused; the face's form is what evaluates.
Test: a_rounded_cubes_ball_patches_go_round_with_their_spheres. The cube's eight corners are ball patches about the corners pulled in by r. Points of each patch lie on its sphere to 1e-12. The patches are kind 6 again after import, with the same definitions bit for bit, and the closed-form volume holds.
Format: pending/ball-patch-faces.rs. Docs: docs/native-brep.md and the rig README's `surface_types` (`ball_patch`).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
A primitive cut skips the sheets kernel::apart (exact bounds grown by the record tolerance)
finds clear of its tool; the bend check leaves the clear case to kernel::boolean, which answers
it from the same exact boxes with no intersection work. The mesh-box helpers are gone, and their
four lines leave xtask/mesh-decisions.txt (172 sites left).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
Each round runs whole to its section square to its edge at its setback (the owner's rule, at
least 1.5 r, scaled to the least at which the G1 fill is certified convex), and the hole is the
setback split: one patch per round and the triangle in three quadrilaterals, 15 faces, G1.
Outside the box the sections span the body is the three strips', so its volume is theirs within
that box's. A later r3 round at the mitred corner makes the body all three at once make
(7928.142563938, 15 faces), as the engine and the model-cache tests have it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
SMLib's setback corner takes a G1 fill only once certified convex, and refuses a setback too
short for that as SMLIB_ERR_NO_ROOM with SMLIB_FIT_SETBACK_AT_LEAST, the smallest setback that
builds. The kernel reads it (solidcraft-smlib binds smlib_blend_fit_size) and names it; the
Fillet dialog says it in plain words. Other room refusals keep their words. The r5 box corner
set back 5.5 is refused naming 5.962, which builds.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
On the CI runners the boss root and the hole rim, both size-2/size-1 curvature rounds, build
correctly but take more than 180 s: the order-2 section's span certificate and the round's
definition are evaluated station by station. The per-case limit is the one the thread cases use.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
The round's cylinder keeps the frame it was made on when it is turned (SMLib's SwapUV no longer
re-derives it): its origin sits at x = −20 on the same axis line, (x, 2, 8) along x, radius 2.
Same cylinder; one number in the record moves.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
SMLib's Ball corner is always the rational patch exactly on the sphere (owner ruling, blend
design §23), so the corner counts as an 'other' face beside the three cylinders and six planes.
The removed volume still checks the corner against r³ − πr³/6.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
With the tangent chain on, 016's and 018's r3 runs on along the r5 round's end arc and down the
vertical edge, so the third pick (60, 40, 8) is 3 from both of that round's contact lines and
names no edge: refused, asking for a point along one edge. The corners they were made for are
020 and 021 (the r3 alone), whose golden entries are 016's and 018's (021 measured on f12a101).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
851-fillet-arc-then-top-front and 851-fillet-top-front-then-upright: with the tangent chain on,
each R2 chain runs along the end curve of an R2 round on a curved face (the arc round's end on the
front face; the first round's end on the wall), where the rolling ball sits on that round's own
centre line, so the piece is the ball about (39.2538, -19, 8): the three-edge rolling-ball corner.
SMLib fails with status 1001; the same piece on a plane end arc builds (front-left upright).
Expectations unchanged.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
- every-fillet-after-fillet-curvature-front-then-side-r3: the side edge's chain runs round the
first curvature round's end curve, whose radius of curvature has a weighted mean of 3 (its
setback) and is unbounded at the ends, so somewhere below 3: the size-3 blend's contact line
folds back on itself. Refused, "larger than the faces beside its edges allow", as ladder
07-fillets/016's r7 on the r5 arc. (It was solid or refused for running on tangentially.)
- every-block-cylinder-tangent-concave-arc-r2-no-tangent-chain: the chain takes every piece of
the half circle and ends at the convex edges it runs on into; it builds the analytic 19091.9620,
so the outcome is solid (the refusal alternative was the chain-off one's).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
With the tangent chain on, two cases round more than the edge they pick, and their old
expectations were the single edge's:
- 1207-fillet-box-end-edge-into-unblended-round: the r1 chain is the end face's top edge, the r3
round's end arc and the back upright; 34 A + (pi/2) A (3 - c) by Pappus on the arc:
V = 7953.139216 (it built 7953.139216, the old 7957.505 passed only inside 1e-3), 10 faces.
- 851-fillet-top-front-then-front-left-upright: the upright's chain runs up the first round's
end arc on x = 0 and along the left top edge, so the corner becomes the R2 ball's eighth:
V0 less the first round's spandrel to the wall (35.344727) less 27 (4 - pi) + 2 pi/3:
V = 9530.777979 (built 9530.777987), 10 faces.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
fillets/every-block-cylinder-tangent-concave-arc-r2-partial-chain: the pick takes one piece of the
concave half circle, which SMLib splits; with the chain off its other pieces are left out, and the
blend is refused at the piece's end (the base gate's outcome). With the chain on the case rounds
the whole half circle. The copy keeps its expectation, to be re-derived.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
Where a case's point is one edge of a tangent chain rounded alone, a copy keeps tangent_chain
false as its own case (SMLib rounds exactly the picked edges, ending at the smooth vertex); their
expectations stay as they were, to be re-derived:
- fillets/1207-fillet-box-end-edge-into-unblended-round-partial-chain;
- fillets/every-fillet-after-fillet-curvature-front-then-side-r3-partial-chain;
- fillets/1207-fillet-bar-top-edge-after-boss-arc-round-partial-chain, renamed from
...-no-tangent-chain: with the chain on it is exactly 1207-fillet-bar-top-edge-after-boss-arc-round,
which the rig already has;
- ladder/07-fillets/020 and 021, the r5/r3/r7 and r5/r3/r2 corners (016 and 018) with the r3 on
its edge alone: with the chain on, the r3 runs on along the r5 round's end arc and down the
vertical edge the third round was to take.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
The owner's ruling of 2026-11-01: the rig and the ladder round with tangent_chain true, how a
user's default pick behaves. The 38 fillets-area recipes and the ladder's 07-fillets/016 and 018
that passed false now pass true. The shell recipes keep theirs: a shell's tangent_chain is its
open-face chain, a different feature.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
SMLib builds a variable round's law corners as its balls' union (the corner
ball's zone at a dip, the sides' crossing at a peak): the kernel's corner
through a middle point (39.5410) and the crate's 4 -> 2 -> 4 law (39.5421) pass.
Rig 1207 (the bar's top edge rounded after the boss's arc, r0.5) builds and
grades on the same SMLib; it failed on c820346.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A variable round is the envelope of the balls rolled along the edge, which takes less than a
quarter round in each section. The expectations are now that union, the law continued past the
edge's ends along its end slopes, integrated by Gauss-Legendre panels in x and t; 2, 4 and 8
panels agree to 1e-9 of the body's values, and 77's removed volume matches a brute-force union of
balls to 2.5e-10. The nearest-ball search now scans the balls the ray meets around ball x
(|x - s| < r(s) sqrt(sin 2t)) on their own, which near the faces and where 78's radius closes to 0
are narrower than the global scan's step. Regenerating keeps each case's known_failure. 79, a
constant radius, is unchanged.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The new section builds their edges on the surfaces, so STEP export no longer finds them 4.6e-5
to 6.1e-5 off. develop's Reference tests (60393a718) report all three as passing while marked.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
At the default 1e-3 the great circles' volumes (4e-6 off) passed too. SMLib builds each within
1.6e-7. The golden takes the new volumes and areas; counts unchanged. The G2 corner test listed
as failing passes on SMLib's step 3 and leaves the list.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
removed_by_balls integrates, in each plane square to a right-angled edge, the corner the union
of the balls leaves (by rays from the edge, the least entry over the balls), cut to the body's
section. The law with a corner through a middle point is its own test, listed as failing.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The smlib crate's laws and ladder 005, 006, 007 and 012 take the volumes the balls' envelope
removes; the law with a corner is its own test, listed as failing until the corner step.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Four are listed with their causes: the equal-pipe tee (its exact conic-pair rounds meet at the
ellipses' crossings in a corner the old corner code cannot join), the tilted bosses (1001, before the
blend rework too) and the Y junction (refused for room at its triple points).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A round's spandrel A = (1 - pi/4) r^2 and its first moment about its wall M = r^3 (5/6 - pi/4):
Mitre adds L A -+ 2 M per edge (cut at, or run on to, the corners' bisector planes), Swept turns
the section about a convex corner's edge, (pi/2) M a corner, and refuses a concave corner rounded
less than the ball. The pocket's tangent chain round its R3 corners is a torus each. Graded to
1e-7, where Mitre and Swept differ by 6.6e-6. The Swept cases are listed until solid.fillet
takes a turn.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
On the round's rails the order-2 section takes off what the ball's circle does: (1 - pi/4) s^2 at a
square corner, first moment 0.0474559669443 s^3 (w = -0.5252123889). The kernel and engine tests
and the curvature rig cases take their volumes from it by their own methods; the pipe on the plate
from its own wedge (70.52878 degrees, w = -0.8544103493). The G2 corner patch's seam test is listed
until the corner step.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SMLIB_BLEND_CURVATURE's section is now the order-2 G^n section at thumbweight 0. Between two
planes square to each other it cuts A = 0.154192655384275 s^2 off the corner, its first moment
about either face 0.0291753295725360 s^3 (Green's theorem on the section): the curvature cases
built on that corner (862, 2708, every-box-edge, every-hole-top-rim, every-l-bracket,
every-block-cylinder-crease, the three-edges-at-bar-corner reports, 3604's fillet) take their
volumes from it by their own methods, the peg's front blend 23.3237146876 (its section along x
up to the wall). Between planes the section's t^3 term vanishes (their feet are linear in the
distance): the box edge case is exactly G3. The boss root is a certified fit, G3 to the plate and
G2 to the wall at Continuity Analysis's tolerances: at least G2. The boss root and the pipe on
the plate pass on SMLib's section and leave the known-failing list.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Eight fillet cases for the blend's cross-section by its order of contact with the faces, each
graded on its analytic volume at rel 1e-7 and its exact continuity (the order, and not the next):
- a box's top back edge chamfered 3 (G0), rounded r3 (G1) and curvature-rounded 3 (G2): the
areas cut off the corner s^2/2, (1 - pi/4) s^2 and 113/756 s^2, the last by the default
thumbweight's definition;
- a pipe R10 dipping into a plate, its concave edge chamfered 2 (the chord between the contacts of
the ball SMLib rolls for that setback, radius 1), rounded r2 and curvature-rounded 2, each
section's added area by Green's theorem along the plate, the section and the pipe's arc; the
order-2 section is built from the faces' feet of the point at distance d from both, which on
the pipe are not linear in d;
- a boss root curvature-rounded 2, the square corner's section revolved (Pappus);
- a variable round r1 to r5 along a box edge (rel 1e-5): the balls' envelope is a circular cone,
and the volume is the cone's sections integrated along the edge.
Three fail today and are listed: the two curvature rounds whose faces are not a square corner of
planes (SMLib's quintic blend curve, not the order-2 section: rel 6.5e-7 and 1.2e-5) and the
variable round (great circles, not the envelope's: rel 4.8e-5). The other five pass on SMLib
7ac037e.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Where the round meets the open bottom the cavity's wall steps down along the bottom's normal, so the
round meets it at 90 degrees and the opening is exactly the picked face. The cases are renamed and
graded on the exact volumes, and come off the shell known-failing list.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Twelve listed cases build on the new blend's end event and exact classes, or were already
built on develop: they come off the list.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The rounds now come as the rational surfaces their classes give, closed ones as two faces split
at their seams, the touching pipes' as four: one splines entry a face, each of the class's degrees.
Their KNOWN_FAILING lines go.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A plane cutting a cylinder or a cone at an angle, a sphere or a cone coaxial with the other face, a
cone and a cylinder touching one ball, two pipes touching at a point: their rounds' centre lines
are rational, so the rounds are rational surfaces of degrees fixed by the construction ((4, 2),
(2, 2) revolved, (6, 2), (12, 2)). The tee's centre line is not rational; its round is graded on
its volume. Volumes from the divergence theorem over the exact pieces, at rel 1e-6. The six that
SMLib 0cc48bd traces are listed in KNOWN_FAILING with what they come out as.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
With SMLib's tangent end as an event of the fillet's trace (blend-end-event 6d73e4f), the
concave chamfer's rail on the cylinder ends where it crosses the seam along which the front
face runs tangent into the cylinder, continued past the vertex, and its end rib on the front
face is built from there. report-peg-concave-chamfer-d2 and
report-peg-front-chamfer-d1-then-concave-chamfer-d2 pass and leave KNOWN_FAILING. The two
chamfers together still fail, now at the mixed-convexity corner where they meet: its line says
so. Rig against SMLib 0cc48bd: no area regresses (963/993 pass, 961 on a87c502), ladder 168/168,
kernel lib only its listed failures.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The six corner cases added in 3a854104a took the fillet's default type, on the premise that the
default would become curvature-continuous. The default stays the circular round, so each case
now asks for the curvature fillet itself (type curvature: curvature-continuous sections and
corner patches) and keeps its grading: every seam of the rounds and of the corner patch G2, one
valid body. They are renamed from cov-fillet-g2-default-* to cov-fillet-g2-*.
The oblique three-edge corner (a block drafted 15 deg) and the pocket corner pass. Four fail, as
KNOWN_FAILING now says:
- the corner beside a cylinder: the curvature fillet builds its sections only between planar
faces;
- the four- and five-edge apex corners: refused because the default setback is shorter than
where the rounds' contact lines meet (3.90 and 3.51 mm from the apex);
- the mixed corner: SMLib sets back a corner only where its edges are all convex or all
concave.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
With the SMLib fork's smlib-tangent-ends (a rail's end on its side edge is the rail/edge
crossing), report-peg-front-chamfer-d2 passes. Its line leaves KNOWN_FAILING, for the pin that
carries that fix.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Six fillet cases that pick their edges with no type, so they take the fillet's default, which the
owner has ruled is to be curvature-continuous (G2) at every corner, with circular rounds kept as
an option. Each grades every seam of the rounds and of the corner patch G2, on one valid body:
- an oblique convex corner (a block drafted 15 deg);
- a four-edge and a five-edge apex corner (pyramids lofted to a point);
- a pocket's concave corner;
- a mixed corner (a step: one concave edge, two convex);
- a corner beside a cylinder (the top corner of a half cylinder).
All six fail on SMLib 2fc375f, listed in KNOWN_FAILING: today's default is the circular round,
whose seams jump in curvature by 1/r. On the five-edge apex the corner patch also meets two
rounds at 8.45 degrees (G0).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Fifteen fillet cases on the test-peg's shape with clean numbers: a bar 40 x 16 x 10 whose far
end is a half disc R8, a disc R8 standing 10 on its top, joined, so the front face runs tangent
into the cylinder along x = 40 and the front top edge (convex) meets the concave arc of the top
tangentially there. Each blend ends on a face tangent to the one it rolls on.
- Rounds: both edges together at r2 and r5; one after the other in either order at r2, and at
r1.5 and r3; the front edge alone as a curvature round, whose end on the cylinder is a
semicubical cusp. The containment invariant (the unblended body's exact box, to 4e-5) and
G1 seams, or the analytic volume where the blend has a closed section.
- Chamfers: the front edge alone and the concave arc alone (analytic volumes: the section along
x up to the wall, the cone's spandrel ring clipped by the sides), both together, and one after
the other (1 then 2).
- STEP: the peg written to STEP and read back, its front edge rounded (analytic) and both edges
rounded together.
- A cone: the peg drafted 5 deg, whose front face runs tangent into a cone along a generator,
its front edge alone and both edges together.
The quadratures are tanh-sinh, converged to 1e-13; SMLib's own volumes of the passing analytic
cases agree to 4e-9. A sphere is left out: a plane meets a sphere tangentially at a point, not
along a seam, so it is not this ending.
On SMLib 2fc375f eight fail, listed in KNOWN_FAILING: every chamfer that ends tangent (status
1001, SmFilletNx1Corner), the two rounds together (the corner patch 0.0374 at r2 and 0.128 at r5
out of the front face, and the rounds meeting with normals 180 degrees apart where their
contact lines on the top cross), the same on the STEP-read peg (status 1001) and on the drafted
peg (its corner refused as unsupported).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Two more fillet cases, the reported part's concave arc and front top edge rounded together at
r5 and r7, with the same exact-box containment check (graded to 4e-5, the corner patch's
tolerance). On SMLib 2fc375f the corner patch stands 0.128 (r5) and 0.230 (r7) out of the
bar's front face (box y min -0.0699 and -0.1723): listed in KNOWN_FAILING.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A new fillet case, report-fillet-concave-arc-and-front-top-edge-together-solver-residues:
the reported part's bar (with the sketch solver's residues) whose sides run tangent into the
cylinder, its concave arc and front top edge rounded r2 together. The plane of the front face
bounds the whole body, so every blend lies within the unblended body's exact box (SMLib's tight
box); graded to 4e-5, the corner patch's own tolerance. On SMLib 2fc375f the corner patch
stands 0.0374 out of the front face (box y min 0.0205): listed in KNOWN_FAILING.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A loop that runs out along a chain of edges and straight back (a meridian from a sphere's pole
stopping short of the other, out and back) encloses no (u, v) area, yet on a closed surface it
bounds all of it less a cut of none. The reader only read such a face when the slit already ran
pole to pole (and moved the sphere's frame onto it only then), so the 2 mm ball whose meridian
stops at 2.5 rad was refused for its empty loop.
The slit is now made the face's seams, so its loop bounds the surface's whole domain: on a
sphere, a revolution whose profile ends on its axis, or a spline closed round u that collapses
at both ends, the slit's meridian is run on to both poles, out and back (a sphere's frame put
on the slit first, whichever two points it joins); on a torus, the circle the slit lies along is
closed and the other circle through its start is the second seam. The seams on a sphere are its
own meridians (angle 0 on the equator), so their pcurves are exact lines on its form.
Tests: non_antipodal_seam_sphere_imports_as_a_whole_ball passes (its known-failing line goes);
seam_only_torus_imports_as_a_whole_ring adds a torus bounded by a slit along its tube.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A loop that uses each of its edges once each way (a whole torus within its tube and ring seams)
is the same set of uses run backwards, so it says nothing of the face's side. One written
clockwise in (u, v) turned the face over, against its same_sense: the torus came in inside out
with a warning. Such a loop is now reversed and the face keeps its side.
Test: seam_only_torus_imports_as_a_whole_ring, both orders of the two seams, volume 2π²Rr².
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Its seams grade needs the continuity check to skip the body the round is not on. Fillet cases
wait for the new algorithm.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A square cut is the slanted plane's ordinary crossing; the cam's half turn is the quarter turn's
contact at a symmetric angle; the r15 slab stands inside the same coincidence tolerance as the r10;
the 90 degree unfold and the 40 degree flange repeat the 72 degree and 20 degree cases' formulas.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The sloped-basin chamfers and rounds at 0.5 mm rims repeat the 1 mm rim's regimes; two of the
three knife-edge chamfer tips, the r1 and box r3 curvature corners, the r1 tangent corner, the
1 mm pocket-rim and hole-rim chamfers short of the floor and the r1 together-round each repeat a kept case's regime
and grades. #854 moves to 851-chamfer-arc-top-edge-9-5, and the cases that cited a dropped one
cite the kept one or state its formula.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The ring cut frame's and the up-down join's shells build now, and so do the up-down join's and
modern-plastic's chamfers (SMLib smlib-blend-refusals). #616's lid in the corpus still fails
SMLib's loop check, the shelled box shelled again at an inner wall is unchanged, and the
oblique cut of a cylinder's fillet still fails SmSurfOfRevolution's Test #7: 3 actions of 7.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SMLib keeps the skirt top's offset where its loops wind the other way under the opening, the
cavity's floor (the owner's ruling of 2026-10-31: build it; a lip thinner than the wall is no
break-through).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SMLib's inset now keeps only the regions that are cavity, not the one the offsets close where
they overlap (between the two faces of #545's 0.5 floor, round the up-down join's two empty
octants). The frame's core under the recess is hollowed to a sealed void, so the case says two
shells and its closed form, 21044 mm³.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SMLib's merge now intersects the offsets of an edge's faces where they could not be mated along
it (the hole's offset poking out through the half-round side's; tangency-labs/solidcore#1795):
one closed valid solid with the one face open, as the owner ruled.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SMLib now offsets a vertex where four faces meet (two walls and two facets at the floor's
corners, four facets at the drain) to two vertices joined by a new edge (tangency-labs/smlib
branch smlib-shells). Both volumes match their closed forms. The pocket's lining, hanging from
the top's rim round the pocket, stands apart from the slab's outer walls with the cavity rising
between them to the open top: the case says two shells in the one body.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
926 (the chamfer ending on the boss's wall), the oblique cut's r0.1
round, the every-block r1 round (its seam with the cylinder is no
contact seam, after the blend_seams fix), the up-down squares' concave
chamfers and the shelled box's lip chamfer build with SMLib branch
smlib-blend-refusals (f8650b8 and later). 1207 r0.5 passes SMLib's check
on its rails now and stays listed for the next cause: its end rib on the
boss, which starts where the round and the boss are tangent.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A blend face's name holds the edge it replaced, <face>|<face>, and a side
of that edge can be a blend face whose own name holds a |. Whether a face
is a contact of the blend was read as the edge's name starting or ending
with the face's name next to a |, so the r2 round's own face F2:side read
as a contact of the r1 round F4:blend:F1:+y|F3:blend:F1:+z|F2:side. The
edge's name is now split into its two faces, a blend side read whole as
the two faces of its own edge.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The r1 round of a block's top edge, chained onto the end curve of the r2
round of its arc at a cylinder (rig fillets/every-block-cylinder-crease-
top-edge-after-arc-round-r1), ends where it runs into the cylinder. That
edge is no seam of the r1 round: the cylinder is a face of the r2 round,
not of the r1. blend_seams takes it for one today (the r2 round's name
F3:blend:F1:+z|F2:side holds a | of its own), and the rig reads it as a
contact seam at 60 degrees.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The owner's ruling: a round or chamfer that runs past an outer edge of its face into open air
builds, tangent where it has room and cut by the face beyond where it runs out. SMLib's branch
smlib-blends-past-rims builds them by the rig's analytic answers. Off the known-failing list:
the disc's rim past its 2 mm wall (190), the hole's top rim R12 past the plate's bottom, the
chamfer past the cylinder's bottom (2893), each closing on the wall continued as itself, and
926's chamfer ending on the boss's wall, which now builds to its answer too.
The sloped basins' R4 rim rounds (1080, mitred rounds built together where one overflows) build
to their analytic volumes (to 6e-9), and stay listed with that reason: their continuity check
(g1 at every blend seam) takes in the mitres' creases, G0 by the mitre ruling.
2893-chamfer-two-distances-elliptical-rim is graded as a solid (the owner: it builds) and stays
listed, waiting on the ruling on unequal chamfers along a rim whose angle varies.
5158-fillet-round-just-past-a-10mm-face stays listed with its cause found: the round passes
5e-6 under the box's top back edge, inside the body's tolerance.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A projected spline edge of several Bezier spans came into the sketch as one
curve per span (#1508), so a G2 round's bottom edge was 16 curves and a path
naming the corner named one span of it (#3604). The kernel now reads such an
edge (a spline, or an elliptical arc of several spans) as the one clamped
B-spline it is over the edge's interval, its knots and weights its own, and
the sketch takes it as one control spline whose ends sit on the edge's
vertices. Planar regions still read edges span by span. The 3604 case builds
with its original path and leaves KNOWN_FAILING.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A sketch spline over control points was always the clamped uniform B-spline
over them, so a free-form edge whose knots are not evenly spaced (or whose
weights are not 1) could only come into a sketch as one curve per Bezier
span. A control spline now may save `nurbs`: its clamped knots and its
weights. Its points, polyline, exact pieces (one a knot span; conics for a
rational quadratic), the solver's distance and curvature, links, parallel
re-projection and inspect.sketch all read them; a loaded design's are
checked. One pending format file (spline-knots).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The tangent and curvature run-offs of the quarter cylinder r 10 strip, 5 across the surface,
are its section swept 20 along z: exactly 10 pi/2 20 + 5 x 20 = 414.159265. measure is SMLib's
integration on the exact surface (1e-8), not a mesh, so the run-off check is 1e-6 relative and
the 'measured on meshes' notes go. Red until SMLib's extension is solved to its distance
(smlib-extend-converges 590d8a1): eaa998a's curvature run-off is 4.986 long, area 413.882.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A face tool cut with that face's surface alone, so a face of a surface body made of spans joined
tangent (a fit-point spline extruded, #3830) cut nothing where its span ends inside the body.
Split Body by a face of a surface body now takes the faces joined to it tangentially (the exact
check Extend uses, within the one angle for smooth) and slices with them as they are, through
SMLib's slice by a sheet (smlib_split_body_by_sheet, tangency-labs/smlib 7a01f1b), its sides those
of the picked face. A sheet that only nicks the body cuts nothing, as before; a lone face, or a
face of a solid, still cuts with its surface extended.
3830 comes off the booleans list. Its answer counted the two halves of the cup and not the surface
that cut it, which stays as a body of its own (4879 removes its surface for that reason): three
bodies, the volume unchanged.
Needs SMLib 7a01f1b pinned (SMLIB_REV, prebuilt; its SMLIB_ABI_VERSION 6, which crates/smlib now expects) to link.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A surface body of more than one face (a fit-point spline's spans extruded, #3830) was refused.
Each face with a picked edge is now extended alone by SMLib's extension of its surface, and the
faces are sewn back together, each the face it was. A side that lengthens onto a face meeting it
tangent takes that face along, past its edge continuing the picked one; across a crease the
neighbour grows only when its edge is picked too, otherwise the extension is refused. Faces whose
lengthened sides no longer meet are refused. Up to a target keeps the pieces every grown face
lies in.
3830's extensions now build; its split still fails (the tool point picks one span, and a face
tool cuts with that face's surface alone), so it stays on the list with that reason.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A sheet's side is extended exactly the distance asked, or the call says it cannot (#71);
NVIDIA's -Werror build passes again (#72); a body splits by a sheet of several faces as it
is, smlib_split_body_by_sheet (#73). The C API is ABI 6 (the new entry), so the binding
expects 6.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The path chain oriented its first piece, not its first curve: a first curve
of several exact pieces (a fit spline, an ellipse, a projected free-form
edge) was never turned round, so a path whose next curve meets it at its
start was refused as "not connected end to end". The chain now orients
curve by curve: the first runs toward the second where they meet at one
end only (else from the end nearest the profile), each next one starts
where the previous ended, with one joint tolerance for both questions.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Develop 38fd4a4f6's Reference tests fail 34, 35, 77, 78 and 81 (STEP export finds fillet edges
4.6e-5 to 6.1e-5 off their surfaces against 2e-5), 37 (the apex blend 0.193 off), 80 (the
taper-to-fit area) and 83 (thicken status 1001). Each expected.json names its cause in
known_failure, which the oracle already reads: a known failure that passes fails the job.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Develop 38fd4a4f6 (CI run 41157648345, after the SMLib eaa998a pin) fails 10 cargo tests; each
is listed with the cause its failure message gives. Seven are SMLib refusals or results off
their derived volumes (fillet, chamfer and shell), the cli action matrix and naming corpus
among them; the two corner_g2 tests are the fitted G2 corner patch bulging past the box, which
the explicit G2 corner fixes.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Native Linux tests and the GPU path test shards no longer fail on any failed test: nextest's
"tests failed" exit (100) goes to `cargo xtask known-failing --junit`, which fails on a failure
the list does not name and on a listed test that passes. Any other nextest exit (a build error,
a bad filter) still fails the step at once. The tests skill says to list a failing test with its
cause, in place of ignoring it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
`cargo xtask known-failing --junit PATH` reads nextest's junit (a file, or every .xml under a
directory, so all of a run's junit artifacts at once) and fails on a test that failed and the
list does not name, and on a listed test that passed (FIXED: take its line off, as the kernel
rig's gate does). A listed test that did not run is neither, since a pull request tests only the
packages it touches. The list has the rig's KNOWN_FAILING format (`<test> <cause>`, sorted, the
rig's own parser), with `<test>` nextest's `<binary id>::<test name>`; `cargo xtask lists`
checks it is sorted. The list starts empty.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The round's centre (32 - r, 42 - r) leaves the hollow's corner (30, 40)
outside its circle, opening the wall, where sqrt2 (r - 2) = r: the case
expects the refusal naming 6.828. 2852's R30, refused naming 25.24, now
passes too: both come off the known-failing list.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The owner's rule of 2026-10-30: a round running past a rim of its faces
into open air builds; one whose section would remove material through to
a hollow behind its edge (a slit into the hollow, a cut through the part)
is refused as too large, so the fillet names the largest radius that fits.
Decided exactly in the section of a straight convex edge between planar
faces: the round's centre is at depth r below both planes, and it opens
where its arc uncovers a boundary point strictly inside the wedge with no
material beyond it toward the centre (the body's exact point
classification). Looked at: straight edges parallel to the round's (a
hollow's corner), cylinders about parallel axes (a rounded corner), and a
picked concave parallel edge's own round, which fills the corner.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
"If too large: Stop and say so / Largest that fits / Narrow where needed"
becomes "Face limits: Exact radius / Largest radius / Narrowed radius", in
every language of the catalog, with the error and the tip that name them.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The gate on aarch64 Linux reports 16 fillet cases FIXED with the pinned SMLib: the sloped and
equal-slope basin rim chamfers and rounds past their rims (1080-*, 5835-*), the pocket rim
chamfer past the floor, and the three pocket rim rounds now mitred at the pocket's corners
(every-pocket-*). No other area's gate reports a case fixed.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
chamfer_wider_than_sloped_basin_rim_builds and a_rim_loop_chamfer_running_off_its_rim_builds
waited for SMLib to build the cliff overflow (CloseRemovalRegion refused it,
SM_FILERR_NO_ROOM). The pinned SMLib builds it (eddf0ede4, bba9914b6): both pass on aarch64
Linux and are no longer ignored.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SMLib's point classification at the body's own tolerance, on the exact faces and edges, in
place of a mesh at a chord of 2e-3 of the body's size (about 0.4 mm on a 200 mm part). A point
within the tolerance of a face, edge or vertex is OnBoundary, never decided by a ray. A mesh
body's triangles are its exact shape: on them within the record's tolerance, else by ray
crossings. The kernel's own probes move to it; Body::contains goes once its last callers have.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NvoxKQ2rEZvcXNQnhE3Sgs
Binds the fork's smlib_brep_classify_point (SmBrep::Point3DClassify at the body's own zone
tolerance): inside, outside, or on the boundary within that tolerance of a face, an edge or a
vertex. A box and a cylinder just off its curved wall in measure's tests.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NvoxKQ2rEZvcXNQnhE3Sgs
1080-fillet-sloped-basin-1-mm-rim-r0-5-4-edges asked G1 at every blend seam. Its front wall
leans 19 over 20 and the others 10 over 20, so at each rim corner the two mitred rounds meet the
sloped corner edge at different heights (0.155625 and 0.276393 below the top): the deeper round
runs on past the corner edge and is cut by the plane of the other's wall, a crease by
construction, the gap below the shallower round filled on that plane. The check now measures
the rounds' contact seams, on the top and on each wall, where the rounds are tangent. The
volume is unchanged.
With SMLib smlib-batch-4-mitre (1c15364): the case passes (V 144530.427946 against
144530.427909, 15 faces, sound); before it, only the four corner creases failed the check.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner ruling d6: the letter t of "tres long" was drafted inward by SMLib (its
loop's normal, summed from the cross products of its chords, pointed down;
fixed in SMLib). With the fix every letter grows, and the join builds at 3°
and 15° by the Round rule and by the default rule (tangent for spline
outlines), where before 15° was expected to be refused.
Exact where the outline derives it: a letter's section at height z is its
outline offset by e = z tan a, by the Round rule of area A + P e + C e² while
the offset trims nothing (Steiner; C half each loop's turning less
tan(t/2) - t/2 at each reflex corner), so the letter is
A h + P k h²/2 + C k² h³/3. Each extruded alone, the t at 3° and s, l and o
at 3° and 15° are checked to 1e-6 (SMLib measures them within 1.3e-9; its
mass properties integrate to 1e-8). The concave joins of r, n, g and e are
tighter than e already at 3° (their swallowtails trimmed: r 1.1e-3 under the
formula), the t's by 15° (9.9e-5 over), and on the block the letters grow
into each other, so the whole word is checked for what holds exactly: one
closed body with the block, and half-way up every point of each straight
letter's outline inside the solid (the t drafted inward failed that).
With SMLib's fix (smlib-batch-4-text-loops 82133b2).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SMLib's trim took a fillet meeting its face at more than 78 degrees for one with no side
(smlib-batch-4-rulings 971e567); the chord of the knife edge's 0.5 chamfer meets the flat face at
81 degrees. The case comes off the known-failing list.
Needs SMLIB_REV at that SMLib once it is pushed.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SMLib (smlib-batch-4-rulings 0e83cca, SMLIB_ABI_VERSION 5) rounds the edges whose rounds overflow
their faces first and then what is left of the others; smlib_blend_dropping says which picks'
edges the overflow removed whole. The smlib crate binds it (Brep::blend_dropping), the kernel
returns those picks (fillet_removing), and a fillet notes them as its warning: "the edge at
(0, 0, 10) was removed by the larger round, so it is not rounded" (a 50 x 50 x 20 block, R21 on
its bottom front edge with the front left upright: the block is R21's alone, in closed form).
Ruling d8: [21, 5, 5] on a 20 cube builds as R21 alone (6107.529370); the test is no longer
ignored. R25 with R2 at a corner (blend_corner) builds the same way, R25's alone in closed form,
where it was refused. The rig's 1080 notched block outline at R8 builds now and comes off the
known-failing list.
Needs SMLIB_REV at that SMLib once it is pushed.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
With SMLib's smooth limit at half a degree (422e6f1) the 1 degree crease rounds R2 and R20
(the test is no longer ignored), and with a cusp's chamfer the ball of radius d (d231547) the
The 0.5 one stays, for its own cause (the chamfer face left apart from the body). Two corner
cases the same SMLib (replay/1.0.1 and those commits) builds come off too.
Needs SMLIB_REV at that SMLib once it is pushed.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
R21 on a 20 mm cube's edge builds (6107.529370, closed form, to 2e-12). With R5 on the
corner's other edges the R21 takes the faces they lie on, so the body is R21's alone; SMLib
fails that blend (status 1001, fillet error 4, Unable to Trim Rail Curve) and the test is
ignored until it builds. It replaces the refusal test that expected TooLarge.
Ruling d8 (2026-10-30).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
smlib_chamfer turns the distance into a ball radius d sqrt((1 - c)/(1 + c)), c the faces'
binormals' dot (capi chamfer_radius); at #851's cusp the binormals agree, the radius is 0 and
the call is SM_ERR_INVALID_INPUT before the fillet executive runs (gdb: chamfer_edges sees
radius 0; the dump's why is empty). SolidCraft hands every chamfer to SMLib, so the
ball-contact chord (the ball of radius d: 3.822 wide at d = 2, 159.2365 removed) is SMLib's to
build.
Ruling d4 (2026-10-30).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The blend's tangent angle is the shaded view's half degree (smooth_edges::ANGLE), one value
for smooth. A constant round lies r (sec(d/2) - 1) inside the crease it replaces (about
r d^2/8); below the edge's tolerance it changes nothing and is refused before SMLib (which
answered SM_ERR_INVALID_INPUT), naming the smallest radius that rounds,
tolerance / (sec(d/2) - 1). d is the least turn along the edge
(tangent_edge::least_angle_along, at tangent_all_along's stations).
Ruling d3 (2026-10-30). The block's tolerance is 2e-5 mm, not 0.1 um: at 1 deg the smallest
radius is 0.526 mm, so R2 and R20 reach SMLib, which still calls an edge within 2 deg smooth
(SmEdge::GetBlendEdgeuse); that test is ignored until SMLib uses 0.5 deg.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SMLib measures an extension's distance across the surface (smlib_extend_sheet corrects
CreateExtendedSurface until the parameter line through the side's middle is that long), so each
run-off of the cylinder strip, swept 20 along z, adds 5 x 20: 10 pi/2 20 + 100 = 414.159 for
both. The parabola-length formula (418.18) was truck's.
Ruling d2 (2026-10-30).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Batch 4: drafts and loops, mitre corners, rim chamfers, rulings, tight box, stitch, point
classification, eased corners. Batch 5: a face's tight box divides its cells at the surface's
knots (thread boxes exact); a cylinder, cone, sphere or torus is extended along its own circles.
Batch 6: a revolution's extension closes its turn; a dropped point's foot is the converged one.
The C API is ABI 5 (smlib_blend_dropping and smlib_brep_classify_point are new; nothing existing
changed), so the binding expects 5.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Model cache format 7 (f3cf0c4f3) records a `rounds` list in every saved model, and reading one
without it is refused ("saved model: rounds"), as is a model without any of its other lists:
the states, the preview and the thinned model all came back empty. The io tests' saved_model
and timeline_model wrote format-6 records, so six tests (the round trip, the repeated part
stored once, and the four too-big-for-the-file cases) read nothing. Their bodies are none made
by rounds: the list is empty, and every expectation stays as it was.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
three_rounds_at_a_corner bounded the patch's extra cut at 3 mm³ beyond the strips, a figure
with no derivation; SMLib's all-at-once body at radii 2, 3, 4 takes 3.099 (V 7878.579574
against strips 7881.678). That body is the strips' outside the block its patch lies in: its
rounds are the strips' cylinders ending at a's section y = rc, b's x = 20 − rc and c's rails
where they meet a's and b's (the patch's four corners, now asserted), so the patch takes at
most what the strips leave in that block (11.86 at 2/2/3, 32.69 at 2/3/4). The lower bound is
that block; the upper one, at most the strips' volume, stays.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A design gave another body when opened from its model cache: the rounds a body was made of
lived only in memory, so a later round at their mitre was built sequentially (or refused, as
too large) after opening and blended with them when evaluated anew. The saved model now
records, per kernel body made by rounds, the body they were made on (a place in the bodies,
stored once though no state holds it) and the edges with their radii; reading it attaches
them back down each chain, and a thinned model keeps those bodies with the bodies made from
them. Model cache format 7.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The rounds that made a body are over the body its history is over: a new history (an
operation carrying a step's result back to its own operands) leaves the record out, so a
later round never reads one history against another body. Body::rounds gives the record and
Body::with_rounds_of takes one back, checked (edges of the body before them, a fillet's
radii, the body's history over that body), for a saved model to keep it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Two box edges rounded r2 in one fillet, then the upright edge at their mitre r3 in a second
fillet (tangent chain on, so the seam comes with it): 10 faces, 7928.743041 mm³ as
fillet_radii of the box gives, the r2 rounds' names kept, the r3 round and the corner patch
the second fillet's.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The owner's ruling of 2026-10-30: a later fillet on an edge at a vertex where earlier
rounds already meet in a mitre makes the corner rounding all of them at once makes, one
smooth patch, the mitre gone. A body made by constant-radius rounds keeps what they were
made on and which edges they rounded at which radius; a later round reaching such a corner
blends the earlier rounds' edges (from the earliest of those meeting there on) with the new
edges in one SMLib blend of the body before them. The result's history is put over the body
the later round was given: an earlier round's face is that face trimmed anew (its name
kept), the corner patch and the new rounds are the later fillet's. A picked mitre seam has
no round of its own: it is refused unless a new edge of its radius meets it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A circle drawn as two half arcs now extrudes to one full-turn wall with its
seam edge, and each rim is one closed edge (tangency-labs/smlib#67). The tests
keep their intent on that body: a rim clicked once is one item, measured and
highlighted whole and picked from either side; a wall picked either side of
its seam is the same surface, lit whole, and toggles off from the other side;
every face is its own patch.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The L's six sides, its two caps and the bore: since tangency-labs/smlib#67 the
full circle the conversion fits extrudes to one full-turn wall, not two halves.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Since tangency-labs/smlib#67 an extruded profile's arcs on one circle sweep one
full-turn wall face, made from all of them (Profile 4, 5 and 6 here), where it
was a face per arc. The geometric check of the record finds a face over several
segments by its triangles' centres and vertices on them; the revolved arcs keep
a face each.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
"After every step: checks each sweep, boolean and blend." / "Once per
feature: checks each feature's result once." / "Off (experimental): no
check.", in the order the options are shown, in en, ar, he, ja, zh, de
and ko.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The Design preference surface_extrude_symmetric_per_side, which gave new
symmetric surface extrudes their distance on each side, is removed with
its Surfaces section, its session field and its labels. A symmetric
surface.extrude given no convention splits the total around the start
plane, as solid.extrude does; timeline.edit and timeline.redefine give a
one-sided extrude made symmetric the same. default_extrude_convention,
which only existed to read the preference, goes too.
An explicit `convention: legacy_per_side` and the marker saved designs
carry are unchanged. A saved preferences file that carries the key loads
as before (the prefs test now covers both removed keys).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The Design preference metric_tap_drill_major_less_pitch, which gave new
metric tapped holes the major diameter less the pitch (M8: 6.75 mm), is
removed with its Holes section, its session field and its labels. A new
tapped hole given no diameter drills the tap maker's drill (M8: 6.8 mm);
a custom metric size the table lacks still takes the major less the pitch.
A saved preferences file that carries the key loads as before: serde
ignores keys Prefs doesn't have, and the key is not written back.
The preference's UI test becomes an engine test of the default drill
(M8, 1/4-20 UNC, a given diameter) and a prefs test that a saved file
with the removed key still loads.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SavedModel::thinned wrote `"validation": null` into the records of a model
that records no check mode, so a thinned model was never the model it came
from, even with room for every state, and its manifest grew by that key
(design::tests::a_thinned_model_keeps_the_final_state_then_the_slowest_that_fit,
a_model_cache_too_big_for_the_file_keeps_fewer_states). It copies the mode
when there is one and adds nothing otherwise; the tests' timeline model records
one, as every saved model does now, and a thinned model is asserted to keep it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
An imported solid's faces were mapped to the file's only when SMLib's export numbered them as the
record did (native.rs, numbering). The export is in canonical order, which can list edges
otherwise: the two periodic-knot tubes of #1374 came back with their seam and rim edges listed
[2, 0, 1, 5, 3, 4], so the sheet, a valid B-rep, was refused as "SMLib renumbered the solid's
faces". The export's order says where SMLib's own face and edge i went; put back in SMLib's
order it numbers them as the record does, and SMLib's i is the record's i (an import lists them in
the record's order). numbering now takes that too, checked the same way; an edge split into
pieces is no renumbering and stays unmapped.
The tube test asserts what it should: one surface body, not a mesh, its faces the file's two
faces in order, every face meshed, in under a minute, and the area exact: each face is the file's
quadratic circle (corner weights sqrt(2)/2 to 12 digits) moved straight along its axis, a
cylinder's side, so 2 * 2 pi r h, which SMLib's measure meets to 1e-6.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A solid SMLib refused came in as a surface body of its faces; where SMLib could not stitch those
either, the importer meshed them with SolidCraft's planner and kept the triangles as a mesh body
(step_in/parallel.rs, mesh_part). A build without SMLib showed it: every STEP part of the import
rig came in as a mesh of its faces. That fallback is gone: the solid is not imported, and its
warning names it and gives the kernel's reason ("solid 'Cube': not imported: ..."); a file whose
every solid is refused fails with the same words.
The import report tells a part the kernel refuses (Refused) from one the reader cannot read
(NotImported), and its summary says "N parts couldn't be made into solids and were not
imported" in place of the mesh sentence (en, ar, de, he, ja, ko, zh). STL, 3MF, OBJ and glTF
still come in as mesh bodies: that is what those files are.
The two-tube sheet of #1374 had come in only through that fallback: SMLib's export lists its
edges in another order, which the next commit maps. Until then its test asserts the refusal and
meshes the faces as read at the body's coarse display tolerance, the regression it guards.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Since the body check mode became part of the evaluation context (9acbcf924),
evaluate digests the context with the mode, but Model::adopt still took the
context without it and the default mode: the first evaluation after opening a
design from its saved model saw another context and recomputed every feature
(undoing_an_edit_after_opening_reuses_the_saved_results,
rolling_the_marker_back_keeps_results_after_cache_eviction). The saved model
now records the mode it was evaluated under (thinned ones too), adopt takes
it and digests the context as evaluate does, and a session opening a design
under another mode evaluates it again rather than showing that mode's results.
Model cache format 6.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The owner's bar running tangent into a cylinder rounds its concave arc and
its top edge both together and one after the other in either order, at
r 1 to 7. Two more peg cases come off the fillets known-failing list.
The ladder's shelled dome ring now has 9 edges, not 7: each of its two
cylinder walls is one full-turn face with its seam edge (one wall face per
extruded circle), where it was two halves. Faces, vertices, area and volume
are unchanged.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NvoxKQ2rEZvcXNQnhE3Sgs
Tests that asserted an older design rebuilds as the build that saved it made it
now assert what still holds: it opens, is upgraded, evaluates, round trips and
names alike every time, and a feature that lost a reference asks for it again.
- naming corpus: two builds still name every face and edge alike and find the
same faces with their stored names; a stored name that finds nothing must
leave its feature failed (it asks to reselect), never a feature that builds.
A sketch's face is found by its name as the sketch finds it.
- design corpus: the volumes, areas and bounds the saving builds recorded are
no longer compared; a corpus design may fail only by a request to reselect,
and undo leaves the features that failed on opening failed.
- fixed robustness seeds: no panic, valid bodies and volumes moving the right
way; a step the kernel refuses is not a bug.
- a format 28 design's pieces and a format 13 design's extra bodies: marked as
they open and named alike, without promising the numbers or names saved.
- action matrix baseline: the two corpus designs whose fillets, chamfer and
offset face held names saved before format 14 re-recorded.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Face and edge names stored before format 14 were worked out from geometry and
open marked `?`. They were found among the names geometry gives today, as the
builds that saved them found them, pieces by the one nearest the pick. They
find nothing now: the feature holding one fails, asking for its reference to be
picked again, which stores its exact name. The legacy face and edge names a
body worked out for them are gone.
The tests that found such names as saved now assert the request to reselect:
a saved strip projection, a version 9 emboss on an annulus, a format 10 face
sketch and the corpus design named with numbered pieces.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A face or edge name a feature stored finds only the face or edge it names: the
very name (or a synonym of that face), or the named piece told apart by the
faces around it. A face split into several pieces, merged into another face,
or left only as a face of the same stem is not the face that was picked, and a
name found on several bodies is told apart only by the body the reference's
point lies on. The fallbacks are gone: no piece nearest the pick, no merged
face, no edge at the picked point, no lost link that keeps its last geometry.
A feature whose stored reference finds nothing fails with DocError::Reselect:
blends, face points, sketch planes, sketch projection links, construction
references, hole reference edges, sheet bend edges and cylinder emboss.
The tests that asserted a fallback now assert the request to reselect: split
and removed fillet edges, a merged or rejoined face, a projected edge that was
split or is gone, a projection whose body went, saved strip projections after
wall coalescence, a fillet saved on a piece of a tapered side that is whole
now, a cut that starts from a piece that is no longer that piece, and a fillet
named on the lower of two stacked boxes.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A side drawn in collinear sketch pieces is one face the extrude made from each
piece (#1788): its first role is its name, and the others were kept as aliases,
like the names of faces merged into it by a later join. They are names of that
very face, not of faces merged into it: the face keeps them as synonyms, which
a stored name matches as exactly as the face's name (a piece of it, once it is
split), through copies and later features, and the face whose name a merge
keeps keeps its synonyms too. An extrude-side certificate made on one of the
pieces finds the joined face the same way, and the saved model records the
synonyms (model cache format 5).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Each component's bodies lie in its own coordinates in the state a feature's
points are named in, so a part inserted twice has a face at the same point in
each copy: a thread on the second copy was named after the first copy's face.
The points are named on the feature's own component's bodies first, then on
every body for a point that lies on none of them.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
FeatureKind::face_body did not name Untrim's body, so its face was looked up by
name on every body and could be taken from another one (a copy has the same
face names).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
DocError::Reselect names the feature and the stored reference (a face or edge
name) that no longer finds what was picked: "<feature>: the reference `<name>`
no longer exists as it was picked; reselect it". Evaluation fills in the
feature's name; reselect_parts reads both back from a feature's error text, and
the UI shows the message translated (ar, de, en, he, ja, ko, zh in
assets/locales/pending/reference-reselect.json).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The Design page's Body check section sets the validation preference
(each_feature; each_step keeps the old checks after every step; off is
experimental), applied to the session like the hole and surface extrude
preferences, to the sessions a design is opened in off the window thread,
and kept in step with diagnostics.validation. ui.prefs refuses an unknown
mode; a saved unknown one reads as the default.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
solidcraft-cli run --validation MODE, kernel-cases --validation=MODE and
cargo xtask kernel-cases --validation MODE (with --ladder too), so the rig
runs under each mode.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
With input and output schemas. The mode is the session's user setting:
kept when another design is opened, started, recovered or imported (each
evaluated under it), and by timeline.compute_all. Linked and extracted
designs are evaluated under it too.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The model carries the mode (Model::set_validation) and runs each feature
under it. When a step left its check, every body the feature made or
changed is checked by SMLib before the state is kept: a body the check
refuses fails the feature with the check's reason and the body's name.
The mode is part of the cache context, except each_step, whose results
are develop's.
Validation::EachStep checks every solid sweep, boolean and blend result
in SMLib as before; EachFeature leaves those checks to the end of the
feature and says a check was left; Off skips them. The evaluation installs
the mode around a feature (validating), as watch installs a watch; outside
it every step is checked as always, and the kernel's worker threads run
under the caller's mode.
Under EachFeature a body decoded from a step keeps that step's SMLib
result (for its own record only), and check_kept checks it as the step's
own check would have, then lets it go; any other kept body is checked as
SMLib imports its record. The record can pass where the result fails: a
fillet's surface of revolution whose polar curve SMLib's check refuses
(fillets/1080-fillet-sloped-basin-1-mm-rim-r0-5-4-edges) is rebuilt on
import, and its round meets a wall at 72 degrees; checking the record
alone kept that round.
The largest-size search of a blend checks every candidate as it is built,
whatever the mode: a candidate fits only as a body the check accepts.
Surface operations and stitching keep their checks.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fillets/1080-chamfer-runs-into-openings-refused already expects the
9 mm chamfer built and cut by the openings (V = 3350); its id said it is
refused. It becomes 1080-chamfer-runs-into-openings-cut-by-them, and
blend_fit's chamfer_through_the_openings_is_cut_by_them names it so.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The owner's ruling of 2026-10-30 (d7): a chamfer that reaches or runs
past a rim builds, everywhere, as SMLib's cliff overflow builds a convex
blend: on its faces' continuations, then cut by what the cliff cuts
away. The earlier rule refused a chamfer whose leg runs off its face.
SolidCraft has no such refusal of its own; SMLib refuses these, so the
cases fail on SMLib 985faaee and are listed with its reasons (traced in
gdb at SmFilletErrorInfo::NoteError):
- the sloped basin's single front edge past its rim (1 mm rim 2 and 3,
0.5 mm rim 4): CloseRemovalRegion, "a cliff overflow's fillet boundary
lies on the surfaces of two faces": the sheet's boundary along the end
wall's top edge line from the edge's vertex to the top's contact
(x = 20, y from -1 to 1, z = 30) lies on the top's plane and the end
wall's both.
- the equal-slope basin's rim loop 2 and the 5 mm pocket's rim 5.5:
CloseRemovalRegion, "a cliff overflow's fillet boundary closes on one
face" (every edge of the loop blended).
- the sloped basin's front and right edges 2: status 1001,
SmFilletNx2Corner, CalcFilletIntSideFace.
- the cylinder's rim 2 across the top and 25 down its 20 mm wall: status
1001, SmFilletNx1ClosedCorner cannot compute its geometry.
Expectations, each from a closed form or an exact quadrature:
- chamfer_wider_than_sloped_basin_rim_is_refused becomes
chamfer_wider_than_sloped_basin_rim_builds, ignored until SMLib builds
it: the triangle clipped to y >= 0, times 30 + z (shoelace):
73.450475, 142.112912, 184.526613; the rig's 1080-chamfer-sloped-
basin-*-past-the-rim cases: V = 144459.882858, 144391.220421,
144082.140054.
- blend_corner's a_rim_loop_chamfer_running_off_its_rim_is_refused
becomes ..._builds, ignored likewise: sliced at depth t the mitred loop
takes the pocket's rectangle grown by w(t) = d (1 - t / delta) on each
side, clipped to y >= 0, less the rectangle, Simpson exact on each
quadratic piece: 375.673069, V = 139957.660264 (the rig's
1080-chamfer-equal-slope-basin-1-mm-rim-loop-2 too).
- 5835-chamfer-sloped-basin-1-mm-rim-2-two-edges: the same slicing with
the front and right sides grown, 161.279149, V = 144372.054184.
- every-chamfer-pocket-rim-5-5-past-the-floor: 50 d^2 + (4/3) d^3 at
5.5, the groove 0.5 deep round the floor included, V = 19265.666667,
15 faces.
- 2893-chamfer-two-distances-past-the-bottom: the frustum r 8 to 9.6
over 20, pi 20 (64 + 76.8 + 92.16) / 3 = 4879.102831, 3 faces.
Each drops "-refused" from its id (the 5.5 pocket's says past the floor).
The same slicing reproduces the existing 5835-...-4-mm-rim-2-2-edges
(176.006388), equal-slope loop 0.5 (24.455545) and half-width
(5.426545) values.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The owner's ruling of 2026-10-30 (d7): a chamfer that reaches or runs
past a rim builds, everywhere. The earlier rule refused a full-width
chamfer, naming the largest size that fits. SolidCraft has no such
refusal of its own (a blend's TooLarge is SMLib's SMLIB_ERR_NO_ROOM,
and the doc layer only names the largest fit), and SMLib already builds
these, so only the expectations change, each from a closed form or an
exact quadrature:
- chamfer_wider_than_sloped_basin_rim_is_refused's full widths become
chamfer_as_wide_as_sloped_basin_rim_builds: the whole triangle,
d drop / 2 (60 - drop / 3), drop = 20 d / sqrt((20 - margin)^2 + 400)
(shoelace over the section, its length 30 + z between the sloped end
walls): 21.662379 (1 on 1 mm), 5.359321 (0.5 on 0.5 mm). The basin and
the removal move into sloped_basin and sloped_basin_rim_chamfer_removed.
- fillets/1080-chamfer-sloped-basin-{1,0-5}-mm-rim-as-wide-as-the-rim:
V = 144511.670954, 144261.307346.
- fillets/every-chamfer-pocket-rim-5-full-depth: 50 d^2 + (4/3) d^3 at
d = 5, V = 19583.333333, 11 faces (the walls used up).
- fillets/every-hole-top-rim-chamfer-10-full-depth: the triangle 10^2/2
revolved at rho = 5 + 10/3 (Pappus), V = 16000 - 3250 pi / 3 =
12596.607959, 7 faces.
- fillets/1113-chamfer-arc-top-edge-full-wall-height: the 9.5 case's
Int rho asin(21/rho) h(rho) drho at s = 10, by Gauss-Legendre in
u = asin(21/rho), 1303.400331, V = 8287.993768.
Each drops "-refused" from its id and its KNOWN_FAILING line goes: all
five pass on SMLib 985faaee.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A joint drive with contact on tested each sample and each of 14 bisection
steps with a brute-force mesh-against-mesh overlap check, its cost the product
of the two display meshes' triangle counts under a fixed budget. Since the
display mesh puts nodes inside planar faces, a cam and its tappet or a block and
a sphere exceed that budget ("motion exceeds contact sweep collision budget"),
and whether a motion may run depended on display tessellation.
Now, at each sample, bodies whose exact boxes meet are intersected exactly
(SMLib boolean, exact volume); a shared volume is a contact, a touch (a cam and
its follower) is none. Between the last clear sample and the first overlapping
one the drive closes in by conservative advancement: from a clear placement it
moves no point of the pair further than the pair's exact gap (body_distance),
until the gap is within 1e-9 of the bodies' size. Only clear placements are
measured, so no intersection is asked to tell touching from overlapping within
its tolerance (SMLib's boolean fails there, status 1001, on two cubes 1e-4
into each other). The budget is 2048 intersections per drive.
Fixes cmd::joints::tests::cam::a_cam_drives_a_closed_loop_and_stops_at_a_contact
and contact_sweep ordinary_curved_bodies_stop_at_their_contact_within_the_sampling_budget,
and the other contact, cam, motion, interference and clearance tests pass.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The batch brings history Kept for a face only cut by a vertex, revolve of a
curve touching its axis, loops touching at a vertex, a torus rail on its axis,
and the fillet causes behind the owner's bar running into a cylinder: a
tangent edge past a tangent side edge is the corner's edge, the rails of a
round collapsing at its end end at one point, and a trace from a tangent point
starts along the curve.
The two peg cases with the sketch's solver residues come off the fillets
known-failing list: both build.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NvoxKQ2rEZvcXNQnhE3Sgs
The test it replaces probed for a polyline by placing a 0.2 um square in the
gap between the rim and a 1 um polyline: a micro feature in a millimetre part.
This one asserts the property itself, in millimetres: every rim segment of the
flat pattern is an arc of radius 10, the DXF draws one circle of radius 10, and
a 1 mm cut 0.5 mm inside the rim stays one hole.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A G2 corner patch's side is G2 to its round except near the face it ends
on, and SMLib holds each side as two edges. The smooth-join test judged
each edge alone, so the G2 half was hidden and the line stopped at the
vertex in the middle of the seam. Edges between the same faces that
continue each other at a shared vertex now share one verdict: smooth only
where every one of them is.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
patch_continuity_and_points_cap_a_tube listed "g3" among the values surface.patch must refuse,
from #1521 when a patch built G0 to G2. Since cb8712aa0 Construction::Patch builds G0 to G4
(continuity_order.rs: `Construction::Patch => (G0, G4)`), so g3 is accepted, as it must be;
the order above what a patch builds is g5.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The block solve kept its sparse entries in hashed maps and summed the coupling of each patch's
interior onto the shared unknowns in the map's order, which a hashed map draws afresh each
time: the same loop filled to surfaces differing in their last bits, so a design read back
rebuilt another cap (engine patch_continuity_and_points_cap_a_tube, "the same surface read
back"). The entries are now in ordered maps; a fill twice of the tube's ring and of a hexagon
about a centre are bit for bit the same.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A tube's end has no corner at all; the kernel gives its circle in four quarters, and one patch
on them has a corner on each quarter joint where the loop runs straight on: flat, its two
derivatives parallel, which SMLib's check refuses (Bad Surf FlatCorner within 0.5°). Any
layout with a patch corner on such a loop has one.
Such a loop is now the ring of structured meshing (an O-grid): four patches each on one side of
the loop, two meeting at every point of it, about one inner patch (Quilt::ring). The spokes are
now any curve two patches share (Seam), each glued G1 with linear gluing functions: at an inner
vertex of valence m the characteristic value ±2cos(2π/m) (the centre's spokes as before, the
ring's inner corners with m = 3), at the loop what its two sides' derivatives there ask
(foot_gluing; 0 and their speeds' ratio where the loop runs straight on). IsoFill says where each
spoke starts and ends (SpokeEnd) and holds the inner vertices; the kernel builds them so.
The tube end caps G1 (normal within 0.0157° of the wall, sealed 10458.232 against the tube and
dome's 10458.232) and G2 (curvature across 4.6e-5 /mm against G1's 0.30), five faces with no flat
corner. A crown on the ring lifts the inner patch whole (the ring rises as v(2 − v)).
Saved designs: a general patch on a smooth closed loop (a tube's end) rebuilds as five faces
where it was one (which SMLib refused).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The crown moved the free points along the patch's own normal, whose sign is only the way the
patch happens to be parameterised: the pentagonal window's crown 0.1 sank 1.56 mm into the
cylinder (the middle 9.959 from the axis plain, 8.395 crowned) where the kernel documents it
filling out to the side the G1/G2 neighbours' normals face. The crown now takes that side: the
sum of the patch's normals against the neighbours' over the stations sets one sign for the fill.
The pentagon's middle goes out to 11.526.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The crown's bump went onto the first net with any control point clear of the loop; a coarse
net could leave points supporting the box's middle without it, so the middle rose by only a
share of crown · size (the pentagonal cup: 7.6558 of 13.3877). The net is now refined (knot
insertion, the surface unchanged) until every point whose basis is not zero at the middle takes
the bump, where the middle is inside the loop: the bubble is then exactly 1 there, as fill_loop
documents.
The kernel test measured against the face's domain, which SMLib holds as the loop's extent; the
documented box is the height field's whole domain, the loop's box and 1% more each way (as the
engine's crown test says, 28 × 28 + 1%). Its diagonal is 1.02 times the face's, so the
documented rise is 0.25 × 53.5506 = 13.387661 = 1.02 × 13.125158, which the patch now meets to
1e-6 for crowns ±0.25.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A face's domain and pcurves are on Face::parameters() (its NURBS form when it has one, the
record's documented contract); the general fill tests' quadrature and the pick-order and crown
comparisons evaluated Face::surface instead. A fill SMLib recognises as an analytic surface (the
240° window's G0 patch is the cylinder itself) then read its arc-length domain as angles: the
quadrature came out 4188.79 for the window's 418.879 (10 × 41.888 of angle against 4.189).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A vertex where the loop runs straight on (SMLib's seams: a cylinder's at 35.12° splits a half
circle into two arcs) was a corner of the fill's region, so a patch had a 180° corner there:
flat (its two derivatives parallel), degenerate, and refused by SMLib's check (Bad Surf
FlatCorner, within 0.5°). Half a post's side, six edges on four corners, was six patches about
a centre and folded.
The region's corners are now the vertices where the loop turns by more than the kernel's corner
test (1°, IsoSpec::corner_turn); a side is the chain of edges between two corners, held as one
exact B-spline (each edge carried exactly to the side's degree on its stretch, joined at a knot
of full multiplicity, which the knot-line rows keep tangent across). Each edge's pcurve is still
a straight line, now on its stretch of a patch's side; a spoke says where on the loop it starts
(IsoFill::feet). A loop with fewer than three corners keeps its edges as sides.
The half post is one face again (a_loop_that_does_not_bound_a_height_field_fills_with_one_face),
the 240° window is one patch, the exact cylinder (area 418.879), and the torus window fills G0
and G1.
Saved designs: a general patch on a loop with seam vertices rebuilds with fewer faces (the half
post's 6 become 1), its corners where the loop's are.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Across each spoke the two patches' derivatives away from it were held opposed (parametric C1).
At the centre that asks the spokes' tangents d_{k-1} + d_{k+1} = 0, which for N other than a
multiple of four only d = 0 meets: every patch got a flat, singular corner at the centre (a
pentagon on a wavy rim: derivatives of 3.3e-5 there; the hexagonal rim's control net doubled
back and SMLib's check refused it as NonMonotonic).
The join is now G1 with the linear gluing function of Loop, Peters and Hahn:
d/du S_k + d/dv S_{k+1} = alpha(t) d/dt S along the spoke, alpha(t) = 2 cos(2 pi / N) t. At the
midpoint alpha is 0 (the edge's two halves leave it at the same speed, opposed); at the centre
it is the value any affine image of the regular N-star meets, d_{k-1} + d_{k+1} = 2 cos(2 pi/N)
d_k. N = 4 is the old row. The pentagon's centre corners now open 72° with derivatives of 16.2
(N = 5 to 8: 360°/N each).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A tensor patch's cross derivative along a side is, at a corner, the tangent of the side it
meets there (the two share the corner's next control point): the compatibility condition of
Coons and Gregory interpolation. The weak rows asked t·c′ = 0 and w·c′ = s right up to every
corner, which no patch can meet where the next side is not square to the edge; at a smooth
vertex (a tube's end in four quarter arcs) the next side runs along the edge itself. The least
squares spread the contradiction into the first spans and folded them: the tube end's worst
normal went 13.8°, 17.9°, 89.8° (folded), 85.6°, ... 25.1° (folded) with refinement, and the
symmetric loop came back asymmetric.
The target is now the Coons start's own cross derivative, compatible at every corner by
construction, turned about the edge into the neighbour's tangent plane (its part along the
edge kept, the rest laid along the leave direction at its length). The tube end converges
21°, 3.8°, 0.76°, 0.18°, 0.045°, symmetric, and does not fold.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
An edge SMLib reports as new was given the origin "where its two faces meet", each side what
that face came from. A split line lies between two pieces of one face, so both sides are that
face and the edge read EdgeOrigin::Meet { top, top }: a face meeting itself, which no two faces
did. Such an edge now has no origin, as the history's EdgeProv documents for a new edge between
faces new to the operation (the doc now names the split line too).
New test: a_split_line_comes_from_nothing (one face split in two, its new edge has no origin).
modify_history_tests::split_a_face checks this at its last line; it still fails earlier, on its
counts ([3, 2, 2, 0, 0] for [5, 0, 2, 0, 0]) on develop's SMLib pin, until SMLib batch 3's
history fix (03bbc88) is pinned.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The closed-box certificate took exactly twelve triangles, two a face. The one mesher puts
interior points on planar faces (a 20 x 20 x 2 box comes in more than twelve), so
render.preflight refused a box as "unsupported dielectric boundary tessellation"; a box is a
box however its faces are triangulated.
The certificate now reads the mesh's geometry exactly: every triangle in the plane of one of
the faces of the box its points span (corners on it, normal exactly that axis) facing out,
and the triangles a closed, consistently oriented surface (each edge, by its ends' exact
coordinates, run once each way). Such a surface is a 2-cycle on the box's boundary, a sphere,
so it covers every point of it the same k >= 1 times, and its area is k times the boundary's:
k = 1 is decided by the area being under 1.5 times the boundary's. Up to 65536 triangles. A
thin sheet is still one or two triangles; a general closed mesh is still refused.
New test: a box with its top fanned from a point in it is certified, with the same bounds;
the point 1e-9 off the plane, or the top covered twice, is refused.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A tapered extrusion of a region with holes checks, at its two ends, that each hole's section
stays inside the outer loop's and clear of the others. Those sections were made with the
start section's rule, which refuses a line the offset swallows ("draft extrusion that starts
before its profile where the taper closes a side"). At the far end such a line is ordinary: a
short line between two concave corners whose wall closes on the way up. The letter g of
"tres long" (8 mm, joined 2 mm with a 3 degree taper) has one, and the whole text was refused
with a message about the start that does not apply.
The end check now takes the section as it is there (offset_loop's swallowed lines left out, their
neighbours meeting where they were); whether the closing wall is built stays the draft's to
say. The g builds at 3 and 15 degrees.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
raked_wedge (#1617, test from 7f2ae11a0 on 2026-10-17) rounds four end edges R4. Since
84bd2daad (2026-10-22) solid.fillet carries each picked edge round its tangent chain by
default, so the R4 now ran on round the end outline onto the R1.2 round's end arc, where the
round's rail on the end face would be an arc of radius 1.2 - 4 < 0, and it is refused as too
large. The issue's R4 rounds those four edges alone: the step says tangent_chain: false.
The test still fails, one step later, on SMLib: the issue's R0.854 round of both ends' outline
is refused by SMLib's own check (SmBSplineSurface Test #5, "close to singular at boundary"),
reported for the SMLib batch.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
tiny_cut_inside_exact_circle_survives_unfold_refold_and_dxf cut a 50 nm square 0.2 um inside
the disc's rim. SMLib models at a zone tolerance of 1e-4 mm: its check refuses the cut's 50 nm
walls as planes "degenerated to a point (tolerance=0.0001)", so the extrude was refused. A
feature below the kernel's resolution is not one it can keep, on any path.
The test's point is that the exact circle, not its display polyline, bounds the flat pattern:
a cut between the two must survive unfold, refold and the DXF. The polyline at 1e-3 has 224
chords (sagitta 10 (1 - cos(pi/224)) = 0.98 um), so the square is now 0.2 um across, centred
0.4 um inside the circle on the first chord's bisector: outside the polyline, inside the
circle, its walls and its 0.3 um gap to the rim above 0.1 um. Its hole's area is
(2e-4)^2 = 4e-8 (was 2.5e-9 for the 50 nm square).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A strip's far curve, where its rulings turn along the edge, is a B-spline in the edge's own
spline space. A straight edge's space is one linear span, which holds only the chord between the
strip's corners: the rulings' ends (the closeness term) had no say, and the strip had no handles.
Off the patch over the cup's rim in a_strip_off_a_curved_face_is_ruled_to_its_far_curve the
normal along the straight rim at x = 14 turns by 5 degrees (x component -0.350 at the ends,
-0.262 at the middle; the patch's middle is at z 10.296, not the cylinder's 10), so the strip is
free and its rulings' ends lie up to 0.26 mm off that chord.
Such an edge is now taken as the cubic Bezier it also is (exact degree elevation: control points
at thirds, the same points at the same parameters) before the far curve is solved, so the far
curve has two interior control points: its handles. Exact strips on straight edges keep the line.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Since 6cc759750 an extruded circle is a cylinder over the face's trimmed range, and the circle was
fitted through three points of that range. On the shallow strip of the extruded-ellipse test
(radius 3000, 6 mm wide: 0.002 rad round) the three points are 2 mm apart and the fit is
ill-conditioned: the centre came 2.5e-10 mm off the circle's plane (the frame's x axis tilted
8.3e-14 out of it) and the radius 8.1e-9 mm short. SMLib took that cylinder, but on the way back
(the import's SMLib round trip, then Body::smlib) SmCylinder::IsNurbSurfaceCylinder did not find
a cylinder in SMLib's own NURBS of it, and the strip was refused as needing repair
(SM_ERR_INVALID_INPUT, AnalyticOfNurbs). Before 6cc759750 the fit ran over the record's domain,
1.4e-6 rad wider on each side, and happened to come out level.
The patch's trims were right all along: they straddle the profile's seam (u = 4, the knot
between the spline's two quarter spans) without wrapping, [3.9992930395761980, 4.0007069604238020],
which is the exact 0.001 rad either side of it.
The circle is now fixed by three points on the arc's widest knot span (a quarter turn here),
where it is determined to rounding, and checked as before at 65 points over the face's range.
A revolution's profile circle is fitted as before.
Regression test (smlib import tests): a 0.002 rad patch of an extruded circle of radius 3000
across that knot is the cylinder of radius 3000 to 1e-10 (it was 2.8e-10 short), its axis
along z to 1e-15, over exactly the patch's range.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
a_long_setback_keeps_the_g2_patch_inside_the_box measured the patch's reach past the box on
the vertices of a display mesh at chord 1e-3, so where the tessellation's nodes fell decided
the result (#9307 moved them). It now brackets the highest max(x - 60, y - 40, z - 20) on the
patch within its trim from the exact B-spline: the surface cut into its Bezier patches, split
by de Casteljau while a patch's control hull can still beat the best surface point found
inside the trim (the pcurves), so the hull bounds it from above and the patch corners from
below.
Body::exact_bounds (SMLib's SmFace::CalculateTightBoundingBox) is not used: it gives the
patch 40 + 1.4e-14 in y at set back 12, while the surface at (u, v) (-1.509, 8.041), inside
the trim, is at y = 40.00133 (a mesh node there agrees).
The bound is 1e-9 mm: the body is convex, a convex face lies inside each tangent plane, and
the patch meets each box plane tangentially along its seam, so it reaches past none of them
but by rounding. The exact extent shows the patch does reach past the box at every setback,
each time 0.4 to 0.65 mm from a hole corner (where a round's section ends on a plane, inside
the fill's fade zone): 7.0776e-4 (s 11, z), 1.3298e-3 (s 12, y), 2.6338e-6 (s 13, y),
5.1293e-5 (s 14, x), 4.7891e-4 (s 15, x). The test fails with these numbers until the patch
construction keeps the fill convex there.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Zebra, Draft, Curvature Map, Environment Map, Accessibility, Continuity,
Isocurve and Curvature Comb are one group: turning one on turns the one on
before off (Session::analyses_off), and the session says which is on
(Session::active_analysis). The new inspect.analysis names it and off: true
turns it off (typed contract and reply). The toolbar shows the active one's
button pressed, its tool running or not. Curvature Comb's button toggles:
on, the tool combs the edges clicked; again, off and the combs go; Esc or a
right click in the tool turns it off; opening another dialog leaves it on.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
inspect.curvature_comb keeps what it shows in the session (Session::comb):
add: true combs the new picks together with those shown, so every comb
shares one scale and tooth lengths compare across curves (a curvature jump
where two edges meet shows); with nothing picked it draws those shown again
with new options; clear: true ends it. Each sketch curve keeps its own
sketch. The tool runs it once per pick and per Comb length / Teeth change,
and the viewport draws the session's combs.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
comb_envelope and comb_teeth in the light and dark palettes (legible on each
view background), themable from a theme file, measured by the colour vision
tests.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This replaces the spline fallback of 64efbe7f6. A face SMLib holds as a rational spline that is
an extruded circle was recognised as a cylinder over the spline's whole parameter range: for the
upper half of the peg's wall after the front top round that range runs 393 degrees round (u in
[-15, 40.18], SMLib's support surface extended past the face), and SMLib refuses a cylinder past
one turn. The face itself, its loops' box, spans u in [0, 8 pi]: half a turn. The cylinder now
takes the face's trimmed range, the least and greatest u and v of its uses' pcurves over their
edges' intervals, found to rounding on each Bezier span (the values at the pieces' ends bound the
extreme from below, the control points from above; pieces that cannot beat the best are dropped,
the others halved). A face whose trims run more than one turn round is no face of a cylinder: it
is refused as an invalid record, never kept as a spline.
The peg (40 x 16 x 10 bar, R8 end, a disc R8 extruded 10 up on its top, joined), front top edge
rounded r2: the body measures to 1e-7 of its closed form, the three r2 corner rounds after it
build and measure, and the upper wall comes back from SMLib a cylinder of radius 8 (engine test).
The rig case of the round of the edge where that round meets the wall (tangent at one end) still
fails, for another reason: on the wall as its exact cylinder SMLib refuses the round as larger
than the faces beside its edges allow (it fades to nothing at the tangent end) instead of
returning a body its own check refuses. Its KNOWN_FAILING line says so.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This replaces the five fixed stations of 0a166bf3d, which compared the faces' normals at the
edge's ends and quarters: a sampled guess that misses a crease or a tangency between stations.
Along each use's pcurve (on the edge's own parameter), the face's natural normal Su x Sv is a
polynomial in t on every piece where the pcurve stays in one span of its knots and one knot cell
of its surface: of degree (2p + 2q - 2) r for a B-spline surface of degree (p, q) and a pcurve
of degree r, (4p + 4q - 2) r for a rational one (its homogeneous form), 0 for a plane. The cross
product of the two outward normals is then a polynomial of degree D, the sum, and it vanishes
on the piece iff it vanishes at D + 1 points of it (the piece's Chebyshev points). Pieces end at
the pcurves' knots and where a pcurve crosses a knot line of its surface (periodic copies too),
each a root of U(t) - k W(t) on a Bézier span, isolated on its Bernstein coefficients. A point
where the normals differ is a witness of a crease; agreement at all of them is a proof of
tangency (crate::tangent_edge). Outward normals opposite (a cusp, a knife edge) is not smooth,
as SMLib's GetBlendEdgeuse has it since fork 81f411d; a seam, whose two uses are on one face,
is smooth.
The C API has no edge classification query; SMLib's own (GetBlendEdgeuse at t = 0.34,
IsTangentSector at five stations) is sampled too. A fork item to make it exact and expose it is
written up for the SMLib batch. The tangent-chain walk decides each edge once.
The bar whose front face runs tangent into a cylinder R8, its front top edge rounded r2: the
round's contact with the front face and the front face's tangent line with the wall are smooth;
the round's edge with the wall (tangent at (40, 0, 8) only) and a box edge are creases; the
knife edge of #851 is a cusp, not smooth (blend.rs test). The blend, fillet and chamfer kernel
tests and the fillets rig keep their outcomes.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A curvature-continuous fillet (type curvature, equivalent radius 2) of the three edges at a top
corner of the owner's bar built, but its corner was SMLib's own patch, which is only tangent to
the rounds: Continuity Analysis measures a 35.8 / mm curvature jump across its seams (with the
rounds G2 to the faces everywhere else), and it shows as a dome sitting on the corner, the
vertical round's shading lost under it. All three edges were rounded; the corner was not
curvature-continuous, and nothing said so.
Such a corner, where three or more rounded edges meet, is now set back (1.5 r unless a setback
names it) and left open by SMLib with the curvature sections (smlib_blend_setback_open with
SMLIB_BLEND_CURVATURE), and filled with the G2 patch fillet_g2_corners already uses for circular
rounds (fillet_g2_with_g2_corners). The `corner` option no longer leaves a curvature fillet with
SMLib's patch: its corners are always G2, and setbacks on it set back the curvature rounds (they
were circular rounds before). Where SMLib or the patch cannot build it, it is refused.
On the reported geometry every seam of the rounds and the patch is G2 (rig
report-fillet-curvature-three-edges-at-bar-corner-solver-residues), and the rounds outside the
setback cube measure exactly: V0 - 27 - (the quintic section, A2 = 0.597884, along the front edge
from 3 to the wall and along 7 and 13) = 9541.116961 (...-outside-setback). With round coordinates
SMLib's open sheet fails its own check (a 2D curve cusp, SmBSplineCurve test 13): the fillet is
refused, listed as known failing (report-fillet-curvature-three-edges-at-bar-corner).
Test: corner_g2_tests::curvature_rounds_meet_at_a_g2_corner (box corner, r5: the patch's jump
under CURVATURE_SHARE / r clear of the hole's corners, SMLib's own patch over ten times that).
Changes a default: a saved curvature fillet with such a corner rebuilds with the G2 patch; there
is no preference or fallback to SMLib's patch.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The cases from the owner's reports in the app (no issue) were named and cited after issues they
only resemble (#9, #896, #1207). They are report-<name> now and list no sources; their `what`
says where they were reported. The README gives the convention (report- for a report with no
issue or pull request, cov- for a command with no source).
report-fillet-g2-corner-of-bar-running-into-cylinder was graded by a 3^3 volume band and a face
count, which say little about a G2 corner. It keeps the band (provable: the patch differs from the
rolling ball only within the setback cube) and adds the corner seams' curvature jump, as
fillets/9-fillet-corner-r1-curvature-default-setback scaled by r = 2 (at most 0.0025 / mm, clear
of the hole's corners by 0.48 mm, within 4.4 mm of the corner). A new
...-outside-setback case cuts the setback cube [-1, 3] x [-1, 3] x [7, 11] away and grades the
three rounds outside it exactly: V0 - 27 - (front spandrel from x = 3 to the wall + (1 - pi/4) r^2
over 7 and 13) = 9342.029541. The bare face counts are dropped.
The -solver-residues recipes now take the reported sketch's points exactly (the arc's end
x = 41.649711830726524); they fail as before.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A 220 x 11 two-distance chamfer of a tapered plate's bottom front edge (rig fillets/5181) runs up
the front face past its straight side edges, l2|start and l6|start, and takes them up: no result
edge comes from them. SMLib leaves the blend face untagged, and it was given every blended edge
whose two faces lie next to it: the picked edge l1|start and both taken-up side edges. Its name
came from the first in edge order, F3:blend:F2:side:l6|F2:start, an edge the user never picked.
A blend face now comes from the picked edges it lies between; only a face that lies between no
picked edge's faces (a corner's piece over a short edge the corner took up) comes from the
taken-up edges it lies between. The chamfer is F3:blend:F2:side:l1|F2:start everywhere on it.
Persistent names: a blend face that also lay between the faces of an edge the blend ran over is
now named by its picked edge only. There is no alias for the old name (5181's
F3:blend:F2:side:l6|F2:start): a saved reference to it is reported lost.
Also corrects 5181's "what": the chamfer builds (335399.749), it is not refused.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
An r2 round of the arc adds the spandrel ring clipped by the bar's sides, integral over rho in
[8, 10] of [2 - sqrt(4 - (10 - rho)^2)] rho 2 asin(8 / rho) = 18.455363. With round coordinates
it builds to that; with the reported design's sketch residues (~1e-10 mm) SMLib's blend fails,
status 1001 (SmFilletNx1Corner: unable to make topology at the arc's end), listed as known
failing.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The edge where a round runs into a cylinder's wall it is tangent to at one end (the bar's front
top round meeting the wall at (40, 0, 8), where the round's contact with the front face meets the
wall's tangent line with it) was refused as smooth, "nothing to round": the faces' normals were
compared at the edge's start alone, which was that tangent end. They are now compared at five
stations from end to end, and an edge is smooth only where its faces meet tangentially at every
one: this edge is a crease everywhere but its end. The wall's seam with the front face, tangent
all along, is still refused as smooth.
The round of that edge with its tangent chain (the top's concave arc) now reaches SMLib, whose
result fails its own check (internal poles, coincident control points, cusps where the round
fades out): its rig case in fillets is listed as known failing for that SMLib defect.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A round of a bar's top edge, where the bar's side runs tangent into a cylinder standing on its
round end, seemed to build: SMLib's result holds the cylinder's wall as a rational spline whose
parameter range runs 393° round (u in [-15, 40.18]). Going back into SMLib (to measure the body
or change it again) the record's extruded circles become SMLib cylinders with the face's range on
them, and that range was 6.866 rad: SMLib refuses a cylinder past one turn
(SM_ERR_INVALID_INPUT from BrepFromFlat's face range check). The body could not be measured, a
second round on it failed, and the app said one of its freeform faces can't be used. An extruded
circle whose range runs more than one turn round now stays the exact spline it is.
The bar of the reported design (40 x 16 x 10 with a R8 end, a disc R8 sketched on its top and
extruded 10 up, joined): the front top round removes the spandrel up to the cylinder's wall,
integral over y in [0, 2] of (2 - sqrt(4 - (2 - y)^2)) (40 - sqrt(64 - (8 - y)^2)) = 32.306475;
the three rounds at the other top corner after it remove 53.285832 in all (spandrels outside the
corner cube, the cube less the rolling ball's eighth). Both now build and measure to 1e-7; the
curvature corner of the three edges at once (setback 3) builds too.
Rig cases (fillets) for the three reports: the curvature corner of the three edges, the front
top round, and the three corner rounds after it pass; the same corner rounds with the design's
~1e-10 mm sketch residues fail in SMLib (its corner's surface of revolution is close to singular
at its boundary) and are listed as known failing. (Their ids take the report- convention in the
rig commit later on this branch.)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
chamfer_wider_than_sloped_basin_rim_is_refused and
a_rim_loop_chamfer_running_off_its_rim_is_refused assert what the kernel gives: a
TooLarge refusal, the body unchanged. The largest size that fits is named by the doc
layer (with_largest_fit) and graded by the rig's 1080 basin cases through commands.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fillets/851-fillet-knife-edge-tip-r2 passes on develop's SMLib (985faae): its line
leaves KNOWN_FAILING. The chamfers of the same edge still fail.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The owner ruled on 2026-10-30 that rounds meeting at a concave corner beside an
unpicked sharp edge are mitred, which fixes the basin loops' re-entrant corners.
Each loop case now grades its exact volume (rel 1e-6): each blend takes
Int width(z) length(z) dz, its section's width from its wall to its arc or chamfer
line (the front one clipped at the slab's face where it runs past the rim), its
length between its neighbours' walls extended; each corner of two picked edges adds
the overlap of their section prisms in the quadrant beyond both walls,
Int width_1(z) width_2(z) dz (r^3 (5/3 - pi/2) for vertical walls, as
every-pocket-rim-edges-r2). One edge alone reproduces the single-edge closed forms to
3e-7 of the removal. The equal-slope chamfer loop 0.5 passes; the others stay on
KNOWN_FAILING with the causes they had (SMLib status 1001, the surface-of-revolution
check, rounds past the rim not built by subtraction).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The 851 table rows grade continuity again, on each round's seams to the faces it
rolls on, picked by points at the middle of its edge (the top front round's at
z = 8 on the front and y = -19 on the top, the arc's at rho 23 and rho 21, the
uprights' at their contacts). The default `blend` selection read G0 there because
it pairs a blend face with the contact faces of every edge in the feature, so where
a round ends square on another edge's contact face (a crease by construction) it was
graded as a tangent seam: a gap in the grader's seam selection, worked around here
by naming the seams. All seven rows pass.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fillets/1668-fillet-outer-top-edge-of-thin-wall-r7-past-inside-corner (and the
both-sides R7 case) now grade the volume at rel 1e-6 (0.04 mm^3), not the rig's
1e-3. The closed form is exact: V0 = 104 64 42 - 100 60 40 less the round's
section (1-pi/4) 49 along 104 plus its part over the hollow, the square
[25,30] x [35,40] outside the circle about (25,35), Int_sqrt24^5 (5 - sqrt(49-u^2)) du
= 0.0050679 mm^2 (a 0.0005 grid gives the same to 1e-9), along 100: 38458.896.
SMLib gives 38458.389, 0.507 mm^3 less: exactly that part over the hollow, which is
not material, taken anyway where the round opens its slit. The unit test's bound
was right; the case goes on KNOWN_FAILING with that cause. The both-sides case
passes at the tighter tolerance.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Unit tests assert the code's logic, the kernel rig asserts geometry through
commands with hand-derived answers; one example of each. The rest of the skill is
tightened to keep it under the skills check's 3600 characters.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The round trip's volume moves from the STEP unit test to an import rig case
(616.850, Pappus); the unit test keeps the writer's logic, the degenerate torus
written as one B-spline face and no toroidal surface or surface of revolution. The
case fails today where the revolve does (KNOWN_FAILING).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The horn torus quarter (a circle r5 touching the Z axis, revolved 90 deg) is a
sweeps rig case with its Pappus volume, pi 25 x 2 pi 5 / 4 = 616.850. SMLib's
revolve refuses the profile today (status 1001), so it is on KNOWN_FAILING.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A cylinder r10 x 30 with its top face deleted, the rim patched G1 and G2 and
stitched, becomes two continuity rig cases: one valid solid whose rim seam reaches
the order asked (the dome's shape is the fill's own, so no volume). They fail
today as the unit test did (the general fill refuses the cap: it folds) and are on
KNOWN_FAILING; the unit test and its helpers are removed.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A 240 deg window through a cylinder's wall and a saddle window in a torus's inner
wall, their cut faces deleted, patched G0 and G1 and stitched, become surfaces rig
cases: the G1 cylinder seals to the whole cylinder's volume within 0.5 % with G1
seams on the window's edges, the G1 torus reaches G1 on its rim, the G0 fills are
one valid solid. They fail today as the unit tests did (the general fill refuses:
it folds) and are on KNOWN_FAILING; the unit tests are removed.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The shell unit tests that checked geometry become shell rig cases built through
commands: the trough and the pocket whose floors fall 1 deg to a central drain
(the pyramid made as two triangular prisms intersected, in place of
convex_polyhedron; the cavity integrated exactly over the cells where each moved
facet is highest, sharp inner corners as the ladder's tier 09), the box opened at
a bottom rounded R2 and R2.4 (refused: the rim would have no thickness) and R1.5
(built, exact volume), and the plate with a hole through its arc side. Four
action-matrix shells that regressed (issue-616's lid, the ring-cut frame, the
filleted shelled box shelled again, the up-down join) get small cases too. The
ones that fail today are on KNOWN_FAILING with their cause, and the unit tests are
removed.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The fillet and chamfer unit tests that checked geometry become fillets rig cases,
built through commands with answers derived by hand (each method field gives the
derivation): a plate outline and a disc rim as tall as or past their wall, a
notched block's outline at R7 and R8, a cube corner as wide as its faces (refused,
and reduced), the 1668 wall at R7 alone and both sides, the 2852 U shell at R30
(refused, naming 25.24), the 851 knife edge (R2, chamfers 0.5/2/5 on three
constructions), the arc top edge at the full wall height and at 9.5, the 851
table of selections, the 556 top edge ending on the boss wall, the 2893
cylinder-rim chamfer refusals and the elliptical rim, seed 33's full round, the
sloped basin rim blends (single edges with exact volumes, loops with the slab's
box), and three action-matrix chamfers and fillets. fillets/851's three-edge
corner gets its volume (67.051 removed, re-derived on a grid; the engine test had
67.05). Chamfers whose leg runs off the face beside the edge are refused and rounds
past a face on its tangent side build, as the owner ruled on 2026-10-30. The cases
that fail today are on KNOWN_FAILING with their cause.
The unit tests are removed, except two cut to what no command can express: the
per-edge-radius refusal at a cube corner and the chamfer of a cylinder's seam.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A colliding pair past the 16 pairs whose volumes are worked out, or past
the check's 256 body intersections, or whose intersection could not be
made, fell back to the sampled mesh depth for its deepest step. That
changed what deepest_step means without saying so. Such a collision now
answers deepest_step and volume_mm3 null and not_measured naming the
budget it ran past (or the intersection that failed), as compare does
since #9132; first_step, last_step and steps are exact and stay.
B pushed through A at 1000 samples overlaps it at about 330 samples, past
the 256 intersections: not measured, "the check's 256 body intersections
ran out". At the study's 16 samples it is measured, deepest at step 15.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
motion.interference picked a collision's deepest step by the depth sampled
on the contact meshes (vertices, edge midpoints, triangle centres), and
worked out the exact shared volume only there. That depth depends on where
the mesh puts its points: since planes mesh as their boundary's triangles,
the arm turning into a block (rig case
assemblies/cov-motion-interference-arm-into-the-block) sampled 4.64 mm at 60
degrees and 2.0 mm at 90, and the check answered step 6 with 536 mm3. The
exact depth is 5 mm at every step from 60 to 90 degrees (both slabs are
10 mm thick), so depth cannot tell those steps apart.
The exact shared volume is now worked out at each sample a pair overlaps,
and the deepest step is the first with the most (a tie keeps the earlier
sample). The arm and block share 536, 807, 952 and 1000 mm3 at 60 to 90
degrees, so it is step 9 with 1000 mm3, at 10 samples or 19. depth_mm is
reported as before and documented as an estimate from the contact meshes.
volume_mm3 is null, and the step falls back to the sampled depth, when the
volume was not worked out at every sample (more than 16 pairs, or past the
boolean budget, raised from 64 to 256 now that it covers every sample).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Where two curves of a face touch or cross by less than the chord tolerance, halving their
chords never parts them, and the face was left to the lenient fill: thin_face_tests::
a_face_touching_its_own_edge_meshes (#1648), an arch dipping 2.8e-7 mm below its face's
bottom line, came out 0.659 mm2 against its boundary's 0.567 at tol 0.3.
After the halving rounds, a face whose boundary still crosses itself has each node that lies
within the chord tolerance of a crossing chord of another edge (strictly between its ends) put
onto that edge as well, the same point (edges::snap; the node is marked as snapped). In a face
that runs both edges, the snapped node takes the other's parameters, so the boundary passes one
point of its (u, v) twice (a pinch) and the chords meet there instead of crossing; the edge's
other faces get the node too, within the tolerance of their pcurve, so the mesh stays
watertight. Where the curves run within the tolerance for a stretch, the nodes either side are
shared in turn and the boundary runs out and back along one polyline (a slit). A node is not
snapped where the pinch would turn part of its loop inside out by more than the tolerance (two
curves crossing at an angle: the face is refused, as before). Nothing is loosened: the
crossing test and the triangulation's boundary check are unchanged.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A planar boolean leaves a cut-out's corner that touches another loop's corner as two vertices
a hair apart: in the sheet refold tests (doc sheet a_cut_out_on_one_side_of_a_bend_line... and
a_cut_out_with_a_corner_on_a_bend_line...), a triangle's corner 1e-8 to 5e-8 mm from the base's
corner on the bend line, both vertices of tolerance 1.05e-4. Their loops then cross by 1e-8 in
(u, v), which no constrained triangulation can keep, and the face was left to the lenient fill.
The boundary build already makes a vertex the face passes twice one point of its (u, v). Now a
vertex within the tolerance of another of the face's vertices (the larger of the two, at most
the chord tolerance) takes that one's parameters too, so the loops touch at one point, a pinch,
as at a shared vertex. Not for two vertices an edge of the face joins: the edge says they are
two points, however near (a_ledge_beside_an_edge_as_tall_as_the_setback_goes_with_the_strip
has a 1e-4 mm step, within the vertices' 1.18e-4 tolerance), nor at a pole.
Test changed, with the reason: thread_display_mesh_stays_on_its_surfaces checked every triangle
whose three corners lie at the core radius rc as one of the core cylinder, and wanted its centre
within 2 tol of rc. The flat end disc of the M10x1.5 thread (z = 12) has its corners a hair
apart too; joined, it is meshed strictly from its boundary (a plane, e39fbdebb), and one of its
triangles has its three corners on the rim, centre at r = 3.956, on the disc. The end-disc
exemption the test already makes for its radius check now covers this check as well.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
uv::divide started every curved face from ceil(range / (pi/2)) lines, as if the parameter were
an angle. A spline's is not: SMLib holds a 90 degree bend as one rational quadratic span with
v in [0, pi/2], and the far pcurve of its boundary gives v = -6.7e-13, so the range is a
rounding over a quarter, the count rounds up to 2 and the bend gets a line at 45 degrees
whatever the tolerance (display_mesh_tests::a_small_bend_on_a_large_sheet_is_meshed_round:
3 angles across the bend at the chord tolerance instead of 2).
The division now starts from the whole range, and the limits refuse an interval that spans
more than a quarter turn of its iso-lines, read from the points as an edge segment's is
(edges::QUARTER_TURN: the half chords of an arc turning theta differ by theta/2, a closed
iso-line's by pi). On a revolved surface the parameter is the angle, so the lines are the
same as before; an iso-line within a millionth of the tolerance of one point (a pole) has no
turn to read.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The comb tool passed only the pick, so a comb's length and tooth count
could not be changed. While the tool runs, a card at the top left of the
view has Comb length (0.25x to 8x the automatic length, default 1x) and
Teeth (4 to 200, default 40), with plain-word tooltips; moving either
runs the comb again on the curves and edges already shown. New strings
in assets/locales/pending/curvature-comb-options.json.
Test: comb_options_draw_the_combs_shown_again drags both sliders: the
shown comb's teeth grow to 8 times their length, then number 4; the
drags pick nothing, and the card goes with the tool.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
`inspect.curvature_comb` read the display mesh for model geometry: an
edge's comb fitted a circle through every three points of the nearest
mesh polyline, a face's did the same on its iso lines' chord points. The
comb was jagged, changed with the mesh tolerance and ignored `density`.
- geom: `CurveEval::jet`, a curve's point, unit tangent and curvature
vector kN from its first two derivatives (lines and conics in closed
form, B-splines and NURBS from the basis functions' derivatives, a
traced intersection from both surfaces' normal curvatures along its
tangent, by Meusnier: kN lies in the plane of the two normals and its
component along each is that surface's normal curvature).
- kernel (curvature_comb.rs): the edge nearest a pick by the exact
distance to its curve (a periodic face's seam and poles left out),
`density` teeth at even steps of the edge's parameter; along an iso
line, the surface's normal curvature n.S_tt / |S_t|^2 along its normal.
`IsoLine` carries the running surface parameter's span.
- engine: edges and faces use them (and `inspect.minimum_radius` on
edges); new optional `length` multiplies the automatic scale. The reply
keeps its shape.
Tests: a circle edge reads 1/R to 1e-9 at Coarse and Ultra display
quality alike, with `density` teeth; an extruded ellipse's edge matches
ab/(b^2 cos^2 t + a^2 sin^2 t)^(3/2) at every tooth, a/b^2 and b/a^2 at
the vertices; a cylinder face's rings read 1/R and its lines 0; `scale`
and `length` set the teeth's length; curve jets on every record kind.
The existing cylinder-edge check tightens from 0.5 mm to 1e-9.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
corpus_designs_rebuild_with_the_same_names_and_references compared every
corpus design with a text record of each body's face and edge counts and its
full name list, last written from truck's output (a55196e7a); 110 designs
differed only because SMLib keeps whole faces truck split in pieces. Those
counts and names are the kernel's, not an outcome.
The test, renamed corpus_designs_keep_their_references_and_name_alike_every_build,
now asserts invariants only, with no record:
- every design loads; one that does not is a failure naming the design and
the step (oracle/83-boundary-loop-thicken: surface.thicken, SMLib status
1001), not a record line;
- every name a design stores (fillet and chamfer edges, faces a feature
picks, a sketch's face, sheet metal edges) finds a face or edge: none
`gone`, no sketch face `lost`;
- two builds give the same name -> face map: each named face's area and
centre and each named edge's length and middle (to 1e-6 of their size), and
the same face or edge found for every stored name.
The design already exempt for unstable piece order
(regressions/closed_sweep_torus_cut) is still only printed for the second.
On develop it fails on two designs: oracle/83 above, and
regressions/cut_up_to_face_leaves_skin, whose Extrude13 face
`F47:top#[...]` finds nothing (the truck-era record had it `gone` too). All
159 designs name alike in both builds. The records in tests/naming/ are no
longer read; CONTRIBUTING no longer asks to re-record them.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ordinary_curved_bodies_keep_a_practical_sampling_step asserted
ContactGeometry.step > 1.0, an internal sampling step derived from the
bodies' display meshes. What a user gets is the drive: it either stops at the
contact or is refused for running out of the sampling budget. The test,
renamed ordinary_curved_bodies_stop_at_their_contact_within_the_sampling_budget,
keeps that: the slide drives to -30 without a budget error and stops in
(-5.02, -4.9) (the sphere r 5 about x = 20 and the box from x = 15 meet the
block's x = 10 side after 5).
It still fails on develop with "motion exceeds contact sweep collision
budget": the planar faces meshed as grids, which the planar-tessellation fix
(#9307) addresses.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
open_in_easyprint_hands_the_host_a_3mf_or_an_stl_that_reads_back asserted the
STL was 84 + 50 * 12 bytes: twelve triangles, the tessellator's count for the
fixture's box (the fixture is a mesh import of box_solid's display mesh, 124
triangles today).
The STL is now parsed (solidcraft_io::read_stl): it has the imported mesh's
own triangle count, every side is shared by two triangles running opposite
ways (closed and consistently wound), it encloses the 10 x 20 x 30 box's
6000 mm^3 (divergence theorem, to 1e-6; the corners are exact in f32) and its
bounds are (0, 0, 0)..(10, 20, 30).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
free_form_profiles_extrude_exactly asked for an ellipse extrusion of exactly
3 faces and a spline-and-line extrusion of at most 5: how many pieces the
kernel cuts a closed side into. It now checks that the sides are exact.
Ellipse a = 10, b = 4, extruded 5: area = 2 pi a b + 5 P, P = 4a E(e),
e^2 = 1 - b^2/a^2. By the Gauss-Kummer series, P = pi (a + b) sum_k
(binom(1/2, k))^2 h^k, h = ((a - b)/(a + b))^2 = 9/49: P = 46.026225191330
(a 200000-point midpoint integral of sqrt(a^2 sin^2 + b^2 cos^2) agrees to
1e-13). A = 80 pi + 230.131126 = 481.458538 mm^2, asserted to 1e-4; a faceted
side would be short of it. Only the top and bottom are planes
(face_types.plane = 2, merged pieces counted once).
The fit spline closed by a line: the planes are its top, bottom and the line's
side (face_types.plane = 3); its volume stays checked against the profile
area.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
a_mirrored_or_patterned_sheet_body_is_sheet_metal_with_its_flat_pattern
(1171c4c2a) expected the mirrored copy's model turned over: the same outline,
its bend down and its pocket on top. That describes a SheetBody::moved that
never landed. The code on develop is SheetBody::copied (d9d6af51c, #3354): a
mirror moves the frame and mirrors the flat x -> -x with the same thickness
side, the opposite hand's blank with each bend turning the same way, which
a_mirrored_sheet_copy_is_the_opposite_hand_with_the_mirror_image_flat_pattern
asserts on an asymmetric bracket. The YZ mirror keeps z, so a pocket cut from
below stays below and the flange on y = 0 still turns up: the flat pattern
reads blank x 0..100 -> -100..0, pocket x 20..30 -> -30..-20, side bottom,
bend up.
The test now asserts that: the same flat size, the outline and the pocket
outline equal to the source's with x negated (to 1e-6), pocket side bottom and
bend up on both. The volume doubling, the bend table and the flange rebuilt
on the copy (point containment) stay.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
a_trays_faces_have_readable_sheet_names_that_follow_its_size asked for
exactly two unnamed faces (the hole's wall in two halves) and for the back
rim's named point at y = 199.5, the strip's centre line. The first is how many
faces the kernel makes a cylinder of; the second is where the face's roomiest
display triangle lies (naming::face_spot), any point on the face.
Now: there is an unnamed face and every one is the hole's wall (r 3.3), and
the back flange's far rim point lies on that rim: z = 30 and 199 <= y <= 200
(the flange 1 thick, its outside at y = 200), 0 <= x <= 400, to the 1e-3 the
test had. The right flange's top (the plane x = w - 1) keeps x = 319 and 399.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fillet_the_knife_edge_at_the_tip (features_more_tests.rs) and
blend_a_knife_edge_where_a_curved_wall_runs_out (tests/robustness.rs) build
the same #851 part with the same script, round the same knife edge at
(62 1/6, 0, 5) with R2 and measure the removed volume through the same display
plan. The first integrated the removed area on a grid (5e-4); the second has
it in closed form. Drop the first and keep its tolerance on the second.
The ball 2 from the back face y = 0 and from the r 21 wall about (62 1/6, -21)
is centred at (62 1/6 - sqrt(168), -2). The removed section is the trapezoid
wall centre, tip, (kx, 0), ball centre (sqrt(168) wide, 21 and 2 high) less the
wall's sector theta = acos(19/23) and the ball's sector pi - theta:
10 (11.5 sqrt(168) - 220.5 theta - 2 (pi - theta)) = 119.648812 mm^3
the constant the kept test has; the dropped test's grid gives 119.6487 at a
0.004 x 0.001 step. The kept test's fillet bound goes from 0.5 to 5e-4 of
that (0.0598), the dropped test's. Its chamfer row (159.236451, the chord
triangle less the wall's segment) already says the chamfer takes more.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
cut_whose_end_touches_an_arc_side_leaves_no_sliver compared the touching cut's
face count with a clear cut's, a count of how the kernel splits its faces. It
now compares what the two parts are.
The plate's arc runs from (0, 20) through (-10, 10) to (0, 0): centre (0, 10),
r 10, so it reaches x = -10 only at y = 10. The r 5 cut along x about
(y, z) = (12.5, 12.5) spans x -10..7.5 (touching) or -10.1..7.4 (clear). Both
open the same patch of the arc; the slice x 7.4..7.5 lies wholly inside the
plate (y 7.5..17.5, z 7.5..17.5 in 0..20 x 0..27.5). So
V(clear) - V(touching) = pi 5^2 0.1 = 7.853982 mm^3
A(touching) - A(clear) = 2 pi 5 0.1 = 3.141593 mm^2 (the hole wall; the
floor disc is the same)
both to 1e-4 (the measure integrates the exact faces to 1e-8). A sliver of the
arc left where the end touches adds about a square millimetre of faces.
Seed 14's half (the fuzz generator's seed, then a shell) is pinned as its own
test, shell_after_a_cut_whose_end_touches_an_arc_side, with the commands the
generator gives today: the touching cut, then a 2 mm shell opening the top
face y = 20. It fails at the shell (SMLib status 1001), a kernel gap.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The owner's final ruling of 2026-10-30 reverses the swept corner 6539c070a
and 8dc344d22 used: rim rounds meeting at a concave corner beside an
unpicked sharp edge are mitred by default (a user who wants it swept rounds
the corner edge too; a swept corner with a sharp inner edge is a future
option). SMLib's swept result is the defect, so both tests now expect the
mitre and fail today on it.
rounds_that_fit_are_closed. At depth u the section is the outline moved in
by d = r - sqrt(r^2 - (r - u)^2) with every corner mitred: the area less
L d, plus d^2 at each of the six convex corners (the two strips overlap in
a d x d square) and less d^2 at each of the six concave ones (the mitre
also takes the d x d square beyond both strips), the overlap of the two
spandrel prisms being r^3 (5/3 - pi/2) per corner over the round. Six and
six cancel, so both ends remove 2 L r^2 (1 - pi/4) with L = 107.6:
11.545566 (the swept corners gave 11.514718).
fillet_tabbed_plate_outer_loop_and_partial_selection_after_hole. Where both
sides of a concave corner (+-4, sqrt(609)) move, the moved R25 arc and the
moved side x = 4 - d now meet where they cross,
y = sqrt((25 - d)^2 - (4 - d)^2), as where only one side moves; the swept
arc branch goes. Check: A(0,0) - A(d,d) agrees with the Steiner form for a
mitred outline, L d - d^2 (pi + theta - 2 tan(theta/2)), to second order
(17.190976 against 17.190968 at d = 0.1; the arc's curvature moves the
mitre point at third order, which the Green's-theorem area has exactly).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
a_strip_off_a_curved_face_is_ruled_to_its_far_curve lifted the free
strip's handles 1 mm and wanted the strip's bounding box to rise, which it
need not (the far curve's corners are fixed and the box's top may be
elsewhere). It now checks what the handles do: the plan's far curve takes
the lifted handles as its interior control points and keeps its corners,
so it rises by 1 - R0 - Rn inside; the built strip has that curve for an
edge (33 points of it within 1e-3 of the strip's edge polylines at 1e-4),
and its middle, risen more than 0.1, is more than half that from every
edge of the default strip.
It fails today on its premise: the strip's edge (the cup's straight rim at
x = 14) is a line, so its far curve, on the edge's degree and knots, has
no interior control points, and ruled_far_handles gives an empty list
(the old witness passed nothing to move). A real gap: the far curve of a
strip whose rulings turn along a straight edge is the chord between its
corners.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
rounded_slot_exports_cylinders required no B_SPLINE_SURFACE, four
CYLINDRICAL and two TOROIDAL surfaces; ramp_cut_slot_exports_sheets
_bounded_by_their_faces five CYLINDRICAL and two B_SPLINE (SMLib keeps one
more round an exact cylinder). Which kind a face is written as is the
writer's choice; what #612 and #1198 were about is that no surface reaches
past the part. Both keep that (every CARTESIAN_POINT's x within [0, 60],
control points and placements included) and their round-trip volume: the
first against Pappus, the plate (800 + 100 pi) 4 less (1 - pi/4) along
the straight edges and the arcs at 10 - r (10 - 3 pi) / (3 (4 - pi)), at
1e-3; the second against the exported body's at 1e-4. Both pass today.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Three history tests pinned truck's sewing in tallies:
- shell_of_a_painted_body wanted changes [0, 2, 8, 0, 5], the side faces
split across the rim's level; SMLib's shell leaves them whole. It now
checks what paint follows: the painted face 0 comes through as exactly
one face (its geometry checked against face 0 by verified()), and each of
the five inner walls is one Generated Offset of the face it lines, the
open top none, as shell_lines_the_walls_with_offsets has it.
- fillet_after_box_cuts wanted the painted cuts to leave faces in pieces
and the fillet's edges to meet merged faces; it keeps the outcome for
every cut on both blocks: the round stands in place of the picked edge,
and composed with the cut the history holds over the block and the tool.
merged_meetings has no use left and goes.
- surfaces_keep_their_faces wanted every stitched face Kept; whether
sewing changes a face's class is not the contract. It now checks each
stitched face has one origin, the face it was sewn from (geometry checked
by checked()), the five walls the open box's faces 0-4 and the lid the
patch, and the four seams naming two edges each.
split_a_face is left as it is (the owner's ruling: a face whose boundary
only gained a vertex is Kept), failing until SolidCraft's split history
says so ([3, 2, 2, 0, 0] against [5, 0, 2, 0, 0]). The three tests above
pass today.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
rounded_shell_planar_roles_are_exact_distinct_and_transformable required
the four outer r6 rounds to be coalesced extrude sides (face_was_coalesced:
SMLib's round is not one any more), no floor-height seam between corner
faces, 19 faces in the cup and in its STEP copy, and the volume of a 1e-4
mesh within 0.2. It keeps what the roles are for: the right wall's role
resolves to the face at x = w/2 and the floor's to the face at z = t, both
still after the transform; each straight outer wall is one full-height
face, in the cup and in its STEP copy; and the cup's volume is exact.
Proof. The box w x 60 x 30 with its four vertical edges rounded r6 is
(60 w - (4 - pi) 36) 30; shelled t inward, open at the top, its inside is
the box moved in by t with its corner rounds at 6 - t:
((w - 2t)(60 - 2t) - (4 - pi)(6 - t)^2)(30 - t). Graded on SMLib's
volume (integrated on the surfaces, to 1e-8) at 1e-6. It passes today.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
a_small_bend_on_a_large_sheet_is_meshed_round also pinned the chord-only
mesh (exactly two stations across each bend, its sag over 0.29 r) and
required every flat side face to keep the chord-only mesh's triangle count:
facts about another mesh, not what the display shows (the chord-only mesh
now puts three stations across the r1 bend). It keeps what the display
mesh must do: each bend a quarter turn in more than five facets, each
turning at most DISPLAY_ANGLE, sagging at most r (1 - cos(angle / 2)) and
less than the chord tolerance. It passes today.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
a_five_sided_window_fills_g1_and_through_a_point required five faces and at
least 15 edges (five patches about a centre); a_hexagonal_rim_fills_through
_a_point... required (6, 18). How many patches a fill is made of is the
fill's own business: both keep their outcome checks (check_face: the rim's
own edges, within the face tolerance, a clean mesh; G1 to the wall within
0.1 degree; the point on the surface; the sealed cup holding more than the
plain fill's).
Both still fail on outcomes: the pentagon's fill through a point has a
folded triangle in its mesh, and SMLib's stitch refuses the hexagon's fill
through a point (its control net doubles back on itself, a cusp in a
curve).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
a_crowned_patch_fills_its_middle_and_keeps_its_edges checked only that NaN,
infinity, 3.01, -0.91 and 1e300 are refused; it now checks why: "a patch's
crown must be between -0.9 and 3" (patch_edges_crowned's range test).
The bump check is left as it is. The audit proposed measuring it in model
space along the loop plane's normal, but it already is: both patches are
height fields over the same plane on the same parameters, so the distance
between their points at the domain's centre is the bump along the normal,
and the record's domain is the fit's box in mm (diagonal 52.5). The crowned
patch's middle rises 7.656 where the documented crown x size is 13.125:
the crown's bump reaches 7/12 of what patch_edges_crowned promises on this
pentagonal cup (geom's own test of fill_loop, on a fine hexagon net, gets
it to 1e-9), a real gap, still failing.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
collapsed_taper_mesh_stays_accurate_as_tolerance_decreases compared each
display mesh's volume with the taper law's integral,
6000 - (1 - pi/4) 40 integral r^2, at 1e-4: the built fillet removes about
10 mm3 more than that (5212.9 against 5223.1) at every tolerance, so it
measured the fillet, not the mesher. It now holds each mesh to the B-rep it
meshes: a mesh within its chord tolerance of the faces has its volume
within area x tolerance of the exact one (SMLib's, integrated on the
surfaces to 1e-8), the bound fillet_mixed_arc_and_line_removed_volume
_converges uses. It passes today.
taper_follows_the_room_along_the_edge keeps its law and closed-form
volumes (the 10 mm3 against the law is the failure it still shows) and
drops the two internal checks at its end (no unmeshed face, a face with
three vertices) for the outcome: the wedge's tapered fillet is valid.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
the_arc_rounded_after_the_back_edge_matches_both_together ran
one_then_the_other(BACK, arc_top()) as a test of its own. It is the same
check as every pair of a_round_ending_in_an_earlier_round_matches_both
_together (the round in sequence against both together, within the
display meshes' 5e-3), which had only the other order (arc_top(), BACK):
the pair joins that list and the separate test goes. Nothing is loosened.
Today the list fails before it reaches the pair: SMLib fails the arc's
round after the long front edge's (status 1001); the back-then-arc pair
failed the same way on its own.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
rounds_that_fit_are_closed counted faces (the input's plus one per picked
edge: 38, where SMLib makes 50 with its corner faces). It now keeps
validity and no crossed loops and holds the R0.5 rounds on all 24 end-face
edges to the exact volume.
Proof. The part (plate 14 x 21.5 x 10, block 14 x 9.948 x 10 on it, the
5.2 x 7.1 window through both along x) is
14 (215 + 10 (b - a) - 36.92). At depth u into an end face's rounds the
section is that face's outline moved in by d = r - sqrt(r^2 - (r - u)^2),
each edge parallel to itself: the area less L d, L = 2 (21.5 + 20) +
2 (5.2 + 7.1) = 107.6 (the stepped outline's perimeter is its box's), plus
d^2 at each of the six convex corners (two rounds mitred), less pi d^2 / 4
at each of the six concave ones (the two shoulders and the window's four
corners: rounds meeting at a concave corner beside an unpicked sharp edge
are swept round it, the owner's ruling of 2026-10-30). The wall between
window and block side is 1.256 > 2 r, so the offsets stay apart. Over the
round the integrals of d and d^2 are r^2 (1 - pi/4) and r^3 (5/3 - pi/2),
so both ends remove
2 (L r^2 (1 - pi/4) - (6 - 6 pi/4) r^3 (5/3 - pi/2)) = 11.514718.
Graded at 1e-7 of the part's volume. It passes today (aarch64, SMLib).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
issue2422_vertical_after_separate_bottom_rounds compared the face count and
volume (within 0.05) of the vertical round, picked with and without its
bottom mitre, against the same round picked alone, and required every face
meshed. It now holds each of the three picks, on the 40 x 80 x 27 box and
on the same shelled 1 mm open at the top, to the exact volume; the corner
probes stay.
Proof. Horizontal sections, s up from the bottom. Below s = r the four
separate R2 bottom rounds (mitred at the corners) leave the rectangle
moved in by d = r - rho, rho = sqrt(r^2 - (r - s)^2), and where the
vertical round meets them (a sphere octant) its corner is a quarter disc of
radius rho: (L - 2d)(W - 2d) - (1 - pi/4) rho^2. Above, LW - (1 - pi/4) r^2.
With the integrals over the bottom r of rho (pi r^2 / 4), rho^2 (2 r^3 / 3),
d (r^2 (1 - pi/4)) and d^2 (r^3 (5/3 - pi/2)):
V = LW r - 2 (L + W) r^2 (1 - pi/4) + 4 r^3 (5/3 - pi/2)
- (1 - pi/4) 2 r^3 / 3 + (H - r)(LW - (1 - pi/4) r^2) = 86174.445361;
with four such corners it is issue1557_all_vertical_corners_match_analytic
_volume's formula exactly. The shell's cavity, 38 x 78 x 26, is clear of
both rounds (along the corner's diagonal the R2 arc stays 2 - sqrt(2) in,
the cavity's corner is 1 in), so the cup is V - 77064. Graded at 1e-6.
Today SMLib's check refuses the bottom rounds' result (edge and vertex
tolerance 0.97 against 0.01), as before.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fillet_tabbed_plate_outer_loop_and_partial_selection_after_hole only
checked that every subset of the R25 tabbed plate's seven top-outline edges
builds and stays inside the plate. It now first holds the hole's rim round
and the three selections that end only at the plate's sharp concave
corners (the R25 arc's two halves, the tab's tangent run of sides, R2
corners and top, and both) to their exact removed volume; the sweep over
all 127 subsets stays as it was.
Proof. The outline's area A(da, dt), the arc moved in by da and the tab's
run by dt, each element parallel to itself, by Green's theorem: an arc
about c of radius rho from a to b gives
1/2 (rho^2 (b - a) + rho (cx (sin b - sin a) - cy (cos b - cos a))), a
segment p -> q gives 1/2 p x q. At a concave corner (+-4, sqrt(609)) where
only one side moves, the elements meet where they cross (the round runs
into the other wall: the section is the union of the two sides' half
regions); where both move the corner is swept, an arc of radius d about the
corner, traversed clockwise from the arc's normal to the side's (the
owner's ruling of 2026-10-30 for rounds meeting at a concave corner beside
an unpicked sharp edge: the profile swept round the corner edge). Checks:
A(0, 0) = 312.5 (pi + 2 theta) + 4 y + 8 (cy - y) + 8 + 2 pi (disc sector,
triangle, tab, R2 corners), and A(0, 0) - A(d, d) = L d - pi d^2 by the
Steiner formula for the swept offset (total smooth turning 2 pi + 2 theta,
the two swept corners -theta each), agreeing to 1e-15 at d = 0.1, 0.3,
0.5; A(0, 0) - A(0, d) agrees with a 0.004 mm grid to 2e-6. The round's
section at height r sin(phi) into it is the outline moved in by
d = r (1 - cos phi), so it removes the integral of
(A(0, 0) - A(d)) r cos(phi) dphi over [0, pi/2] (midpoint rule, 8192
steps, converged to 1e-7 against 4096). The hole's rim round is Pappus:
(1 - pi/4) r^2 about the axis at 1.5 + r (10 - 3 pi) / (3 (4 - pi)).
Graded at 1e-5 of the removal, the bound the D prism's rounds are held to
(the blend surfaces are SMLib's fits).
Today the three selections build with these volumes (aarch64, SMLib); the
sweep still fails where a subset ends a round at a tangent joint (the x = 4
side without its R2 corner): SMLib cannot end a blend inside a tangent
chain, "the blend cannot end there".
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The owner's blend-overflow ruling of 2026-10-30: a chamfer whose leg runs
off the face beside its edge over another face is refused as too large,
naming the largest size that fits (a 2 mm chamfer on the basin's 1 mm rim
would lower the slab's front face from 30 to 29.382); a full-width chamfer
stays refused. Two tests wanted those chamfers built and cut from the slab:
- chamfer_wider_than_sloped_basin_rim_is_cut_and_a_full_width_one_refused
becomes chamfer_wider_than_sloped_basin_rim_is_refused_naming_the_largest:
(margin, d) = (1, 2), (1, 3), (0.5, 4) and the full widths (0.5, 0.5),
(1, 1) are TooLarge, the body unchanged, and the message names a largest
size just below the rim's width: the full width is refused, so the fit
search (three significant digits of the size asked, step
10^(floor(log10 d) - 3)) ends one step below it, in
[margin - step, margin). The removal formula for the cut chamfer
(basin_rim_chamfer_removed) has no use left and goes.
- equal_slope_rim_loops_stay_inside_the_material: the 2 mm chamfer of the
1 mm rim's loop is refused the same way (largest in [0.999, 1)); the R4
round (tangent side, builds) and the 0.5 blends stay.
The half-width chamfer on each rim, which only had to take something off,
now takes its exact volume. As in chamfer_sloped_basin_rim: the triangle
with legs d on the top and d down the wall towards (20, 10) (run
20 - margin over the 20 drop) has area d * drop / 2 with
drop = 20 d / sqrt((20 - margin)^2 + 400), and the chamfer's length at
depth h is 60 - h between the end walls x = 20 + (30 - z) / 2 (planar:
x depends on z only), so it removes d * drop / 2 * (60 - drop / 3);
graded at 1e-8 as that test is.
Today SMLib refuses the chamfers as too large, but the message does not
name the largest that fits yet ("the chamfer is larger than the faces
beside its edges allow"), the SolidCraft change issue_1080's R30 test
waits for too.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The owner's blend-overflow ruling of 2026-10-30: a round that runs past
its face on its tangent side is built on the face continued and cut from
the part, keeping its radius. loop_fillet_as_tall_as_its_wall_consumes_it
still wanted R2.001 and R2.5 on the R13 x 2 disc refused as taller than the
wall; they now must build, valid, with the exact volume.
Proof. The round's section in (rho, z) is the r square at the top edge
outside the circle about (13 - r, 2 - r), clipped to z >= 0. With
t = z - (2 - r) = r sin(theta), the round's inner radius is
rho(theta) = 13 - r + r cos(theta), theta from asin((r - 2) / r) to pi/2,
and the disc keeps pi (169 * 2 - integral (169 - rho^2) dz), dz =
r cos(theta) dtheta (midpoint rule, 20000 steps). At r = 2 it is Pappus,
2 pi 169 - (1 - pi/4) 4 * 2 pi (13 - c), c = 2 (10 - 3 pi) / (3 (4 - pi))
(checked to 1e-9 in the test); at r = 2.5 it is 957.692239 mm3, the
ruling's number, the same integral as
rounds_past_the_bottom_of_a_wall_are_cut_from_the_part's. Graded at 1e-6
as that test is.
Today SMLib fails the R2.001 round (status 1001): a convex round past its
face is not yet built by subtraction, the cause fillets/KNOWN_FAILING gives
4782 and 5158.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
a_round_into_a_hole_is_cut_by_it (issue_324_tests.rs) built rig case
fillets/324-fillet-over-hole-overlap's body, but cut its hole with a cylinder
longer than the block (z -1 to 11) where the rig extrudes a sketch circle
flush. The new case fillets/324-fillet-over-hole-cut-by-overlong-cylinder
builds it that way (solid.cylinder, base z -1, height 12, cut) and holds it to
the same hand-derived answer: block 40x20x10 less the r3 hole at (20, 14.5)
(282.74) less the R4 round on the top edge at y = 20, 40 (16 - 4 pi) = 137.35,
plus what both remove, the integral over y in [16, 17.5] of
(4 - sqrt(16 - (y - 16)^2)) * 2 sqrt(9 - (y - 14.5)^2) = 0.375830 (re-derived
with the substitution y = 17.5 - s^2, 200000 steps):
V = 8000 - 90 pi - 40 (16 - 4 pi) + 0.375830 = 7580.287315, and G1 on the
blend. It passes today (aarch64, SMLib), as the flush case does, so it needs no
KNOWN_FAILING line; the unit test, a duplicate of the two cases, is dropped.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fillet_mixed_arc_and_line_joint_preserves_both_section_radii put R0.5 on the
D prism's top outline and checked 258 points of each mitre edge against the
cylinder and torus to 1e-7 in r squared, through the record's edges. The rig's
fillets/485-fillet-d-prism-top-outline-arc-and-flat builds the same prism with
the same radius and grades the removed volume to 5e-5 (a 0.12 mm3 loss shows)
and G1 on every blend seam, which is what the mitre's accuracy is for.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A box edge chamfered 2 and by two distances (3 and 1, and flipped, told apart by the
centre of mass); a pocket's rim chamfered 1, by two distances, 4.9 (fits), and 5 and
5.5 (refused by the owner's rule on full-width chamfers: built at 5 today).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A box edge rounded, then the edge meeting it at the corner, in both orders (both the
three-edge rolling-ball corner); r3 then r2 (the r2 round's torus about the r3 round's
axis, by Pappus); an L-bracket's front inner outline after its bend round; a block's
top edge after the arc round at the cylinder (fails today: G0 at the round's end on the
crease); a curvature round after a curvature round with Tangent chain off.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Inside bend r3, outside r5, both concentric (r3 and r8), the inside r35 using up both
inside faces, r36 refused naming 35, and the inside bend Type: Curvature.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Top and both rims rounded r1 and chamfered 1; the top rim rounded r10 (as deep as the
plate), r12 (past it on its tangent side: built by subtraction, fails today with
status 1001) and Type: Curvature; chamfered 9.9 (fits) and 10 (the full depth:
refused by the owner's rule, built today). Volumes by Pappus.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A rectangular pocket's floor edges, rim edges and both rounded r2, the rim r5 as deep
as the pocket; a boss's root r2 and r10 (as tall as the boss) and its top rim r2.
The rim cases fail today: SMLib puts a corner patch where two rim rounds meet at a
concave pocket corner, where the rounds running into each other make a mitre (four
faces more; the volumes agree to 5e-4).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A block whose sides meet the cylinder at creases: the concave arc at the wall above
the block's top r2, the cylinder's top rim r2, the block's long top edge r2 with
Tangent chain off and Type: Curvature. A block as wide as the cylinder, its sides
running tangent into the wall: the arc and the long top edge each rounded alone
(built or refused as continuing tangentially). Volumes by Pappus or one-dimensional
quadratures of the exact sections, the round ended by the planes it runs into.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Three edges at one box corner rounded r1 and r3 with the rolling-ball corner, r3 with
Corners: Curvature at its default setback and at 3.5, and refused at 3 (the radius);
the corner chamfered 2; all twelve edges rounded r2; one edge rounded Type: Curvature.
Volumes in closed form (strips plus sphere octants, half-space intersection, the
rounded box as a Minkowski sum, the quintic section's area 113/756 s^2); G1 at every
round's seam, G2 for the curvature round and the corner patches.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Stale since 84bd2daad (the Fillet feature rounds each pick's tangent chain). After a and b are
rounded at 2 mm and meet in a mitre, the mitre's seam leaves c's end along c, so c's chain is c
and the seam; rounded at 2 mm, as the issue1557 tests pick, the corner is a sphere octant.
Proof: the 20 mm cube less its three rounds, each (1 − π/4) r² over its 18 mm straight part, and
the corner's 2 mm cube less the octant, r³ (1 − π/6): 8000 − 3·(1 − π/4)·4·18 − 8·(1 − π/6) =
7949.834793498635. Measured 7949.834793513291 (1.8e-12 relative), 10 faces, valid; the check is
tightened from 0.05 mm³ to 1e-11 relative.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Stale since 84bd2daad, which gave solid.fillet each pick's tangent chain by default. After the
long top front edge is rounded, the front-left upright meets the round's end (the quarter circle
on the left face) along its tangent, and that circle meets the top-left edge along its tangent:
the second fillet rounds the upright and the top-left edge. The "together" fillet picks the
three edges ([20, -21, 10], [0, -21, 5], [0, -10, 10]); one by one and together remove the same
volume within the display meshes' 2e-4 (it read 60.649 vs 43.185 with two picks).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
tangency-labs/smlib#64 builds a tapered wall that closes partway up (its neighbours meet above
its apex), so the 0.2 mm slot of a 10 mm square tapered 10° out over 2 mm now builds where it
was refused. The test, renamed for what it checks, asserts the slot's solid is valid with its
exact volume and keeps the ring's refusal (its 0.3 mm hole closes entirely).
Proof of the volume, t = tan 10°: every wall moves out of the material by z·t at height z. The
square grows to 10 + 2zt, so without the slot ∫₀² (10 + 2zt)² dz = ((10 + 4t)³ − 1000)/(6t).
The slot narrows to 0.2 − 2zt and keeps its length 8 (its end wall and the square's side both
move up by zt); it closes at z = 0.1/t = 0.567 and takes ∫ 8 (0.2 − 2zt) dz over 0..0.1/t =
0.08/t. Volume ((10 + 4t)³ − 1000)/(6t) − 0.08/t = 213.984095421783; measured to 1e-6.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
tangency-labs/smlib#63 raised SMLIB_CURVE_MAX_CURVES from 4096 to 16384; CURVE_MAX_CURVES
follows it, so a profile of 5000 segments (a modelled thread, a fine polygon) extrudes:
kernel tests::measure_of_a_body_with_many_faces passes (5002 faces, 15000 edges, 10000
vertices).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- #63: a knife edge (two faces tangent along it, folding back) rounds to the ball touching both
faces back from it; a curve list takes up to 16384 curves (SMLIB_CURVE_MAX_CURVES); a stitched
solid is a nested solid, its cavities void; booleans pair each face only with the faces whose
box comes near its own, the closure test of a new face searches from both its sides, and a new
edge from a faceuse shell to a wire keeps the faceuse shell: a row of Menger sponges joins in
near linear work.
- #64: a tapered wall that closes partway up ends at its apex, its neighbours meeting above (it
was refused as SMLIB_ERR_WALL_CLOSES); a round of revolution offset in past its radius has no
offset; a round along an arc turns from its start section, not from the arc's frame.
- #65: capi tests, the Menger row join counts its work (smlib_work_counters) instead of timing it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
tapered_extrude_swallows_a_short_tip expected the prismatoid whose two tip
corners run straight to the top's tip (h/6 (A0 + 4 A_mid + A1)), the solid
the old offset-and-rule construction built: its tip triangle leans about 40
degrees, not the 5 degree taper. With every wall drafted 5 degrees the tip's
wall is a triangle that closes where the long sides meet across it, at
z* = 0.126237833 (offset 0.011044379), and above that the long sides meet
along a ridge. The section at height z is the profile's lines moved in by
z tan(a): a quadrilateral below z*, a triangle above, each area quadratic in
z, so Simpson's rule on each piece is exact: V = 72.883284979193. The old
value, 72.882657253174, is 8.6e-6 off, past the test's 1e-6. SMLib's
DRAFT_CORNER_ROUND path builds exactly this solid (72.883284979193, 6 faces);
the default curvature rule still refuses it (SMLIB_ERR_WALL_CLOSES at
(20, -0.01, 0)), so the test fails until the fork builds a wall that closes
partway up.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
shell_thicker_than_a_rim_is_refused expected the "rim or ledge" refusal from 9508ee749,
added because truck's face offset turned the top face inside out and returned a body of
about twice the volume. SMLib builds the exact sharp-edged offset, and its volumes are the
closed form, so the test now checks those (renamed
shell_of_a_basin_past_its_rim_keeps_the_rim_solid).
Proof. Slab [0,100]×[0,60]×[0,30]; pocket lofted from x 20..80, y 4..50 at z 30 to
x 30..70, y 20..40 at z 10, its sides the planes x + z/2 = 35, x − z/2 = 65,
y + 0.8z = 28, y − z/2 = 35 (normal lengths √5/2, √5/2, √1.64, √5/2). Shelled open at
z = 0 by t, the cavity is the slab shrunk by t (x t..100−t, y t..60−t, z 0..30−t) less the
pocket grown by t (each plane moved out by t·|n|, floor z = 10 − t). For t ≤ 6 the grown
pocket stays inside the shrunk slab in x and at the back (50 + 0.618t ≤ 60 − t); its front
reaches y = t at z0 = (28 − (1 + √1.64)t)/0.8, below 30 − t from t ≈ 2.70 (the rim stays
solid above z0). With W = 30 + z + √5 t,
grown(t) = ∫[10−t, z0] W (7 + 1.3z + (√5/2 + √1.64)t) dz + ∫[z0, 30−t] W (35 + z/2 + (√5/2 − 1)t) dz,
V(t) = 180000 − grown(0) − (100 − 2t)(60 − 2t)(30 − t) + grown(t),
grown(0) = 33866.667, so V(1) = 17105.6240415, V(4) = 63560.2492284,
V(6) = 90113.9202101. SMLib measures 17105.6242, 63560.2492, 90113.9203 (≤ 1e-8
relative). The test computes the closed form and checks each shell to 1e-6, with the
centroid inside its box and on x = 50 as before.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The test offset the sphere's top patch to get a fitted B-spline sheet. That held on truck,
whose sphere came in several patches and whose sphere offset was fitted. On SMLib the
sphere is one face: offsetting it closes up, so it is a solid by design (surface_offset.rs,
"Faces that close up make a solid", and its test a_sphere_is_fitted_and_refused_past_its_centre
asserts exactly that), and SMLib's offset is exact, a sphere of radius 22 with no control
points, which surface.fair refuses. Body::is_surface was right: the record lists the offset's
closed shell as the outer shell of a material region (Parts::canonical), so it is a solid
whether read from edge uses or from regions.
The test now fairs the patch on the non-planar rim of a box cut by a sideways cylinder (the
cover in patch_trim_thicken_and_stitch), a one-face B-spline sheet: energy 0.7185 → 0.6938 in one
step, edges unmoved bit for bit, undo/redo/reopen and the refusals as before.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
hostile_params_never_panic built a box, a sketch and a rectangle afresh for each of the ~3000
calls it makes per command. SMLib serialises every call behind one process-wide lock, so those
boxes were built one after another whatever the number of threads: 20 threads made 4000 boxes
in 7.8 s, one thread 200 in 0.31 s (1.5 ms each). The fixture was nearly all of the test's time
(8814 of 8823 thread-seconds over the first 72 commands on the aarch64 box; the commands
themselves 9 s, none over 0.5 s), and the test took 2195 s in develop CI.
It now builds that model once per command and gives each call a copy of the session with its
design, model, undo, redo, open sketch and log, sharing the bodies as undo does. Every command
still gets every parameter name with every hostile value, from the same starting state. A new
check runs Cancel Sketch, two undos and a redo on a copy and on a session built afresh and
finds the same designs, with the copied session untouched.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
encode_native_body turned the whole saved record into a serde_json
Value (a map with an owned key for every field of every face, edge,
curve and pcurve), checked it, counted it, then wrote it out. Building
that tree was most of the cost: on the Menger level 4 sponge (3 tools,
--save) the 101 bodies the model cache encodes, 535 MB of encodings,
took 24.1 s of encode_native_body, 20.8 s of it in to_value.
binary::write_serialized is a serde Serializer for the tagged binary
format: it writes each value as it is serialized and applies the same
checks as it goes (nesting, string and array budgets, floats within
1e12, the value budget, the size limit). An object's entries are put in
key order when it closes, as the JSON map held them; floats that are not
finite are null, as to_value made them. The bytes are the same: a test
encodes plain, blended, cut, extruded, painted, split, open, round and
far-placed bodies both ways and compares them, and all 101 Menger bodies
(6 to 28 412 faces, 15 kB to 68 MB) encoded both ways in one run were
byte for byte the same. The JSON-value writer stays for the tests that
build hostile records.
Menger L4 3-tool --save, two runs each: encode_native_body 24.1 / 25.3 s
before, 3.0 / 3.0 s after (the longest call 1.34 s -> 0.29 s); the run
41.2 / 41.4 s wall before, 39.1 / 39.2 s after (the encodings run on
16 threads).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A To Object extrude to a curved face runs its tool through the target and
cuts the target out of it. The SMLib boolean carries no extrusion face
sources (they stood for the untrimmed profile), so sheet_tool_span, which
read the tool's depth and footprint only off its extrusion caps, gave up
and the intersect was refused as unrepresentable.
The tool's current geometry says what it is: the kernel's prism
certificate (prism_measure, the one component copies are compared by)
reads off the exact record whether a body is a uniform prism along a
direction, its two cap levels and its section of lines and arcs. It is
now public as certified_prism_section, and sheet_tool_span uses it when
the caps don't certify the tool: the levels are the depth, the section the
footprint the To Object cut is bounded by. A tool trimmed to something
that is not a prism (a curved roof over it) is still refused.
partial_depth_intersect_curved_to_object_preserves_current_trimmed_cap_footprint
passes: the tool is the square 20 ... 30 less the pin's circle (radius 2),
z 0 ... 1, 100 - 4π, as the test's own witness extrude measures it. A
kernel test reads that section off the trimmed lump.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The refusal "capture the source occurrence position before generating a
legacy face profile across components" lost its test when Offset Face got
an exact history name (b6c3bf3c5). A half of a box's top that Split Face
divided still has neither a construction certificate nor an exact history
name, so Extrude from that face, in a component whose occurrence has an
uncaptured move, takes the legacy path and is refused there; the document
and the pending moves stay as they were.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
end_at_wall takes the plate's end strip off a wall that stands on part of
an edge of the fixed face: the strip's two corners and its two edges go.
They were filtered at their places in the face's lists, counted from the
bend's edge, which pairs corner j with edge j only while the places do
not run across the lists' start. SMLib merges the plate's end strip and
both walls at x = 100 into one L-shaped face whose loop starts on the
strip, so the corners left were each followed by the next one's edge:
the bend's edge took the wall end's face and the wall end took the
plate's. The bend then ran the wall's full width and no relief cut it.
Both lists are now kept counted from the bend's edge.
a_wall_on_part_of_an_edge_meets_a_wall_at_a_relieved_corner_and_is_relieved_at_its_end
passes: bends [22, 92] (was [26, 96]). From the geometry: T 2, R 2, the
setback R + T = 4 on the plate from y = 0 and from x = 100; the round
corner relief 8 across is centred on the setbacks' corner (96, 4), so it
takes 4 off the end of each bend there: the long bend from x = 0 to
96 - 4 = 92, the short one from y = 4 + 4 = 8 to 30, 22 long.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The kernel switch broke these tests only through their counts, which record how a kernel splits
faces rather than whether the result is right. Each now checks its intent:
- a fitted circle is the exact circle (centre, radius, a full turn), not "one segment";
- the tight bend sweeps a valid solid of Pappus' volume, πr²(40 + 5π/2), not a count of faces,
edges and vertices;
- the Pi case keeps each outer side one face, stays valid after every feature and rebuilds the
same topology at 32 whether built there or edited there, without a hard-coded table of totals;
- a certified paint stays on the wall's radius and covers as many faces after an edit, a copy
and reopening as when it was painted;
- the offset sleeve and the extended strip are checked by their exact areas only.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
saved_curved_strip_projection_is_lost_after_exact_wall_coalescence built its "old" strip by
cutting the cavity raw (paint turning off the construction shortcut), where truck sewed the cut
slab by slab and split the outer round at the cavity's floor. SMLib cuts without slabs: the raw
cut's round is one face, so there was no piece to save a projection on, and the test stopped at
"must have a piece suffix". The link is now what such a build saved, written out: the face name
`F2:blend:F1:+x|F1:+y#1` (the lower piece, numbered up its spread) and the piece's projection on
YZ, the rectangle y 24..30, z 0..2 (the quarter round from (40, 24) to (34, 30), its arcs and
straight sides), 12 mm³ when extruded 1. The current wall is checked to be one face with that
stem and no planar authority.
The test still fails: the link is found on the whole wall ("was split; using the nearest
piece"), not lost, and the strip's material grows to 6 × 30 × 1 = 180 mm³. project.rs takes a
missing piece as removed only on a certified planar or coalesced face, which truck's shell
made and SMLib's does not. That is a persistent-name decision for the owner (see the PR).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fillets_on_tapered_bosses_saved_before_still_find_their_edges compared the part with
69454.885209 mm³, what the truck build that saved it measured. In closed form: the 80 × 40 × 20
block (64000); the 20 × 20 boss 10 high tapered 5° in, a frustum to a 20 − 20 tan 5° square
(3660.251034); the Ø16 boss tapered alike, a cone frustum to radius 8 − 10 tan 5° (1798.751833);
less the R1 round on a sloping corner, the corner's section r²(cot φ/2 − (π − φ)/2) at its
dihedral angle φ = 90.435° times its length between z = 20 and 30 (2.124401), and the R0.5
round all round the cone's top, the section at the rim's 95° turned about the axis by Pappus
(1.928463): 69454.950004. SMLib's part measures 69454.950004.
The test still fails before that check: Fillet2's saved edge `F4:side:c1#1|F4:top#[F4:side:c1]`
names a half of the cone wall truck built, which SMLib builds whole, so it is found with a
"was split" warning (a persistent-name question, see the PR).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Since 0a216d692 tangent and curvature extensions are SMLib's G1 and G2 extension of the surface
(smlib_extend_sheet, CreateExtendedSurface), and the face stays one face on it, as
surface_extend's docs say; extend_a_cylinder_strip_every_way still counted truck's separate
run-off face (2). It counts 1.
The test still fails after this, on the curvature run-off's area (see the PR): SMLib's G2
extension of the quarter cylinder by 5 gives 413.882 (a section 4.986 long), where the test
works out the parabola's 418.182.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
cut_keeps_posts_joined_while_apart_in_one_body expected the reply's `bodies` as
["Case", "Case (1)"]. That list is the state's order, which is SMLib's lump order (the -x half
first); the names follow the pieces' faces (lineage::order_lumps, 08cf526fe): the piece whose
least face name sorts first keeps "Case". That is the +x half, whose least is `F1:+x`, before the
-x half's least, its piece of `F1:+y`. The test now checks the names as a set, that the +x half
(from x = 1) is "Case" and the -x half (from x = -30) "Case (1)", and each half's volume as
before.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Since 09c979a4b a circle is one closed arc, so an extruded circle's wall, a hole's wall and a
cylinder's side are one face each, closed along a seam. Tests that counted truck's two halves:
- certified_annulus_side_rows_follow_radius_edits_and_clone and
certified_side_transfer_preserves_geometry_and_unsupported_taper_refuses_atomically: the
painted outer wall is 1 face (every vertex of it still at the painted radius), not 2;
- offset_surface_of_a_cylinder_and_a_box_top: the offset sleeve is 1 face (its area 2π·12·20
unchanged);
- press_pull_then_curved_face_offsets_it: a click on the hole's wall offsets its 1 face;
- pi_case_faces_per_step_at_both_heights: each standoff (a ring, Ø6 round a Ø2.5 hole) adds 4
faces, not 6: its outer and inner wall, its top, the floor inside its hole. So 23 after the
first and 35 after the pattern of four; the port openings (3 × 4), the end cut-out (4) and the
five vents (5 × 4) are planar and add what they did: 47, 51, 55, 71.
- the_round_sides_of_a_thin_ring_are_named_by_the_circle_they_run_beside: a thin ring 2 thick
about the R10 circle has two walls, `F2:wall:c1:left` (radius 9: the counter-clockwise
circle's left is inside) and `F2:wall:c1:right` (radius 11), with no numbers; each name is
found again by a point on its own wall.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
box_and_fillet_have_stable_wire_records compared the encoding of a box and a filleted box
with records truck built (2f4d6acac). Since f11c0c571 an operation's result is the record
SMLib gives, which numbers the box's faces in its own order and the fillet's edges by its
history, so the golden differed in face order, face sources and edge history, not in the
encoding. Rewritten with NATIVE_BREP_BLESS=1 and checked against the geometry: the box 6
planes, 12 edges, 8 vertices, each face source's plane its face's; the filleted box 7 faces,
15 edges, 10 vertices (one edge replaced by a face: +1, +3, +2), the round a cylinder of radius
2 along x on the axis (y, z) = (2, 8), 2 from y = 0 and z = 10.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Since 09c979a4b a full circle in a profile is one arc of a whole turn, so what is built from
it is one closed edge and one wall closed along its seam. Five kernel tests still expected
truck's halves:
- a_small_hole_in_a_large_spline_face_cuts_cleanly: the Ø1 hole adds one face (its wall),
not two; the removed volume (π · 0.25 · 40) is unchanged.
- fit_loop (two mesh_convert tests): a fitted circle is Loop2::circle, one segment.
- tight_bend_counts: a Ø10 tube swept up 20, round a quarter turn of radius 5, along 20. The
circle starts at (5, 0), which runs up to (5, 0, 20) on the bend's axis, where the turn
leaves it: the bend face has no seam and both straights' seams end there. By the ladder's
rule (each whole curve once, each seam): 5 faces (2 caps, one per path segment), 6 edges
(4 circles, 2 seams), 3 vertices (the seams' ends: (5,0,0), (5,0,20), (25,0,20)), the
record's own counts.
- extruded_circles_go_as_cylinders: the record holds the wall as the cylinder it is (one
face of three), no longer a rational spline; it still goes into SMLib as its cylinder.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A folded edge's Hermite pcurve on a bend's form breaks where the edge's angle crosses a
quarter. At the 120 degree corner with flanges at 60 and 90 degrees under a tear, an edge
starts 3.25e-12 of its parameter short of a quarter: the crossing was kept as a break
(breaks within 1e-12 of the parameter merged), the pieces halved to 1.6e-12, and SMLib,
given knots 1.6e-12 apart, handed the pcurve back with 15 equal knots at degree 7 ("SMLib
export: pcurve: loop 0 use 1: given pcurve: portable B-rep: knot multiplicity"). A crossing
whose point on the edge lies within the pcurve's lift accuracy (FOLD_TOL of the edge's size)
of the previous break is that break; the end is never merged into the start.
Fixes sheet::tests::every_pair_of_angles_is_torn_or_keeps_its_notch (torn pairs 37, 37, 27).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Two expectations encoded truck-era output:
- a_flange_bent_inside_keeps_the_base_sketchs_arcs_in_the_flat_pattern_and_the_dxf: the
DXF has 7 LINEs, 4 ARCs, 11 shapes (was 9, 4, 13). The flat outline is SMLib's exact 2D
union of the plate, the bend zone and the flange panel; a zone's side and its panel's side
meet in line, and a region's boundary has no vertex in the middle of a straight run, so
each flange side is one line: 6 outline lines (plate top, left, right; flange sides and
end) and the bend's centre line. The same reason as 5d25684a1 gave for
a_base_trimmed_for_a_flange_keeps_its_arcs (12 to 10 edges). Areas, the bend length and
the volumes are checked as before and hold.
- hole_beside_two_adjacent_edge_flanges_cuts_and_bends_stay_guarded: the folded volume was
14057.2 +- 0.1, a faceted measure; since 32ae0cd9c the measure is SMLib's exact integral,
14057.3837123. Exactly, a folded sheet holds its flat area A times t, less each bend's flat
strip L·t·(R + K·t)·π/2, plus its sector L·t·(R + t/2)·π/2: t·A + t²·(½ − K)·(π/2)·L. With
t = R = 2.5, K = 0.44, A = 5597.0353454 (the flat pattern) and L = 75 + 35, that is
13992.5883635 + 64.7953485 = 14057.3837120, within 2e-11 relative of the measure. The
test now checks that identity to 1e-9.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A face's sheet name is the name 80% of its mesh triangles' centres agree on. SMLib's
mesher fans a 1 mm rim (30 mm tall) into four triangles about its middle; two of their
centres lie 1/6 mm from the panel's top or bottom face, inside the 0.2·t tolerance, and
took that face's name, so the rim got no name (rim.side0/side1/ext0/ext1 of the tray's
flanges: 6 faces unnamed). A flat face's name now needs its plane to face along the
triangle's normal (within 1e-3); otherwise the point is a rim's, a bend's or an ext rim's.
No face changes name: these faces had none.
sheet::face_names_tests::a_trays_faces_have_readable_sheet_names_that_follow_its_size now
passes its naming checks and fails later, on the point named_face_point gives for a rim
(the roomiest triangle's incentre, 0.497 mm from the rim's edge, not 0.5).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A hole drawn on a flange's face and cut through ("direction": "negative") was refused as
"below the supported 0.000001 mm extrusion resolution": the flange panel's frame, turned
up by the cosine and sine of 90 degrees, puts the panel's origin at -1.9999999999999998
along the sketch normal, so the cut ends 2.2e-16 mm short of the sheet's far face and
reads as a layer 2.2e-16 thick. A depth within four units in the last place of the
numbers it is worked out from (the frame origins, the tool's span and the thickness) now
lands on the face. A real thin layer stays: a 1e-8 mm layer of a sheet 1e5 mm from the
origin (bound 9e-11 there) is still refused
(partial_depth_intersect_sub_extrusion_resolution_layers_refuse_atomically passes).
Fixes sheet::tests::a_sketch_on_a_sheet_face_follows_the_sheet_when_its_thickness_changes.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Since 09c979a4b a circle in a profile is one closed arc (Loop2::circle). The sheet's
faces passed it to the sew as one arc edge from a point back to itself, which the sew
refuses ("sew: a degenerate edge"): a sewn edge runs between two vertices, and an arc
edge is the circle through its ends and middle. A disc's flange failed (first with the
4-face minimum, then with the degenerate edge). Each closed curve of a cell is now split
into its two exact halves (Seg2::split_half) where the cell's edges are prepared, as a
hole's wall already came out: a disc is two caps and two half walls.
sheet::tests::tiny_cut_inside_exact_circle_survives_unfold_refold_and_dxf now builds the
disc flange and fails later, on SMLib's extrude of the 50 nm tool (an SMLib tolerance
defect, reported separately).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The case expected "drill 6.75 mm for M8", the major diameter less the pitch.
Since 05f1c6b9a (Tapped holes: the tap maker's drill for every form) a tabulated
size names the tap maker's drill, 6.8 mm for M8 x 1.25 (Yamawa YEU23 p.704), as
case 2115 already grades and engine thread_tests.rs asserts; major less pitch
is for a size no table lists. The refusal itself and its reason are unchanged.
The case passes and leaves threads/KNOWN_FAILING.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The zero-area triangle is dropped (previous commit): the box converts with six
faces and V = 1000 mm^3, as the case expects.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A triangle whose corners lie on one line (or weld into one another) adds no
surface, so welding now drops it, with any corner only it used, instead of
refusing the whole mesh as having a degenerate triangle. The closed and
consistently oriented check that follows still refuses a mesh that needed it to
close, and a mesh of nothing but such triangles is refused by name. Dropping its
unused corners keeps a dropped triangle from widening the part's extent, which
the prism search reads from every position.
Regression test a_zero_area_triangle_is_dropped: the 20 x 10 x 5 box with the
case's extra triangle (0,0,0) (10,0,0) (20,0,0) converts to six faces and
V = 1000 mm^3.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fixed_seeds_run_clean expected the join of a box touching the first only along
an edge to be refused with "zero-thickness edge contact". Since 94ee28d5c (doc:
a join keeps solids that only touch as separate bodies) such a join succeeds and
keeps the new box a body of its own with an along_edge notice, which
join_touching_along_an_edge_keeps_a_separate_body asserts in engine tests.rs.
The seed now expects that: the notice, two bodies, each valid, and the volumes
unmoved, 25 x 15 x 10 + 17.5 x 17.5 x 20 = 3750 + 6125 mm^3.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SMLib's thickening of the test sheet makes a top face of 72 x 78 control points,
which the 4096-point cap refused (TooLarge) before the solver saw it. The band
cap (2^21 entries, 16 MB) is what bounds the system's memory and its
factorisation (at most n min(n, bw)^2 work); the 72 x 78 bicubic net needs
5320 unknowns 213 apart, 1.14 M entries, well within it. The point cap now
bounds only the per-step energy sweep and the net's copies: 2^14 points, above
the band's own limit for square bicubic nets (about 90 x 90), so a face is
refused for the system it needs rather than its size. The hostile-input test
asks for 129 x 129 and checks the refusal is TooLarge.
a_body_face_is_faired_with_its_edges_untouched_and_its_history_kept passes.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The README demo's Raspberry Pi case stands four standoffs on its floor: Extrude2's ring of
radius 3 round a 1.25 hole, patterned by RectangularPattern1. Each is its outer wall, its inner
wall, its top and the floor inside it: four faces. The recorded counts were truck's, which made
each cylindrical wall two halves (six faces a standoff): 25 after feature 6, 43 after the
pattern, and 8 more than now at every step after it. On SMLib each wall is one face closed on
its seam, and the counts are 23, 35, 35, 47, 47, 51, 51, 55, 71 from feature 6 on (the feature
names show it: F6:side:c1, F6:side:c2, F6:top and the floor piece bounded by F6:side:c2 per
standoff). The outer sides stay one face each, and (b) and (c) still agree step by step.
Fixes cli rebuild_topology::pi_case_faces_per_step_at_both_heights.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- A modelled thread reopened with the designation 1/4-20 UNC on the M8 it was made as: the
thread is metric, and since b4549d270 (threads in the standard forms) an unknown designation
is named with its form: "unknown metric thread `1/4-20 UNC` (like M8 or M8x1)". The test looked
for the old wording, "ISO metric".
- Press Pull on a hole's wall opens Offset Faces with the whole wall: one face, closed on its
seam, on SMLib (a cylinder wall was two halves on truck).
Fixes ui-egui dialogs_thread::contribution_tests::expanded_catalogue_rejects_external_taper_holes_and_nonmetric_thread_features
and preselect_tests::press_pull_then_curved_face_offsets_it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A face on a B-spline surface closed around u (first and last control columns the same) may lie
across the surface's start without winding round it: the strip on a radius-3000 rational
cylinder whose seam is 0.001 rad into the strip. A kernel's trims run inside the surface's
knots, so its pcurve came back clamped at the start, 2.28 mm off its edge, and the strip was not
imported.
Before seams are added, such a surface is started anew in the middle of the stretch of u the
face leaves free (each loop followed round, unwrapped across the start; a face winding round is
the seams' to handle): the new start inserted to full multiplicity and the piece after it put
before the piece before it, a period on. The same points, a period apart in parameter before
the new start: exact. The face then lies inside the knots.
Fixes kernel step_in::tests::explicit_outer_bound_crossing_a_closed_nurbs_seam_stays_trimmed.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Two tests counted the old 2D boolean's edges, which kept a vertex wherever an operand's corner
or edge end lay on another's edge. SMLib's planar boolean leaves no vertex that is no corner:
edges on one line within the tolerance are one edge. The results are the same regions with
fewer, whole edges, and each test's point stands (no edge shorter than the tolerance, no sliver):
- a quadrilateral cut away from below a square whose bottom edge it lies on within 1e-8 (tilted
1e-9 rad) leaves the square's four 10 mm edges (its corner at x = 4 is within 1e-8 of that
edge's line), and its union runs along y = 0 as one 14 mm edge (the quadrilateral's bottom
edge is within 1e-8 of y = 0 all along): [4, 5, 5, 10, 10, 14];
- the bent plate and the strip under it: their ends on the line x = 150 are one edge from
y = 47 to 80, six edges for every turn and offset tried, the shortest 3.
Fixes prism::planar_tests::overlapping_lines_a_hair_from_parallel_do_not_cross and
a_bent_edge_crossing_its_neighbour_by_their_corner_leaves_no_sliver.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Reading a planar sheet's faces back as regions, each hole went to the smallest outline whose
Loop2::contains held its middle: even-odd against the outline's polyline within 1e-3 mm. A
5e-5 mm square cut 1.7e-4 mm inside a radius-10 circle lies outside the polyline's chords there,
so no outline held it and the cut failed ("face 0 has a hole outside its material"). An
outline now holds a point by its polyline within a quarter of the point's distance from it (its
nearest point on the exact segments), which no chord can pass the point by.
Fixes kernel prism::planar_tests::tiny_tool_between_circle_and_display_chord_is_not_lost.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
94bd8719a (#3730) turned a BREP_WITH_VOIDS void inside out when it enclosed volume of the
outer shell's sign: SOLIDWORKS writes .F. over a void shell already facing into its cavity,
SolidCraft .T. That lived in the truck reader; the schema-4 reader (crates/step) that replaced
it took the flag alone, and the block with a 20 x 6 x 5 cavity read as 15600 (the cavity added)
instead of 15000 - 600 = 14400.
The reader now takes each void's sign from the faces themselves before it orders the record:
the divergence theorem on the record's surfaces and pcurves (sew's face_flux of p / 3, moved
to geom's brep::eval so both use it). A void enclosing volume of the outer shell's sign has its
faces turned over. Flipping on the finished record is not an option: its edges are ordered by
the faces' sides.
Fixes kernel step_in::tests::a_void_reads_as_a_cavity_whichever_way_its_shell_flag_points.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The expected 6703.5222 was a mesh measure (truck). The lid exactly: the 76.8 x 89.3 x 2.4
plate less its four 3 mm corner rounds ((76.8 * 89.3 - 36 (1 - pi/4)) * 2.4 = 16441.2344), the
skirt ring ((71.5 * 84 - 68.5 * 81) * 3 = 1372.5), less the window (68 * 61 * 2.4 = 9955.2) and
the slot (44 * 10 * 2.4 = 1056) through the plate, and the notch through the skirt's 1.5 mm wall
(22 * 1.5 * 3 = 99): 6703.534401. The window and slot lie inside the ring's opening and the
notch above the plate, so nothing else overlaps. SMLib measures 6703.534401575, 2.6e-7 off.
The test now computes that closed form and holds the body to 1e-6.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A whole circle is now one closed rational curve (Loop2::circle is one segment), whose first
control point is repeated as its last: the mean of its nine control points sat r/9 towards the
seam, and a rail scaled each station about that point. A rail bulging from radius 10 to 15
(r = 10 + 5 sin(pi z/40)) then grew the circles as if r = 10 + 5.625 sin, volume
4632.8 pi + 9000 = 23553.9 against the solid of revolution's pi * integral r^2 dz =
4500 pi + 8000 = 22137.2 (+6.4%; the engine's arc rail +6.5%).
The middle is now the curves' centroid by length, integral x ds / integral ds (8-point
Gauss-Legendre per knot span on the rational point's speed): the shape's alone, however its
curves are written; a circle's is its centre. geom's GAUSS_8 is public for it.
Fixes kernel loft_rails_tests::a_bulging_rail_makes_the_solid_of_revolution_of_the_rail and
engine loft_rails_tests::a_rail_turns_a_loft_into_its_solid_of_revolution_and_stretching_is_an_edit.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fillets/4782-fillet-two-end-verticals-past-a-full-round passes: SMLib (90aabff) refuses
R10 on the 15 mm wide box's two end verticals as too large, and the refusal now names
the largest radius that fits, 7.5 mm (the full round). Run on aarch64 Linux with
--known-failing: every other fillets case as listed.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Under the blend-overflow decision (237f0ae74) a convex round running over a face's far
edge (a cliff) is built and cut from the part, so the truck-era fixtures of the reduce
and taper fits (a 2 mm fin, a plate narrowing to 2 mm, a wedge, a 10 mm cube's edge at
R20) no longer refuse their radius and the fits have nothing to react to. Each test now
uses a case SMLib still refuses, and checks the cliff case builds:
- engine fillet_fit_reduce_keeps_the_radius_where_it_fits: a 14 x 6 x 10 post on a
40 x 30 x 20 block, its four verticals at 3.5 (two rounds would cross on its 6 mm ends)
reduced to 3 on 4 of 5 edges, the block's corner kept at 3.5: 24840 - (4 - pi) 90 -
(1 - pi/4) 3.5^2 20. New fillet_fit_reduce_keeps_a_round_over_a_cliff: the fin's R4
builds, nothing reduced, at the kernel's fillet_max_each answer.
- engine fillet_fit_taper_follows_the_room_along_the_edge, spline_fillet_takes_over_a_taper,
kernel taper_follows_the_room_along_the_edge, ui-egui fillet_spline_handle_tests: the
narrowing plate stands against a wall behind its slanted side (z -15 to 30), so its top
and bottom end in concave edges: R3 is refused and tapers 3 -> 1.8 as before. Without
the wall, R3 is cut over the 2 mm top's far edge and kept constant: at x the section
loses (1 - pi/4) 9, or 3 w - (F(3) - F(3 - w)) where the top is w < 3 wide, 6522.7745566.
- The wedge closing to a point: on its own R16 is cut over its cliffs (the section
integral, 4195.578821, SMLib within 4e-8) and kept; its room's taper is checked as a
spline fillet. Against a wall (new fillet_fit_taper_closes_to_a_point) the taper must
close to 0, which SMLib fails today (status 1001).
- kernel taper_mesh_tests: the collapsed taper is built from taper() as a spline fillet.
- ui-egui the_feature_menu_copies_a_warning_message: the 10 mm cube's four verticals at
6 are reduced to 5 (a full round), which the warning says.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The owner's blend-overflow decision (2026-10-25, 237f0ae74): a convex round or chamfer
whose rail runs off its face across a cliff (an opening's rim, a hole, the part's
outline) is built on the faces continued and what it removes is subtracted, so it never
bridges an opening; a round may use up a face; a chamfer of a face's full width stays
refused. These tests still expected truck's refusals. Each now expects the decision's
body, with its answer from the geometry:
- issue_1080 chamfer_into_a_pocket_is_cut_by_it (was ..._is_refused_with_the_size_that_fits):
chamfer 6 into the pocket 4 mm in removes 360 - 20 (its triangle less the part over
the pocket): 14660; 6 along the top and 2 down, 120 - 20/3; 2 and 6, 120.
- issue_1080 fillet_into_a_pocket_is_cut_by_it_and_one_that_fits_builds: R5 removes
(1 - pi/4) 25 along 20 less 10 (5 - (sqrt(24)/2 + 12.5 asin(1/5))): 14893.0344442.
- issue_1080 chamfers_crossing_each_other_are_refused: still refused (they cross);
chamfer_max and fillet_max find 2 mm.
- issue_1080 rounds_on_both_sides_of_a_wall_build_as_one_fillet: R7 alone opens a slit
where its arc passes the inside corner: V0 - (104 (1 - pi/4) 49 - 100 a), a = the square
[25, 30] x [35, 40] outside the circle about (25, 35), 5 (5 - sqrt 24) - (F(5) - F(sqrt 24)):
38458.8958265. Both at R7: the arcs about (25, 35) and (23, 33) cross only outside both
quarter arcs and the inner round's material holds the slit, so V0 - 4 (1 - pi/4) 49 =
39509.9380404 (was expected refused).
- issue_324 a_round_into_a_hole_is_cut_by_it (was the_radius_offered_beside_a_hole_fits):
R4 over the r3 hole: 8000 - 90 pi - (640 (1 - pi/4) - the round's height over the
hole's width, integrated with y = 17.5 - s^2): 7580.2873154.
- issue_851 arc_top_blend_uses_up_the_wall_and_refuses_a_collapsed_one: a round of the
wall's full height uses the wall up (one face for the wall, the removal integrated as for
the other sizes); the full-height chamfer stays refused.
- kernel tests: fillet_max_finds_the_largest_radius_that_works keeps the post (3.5 -> 3)
and the no-edge case; its disc and notch cases move to
rounds_past_the_bottom_of_a_wall_are_cut_from_the_part: the 2 mm disc's R2.5 turned
section, pi (338 - integral of (169 - rho^2) dz), rho = 10.5 + 2.5 cos(theta) (the same
formula gives SMLib's R2 994.15188 exactly), 957.6922389; the notched block's outline
R7, 11925 - (1 - pi/4) r^2 (140 - 8 c), c = r (10 - 3 pi) / (3 (4 - pi)) (SMLib's R7 within
5e-8), and R8 less its part over the notch, integral of 2 (5 g - g^2/2), g = 8 - sqrt(64 - t^2).
- kernel tests: chamfer_wider_than_sloped_basin_rim_is_cut_and_a_full_width_one_refused:
past the 1 mm and 0.5 mm rims the chamfer runs over the slab's front edge and is cut:
the clipped triangle's area (30 + z centroid), its length 60 - h between the sloped end
walls (the same formula gives chamfer_sloped_basin_rim's fitting chamfer to 1e-12);
a chamfer as wide as the rim is refused.
- blend_corner sloped_rim_fillets_stay_inside_the_material, equal_slope_rim_loops_stay_
inside_the_material: R4 and chamfer 2 over the thin rim build, every vertex inside the slab.
- engine blend_fit chamfer_through_the_openings_is_cut_by_them: the report's 9 mm chamfer
is cut by the openings, 3350 (the rig's fillets/1080 case).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Since bcbb99005 a blend larger than its faces is SMLib's refusal (KernelError::TooLarge,
"the fillet is larger than the faces beside its edges allow"); truck's room check, whose
words these tests still matched, went with blend_fit. The refusals themselves stand:
- fillet_consuming_a_side_face_makes_a_full_round: R3.001 and R3.5 on the 14 x 6 x 10
box's four vertical edges, past the full round, are refused as too large (no longer
"larger than the neighbouring faces"); the body unchanged is its own volume before
(SMLib's measure of the box is 839.9999999999998, not 840 bit for bit).
- a_chamfer_that_would_grow_the_part_on_a_convex_edge_is_refused: refused as too large;
the word "convex" was the old check's.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
When the kernel's room pre-check went (bcbb99005), a fillet or chamfer refused as
too large stopped saying what would fit: only SMLib's NO_ROOM words were left. The
rig expects the refusal to name it (fillets/4782-fillet-two-end-verticals-past-a-full-round:
"the largest radius that fits is 7.5 mm", fillet_max for the exact fit).
A constant fillet with the exact fit, and an equal-distance chamfer, refused as too
large now add "; the largest radius (distance) that fits is X mm", found by the same
bisection fillet_max runs (up to 16 blends, three significant digits), now shared with
a new kernel::chamfer_max. Where the search itself fails (a candidate failing for
another reason), the refusal is left as it was. The reduce and taper fits and the
kernel's own searches call the kernel blends directly and do not pay for it.
Tests: the 14 x 6 x 10 post's R3.5 names 3 mm; a 4 mm rib's crossing chamfers and
rounds at 3 name 2 mm.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
sweeps_along_paths expected one wall for the circle swept through 41 points of
a smooth curve: a point path is the polyline its points make, swept line by
line and mitred at each point since 43e8b0349 (sweep_path's own test expects
40 + 2 faces since d9274aaf1), so the circle's one segment has a wall along
each of the 40 lines.
The holed square along the L-shaped path expected two faces per segment. The
corner turns the profile about Y, so each line at a constant y (the outer
loop's segments 0 and 2, the hole's 1 and 3) sweeps the plane y = c it lies in
along both legs, and the two walls meet edge to edge on the mitre in that one
plane: one L-shaped planar face. The lines at a constant x sweep two planes,
two faces. check_sweep takes the count per segment.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
sweep_origins read a sweep_path tool's faces by the truck face order (walls in
profile order, then the start and end caps), and fell back to swept_origins,
which names a face without an edge in the profile's plane an end cap. SMLib's
sweep along lines and arcs is made piece by piece and mitred at each corner
(tangency-labs/smlib#43), so most walls start further along the path: 39 of a
44-face sweep came out as end caps (105 of 110 before the previous commit). The
sweep records each face's origin as it builds it (Body::history), and
sweep_origins now returns those, finding by geometry only a face the tool names
no origin for. swept_origins says what it holds for.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A sweep along a path with corners sweeps each run past its corners and cuts it
back to the plane halving the corner. The lead past the corner was the
profile's reach times tan(turn / 2), enough only for a profile square to the
path. A point standing s ahead of the path and w from it needs
w tan(turn / 2) - s past a corner (w tan(turn / 2) + s before one): a profile
at a slant to its path reaches across the mitre by its slant as well, and a run
carried short of it leaves a notch with a piece of the run's section in it.
The section keeps both distances along a run and through each corner (it
turns with the path; a twist keeps them, an end scale grows them by at most
its largest scale), so the lead is taken from the profile's points at the
start, for the plain and the controlled sweep. A profile square to the path
(s = 0) leads exactly as before.
The walls' history seeds sat at the middle section of each run, which for a
slanted profile on a run shorter than its slant lies past the mitres, on the
next run's wall: half the walls came out generated. Each piece's seed now sits
half way along the stretch its own point keeps between the mitres, carried
there exactly along lines and arcs (as SMLib's sweep turning with the path
carries the profile), at the station there in the controlled sweep.
A flat 4 mm square swept along 21 points of a rising sine (provenance test):
110 faces, 66 of them notch faces, and walls left unnamed; now 44 (two caps, the two
walls in the path's plane, a wall of each slanted side along each line), volume
16 cos(slant) L to 1e-6 (new test a_slanted_profile_meets_itself_at_every_mitre).
The square round a closed 122-line polyline (issue_2005
closed_polyline_sweep_shares_its_starting_section): the first section leaned
by half a chord's turn left a 6.2 mm^2 piece of it at the closing mitre, named
the start cap; now 246 faces, every one a wall.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
legacy_internal_capture_refuses_an_uncaptured_source_in_another_component
picked the top Offset Face raised as a face with neither a construction
certificate nor an exact history name (#494), to reach the legacy path
that refuses a profile across components while the source occurrence's
move is uncaptured. Offset Face has SMLib's history since 0f3d6f177 (shell,
offset faces and thicken through SMLib), so that top is now named exactly
(F3:+z#[F3:-x], verified) and capture_face_anchor gives it a lineage
anchor; the legacy path is not taken, and the capture is right to
succeed: an anchored attachment captures its path's pending positions
when it is made (capture_positions).
The test, renamed to what it now checks
(internal_capture_in_another_component_anchors_an_offset_face_by_its_history_name),
asserts the face still has no construction certificate, the capture is a
Lineage anchor on the occurrence's path, and capturing changes neither the
document nor the pending moves.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The test cut three regions from a plate that keeps its meshes and
expected the memo to hold one mesh afterwards: the old kernel's booleans
meshed their operands. On SMLib (ops::boolean -> smlib_boolean, since
42c41464a) a boolean reads the exact record and a tool apart from the
body is found from the exact boxes, so no boolean meshes anything and the
memo is empty after them. The test now asserts that, then that meshing
the kept body twice at one tolerance makes one memo entry, bit-equal to a
fresh mesh, which is the reuse the memo is for.
Fixes kernel body::mesh_memo_tests::regions_cut_from_a_body_keeping_its_meshes_are_unchanged.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Split Face records its lines on the body (split_lines): heal and the
certified-planar regularizer keep the faces apart along them, and they
make the body regularization-protected. On SMLib the boolean, the n-way
union and Shell carried the protection over but dropped the lines, so a
body with an authored split lost its record after a Union with partial
contact (issue #674/#782's case), and a shelled one after Shell. Each
result now keeps its operands' lines, each line once
(Body::inherit_split_lines), as the old kernel's coplanar join did.
regularization_protection_tests: SMLib's shell makes no section strips,
so the painted cup no longer has more faces than the ordinary one. The
ordinary cup is the box's five kept faces, their five linings and the
rim: 11. A paint over a whole face authors no boundary inside it, so the
painted cup has the same 11 faces; the split side's line stays an edge on
the wall and its lining: 13. The test now asserts those counts exactly
(it asserted more than 11 for both, the old strip route's witness) and
that the split lines survive.
Fixes kernel issue_674_tests::partial_contact_retains_an_authored_split_away_from_the_contact
and body::regularization_protection_tests::stamped_shell_keeps_authored_painted_and_split_boundaries.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The test helper side_by_side copied the second body's regions by hand,
dropping its voids and keeping its infinite region (region 0) as if it
were a bounded one. Its closed shell was then the outer shell of two
regions, which the portable record refuses ("a closed shell bounds two
regions and encloses one"). The helper now joins the two records with
geom's brep::part::compound, which puts each body's outer shells in the
one infinite region and keeps its bounded regions; the face sources are
still found by plane afterwards, so nothing the test checks changes.
Fixes kernel body::planar_sources::tests::coincident_competing_source_planes_and_tool_planes_stay_unknown.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Body::parts (and so Body::lumps) mapped each piece's faces through the
body's face-source table with a silent `get`, so a table shorter or longer
than the body's faces gave its pieces sources of other faces, or none. The
table is by face position: one whose length is not the body's face count
belongs to another body. The pieces are now refused with "lumps: face
source table does not match the body", as before the SMLib port (the check
went with the old lumps_with_clearance in 66e31bede).
Fixes kernel body::lump_tests::grouping_lumps_does_not_infer_absent_or_misaligned_sources.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Which input plane each result face lies on was found by scanning every input plane whose
normal x was within the resolution's angle: quadratic on axis-aligned parts (two thirds of the
faces have normal x = 0), so it was capped at 16 384 faces a body and 2 M comparisons, and the
join of the 20 level-2 sponges of a level-3 Menger sponge (7 326 faces) was refused past the
comparison budget.
The planes are now indexed by their unit normal, in cells twice the bound on two matching
normals' difference (asin(angular) < 2 angular), and in each cell by their offset from a common
centre, searched in the window linear + |a.o - c| |n_b - n_a| that
d_b - d_a = (b.o - a.o) . n_b + (a.o - c) . (n_b - n_a) gives, plus rounding slack. The index
offers a superset; same_support still decides each match, and candidates are taken in the same
order as before, so every answer is unchanged. A plane with a normal not of unit length is
offered to every query. Both caps are removed: results are bounded by inputs capped where they
entered. The descriptor-size budgets on kept roles are unchanged.
Rig, --known-failing, results compared case by case with develop's: booleans (129) and shell
(28) identical except booleans/5126-join-menger-sponge-level-3, which now passes in 38.9 s on
aarch64 and leaves KNOWN_FAILING.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
outer_area, which decides whether SMLib's normal is the record's for each
face, copied every edge of the body into a record for each face before
computing the pcurves of that face's outer loop: O(faces x edges) curve
clones, on every operand and every boolean result. pcurves now takes an
edge lookup instead of a slice of edge records, so outer_area reads the
loop's edges where they are. The pcurve routine gets the same curve,
interval, tolerance and trims as before, so every area, face turn, record
and numbering is bit for bit what it was.
On the level-4 Menger sponge with 3 tools, body_from_smlib_ordered goes
from 92.6 s to 1.3 s of self time.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
explode.show put the view's placements in the uncaptured moves, so occurrence.properties reported
the exploded placement and Capture Position (and reparenting, moving bodies between components,
copying or pasting in place, URDF export) wrote the view's offsets into the design. The session
now records which uncaptured moves are the view's (Session::exploded); what reports the design's
placements or works a new placement out from them uses the design's own moves
(uncaptured_moves, design_document), while the viewport and picks still show the view.
New case cov-explode-show-keeps-the-placements: the arm's properties are the same before, while
and after the view is shown, and Capture Position keeps nothing. The two explode cases that read
occurrence.properties while exploded now expect the design's placement, centre (20, 0, 5), as the
command says ("shown only; the design keeps its placements").
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The curves were held on a 1-2-5 ladder from the world origin, so count 3 on a 40 x 30 face gave 3
one way and 2 the other. They now follow the command's contract: the held parameter at
lo + k (hi - lo) / (count + 1), k = 1…count, over the face's extent. Faces of the body on the same
surface record are spaced together over their combined extent, so a face a boss splits still
shows the same lines straight across the split.
New case cov-isocurve-40-by-30-face-count-3: x = 10, 20, 30 and y = 7.5, 15, 22.5, to 1e-9 mm.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Both walked the picked curve's display polyline: a point a third along an R10 sketch arc was
0.87 µm off (8.6603, 5). They now evaluate the path's exact curves by arc length: lines and arcs
in closed form, a free-form span at the parameter its arc-length integral reaches (body edges by
their record curves, 3D sketch curves by their arc, spline, line or linked exact curves; only a
curve that exists as points alone, an intersection edge or a projected curve, runs along them).
The arc's point is now within 1e-12 mm of (10 cos 30°, 5, 0).
A t outside 0…1 was clamped silently, which the contract (`t: expr, 0…1 along it`) does not
say: it is refused ("t is 1.5: a point along a path is 0 (its start) to 1 (its end) of the way
along it"). The construction cases grade the arc and line to 1e-9 mm, past-the-end is refused,
and a new case takes the middle of a symmetric cubic spline, (20, 7.5).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A face of degree 1 in one direction (an extruded spline) was refused with "a fairness term does
not fit the net's degrees": the thin-plate energy's S_vv asks for second derivatives a linear
direction does not have. On every span that term is exactly zero, so it is dropped; the energy is
the bending along the curve and the twist. A face whose held layers are its whole net (a
single-span cubic with its edges kept, an extruded curve's two rows) has no interior control
point: it is left exactly as it is, its energy reported unchanged, 0 steps.
cov-fair-single-span-face-has-nothing-free-to-move passes and leaves KNOWN_FAILING.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The portable record's 4,000,000-item budget refused a real result: the join of a level-4
Menger sponge's level-3 sponges ended with "SMLib export: the mapped B-rep does not validate:
portable B-rep: item budget". The budget guards records from outside the kernel, and a body
the kernel built in memory from inputs already bounded where they came in isn't hostile.
Brep::validate keeps the budget for records read from outside: native design caches
(decode_native_body, behind its own 256 MiB, 1M-per-array and 20M-value caps) and STEP import.
The new Brep::validate_built runs every other check, without the cap, on what the kernel
builds: SMLib's export of an operation's result, a body's record (Body::from_record, after
the decoder has checked a file's), a part of a validated record, the record handed back to
SMLib, and the validity check. Its checks are linear in a record already in memory.
SMLib's export bounded its counts by the same budget; a count is now bounded by SMLib's own
longest array (flat::MAX_LEN, checked on entry), which keeps every offset worked out from
the counts from overflowing, and the redundant topology-length cap goes.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Where a round meets a plane it is only tangent to it: its curvature jumps by 1/r there, so no
corner patch can be G2 to both at that point. The cases graded the whole seam and could not pass.
They now bound the curvature jump at stations clear of each seam's turn, within reach of the
corner, scaled by r (ladder 07/019's bound at r5): r1 within 2.2 mm, 0.24 mm clear, 0.005 per mm;
r5 within 11 mm, 1.2 mm clear, 0.001 per mm. Develop's corner gives 0.00135 and 0.00027 per mm
(the jump at the vertex is 1.017 and 0.2035, the round's own 1/r), so both leave KNOWN_FAILING.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
When a − b or b − a cannot be made (a kernel error, or a body that encloses no volume), the
region's volume and centre are null, measured_by is "not measured" and not_measured gives the
cut's error; its deviation, area, faces and box are still given, the side's total is null and
the verdict says the volume is not measured. The integrated-along-lines estimate is no longer
reported as a volume.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
inspect.compare integrated a region's volume along sampling lines: the
40 x 30 x 5 slab between a box and one 5 mm taller came out at 5976.49 mm3
against 6000. The regions are still found from the two surfaces; each one's
volume, centre and box now come from the pieces of the exact cut a - b (or
b - a) that lie there, measured as inspect.measure measures a body
(measured_by: boolean). Where a cut cannot be made the region keeps the line
integral, marked measured_by: lines, with a warning. The rig case
cov-compare-taller-box passes.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
inspect.center_of_mass measured each body's display mesh, so a cylinder r 5,
h 10 came out at 784.13 mm3 against 250 pi = 785.40, and the answer moved with
display quality. It now takes the exact mass properties inspect.measure uses
(ModelBody::measure), skips bodies that enclose no volume as Measure does, and
lists what it skipped. The rig case cov-center-of-mass-box-and-cylinder passes.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- #58: a fillet's tangent-point step no longer depends on the blends before it (solidcore #1173).
- #59: the fillet clean-up keeps the target's edges and faces by a mark, not by address (#1176).
- #60: capi test, a line projected through a sphere's poles meets itself smoothly at each pole.
- #61: offset faces removes a step wall the move closes to nothing and merges the two tops, so
shell/cov-replace-face-step-onto-the-higher-face builds.
- #62: thicken puts a flat side wall on its plane (solidcore #1599), so a cylinder sheet's end
rings are planes: surfaces/cov-thicken-cylinder-sheet-symmetric-tube passes.
Both cases leave KNOWN_FAILING.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
They fail on develop today (4 native tests, 8 of 83 reference cases), so running them on pull
requests would fail every pull request. Back on pull requests once develop is green. Reverts
0cdc25094.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The single results form compares a whole number exactly (a count). The construction and inspect
cases gave positions and volumes as whole numbers, which the form they were written for compared
within tolerance; they are decimals now. The NPT groove fix makes ladder 06/023 pass: its golden
entry is the passing run (51 faces, 8226.4042 mm3).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The shared core (crates/smlib, the grader, doc eval.rs, engine features.rs and the kernel's core)
is in PATHS-ALL; the new areas' copies of it are dropped, so an area reruns on its own files and the
core reruns them all. sheet-metal also watches the sheet commands, the sheet document and the DXF
writer. 116 commands a case now uses leave EXEMPT; 25 geometry commands are still to cover.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Two branches added a results field in different forms ({step, json} and {command, pointer,
value}). The grader keeps one: a 1-based step, an optional JSON pointer into its answer, and the
value matched as files are, with an optional relative or absolute tolerance. The construction and
inspect cases are rewritten to it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The groove's section was cut square a fixed margin past the crest. The crest cone changes 1 in 32
along the axis across the section's own width, so for NPT (margin 0.015 mm against a 0.028 mm
rise) the section's deeper corner stopped under the cone and each tooth kept a sliver of its
flank: 0.94 mm3 too much on a 1/2-14 NPT. The section's edge now follows the cone at the same
margin.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
167/168: every new case passes against its hand answer but 06/023 (1/2-14 NPT external), whose
groove stops 0.015 mm past the crest at its section's middle, under the crest cone on the section's
deeper side, so a sliver of each tooth's flank stays (0.94 mm3, 1.1e-4). The 139 cases before keep
their statuses and counts; their volumes and areas re-measure within 2e-6 on this SMLib.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Base flange; an edge flange at 90 deg; four made together, the corners closed on the mitre plane
with the rule's gap, at 90, 72 (leaning out, the ends run on along a slant) and 108 deg (leaning
in, cut back); round, rectangular and tear reliefs; a hem; a fold, unfolded and refolded; the
tray's flat pattern (outline size and area, bend lines); a bracket with a hole and a flange on a
flange. K = 0.5, so every volume is T x the flat area. The 108 deg tray is a sheet-metal rig case too.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
From the script's last sheet.flat_pattern result: the outline's size, its area less the
cut-outs', and the bend lines, each matched to its own one of the result's either way round.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
G 1/2 external and Rp 1/2 internal (ISO 228-1 / ISO 7-1, 55 deg) by Pappus turn by turn; R 1/2
and 1/2-14 NPT external and Rc 1/2 internal tapers (1 in 16 from the standard's diameter at the
free end, crests cut by the major or minor cone) by the screw sweep's Jacobian, integrated exactly
(ladder_lib.sweep_removed); an S20x4 run down to a shoulder with its steep flank toward the end and
toward the start, which moves where the groove stops; tip: start, and a Tr20x4 chamfered at its own
30 deg and 2.5 mm; refusals for a Tr chamfer without a depth and for the square form.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1/4-20 UNC (#7, 0.201 in) and Rc 1/2 (17.6) through the stock, 1/4-28 UNF (5.45) blind with a
flat floor, 1/4-18 NPT (10.85) through: a cosmetic thread in a straight hole, so each volume is
the stock less that cylinder. The drills are the catalogue's (Guhring, Yamawa YEU23); each method
gives the standard's minor diameter beside it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The tap maker's 6.8 mm M8 drill, the chamfered tip's ISO 724 d3 with tip: both, and 07/016's
refusal reason were edited into the cases' JSON but not into cases.py, so running it undid them.
Its output now matches the committed cases (to the last rounding digit of two volumes).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A Default row, a 60 mm row, a row without the hole, a height column and rules
that suppress the hole or drive the height, each checked after activation;
preview leaves the design; refusals for a row that cannot build, unknown rows,
columns and features, and a rule a row breaks.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Suppress a hole and the block is whole again; a round moved before the notch
runs the whole edge and is cut by it; deleting a sketch takes its cut and
deleting the block leaves the round and cut failing; roll to the middle gives
the part at that step; edits, compute all and folders, each with a refusal.
The new history area has its KNOWN_FAILING (every case passes) and PATHS.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A case's construction field names construction points, axes and planes with the point, line or
plane each must be, and results reads values out of the commands' own replies by JSON pointer.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A new plastic area with its KNOWN_FAILING (empty: every case passes) and the
sources whose change reruns it; the README lists the area and the new files and
results fields.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A case's expected.json may name files written to $OUT (json, csv rows, or a DXF's
entity counts and curve lengths per layer) and a command's answer by step, each
matched as a part of what was made.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
cargo xtask kernel-cases --coverage lists every built registry command that no recipe.json under
tests/kernel-cases runs and fails unless tests/kernel-cases/EXEMPT lists it. EXEMPT holds 252
commands with no geometry to grade and, under [to cover], 133 geometry commands still waiting for
a case; a listed command a case now uses, or one the registry no longer has, fails the check, so
the to-cover section only shrinks. The gate's build job runs it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The booleans area also reruns on sketch projection from the model. The selection self-test
fails on an area glob that matches a file PATHS-ALL already covers, so a whole-crate glob
cannot creep in.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A plan job (scripts/ci/kernel_rig_plan.py, with its self-test) maps a pull request's changed files
to the areas: tests/kernel-cases/<area>/PATHS for each area, tests/kernel-cases/PATHS-ALL for the
shared core, the ladder whenever any area runs. Areas come from the folders, so a new one needs no
workflow edit. Pushes, merge groups, the release gate and runs by hand run every area. The
kernel-rig check counts a skipped build or shard as passed only when the plan selected none.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The gate passes no secrets to release.yml, so the macOS and Windows signing steps skip as
they do on a fork (no signing secret, no SignPath quota), and the new packages_only input
skips the release job (checksums, update signing, publishing). The call still grants
contents: write, which GitHub checks for the skipped job before the run.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
tests/kernel-cases/README.md describes the kernel rig gate for every area, how a pull request
updates its area's KNOWN_FAILING, and the ladder's --gate and --record. The tests skill and
CONTRIBUTING say which pull requests run the native and reference tests, and what the
release gate runs.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
release-gate.yml, run by hand on a branch, calls ci.yml as Run workflow with
cross-compilation (every native suite in full, reference, doc and GPU path tests, the whole
action matrix, property tests, web-offline, wasm, Windows FXC and startup), kernel-rig.yml
(every area and the ladder) and release.yml as a dry run (every package and its smoke
tests), and passes only when all three pass. release.yml can now be called (workflow_call).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kernel-rig.yml builds solidcraft-cli once (release, SMLib prebuilt; sccache on a sticky disk
that only pushes to main and develop commit) and hands it, with the rig's runner, to a matrix
of eleven shards: the ten areas of tests/kernel-cases/, each against its KNOWN_FAILING, and
the ladder against its golden. One path filter covers the kernel surface; drafts skip; a new
push cancels a pull request's old run; merge groups always run it, and the release gate calls
it. The areas other than fillets get a KNOWN_FAILING with only its header, to be seeded from
develop after the SMLib pin bump.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A pull request whose author is an owner, member or collaborator of the repository runs
Clippy, Native Linux tests, GPU path tests and the reference tests without the
approved-for-ci label, scoped to the affected packages as before; others still wait for the
label. The reference tests leave the pull request fast lane: they run when solidcraft-cli is
selected. ci.yml can also be called (workflow_call) by the release gate, and runs as Run
workflow does. Pushes, merge groups and the nightly run are unchanged.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
`cargo xtask kernel-cases --ladder --gate` grades every ladder case against
tests/kernel-cases/ladder/golden.json and fails on a changed status or count, better or
worse, or a case with no golden; times stay report-only, since they are the machine's. A
right change is re-recorded with --record "why" in the same pull request.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SMLib's parallel projection (CreateParallelProjectionCurves) gives every curve where the
projecting lines cross the face: a line projected down onto a ball came back as its top and its
bottom, each split at the pole, and the link's first wire was half the bottom. A projection onto
a surface is where those lines first hit it (owner's decision, as mainstream CAD does): a curve
is now kept only when the first hit on the body's mesh along the line through its middle is the
curve itself (within 4 chord tolerances), and the pieces that meet end to end are joined in
whatever order and direction they come, a piece run the other way exactly (its knots and
control points reversed; a line's, circle's or ellipse's parameter mirrored). The ball's top
is then one wire from x = -10 to 10.
three_d_sketch_curves now expects that exact curve: one wire, its ends at (±10, 0, √300), every
point of its exact curves on the sphere of radius 20 in y = 0 over the top, to the projection's
own tolerance (a millionth of the body's size), and sweeps_and_pipes_follow_3d_sketch_curves
pipes along the whole joined top. Both pass on the pinned SMLib (90aabff): the pieces lie 9.1e-6
off the sphere against a 4e-5 tolerance and meet at the pole within 4.7e-8 rad, since the fork's
8d95600 keeps the pole's exact tangent in StepBackFromSingularity.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
path_points took any wire with three or more fit points as a fitted spline, and a 3D arc keeps
its start, through and end points as its fit: the pipe along a quarter arc of radius 20 ran
along the cubic through those three points and came out 388.06 mm³, not π·2²·10π = 394.78.
A wire with its exact arc (Wire::arc) now goes to the kernel as that circle, from its start
counter-clockwise about its normal through its sweep (kernel::curve_path of the record circle).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Design defaults gains a Surfaces section with one setting,
surface_extrude_symmetric_per_side (off by default). When it is on, new
symmetric surface extrudes go their distance each way, as they did
before they matched solid extrudes. The app hands it to the session
before every command and each frame, and it stays with the user across
tabs and new designs, like the metric tap drill rule.
The Surface Extrude dialog now sends a feature's stored convention only
when the feature is already symmetric, so a one-sided one switched to
Symmetric takes the new reading, as in the solid Extrude dialog.
Labels in en, ar, he, ja, zh, de and ko.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A symmetric surface.extrude given no convention now splits its distance
evenly around the start plane (10 mm: 5 mm each side), the way
solid.extrude reads it, instead of going the distance each way. Both
commands take their default from one function, which a session setting
(surface_extrude_symmetric_per_side) can turn back to the per-side
reading for surface extrudes. timeline.edit and timeline.redefine give a
one-sided surface extrude made symmetric the same default.
Saved designs are unchanged: every surface extrude saved its convention
(legacy_per_side), and one saved before the marker existed reads per side
as it always did. The help of both commands says how the distance is
read. The 3830 kernel case, recorded with the per-side reading, now says
so explicitly.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
tangency-labs/smlib#57 on top of 60b1c6a. It fixes the two engine tests the earlier pin broke:
press_pull_on_curved_faces and a_shell_fillet_does_not_follow_a_gone_edge_onto_a_smooth_seam,
with their expectations unchanged.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The barrel's arc has its centre across the axis, so its side is the inner (lemon) zone of a
spindle torus, which SMLib's torus does not describe (its meridian is on the X side): SMLib
(revolve-spindle) sweeps it as the exact rational surface of revolution. shell_of_a_revolved_barrel
asserted an analytic torus of major radius -10. As the owner decided, it now asserts what
matters: two flat caps and the curved side, the closed-form volume, 14 mm round at mid height,
and after the shell the two offset faces (the inner wall and floor; truck's side was in halves).
Needs SMLib with revolve-spindle (pin bump).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Drafting a cube's side about its bottom edge (on the neutral plane) tilts the side and moves the
edges it shares with the top and the two faces beside it: those four are trimmed differently
(Modified); the bottom and the opposite side are untouched (Kept). Truck called all six
Modified; SMLib's history called the moved neighbours Kept. Needs the SMLib fix "history: a face
whose edges an operation moved is Modified, not Kept" (SMLib branch devgreen-kernel-records,
cdaf205) and a pin bump.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
From 7e917f0 to 60b1c6a on tangency-labs/smlib replay/1.0.1, 45 commits in 43
pull requests:
- Booleans (#28, #29, #34, #39, #45, #47, #55, #56): a coincident edge split with
its edge, a plane grown to cover a face however far, a seam point classified to
its face, intersection loops closed only along edges that lie on each other,
curves inside one ProtoVertex split at its vertices, an intersection along a
face's own edge taken as that edge, a plane a hair into a cylinder touching it
along one line (and crossing it in two), faces and loops apart not intersected.
- Transforms (#48, #49, #50): a mirrored cylinder read back from its NURBS turns
the right way, a rotation or reflection keeps every tolerance and a scale
scales them, a scaled body's model size is measured from its geometry.
- Fillets and chamfers (#24, #30, #51): a chamfer round an arc is a cone, a gentle
corner in a variable radius splits the round, a seam round's corner ball sits
where the cylinders' axes meet.
- Shell and offset (#17, #22, #23, #25, #26, #32, #38): closed faces and closed
sheets offset, exact lines and conics between analytic faces, cones and
cylinders extended as themselves, a cone's apex offset as a sphere, a wall
that would turn a face inside out refused, neighbours extended to reach a
face moved past the body's size, an open edge's trim point on a closed curve.
- Draft (#27, #53): a cylinder along the pull drafts to a cone, a cone about the
pull to the cone its turned generators make.
- Sweeps (#14, #31, #36, #37, #40, #43, #44): a whole turn of a holed profile
leaves the void, a curve near a circle swept as itself (text outlines' Béziers
pass the check), an arc centred across the axis revolves to an exact B-spline
surface of revolution, a minor circle on the axis and a horn torus, line and
arc paths swept exactly piece by piece.
- Surfaces (#18, #19, #20, #21): a B-spline starter in Bezier form, extend by the
distance across the surface and as the same cone or cylinder, untrim in place.
- Intersections (#35, #46, #52): a curve into a pole keeps its tangent, a periodic
value just past the top wraps a period down, a curve from a singular point
starts inside.
- Checks, history, measure (#15, #16, #33, #41, #42, #54): a face whose edges
moved is Modified, SMLib's warnings are no failed test, sheet faces count in
the area, internal poles sought in the knot's row, a collapsed seam not
classified, a small loop oriented on the surface's scale.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SMLib now sweeps a curve within the tolerance of a circle as itself, not as that
circle's cylinder (tangency-labs/smlib#31, 3cfbbdd), so the offset curves' pieces
meet with one curvature at every wall join of the ring (the largest curvature
jump 4.2e-7): all 512 are smooth, where 400 were and the other 112 jumped by
0.9-3.6%. The comments that said the pieces meet only tangentially, or at small
real creases, go.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
With SMLib integration-overnight + b78bd4a (the fixes of 2026-10-29), three
expectations that held a refusal now build, each checked against its exact answer:
- rig fillets/1207-fillet-box-end-edge-into-unblended-round (was ...-refused): the end
face's top edge of a cube rounded r3 along its top back edge, rounded r1 alone
(tangent chain off), builds. Its round runs on along y through the r3 round's end
until that surface drops below it at y = 17 + sqrt(5): V = 8000 - 20 (9 - 9 pi/4)
- 17 (1 - pi/4) - 0.218236 = 7957.505202 (the last term the section under the round,
integrated exactly); SMLib gives 7957.505245.
- blend_smlib smooth_edges_and_unfinished_tangent_chains_are_refused_saying_why: the
same cube builds, at that volume.
- modify_history_tests::smlib::draft_tilts_a_side_and_keeps_its_name: the rod's side,
a cylinder along the pull, drafts 5 deg to a frustum, radius 5 at the neutral plane
and 5 - 10 tan 5 deg at the top, at its exact volume.
tests/kernel-cases/fillets/KNOWN_FAILING drops 1557-fillet-vertical-corners-after-
bottom-rounds, which passes now; the other eight still fail, so the gate holds
(81 pass, 8 known failing, no regression).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Since an operation's result is its record (f11c0c571), a mirrored body is
SMLib's transform read back from SMLib's export, and two SMLib defects there
made it invalid: a mirrored cylinder came back inside out the wrong way
(SmCylinder::IsNurbSurfaceCylinder; its edges 10 to 30 mm off the surface),
and every edge's own tolerance was reset to the body's (SmBrep::Transform).
Both are fixed in SMLib (fix/mirrored-cylinder-from-nurbs e02e63e, c603293,
with e008e82 for a scaled body without vertices);
this test needs the SMLib pin moved past them.
A plate with a through hole and a box with two rounds meeting at a corner,
mirrored in x = 30 and read back from their records: SMLib finds both valid
and their volumes are the originals'.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
notch_into_a_ring_chamfer_is_cut_exactly measured the notch as the ring's mesh volume before less
after (0.2906 against the integral's 0.28665) and oblique_cuts_through_a_chamfered_ring_are_exact
compared the two mirrored cuts the same way (3.3e-4 apart). The cut is right: the ring less the
cut ring is a piece of 0.2866521 mm³, the integral to 2e-6. A difference of two 1149 mm³ volumes
is not: the re-tessellated ring's mesh volume moves by 4e-3, and SMLib's mass properties (at
their finest, 1e-4 asked) by 1.5e-6 of the ring, 1.7e-3. Each cut is now measured as the piece it
took away (the ring before less the ring after, an SMLib boolean), to 1e-5 of the integral and
1e-6 between the two mirrored cuts.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SMLib keeps a whole cylinder one face and the arm's round end and the boss over it (one
cylinder) one face, named for the arm's end. Three naming tests relied on truck's pieces:
- a_cut_through_one_of_two_bosses_names_only_its_own_walls finds the boss's wall by a point
on it (the centroid of truck's half cylinder lies on nothing now) and checks it keeps its
name through the cut and the fillets;
- split_pieces_keep_their_numbers_across_evaluations keeps the torus (its sweep's walls are
whole now, their names stable) and adds a disc whose top a round groove splits into
F1:top#1 and #2;
- a_design_saved_before_pieces_were_numbered_by_place_keeps_their_numbers uses that disc,
whose kernel order numbers the pieces the other way round from their place (the post's
side of multi-body-join-cut is one face now).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- shell_tangent_chain_that_opens_every_face_explains_how_to_keep_walls: the shell is the
rounded box (its 37 x 27 x 57 core grown by the 1.5 ball: 71753.436) less the sharp 36 x 56
x 28 cavity, 15305.436, to the measure's 2e-7 (SMLib: 15305.445); truck's was 15305.28.
- press_pull_on_curved_faces: the shell's inner wall behind a fillet is offset as a face
(SMLib builds it, truck refused it as tangent to its neighbours): pulled 0.5 into the
cavity it adds exactly the quarter ring π/4 (3² - 2.5²) 18 = 38.877.
- revolve_cut_round_a_box_corner_does_not_panic: the side face is picked by its point; the
report's face index was truck's face order (SMLib's face 1 is the opposite side).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SMLib keeps a whole cylinder (and an arc of one past half a turn) as one face closed on its
seam, where truck split it in two; its holes are exact circles; its mass properties come
within 2e-7 of a closed form. The tests that counted truck's pieces or its polygon hole now
check the exact geometry:
- extrude_of_adjacent_profiles_has_whole_edges: the cut-off cylinder is 4 faces (arc side
4674 = 40·(2π − 1.2019)·23, chord side 1039.8, two ends);
- step_export_of_an_enclosure_with_a_screw_hole: 27 faces, as the file holds them;
- model_faces_gives_a_point...: the hole's wall is one cylinder, its centroid on the axis;
- draft_takes_a_cylinders_side_by_name: one side face (the draft itself waits for SMLib's
draft of a cylinder);
- convert_to_sheet_metal_takes_the_plates_face_by_name: 15000 − 62.5π to the measure's 2e-7;
- a_checkpoint_survives_file_new: a unit box measures 1 + 2e-16;
- creating_a_component_recomputes_nothing: SMLib's boolean keeps the face certificate the old
setup relied on losing, so the legacy face plane is made as a design saved before face
attachments were certified (its anchor removed) and reopened.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Since the section hatch per part (#8529), a cut is tinted toward the hatch colour its body's
name picks; Body1 picks the steel one, so the cap test's warm pixels were none
(cpu_picture_section_caps_hide_the_inside). The test turns the part hatch off: it checks that
the cap hides the inside and shows its colour, which the hatch tests cover per part.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
solid.shell takes faces: [] since 1df330c79 (a closed hollow body), so its row in
shared_types_keep_the_handlers_messages no longer matched the shared FaceRefs message. The row
uses solid.draft, which still refuses it; FaceRefs says shell's exception.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SMLib makes a torus one face, so the face at (25, 0, 0) was the whole torus,
not a patch within half a turn each way. The patch is now the torus's piece
with x, y > 0 and z > 1, bounded by iso lines both ways (planes through the
axis, and z = 1 round the tube), and its thickened volume is the formula's
over the angles its mesh spans. (The sphere cap above it builds once SMLib's
offset takes an open edge's second trim point away from its first: SMLib
devgreen-kernel-geometry; waits for the pin.)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SMLib thickens a sheet across a convex sharp edge as other CAD does: each
face's offset is extended until the offsets meet (and trimmed where they
cross inward), where truck bridged the gap with a wedge. Owner decision:
keep SMLib's result. The exact values:
- three faces of a 10 box's corner out by 1: three slabs, a 1 × 1 × 10 block
along each edge and a unit cube at the corner, 300 + 30 + 1 = 11³ − 10³;
- into the inside corner by 1: 10³ − 9³ (it was refused); half each way:
10.5³ − 9.5³ (refused too);
- two faces across one edge: 2 · 100 + 1 · 1 · 10 = 210.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A sweep along points follows the lines between them (no wall is fitted through
the points, sweep_sheet_points' contract, as sweeps_along_3d_paths already
says): along a quarter circle of 41 points the sheet is a wall per line, 40,
its area 10 × the polyline's length (within 10⁻⁴ of 10 × 15π); the bent chain
is 2 × 40 walls sharing every seam, 2·41 + 3·40 edges.
SMLib's sweep takes guide rails along a cornered path when each rail turns
with the path at its corners; a straight rail along a bent path is refused
for that reason, not as "guide rails along a path with sharp corners".
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SMLib revolves the cone frustum's sheet over angles 0…1 as one face, where
truck made two of half a radian each; the face's own span is angles 0…1 by
profile parameters 0…0.8: √125 · ∫₀^0.8 (5 + 5t) dt = √125 · 5.6.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SMLib makes a cylinder's side one face closed round its seam, and a sphere one
face; the tests picked "one half" of the side or "one sixth" of the sphere, which
were truck's pieces. The offset test moves the whole side (one face, area
2π·12·20); the thicken test takes half the side from a cylinder split at x = 0
(π·(11² − 10²)/2·20) and the whole side inward (π·(10² − 9²)·20); the sphere
test takes the cap above z = 5 (solid angle π: π/3·(11³ − 10³)).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
prism_measure's uncertain-material check built a 20 x 20 x 1e-5 box and asked that it get no
cap certificate. SMLib refuses that box (its loops fail SMLib's orientation check): at 1e-5 it
is half a body's tolerance (2e-5) thick, no solid. Refused or built without a certificate, the
property holds.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
edge_at (matchsurf) and the mixed fillet mitre check evaluated `e.curve` at parameters from
`e.interval`, which is the interval on the edge's NURBS form when it has one (SMLib's edges
do): they picked and sampled the wrong points. They now evaluate `e.parameters()`, as the fill
helpers do since aa534cc6d's fix on the kernel-geometry branch. (Both tests still fail, for
their own causes: the G2/G3 match leaves a curvature jump of 2 at the seam, and SMLib's mixed
blend lies 4e-7 off its section circle.)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Truck split what it swept: a big arc into two faces, a full circle into halves, a turn into
two or three parts, a sphere into six patches, a torus into six; it numbered boxes' faces in its
own order and sewed stepped cuts slab by slab. SMLib sweeps each profile segment into one face,
closes a full cylinder, sphere or torus along one seam edge, and cuts without slabs. The record,
face source, helix, display mesh, measure and boolean history tests still expected truck's
pieces. Each expectation now follows the geometry, checked by the tests' own independent
measures: every face's origin against the profile segment its mesh lies over (unchanged),
faces picked by where they lie instead of by truck's face numbers, and the merged counts by the
kernel-cases ladder's rule (each whole curve once, and each cylinder's seam): a cylinder 3
faces, 3 edges, 2 vertices; a ball cut from a slab 7, 14, 10. The truck-only stepped-prism
check (walls coalesced across slabs) becomes the property it stood for: the stock's walls stay
whole, one face each, Kept.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Seg2::closest_param starts Newton from the nearest of 65 samples. On a closed segment (a full
circle) the start and end samples are one point and the first wins the tie; for a point just
before the start (in the sweep's sense) Newton then wants a parameter below 0, the clamp holds
it at 0, and the answer is the start point, off by up to a sample spacing (0.15 mm on a 5 mm
circle). The record tests' face-to-segment matching read an SMLib cylinder's side as lying
over no segment because of it. A closed segment whose answer lands on an end now also tries
Newton from the other end and keeps the nearer; every other answer is bit for bit as before.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
picked_edges_give_the_sketch_s_table picked [E + R, 0, 5]: on SMLib's extruded circle that is the
vertex where the side's seam meets the top rim, a pick either edge answers, and it took the
seam. The pick is now a quarter turn round the rim, [E, R, 5]; the product's pick rule is
unchanged (owner's call).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
a_face_picked_by_point_on_a_block_with_a_modelled_thread_is_found guarded #6720 (the face search
charged the whole mesh once per face) with a modelled thread's 5 000 facets. On SMLib a modelled
thread is a few exact helical faces, so the block had nowhere near the 1000 faces the test
asserts, and the case no longer reached the old charge. A block drilled with 16 x 16 holes does:
the test now asserts its faces times its mesh's triangles is past the search's 2 000 000 budget
(the old charge) while their sum is well inside it (the new), then picks its top by point.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
intersect_keeps_its_exact_cuts pinned the tilted cylinder's section to 21 segments and one
segment's ends to 1e-4: the crossings of truck's mesh. The cut is the mesh's segments, as many
as the tessellation crosses (20 on SMLib's), each end within the section's reach of the surface,
the display tolerance (a thousandth of the mesh's size, doc::project::fit_segments; SMLib's ends
lie 6e-4 off at most, the test's limit is 0.051). The test now checks that every curve is a
line, at least 16 of them, and every end lies that close to the cylinder of radius 5.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ids_names_suppression_marker_and_failures_survive needs a feature that a parameter change makes
fail, to see the failure survive the script's replay. It made a 1 mm round 50 mm, which truck
refused as too big; SMLib builds a convex round wider than its faces by subtraction (the owner's
overflow decision), so that round now succeeds. A radius of -1 mm fails on any kernel, and the
replay still has to keep the failing feature, its id and its marker.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
a_whole_sketch_section_stays_whole_through_an_edit compared the ring member's volume before and
after turning its section 30° to 1e-6. kernel::measure integrates at SMLib's finest relative
accuracy, 1e-4 (measure::ACCURACY, the clamp SmApiBrepComputeMassProperties documents): the
exact π (20² − 17²) 600 = 209230.07 mm³ came out 209229.86 before and 209230.43 after. The
test compares to 1e-4; the filled circle it guards against is 3.6 times the ring.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- An SMLib circle edge's `interval` is on its NURBS form (`Edge::parameters`), and an analytic
face's `domain` on the form's (u, v). edges_are_on_smlibs_curves evaluated `curve` at the
form's interval and took the domain for angles; it checks the side's whole turn and height
on the form and a rim's turn by `curve_interval`. The tangent hole test's edge middles were
read the same way (the copy seemed to join faces on opposite sides of the line).
- kernel::chamfer blends the edges it is given; a feature's pick is extended by
kernel::tangent_chain first (doc eval). The chamfer tests do the same:
one_chamfer_pick_follows_the_tangent_chain_at_any_part_size removes its 54.66 mm³ again.
- Since the section hatch per part (#8529) a cut is tinted with the hatch colour its body's
name picks (Body1: steel); the GPU cap test turns the part hatch off, as the CPU one does
(2885f101b on devgreen-engine-builds).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
truck made a cylinder's wall and rims in halves; SMLib makes one wall face and one closed edge
per rim (one face per profile segment, a circle being one closed curve since 09c979a4b). The
tests of what joins a rim's or a wall's pieces for picking, measuring and the agent chat
(circular_rim_hover_click..., circular_items_measure..., curved_face_hover..._cross_the_seam,
a_rim_clicked_once_is_one_item_not_its_pieces) now build their cylinder from a circle drawn as
two half arcs, extruded, so the pieces they test exist. A ring's outer circle is one wall face
(configuration_annulus_picker...: 1, was 2). The certified small crease is no longer taken for
a seam (truck's coarse fit did; the seam flags compare exact surfaces now) and, a kink of a
millionth, is smooth for the shading while still a measured crease: sharp, drawn in wireframe,
picked (smooth_edges::Join).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- The shaft's rim was picked at its polyline's first point, the vertex where the wall's seam
meets it, as near the seam as the rim; SMLib's cylinder lists the seam first, so the pick
took it ("the edge is not circular", "the revolve axis does not lie in the sketch plane").
The rim is picked at its middle.
- The gear discs touch at x = 10, on both walls; G1 is picked on its far side.
- 366b90597 refuses a thread of some length picked in the middle of a face free at both ends
and asks for `from`; the cosmetic thread test gives it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Builds before format 14 named the pieces a cut splits a body into in truck's shell order, and
the later features of such a design name the piece they work on by that name. SMLib orders the
pieces otherwise, so split-body-pieces' fillet and chamfer landed on the wrong piece, its
reference "no longer exists" (design_corpus body_names_saved_before_exact_history_keep_their_pieces,
old_designs_open_and_evaluate_as_saved). For a feature saved so (`shell_piece_order`), each
name its pieces are known by goes to the piece the points the later features naming it picked
lie on; a name no later feature uses keeps SMLib's order, and so do all of them where the picks
do not tell the pieces apart. docs/compatibility.md says so.
That makes the feature's result depend on features after it, which neither its fingerprint nor
its cache key cover: a script replays the design one feature at a time, so the split was
evaluated before the fillet and chamfer existed, kept SMLib's order, and was reused once they
came (script_roundtrip corpus_designs_replay_from_their_scripts: 'Body1 (1)' 4765.663706234679
opened against 4765.663706134907 replayed). The state now keeps a digest of the picks it named
the pieces by (`ModelState::legacy_picks`), and every reuse (the last results, the cache, the
kept, rolled-back and primed results) takes a state for such a feature only while the design's
later features pick the same, so the replay names the pieces again as the file does when it
opens. A saved model's states carry no lineage and are taken as saved.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SMLib's draft extrusion takes one loop, so a tapered extrude of a region with holes was refused
("SMLib draft extrusion of a profile with holes"), and designs that use one no longer opened
(modern-plastic's Rest: design_corpus, action_matrix a_small_hole_through_the_wall_of_a_plastic_rest).
As other CAD does, every wall now leans by the taper relative to the pull on the material's
side: the outer loop is drafted, and each hole, taken counter-clockwise, is drafted the other
way and cut from it, so a taper that narrows the outer boundary widens the holes. Exact: each
loop is SMLib's draft extrusion of it, the walls' roles are found as the foot's are. Refused,
saying why, where the taper would make a hole meet the outer wall or another hole at either
end of the extrusion.
Test: a 40 mm square with a 10 mm square hole, 30 up at 5° inward, is the one frustum less the
other to 1e-6 with ten faces; at 30° the hole would pass the outer wall and is refused.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
17-loft's expected values were FreeCAD's (OpenCASCADE's Part.makeLoft), which runs each side of
the square to its quarter of the circle at uniform angle (arc length). That correspondence has
no exact rational B-spline form, and SolidCraft keeps its surfaces exact: its ruled loft runs
each side to one rational quarter of the circle's B-spline by their own parameters, 35080.7251
mm^3, 0.13% less (the oracle failed on volume and the second moments). The owner chose this
correspondence. The case is now worked out in tools/oracle-analytic/cases_basic.py: the section
area is quadratic in t with the loops' mixed area, so volume and centroid are closed forms of it
(the mixed area and the wall area by Gauss-Legendre on the exact rational arcs); its note says
why it differs from OpenCASCADE and gives that volume, and its `compare` leaves out the surface
check against OpenCASCADE's reference.stl. All its checks pass.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
chamfer_the_top_lip_at_a_tangent_wall_junction measured the removed volume as the difference of
two meshes at chord 0.0005. The display planner meshes the two bodies differently, so their
chord errors no longer cancel as truck's meshes did: 37.404, 37.672, 37.761 and 37.759 mm³ at
chords 0.002, 0.0005, 0.0001 and 0.00003, converging on the expected 37.762 (the chamfer as the
chord between the contact lines of a 2 mm ball, integrated exactly). SMLib's chamfer is that
one; the test measures at chord 0.0001.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The display mesh is the tessellation planner's (8b6bfc48c: the mesher plans a schema 4
record), which grids a planar face with no side longer than a fifth of the body's extent
(docs/capabilities.md, "Display meshes"); truck's mesher gave a box face two triangles. The
tests that counted truck's mesh now count the planner's, worked out by hand from that rule:
- a 10 x 20 x 30 box (37.4 mm diagonal): edges in 2, 3 and 5 pieces, faces of 2 x 3, 2 x 5
and 3 x 5 cells, 124 triangles; welded, the box lattice's 3 x 4 x 6 nodes less the
1 x 2 x 4 inside it, 64 positions (obj_export_is_welded_and_keeps_names);
- a 20 x 15 x 10 box: 4 x 3, 4 x 2 and 3 x 2 cells, 104 triangles (an_opacity_class_change...);
- a 20 x 20 x 10 box saved as a mesh: its edges in 4 and 2 pieces, 40 segments per box
(imported_mesh_edges_draw_in_each_style...);
- the cylinder's top cap is under a third of its triangles (select_other_over_a_dense_cluster...).
An imported mesh's outline was one line per crease side, so a box exported at that spacing
showed each edge in pieces: a click on a 10 mm edge measured 5 mm, or hit the node between
two pieces (measure_imported_stl_edges_and_vertices..., mesh_outline_hover_cache...). Outline
sides that run straight on through a vertex no other outline side meets are now one line, as
the CAD model's edge was.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A face's edges are projected exactly: lines, and arcs read off SMLib's NURBS within the
planar-edge tolerance (Body::planar_edges). An SMLib shell's offset corner is a NURBS whose
arc came out with its centre 2e-6 mm off and its ends up to 6e-7 mm from the lines they meet,
beyond the link's merge tolerance (1e-7): the inner loop of the sensor enclosure's case top
projected as sixteen loose curves, the offset of one found no chain to follow, and the Lid lip
extrude found no profile l13..a16 (the five acceptance scenarios, action_matrix
an_axis_through_a_corner_round_that_a_parameter_moves). Each edge's pieces now end on the
edge's vertices where they lie within the edge's and the reading's tolerance of them (the
vertex is the point both edges share), and an arc whose ends moved takes the centre nearest
its own that is equally far from both, so the sketch keeps both ends on its circle.
Body::planar_edges_tolerance names the reading tolerance planar_edges uses.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A round face's box (form::extent) unwrapped each periodic parameter from one boundary point to
the next. Through a pole the loop goes on from anywhere round the direction the pole collapses:
a hemisphere bounded by its rim and its seam put its second seam use on the first and its box a
quarter turn off the seam, while its pcurves ran from the seam. Past the first pole the loop is
now moved the whole periods that close it. Reference case 14's re-imported dimple had a
quarter of its area missing (9601 against 9706 mm2).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A field scrolled out of a dialog's field area still published its handle at the centre of its
whole rect. The tapped hole's dialog has grown (thread hand, tap drill, thread end rows) past
1000 px, so its section's Thread depth field scrolls under the footer, and a click on that
handle pressed OK: the edit was applied (tapped_thread_depth_field_keeps_focus_and_typing_...
saw the model change at the click; focusing a field commits nothing). A field's handle is now
the middle of its visible part and is left out when none of it shows, so a scenario can only
click where a user could; the rect keeps its whole extent. The test opens a window tall enough
for the section.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sketch::bounds took the points of each segment's polyline. Since 09c979a4b a whole circle is
one closed arc whose chords start at its start angle, so none lands on the circle's left or
bottom: a radius 5 circle at (-300, 0) spanned x from -304.50, and Home and Fit framed short
of it (home_and_fit_frame_the_moved_body_not_its_old_place). An arc's bounds now add the
quarter points of its circle it sweeps through, which are exact.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
checked_field, checked_row and warning_caption (the fillet Setback check), text_field_tip (tap
drills), continuity_row, continuity_row_explained and continuity_tip (the continuity choice) and
steps (opening progress) are pub(crate) ui_kit functions with no gallery entry, which
gallery_covers_every_inline_element requires of every one.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
help.version (help-menu-version) and prefs.section_hatch* (section-hatch-by-part) came with
ja and zh only; ar and he are complete catalogs too, so
every_complete_catalog_carries_every_english_message failed on them.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
be859aa0d added `colors::ISOCURVE` to the engine palette; the GPU viewport draws iso curves in
the theme's accent (`scene_palette`, the isocurve pass), so the engine value is only the
headless snapshot's, like the body and grid colours. every_engine_colour_tag_is_placed lists
it with those neutral tags.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
9a7958857 (placing the model returns its error) passed the legend the whole viewport rect
instead of the bottom overlay rect that clears the floating History card, and slid the
placement note's doc comment in between the legend's comment and its function. The legend is
laid out in the overlay rect again, as the frame rate readout is, and each function has its
own comment back (bottom_readouts_clear_floating_history_on_the_first_frame).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
a_face_engraved_with_text_projects_its_letters_exactly_and_extrudes counted the letters' pieces
as control-point splines. A TrueType outline's curves are quadratic Béziers, which are parabolic
arcs, and the cut made on SMLib keeps them exact: the projection gives 222 conics and 154 lines,
no splines. The count now takes conics with the splines. (The cut itself needs SMLib 1a1bebc;
with it the test passes.)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
loft_cut_through_a_shelled_basin_in_either_order asserted one body. The loft's top section is
the basin's full 100 x 60 outline at z = 10, so the cut takes the walls' whole cross-section
there and leaves the walls above (z 10 to 30) touching the rest only along their outer rim, an
edge: two pieces, which a cut makes two bodies (eval's lumps rule). SMLib gives exactly that;
truck kept them as one. The test now expects two bodies, the upper one the walls' exact
924 mm² ring times 20 = 18480 mm³, and the total as before (41582.028).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
a_face_sketch_saved_with_fitted_letters_reopens_and_builds_the_same compared the part with the
5916.018831 mm³ its saving build measured, to 1e-3. The part is the 30 x 20 x 10 block less the
"S" 1 deep and an r 2 circle 3 deep clear of it: 6000 - 46.290121 (the letter's exact profile
area, Sketch2's smaller region) - 12 pi = 5916.010767. SMLib measures 5916.010768 (1.2e-6 off);
the saved figure was 8e-3 off. The test now checks that closed form to SMLib's 1e-8, and counts
the letter's exact pieces as conics or splines (its quadratic Béziers come in as conics).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
map_planar_sources took every plane of a cut's tool as competing with an input face on it,
facing either way, and dropped that face's exact role. A text pocketed 1 mm down from a block's
top has its tool's top on the top's plane facing up, as the top does; the top then lost its
CertifiedExtrudeCap, and the sketch on it reported "the top cap of Extrude1 no longer exists"
(a_face_sketch_saved_with_fitted_letters_reopens_and_builds_the_same). A cut's tool faces enter
the result turned round, as the walls of the hollow, so a tool face can only take the place of a
face on its plane facing against it (a pocket's floor, a face the tool sat on from outside). Only
that orientation competes now; the existing blocking cases (a tool's bottom on a pocket floor, a
tool face against a wall) are unchanged.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
unsupported_face_has_explicit_fixed_alternative_and_no_live_projection needs a planar face with
neither a construction certificate nor an exact history name, so a sketch on it must be fixed.
Its face, a split top face offset up, now keeps its history through SMLib's offset and gets a
name. A rib reports no roles for the faces it builds (Traced::unnamed, eval_more), so a rib's
wall has neither: the test now picks the wall at y = 12 of a rib in a bracket's corner.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
interference_lists_a_pair_it_could_not_check needed a pair interference cannot check. Its
pair, an arc revolved up to a post's wall, was one truck could not intersect ("not verified");
SMLib intersects it exactly, and that reason is gone from the code. The pairs left unchecked
are a kernel failure, the time budget, and a mesh body: an imported mesh has no exact surfaces
to intersect (owner's call). The ring is now brought in as an STL beside the post, and the pair
is listed with "mesh body: not checked" instead of passing as clear.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
freezing_rebuilt_arc_borders_keeps_authored_dimension_entity_indices needs the projected
border of the sketch's face to come back with a different number of curves. Truck split the
sector's arc into pieces that changed with its sweep (270 to 300 degrees); SMLib keeps one arc
whatever the sweep, so the count stayed 3. A notch, clear of the sector until a parameter moves
it across the arc at 90 degrees, now splits the arc border into two arcs and the notch's sides.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
same_support took two planes as one support only within 4096 ulps (normals 9e-13 apart,
origins about 1e-12). Faces SMLib rebuilds through a boolean lie within its own resolution of
the plane they were made on, not within ulps: a cap at z = 10 notched by a cut came back with
its origin 2.1e-11 off and its frame turned 1.36e-12 rad, so its CertifiedExtrudeCap was
dropped and the sketch on it reported "the top cap of Extrude1 no longer exists".
Supports are now compared at SMLib's own coincidence rule, SmPlane::CoincidenceCheck: normals
within the angle the tolerance makes across the plane (`tolerance / size`) and each origin within
the tolerance of the other plane, the tolerance being the record's `tolerance` (SMLib's per-brep
XSectTol3d, the one its booleans test surfaces for coincidence with). The body's size stands
for the plane's extent (at least as large, so no looser); rounding stays the floor. The normal
window the candidates are searched in follows the same angle.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The truck booleans answered a tool clear of the body without intersecting (the operand kept,
its record shared). The SMLib boolean always rebuilt the body, so a cut that could not reach a
body still handed back a new record: a hole far from a second body reported that body changed
(#2904's test), and a body clear of a pocket's cutter was no longer the same solid. A cut or
intersection whose operands are apart (their exact boxes, grown by twice the tolerance as
union_apart takes them, do not meet) now gives the body itself with its faces and edges kept,
or nothing, with no SMLib call.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- A section's chains are walked from either end, whichever segment the mesh's triangle order
puts first at a node (doc::project::fit_segments), so a line's direction says nothing about
the cut. SMLib's box tessellates in another order and the outline came out clockwise: the
same four lines. The two box-outline tests now compare each line with its lower end first.
- The base rim of SMLib's cylinder is one closed circle edge (truck's was two seam halves), so
projecting it gives one exact ellipse. Checked against the closed form: a radius-5 circle in
a plane tilted 45° projects to semi-axes 5 and 5·cos 45° = 3.5355339 (the reported minor
radius), and every sampled point lies on x²/(5/√2)² + y²/5² = 1 within 1e-9, as before.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Linking a reference (sketch.include_3d, project, intersect) stored the link's wires as points
only: add_link_unless_present called add_link_with_wires and dropped the resolution's exact
curves, which only the next refresh of the sketch filled in (doc::project, since 7952516eb).
So an included box edge had no exact line until any edit refreshed it, and the wire changed
under an unrelated sketch edit. The exact curves are now set with the wires when the link is
made, as a refresh sets them.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Two readings of the SMLib record went wrong in emboss_cylinder:
- The footprint arcs were labelled on the sketch's radial frame. The assembly gives each new
circle edge the NURBS form on its label's quarter grid, and the wall face keeps its own form on
its frame's grid (a cylinder's seam lies at an odd angle, build::SEAM_ANGLE). The two grids
differ by a non-quarter turn, so the arc's form is not a straight line in the face's (u, v)
and no exact pcurve exists: "no exact pcurve of a NURBS on a spline surface". The arcs at the
wall's radius are now labelled on the wall face's frame (form::on_frame), so their forms lie on
the face's grid and the pcurve is exact.
- wall_angles took the edge's interval as the circle's angles. On an SMLib record the interval
is on the edge's NURBS form (2πr long for a whole turn), so a wall spanned some 63 rad: a
profile across the seam was accepted, and a wall of radius 0.1 was refused as off its seam.
It now reads Edge::curve_interval.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A face that meets itself along a line (the Pinch case's boss side, turned 30 degrees: the hole's
wall touches it along a vertical line from the hole's bottom to the top rim) has its loop run up
that line and back down. Its motorcycle trace runs from the slit's tip to the bottom and the
iso-line grid meshes it, but the band between the grid cells and the boundary was filled by a
parity flood that flipped at every constraint, the slit's too: the band on one side of the slit
was taken for outside, the face did not follow its boundary, and the lenient fill took over.
The band now crosses a side the loops run along both ways without counting it, as the
triangulation itself already did. Delaunay's sag refinement had the same flood and left the far
side of a slit unrefined (the lenient fill's 0.52 mm^3 shortfall); it takes the slits too.
The Pinch case now meshes strictly: the boss side is 628.3177 mm^2 against 200 pi = 628.3185, and
hole_tangent_inside_a_stepped_boss_cuts_exactly passes. New tess test: a square with a slit
meshed by the cut grid follows the slit both ways and covers the square's area exactly.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Where a face meets itself along a line (a hole's wall tangent inside the wall round it: the
boss side touched by the hole along a vertical line, run up and back down), its loop runs along
that line both ways. The triangulation's region test flipped inside and outside at every
constraint side, so crossing the slit put the face's far side outside it; the follow check
wanted every boundary side under exactly one triangle, where a slit has one each side. Sides the
loops run along an even number of times no longer flip the region, and the follow check wants a
triangle per run. (The Pinch case's boss side still falls back to the lenient fill, now within
0.52 mm^3 of the exact 8717.92 where it was 340 short; the strict fill's remaining mismatch on
the seam-cut face is open.)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A ring whose inner circle touches the outer one (a boss standing on a disc, tangent inside its
rim) is one loop through the touching vertex, both circles leaving it along one tangent. There
the inner circle's first node falls on the outer circle's last chord whenever the outer chord is
twice the inner (exactly but for the next order: the inner circle at s rises s^2 / 2r, the outer
chord at s/2 of its length rises L^2 / 8R, equal for L = 2l, R = 2r), as the samplings fell
here. No crossing by the untangle test, but no triangulation can keep both as constraints: the
strict fill refused the face, and the lenient one, dropping constraints, filled the inner disc
(314 of the ring's 942 mm^2, the Pinch test's 1047 mm^3 shortfall). A node of one chord lying on
another (inside it, not at its ends, and not two chords along one line, as a seam's two uses a
period apart are) now has that chord halved. Regression test: the ring meshes strictly, to
300 pi.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fillet_an_open_curved_edge, fillet_sharp_arc_and_arc_loop and
fillet_mixed_arc_and_line_removed_volume_converges took the volume a round removes as the
difference of two mesh volumes, which magnifies their sag (each mesh lies within its chord of its
faces, so the difference can be off by both areas times the chord: for the r 0.25 round at a
1e-4 chord 1.8e-3 of what it removes). Measured exactly (SMLib, 1e-8) the rounds are right:
the open curved edge's removal 25.7629198 against Pappus' 25.7629199, the sharp arc loop's against
its lens quadrature, the mixed joint's 2.7155830 and 0.6842666 against the reference 2.7155785 and
0.6842658 (1.7e-6 and 1.2e-6: the blend's own fit, whose section error the joint test reports).
The removals are now exact, the mixed one held to 1e-5 of the reference; the meshes' removal is
held to its chord bound of the exact one.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Support::station reads the curve leaving a boundary from five samples: one-sided where the
support ends at the station, central where the surface goes on past it. The central five-point
formulas had the first and second derivatives' signs reversed ((-f0 + 8 f1 - 8 f3 + f4) and
(f0 - 16 f1 + 30 f2 - 16 f3 + f4) over 12h, 12h^2, the negatives of the standard ones), so the
curvature read there pointed away from where the surface bends. Truck's half cylinders ended at
every picked line and read one-sided; SMLib's cylinder is one periodic face, the seam is inside it,
and the central branch read the wall bending outward (+radial / R): the G2 and G3 matches to it
built sheets bending the wrong way, and the continuity check, reading the same frames, called
them G2. The central formulas are now the standard ones.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
a_split_in_the_plane_of_a_face_keeps_all_of_the_body held the two parts' volumes to the body's
within a millionth, each read from a mesh at a 1e-3 mm chord. Nothing was lost: the parts came
out at exactly the closed forms (780.3707 and 1035.2797 for the 5 mm groove, 1815.6504 together);
the whole body's own mesh sagged 0.0034 mm³ short of that round the hole, twice the millionth.
They are now SMLib's exact volumes (1e-8).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
measure now integrates to SMLib's finest relative accuracy, 1e-8 (da57f37e5, cherry-picked from
the engine-commands branch), not 1e-4: the mirrored bracket's union and twice its half, each an
integral good to 1e-8, agree to 2e-8. (The test stops earlier on this base, at the mirrored
operand SMLib's check refuses: the mirror-regressions agent's cause.)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
measure asked SMLib for a relative accuracy of 1e-4, after SmApiBrepComputeMassProperties'
documented clamp to [1e-4, 1e-1]. smlib_brep_mass_properties does not go through that call: it
calls the kernel's integration directly because the clamp "leaves curved faces off by 1e-5 to
1e-3", and takes [1e-8, 1e-1] (solidcraft_smlib::MEASURE_ACCURACY). Asking 1e-4 threw that
away: a swept cylinder's centre came out 5e-7 off its exact place, and a 0.0177 mm³ crescent
(a pin 0.59 µm off its hole) 0.27% off the lens of two circles. Measured at 1e-8, the sweep
centres are exact to 1e-7 and the crescents match the closed form to 1e-6; the engine-commands
batch runs in the same 20 s.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
cap_support_origin_is_not_a_trimmed_face_height read the drilled block's last face as a cap. The
record's face order is SMLib's: its last face can be the hole's wall, which has no cap loop, and
the test unwrapped None. The cap is now the first face on a plane square to z.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
a_lip_swept_on_a_round_rim_joins_it compared the union's mesh volume with the two operands' at a
1e-5 chord to 1e-3 mm³. Each mesh lies within its chord of its own faces, and the union is
tessellated by its own faces (the lip's foot merged into the top): two meshes of one solid differ
by up to their area times twice the chord, 0.02 here; they differed by 1.6e-3. The bound is now
that. overlapping_holes_and_mirror_joins held the mirrored union to 2v within 1e-9, below the
relative accuracy SMLib integrates volumes at (1e-4, measure::ACCURACY): the two integrals
differed by 2.3e-8. (That test now stops earlier, at the mirrored operand SMLib's check refuses,
the mirror-regressions agent's cause.)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
faceted_cut_of_a_helical_groove took the volume removed as the shaft's exact volume less the cut
body's mesh volume at a 0.01 mm chord. That mesh sags inside the shaft's round wall: the uncut
shaft's own mesh at 0.01 is 0.18 mm³ short of pi r^2 h, five times the 3 % the groove is held
to, so the groove read 1.326 where the screw integral gives 1.2214 (the section's 2 pi int r dA
over 4 turns plus the ramp at z = 0). The cut is a B-rep: its exact volume (measure) gives the
removed volume within the 3 %.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
faceted_boolean took the tool mesh's triangles by vertex index and refused any edge not shared
by exactly two triangles. A body's mesh (Body::mesh) gives each face its own vertices, the faces
along an edge the very same points, so a box's mesh came in as six open patches: "the mesh is
not closed". Corners at the very same point are now one vertex first (triangles keep their order,
so the history's triangle faces are unchanged).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
check_kept panicked on any edge origin that was not an operand's edge, but a new edge where two
faces meet has a Meet origin by the history's contract (EdgeOrigin::Meet), and SMLib's history
gives them: the raised band's and the thickened sheet's new edges. It now checks the edges an
operand still owns and passes over the meetings. The thickened sheet is the whole cylinder side
(SMLib's one face, truck's half): a wall stands along each of its free edges, the two rims, and
none along its seam, which the face meets itself along (2 + 2 faces, not 2 + its 3 edges).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A layout can leave triangles standing on their long side across the surface:
their corners on it, their plane across it. They count several times the area
under them (the front triangle's loft tubes 0.7% and 1.1% over the finer mesh)
and no split repairs them, since each half stands the same way.
After the sag refinement a post-pass flips a side inside the face when the
two triangles on it turn less from the surface normal the other way (by more
than a degree), keep their orientation in (u, v) and against the surface
normal (nothing folds), have area in 3D, and the new side and triangle middles
stay within the tolerance of the surface or no farther than before. Boundary
sides are never flipped.
Test: tess triangles_standing_across_a_curved_sheet_are_flipped_along_it; the
boolean_regression joined_loft_frames_reference_mesh_covers_each_face_once
case now passes.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Refinement split the side of a triangle that sagged most. Where a long
inner side lies on the surface at its middle (a section with an inflection,
a loft tube of the bike frame's front triangle) and the triangle's short
sides sag, only the short sides were split: each split left a child with the
long side and its vertex nearer to it, and the triangle beside a split side
lost its shape the same way. The triangles flattened onto the long side
without end, refinement ran to its point budget, and the mesh of the face
counted 3.4 times its area (1.45 times on a second tube).
A triangle whose widest angle is past 150 degrees now splits its longest
side, and a split never goes across an obtuse triangle's shorter side: that
triangle's longest side is split first, along the path (Rivara's
longest-edge propagation, its lengths growing, so it ends). Only sides inside
the face are split, as before.
Test: tess sag_refinement_across_an_inflection_ends_without_slivers, a sheet
with an S section meshed with a triangle flat on the chord across its
middle; it ran to its budget of 20000 points before and adds 28 now.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A whole sphere as one face has its seam as its only edge, used both ways. In a body many times
its size the seam gets two segments at the body's chord (pole, equator, pole), so no node off
the poles follows a node off them, and the loop kept its first node, a pole: its closing step
crossed the other pole, which the drift unwrapped to a whole turn ("boundary winds around the
surface"). The sphere was left out of the mesh (cut_beside_a_sealed_void_keeps_the_body: a void
r 2 in a 75 mm part, "1 face(s) don't mesh"). The loop now starts, failing a node with an
off-pole predecessor, at a node whose predecessor is a pole on the same edge, so the step into
it is that edge's own and the step into the pole is unwrapped in the loop like any other.
Regression test a_small_sphere_void_in_a_large_block_meshes (tess tests): watertight, no face
left out.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
export_keeps_faces_split_on_purpose took a box whose top Split Face cut in two, dropped the
split record by hand (with_split_lines(None)) and expected the STEP file to have 6 faces: truck's
export joined pieces on one surface, "as it does for pieces a boolean left". No operation makes
such a body: the split record is only set (doc eval, Split Face), never dropped, and removing a
Split Face rebuilds the part without the split. SMLib's booleans join pieces on one surface at
their end (two touching boxes unite into 6 faces), and the local modifiers heal through
boolean_record::healed, so no operation leaves incidental pieces either. The file now has what the
body has (7 faces, the export merges nothing), and the heal every later operation applies
joins the unrecorded pieces: 6 faces in the body and in its file.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SMLib's cylinder side is one face round the whole turn (truck's two halves): a line at z = 5
splits it into a quarter and three quarters of 2 pi 10 x 20, two side faces, not three. (The
test still fails further on, at the face-split tool's "invalid argument", engine-builds'
cause fixed on their branch in 50356dbf2.)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
a_modelled_thread_in_a_bore_meshes_inside_its_block held each face's triangle area to within 5%
of its surface's area. At the 0.1 mm tolerance, face 18 failed that: 1.777 mm^2 of triangles
over 1.522 mm^2 of surface. Face 18 is the groove's crest band where it runs out through the
block's end, a wedge at most 0.44 mm wide. Its boundary sides are the helix edge's chords, 1.37
mm long and sagging 0.062 mm (inside the tolerance). A flat triangle on such a chord bridges the
sail between the chord and the edge instead of following it, and the band is no wider than the
sag. The excess, 0.255 mm^2, is less than the sails along the face's boundary (sum of 2/3 L sag
= 0.62 mm^2). Every triangle is within the tolerance: the chord check passes. No triangulation
of the inside changes this; the boundary nodes are the shared edge nodes.
The check now allows 5% plus the boundary's sails at the tolerance, 2/3 L tol per boundary side.
A zigzag that multiplies a face's area, which this test exists to catch, is still far outside
that. On the run-out root band the bound allows about 40% at 0.1 mm and 5% plus 4 mm^2 at
0.01 mm, against the former 6x.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
tapered_extrude_of_lines_and_arcs expected the quarter disc (its arc meeting both lines at a
corner) to be refused, "arc meets another edge at a corner". That was truck's limit. SMLib's
curvature-keeping taper builds it as mainstream CAD does: each wall continues as itself until it
meets its neighbour. The test now checks what was built. The section at d = z tan 8 deg is the
disc of radius r + d over x >= -d, y >= -d. Its area is in closed form, and the volume is its
integral by Gauss-Legendre: 458.5870559 against SMLib's 458.5870567 (2e-9). The body has 5 faces.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
thread_display_tests sewed its M10 and M12 threads from cubic Bezier pieces approximating
helices, which lie about 1e-5 mm off the core and crest cylinders. No exact (same-parameter)
pcurve exists on the cylinder for such an edge, and SolidCraft's pcurves are exact B-splines
only. Sewing refused the core face ("no exact pcurve of a B-spline on a spline surface"). Truck
had fitted one. The thread feature makes its helices exactly, with SMLib's screw sweep, so the
test now does the same: the ISO ridge's section is screw-swept and joined to the core cylinder.
The section reaches a tenth of a pitch into the core along its flanks. ridge_volume is still the
thread's exact volume, and both display tests run unchanged, from the body as made and after a
STEP round trip. Imported edges that lie off their surfaces stay refused; they are Repair Part's
job.
The quality check's sag is now measured at the surface point nearest each triangle's centre.
Before, it was read at the mean of the corners' parameters. A closed surface's parameters are
kept within one period, so a triangle across the core's seam had corners a period apart, and
their mean read 6.27 mm off a triangle that lies on the surface.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
isocurves_of_a_split_face_run_on_across_the_split split the box's front face at x = -2
and 22, leaving an 8 mm piece. Since a body's size counts its edges (the boss's rims
reach y = -32 and z = 50), the lines' spacing grew to 10 (x = -20, -10 on the left
piece), and the 8 mm piece had no line up it to compare. The boss now leaves pieces
x < -6 and x > 18, room for two lines and one: the test still checks that both pieces'
lines lie on one ladder.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Body size (the box diagonal every size-relative tolerance comes from: mesh chords, reach,
fit tolerances) came from the record's vertices alone. SMLib closes a sphere, a cylinder or a
torus along seam edges, so those vertices can be two poles, two seam ends or a single point: a
torus was 1 mm across (its preview at a hundredth of that took 214 720 triangles and broke the
budget), a 5 x 8 cylinder 8 instead of 16.2. The size now also takes three points along each
edge: points on the edges, not their control hulls, which for a rational edge can lie far off
it (a sheared L-prism's outline box was 49 km across).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
sample_aliasing_does_not_certify_spline_caps built its trap as one polynomial of degree 17 with
a root at each of the 17 old sample locations k/16 (and a circle times such a polynomial, degree
19). A B-rep record holds splines up to degree 16 (MAX_SPLINE_DEGREE, #8618), so no record can
carry either and the evaluator refuses them: the test failed before testing anything. The trap
is now a C0 spline with a knot at every k/16: a quadratic on the line at each knot, bowing 1 mm
off it half way along the first span; and the quarter circle of radius 10 with its homogeneous
coordinates scaled by 1 + bump / 10, radius 10 at every knot and 11 at 1/32. Sampling at the old
locations still sees a line and a circle; the certifier, reading the spans' control points,
must certify neither, and doesn't.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
genuine_curves_and_oriented_traversal_are_certified built its degree-elevated line at degree
17. A B-rep record holds splines up to degree 16 (MAX_SPLINE_DEGREE, Brep::validate, #8618), so
no such edge reaches the certifier, and the evaluator refuses to build it. The line is now
written at MAX_SPLINE_DEGREE: still a line of the highest degree a record can carry.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The smooth-path sweep named walls only by the profile's edges in the start plane and took any
planar face nothing claimed for the end cap. A wall the start plane meets along no edge got
no name or became a cap: round a closed path, a square tube's planar top and bottom (whole
annuli, no seam) were both called end caps; along a line then an arc, the walls SMLib makes
along the arc were unnamed or caps. Like the cornered and controlled sweeps, it now also names
walls by the profile carried half way along, takes the end cap from where SMLib carries the
profile last, and round a closed path has no caps at all.
The issue #2005 tube check counted V - E + F without the ring term: SMLib's annular planar
faces have two loops each, so it checks V - E + F - (L - F) = 2 - 2g (Euler-Poincare). Along a
line then an arc SMLib makes a wall per profile segment per path segment (two, where truck
made three).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
transform_matrix moves a body by a matrix that is not a rigid motion through SMLib, which
numbers the moved body's faces afresh, then attached the input's face sources and paint in the
input's face order. Planar certificates landed on the wrong faces (a reflected, sheared plate's
hole walls and caps no longer lay on their certified planes). Each moved face now takes the
source and paint of the face its history names; a face with no known origin takes no source,
and with no history at all the paint stays as it was.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
efd0a577b kept the cap flatness tolerance under a quarter of the gap between parallel start
and end planes. A half turn's end plane is its start plane: the gap is 0, the tolerance became
0 and neither cap was found, so m0-revolve-primitives' two flat ends could keep no sketch
attachment (design_corpus every_flat_face_of_every_corpus_design_takes_an_attached_sketch).
Only planes apart by more than rounding bound the tolerance; coinciding ones are told apart by
the profile's edges, as before.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The roles of a swept body's faces take a face as a cap when all its points lie within a
flatness tolerance of the start or end plane, sized to the body (1e-5 of it). A box 0.1 µm
thick in a 14 mm body is thinner than that, so each cap lay in both planes and box_solid
refused "box role correspondence" (engine component_clone
boundary_material_proof_requires_resolvable_stock_and_void). Between parallel start and end
planes the tolerance stays under a quarter of their gap; a cap's points lie on its plane to
the evaluation's precision. Regression case: a 10 x 10 x 1e-4 box in
box_certificates_are_six_construction_roles...
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Each wall of a swept body is known by a seed on its piece's edge in the start plane; every
start-plane edge within `near` of a seed took its piece, `near` sized to the body
(3 x 2e-4 of its size). On a side shorter than that the neighbours' edges are near too: a
0.3 mm wall of a 1 m label is 0.15 mm from them, near 0.65 mm, so the long walls got two
pieces, had no source, and box_solid refused "box role correspondence" (gpu depth
at_ten_metres..., engine component_clone boundary_material_proof); a ring of radii 10 and
9.999 lost its side certificates (ui configuration_annulus_picker...). A seed now marks only
the edges nearest it (within the flatness tolerance of the nearest), still within `near`.
Regression case: a 1000 x 0.3 x 400 box in box_certificates_are_six_construction_roles...
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A chamfer picked at (10, 0, 20) on a cylinder's top rim lies on the vertex where SMLib's
cylinder has its seam. The blend takes the rim there (blend_smlib::resolve: a seam or a smooth
join loses a tie), but the name stored with the feature came from the nearest mesh edge, the
seam (`F2:side:c1`). Once the stem grew, the name found the seam and SMLib refused the chamfer
(join_extrude_from_a_chamfered_top_face). edge_names_for names the edge each pick takes as a
blend takes it (kernel::blend_edges), the nearest edge only where that finds none.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
face_patch put the tool face's surface (a cylinder) over the domain of its NURBS form, which
SMLib parameterises otherwise (0..1, not the angle and height), so the patch handed to SMLib
was a sliver of the cylinder or empty and SMLib refused it as an invalid argument
(split_body_by_a_face). The domain is the analytic surface's: a whole turn, unbounded along
the axis, closed past the body as before.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
edge_circle took a circle edge's interval as its angle. A circle SMLib holds on its NURBS form
is parameterised on that form (a fillet's quarter circle over 0..1), so the fillet's edge
measured 57.3° and an arc length of R·1 (a_fillet_edge_is_an_arc). The span is the edge's
curve_interval, the angles of its ends on the circle, as the lip already reads it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The thread forms (b4549d270) parse designations in thread_forms, whose refusal for a plain
M28 said "give it: M28x1" and, for M0 or M1e9, still offered a pitch. The hint the hole
command gave (the two coarsest ISO fine pitches that suit the diameter: M28x2 or M28x1.5) is
now thread_forms::no_coarse_pitch, used by both; a diameter no metric thread has is an
unknown metric thread. The test's "unknown thread" follows the forms' wording ("unknown
metric thread").
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
#5191 read the header's preprocessor version and FILE_DESCRIPTION, so a SolidWorks file named
only there was stood up. The reader had moved to crates/step (p21.rs) before #5191 merged,
and the merge kept only the originating system: a file naming SolidWorks in its description
got no exporter_up (step_replies_name_a_y_up_exporter). The parser reads both fields again,
StepImport carries them, and exporter_up looks at all three.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The normal equations of patches about a centre were solved dense, so at most
500 free control points: the torus window, 1433 once its patches ran in their
own spaces, was refused. Each patch's interior (coordinates of points only it
holds, coupled by no row to another patch's) is a banded block now; the blocks
are eliminated exactly onto the unknowns the patches share (the spokes, the
centre, and the points rows across a spoke couple), whose Schur complement is
solved dense, and the interiors follow by back substitution. A solve takes up
to 6000 free points, as one patch does, and refuses past 4000 shared unknowns
(a 128 MB dense block) with that reason. The torus window and the pentagon now
solve (they fold, open).
The fill tests' own-edge check compares an edge's NURBS form to rounding, as
fill.rs's does.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
About a centre, every patch ran in one space both ways that held the breaks of
every half edge and spoke, so each patch carried every edge's knots: a window
cut in a torus, its edges SMLib's traced intersections with many knots each,
needed 13537 free control points. Patch k now runs along u in the space of
spoke k − 1 and along v in that of spoke k; the space along a spoke holds the
spoke and the two edge halves it meets beside its two patches, so the spoke
is one row of both, as before. The torus window needs 1433 (still over the
dense solve's 500, open). Refinement about a centre adds the middles of one
uniform grid to every spoke's space; a patch's conditions read its own
spaces' spans, and the stations along spokes the finest of them.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The fold check refused a patch whose normal, anywhere on a grid, was a right
angle or more from the normal at its middle. A fill may turn its normal that
far without folding: a dome that meets a tube's wall tangentially is vertical
at its rim (90° from its top), a window round more than half a cylinder turns
past 120°. A fold is the surface turning back over itself, which reverses the
normal between neighbouring points of the grid (24 × 24, 3.75° steps on a
half cylinder); that is what is refused now, and a normal that vanishes
inside the patch. It may vanish at a corner where two sides run on straight
(a closed loop's pieces) and on a three-sided patch's pole.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A cup's rim of seven or eight ellipse arcs meeting at corners was too wavy for
the height-field fill: its finest grid, 32 spans across, stayed 6.4e-5 off the
loop where the tolerance is 4.4e-5 (a smooth bicubic follows the height's kink
at a corner only as closely as its cells are small), and the loop went to the
general fill, seven faces where one fits. The grids now go to 64 spans (the
fit's system is banded); the first within tolerance is still the fill.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
face_tolerance (and planarity_tolerance) was 10⁻⁶ of the body's bounding-box
diagonal, which changes as a body turns: the cup turned 0.7 rad about
(1, 2, 3) grew from 54.7 to 61.6, its fill sampled to another tolerance, a
different surface (area 974.543 against 974.527). The size is now the
diameter of the smallest ball holding the vertices (solidcraft_geom::Ball,
Welzl's algorithm, expected O(n)), the same wherever the body is and however
it is turned. Twice the farthest vertex's distance from the vertices'
centroid is that too, but up to twice the body's diameter where the
vertices crowd one end: a rounded box's set-back-13 G2 corner patch then
ran 2.0e-3 past the box (corner_g2
a_long_setback_keeps_the_g2_patch_inside_the_box, limit 1e-3).
The own-edge check of the fill tests compares an edge's NURBS form to
rounding (10⁻¹² of each coordinate): SMLib makes a conic's form again on a
round trip, the last bit of a coordinate apart.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The iso fill needs three sides or more, so a loop of one closed edge (a tube's
end) or two was refused as "a loop of 1 edges". Such a loop's edges are now
taken in equal pieces of their own parameters (one edge in four, two in two;
a break that falls on one of the curve's knots, a conic's quarter points, is
that knot exactly), each piece the edge's own curve segmented exactly; the
patch's edges are those pieces, their ends new vertices shared by the pieces
either side. A piece of an edge the loop runs against has its parameter
reflected about the edge's interval, as a whole edge's is.
The tube end is still refused: one four-sided patch on four quarters of a
circle has corners where its sides run on straight (180°), and the G1 dome
folds there.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A record's tolerance is SMLib's intersection tolerance: SMLib holds an edge's
gap to its faces to half of it (the zone tolerance) and a vertex's gaps to a
quarter (SM_XSECT_TO_ZONETOL3D, SmBrep::ValidateAndUpdateTolerances). The fill
gave its edges and vertices the face tolerance itself, the gap its surface is
certified to, so SMLib's check refused every fitted patch (an edge/surface gap
of 2.6e-5 against 1.85e-5 where the fit holds 3.7e-5), alone or stitched to
its body. Its edges now take twice the gap and its vertices four times.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A ruled strip off an arc whose rulings keep their angle to the arc's axis
(normal or tapered mode on a 30 degree lean) is a piece of a cone, but was
built as the rational B-spline between the arc and its image, which SMLib
labels with no analytic type (its CopyAndAddAnalytics only sees the plane
strips). Such a strip is now the start ruling turned about the arc's axis
through the arc's angle by SMLib's revolve, as the round corners already are:
a cone face, the same surface. a_circle_in_every_mode passes.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Kept parallel (the profile as drawn), a profile flattens to nothing where the
path turns to run along its plane. The check that refuses it (the path must
cross the plane by 5° or more all the way) lived in the stations of a
controlled sweep only; a plain parallel sweep went to SMLib unchecked and
built a degenerate solid. Both take the same check now, the plain sweep on
each segment's direction of travel at 33 points along it.
A circle profile is one closed arc, one edge in SMLib: a wall per path line,
not two.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Going into SMLib a sheet's shell holds both sides of each face, so the side the
record keeps as the sheet's front is lost, and SMLib thickens along the
surfaces' natural normals: Reverse Normal did not change which way a thicken
grew. A sheet used against its natural normals everywhere is thickened by the
negated thickness.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A record edge on a circle or ellipse carries the NURBS form SMLib holds it as,
its interval on that form. The patch built its loop edges from the form alone
(sew::PartEdge had no place for it), so a fill's rim came back from SMLib as a
plain B-spline rather than the body's ellipse. PartEdge now carries the form;
assemble keeps a given form and labels the edge with what it is.
Test helpers that sampled an edge on `curve` with the form's interval picked
points off the edge ("no edge at …"); they sample `parameters()`. The fill's
own-edge check compares the curve's kind and the exact form it is parameterised
on: SMLib renormalises a conic's frame axes in the last bit on a round trip.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SMLib can give a NURBS edge an interval that starts or ends a rounding past its
curve's knots: the end of the variable round r1 -> r5 run on into a box corner's
R5 round (ladder 07-fillets/012), trimmed by the R5 cylinder, started 7e-15 before
the first knot, and the record failed validation ("parameter interval outside
the natural domain"). Such an interval is moved onto the knots, as a face's
domain side is onto its surface's natural range (`onto`); farther past them is
still an error. SMLib 7e917f0 (c0d74ee..6e77631: the trace's reach set before
the corners) moved these ends by 1e-11, which is how the case regressed.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Ten cases the pin fixed leave the list (the 1207 corner patch and its together cases, 1390,
4782 reduce-fit, 896). 1557 joins it with its cause: since bodies are read back from their
records (#8625) its bottom rounds come back as SmCylinder where SMLib's blend made SmCone(0),
and the corner-ball trace starts 2.78e-4 off; its fix is in progress.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
a_shown_dimension_that_breaks_a_later_feature_reports_it_and_undoes took the
plate's 10 width to 3 under an r4 round of its back top edge, expecting the round
to fail. At the 7e917f0 SMLib pin a convex round wider than its face runs over the
face's far edge and is cut as if the face went on (the owner's overflow decision),
so it builds and the test failed. The test is about the error a dimension change
reports and its undo, so the broken feature is now a 2 thick shell open at the
top: 3 wide leaves no room inside its two walls, a refusal made before SMLib.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
#8676 added FeatureKind::Repair without a fixture, so
feature_walk_tests::the_record_covers_every_variant failed. The fixture sets
every field (body, gap, patch_holes); the records, written with
FEATURE_WALK_BLESS=1, show its one input (Gap, a length) and that copying with
bodies renamed rewrites its body.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
At the 7e917f0 pin SMLib builds the r50 round of a 20 cube's edge that
hostile_inputs_are_errors expected to fail: a convex blend that overflows its
faces' far edges is built by subtraction (blend on the faces extended, then cut),
as the chamfer past the faces two lines below already is. The body is exact: the
two ends, the two far faces and the round (5 faces, 9 edges, 6 vertices), volume
20 (F(40) - F(30) - 300) = 1094.85273 with F(u) = (u sqrt(2500 - u^2) +
2500 asin(u / 50)) / 2, the cube's section inside the r50 circle about
y = z = -30. The test checks that answer instead of an error.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The arc part's front edge rounded r2, then its left top edge with tangent
propagation (the Fillet feature's default): that edge runs on round the first
round's end arc and down the left front upright, so three edges end up rounded
(a sphere octant at the corner where they meet), not two. Both results were
exact: 9530.77 (meshed) is the part less three r2 strips and the octant,
9591.44 − (0.858407·(39.1667 + 19 + 8) + 8(1 − π/6)) = 9530.83; 9538.79 is
two strips less their overlap, 9591.44 − (0.858407·62.1667 − 0.7670) =
9538.84. The test compares the sequential rounds with the same edges of the
part rounded together: the picks' chains and every edge of the part the second
chain carried on into.
The other pairs still fail in SMLib (1001, or SM_ERR_INVALID_INPUT at the
knife-edge tip) where a later round ends on the first round's arc.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The Fillet and Chamfer features already blend each picked edge's tangent chain
by default (tangent_chain, true unless saved false), as mainstream CAD's
tangent propagation does; the kernel blends exactly the edges it is given.
#8678 refused, before SMLib, every edge that runs on tangentially into one left
out, which also refused blends SMLib builds (a round ending on the round its
edge runs into: blend_corner's a_round_next_to_a_round_of_another_radius, the
same feature with propagation off). Now:
- propagation off: only the picked edges are blended; where SMLib cannot end
the blend at such a continuation, its refusal names the edge it runs into
and that propagation (tangent_chain: true) blends the chain as one;
- propagation on, where the chain cannot be built (an r3 round carried on
round an r2 round's end arc), the refusal says the chain was blended and
that with propagation off only the picked edges are.
A smooth edge is still refused before SMLib. No default changes: the feature's
default was propagation on already.
The kernel tests that stand for a Fillet feature (curvecorner's sequential
rounds, issue 2422) take each pick's tangent chain, as the feature does by
default.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A smooth edge (its faces meet tangentially) has nothing to round, and an edge
that runs on tangentially into one left out has no end SMLib can blend (it
rounds a tangent chain as one sequence and failed building the face there,
status 1001): both are refused before SMLib with that reason. SMLib's new
SMLIB_ERR_CORNER_UNSUPPORTED (a vertex no blend corner handles) is
Error::CornerUnsupported and says so instead of a bare status.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
tangency-labs/smlib#11 (the Coons corner patch is tangent to its sides' surfaces), #12
(SMLIB_ERR_CORNER_UNSUPPORTED for a vertex no blend corner handles) and #13 (a torus found in a
NURBS has its major radius from its origin and a whole turn of its tube). Prebuilt hashes written
by scripts/fetch-smlib.sh --pin.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The Patch dialog's continuity row keeps each order's hover line and adds one: the patch meets
the faces round it at the chosen continuity along each side, and at a corner where those faces
meet each other with different curvatures it stays tangent (G1) there. New text in
assets/locales/pending/patch-continuity-corners.json, in English and the complete catalogs
(Arabic, Hebrew, Japanese, Chinese), German and Korean.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Four continuity cases for the patch fill. A hole in one smooth sheet (a cubic Bezier profile
extruded, a square trimmed out) patched g2 and g3: every seam reaches the order, corners
included, since round the hole there is one surface. The hole a three-round corner's blend
face leaves, patched g2 and g3: exactly g1 over each whole seam, since at the hole's corners
the rounds meet each other G1 (their curvatures differ by 1/4 or 1/8 per mm) and a patch smooth
there has one curvature; the middle of each seam reaches the order (kernel test).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The patch fill meets its neighbours to G4, so Construction::Patch now offers g0 to g4: the
surface.patch command takes g3 and g4 and the Patch dialog's continuity row offers
"Curvature change" and "Smooth curvature change" by itself, from the one table.
The three-round corner test patches G2, G3 and G4 and reads the seams with the Continuity
Analysis too: the middle of each seam (30-70 %) at the order asked; the whole seam G1, since at
the corners the rounds' curvatures differ and no patch can meet both.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5Lzv2n8fyKqD61NCHSF
Two command scripts in examples/clean-up: a round along a plate's edge running into a boss
wall, and a corner where three rounds meet. Each takes the blend's messy face off (face.delete
heal false) and patches the hole with Curvature (g2) and, beside it, Curvature change (g3).
Gauss-Legendre constants at f64 precision.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The corner blend of a box's R8 vertical round and R4 top rounds taken off and patched: both
patches meet the tangent planes and the curvature in the middle of each seam; the G3 patch
also meets the curvature's rate of change (4e-6 to 4e-5 /mm^2), which the G2 patch leaves at
0.27 to 0.63. G3 to an edge between two faces is refused; G3 is no longer refused as such.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A fill asked G^n is faired with the thin plate plus the energy of order n + 1 (each to unit
trace), so the change of curvature its conditions ask at the edges spreads over the fill
instead of being squeezed into the first span; Gram matrices on six-point Gauss-Legendre,
exact for quintics.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Rows across a patch's C0 knot lines (a side's break where it is only C0 in its parameter, such
as a circle's quarter joint in homogeneous form): the one-sided derivatives across in the
ratio of the crossing sides' speeds there, blended between them. Without them the fill rippled
along those lines (zebra stripes in steps) and SMLib's surface check refused it.
- Space::basis_left: the basis of the piece ending at a knot.
- Orders above a corner's agreement come back smoothly over the next share of the side
instead of switching on at once.
- Orders above G1 are best effort once refinement is spent: the fill is returned with its
jumps reported; the tangent plane, the points and an unfolded fill stay hard.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- One patch has a space along u and one along v, each holding its two sides that run that way;
a side's knot keeps its continuity when raised (multiplicity m + q - p), and each side is
carried in exactly by interpolation at the space's Greville abscissae.
- Refinement halves the spans only in the direction whose sides miss, and one patch's normal
equations are banded (the shorter direction numbered fastest), so a loop with a long
intersection curve refines where it needs to.
- At a corner whose neighbours agree to a lower order than asked (their tangent planes, their
twist between the two edges, or their forms), the stations near it ask no more than that.
- A station is held to the angle tolerance beyond the edge's own lean out of its neighbour's
tangent plane: a fill that holds the edge cannot come nearer.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
One order-n implementation in the linkage-curve formulation (Pegna & Wolter 1992;
Hermann, Lukacs & Wolter 1999): geom::linkage reads the neighbour as a height over its
tangent plane to order n (its jet, from the surface's exact partials of any order) and
gives each order's condition on the linkage curve, with exact gradients (dual numbers),
so fill_iso solves orders 2..n by Newton's method. Each order's row is weighed by h^(k-1)
and its jump is held, carried into the fill by Taylor's theorem, within the angle tolerance.
The iso fill takes rational edges (a circle's arc on its NURBS form): homogeneous rows,
each edge scaled so the corner weights agree, the inside weights the Coons blend and
fixed, so the fill stays a linear least-squares problem. Its degree is at least n + 1,
refinement adds simple knots, breaks of different sides within rounding are one, and the
weak Hermite rows act in the tangent plane at the Coons start's own speed, so they no
longer pull against the G1 rows.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LUXeKMoxpM7Vuv8Rb6E3K2
The command worked the repair out itself for its reply and the feature worked it out again
when it evaluated. The evaluation now keeps the kernel's report on the feature's result (as
an import keeps its import report, cached with it), and the command's reply is built from
that: one repair per call, and a part with nothing to repair fails the evaluation, which
leaves the design unchanged.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A new undoable feature (`repair`, one pending format file) and command with input and
output schemas. In order:
- A cylinder, cone, sphere or torus face SMLib refuses on its own is rebuilt on a NURBS
form of its surface laid on arcs from where the face starts
(`form::surface_on_own_arcs`), with SMLib's own trims: the import's quarter-grid form of
a face round most of a turn closes on itself, which SmTorus::IsNurbSurfaceTorus does not
recognise. Geometry unchanged.
- Free edges that pair up within `gap` are sewn by SMLib's stitch; GlueEdgesGeneral gives
each glued edge its own tolerance (at least twice its gap), the body's and the other
edges' stay. The result is checked against the input's own SMLib check, the
tolerance-bound tests (#5, #6, #59, #82) exempt.
- Loops of free edges left are holes: offered as surface.patch, and with patch_holes made
(flat only when the loop is planar and every face around it is a plane, else G1) and
sewn in.
The reply reports what changed face by face; nothing to do is refused with why.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
allow_errors_writes_anyway_and_a_saved_design_keeps_failing compared the box's volume
with 4000.0 to the bit, which the old kernel's closed-form planar volume gave. SMLib
integrates mass properties numerically (relative accuracy 1e-4 asked for) and gives
the 20 x 20 x 10 box within a unit or two in the last place (3999.999999999999), the
correct answer to the precision the measure has. The test now checks 4000 mm³ to a
relative 1e-9.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
a_combine_tool_stays_where_it_is_placed makes a part and then moves its occurrence
to check that a combine tool stays where it is placed. Since #2804 the design's first
part is grounded when it is made, so the occurrence.move refused and the test never
reached its question. The part is now made with grounded: false, as a part that is
meant to be moved is; the checks are unchanged.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A body made by an SMLib operation kept that SMLib body beside its record (SMLib's
export). The export is not exact to the bit, so the kept body measured and operated a
little differently from the record's import, which is what a body read back from a
file has: a box measured 24000.000000000004 mm³ live and 24000.0 reopened, a drilled
box 21989.38056 against 21989.38013. A cut ring's volume therefore changed when it
was moved, the moved ring being measured on the SMLib body the move made
(measure_centre_tests::combine_cut_volume_does_not_depend_on_placement). Every body
now imports its record when an operation first needs it, so evaluated and reopened
bodies are the same.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The GPU path tests (and the Windows FXC job, cargo test -p solidcraft-gpu) build real
designs through solidcraft-engine, a dev-dependency without its smlib feature. Run on
their own (-p solidcraft-gpu), nothing in the build turns SMLib on, so every geometric
step answered "this build has no SMLib" (10 path::* tests on develop). The
dev-dependency now asks for engine/smlib, as the apps do, and both jobs fetch SMLib
before building.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fillet_into_an_earlier_round picked the box's upright after rounding its top edge
and expected only that edge rounded. Since solid.fillet rounds each picked edge's
tangent chain by default (84bd2daad), the upright runs on through the first round's
end arc into the top right edge, and that is rounded too. The two-radius checks now
ask for exactly the picked edges (tangent_chain: false), and a new check rounds the
chain and expects what a round of the 38 mm top right edge takes off as well.
ribs_flush_with_a_window_change_nothing_away_from_them compared the lid with
6703.5222 mm³, the old kernel's chorded volume. The lid's closed form (the plate
with its rounded corners, the skirt, less the window, the slot and the notch) is
6703.5344 mm³, which SMLib gives; the test computes it, and the script's
description says it. Each rib's volume and area are checked to SMLib's mass
property accuracy (2e-7 relative) instead of 1e-6 absolute.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Three expectations encoded the old truck planar booleans' incidental output;
each is replaced by the exact answer:
- a_base_trimmed_for_a_flange_keeps_its_arcs: the flat outline has 10 edges,
not 12. The flange's bend zone and panel meet in line, and the union of
the two is one line along each side (a region's boundary has no vertex in
the middle of a straight run). Lengths and areas are unchanged and still
checked to 1e-9.
- a_base_trimmed_through_a_free_form_curve_follows_it_with_arcs, renamed
..._keeps_it_exact: the trim cuts the parabola exactly, so the base keeps
one conic and three lines instead of tangent arcs within 0.001 mm. The
strip (183.564 = ∫ y from 197 to 200, or 600) and the bend's length
(62.364) are now checked to 1e-6 and 1e-9 instead of 0.22 and 2e-3; the
chorded comparison stays.
- pockets_with_free_form_outlines_are_machined_beside_free_form_cut_outs:
the machining record holds the pocket's four exact conics in their order,
started at another of them; the check is for the same closed loop, not
the same first segment.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Reading a planar sheet back from SMLib split each loop where two of its
segments started within ten times the record's tolerance (2e-5 mm), so
the two ends of an edge shorter than 2e-4 mm counted as one point and the
edge came out as a loop of its own, which the next planar boolean refused
("needs closed loops"). A loop passes a point twice where it passes one of
the record's vertices twice; the split now reads the vertices, not their
places. The sheet built from our own regions still splits by place, at ten
times the caller's tolerance.
Fixes sheet::tests::a_ledge_beside_an_edge_as_tall_as_the_setback_goes_with_the_strip
(the ledge 1e-4 above the bend line); new kernel test
a_ledge_shorter_than_the_record_tolerance_reads_back_as_one_region.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The SMLib planar sheet united every region's material and then cut every
region's holes from it, so a region lying in another's hole (the island
inside a ring cut) was cut away with that hole. Each region is now its own
material less its own holes, and the sheet is the regions united.
Fixes sheet::tests::ring_cut_retains_exact_central_material_island (the
flat solid lost the island's π·25·2.5 mm³) and the kernel's
compound_planar_extrusion_normalizes_overlap_and_retains_islands.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Two tests rebuilt the old kernel's raw strips (a shell's wall split along its
opening, a stepped tab's -x wall split by the Join and the Cut) with today's
kernel and took the saved piece's name and projection from them. SMLib leaves
those walls one face, so there is no strip to rebuild: the tests now say so (the
wall is one face) and give the saved link as what an older file holds, its piece
name and its rectangle (y 10..20 x z 0..20 on the -x wall, the same 4-line
projection the strip had), and keep every check of what the model does with it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The SMLib port of shell dropped with_shell_planar_sources (then deleted it as dead
code), so a shelled body's kept walls and their inner linings had no ShellPlanar
certificate: a sketch or press-pull on a shell's floor lost its attachment (the Pi
case's Sketch2 and everything after it, press_pull_on_the_pi_case_floor) and the
shell certificate tests found no inner/outer face. The roles come from the input's
exact planar supports, so they apply to SMLib's result unchanged.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Mesh::ray_crossings and InsideIndex counted a triangle crossed by a
Möller-Trumbore test with half-open barycentric bounds (u in [0, 1), u + v < 1).
Those bounds depend on each triangle's own vertex order, so on an edge two
triangles share the ray was in both or in neither: the bracket example's hole
centre lies on a diagonal of the base's top triangulation and was counted 0 or 2
times instead of once (bracket_example_cuts_two_through_holes_and_reopens).
Both now use ray_crosses, a watertight test: each edge's side of the ray is the
signed volume dir · ((p - o) × (q - o)), which is exactly antisymmetric in
floating point, so the two triangles of an edge see it with opposite signs, and a
ray exactly on an edge's line is put on one side by the edge's endpoints in
lexicographic order. New geom test ray_crossings_count_a_shared_edge_once crosses
a grid at every inner edge, straight down and obliquely.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The seeded robustness goldens (tests/robustness/goldens.json, tests::robustness_goldens) recorded
what truck built for seeds 0-95, so they now fail on every seed SMLib builds differently. The
kernel-cases ladder (tests/kernel-cases/ladder, cargo xtask kernel-cases --ladder), whose cases
each carry their own right answer, supersedes them.
Gone with them: fuzz::golden, the CI goldens lane (the goldens output, SLOW_SEEDS, the re-record
hint), their nextest filter and priority entries, the mutants sample and the tests/robustness/
test-data mapping in affected.py. The robustness seeds and tests::robustness stay. The docs point
at the ladder.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
tess.wgsl sized its basis arrays for degree 7 by hand. It now holds 17 slots, degree 16 as the
CPU evaluator, and a test fails when the two drift apart again.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A G4 blend curve is one Bezier of degree 9, and the face extruded from it a spline surface of
degree (9, 1). The record accepts splines up to degree 16 (Brep::validate), but the evaluators
behind pcurves, tessellation and Continuity Analysis capped the degree at 7
(MAX_SPLINE_DEGREE), so the SMLib export refused the face with "pcurve: not supported yet: a
spline surface of degree (9, 1)". The cap was not an algorithmic limit: every routine under it
is the general NURBS Book algorithm, sized by fixed arrays of MAX_SPLINE_DEGREE + 1 slots.
MAX_SPLINE_DEGREE is now the record's own bound, 16, and Brep::validate reads the same
constant. The display evaluator's first-derivative basis (tess::basis_ders) works on two
one-dimensional tables (A2.2 at degree p and p - 1, eq. 2.7) instead of a square one, as its
GPU twin does, so the larger bound costs a low-degree surface nothing.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
cargo xtask kernel-cases --known-failing FILE grades a set against its
baseline: it fails on a case that fails and is not listed (a regression)
and on a listed case that passes (fixed: its line goes, so the list only
shrinks). The Fillet rig workflow runs the fillet set that way on pull
requests touching the blend, fillet, corner and continuity kernel files,
crates/smlib, eval*.rs, engine features.rs or the cases: one release
build of solidcraft-cli on a Blacksmith runner, SMLib prebuilt, sccache
on a sticky disk that main and develop commit.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
New: an r5 curvature corner at a box corner (its patch must seam G2), an
edge running tangentially into a round left out (refused: continues
tangentially), a convex r10.01 round 0.01 past a 10 mm face (built by
subtraction: V = 7139.875, A = 2585.140). The bar and boss arc rounded
together say their crease (15.6 deg r2, 13.1 deg r1); 1390 expects SMLib's
unsupported-corner refusal, the honest reason today; past a full round
the exact fit's refusal names the largest radius that fits, 7.5 mm.
KNOWN_FAILING lists the 18 of 89 fillet cases failing today, each with
its cause.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A new `continuity` area: seams whose order is certain by construction, each graded
`exact` (reads its order and not the next) at picked edges with Continuity Analysis's
default stations and tolerances: a box's crease (g0), a chamfer in place of a round (g0),
an r5 round on planes (g1), and a profile closed by a g1, g2, g3 or g4 blend curve between
lines, extruded (g1 … g4). `continuity.edges` may now be a list of points, picked as
`inspect.continuity` picks them, and `continuity.exact` asks for the order and no more.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
expected.json may give `continuity: {order: g0…g4, edges?: "blend" | "corner"}`: the
seams of each round, chamfer face or corner patch with the faces either side of the edge it
replaced, and of each corner patch with its rounds, are measured as Continuity Analysis
measures them (seam_diagnostics at its default 33 stations and default tolerances), and the
case fails naming the worst seam, its faces, the order it reaches and the next order's worst
value. The seams come from the faces' persistent names (doc::naming::blend_seams). The older
`{near, within_mm, …}` form is kept.
Every fillet-area case with a body gets its order: constant rounds and rolling corners g1,
curvature rounds g2, chamfers g0, the corner: g2 patch g2 at its seams.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A torus face covering most of its tube off the tube's quarter lines (an
exhaust collector's bend: 326° of the tube from −113.8°) needed a fifth
quarter along the tube, which STEP counts from the outer equator: its form
ran past a full turn of the tube and SMLib refused the solid. #8496 turns
frames about the axis only, and the torus label had no tube reference.
The torus label gets a tube start (`tube_start`, radians; 0 and left out
of the record by default, so older records mean what they did): v counts
from there, in every evaluator, form, pcurve, iso curve, tessellation,
placement, SSI and SMLib transfer. A spilling torus face's tube start moves
to where its tube begins, or a turn before where it ends, whichever puts
its tube circles on the grid of a round face they are about the axis of
(a pipe's cylinder meeting the bend); circles round the tube are labelled
from the tube start (brep::form::on_tube), so their forms and pcurves lie
on the face's quarter grid exactly. The saved-format change is one file,
crates/doc/src/format/pending/torus-tube-start.rs.
Engine assembly: COLLECTOR_EXHAUST_VER_1 now comes in as a closed solid
(refused 3 -> 2); Poppy Humanoid unchanged (4).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SolveApp::header (toolbar::HeaderLayout) lets the app that hosts the UI
choose where the application bar puts three things; the default is the
current desktop layout, pinned by a test:
- command search: in the ribbon's tab row (default), or in the bar
immediately left of Settings, folding to its magnifier when the bar is
short of room (the ribbon's tabs then run to its end);
- Report a bug: a labelled button (default), or an icon drawn like Settings
and Help with its name as tooltip and accessible label;
- the version: in the bar (default), or as a Help menu row after About that
opens the release notes.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
An app that embeds the engine can install a check on the Session
(Session::set_command_check). Session::execute asks it before each command
with the command id, its parameters and the session (read only); a refusal
comes back as EngineError::Refused with the check's reason and leaves the
design unchanged. Without a check nothing changes.
The check belongs to the host: it survives opening and starting designs,
scratch copies (previews, off-thread evaluation) carry it, and the desktop
UI hands it on to every document tab and to designs opened in the
background.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
An edge along a face seen edge on lies within a pixel of the nearer face beside it, which hides
part of its width; its hidden copy, drawn after the visible edges, laid a light line over the
visible edge of that nearer face (some 100 px on a box at yaw 1.565). Drawn first, it is covered.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
uv::closed tells a spline closed on itself (periodic, one knot interval per period) by
its first and last control rows and knots clamped at both ends, checked as k[0..=p] and
k[n..=n+p] all equal. Over its interval [k[p], k[n]] a spline of degree p never uses
k[0] or k[n+p]: it starts at its first control point and ends at its last when
k[1..=p] and k[n..n+p-1] repeat. A periodic quadratic circle written with knot
multiplicities 1,2,...,2,1 (as OpenCascade writes one) was taken as open, so its seam
edge's two uses got one pcurve and the face was refused as a loop across a closed
spline surface's seam without a seam edge (periodic_knot_tube_faces_import_and_mesh:
"pcurves failed on 2 of 2 faces"). The check now skips the outermost knots; the knots
the existing test calls unclamped (uniform) stay open.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A SPHERICAL_SURFACE face bounded by one meridian used both ways is a whole ball, but the
file's placement need not have its poles at the meridian's ends: a sphere's frame is any
right-handed frame about its centre (the same surface, its natural normal outward). With
the poles elsewhere, the seam is a slit across the face's form, not the form's own seam;
SMLib's export refused the record ("a closed shell bounds two regions and encloses one"),
and the ball was not imported
(seam_only_sphere_whose_placement_axis_misses_its_poles_imports_as_a_whole_ball).
Before anything is measured on the frame, such a sphere's frame is put on its seam: the
axis through the seam's ends (which must be antipodes on the sphere, within the
tolerances), the x axis through the seam's middle. A seam already between the frame's
poles keeps the file's frame.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A cylinder, cone, sphere or torus face of one whole turn has a NURBS form of the four
quarters from the one its seam starts in (brep::form::face_quarters). When the seam is
not on a quarter line of the file's frame, the seam's second use lies a period on, past
the form's end: the face's domain stopped at the form's end and SMLib measured a ball
whose seam meridian is 0.7 rad off its frame's x axis 2.2% short
(tilted_seam_only_sphere_imports_as_a_whole_ball: 32.03 vs 32.74 mm3), and a 5 mm ball
with its seam 1 rad off, holding a 2 mm void, 481.0 vs 490.1
(seam_only_sphere_void_is_turned_inside_out).
turn_quarters, which says whether turn_frames (ee4d4b5a5) turns a face's frame, counted
such a whole turn as four quarters, never a spill. It now counts the quarters the face's
angle interval needs on the grid (brep::form::quarters, as for a face of less than a
turn): five for a whole turn off the quarter lines, so the frame is turned about its
axis to put the seam on one, and the form's seam is the face's.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The schema 4 reader adds a seam to a face that winds around its surface without one
(3d7e465b1) and turns over a face whose loop disagrees with its same_sense, and notes
both (the spindle torus tests assert the seam note). The tests written against truck
expected no warnings:
- step_conformance_parts_read_back_their_exact_shape: each part's seam count (the cone,
dome, cylinder parts bounded by their rims alone); volumes, boxes, faces unchanged.
- extruded_ellipse_patch_crossing_profile_seam_stays_trimmed: same_sense .F. adds the
turned-over note.
- implicit_bound_can_still_describe_the_complement_of_a_patch becomes
implicit_bound_against_its_face_sense_turns_the_face_over: the strip's one bound on a
cylinder cannot be a hole (the cylinder is unbounded along its axis, so the face would
have no outer boundary); the loop bounds the face, turned over, the 42 mm2 strip.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The face-bounds limit lives in crates/step's topology (MAX_BOUNDS, 54b10b9a3) since the
truck reader that said 'boundary loops' went (ab8bc6625); it names the face and its
bound count. The test asserts that message; the time bound stays.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The reader (crates/step, f06581ca5) keeps distinct knots and their multiplicities and
never expands them; a multiplicity above degree + 1 is invalid (ISO 10303-42) and is
refused on its own as 'bad knot multiplicity' before the sum is compared. The test's
1,000,000 knots of multiplicity 64 on a degree-1 curve hit that first. Both checks are
asserted: multiplicity 64 per knot, and 1,000,000 knots of multiplicity 2 by the sum.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
unsupported_face_is_left_out_and_reported replaced a plane with an OFFSET_SURFACE on a
placement: the reader reads offset surfaces since d41ae8512, so the face was refused
for its basis (AXIS2_PLACEMENT_3D), not for being unsupported. It now uses
CURVE_BOUNDED_SURFACE, which the reader does not read. Since cfee4a720 and 4cb0d6ee9 a
solid with a face left out comes in as a surface body of the faces that read, warned
'imported as surfaces' and 'left out', with no 'open body' warning on top (as
a_refused_solid_comes_in_as_a_surface_body_of_the_faces_that_read asserts); the test
asserts that.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
8eb93ff06 gave every cube edge its own line through two vertices, with the lines'
directions and vectors at #600 to #623. two_instance_assembly writes its occurrences
at #600 to #614, so 10 ids were defined twice, the reader kept the cube's, and the file
had no assembly: one body where hand_written_assembly,
later_instances_show_the_first_instances_mesh_placed and
repeated_items_are_shared_and_one_use_items_are_not expect two. The directions move to
#340 to #363, which no fixture uses.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
An edge that lies off its face's surface has its tolerance raised to cover the
gap before SMLib makes its trims (cover_gaps). Where such an edge runs out of
its patch, SMLib ends it where its drop onto the patch ends when that is within
the edge's cross-section tolerance of its vertex (SmEdgeuse::CreateUVTrimCurve),
and moves the edge's interval there. The moved end was checked against the
edge's tolerance before it was raised (1e-5 mm), so two faces of Poppy
Humanoid's left thigh, whose edges SMLib ended 0.08-0.1 um short with a held
tolerance of 0.77 um, were refused ("SMLib moved an edge's interval"). The end
is now checked against the tolerance SMLib held the edge at.
Poppy Humanoid: thigh_left comes in as a closed solid (refused 4 -> 3).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
An edge on a circle or ellipse read as a full turn whenever its two vertices lay
within the file's uncertainty of each other. The engine assembly's water pump
housing has a 20.4 um arc between two vertices in a part whose uncertainty is
20.5 um: read as a turn, its cylinder face's loop wound once round the axis with
no second bound ("a face around an open surface of revolution with one bound")
and the housing came in as surfaces. A full turn is now an edge with one vertex,
or two at one point; two vertices apart bound the arc between them.
Engine assembly: HOUSING_MAIN_WATER_PUMP_01 comes in as a closed solid
(refused 5 -> 4). No other edge of the engine or Poppy Humanoid read this way.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Each body a section cuts is hatched at 45 or 135 degrees in one of three
colours of one family (the cap's clay, a steel and a sage, theme tokens
`section_cap` and `section_hatch`). Bodies whose cut outlines touch or
overlap get different hatches, the angle changed first, then the colour
(solidcraft_render::hatch, a greedy map colouring of the cut); otherwise a
body keeps the hatch its name seeds, so it stays the same from frame to
frame and as the plane moves. Spacing and line width are unchanged.
The hatch rides on the palette (an Rg32Uint texel: colour, 1 + hatch), so
the viewport, headless GPU pictures and the CPU raster draw the same.
Preference Graphics > Section hatch: By part (default) or One style, the
look before this change.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5Lzv2n8fyKqD61NCHSF
Ten `refused` cases outside the fillets had no `refusal` since #8445 made one required. Each
was run; its refusal is the right answer for the reason its method gives, and that reason is
now its `refusal`.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A cylinder, cone, sphere or torus face of less than one turn that does not
start on a quarter line of its frame, with more than three quarters left to
it, spilled into a fifth quarter of the quarter grid: its NURBS form ran past
one turn and SMLib refused the solid ("an edge lies 12-16 mm off the face's
surface"), which came in as surfaces.
Before its edges are labelled on it, such a face's frame is turned about its
own axis (brep::form::turned: the same surface, its angle parameter measured
from further on) so it starts on a quarter line and its form spans four
quarters. Round faces a circle edge about both their axes joins share one
quarter grid, so they turn together by one angle, chosen so every one of them
fits in four quarters; a group with a face that cannot be turned keeps the
file's frames. Each face's box on its label is measured once and reused.
Engine assembly: PULLEY_WATER_PUMP and MOUNT_SCAVENGE_PUMP_01 now come in as
solids (refused 5 -> 3); Poppy Humanoid unchanged (4).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5Lzv2n8fyKqD61NCHSF
A body showing another's display (a later instance of a part an assembly
places several times) took that part's mesh, placed, but was planned for
the GPU viewport on its own: Poppy Humanoid's display planned all 247
bodies where its meshes came from 94 parts. Body::mesh_plan now plans the
original once (kept with the shared display, as its meshes are) and moves
the plan, so the copy's display is the part's triangulation, as its mesh
is. Body::unmeshed_faces needs no case of its own for a copy any more.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The STEP import's mesh check made a coarse mesh of every part (planned,
evaluated, its seams and smooth edges flagged) only to see which faces had
triangles, and threw it away. A face has triangles in the evaluated mesh
exactly where its plan has a triangle on its own nodes, so the count is now
read off the plan (TessPlan::faces_with_triangles, the condition evaluate
keeps a triangle by).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A window of planned solids ended at the second instance of a part not yet
read, so an assembly that places a part several times in a row converted
in windows of one or two solids, each waiting for its slowest read before
the next began (Poppy Humanoid: 14 windows of 1 to 30 reads on 8 workers).
The window now always takes MAX_WINDOW solids; an instance of a part an
earlier job of the window reads is placed after that job, from the
orientation it found, as the next window would have placed it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A face whose boundary is only two small circles (a tube's bend) did not show where it is from
its ring alone: its triangles are now drawn over in the error colour at 35%, depth-tested like
the selected face's tint, under the ring.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5Lzv2n8fyKqD61NCHSF
While a feature dialog says that a part's face can't be used for modelling, and while the
pointer is over that part's "needs repair" row in the browser, the face is outlined round its
edges in the theme's error colour, over the shading and dimmed where the model hides it, like
the selection's outline; it goes when the message or the hover does. Show face now frames the
face without selecting it (a selection in a dialog becomes its pick and cleared the message).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5Lzv2n8fyKqD61NCHSF
The current step's spinner was egui's, sized to the text and drawn as a small partial arc next
to the tick and the ring. All three marks now share one box the label's height, centred on its
capitals (the first glyph's ink, not the line box), at the same left edge: the tick, a turning
three-quarter circle and the ring are the same diameter, the spinner with the tick's stroke,
whole at 100% and 200% UI scale.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5Lzv2n8fyKqD61NCHSF
SMLib's import says only that it refuses a body, so the kernel now keeps a structured
refusal with the body's SMLib cache (Body::smlib_refusal / smlib_refused: the first face SMLib
refuses on its own, found by sending each face alone, and its surface kind). A STEP import sends
each part's first instance as an operation would, notes the parts that need repair in the
import report, and the browser marks them ("VALVE_COVER_01: needs repair").
A feature dialog whose operation fails on such a part says, instead of the kernel's words and
an issue report: "Couldn't join to VALVE_COVER_01. One of its rounded faces can't be used for
modelling.", with Repair part (body.repair, declared as planned, also in the part's menu) and
Show face (selects and frames the face).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The kernel's import warnings get a structure (ImportReport: the file's parts, how many came
in as solids, and each warning's kind, part, faces and count; the reads' notes are typed as
repairs or faces left out). The Import feature's result carries it (and the model cache keeps
it), and the timeline tooltip and the status line after an import word it from the catalogs:
"Imported 40 of 43 parts as solids. 1 part couldn't be made into a solid and is shown as a
mesh. 3 faces couldn't be repaired and are missing." with what may help. Entity numbers and
the kernel's wording stay in Copy Warning Message, which now lists every warning.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
An open or an import lists its three steps (a STEP or IGES file: reading the file, checking
and repairing the parts, building the model; a design: reading, rebuilding the features,
preparing the view), the ones done ticked, the current one with a spinner the height of its
text and how far it is, and the bar for that step. The other file operations keep their one
line, led by the same small spinner. New kit control: ui_kit::steps.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The Setback field's "More than 2 mm" is the message; the kernel's refusal of
that setback shows no text under the dialog and no Create Issue (it is the
user's value to change), and its raw text stays in Copy Details.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5Lzv2n8fyKqD61NCHSF
The Setback field reached the command and the kernel used it: on a box corner
with r 2 rounds a 3 mm setback built, while 1.5 and 2 mm failed inside SMLib
(status 1001), shown as "could not be built" with nothing saying why. A setback
must reach past where the rounds meet without one (the radius on square faces).
The kernel now refuses such a setback before SMLib runs, naming the least
(the pre-check of aa2b09bc2 on fillet-kernel-cases), and exposes that least
(fillet_least_setback). The field shows the default, 1.5 x the radius, as an
editable length that follows the radius until the user types one, and outlines
a value at or below the least in the warning colour with "More than 2 mm"
under it (ui_kit::checked_row, warning_caption). Its hover text says what a
setback does, the default and the least.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5Lzv2n8fyKqD61NCHSF
An open body (a surface body, a mesh that does not close) has no inside: its faces counted
with the rest took the cap from the closed body it lay in or behind. The body's closedness,
which the kernel knows (`ModelBody::is_closed`: no shell left open, a mesh body every side of
which two triangles share), goes with it to the renderer (`SceneMesh`, `PlannedBody`,
`InstancedMesh`, a block's closed runs, the loose open triangles), and the count draws closed
bodies only.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5Lzv2n8fyKqD61NCHSF
The cap went to the nearer surface by depth: a back face (the cut body's far wall) or a front
face. Where bodies touch, the cut body's far wall and the other body's face lie at one depth,
and rounding settled each pixel either way: the other body showed through the cap in specks,
stripes and triangles (an engine's sleeves in their bores, pins in their bosses). The stencil
now counts the faces behind the plane instead, from a base of 128: a back face adds one, a
front face takes one away; above the base, the plane is inside a body and the cap is drawn in
the nearest back face's cut colour, at the plane's depth. Elsewhere the faces draw as without
a section, an open body's inside lit rather than hatched. All four draw paths (built, planned,
instanced, instanced flat).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5Lzv2n8fyKqD61NCHSF
A SHELL_BASED_SURFACE_MODEL with both closed and open shells (Poppy Humanoid's
thighs: the part and a two-face sheet on it) came in as one body, open for the
sheet's edges. Each closed shell is now read as an item of its own, a solid in
the model's colour, and the model's open shells as a surface body.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5Lzv2n8fyKqD61NCHSF
A face's form covers the quarters of its box, and the box is the extent of its
boundary's points, which run past a quarter's end by as much as the edges lie
off the surface (nanometres in a file of 1e-11 mm digits). A half tube's form
then took the quarter past each end and went round the whole tube, which SMLib
does not take for a torus: 16 parts of an alternator came in as meshes. An end
within the tolerance of a quarter's end (the angle on the face's widest circle
there) is now on it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5Lzv2n8fyKqD61NCHSF
A corner setback must reach past where the corner's rounds' contact lines
meet without one (smlib_blend_setback); short of it SMLib failed with its
own status (1001). The kernel now refuses it before SMLib runs, for the
rolling-ball corner (fillet_setback) and the curvature corner
(fillet_g2_corners) alike, naming the least: on each face at a corner of
planar faces and straight edges the two rails, r tan(psi/2) from their
edges, cross (d2 + d1 cos alpha) / sin alpha along an edge (r on faces
square to each other). Other corners stay SMLib's to refuse.
The rig's `refused` cases now name the reason (`refusal`, a part of the
message, required), so a failure for another reason no longer passes; a
`solid_or_refused` case may name one. Fillets: the setback cases and
783, 3435 pass; 1390, 896, 4782 past-a-full-round and the no-tangent-chain
case are refused for an unclear reason and fail.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
22 hand-written cases in tests/kernel-cases/fillets:
- 1207-fillet-bar-top-edge-and-boss-arc-together (r2, r1, fit reduce,
fit taper, curvature corners): a bar's top edge and the partial base
arc of a boss standing out over the bar's side rounded together. The
rounds' volumes away from the corner, the corner patch within (2r)^3.
SMLib's 3x2 mixed corner fails here (1001) until the fork's fix.
- 1207-fillet-bar-top-edge-after-boss-arc-round (r2, r0.5, no tangent
chain): the edge rounded after the arc; r0.5 fails SMLib's check.
- 9-fillet-corner-*: setbacks not past the radius refused (rolling and
curvature corners), the curvature corner at r1, and the curvature
corner with reduce and taper fits (not supported yet).
- 4782-fillet-*: full rounds (two end verticals at half the width, exact,
reduce, taper), a round at half the wall, radii past the full round
(refused; reduce gives the full round) and a round wider than both
faces (built by subtraction).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The old body was drawn as ghost whole, behind the new body by a fixed depth bias. A curved
face the change re-meshes (a boss face whose boundary a fillet moves) has a new triangulation
that crosses the old one by up to the chord error, far past that bias, so the ghost showed
through it in slivers. Old triangles lying on the new body's surface are now left out; the
removed material is still shown.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The held parameter was spaced over each face's own trimmed (u, v) box, so the pieces of a
face split by a boss showed different lines that missed each other at the split. The lines
now sit on a ladder of the surface: a bounded parameter's range in count + 1 steps, a linear
one (a plane's, a cylinder's or cone's axis) at a round world spacing from the world origin.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The dialog follows the options solid.fillet takes together: If too large
(fit) and Corners show only for Constant radius, a curvature corner and a
fitted radius rule each other out and the other resets visibly, and an
option that does not apply is never sent (it used to send `corner: g2`
with Reduce or Taper and get refused). Variable Radius shows only for the
types that take it; the Advanced section held only the fit and is gone.
Each option has a one-line hover text. Kernel refusals read in plain
words, with the raw text in the hover, Copy Details and the issue report.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SMLib holds both sides of a sheet's faces and gives each back on its surface's
natural side, so a sheet whose file uses faces the other way came back
renumbered. The reader no longer turns them (that lost the file's side);
instead SMLib is given the sheet with those faces turned over exactly on the
record, and they are turned back on SMLib's body, each face mapped through.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A solid the reader or SMLib refuses was shown as a mesh of its faces (#8223):
exactness lost, cracks between faces, and no modelling. It now comes in as an
open surface body of the faces that read, sharing their edges as the file has
them; each face left out is named.
- The reader reads a solid with a set of faces left out (read_solid_without):
a sheet whose faces face their surfaces' natural normals, as SMLib gives a
sheet's faces back, so SMLib's body numbers the faces as the record does.
- Tier 1: the faces that cannot be read alone and the face each refusal names
(named_face) are left out, up to 8 reads. Tier 2, when a refusal names no
face of the solid: the one-face bodies stitched by SMLib. Tier 3, when SMLib
cannot stitch them: the mesh of them, as before.
- Report: "imported as surfaces: <why>" and "left out: face #..."; the
ImportedBody field shown_as_mesh is now refused.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A face's boundary node on a patch side collapsed to within the tolerance of
the vertex there (capped at the chord tolerance), not to a point, is a pole:
its parameter along the collapsed direction is free, as the record check and
the STEP loop check take it (`uv::collapsed`, shared with
`SurfaceEval::pole_within`). A loop through such a corner no longer winds
round the surface as projected, and plans strictly (Poppy Humanoid's
connector, face 43: a quarter of a sphere cap on a closed rational spline).
A face the strict plan and the lenient fill both refuse no longer fails the
whole body's mesh: it is left out with no triangles, named in
PlanStats::unmeshed (logged by the display plan, counted by
Body::unmeshed_faces), and the rest of the body is meshed; a body none of
whose faces plan is still the first face's error. Body::volume_at gives no
volume for a mesh with a face left out.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
When the reader or SMLib refuses a solid, each of its faces is read on its
own as a one-face surface body (solidcraft_step::topology::read_faces_with)
and meshed by the planner; the triangles together are a mesh body (the
existing kind STL/3MF imports make), marked ImportedBody::shown_as_mesh with
the refusal. The report says 'shown as a mesh: <reason>' and names each face
left out. Modelling operations refuse it as any mesh body.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The check that a loop does not jump across a spline surface's parameters took a
pole only within the face's tolerance. A corner patch written with one side
shrunk to a few µm (Poppy Humanoid's connectors: 5 µm in a 1e-5 mm file) was
refused, though the record check takes the same junction as a pole at the
tolerance of the vertex the uses meet at. The import check now uses that
vertex's tolerance; the loop runs along the collapsed side, its boundary iso
line. A jump that is still refused says whether the surface closes there.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
An edge whose curve runs a few um past its vertex and its spline face's
patch was trimmed back by SMLib when it made the trim, and the face was
refused ("SMLib moved an edge's interval"). Our own measure never saw the
gap: STEP measures an edge against its surface only where the nearest point
is in closed form, and a spline face's gaps only on the pcurves the kernel
returns, after SMLib has trimmed the edge. Each bare use's edge is now
measured by SMLib (smlib_brep_edge_face_distance, over the patch) after the
sheet's import, its tolerance raised to cover the gap with
SURFACE_GAP_MARGIN and the sheet imported again: SMLib keeps the edge whole.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
An edge raised to cover its pcurves' gap could get past SMLib's limit
(Congé19: 0.98 mm off, tolerance 1.47 mm) and its whole solid then failed
as "SMLib rejected the input". The tolerance an edge or vertex would get,
not only its gap, is now held to that 1 mm: farther off is refused with
how far. The record mapping refuses a tolerance past it with a message
rather than handing SMLib what it rejects.
The margin over a surface gap moves to solidcraft_geom::brep::pcurve
(SURFACE_GAP_MARGIN) for SMLib's pcurves to use too.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Binds smlib_brep_edge_face_distance: how far an edge lies from a face's
surface over the surface's own domain, the gap SMLib sizes an edge's
tolerance by.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
tangency-labs/smlib e51c3f2: a drop that comes back in pieces is joined
where they meet, never stretched onto its edge (solidcore#1383), and
smlib_brep_edge_face_distance.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Pins tangency-labs/smlib 56f6e81 (release prebuilt-56f6e811bc84…): smlib_blend_setback_eased
and smlib_blend_setback_open_eased, an ease length before each set-back corner over which a
round's section blends from its circle to the curvature-continuous section (solidcore#1376).
New calls only; existing ones are unchanged (ease 0 is today's body).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The Corners row keeps the control's words (Tangent, Curvature) and its hover text says what
each makes: a rolling-ball corner (G1), or a smooth patch set back along each edge by the
Setback, 1.5 × the radius when empty (G2). continuity_row_explained is the shared control with
a caller's hover text; the new lines are in en, ar, de, he, ja, ko and zh.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ui_kit::continuity_row is the one widget that chooses an order: a dropdown of the orders a
construction builds, labelled with the table's words and with a hover line per order naming
its code. Patch, Blend Surface, Boundary and the fillet's Corners row (tangent rolling ball or
curvature-continuous patch) all use it, and their dialogs keep a Continuity rather than an
index into a copied list.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Each seam now also reports the jump of the curvature's arc-length derivative across it (G3)
and of its second derivative (G4), both from the faces' exact partials, and its order: the
highest one every station meets within the tolerances (two new tolerances, defaults in the
kernel). The verdict keeps its meaning (smooth is G2 or better). inspect.continuity replies
with the new metrics, each seam's order and a count per order; the viewport widens G3 and G4
seams, the legend and the marker labels name every order in words. The Patch, Blend and
Boundary rows offer the orders the kernel's Construction table says they build. G4's words
in en, ar, de, he, ja, ko and zh.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
EvalSurface and SurfaceEval give every partial derivative up to total order four: in closed
form on cylinders, cones, spheres and tori, by basis-function derivatives and Leibniz's rule on
rational splines, and by the rotation's own derivatives on a revolution (which had no second
derivatives before). normal_section turns them into the curvature of a normal section and its
first two arc-length derivatives by solving the section's Taylor series order by order.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LUXeKMoxpM7Vuv8Rb6E3K2
The kernel's Continuity moves out of bridge.rs into continuity_order.rs and gains G4. One
table holds each order's command word (g0-g4), its code (G0-G4, for tips and messages) and
the message ids of its label and hover text. Construction says which orders the patch,
bridge, network, match and sketch blend curve build today; Continuity::built_by is the one
refusal every command and kernel entry point uses. A design may now save g4 (format note).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LUXeKMoxpM7Vuv8Rb6E3K2
The fit-point spline's extruded side is two faces split at x = 20; the hole now
lies inside one of them, so the test clips to a real inner loop.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The analysis sliced the display mesh with planes: faceted, approximate, and
broken at triangle seams and trims; the window drew it as a 2D overlay without
depth while the tool was active. Now one kernel routine (kernel::iso) clips a
surface's u = const or v = const line to a face's pcurve loops; the curve through
a point (sketch projection) and the analysis grid (count each way, evenly across
the face's extent) both use it. The loop polygon follows the loop's order (a
pcurve the loop runs against is walked backwards), which the inside test got
wrong before, and closes over vertex-loop poles.
ModelBody caches the lines per face, count and display quality. The session
keeps the picked faces as view state (inspect.isocurve add/clear, hostile counts
refused); the viewport, ui.render and snapshots draw them depth tested in the
accent colour. Curvature combs on faces follow the same exact lines.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The nearest point on a spline (5cb015fae measured spline faces up front too) may settle on
another part of the surface, or on its boundary for a point a hair past it, and reported gaps
the edges do not have: 2.9 mm on Poppy Humanoid's leg shells, whose edges lie within 0.003 mm
of their faces, and widened tolerances past what SMLib takes (it then refused
models/vertices-off-curves.step). The up-front measure is again for faces whose nearest point
is in closed form (plane, cylinder, cone, sphere, torus); a spline face's gaps are measured
on the pcurves its kernel makes, as the record check measures them.
The corpus survey is back to 53 of 56 files; Poppy imports 238 bodies (10 solids refused,
most for SMLib's pcurves on spline faces: solidcore#1383).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
As the app's Display Quality setting, set before the design opens so every display plan is
made at it; a level that isn't one is refused with the levels. For close-up reviews of
imported faces.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Two edges leaving a vertex almost tangentially (a cusp, as a round runs out on Poppy
Humanoid's creative_commons_license) separate by about Δκ·s²/2 at distance s while a chord of
length L sags by κL²/8: halving the chords never stops them crossing. untangle returned that
face's error for the whole plan, and the body's 1834 faces were not shown. It now returns the
faces still crossing, each with why, and plan_or_fill fills each leniently straight away and
names it in the stats (the rule of #7755): the other faces are planned as usual.
Test: a face named as still tangled is filled leniently and named with that reason.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A corner ball's edge may run from its equator over the sphere's pole to a vertex just past
it (Poppy Humanoid's creative_commons_license: 1.8° past, 0.016 mm off the pole). On the
sphere's parameters the pole is a line, and the edge's pcurve would have to jump half a turn
along it: "pcurve starts 2 from the end of the use before it, on another period". Each
edge that passes through a pole of a face it bounds (a sphere's, a revolved face's on its
axis) inside its interval is now split at the nearest point to the pole (golden-section
search from 16 samples), the new vertex placed on the pole; the loop's half turn is then at
a vertex on the pole, where a loop may run along it. Each solid's notes say how many edges
were split. The geometry check takes a vertex at a pole to within the vertex's tolerance, as
the reader already does (SurfaceEval::pole_within).
Without the split the edge's jump read as a 0.024 mm gap and was covered by a tolerance:
the measured gap now only covers what the file's geometry really has.
Test: a spherical triangle (radius 0.5) with an edge over the pole to 1.8° past it reads
with its spherical-excess area and its edge split.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LUXeKMoxpM7Vuv8Rb6E3K2
A range sampled in even steps ends at a + (b − a)·1, which may round one ulp past b, where
find_span gave no span and every B-spline evaluation there failed. The import's loop area
(the reader's sampling of each pcurve, used to turn over a face whose outer loop runs
clockwise) then had no value, the face was left as written, and the record check refused
it: "outer loop runs clockwise in (u, v)" on 7 of Poppy Humanoid's solids. The same step
had refused closed-form pcurves (426924937). find_span now takes a parameter within 8 ulps of
the domain's magnitude past an end as that end; farther is outside, as before. It fixes the
pattern for every caller rather than each sampling loop.
Poppy: 232 → 242 bodies, 15 → 7 solids not imported; the kernel tests as before.
Test: Poppy's interval's last step rounds past its end and finds the end's span; 1e-9
past is still outside.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LUXeKMoxpM7Vuv8Rb6E3K2
SMLib may end an edge at a parameter of its own: a knot its vertex lies at (-1.0 where the
vertex's angle gives -0.99999998, a 2e-8 step on the edge's quarter arc, far under 1e-6 mm).
We refused any change beyond 1e-9 of the parameter, a bound with no geometric meaning:
"SMLib moved an edge's interval" on 8 of Poppy Humanoid's faces. The ends SMLib chose are now
measured on the edge's curve: within the edge's tolerance, its pcurve is mapped onto our
interval by the affine change of parameter (exact for a B-spline: its knots move), and the
record's check measures it as any pcurve; farther is SMLib trimming the edge, refused with
how far.
Poppy: 227 → 232 bodies, 17 → 15 solids not imported, no interval refusals left.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LUXeKMoxpM7Vuv8Rb6E3K2
When an edge's tolerance is raised to the gap it has, the vertices at its ends now cover it
too, as in any tolerant record (SMLib takes the vertex's zone as at least its edges'). The
edge measures sample the interval's end as t1 itself: t0 + (t1 − t0)·1 may round past it.
(This commit also measured spline faces up front by nearest point; 04de97cd9 takes that out.)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The closed-form pcurve's lift check sampled t0 + (t1 − t0)·k/n, which at k = n can round
one step past t1 (1.2985843833752289 for an end of 1.2985843833752286), where the pcurve
on [t0, t1] has no point: the closed form was refused, and on a plane, which has no
parameter box for a kernel's pcurves, the face with it ("a face on an unbounded surface
without closed-form pcurves", Poppy Humanoid's Combine1 and others). The end is now t1.
Test: Poppy's interval on a spline on a plane; without the fix, "no exact pcurve of a
B-spline on a plane".
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LUXeKMoxpM7Vuv8Rb6E3K2
Pins tangency-labs/smlib 1072d1b (release prebuilt-1072d1b857de…): an N-sided corner
patch now meets each round on the round's own exact section edge instead of its polynomial
approximation, which the stitch kept on a near tie at some corners (solidcore#1377).
SMLIB_PREBUILT rewritten by scripts/fetch-smlib.sh --pin.
The kernel's tess, display_mesh, step, corner and fillet tests fail the same 63 as with the
previous pin, none new.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Brep::validate lets a pcurve's interval differ from its edge's by PCURVE_INTERVAL (1e-9
of the magnitude: rounding room), but check_geometry then evaluated the pcurve at the
edge's own ends and samples, which may lie just past it: "the pcurve has no point at
2.0000000000082903" on four of Poppy Humanoid's solids, circle edges whose end vertex
sits on a quarter of their form, where SMLib's pcurve ends on the knot. Both of the
check's pcurve readings (the use's points and the loop's area) now take the edge
parameter on the pcurve's interval, through one reader.
Poppy: 195 → 199 bodies, 41 → 37 solids not imported; the corpus survey and the kernel
tests are as before.
Test: a pcurve whose interval ends 1e-11 short of its edge's validates and checks;
without the clamp, "the pcurve has no point at 1".
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LUXeKMoxpM7Vuv8Rb6E3K2
A closed-form pcurve (a B-spline edge's control points projected onto its plane) is
accepted within half its edge's tolerance, and the edge carried the file's: Poppy
Humanoid has planes whose B-spline edges stand 9 µm off them in a file that states
10 µm. The closed form was refused, and a plane has no parameter box for SMLib to make
pcurves in: "a face on an unbounded surface without closed-form pcurves" on 11 of its
solids. On a plane, cylinder, cone, sphere or torus (nearest points in closed form)
each edge's distance from the surface is now measured along it first, and its
tolerance covers three times that; a spline face's gaps stay measured on its kernel's
pcurves, with the 1.5 × margin of a vertex's. The pcurve code reads each use's own
tolerance.
Poppy: 194 → 195 bodies, the unbounded-surface refusals 11 → 3 (the solids they let
through now stop at later steps); the corpus survey and the kernel tests are as before.
Test: a plane face whose B-spline edges stand 0.8e-6 mm above it in a file stating
1e-6 mm imports with its closed forms; without the measure it fails as Poppy's did.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LUXeKMoxpM7Vuv8Rb6E3K2
A TOROIDAL_SURFACE whose tube reaches its axis (major radius at most the minor, or
written with a negative major radius) and a DEGENERATE_TOROIDAL_SURFACE were refused.
They are read as what they are: the tube's meridian circle (centre C + R·X, its angle
from X towards Z) revolved about the axis, the same points and normal as ISO 10303-42's
formula, a negative R putting the tube's centre across the axis.
A revolved circle or ellipse that meets its axis is now its whole arc on the face's
side, pole to pole, in closed form (where s0 + M cos(t - phi) = 0), and its NURBS form
is cut there exactly (Boehm knot insertion, bspline::segment): the parameter stays the
quarter grid's, so the edges' forms and straight pcurves are unchanged, and the surface
ends at the poles instead of running on to whole quarters past the axis (which folded
the surface over itself, and left a face with one bound around the axis without its
pole). The face's boundary picks the apple or the lemon.
On Poppy Humanoid 22 solids were refused for these tori; with the SMLib fixes before
this none of their torus faces fails: Poppy 42 -> 27 solids not imported, 194 -> 215
bodies.
Tests (hand-written files, analytic answers): a horn torus round of radius 1 on a pin
(V = 8 pi + pi(5/3 + pi/2)); a spindle torus pin end (major 1, minor 2, its apex in a
dimple at z = sqrt 3, V = 3 sqrt3 pi + 8 pi^2/3 on the cylinder) as TOROIDAL and
DEGENERATE_TOROIDAL, with a seam to the pole and with one bound; a nearly round end
(0.005 / 0.345) in two halves with SolidWorks's apex vertex; the lemon of a spindle torus
as one seam-bounded face with major radius -1 and as a degenerate torus with its lemon
selected (V = pi(6 sqrt3 - 8 pi/3)). Volumes and areas within 1e-3.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LUXeKMoxpM7Vuv8Rb6E3K2
The pcurves close a face's loop through a pole to within the face's tolerance (a
point where crossing half a period moves less than that): there the periodic parameter
is free and the loop jumps across. The reader's check that no loop crosses a seam
without a seam edge took a pole only exactly (1e-9 relative), so it refused the loops
the pcurves had closed near one. Poppy Humanoid's nearly round pin ends (a spindle
torus of major radius 0.005, minor 0.345) have their apex vertex at the tube's top,
3.6e-5 mm above the true pole: their meridians end 1.7e-6 rad short of it, and 13
faces were refused. Both now use one test, SurfaceEval::pole_within.
Test: a point 2e-7 mm from a sphere's axis is a pole within 1e-6 mm, not within 1e-7.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LUXeKMoxpM7Vuv8Rb6E3K2
A revolved circle whose centre is as far from the axis as its radius (a horn torus, its
tube touching the axis) measured its major radius a few ulps above its minor from the
profile's control points, became SMLib's ring torus, and SMLib refused it
(SM_ERR_INVALID_INPUT: no ring torus of that NURBS). A ring torus now needs its tube
clear of the axis by more than rounding (1e-9 of the radius, the slack the same test
already takes for the circle's plane); a horn torus goes as its rational B-spline.
Test: a revolved unit circle 1.5 from the axis is a ring torus; at 1, 1 + 4 ulp and 0.5
it stays a revolution (develop calls the first two ring tori).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LUXeKMoxpM7Vuv8Rb6E3K2
A face on a placed revolution that carries its NURBS form (every STEP surface of
revolution, read since b6a3b31ff) was written as two NURBS blocks: the revolution's own
net, then the form, flagged FACE_NURBS_FORM on a NURBS face. SMLib reads one block per
face, so the flat arrays did not add up and it refused the body (SM_ERR_INVALID_INPUT),
in the main import and in the one-face sheets SMLib makes pcurves on. SMLib has no class
for a revolution: the form is the face, its range and trims already in its parameters,
so it now goes as that NURBS face with no form flag. A revolution the analytic pass
recognises (a plane, cylinder, cone, sphere, ring torus) is unchanged.
Test: surface_of_revolution_sense_follows_iso, which develop fails with the refusal,
passes.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LUXeKMoxpM7Vuv8Rb6E3K2
Each edge is sampled on its own, and a short one within the chord tolerance is one
segment. A face bounded by two such edges (a lens of short arcs, a sliver strip of a
cylinder between two rulings) had two chords on one line: "degenerate boundary", and
the whole body's display mesh failed with it (one of Poppy Humanoid's bodies lost all
336 faces to one sliver). Such a loop's segments are now halved until it has three; the
new nodes are on the edges' curves and shared by every face that runs them.
Test: a lens of two radius-1000 arcs beside a 2 m face meshes; without the split it
fails with the same error.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LUXeKMoxpM7Vuv8Rb6E3K2
An edge's curve as a file writes it may lie off a face's surface by more than the
file's stated uncertainty: Poppy Humanoid's intersection curves lie up to 9 µm off
surfaces in a file that states 0.01 µm, and 24 of its solids were refused by the
record check ("pcurve … lifts off its edge's curve"). Each use's gap, between its
pcurve on the surface and its edge's curve, is now measured along the edge at 17
points as the record check measures it, and the edge's tolerance covers it (1.5 ×
the gap, as a vertex's covers its gap; more than 1 mm is refused). The pcurves are as
made, and each solid's notes say how many edges were raised and how far.
The pcurve fit's tenfold retries went in 6cc0401fa; this measures instead of
retrying. On the corpus (the repository's STEP/IGES files, the models repository,
Poppy): 50 → 53 of 56 files import; Poppy 132 → 194 bodies.
Test: a hand-written domed patch whose edges are written 0.2 µm above it (SMLib makes
its pcurves) imports with them covered; 1.5 mm off is refused.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LUXeKMoxpM7Vuv8Rb6E3K2
New metric tapped holes drill the tap maker's drill (M8 6.8 mm). The Design preference "Metric
tapped holes drill the major diameter less the pitch" (`metric_tap_drill_major_less_pitch`, off
by default) gives them the drill every metric size took before (M8 6.75 mm): the Hole dialog
shows and sends it, and `solid.hole` given a thread and no `diameter` drills it, through the
session as `auto_project` is (kept when a design is opened or started, and across tabs). Unified,
pipe and taper sizes keep their tabulated drills; a given diameter is unchanged. Saved designs
keep the drill they stored either way.
Labels in en, ar, he, ja, zh, de and ko.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LUXeKMoxpM7Vuv8Rb6E3K2
Every tapped hole now drills the tap maker's tabulated drill. ISO metric takes Yamawa YEU23's
drill size column for cutting taps (printed p.704, M coarse; pp.704 to 706, MF fine): M8 drills
6.8 mm and M12 10.3 mm, where the major less the pitch gave 6.75 and 10.25. A custom metric size
the table lacks keeps the major less the pitch. UNC/UNF (Guhring), G, Rp, Rc and NPT (Yamawa)
were tabulated already. The Thread command's suggested hole for a metric size follows.
The Hole dialog's Tap drill diameter is now a field, the tap maker's drill by default, and the
command's `diameter` with a thread is checked the same way: a drill is accepted from the
internal thread's standard minor diameter (or the tap maker's drill where that lies below it:
Rp, Rc, NPT) to 5% over the tap maker's drill. Outside that the command names the range and
why. The field's tooltip gives the drill, the minor diameter and the range. Presets keep a
chosen drill.
A saved design keeps the diameter it stored, so it builds as before, and editing such a hole
keeps its drill: no preference and no format change. Scripts that give a thread without a
diameter drill the new default; ladder 05/007, 11/003 and rig case threads/2115 follow
analytically, and their golden entries are re-measured from runs (tier 05 re-sorted by time).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LUXeKMoxpM7Vuv8Rb6E3K2
The Rc and NPT drills were rounded to a drill series from a third-party reproduction of DIN 345
and a fractional/letter inch series cited from memory. They now come from the same tap maker's
catalogue the G and Rp drills do: Yamawa YEU23, printed p.709 (Rc, the maximum straight bored
hole with non-full threads, Rc 1/16 to 4) and p.710 (NPT, the maximum straight bored hole, 1/16
to 3). A size its tables lack (Rc 5 and 6, NPT 3 1/2 to 12) is refused as a tapped hole, naming
the range. The dialog's tooltip keeps the standard's minor diameter where the thread ends.
Rc 1/2 drills 17.6 mm (minor 17.807), 1/2 NPT 17.60 mm (minor 17.473).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LUXeKMoxpM7Vuv8Rb6E3K2
An Rc or NPT hole was drilled to the exact minor diameter where the thread ends, a size no shop
stocks. It now takes the largest stocked drill not larger than that: metric drills of the DIN 345
series for Rc (to 100 mm), letter and fractional inch drills by 64ths (to 1 1/2 in, ASME B94.11M)
for NPT; past the series it is bored to the exact value. The Hole dialog's drill shows the inch
size for NPT, and its tooltip the exact standard value. Rc 1/2: 17.807 mm, drilled 17.75 mm;
1/2 NPT: 17.473 mm, drilled 11/16 in (17.4625 mm).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LUXeKMoxpM7Vuv8Rb6E3K2
A preset's thread options save `modeled` and `ease_out` (a named ISO 3508 runout or the fade's
length, kept portable as the other lengths are) and recall them into the dialog. A runout
without a modelled thread is no preset's. Recalling checked the thread with the metric parser
only, so a UNC, G, Rp, Rc or NPT preset was refused; it checks the tapped-thread catalogue now.
An older preset without these options recalls as before: listed, square.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LUXeKMoxpM7Vuv8Rb6E3K2
Ladder 06/017's golden entry was edited by hand when the chamfered tip moved to ISO 724's d3.
Re-measured by running the case (solidcraft-cli kernel-cases on SMLib): its counts, area and
volume are the ones written by hand; its time is the run's. The tier's order by time holds.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The tapped-hole catalogue takes ISO 7-1's Rc and ASME B1.20.1's NPT internal taper threads,
every size of the tables a modelled thread cuts. Their drill is the internal minor diameter where
the thread ends (the reference plane's minor at the face less the 1 in 16 taper over the useful
or effective thread length), derived from the standards rather than a tap maker's table. An
external R is still no hole's.
A tapped hole's options mirror the thread's: `modeled` cuts its thread into the wall, from the
entry, by the same cut as `solid.thread` (now one function both call), and `ease_out` fades its
inner end out before the bottom (ISO 3508); without it the groove stops square at the thread
depth, clear of a blind hole's bottom. The Hole dialog's Tapped rows add Rc and NPT, Modeled
and the End choice (Square, Fade, Fade Length). The format notes in pending/thread-ends.rs and
pending/pipe-threads.rs record the new keys and sizes.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The thread dialog offers the pipe threads: G (ISO 228-1), Rp (ISO 7-1), R and Rc (ISO 7-1) and
NPT (ASME B1.20.1). Their sizes are listed by designation without a pitch, one start and a hand
of right or left; a size picked for a hole the dialog sized Rc stays Rc.
Rp, ISO 7-1's parallel internal thread an R screws into, is a form of its own (`rp`): the
parallel profile (H = 0.960491 P) at ISO 7-1's gauge diameters, refused on a shaft. Its cut
meets the analytic material of its profile within 1e-5, as G does.
A taper thread takes a chamfered tip: each end's cone is measured from the major diameter the
taper has at that end. Pipe threads are not ISO metric, so they give chamfer_depth.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The thread's start is its free end: it runs off plain or chamfered (ISO 4753). Its inner end
stops square in its own profile or fades over a length; an empty Fade Length is ISO 3508's
runout (2.5 P, or 1.25 P for a thread saved short). A thread saved chamfered at both ends keeps
that. "Square" is its own message (thread.end_square), apart from the geometric square. The
new labels are in en, ar, he, ja, zh, de and ko; Extent, Ends, the chamfer labels and the ISO
4753 hint come from the catalog entries already on develop.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A thread's start runs off its free end, plain or chamfered; only its inner end fades out
(ease_out) or stops square. The `ease_in` field, the command parameter (refused now, naming
ease_out), the dialog's Ease In row and their docs are removed; `pending/thread-ends.rs`
drops a saved `ease_in` as the design opens. The runout test covers the short, standard and a
sub-turn fade at the inner end.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The free-end test looked for material 1 to 1.5 pitches past the face's end, beyond the first
pitch so that a chamfer the groove runs out through counts as free. A plate thinner than that
(a boss on a 1 mm plate under M10) had none there, so its top was taken for a free end and
the groove's one-pitch overrun cut into the plate (15 mm³ of a 1 mm plate).
An end is now closed when, over the overrun's whole reach, material lies outside the face's
cylinder (inside it, for a hole) at the radii the groove cuts beyond the face: a shoulder,
plate, head or blind bottom, however thin, steps out past the face, while a chamfer, neck,
countersink or counterbore steps the other way. The band test beyond the first pitch stays
for a cylinder that goes on past a split.
The regression test builds the boss as the app does (a rounded plate, a circle sketched on its
top face, extruded with Join) on 6 and 1 mm plates.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Three forms: `bspp` (G, ISO 228-1, 55° parallel), `bspt` (R external, Rc internal, ISO 7-1,
55° taper 1 in 16) and `npt` (ASME B1.20.1, 60° taper 1 in 16). Their sizes are tabulated
from the public sources: ISO 7-1:1978 Table 1 (its gauge-plane diameters are the G sizes)
and NBS Handbook H28 (1957) Table VII.2; tests check every row against the standards' own
relations.
A taper thread starts at its free end with its standard diameter there (external: the gauge
diameter its gauge length in, internal: at the face). Its groove is the screw sweep with the
section moved 1/32 of the axial travel off the axis (the radial law the runouts use, added to
it), its section reaching just past the crest, and the material beyond the major cone (or
inside the minor cone) is cut with it, as a die or tap cuts the crests. An external one runs
its standard length by default.
The volumes are checked against the profile's material fraction integrated over the tapered
radii: G 1/2 to 2e-6, R 1/2, Rc 1/2 and 1/2-14 NPT within 0.2 % of the cut.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
`tip` was none|chamfer, chamfer cutting every free end. It is now none|start|both: `start`
chamfers the end the thread starts from, refused when that end is not free (a shoulder, or a
stop inside the face), and `both` every free end as `chamfer` did. The dialog's Tip pick offers
None, Start and Both; `tip: chamfer` in a command names its replacements.
The thread's end options (runouts, tip, chamfer angle and depth) came without a format
change file; `pending/thread-ends.rs` records them and rewrites a saved `tip: chamfer` to
`both`.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ISO 4753's chamfered end bounds the end's diameter by the minor diameter. The default took the
modelled root (the basic d1) for it, so the cone's small circle lay on the root cylinder and
the chamfer ring pinched to nothing wherever the groove reached the end. The default is now
the external minor diameter d3 = d - 1.226869 P of ISO 724, below d1: the cone crosses the
root, each end is a whole disk of d3 inside a whole conical ring. ISO 4753 is for ISO metric
threads; the other forms, whose root is already their design minor, give chamfer_depth.
Ladder 06/017's analytic volume follows (1945.354522563); its golden entry re-measured.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A regression test for the groove stopping at the plate's top: the boss loses the
closed-form volume and the plate keeps all of its 9600 mm³, with and without a runout
and a chamfered tip.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Curvature continuous is the Type entry's name; Corners (Ball, Smooth patch) and Setback are
described with the command words they write. The codes (G1, G2) stay in the text, where they
explain the words.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LUXeKMoxpM7Vuv8Rb6E3K2
Patch, Boundary and Blend Surface list Position, Tangent, Curvature and Curvature change; each
order's code (G0 to G3) and what it means is in the row's hover text. The Continuity Analysis
legend, its seam markers and its status line use the same words (Crease for a G0 seam). The
segments now draw their labels translated. The new labels carry over each catalog's existing
translation with the code taken off, so no language loses its wording; a word another label
already translates keeps that translation.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LUXeKMoxpM7Vuv8Rb6E3K2
The Continuity G1|G2 control repeated Type (both set `type`) and G1 silently cleared the
corner; it is gone, and Type names the section in words: "Curvature continuous", its code (G2)
in the row's hover text. The vertex choice moves out of Advanced as Corners: Ball | Smooth
patch, shown only while the edges have a corner where three or more rounded edges meet (or the
fillet already has a smooth patch), enabled for Constant radius with Exact fit and saying why
when not. Smooth patch shows Setback: one distance for every corner, sent as `setbacks` at each
corner's vertex; left empty, the command's default (1.5 x the radius) applies. A fillet saved
with setbacks reopens with them: one distance at exactly the dialog's corners shows in Setback,
any other list is kept as saved. "Smooth" in Variable Radius is "Smooth radius change". The
stale "G2 corner construction is not supported yet" tooltip and the "Fit and G2 corners" note
are replaced by new messages (en, ar, de, he, ja, ko, zh).
No command parameter changes; saved designs open unchanged.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LUXeKMoxpM7Vuv8Rb6E3K2
A face whose boundary crosses itself in (u, v) (a cusp, a sliver whose sides
sag across each other) was an error, and the body had no display plan. It is
now planned once more with a lenient constrained Delaunay in (u, v): sides
crossing one already kept are left out, the rest is seeded and refined as any
face, and its points lie on the surface, where the GPU evaluates them. The
display has no hole, but the face is still a defect upstream, in its pcurves
or seams: PlanStats::lenient names it with the strict plan's refusal, and the
display plan logs a warning for each such face, so it is never silent.
The face boundaries keep coming from the exact pcurves (d61efb306); cdt::Fill
gets its `lenient` field back (dropped in 3f2585569). The old flat fill (#4021,
tess/fallback.rs) stays gone: develop removed it in 9138e8704. A face the
lenient fill refuses too (loops that do not close in (u, v), or wind round a
seam or pole) stays an error naming the face. Closes#4453's intent on develop.
(cherry picked from commit 84de5aa071)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LUXeKMoxpM7Vuv8Rb6E3K2
SMLib's out_failed_corner reaches Rust as Error::CornerRefused { corner }, and the
kernel names the corner by its point: a G2 fillet at a corner of mixed convexity
says where it is and that SMLib sets back only corners whose rounds are all
convex or all concave. Engine test checks the message through solid.fillet.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LUXeKMoxpM7Vuv8Rb6E3K2
The inner corner of a 20 x 20 x 10 notch in the 60 x 40 x 20 box, three
concave r5 rounds with corner: g2: one valid body of 13 faces within the box,
the patch's twelve seams jumping at most 1e-3 per mm clear of the hole's six
corners (2.7e-4 measured; the ball corner jumps 0.2). The continuity check
looks within 11 mm of the corner: the vertical round, 2.5 mm long past its
setback, meets its faces 11.2 mm out with every round's G1 jump.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The inner corner of a notch, three concave r5 rounds, takes the set-back G2
patch as a convex corner does: one valid solid with the ball corner's 13
faces, seam jump 6.3e-4 per mm clear of the hole's corners against the
ball's 0.2. A corner of two convex rounds and a concave one is refused as not
supported: SMLib sets back only corners of one convexity.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
expected.json `continuity`: over the tangent seams wholly within `within_mm`
of `near`, the curvature jump across them (exact surfaces, 65 stations a
seam) at most `curvature_jump_per_mm` clear (`clear_mm` along the seam) of the
vertices where two of them turn, where a neighbour's own G1 seam ends.
07/015, the box corner's three r5 rounds with corner: g2: one valid body of 10
faces within the box, its patch's twelve seams jumping at most 1e-3 per mm
clear of the hole's six corners by 1.2 mm (2.7e-4 measured; the ball corner
of 009 jumps 0.2). Its golden entry is the passing run's.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
FeatureKind::Fillet with corner G2 is kernel::fillet_g2_corners, its setbacks
the corners' distances (the rest 1.5 r); setbacks now go with either corner.
The engine's corner test builds the G2 corner, default and set back 7, one
closed solid of 10 faces within 0.1% of the ball corner's volume.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A corner where three or more rounded edges meet, every edge there rounded, is
set back (1.5 r unless a setback names it) and left open by SMLib
(blend_smlib::fillet_setback_open: the sheet and each corner's hole, in the
sheet's orders); each hole is filled by fill::matched_patch, the height field
over its plane fitted to the position, tangent plane and normal curvature
across the boundary of every face beside it (exact second derivatives), rounds
and planes alike, each edge's pcurve its exact projection; SMLib sews the
sheet and the patches into one solid, which must close. The history is the
sewing's carried through the sheet's, each patch face made from the rounded
edges its neighbours come from.
corner_g2 is that construction now. The polar patch over three sections it
held (never sewn in) could not be: its boundary is a closed cubic through
stations, which rounds off a corner of the loop, and the setback hole has six.
The 60 x 40 x 20 box corner of r5 rounds (07/015): 10 faces, a valid closed
solid (record and SMLib's check), curvature jump across the patch's seams
6.3e-4 per mm clear of the hole's corners against the ball's 0.2; set back 8
between the hull and prism bounds; set back 11 to 15 inside the box but by
under 7e-4; all eight corners of a box filled; refusals named.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SeamReport.stations: each station's edge fraction, gap, normal angle and
curvature jump, alongside its point, so a seam's profile (where a jump holds,
where it fades) can be read and plotted, not only its worst value.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
smlib_blend_setback_open's binding: the sheet, and per corner a Hole, its
edges in order (each starting where the one before ends), each with the face
beside it and whether that face runs it forwards. The holes' buffer starts at
64 edges a corner and grows once to the length a first call names. Tested on
the r5 box corner set back 8: 9/30/22, a sheet SMLib's check passes, one hole
of twelve edges chained end to start; an unrounded edge at the corner is
Unsupported.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fill_loop's bicubic height field over the loop's plane, fitted to the
neighbours' derivatives as well as the loop: every condition of a graph is
linear in its heights (G1: the gradient from the face's normal; G2: the second
derivative along the face's leave direction from its normal curvature), so
one banded least-squares solve with the thin-plate energy decides the surface.
Its parameters stay plane coordinates, so an edge's pcurve is still the edge
projected onto the plane, exactly.
Where a round's section meets a plane at a corner of the loop, the section has
the round's curvature and the plane is flat across its own curve: no surface
is G2 to both there. The G2 rows fade in over 15% of the run from each corner;
asked over a few cells instead, the plane's flatness to the second order along
its curve pulls the surface off the whole side. Grids go to 128 spans, which
G2 to a plane along a curved line needs. The thin-plate weight is a thousand
times fill_loop's: with the slope and curvature rows acting a little inside
the loop, the weaker one let the surface rise past a plane it is G2 to (0.06
mm at a box corner of r5 rounds set back 8).
loop_frame is fit_once's plane, shared.
Tests: the hole a setback leaves at a box corner of r5 rounds set back 8,
within 2.2e-5 of the loop, 0.027 degrees and 4.7e-4 per mm of its neighbours
clear of the corners; set back 7.5 to 15, under its planes but by under 7.2e-4;
a hole in a cylinder filled with the cylinder's own second order; refusals.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
What each category records, self and total time, the table and the Chrome
trace; the CLI's --profile and --profile-out on scripts, designs and STEP
files; diagnostics.profile over the control channel.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LUXeKMoxpM7Vuv8Rb6E3K2
The profiler is process-wide, so the engine's other tests (the schema
check's failing diagnostics.profile calls among them) record into it while
this test does. It now shows the reset by the wall time starting again,
and checks only rows that are certain to be there.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LUXeKMoxpM7Vuv8Rb6E3K2
- Graphics page: "Profile operations" (off by default) starts and stops the
profiler when it changes; an agent's diagnostics.profile in between stands,
and SOLIDCRAFT_PROFILE=1 is not undone by the default at start-up.
- The desktop app reads SOLIDCRAFT_PROFILE at start-up.
- Labels in en, ar, de, he, ja, ko, zh. The pending-messages test compares
right-to-left pending text in display order, as the catalogs give it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Session::execute is a command span; Model::evaluate and each feature computed
(by its type) are spans; io's import, export and design read/write too; the
STEP reader's topology, pcurves and solid record.
- diagnostics.profile (contract + output schema): report, start/stop, reset,
Chrome trace file.
- A STEP/IGES import's reply carries its own profile while recording.
- Every app compiles the profiler in by default (feature `profile`);
SOLIDCRAFT_PROFILE=1 starts it.
- solidcraft-cli run/eval/bench-open --profile print the table on stderr,
--profile-out writes the trace; run --profile works on designs and STEP files.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Booleans, blends, sweeps, lofts, shell/draft/offset, healing and sewing,
SMLib conversions, meshing and measuring; the import as parse, index,
per-solid read, placement and mesh check, convert batches and finish.
The existing per-step boolean/tessellate capture names its spans too.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The C API logs each call with its steady_clock time; the log sink records
that as an smlib span (child of whatever runs on the calling thread).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
solidcraft-profile (L0, standalone): spans with self and total time, SMLib-timed
records, a bounded trace (200k events) and an aggregate that stays; compiled in
with the `enabled` feature, off at run time until switched on.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
An edge is left out of the shaded view only where its two faces meet
with one tangent plane (normals within 0.5 degrees) and one curvature
across the edge: at each station the faces' normal curvatures square to
the edge agree within 0.5 degrees' worth, |k1 - k2| <= 0.0087 x
max(|k|, 1/L), L the edge's length, so the continued faces turn apart
by no more than that over a radius of curvature or the edge's length.
Fillet boundaries (0 to 1/r), corner-patch joins and a plane tangent to
a cylinder are drawn again, straight ones included. A modelled thread's
flank pieces (one sweep) differ by at most 0.0046 and stay hidden.
Second derivatives of a spline surface now exist at a boundary point a
pcurve carries a rounding step past the knot range, as its point and
first derivatives already did.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Smoothness (normals within 0.5 degrees) and a crease are separate
verdicts. A crease is certified where the normals differ by more than
the evaluation can account for: each pcurve point's measured distance
off the edge's own curve times the faces' larger principal curvatures.
So a real crease too small to see is not drawn in the shading but stays
a pickable edge in the wireframe, overriding a coarse same-surface seam
fit, as before; exact tangent joins (fillets, seams, a thread's flank
pieces) are no crease.
The viewport's smooth-wall test expects the wireframe to draw
`edge_visible` edges: the offset ellipse's pieces meet at real creases
of 1e-4 rad that the old checker could not certify.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The M10 thread's 32 flank-piece joins meet with normals about 1.5e-6
degrees apart (measured independently with seam_diagnostics); each is
left out of the shaded view, stays pickable and stays in the wireframe.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
An edge is left out of the shaded view when its two faces' outward
normals, evaluated on their exact surfaces at each use's own pcurve,
agree within half a degree at eight stations along it (a seam one face
meets itself across is the same test with its two pcurves); it is a
protected crease when they differ by more. Replaces the special cases
for ruled clamped Bezier patches, planes, cylinders and cones. Fillet
tangent joins and corner-patch joins are hidden too; they stay
pickable and in the wireframe.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The truck vendor/ crates went with the kernel's move to SMLib, so their
mapping and the test that selected the kernel for vendor/truck-shapeops
are gone; egui-wgpu is the one vendored crate left.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LUXeKMoxpM7Vuv8Rb6E3K2
A collapsible if (assemble.rs), two manual assign operations (sew.rs), a range loop indexing
the placement inverse's translation row (step_in), and two needless borrows (engine features),
which failed CI's clippy -D warnings. No behaviour change.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Seven labels of the thread dialog had no English catalog entry, so they stayed English in every
language (every_ui_label_literal_reaches_an_english_catalog_entry): Extent, Ends, Chamfer Angle,
Chamfer Depth, the two ISO 4753 hints and the designation hint. They are in
assets/locales/pending/thread-dialog-labels.json with Arabic, Hebrew, Japanese and Chinese, the
catalogs that must be complete. The ISO 4753 hints are looked up by id, and the designation hint
takes its example as {example}, so a right-to-left language places it where it reads.
pending_messages_are_in_the_catalogs compared a pending message with the catalog's text, which
for Arabic and Hebrew is in display order since #3768; it compares with that order now, as the
catalog stores it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Main's Arabic and Hebrew catalogs (#3768) arrived with thread.direction, thread.left_hand and
thread.right_hand, the labels of #4414's screw direction, which this branch replaced with the
thread's hand and took out of every catalog.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Each job fetched the prebuilt SMLib into target/ before Swatinem/rust-cache restored target/,
which replaced it, so every build that links SMLib stopped with "SMLib ... is not fetched"
(the Docker image of #7403). The fetch now follows the cache restore in every job.
develop (the SMLib kernel's trunk until it merges into main) gets main's push runs: CI runs on
pushes to it, a push compares against the last passing push to its own branch, and its runs save
the Rust caches the PRs into it restore.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Move/Copy's pick from the browser (#4774) read Session::world_state as the placed model; it now
returns why a model cannot be placed, so the browser reads it as the other panels do, through
open_meshing::session_world (no placed bodies when it cannot be placed).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
v0.24.0 (format 39) saved a left-hand Thread or tapped Hole as `handedness: "left"`; this
branch replaced main's handedness (#4414) with the thread's `hand`, and features don't refuse
unknown fields, so such a design opened right-handed without a word. The pending format change
thread-hand.rs renames `handedness` to `hand` on Hole and Thread features (a `right` is
dropped, anything else refused).
Tapped holes take `hand` again, right or left (never both, and only with `thread`): the Hole
feature saves it, its thread is cut and annotated that way, solid.hole takes `hand?`, the hole
dialog's tapped rows have the thread dialog's Hand choice (without Both), editing a hole keeps
it, and hole presets save it under v0.24.0's `thread_options.handedness` key, so presets saved
by v0.24.0 recall it.
Test: a format-39 design with a left-hand thread and tapped hole opens left-handed; a hole's
`hand` refuses both and needs a thread.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Every job that builds the kernel with SMLib runs scripts/fetch-smlib.sh after the toolchain:
the host's prebuilt archive, the matrix target's for cross builds, wasm32's for the web jobs.
RISC-V has no archive, so its check compiles the sources with g++-riscv64-linux-gnu.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HoZgkCdAVrscuw2kjQTWDs
tangency-labs/smlib's prebuilt workflow builds the C API once per commit for every Rust target
SolidCraft builds (Linux x86_64 and aarch64, macOS arm64 and x86_64, Windows x64, x86 and ARM64,
wasm32 with wasi-sdk's C++ runtime) and releases it as prebuilt-<commit>. SMLIB_PREBUILT pins each
archive's SHA-256. scripts/fetch-smlib.sh now downloads the host's archive (or the named
targets'), checks its hash and the commit it was built from, and falls back to the sources for a
target with no archive; --source fetches the sources, --pin writes SMLIB_PREBUILT from the
release. build.rs links a fetched archive whose hash matches the pin, else compiles as before,
now with -ffp-contract=off like the archives: every platform does the same arithmetic. No
network access in build.rs.
SMLIB_REV moves to 8b57e7e: the workflow, and fixes for MSVC (no directive inside a macro
argument, SM_PI for M_PI), the no-fused-multiply-add build and a test that needed a POSIX shell.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HoZgkCdAVrscuw2kjQTWDs
On the web target the smlib build compiles SMLib for wasm32-wasip1 with wasi-sdk's clang
(WASI_SDK_PATH), with wasm exceptions in the exnref encoding that wasi-sdk's libc++ and Rust
use, and links wasi-sdk's libc++, libc++abi, libunwind and libc. The WASI calls libc makes are
defined in ffi.rs: stdout and stderr go to the log, the clocks are the page's (the C API times
every call), and there is no file system or environment. solidcraft-web gets an smlib
feature, off until CI has wasi-sdk.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HoZgkCdAVrscuw2kjQTWDs
Code main added since the last rebase reads the placed model, a camera or a scene
as values; on this branch they return Result. Picks and the edit dialogs read the
session's placed model through open_meshing::session_world, as the others do; the
revolve and circular-pattern axes, the model axis of a command and the warming of a
computed edit pass the error on; tests unwrap. A test meshing bodies uses
Body::mesh, the one mesher.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HoZgkCdAVrscuw2kjQTWDs
The reworked thread has its own direction, `hand: right|left|both`, on SMLib's
exact screw sweep. Main's #4414 added a second one, `handedness: right|left`, on
Hole and Thread, for the faceted groove this branch replaces. It is taken out: the
field, its pending format change (never released), the hole dialog's direction row,
its hole-preset option, its strings and its tests, which measured the faceted
groove. A tapped hole is right-handed, as before #4414.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HoZgkCdAVrscuw2kjQTWDs
A modelled thread never changes the size of the shaft it is on (#1018, #2853): a
shaft thicker than the thread is refused with the size to make it, as
tests/kernel-cases/threads/2705 expects ("this 14.6 mm shaft is too thick for a
modelled M14 thread; make the shaft 14 mm for M14"). This takes out the turn-down
of #4256: `thread_turn`, the fit that let a thicker shaft through, and its tests;
the 9 mm shaft refusing an M8 and the preview's M6 refusal on an 8 mm shaft are
back as they were before it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HoZgkCdAVrscuw2kjQTWDs
Main's reader (#1609, #3845, #3928) and the branch's met in the rebase, and the
tree kept main's gap closing: it moved a trim piece's end vertex onto the mean
of the gap's ends without changing its curve, and widened the STEP file's
stated accuracy to cover the move. SMLib checks each edge against its vertex at
the body's tolerance and refused the box (SmTrimmingTools Edge/Edge Gap 0.005 >
0.00425, rig 3845); the first piece of a trim curve with no start point was
also turned against the second (rig 3913, "edge loop is not connected").
The reader keeps main's structure (groups and subfigure instances as products,
names, placements, separate lumps as separate solids, the originating system)
and sews each group's surfaces the branch's way: each meeting point of two
pieces is one vertex, where most piece ends there agree, and a line or clamped
B-spline that misses it is rebuilt to end there exactly. Main's limits on which
gaps are one corner written loosely (0.1 mm, 5% of the shorter piece) decide
which meeting points are joined; the stated accuracy stays the file's. A trim
curve's first piece starts at its end away from the second when no start point
is given.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The IGES reader (#1609) writes each group and subfigure instance's placement as a
CARTESIAN_TRANSFORMATION_OPERATOR_3D_NON_UNIFORM. The branch's STEP reader took
only the uniform operator, and only its origin: every IGES assembly placement
was refused ("placement location: expected a reference") and put at the origin.
An operator, uniform or not, is now read as main reads it: its axes (the global
ones where omitted), its scales (1, and the first for the second and third) and
its origin, refused when singular. A placement may then scale, so the inverse
that maps one placement onto another inverts the linear part by its adjugate
instead of transposing it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The corner pick (#5173) counts the edges meeting at a picked point; seams already
did not count, and now a tangent join between two spans of one smooth curve does
not either (4332: a chamfer on a spline rim was refused as two edges).
3383: the first occurrence is grounded by default on main, so the recipe
ungrounds it before moving it. 5024: a hole's position must lie on a face, so the
centre is on the box's top edge; the volume is half of the drilled cut, exact.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The branch's placement change (placing the model returns its error) made
world_state, home_camera, bounds, open_sketch_plane, the scene builders,
to_local and auto_operation return a Result. Main added callers of them
since the branch left it; they now take the error as the branch's own
callers do:
- engine: commands pass it on (`?`); helpers answering yes/no or "found"
(snap points, a face's normal, the DXF export check) answer no for a
model that cannot be placed. Frames keep the session for main's lazy body
frames (#6356) beside the placed model the picks are on; a library apply
maps its targets on that placed model. Before an extract or a link is
replaced, the placed model is taken or the command fails.
- ui: panels, picks, dialogs and previews read the placed model through
open_meshing::session_world (none when it cannot be placed: the viewport
says why); Home and Fit frame nothing then.
- cli: the usage table is main's, with kernel-cases in it (a resolution of
the rig's commit had kept the branch's whole file).
- tests read the Results with unwrap, and main's tests of Body::tessellate
mesh through Body::mesh. Main's test of saved boolean retries goes (the
branch saves none), as does the thread half of its dialog rendering test
(the branch's thread dialog has its own); the tapped hole half stays.
- What no caller uses after the merge goes: a mesh body's span, the metric
thread refusal text, and the revolve's targets-as-shown model (main used
it for the coplanar run-on the branch removed). Main's SolidWorks Y-up
test reads the exporting system's name (the branch's STEP header has no
preprocessor or description fields).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Main gave the Thread feature two things the branch's thread rework (forms,
hands, starts, extents, runouts, tips on ThreadAsk) was written without:
- Tapped holes take catalogue sizes (ISO metric and the catalogued UNC/UNF,
G and Rp sizes): `ThreadAsk::tapped` reads the designation from the tapped
catalogue, names the thread as the catalogue does, and fits a size that is
not metric to the hole drilled for it (its tap drill). The hole feature
asks for its thread this way.
- A modelled external thread on a shaft thicker than it turns the shaft down
to its major diameter first (#4256): main's `thread_turn` makes the ring,
the shaft is cut by it, and the grooves and a chamfered tip are cut at the
turned radius. Such a shaft fits the thread.
ThreadInfo keeps the radius of the face it is on, which main's cosmetic
thread display draws at (0 in a state saved without it).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The branch rebased onto main keeps each of its commits; where both sides
changed the same code, these are the pieces neither side's commit had.
- Cargo: one [features] table in the CLI's manifest (two met in the merge).
- geom: a NURBS surface's `closed` set once in a placed copy (both sides
added it).
- kernel: the whole-face extrude tools (#2040) work around truck's boolean
on truck types, which left the workspace with the SMLib kernel; the
module, its tests and the doc crate's tool and tests go. The display
planner's flat fill (tess/fallback.rs) has no caller with the schema 4
mesher, and the tessellator's seam and uv modules are the branch's. A
body's boundary tolerance from a STEP file belongs to the truck body the
schema 4 record replaced: `with_boundary_tol` goes. `unmeshed_faces`
counts the coarse mesh as the branch does. A loft's section re-split
passes the lead's perimeter shares to main's `resample` (a circle breaks
there when the matched corners do not go round in order). Main's tests of
the mesh-based measure (the SMLib kernel measures exactly) and of the
IGES preprocessor name (no such field on the branch's import record) go.
- doc: a feature result carries no boolean diagnostics on the branch, so
the model cache neither writes nor reads them, and a pattern copy's miss
test runs the intersect as it is. A placed body's worker result is a
Result: a body taken from the previous placement is Ok. A thread's
clipboard remap takes main's arguments, the tapped catalogue names a
metric size by ThreadForm::Metric, and main's tests unwrap the placing
calls that return their error.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The r7 on the vertical edge runs on (tangent chain) up the side's arc on the
r5 round, a circle of radius 5: its contact line on that face would be the arc
offset 7 towards its centre, so no such round exists and the right answer is
a clean refusal. 018 picks a radius that fits (r2: 11 faces, inside the box).
cases.py now writes 013 (the corner setback, graded by its convexity bounds)
instead of marking it missing; its tolerance is the interval's exact half
width.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
003 and 004 passed on one valid body alone. 003 is now the flange less
its M30 groove (stopped clear of the root round, run out through the
chamfer) and three M8 tap drills; 004 is 10/008 less the M16 groove on
the shelled boss, which cuts the wall only. With bboxes. Both hold on
SMLib (worst 1.4e-7 relative).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
It passed on one valid body alone. Each d3 vent goes through the shelled
top skin into the cavity and meets nothing else, so the case is 09/011
less 4 pi 1.5^2 1.5; with the bbox. Holds on SMLib (1e-6 relative).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
010, 011 and 014 passed on one valid body alone. 010 (top rounds in
mitres, shelled open below) and 014 (drafted box with tilted rounds:
every level section loses the same elliptic corner) now check closed-form
volumes, exact counts and bbox (014 also its centre of mass). 011, the
running part shelled 1.5, checks the part less its cavity built feature
by feature, the offset faces meeting sharp at concave edges as in the
rest of the tier (a distance-based offset would differ by 0.3%). All hold
on SMLib (worst 1e-6 relative).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
It passed on one valid body alone. It now checks the chamfer's prism, the
two r2 rounds below it and the columns they carry on up into the chamfer
face (the section's first moment), with exact counts and bbox. Holds on
SMLib (8e-9 relative).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
010, 011 and 012 passed on one valid body alone. 010 (r7 then an r3 chain
round its arc) and 011 (two r5 rounds in a mitre) now check closed-form
volumes, counts and bbox; 012's variable round takes only its edge and
runs on into the vertical round's column, so its volume is graded as the
interval between that end carried on as a constant r5 tube and as its
growing radius. All hold on SMLib (worst 4e-8 relative; 012 at the
growing-radius end).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
010 passed on one valid body alone: it now checks the tier-05 part less
the M16 groove (stopped w above the boss's shoulder, run out at its free
top) and the bbox. Two new cases with closed forms: 018, an M10 cut both
hands, whose crossing grooves leave the material fraction squared
(2 pi L int r m^2 dr, exact for L a whole number of pitches); 019, a
two-start Tr40x14(P7), six pitches of the Tr40x7 section. All hold on
SMLib (worst 2e-6 relative).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
07, 08, 09, 11 and 12 passed on one valid body alone. Each now checks
its volume, bbox and (where derived) counts, area and centre of mass:
the three-section loft is the degree-2 interpolant r = 10 + (z-20)^2/40;
the square-to-circle loft a ruled prismatoid, its mixed area from the
sides ruled to rational quarter arcs; the periodic fit spline the cyclic
C2 chord-length cubic; the pleated skins star polygons on fixed rays,
their crossing integrated exactly per wedge; the cap's union integrated
as y-intervals over x and z. All hold on SMLib (worst 9e-8 relative).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The generator had fallen behind the tree: it no longer wrote 02/021-025,
03/010, 04/011-012 and 09/012-015, and its 07/016 lacked the second round's
tangent_chain. Each is now built in cases.py; the two reporters' scripts
(04/011, 04/012) are kept verbatim in reported.py. Regenerating reproduces
the tree exactly; the only file changes are the generator's own format
(volumes to 9 decimals, one-space indent, a final newline), all under 1e-8
relative.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Three r5 rounds at (60,40,20) set back 8: the volume between the convex
hull of the body on the corner cube's faces and the rounds' prisms (both
bounds closed form or a sampled hull below the true one), the box's bbox,
and SMLib's setback-patch topology (15 faces, 36 edges, 23 vertices).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
FeatureKind::Fillet gains setbacks (serde default: none, omitted when empty),
each a corner vertex and a length expression; a fillet with setbacks is
evaluated by kernel::fillet_setback. Constant-radius exact fillets with
rolling corners only (refused otherwise, in the command and in evaluation).
One distance per corner: SMLib keeps one setback per corner, not per edge.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Each (point, distance) sets back the corner at the body's nearest vertex: its
patch starts that far along every edge there. Tested on the 60 x 40 x 20 box
corner with r5 rounds set back 8 (volume between the convex hull and the
rounds' prisms bounds, 15/36/23 topology, the box's bbox) and on refusals.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
At a pole or apex `EvalSurface::eval` takes the normal from a step beside the
point, trying (+h, +h) first. At the far end of an interval (a sphere's north
pole at u = 1) that step lands past the end, where the extrapolated surface
folds back over the pole, and the normal came out turned over: the pole vertex
shaded dark with a light ring around it (ladder 01/005, every sphere and dome).
Steps now stay inside the active interval of a spline or a revolution's
profile. The pole test checked only that the normal was radial, either way;
it now checks the side too.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Recorded on SMLib replay 2c5baae (screw sweep walls exact and within their
tolerance, the radial sweep, the point solve on long rational surfaces) with
the thread rework: 06/008 (two starts) and 06/009 (runout) now graded and
passing, 06/011-017 new (Tr, Acme, S, ASME buttress, an internal Tr nut,
left hand, the chamfered tip), and 06/003, 004 and 007 grading the extent and
the collar. 132/135 pass; left: 07/013 corner setback, 07/015 G2 corners
(unsupported) and 07/016 three sequential corner rounds.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sizes, designations and the face's size come from ThreadForm (sizes, parse,
format) and suggested_thread_in, per form; the dialog's own trapezoidal and
buttress lists are gone. Acme sizes are listed by designation. The square
thread, which the command refuses (no standard defines it), is not offered.
Editing a thread reopens its form, hand, starts, extent (length or up to, with
its pick), start end, runouts, tip and steep flank, and OK gives them back.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Ladder 06/009 had no way to ask for one: "solid.thread has no runout (vanishing thread)
length". With SMLib's smlib_screw_sweep_radial (replay e7acea1):
- smlib: the FFI binding and Brep::screw_sweep_radial, the profile moved off the axis by a
piecewise linear law of the turn; crate test: a tooth moved out 1 mm over three turns has
A 2π (c turns + ∫ offset dt).
- kernel: sweep_helix_radial, sharing sweep_helix's checks (helix_profile).
- doc: `ease_in`, `ease_out` (a length, or ISO 3508's standard 2.5 P or short 1.25 P) fade the
groove over that length, its section moving out of the material as it turns (outward for a
shaft, inward for a nut). ease_in is at the end the thread starts from. The runout lies past
the full-form length: beyond a square stop, before a shoulder up to its clearance; at a free
end inside the face. Runouts longer than the thread are refused. No end gets one by default,
so saved threads keep their geometry.
The cut is the integral over the turn of the clipped section's 2π∫ r dA: engine test (2.5 P
and 1.25 P between two collars) within the sweep's wall tolerance times the runouts' wall area
(0.029 against a 0.036 mm³ bound), ladder 06/009 (004's shaft, a 2 P runout before the
shoulder) graded in closed form (measured 1.7e-6 off).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
`tip: chamfer` cuts ISO 4753's chamfered end at each free end a modelled external thread
reaches, after the groove, so the last teeth taper into the cone instead of ending in a
ragged first turn: the material outside a cone `chamfer_angle` to the axis (default 45°)
reaching d_f = d - 2 `chamfer_depth` at the face's end (default the external minor diameter,
the largest the standard allows), a revolved ring cut by one boolean per end. Past the end the
ring keeps to the radii the groove's overrun already cuts. An internal thread is refused (its
entry takes the hole's countersink), as is a tip with no free end or on a cosmetic thread.
The cone is axisymmetric and cut after the screw-symmetric groove, so the volume is the stock's
chamfered section with the thread's material fraction: engine test (both ends 45°, and 30°
x 0.5 mm at a shaft's one free end above a collar) within 1e-4, ladder 06/017 (measured
2.4e-7 off).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Ladder 06/008 had no way to ask for one: "solid.thread has no start count". `starts: n` (1 to
8) cuts n grooves of lead n x P, the j-th a j/n turn round from the first (the same helix j
pitches along), in one boolean with their union. A designation that gives the lead
(M16xPh3P1.5, Tr40x14(P7)) gives the starts, and a `starts` that disagrees is refused. The
helix's self-clearance check and the turn limit use the lead.
Over the same length n grooves of lead nP take the volume of one start of pitch P: engine test
(2 and 3 starts, M10xPh3P1.5) within 1e-4 of the closed form, ladder 06/008 graded as 001
(measured 3.5e-7 off).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Only the ISO metric 60° thread existed. Forms now (crates/doc/src/thread_forms.rs, values and
sources in docs/threads.md): ISO metric (ISO 68-1), trapezoidal (ISO 2904 design profile, ISO
2902 sizes), general purpose Acme (ASME B1.5), metric buttress 3°/30° (DIN 513), buttress inch
7°/45° (ASME B1.9 basic profile). Each has its groove as a straight-flanked polygon, its standard
sizes (none for ASME buttress), its designations (M10, M16xPh3P1.5, Tr40x14(P7), S20x4,
1/2-10 ACME, 2.5-8 BUTT) and the size that fits a face. The square thread is refused: no current
standard defines it.
`hand: right | left | both`: a left-handed groove is the screw motion about the reversed axis
rising along it; both cuts the two grooves, crossing, in one boolean. `steep_flank` turns a
buttress. The design diameters are checked against the published tables (ISO 2904/DIN 103,
DIN 513 via IS 4696-3); every form's cut against 2π∫ r w(r) dr per turn to 1e-4 in engine tests
and to 1e-4 in ladder 06/011 to 016 (they measure within 5e-7).
FeatureKind::Thread holds every option the command has (form, hand, starts, ease_in, ease_out,
tip, chamfer_angle, chamfer_depth, steep_flank, all defaulted so saved threads load unchanged);
starts, runouts and the chamfered tip are refused as not built yet. suggested_thread_in takes the
form.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A thread of some length ran from "the end of the face nearest the pick", a coin toss for a
pick in the middle (rig 602's 4 mm thread meant for the free bottom end ran at the head end,
cutting 1.17 mm into the hex), and every thread end at a face end got a one-pitch overrun,
which at a shoulder gouged the material past it (ladder 06/004 cut 0.9% of its volume out of
the collar).
- kernel: material_in_ring, the exact intersection of a body with a ring about a cylinder
face's axis, by an SMLib boolean.
- doc: a face end is free when no material lies past it, over the span the groove's one-pitch
overrun reaches beyond its first pitch, within the radii the groove cuts (a cap, a chamfer
the groove runs out through, a counterbore). At a free end the groove runs out as before; at
a closed one (a shoulder, a head, a blind hole's bottom) it stops with its widest part clear
of it; inside the face it stops square.
- doc: a thread of some length starts at the end nearest `from`, else at the face's only free
end, else at the end the pick lies within a third of the face of; a pick in the middle of a
face whose ends are alike is refused, naming `from`. A length as long as the face runs the
whole face. `up_to` a plane or a point's place along the axis. New fields `from`, `up_to`
default to none, so saved threads keep their meaning where it was not a coin toss.
- engine: solid.thread takes extent (full|length|up_to), from and up_to.
- ladder 06/003 (now with `from`), 004 and 007 are graded by volume and centre of mass in
closed form (a square stop inside material removes exactly length/P turns, the section being
symmetric); rig 602's method says why the thread is at the bottom, tolerance 0.02%.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Form (ISO metric, trapezoidal, Acme, ISO and ASME buttress, square), size and
pitch from the form's list, hand, starts, extent (full, length or up to, with
the end to start from), ease in and out (standard, short or a length), the
chamfered tip and the buttress steep flank. Only the fields that apply are
shown; a form change keeps the options and a manual size's diameter where
the new form lists it. Defaults stay out of the command, so a plain thread
means what it did.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The ISO metric table, the thread on a cylindrical face, the groove shape and the thread
feature's evaluation move from eval.rs to eval_thread.rs, unchanged, before the extents,
forms and starts work changes them.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A face's boundary nodes are its edges', shared with the neighbouring face.
On a nearly straight stretch (the base of a thread flank's corner, clipped by
a hex head's flats, on an iso-line of the helix) refinement met slivers
between consecutive boundary nodes: their centroid, or the middle of their
inner edge, lies on the boundary chord to rounding. Inserting it split the
boundary constraint, and the face was refused ("boundary crosses itself";
rig threads/602, refused while the body was meshed to pick the fillet's
edges). A sliver whose centroid lies on the boundary is now split at its
inner edges' middles, and a refinement point that lands on the boundary is
not inserted.
The 602 engine test assumed the old kernel's faceted thread (over 1000
faces); with SMLib the thread is exact, and the test now checks that the
fillet finishes and removes a little material.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Three new cases in closed form: two through holes touching at a point
(02/021), the stock shelled with no face open (09/012, a sealed void, two
shells) and a dome shelled from its flat base (09/013, its rim the circle
r18). Nine rig cases copied into their tiers: a cylinder grazing a hole's
edge (1279), lips 1e-4 off a base's walls (2928), wall halves merged into a
flange (494), flush chord layers (5197), the horn torus revolve (4007),
crossing pleated loft skins (4623), loft ribs joined to a rounded pad (4092),
a drafted box with rounds shelled (3576) and a shelled dome with its ring
joined back (4847). Golden recorded on SMLib replay 8017df9: 123/128 pass.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A notch cut into a sheet's base is a cut-out, so the base outline that
edge_at and the edge names read has no edge along it: a flange picked on
the notch's bottom edge took the name of the nearest outline edge (the
plate's far edge) and was built on the stretch of it the notch left. A
pick nearer a notch's edge than any outline edge now names no edge, and
the flange runs the base's outline round that notch first, keeping as a
cut-out only what it takes of the flanges, then trims and bends as on any
edge of the outline. The edge of a hole inside the base is refused.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Convert to Sheet Metal keeps a shell's (and a plate's) own thickness, but
the rule's values were evaluated with `Thickness` the rule's: under the
default rule (2.5 mm, bend radius `Thickness`) an L 2 mm thick with its
bend modelled R 2 was rebuilt bent R 2.5, losing 8.58 mm3 (2659.911
against 2668.496), and its gap and reliefs followed 2.5 mm too. The rule
is now evaluated for the sheet's thickness (Document::rule_values_at):
in the conversion once the shell's thickness is known, for a converted
plate, and for the flanges, hems and folds added to an existing sheet.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
solid.mirror and solid.pattern of bodies pushed each copy as a plain body:
no sheet model went with it, so its flat pattern, DXF and bend table were
refused ("`Body1 (2)` is not a sheet metal body"). Each copy now gets its
source's sheet model moved with it (SheetBody::moved). A reflection turns
the frame's handedness over, so a mirrored copy's frame sits on the moved
top face, thickness growing back toward the moved bottom: the same blank,
each bend turning the other way, machining depths taken from the other
face. A sheet feature on the copy rebuilds it in place.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The countersink's cone started 1% of the drilled body's size above the
entry face, widening on to rc + top tan(half) there, so above the face
it cut beyond the countersink's rim: a wall 0.15 mm from the rim was
notched (#5041, 12 faces instead of 10). The tool is now one revolved
profile: the cone from its rim on the face to just inside the bore, and
above the face the rim's own cylinder, as the bore's cylinder runs on
above it. The cone stays the profile's first segment (csink:side:0).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A Combine took its tools in their own component's coordinates and joined
them to a target kept in another component's: a root body joined into a
body of a component turned a quarter turn landed where the turn carries
its root coordinates (#3383, 2 shells and 17000 mm3 instead of one solid
of 16750). Each tool is now moved through its own placement and the
inverse of the target's (component placement, then body offset), as
state_in_frame places bodies, and a combine's cache key follows the
placements so moving a component recomputes it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The case's base is a stadium ring (r 3..5 arcs, centres 20 apart, z 0..2),
as its description and expected volume (2 (80 + 16 pi) for the base) say,
but its extrude picked no profile, and "all profiles" is every drawn region:
the ring and the stadium island inside it. The base came out filled and the
join 1066 mm3. SMLib's union was exact for those operands. The extrude now
picks the ring (the region at (4, 0)).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The record's torus label is a ring torus (major > minor; the validator
refuses any other). SMLib keeps horn and spindle tori: a half disc revolved
about a line through its rim's end is a horn torus, its major radius a
rounding below its minor, and the export wrote it as a torus label the
record then refused (rig sweeps/4007, "ring torus radii"). Such a face is
now its NURBS form, unlabelled, which is its geometry in any case.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
solid.shell refused an empty face list ("select 1…1000 faces"), and the
shell feature found its body from the first face picked. SMLib shells with no
face opened (the void sealed inside, its own shell): the command now takes
`faces: []`, the feature shells the one body there is or the one named
(`body`), and an outside or both-ways shell pushes no open face out of the
cavity. Rig shell/4009 declares the void's shell (`shells: 2`), as its method
says.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Where a face's loops pass a vertex more than once (two holes touching at a
point, a loop through another hole's corner), each pass took its parameters
from the pcurve of the edge leaving it, and the two pcurves round them 1e-14
apart. The triangulation got two nodes 1e-14 apart with constraints crossing
between them and refused the face ("boundary crosses itself"): rig 307, 3092
and 3887. A pass whose parameters agree with the vertex's first pass to that
rounding (1e-9 relative) now takes the first's; farther apart they are two
places of the surface (a seam's two sides, a closed spline's ends).
Rig 494 now fails: its revolved face has a dead-end edge walked down and back
up in one loop, which met the triangulation as a needle 1e-14 wide and now as
the slit it is.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fillet_max bisected the radius down on any error of a candidate fillet,
not only KernelError::TooLarge, and fillet_max_each fell back to one
radius for all on any error of a group or of the combined fillet. A
kernel failure at the radius asked for (or at any candidate) came back
as a smaller radius reported as "the largest that fits".
fillet_max and fillet_max_each now return Result<Option<..>>: only
TooLarge narrows the search or falls back to one radius, and any other
error is passed on. Ok(None) is still "no radius fits". The doc's
FilletFit::Reduce passes the error on. The test of a point with no edge
near it now expects the fillet's own error, not "no radius".
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The pieces of an IGES trim curve run on from one another, and the sewer made
each meeting point one vertex, but left a piece that missed it where it was,
the gap on the vertex's tolerance: an edge 0.01 mm short of its corner, 2000
times the file's resolution, which SMLib refuses (SmTrimmingTools #0, SmBrep
line or clamped B-spline piece that misses it is made to end there exactly;
any other piece that misses keeps its ends, and the gap is reported.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0113gDVmStT5tCGKW9Fxgc5K
A cone face bounded by its base circle and its seam out to the apex and back
turns once round the axis and closes at the apex. add_seams counted the turn
as a loop without a seam and added another, out and back from the same
vertex: the drill point of a turned pin read back from STEP had a sliver
whose boundary crossed itself, and the body would not tessellate (#5193). A
winding loop with a vertex on a pole is left as it is.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0113gDVmStT5tCGKW9Fxgc5K
form::extent took the box of 32 points per edge. A face's NURBS form is built
over that box, so where the boundary peaks between two samples the form
stopped short of its edge: the re-imported rod's bore ended at v = 9.99977
while its intersection with the rod reaches 10, and SMLib found the edge
1.9e-4 off the bore (SmBrep #4, SmEdge #13). Each sample higher or lower
than its neighbours now brackets the edge's extreme there, found by golden
section.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0113gDVmStT5tCGKW9Fxgc5K
form::extent unwrapped each loop of a face from its own first point, so a
hole beside the seam (a cross bore through a rod at the rod's seam angle)
came out a period away from the outer loop. The box over both was more than a
turn, cut to one turn from the hole: the face's NURBS form ran over quarters
3..7 while its seam uses lay at 4 and 8, and SMLib found the re-imported
rod's edge ends outside its face domain (SmBrep #70-#72). Each loop after the
first now goes the whole periods along that keep the face's box smallest.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0113gDVmStT5tCGKW9Fxgc5K
tangent_chain followed tangent edges without looking at their convexity: a boss's concave base
arc that runs on tangentially as the convex rim of the overhang above it (rig fillets/4174,
4369) and a convex outline running into the concave edges under an overhang (4365) were sent to
SMLib as one chain. No round can pass from one side of the faces to the other, the cases'
answers stop at that vertex, and SMLib rightly refused the request (1001 in its Nx2 corner).
A chain no longer runs on into an edge of the other convexity: convex(e, v) tells, from the
second face's natural normal, the loop's direction and the first face's normal, whether the
faces meet at less than 180 degrees inside the body. With SMLib's corner and end fixes this
makes rig 4174, 4365 and 4369 pass with their analytic answers; nothing else changes.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0113gDVmStT5tCGKW9Fxgc5K
Rig case shell/4711 (a 60 x 40 x 10 block, an r3 through hole at (22.5, 7), a 10 x 10 notch on
the front edge, shelled 2 open at the bottom) failed with "SMLib shell: operation: SMLib failed
(status 1027)". The hole is 4 = 2 x 2 from the front face: the hole wall's offset (r5) is tangent
to the front's at (22.5, 2), the walls meet along a line and the cavity would pinch to zero
thickness there, which is no solid. Refusing it is right; the refusal did not say why.
SMLib now refuses an offset whose walls would meet with its own status, SMLIB_ERR_WALLS_TOUCH
(-1110). The smlib crate reads it as Error::WallsTouch; the kernel's offset backend turns it into
a sentence with the wall, as blends turn NoRoom into one: "shell: the 2 mm walls would meet along
a line (between a hole and the side, for example), which leaves no solid there; use a thinner or
thicker wall, or move the feature". Thicker builds too (SMLib shells 4711 at 2.5, the walls
crossing and merging between the hole and the front), so the sentence offers both.
4711 expects that refusal and its message ("outcome": "refused", "refusal"), its "what" and
"method" saying why: the wall is 4 = 2 x 2, the walls meet along a line. Tests: the smlib crate
shells 4711 built from primitives (2 refused as WallsTouch, 1.5 and 2.5 valid), the kernel a
plate whose hole is 3 from its side at 1.5 (refused, with "the 1.5 mm walls would meet along a
line").
Results (run-sc.sh against SMLib a759622's code, which differs from the tree run only in
comments and docs; baseline 858f381fc-5448b9a): rig 410/447 (409
before; 4711 fail -> pass as the refusal, nothing else changed), ladder 109/116 (unchanged),
kernel lib 535 passed / 202 failed (one new test; the same failing set), smlib crate 53 / 2
(one new test; the same failing set).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0113gDVmStT5tCGKW9Fxgc5K
SMLib now builds a round or chamfer whose rail runs off its face across a cliff (an opening's
rim, the body's outline): the blend is made as if its faces continued and what it removes is
subtracted, so it never bridges an opening (owner decision for rig 5158/5181; fork commit
"SMLib, capi: a convex blend overflowing a cliff is subtracted from the body"). The tests that
expected a refusal for such blends now expect the body, each answer from the geometry:
- variable_radius_on_a_box_edge: 2 -> 50 on the 10x20x30 box's top edge builds at
3546.18767939 (circular sections in y = const, the r x r square less the quarter disc,
clipped to the box; rel 1e-4).
- variable_radius_from_a_spline: the "big" law builds at 6000 - 726.5334566720 (de Boor law,
split at the knot and where r crosses 10).
- a_chamfer_meets_sloped_end_planes: chamfer 25 removes 11500 - 4625 * slope
(integral of 40 - 2 * slope * y over z >= y - 5).
- g2_fillet_refuses_invalid_geometry: G2 at 25 builds at 6138.1606889 (the quintic section
with control points at thirds, clipped to 20x20, along 20).
- fillet_max_each_reduces_only_where_the_radius_does_not_fit: both edges take 4, 24438.7317761.
- hostile_inputs_are_errors: chamfer 30 on the cube builds at 1000 (y + z <= 10 along 20);
R50 still fails.
- kernel-cases fillets/1080: the 9 mm chamfer into the openings builds at 3350
(method in expected.json).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0113gDVmStT5tCGKW9Fxgc5K
Cases from the issues filed after #4160, each a synthetic recipe with its own answer
(analysis or invariants); every other issue in the range is listed with why it was skipped.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Cases from the issues filed after #4160, each a synthetic recipe with its own answer
(analysis or invariants); every other issue in the range is listed with why it was skipped.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Cases from the issues filed after #4160, each a synthetic recipe with its own answer
(analysis or invariants); every other issue in the range is listed with why it was skipped.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Cases from the issues filed after #4160, each a synthetic recipe with its own answer
(analysis or invariants); every other issue in the range is listed with why it was skipped.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Where a cut-out's corner touches the outline (a triangle on the sheet's edge in a bend), four
walls meet along the corner's line. The touching sew paired them round the empty wedges and
gave each fan at the corner its own vertex, so a cap kept its outline and the cut-out as two
loops with a vertex each at one point: SMLib refuses that face (coincident vertices, loops
touching: its face tests 32, 38 and 39), and the bend face's two corners, a hair apart in
(u, v), left a boundary no triangulation follows.
The walls are paired round the wedges of material, as SMLib keeps a solid touching itself along
a line: an edge per wedge, the two sharing their end vertices. A face's loops that meet at a
vertex are joined there into one loop through it twice, SMLib's form of such a face.
With SMLib's face builder taking the same profile (an extrusion of the plate and its
cut-out), fixes rig sheet-metal/1095.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit 0bf765aa815a5552e5b090fd8854b1dc7a981e3f)
A loft cut from a block's whole outline (flush with its sides) down to a pad cuts the slab
above it loose: the slab and the rest touch along the outline's four edges, round the pocket
the loft leaves. SMLib keeps the pocket as a void region of its own (its check finds the body
valid): its one runtime shell is the slab's underside and the loft's faces, so the slab's
material shell faces two empty runtime shells, the infinite region's and the pocket's, and so
does the rest's. The export made one record shell per pair of empty and material runtime
shells, so each solid's closed boundary came out as two open shells ("an open, wire or vertex
shell lies in one region").
A record shell is now one material runtime shell, whatever empty shells its faces face. Empty
regions one solid's boundary faces together are one record region: the infinite region where
it is among them, else the void whose outer shell bounds it alone. The pocket, which no record
shell bounds once the solids' shared edges are split, is part of the empty space round them.
Fixes rig sweeps/96-loft-cut-box-sections-pad-first and -top-first.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit 796920968265c57c59f11dd908ec022d53f5c647)
With touching: separate (the default) a join groups the joined body's
pieces by face contact. The groups that hold the material of the body
before the feature stay in it (each unless it touches one already kept;
the first group where the lineage doesn't say), and so do the groups that
touch nothing: a virtual grouping later operations take as one body. Every
other group that touches another along an edge or at a point becomes a
body of its own, and the feature's notice says so. The joined body keeps
its name and never holds an edge or point contact. A join that only
grouped pieces apart gives no notice, so KeptSeparate::Apart is gone.
one_body still keeps every piece in one body.
SMLib's export copies an edge or vertex that touching solids share once
per solid, so the record never listed those contacts:
Brep::region_contacts now takes such copies (the same curve and interval
between vertices at the same points, a vertex at the same point) as the
edge or vertex they share. A contact SMLib leaves out of the topology (the
3612 spoke tangent to its hub) is found on the exact geometry, the least
distance within the record tolerance, and reported as KeptSeparate::
Touching ("along a line or at a point").
The pending format change join-touching-bodies stays: older designs kept
pieces touching along an edge or at a point in one body too. Its notes say
so, and the reopened legacy emboss still expects touching: one_body.
Tests restored to their form before cc49081df and 733d3bd19: kernel-cases
2896-join-arm-end-near-ring-wall-gap (one body of two shells), 3379, 3455
and 3526 (no touching: one_body); the engine tests of posts joined while
apart (twice), two cubes for interference, a ring with a cylinder, the
buried tab and a_join_adds_only_its_sketch's 0.1 mm gap.
join_meeting_nothing_keeps_the_first_body expects one body and no notice.
The #3378 spoke stays 1 mm inside the hub.
New tests: blocks touching along an edge are split with the along-an-edge
notice; blocks apart stay one body without one; a ring with an arm on its
corner edge and a hub apart gives ring and hub in one body and the arm on
its own (doc); the engine's notice for an edge contact; the record's
contacts of cubes sharing an edge or a vertex (kernel).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Each edge is sampled to the chord tolerance on its own, so where two curves of one face run
closer together than their chords sag (the two arcs of a thin lune, the sliver caps of a
joined ring of cylinder segments) the chords crossed although the curves do not, and no
triangulation follows such a boundary ("boundary crosses itself").
After the edges are sampled, every face's boundary is checked for chords that cross another
of the face, in its loop or another, and on a closed surface across whole periods (chords
ending on a pole are left out). The edge segments that cross are halved at their curve
parameter's middle, on the edge, so every face of the edge gets the same new nodes, and the
faces of the edges split are checked again until no chords cross. A boundary still crossing
after 16 rounds, or an edge past its node cap, is an error naming the face and the edges.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BnQawySUFx57iaJZq7z1Fm
(cherry picked from commit d2b2bdb8e2720690d79123a16bc18c768b1598e8)
Every edge segment now spans at most a quarter turn of its curve, whatever the chord
tolerance: a hole far below the tolerance (a 1 mm hole through a 990 mm plate at a 2 mm
chord) stays a polygon with area, where each half arc had been one chord and the two
chords lay on one line, a hole of no area.
The boundary check takes boundary nodes at the very same (u, v) as one vertex, as the
triangulation does: two loops touching at a vertex they share (a ring standing on a
perforated plate, tangent to the holes beside it) bound a face the triangles follow. A
seam's two uses, one point in space a period apart in (u, v), stay two.
Fixes rig booleans/3665 and sheet-metal/1040.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BnQawySUFx57iaJZq7z1Fm
(cherry picked from commit 53f4f9a2a991fcd6d1374ca2d647e3a1be36554f)
The r3 on the top edge at x = 60 takes tangent_chain: false, so it
rounds that edge alone and not the r5 round's tangent chain with it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BnQawySUFx57iaJZq7z1Fm
(cherry picked from commit cf46e2a713c45ae0427e831cae1dc1d3b858febc)
seam_flags matched only an edge between two faces on one curved surface.
A whole turn of a cylinder is one face whose seam it uses twice, and
history::edge_faces lists that face once, so the seam came out as [x]
and was never flagged: it was drawn and picked, and a blend pick at the
vertex where it meets a rim (ladder 07-fillets/017's (23, 15, 20) on a
boss's base circle) resolved to the seam, which SMLib then rejected. An
edge both of whose uses lie on one curved face is now a seam too, for
every consumer of the flag (display, picking, blend resolve, projection).
The blend's own edge selection took the plain nearest edge: the tangent
chain seeded from it and grew into seams (a pick at the top of a boss's
seam ran down it into the base round's seam, ladder 08-chamfers/008), and
the variable fillet's edge and the fillet's grouping of picks could
differ from the edge the blend resolved. They now take the edges the
blend's resolve picks, and a chain never grows into a seam or a smooth
join.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BnQawySUFx57iaJZq7z1Fm
(cherry picked from commit 709c19c7fd60db522d35e147f21821360bf34668)
Every feature command reads touching (separate | one_body) as it reads
participants; the box and extrude contracts declare it. A feature result
carries notice {message, contact, action} when its join kept solids
apart ("These bodies only touch along an edge, so they were kept as
separate bodies."), the action a timeline.edit that sets touching to
one_body; programmatic calls open nothing.
Tests adjusted: join_meeting_nothing_keeps_the_first_body now expects the
separate body and its notice by default and the old single body of two
lumps with touching one_body; the schema key lists and the
FeatureResult literal gain the new fields.
Engine tests whose subject is a body joined from pieces that share no
volume make it with touching: one_body (posts joined while apart, a
cube joined clear of another, a cylinder joined clear of a ring, a tab
joined in a component); a legacy design reopens with touching: one_body
on its emboss; the 0.1 mm gap of a_join_adds_only_its_sketch leaves the
block a body of its own; and the #3378 spoke starts 1 mm inside the hub,
so the join merges its targets instead of touching the hub along a line.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
Claude-Session: https://claude.ai/code/session_01BnQawySUFx57iaJZq7z1Fm
(cherry picked from commit 7a2915fe32e6549cbf3170d69e0f5b6518e19da3)
A feature's touching parameter says what a join makes of solids that
share no volume and no area: separate (the default) splits the joined
body's pieces that share no face into bodies of their own, named, with
history and lineage, as a cut's pieces are; one_body keeps one body of
several pieces. The state records how the kept-apart pieces met
(KeptSeparate: along an edge, at a point, apart) for the feature's
notice.
Older builds kept every join's pieces in one body: the pending format
change join-touching-bodies gives each joining feature of an older design
touching: one_body, so existing designs keep their bodies.
kernel-cases 2896-join-arm-end-near-ring-wall-gap: the arm meets nothing,
so it now stays a body of its own (body_count 2, one shell each).
kernel-cases that join solids apart to make the body they test ask for
it with touching: one_body: 3379 (the hub joined to the ring before the
spokes reach it), 3455 (64 pegs in one body) and 3526 (a two-lump target
for an intersect).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
Claude-Session: https://claude.ai/code/session_01BnQawySUFx57iaJZq7z1Fm
(cherry picked from commit 2c2aaed86f4be60f7f88e40bc24b60de60085148)
Brep::region_contacts lists each pair of material regions that shares a
face, an edge (used by faces of both) or a vertex, with the most it
shares; pairs not listed are apart. Body::region_contacts reports it for
a boolean's result (lump positions as in Body::lumps), and Body::parts
cuts a body into groups of lumps (lumps is parts of one each). Exact
facts from the record only: no geometry, no decision.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
(cherry picked from commit 64a1d688e68e5f0c5b1f9e4fe0d2facfaa4744be)
Every edge of the hand-written cube was a LINE along one filler direction,
trimmed by vertices up to 1 mm off it; the reader refuses such an edge (a
degenerate edge on a line). Each edge now has the line through its two
vertices, so the assembly, instancing and unit tests read a valid cube.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BnQawySUFx57iaJZq7z1Fm
of_faces gave every edge it was not told about the meeting of its two faces.
A builder (extrude, revolve, loft, a primitive) has no operands: every face it
makes is new, so its edges are new too (EdgeProv: empty when it is new and lies
between faces new to the operation), not where profile segments meet. With no
operands an edge's origins are only what the builder states.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BnQawySUFx57iaJZq7z1Fm
The display's smooth joins were certified only between ruled B-spline patches
along a Line record. SMLib gives an extruded profile's rulings as degree-1
B-splines of two control points, and sweeps a profile curve within tolerance of
an arc as a cylinder (a ring of 256 cubics is 512 cylinder faces), so no join
was certified. A straight edge is a line or such a B-spline; a plane, cylinder or
cone gives its outward normal along the edge in closed form at both ends (their
difference is the uncertainty, so an edge that is no ruling certifies nothing).
The closed-edge fixture cuts its hole with one circle: SMLib trims a loop of
eight cubics as eight edges.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BnQawySUFx57iaJZq7z1Fm
The kernel blends exactly the edges given; the Fillet and Chamfer features
expand each pick to its tangent chain (kernel::tangent_chain) before the call
(4593fd07). Six tests written before that passed one pick and expected the
chain: they now ask for it as the features do, with their analytic expectations
unchanged (10 faces along the rounded corner, the sphere corners of #1557, the
boss's half circle, the rounded rectangle's tiny end, the rounded box's loops).
blend_smlib's notes no longer say SMLib follows the chains.
fillet_tabbed_plate_outer_loop_and_partial_selection_after_hole is left as it
is: it fillets every exact subset of the outer edges, and SMLib still fails some.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BnQawySUFx57iaJZq7z1Fm
A degree-1 patch of four control points on a parallelogram (a plane as an IGES
or STEP B-spline writes it) is that plane at every parameter, so its pcurves
take the plane's closed forms instead of going to SMLib (which drew the rim
circle of 3806's base as a 385-point spline).
SMLib may run a one-face sheet's loop against ours. A use's pcurve is the same
either way, so the loop's way round is read from an edge the face uses once and
every use is matched with it (3806 failed with 'a use SMLib did not keep').
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BnQawySUFx57iaJZq7z1Fm
A use with no closed-form pcurve (an approximated intersection curve on a cone,
a spline edge on a spline surface) no longer refuses its solid. Its face goes to
SMLib alone, an open sheet with the trims it has and without the others, and
SMLib makes those as it makes every trim it needs (GetOrCreateUVTrimCurve on
export); they come back on the record's parameters and the face is closed and
checked as before. The STEP reader takes the trim maker from the kernel
(read_solids_with, read_solid_with); read_solids stays exact-only.
Kernel lib tests: 490 pass, 239 fail (were 468 / 261; pushed head 475 / 254),
none newly failing.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BnQawySUFx57iaJZq7z1Fm
exact_pcurves gives each use's pcurve where it has a closed form (or is given)
and None where it has none, without closing the loops; pcurves_within closes
them once every use has its pcurve. TrimFace, TrimEdge, TrimUse and the Trims
trait carry a face to a kernel that makes the pcurves of the uses with none.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BnQawySUFx57iaJZq7z1Fm
along took u or v the edge's own parameter at slope ±1. A rim SMLib makes (an
extruded or revolved circle, four quarters with scaled knots) runs the face's
quarter grid at another steady pace, and a closed rim's two ends are one point,
so neither its ends nor slope ±1 give its line. The pace is read from the edge's
points a quarter and three quarters along, unwrapped from the middle; the line
is taken only where it lifts onto the edge within the tolerance.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BnQawySUFx57iaJZq7z1Fm
Validation refuses a circle or ellipse edge, or a cylinder, cone, sphere,
torus or revolution face, without its NURBS form. Test fixtures are built on
forms; seam and domain defects use the form's parameter (one turn = 4).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BnQawySUFx57iaJZq7z1Fm
`Assembly::finish` (lip, emboss, delete face, and the other operations that take a body apart
and rebuild it) puts on a NURBS form every cylinder, cone, sphere, torus or revolution face that
none of its uses brings a pcurve to (over its boundary's extent on its label), and every edge
whose uses bring none and whose faces are planes, splines or on forms (a circle about such a
face's axis labelled on its frame). Their pcurves are then exact on the forms. A face or edge
with a pcurve of its own keeps the parameters that pcurve is on.
Rig and ladder unchanged (333/372, 101/116; 529 and 3368 flip between pass and a 40 s timeout
with the machine's load). The kernel tests of lip, emboss, delete face and assemble fail as
before (none new).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BnQawySUFx57iaJZq7z1Fm
sew and the STEP reader build a revolved face's NURBS form over `form::extent` (its boundary on
its label) instead of a pass of pcurves on the label, and compute its pcurves within the form's
box. The STEP reader gives revolutions their form too, and a trimmed swept profile its file's
trim range exactly (points on the axis fit either side of it). The STEP seam tests read edge
angles through `Edge::curve_interval`, intervals and domains being in the forms' parameters.
step 37/37.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BnQawySUFx57iaJZq7z1Fm
- A meridian of a sphere or a tube circle of a torus (a circle in a plane through the axis) has
its exact pcurve on the label: u fixed at the arc's azimuth, v its angle from the outward
radial, alpha + s t.
- A placed revolution has a NURBS form: its profile's control points turned about the axis on
the quarter grid from angle zero, weights multiplied, then its matrix; the record takes forms on
revolutions.
- `form::extent`: a face's parameter box from its boundary projected on its label (the collapsed
parameter at a pole bounds nothing; a boundary that never goes round covers the turn), what its
form is built over with no pcurve involved.
- A face that goes all the way round gets a form of exactly one turn, closed and so periodic.
- `along` projects inside the face's box (a spline extended past its knots, or a profile turned
past the face, has other preimages), and takes a closed form within the record's tolerance, as
the closed forms on analytic surfaces are.
Tests: fits are gone, so curves with no closed form on their face (a tilted circle on a sphere,
an ellipse on a cylinder, an intersection record, a curve weaving across a thread flank) are
asserted refused; the closed-spline fixtures are built as forms. geom 166/166.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BnQawySUFx57iaJZq7z1Fm
`On::fit` and everything it used (samples, least squares, breaks, filled poles) are deleted, and
the STEP reader no longer retries a face at ten times its tolerance. A pcurve is exact (closed
form, an affine image, or a straight line along a form's parameters) or the face is refused:
"not supported yet: no exact pcurve of <curve> on <surface>".
The rig and ladder are as with the fit (333/372, 101/116; none lost; 3806, already failing, now
refused on import). 16 unit tests that build sphere meridians, torus seams, closed spline
bands, intersection curves and surfaces of revolution on their labels now refuse: those paths
need meridians labelled on their face's meridian plane and revolutions on the quarter grid.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BnQawySUFx57iaJZq7z1Fm
A surface of linear extrusion or of revolution over a circle or ellipse built its profile with the
reader's own conic spline, on a parameter of its own; the profile is now `form::curve`, the form
its edges carry, so the surface's parameter along the profile is theirs and their pcurves are
straight. The reader's conic spline is gone.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BnQawySUFx57iaJZq7z1Fm
SMLib holds every ellipse as an exact rational NURBS; the fork now sends ellipse edges with that
form and takes them back with it. The export reads an ellipse with its form as it reads a circle
with one (its frame turned so its angle grows along the form, its trims carried over as they are);
the import writes an ellipse on its form as its conic entry plus the NURBS.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BnQawySUFx57iaJZq7z1Fm
`form::edge` is the one rule sew and the STEP reader share: a circle about a revolved face's
axis is labelled on that face's frame, and a circle or ellipse edge gets its form. The STEP
reader now gives every imported edge its label and form before any pcurve, and every
cylinder, cone, sphere and torus face its form over the extent its label's pcurves give; the
pcurves, the outer-loop choice and the turn-over test then run on the forms, and the record
carries them.
With the pcurve fit turned off, the STEP and IGES circle cases pass (8 of the 9 import cases
that needed it; 3208's ellipse on an extruded spline surface remains).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BnQawySUFx57iaJZq7z1Fm
A flat-pattern edge folded across a bend is a helix, which no NURBS is: sheet metal already
gives its 3D curve as degree-7 Hermite pieces of the fold, within 1e-7 mm. Its pcurve on the
bend is now built the same way, on the edge's own parameter: degree-7 Hermite pieces matching
the point and first three derivatives of its angle about the axis (through the form's quarter
parameter, by the chain rule) and of its height along it, broken where the angle crosses a
quarter (the form's parameter is only once differentiable there), halved until they lift onto
the edge within 1e-7 of its size. An approximation by construction from exact derivatives, like
the edge; nothing is fitted. B-spline and NURBS edges alike (a NURBS's derivatives from its
homogeneous form). Breaks within rounding of each other are one.
With the pcurve fit turned off, all 44 sew cases that needed it pass; with it on, all 44 pass.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BnQawySUFx57iaJZq7z1Fm
The bend's rim arcs carried frames of their own (x toward the arc's start), a fraction of a
quarter from the bend cylinder's, so their forms were off the cylinder's quarter grid and no
straight pcurve lay along them. `form::on_frame` relabels such a circle on the face's frame (the
same circle, its interval shifted); its form is then on the face's grid, its pcurve u = ±s + c.
`along` takes u or v as the edge's parameter either way along, offset. The volume test steps to
a pcurve's ends exactly (t0(1-f) + t1 f), as an interval's end may now carry rounding.
With the fit off, 38 of the 44 sew cases pass (from 29). With it on, the rig is unchanged
(333/372, ladder 101/116, no case changed).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BnQawySUFx57iaJZq7z1Fm
Every circle and ellipse edge sew builds now carries its NURBS form, its interval in the form's
parameter; every cylinder, cone, sphere and torus face its form over the extent its label's
pcurves give; and every pcurve is computed on the forms, so a bend's rim circle is a straight
line on the bend and an affine image on the flange, exactly. The volume test evaluates the faces
on their forms. A form interval's end within rounding past its last quarter stays on it.
With the pcurve fit turned off, 29 of the 44 sew cases that needed it pass (from none); with it
on, all 44 pass as before.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BnQawySUFx57iaJZq7z1Fm
On a plane, a B-spline or NURBS edge's control points go through the plane's affine parameters
and the result is cut exactly (bspline::segment) to the edge's interval, so a circle's form gives
its exact pcurve on any plane. On a spline face (a NURBS form), an edge that runs along the face's
parameters at its own pace gets the straight (u, v) line it is: between its ends' parameters, or
with u or v its own parameter (a rim on the same quarter grid). Each is taken only where it lifts
onto the edge to within 1e-9 of the geometry's size; nothing is fitted.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BnQawySUFx57iaJZq7z1Fm
A form's parameter is now the angle's quarter on its frame plus the arc's parameter in it, and a
form spans the quarters its interval needs (up to five for a turn). Every form on one frame has
the same parameter at the same angle, so a circle edge and the cylinder it bounds agree along it,
and an arc across the frame's x axis, or starting anywhere, has a form. Traces its label to 1e-14
on such arcs, negative angles and a turn from 30 degrees.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BnQawySUFx57iaJZq7z1Fm
`brep::form` builds each analytic kind's exact B-spline the way SMLib holds its own: a circle
or ellipse as four rational quadratic quarter arcs from its frame's x axis on [0, 4] (angle and
parameter related in closed form), a cylinder or cone as that circle times a line along the axis,
a sphere as the circle times a half circle of latitude, a torus as the circle times its tube's
circle, a line as the degree-1 B-spline on its own parameter. A circle and every face it bounds
then share one parameterisation. Each traces its label to 1e-14.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BnQawySUFx57iaJZq7z1Fm
The assembly kept a face's domain and pcurves, which are in its NURBS form's parameters, but
dropped the form and computed new pcurves and the domain on the analytic surface. The form now
travels with the face, and its pcurves and domain are computed on it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A shell's `forward` is about the surface the face's (u, v) are on, its NURBS form when it has
one, which may run against its cylinder, cone, sphere or torus. The kernel read it against the
analytic surface, so a fillet's bore whose form runs the other way was a shaft and an M10 thread
was refused in its 8.5 mm hole. `Face::form_turns` says when the form turns the normal.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
No floor of ours on tolerances (1e-6 of the body's size, 30 times SMLib's 1e-5 default): the
record's tolerances go back into SMLib, which approximates to them, so the floor coarsened every
later operation. No recognition of NURBS edges as lines or circles: an edge is a circle where
SMLib holds an SmCircle (with its NURBS form), and a NURBS edge keeps SMLib's trims on its own
parameter. crashes/2992 and sweeps/1853 pass.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Edge::curve_interval (and brep::curve_interval for assemble's edges) gives the interval on the
edge's curve itself: a form circle's angles of its ends, its frame turned by the SMLib conversion
so the angle grows along the NURBS. lip and the ruled surfaces read arcs by it; the hull, the
blend tangents, the patch pcurves, point paths, IGES output and the prism runs evaluate on
Edge::parameters. assemble carries an edge's form through.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The SMLib conversion reads and writes EDGE_NURBS_FORM: a circle edge's record keeps the circle
as what it is and the NURBS SMLib holds it as as its parameter, so the trims on it carry over
exactly (TrimMap identity).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The edge mirror of a face's NURBS form: Edge::nurbs keeps the NURBS SMLib holds a conic as, and
the edge's interval and its pcurves' parameter are its. Edge::parameters is the curve every
evaluation at a parameter uses; curve says what the edge is. Nothing writes the form yet.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
prism.rs's sheet regions import Surface and Vec3 only where they are built (the smlib feature),
so the kernel without it has no unused imports; the cli's tests that measure meshes at their own
tolerance depend on solidcraft-kernel.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
An edge whose two faces meet tangentially has no corner to round, and SMLib refuses a blend along
it. The chain now runs on sharp edges only, as a tangent chain does (fillets/3369: a rim edge that
ends on the tangent seam of a stadium).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
A whole circle is one closed edge now, so the outer wall and the hole wall each have a seam; the
rig counts seam edges (4005, 4006), and 1c490ddd's count without them broke those cases.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
doc: world_state, world_state_reusing, state_in_frame_at, state_in_frame, face_point_state,
face_point_names and construction_state return Result. A body that could not be placed, a
frame that could not be inverted, a sketch plane or thread axis that did not survive the
placement, or a failed placing worker used to leave things where they were without a word;
now the call fails with what could not be placed. is_placement is the one test of an
occurrence's placement (finite, a rotation that does not mirror, a translation within
1e9 mm). Opening a design names every occurrence that fails it; add_occurrence refuses
one; a joint solution that would place an occurrence outside one is not applied and the
joints placing it report it.
engine: Session::world_state returns Result and keeps a failure in its cache as it keeps a
placed model. bounds, home_camera, open_sketch_plane, the scene builders, the world
previews, frames::to_local and auto_operation pass the error on; helpers answering "not
found" take the placed model from their caller. Commands setting a placement check it
(valid_position, exploded view, fastener at a point, STEP insert matrix).
ui: panels, picks and hovers read the session's placed model through
open_meshing::session_world; a model that cannot be placed shows no placed bodies, and the
viewport says why across its bottom. Pictures and the control channel report the error.
cli, mcp: snapshots, renders, benches and the oracle report the error; the kernel-case rig
records it as the case's failure. Tests read the new Results with unwrap.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
Extent.corner is optional: unset, each profile preserves curvature where
every curve is a line or an arc and takes the tangent rule where another
curve has a corner, with a note in the feature's warning; a rule the user
gave is kept. draft_corners reports not_exact as the kernel builds (any
free curve in a cornered profile). Builds (release CLI); cases not yet run.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
The kernel blends exactly the edges given; the feature's tangent_chain (default true, saved
only when false: pending format note blend-tangent-chain) expands each pick to its tangent
chain (kernel::tangent_chain) before the kernel call. A variable or spline round takes its
edge alone. Scripts and MCP passing one pick get the chain again.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
Every SMLib analytic surface is a B-spline surface, and its trims are in that NURBS's
parameters. Face::nurbs keeps that NURBS: the face's domain and pcurves are its (u, v), and
`surface` says what the face is. Face::parameters is the surface every (u, v) evaluation uses.
The SMLib conversion reads and writes it (fork FACE_NURBS_FORM, SMLIB_REV c4483f6); the STEP
writer writes the analytic surface and the face's edges without pcurves.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
SMLib (fork 68e3086) refuses a blend whose rails leave the faces they roll on with
SMLIB_ERR_NO_ROOM, which the kernel reports as KernelError::TooLarge. The kernel's own
pre-checks go: blend_fit's fit check and the 256-station band check of the variable fillet.
The shim no longer follows tangent chains; the Fillet/Chamfer dialog already expands a pick
to its chain (its Tangent Chain option) and stores every edge in the feature.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
Exporters write a plane as a CONICAL_SURFACE whose semi-angle falls a whisker
short of 90 degrees (#4006: pi/2 - 7e-12): its height over the face spans
4e-11, a parameterisation ill-conditioned for everything downstream. The
reader now measures the cone's deviation from its limit plane (the plane
through the placement across the axis) over the face's boundary points and,
should the face hold the axis, the apex; within the file's distance
uncertainty the face's surface is that plane, oriented as STEP's normal.
One criterion, the deviation over the extent against the tolerance; no
semi-angle threshold.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
Pinned at the fork's draft-corners head: a drafted rectangle (or any
line-line corner) has its walls meet at a corner edge under the tangent
rule as well, 6 faces rather than 14. A curvature refusal for a curve
that is neither a line nor an arc names that curve's start.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
Extent.corner (preserve_curvature by default, tangent or round), saved
only when not the default (one pending format change), and the
solid.extrude `corner` parameter. draft_corner_options reports what each
rule gives at each corner of a feature's profiles, for a dialog to offer
the others where the chosen one is a poor fit.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
extrude_tapered(_between) take a DraftCorner: PreserveCurvature (each wall
continues as itself, a line's plane or an arc's cone, until it meets its
neighbour; SMLib's SM_OC_CURVE_EXTENSION), Tangent (the offsets continued
along their end tangents) or Round (an arc about the corner). A corner
the rule cannot close is refused with its point and why
(solidcraft_smlib::Error::Corner). draft_corners reports, per sharp
corner of a profile, what each rule gives: how far each offset curve runs
on or is trimmed, whether the corner cuts inside the exact offset, or why
the rule refuses it. SMLib pinned at the fork's draft-corners head.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
The angles a cylindrical wall spans came from its arc's two ends about its middle; a wall in
one piece has a whole circle for an edge, whose ends are one point. The circle's parameter is
its angle, so the span is the edge's interval about the angle of its middle: half the turn
either side for a whole wall, as for any arc.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
A rim's arc was its two ends and the point halfway, its circle found through the three: a
whole circle, one closed edge now, has one end and no circle through it. Each arc piece carries
its circle's centre and the angle it turns about the face's normal, read off the record circle
(its parameter is the angle), and offsets, profiles, edges and walls are made from those; the
loops' turning is read through points a third and two thirds along each arc. assemble's
unused edge_point goes.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
Loop2::circle and circle_from gave two half arcs, so everything built from a circle came out in
two: an extruded wall in two faces, a rim in two edges, and so every round, chamfer or sweep on
it in two B-spline halves that SMLib cannot join (two separately parameterised arcs meet at
different curve parameters, SmVertex::IsTopologicalVertex; different free-form surfaces are not
topological, SmEdge::IsTopological). A circle is now one arc of a whole turn from its start
angle: one closed edge, one wall with a seam, one round. Sketch circles, the cylinder builder
(circle_from at its seam angle) and every other builder take it through Loop2; SMLib's arc
curves take a whole turn (smlib_sweeps clamps to one) and ArcSweepCylinder makes the whole
cylinder.
Cases, singly on 9f5ad20c: fillets/1191, 2797, 3753 and sweeps/1269, 2295 fail before and pass
now; eight hole and six thread cases give what the base gives (12 pass, booleans/1279,
booleans/307 and threads/2038 fail as on the base).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
Seven sheet-metal cases failed in smlib_planar_faces (status 1001/1006). Every refused
curve list, in the rig's dumps, has curves of which more than two meet at one end point:
flange regions of one flat pattern touching at their corners (405, 349 x2, 436, 1481, 725,
723) and an outline passing a point twice where a cut-out's corner lies on the sheet's edge
(1095). SmBrep::CreatePlanarFacesWith3DCurves, behind SmApiCreatePlanarFaces, documents
that it fails for such "spine points (where more than two curves share a common
end-point)" (SmBrep.cpp); the sheet handed it all of an operand's loops at once.
A sheet is now built one simple loop at a time: each loop (outer counter-clockwise, holes
clockwise) split where it passes a point twice, each simple loop its own planar face, the
counter-clockwise ones united and the clockwise ones taken away with SMLib's 2D boolean,
which takes faces touching at a point. extrude_planar_regions uses the same sheet.
The read-back keeps the contract the regions had: a face's loop that passes a point twice
(a cut-out touching the outline) comes back as simple loops, counter-clockwise pieces
material and clockwise ones holes of the piece that holds them.
Release CLI, SOLIDCRAFT_KERNEL=smlib: 405, 349 (72 and 90 degrees), 436, 1481, 723 and 725
pass. 1095 now gets past the planar regions; its extrusion of a plate with a cut-out
touching its edge at one point fails in SMLib's export ("a closed shell bounds two regions
and encloses one"). Every other sheet-metal case fails or passes as in rig-1, and 529
(a hang in rig-1) passes.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
The five "boundary winds around the surface" refusals of the first SMLib rig run (solid.hole
1355, solid.revolve 1853, 1866 at 180°, 3191, 466) are one mechanism: a revolved face whose
profile ends on the axis (a drill point, a cone tip, a half slot about its centreline) has a
pole, and its two meridian edges meet there with pcurves half or a whole period apart in the
angle, the parameter the pole leaves free. The boundary unwrapped every step to the nearest
copy, so at the pole it moved the next meridian a period along (1866's quarter sphere: from π
to 2π instead of 0) or, where the pole closed the loop (3191: v from 1 back to 0), the closing
step did; the loop then drifted a whole period and the face was refused as winding.
The pcurves are exact and run on continuously, so nothing within an edge is unwrapped now.
Where one edge meets the next, a pcurve starting a whole period from where the previous one
ended is moved back by it, except in a direction the meeting point is a pole of: there the
two pcurves' own values are the ends of the boundary's run along the pole, which the split
poles then carry. Each loop starts at a node off every pole whose predecessor is off them too,
so seam::drift's nearest-copy closing step never crosses a pole. All five cases pass;
tessellation/ and sweeps/ otherwise as in the rig run (1856 and 3006 pass, slow under a
machine load of 190; 2552 hangs as before).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
SMLib's mass properties no longer refuse bodies that are not one manifold
solid: several lumps and lumps touching along edges or points are the sum
over their material regions, and a sheet is its faces' area and centre with
volume 0. Docs of Brep::mass_properties and kernel::measure say so.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
The ruled surface's far-curve solve kept its own copy of NURBS Book A2.3. The
geom crate now exposes bspline::basis_derivatives (the basis functions alive at
a parameter and their derivatives up to an order, each from its local knots via
local_basis, on the span tess::span_of picks); tess's second-derivative surface
evaluation and the ruled surface both use it, and the copy is gone. smlib's
mod list back in order.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
Owner's decision for strips whose rulings turn freely along their edge (a face's
normal along a free-form face, which was refused): the far edge is not the
offset curve but a B-spline the kernel defines, and the strip is exactly the
ruled surface between the edge and it.
The far curve has the edge's own degree, knots and weights (so the ruled NURBS
needs no knot merging); it runs from the strip's start corner to its end corner
(where the rulings at the edge's ends reach); its interior control points are
given (handles) or the least-squares solution of weighted terms, the
construction's parameters: closeness to the rulings' ends at the edge's
Greville abscissae (W_CLOSE), fairness by arc length (W_FAIR), each end leaving
along the chord to the other end (W_TANGENT, one small function), and at a joint
where the chain runs on smoothly with shared sides the first and second
derivatives by arc length matched to the neighbour's (W_JOIN), in one solve
along the chain, an exact neighbour's far edge matched as it is. Exact strips
are unchanged.
ruled_far_handles gives each free strip's default handles; ruled_surface_with
takes moved ones. The Ruled Surface feature saves them as `far` (per chain
edge, null for the default; pending format note ruled-far-handles), and
surface.ruled takes them as `far`.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
No caller is left for: Assembly::sheet and assemble::outward_normal, Body::shell_nesting,
regularize_generated_planar_faces, with_shell_planar_sources, boolean_record's Traced and
of_pair, offset's normal, plane_fit's plane_through, EdgeSampler, planar_face and
plane_frame (fill has its own on the record), polyhedron's solve3, prism's wall_along,
record::regions/region, splitface's side_of_point, Analytic, analytic_face, face_sides and
canonical, surfaces::picked_loop, sweep_path's closed_path, turn and stations,
shell_groups' groups and parents with their limits, and the whole of spline_conv. Their
tests go with them: prism's curved_prism_wall_requires_positive_separable_rational_weights,
body_lump's shell_grouping_preserves_large_disconnected_patterns_and_bounds_hostile_work,
and regularization protection's check of the generated regularizer. Three names follow
clippy's conventions: into_face -> direction_into_face, from_to -> ends_along, and Params::
to_eval takes its Copy self by value; fill's clash loop walks its slots.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
Machine-applied by cargo clippy --fix: borrows the compiler dereferences at once, an
unused import, a manual += , an entry() for contains_key+insert, a needless Ok(?),
contains() for iter().any(). No behaviour changes.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
mesh memo (one remembered mesh per tolerance), history (a bare body from a record), tests.rs
(no coarse-missing field, lumps for touching shells), outline (the foot found by the planar
faces in its plane), chamfer sides (the rim from the record's edges), seam faces, coplanar
and issue 679 and pinch tests (the boolean is SMLib's: the diagnostics assertions go, every
volume, shell and validity check stays), boolean history (a cut of two pieces through the
boolean), integration tests naming solidcraft_kernel::MeshTolerance.
Deleted, testing internals that are gone: boolean_history_tests' glue_merges_across_the_seam
and faces_pushed_apart (coplanar::glue, boolean_apart), planar_fallback (polybool's
planar_boolean) and bore_union_of_a_bore_in_two_arcs_has_no_history (coplanar::bore_union);
issue_851's the_sphere_at_a_box_corner_is_the_planar_corner_builders (blend_vertex); pinch's
prism_boolean shell check.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
The truck reads become record reads: an intersection edge of a moved cut, the fillet
mitre edges sampled with CurveEval, the cache estimate from the record's faces and edge
uses, holed faces by their loops. The drain pads and the coincident-faces booleans keep
their volumes and faces without the boolean diagnostics and the polygon boolean.
Deleted, testing internals that are gone: a_tapered_s_curve_is_cut_into_pieces_that_follow_its_offset
(build::offset_error/offset_splits), planar_fallback_names_the_curved_faces (the polygon
fallback), mixed_loop_blend_guards_selection_and_construction and
loop_chamfer_mixed_arc_and_line_uses_offset_intersections (loopblend),
an_attempt_budget_stops_the_boolean_and_is_shared_by_nesting (with_attempt_budget),
placing_a_body_does_not_turn_its_revolved_faces_again (REPHASED, truck's revolution phase),
and the truck debug runs debug_coplanar_union_rate, debug_truck_sphere, debug_sphere_patches,
debug_sphere_cases, debug_sphere_rotations, debug_cube_sphere_measure, debug_heal_sphere_cut,
debug_coplanar_cylinder_union, debug_drilled_hole, debug_face_param_areas and
debug_revolved_tube_cut (truck_shapeops booleans, build::sphere_patches).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
native.rs's test module keeps its encode/decode, wire-record, hostile-input and appearance
tests. Deleted with the adapter they tested: pcurves_on_planes_are_the_curves_mapped_exactly,
pcurves_fit_curved_faces_within_tolerance, pcurves_of_seams_lie_a_period_apart and
pcurve_pictures, with their helpers (pcurves_of, check_pcurves, check_faces, curved_bodies,
seam_faces, draw). smlib_import_tests count shells on the record; their notes no longer
speak of truck.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
- thin faces: the face pinched against its own edge is a record sheet (sew::assemble) meshed
by the body's mesher; its triangles still cover its boundary polygon.
- trimmed loft faces, loft rails: distances to faces through the record's SurfaceEval.
- untouched faces: edges and in-line stations from the record's edges and vertices.
- intersection curves: the #1252 regression on a record sheet whose edge is a traced
intersection of parallel planes: meshing neither panics nor goes non-finite.
- lumps: shells counted on the record; the certified witness is Brep::compound of its three
bodies, faces known by surface and box.
- Deleted, testing internals that are gone: intersection_curve_tests'
degenerate_intersection_polylines_return_none_without_panicking,
closed_intersection_retains_the_closure_and_spherical_supports and
open_intersection_keeps_endpoints_on_both_planes (truck's IntersectionCurveWithParameters)
and a_result_with_an_edge_that_does_not_evaluate_is_refused (boolean_record::edges_evaluate);
body_lump_tests' unowned_overlapping_and_touching_cavities_are_errors_not_dropped_geometry
and shortcut_clearance_refuses_curved_contact_hidden_between_mesh_vertices (truck shells
joined without regions, separated_lumps) — kept as spheres_apart_join_as_two_lumps — and the
shell-order permutation of nested_cavities (the record names each cavity's region).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
- placement: a rigid placement moves the record and nothing else (regions, shells, loops
with their pcurves, edges and their uses equal; every vertex moved; the identity's
history), on a cylinder whose wall's loop uses its seam twice.
- issue 2005, 616, 674, 1038, 1510, join between caps, regularization protection, history,
mesh memo, display mesh: the truck reads become record reads (shells closed by edge
uses, faces by the record's surfaces, vertices by the record's points, the mesher's own
boundary budget); the nearly-in-plane slab of 1510 is an extruded record body.
- Deleted, testing internals that are gone: issue 616's glue_joins_every_face_the_pieces_share
(coplanar::glue) and the_retry_guard_refuses_changes_away_from_the_tool
(boolean_guard::check_retry); issue 674's partial_contact_does_not_join_tangent_or_separated_faces
(coplanar::imprint_union); issue 1038's hinted_division_matches_the_search_from_nothing
(truck's vendored parameter_division); issue 1510's a_face_close_to_the_plane_but_off_it_is_not_moved
(ops::off_plane). The boolean-diagnostics assertions (no retry, no tool nudge) went with
capture_boolean_diagnostics; the rest of each test is kept.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
solidcraft-smlib is a dependency of every build (it answers NotBuilt without
SMLib), so the SMLib sides of surfaces.rs and blend_smlib.rs no longer sit
behind cfg(feature = "smlib"), and their stub modules go; blend_smlib's tests
run in every build like the rest. This also uses offset_backend::thicken and
the smlib_sweeps curve conversions in builds without the feature, which left
them unused there.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
The three refusals of the cornered controlled sweep become the owner's rules:
- an orientation direction turns the section about the corner's binormal like
any sweep, then turns it back about its normal to the direction's frame
evenly along the next run, as a twist (direction_offset: the turn between
the carried section and the direction law's section there);
- guide rails follow a path with corners when each rail has a corner of its
own at every corner of the path, in the plane halving it and by the same
turn about the same axis; the rails are cut there into each run's
(run_rails), anything else is refused with the corner named;
- round a closed path with corners the first run starts from the closing
mitre and the last ends on it; a twist is allowed where the profile maps
onto itself (closing_offset), an end scale is refused.
Each run's station count now follows its own turn, twist included.
solidcraft-smlib is a dependency in every build (it answers NotBuilt without
SMLib), so smlib_sweeps' imp is no longer behind the smlib feature and its
stubs and not_built go; polyhedron calls offset_backend in every build.
Deleted as unused: sweep_path::{closed_path, turn, stations}.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
A sweep that twists or scales refused any path whose direction jumps by more
than 1e-3 rad, a branch on the path's shape. It now takes the corner model of
the plain sweep: each smooth run is swept through stations by the laws a smooth
path has (twist and scale running with the length along the whole path, each
run going on from the section the last ended with), and the runs meet at each
corner in a mitre. Turning with the path, each run goes on past its corners as
a prism of its section there (the laws hold still across the mitre: the two
runs' sections meet on the plane halving the corner only when both are the
corner's section) and is cut back to that plane, then turned through the
corner onto the next run; only moving along the path, the runs meet at the
corner's section. The mitre plane is one function for both (mitre_of).
Refused, with the reason, where a control has no meaning at a sharp corner: an
orientation direction (it turns the section by its own turn, not the corner's,
so the two runs' sections don't meet), guide rails (their sections jump where
the path turns), and a closed path with corners (a twist or scale keeps the
last section off the first).
(not built: base in progress; no error in these files)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
Intersection::point started its Newton solve from the last point found (a Cell holding both
surfaces' parameters) when that landed near the leader, as truck took a hinted point. The
answer then depended on what was evaluated before, so CurveEval was not Sync, and the
clearance check, which shares a body's DistanceShape (its edges' CurveEvals) across worker
threads, did not compile; with threads it would also have made the result depend on their
interleaving. Each point is now solved from the leader's own point, the path the hint fell
back to, and the unused trace tolerance goes with the hint.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
sheet_hole_cut chose by failure: a hole's drills were tried all at once and, if that was
refused, one by one; each drill was tried as a flat cut-out and, if that was refused (or
machined nothing), as a bore. Now the drill's geometry decides, one path each:
- SheetBody::drilled_panels: the panels a straight drill meets and how square it is to each
(|panel normal · axis|); a drill into a bend is refused, as before. add_bore uses it.
- sheet_drill: square across every panel it meets is Drill::Across (sheet_primitive_cut, a
cut-out or pocket of the flat pattern), along every one into a rim is Drill::Along
(sheet_bore_cut, a bore), meeting no sheet is None, and anything else (square to one panel
and along another, or at an angle) is refused with the angle message.
- The all-at-once pass (sheet_drill_cuts) passes its errors on; its None (the drills not all
square along one axis) still puts the model back and drills them one by one.
- sheet_bore_cut passes add_bore's refusal on instead of answering None.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
The boss's post and ribs, the boss's hole, the snap fit's arm and the rest started a few
hundredths of their height inside the material (and the hole and the groove ran on as far
past the face), and the groove's cutter reached past the rim edge into the free side, so no
face of a tool lay on a face of the part. SMLib joins and cuts touching faces exactly: each
tool is now the feature's own shape, from the face (a drafted post or rest sized at the
face, the groove's band the rim's own, free reach 0). The material each adds or removes is
the same.
kernel::rim_band's `free` is now always 0 from the doc.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
The kernel has no boolean retries now, nor their diagnostics
(capture_boolean_diagnostics, BooleanDiagnostics, BooleanStrategy), nor the near-coaxial
crescent (coaxial_overlap, coaxial_candidate, with_attempt_budget). What read them goes:
- doc: FeatureResult and the evaluation cache carry no boolean diagnostics, and no "Boolean
retry" warning; the saved model no longer writes them (an older file's are ignored);
- engine: timeline.inspect / feature inspection drop `boolean_diagnostics`; fuzz runs and
the CLI fuzz summary drop their retry counts;
- inspect.interference: each pair is the bodies' Intersect, measured; the near-coaxial
crescent, the by-piece intersection of bodies in several pieces and the unverified notes
go (the command's doc no longer lists near_coaxial);
- inspect.clearance: an overlap is the bodies' Intersect, measured near its region; the pin
tries, the cut-down copies of large bodies (clipped, narrowed), the union cross-check
(union_disagrees, contradicted) and the malformed-part check (plausible) go, and the
measure near the origin passes its move's error on.
Tests: the retry test and the unit tests of the deleted checks are removed; the barrel join
test (tests/boolean_diagnostics.rs, now tests/barrel_join.rs) keeps its geometry checks;
the pin-in-bushing test expects the filleted case measured; assertions on empty diagnostics
and on near_coaxial are dropped; the corpus fixtures lose the diagnostics key and the one
retry warning.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
Every lib warning under --features smlib outside the files agents are editing
(assemble.rs, sweep_path.rs) pointed at code nothing calls any more:
- body: shell_nesting;
- boolean_record: of_pair and its Traced alias;
- planar_regularize: the generated-wall regularization (and its branches in the
certified one, which was its only other path); planar_sources:
with_shell_planar_sources;
- plane_fit: plane_through, EdgeSampler, planar_face, plane_frame (the patch is
fill's); only loop_area is left;
- polyhedron: solve3; prism: wall_along; offset: Surf::normal;
- record: regions, region; shell_groups: groups, parents and their limits;
- splitface: side_of_point, Analytic, analytic_face, face_sides, canonical;
- spline_conv.rs, all of it (surfaces builds NURBS records); an unused import in
tess/uv.rs.
The tests of deleted items go with them: prism's wall_along test, the shell
grouping test in body_lump_tests, and the generated-regularization assertion in
regularization_protection_tests.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
split_band_edges_are_seams tested split.rs's splitting of a face that winds around its
surface into two (deleted with the truck reader; the record keeps the face with a seam):
deleted. ImportedBody::file_faces says each body face is a file face.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
Each body's record is written directly: a manifold solid B-rep (186) per material region
with its voids, open shells as 514 form 2, faces on the record's exact surfaces and edges
on its exact curves over their intervals, in the STEP form solidcraft_step::write::topology
gives them (one geometry model for both exports). The detour through STEP text and its
re-parse is gone; the maximum coordinate is the largest coordinate written.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
write::topology::layout says which shells make each solid (a material region's outer shell
and its voids) and which are sheets, and outer_loop which loop of a face is its outer one;
the STEP writer uses both, and the IGES writer can too.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
Import: every solid is read by solidcraft_step::topology into its record and taken into
SMLib as given (step_in/parallel.rs smlib_part), the one path; the truck readers
(step_in/brep.rs, split.rs, geom.rs) are deleted. Placements are column-major 4x4 matrices
from solidcraft_step::read placements; an instance is its part's record moved there
(ops::transform_matrix), or the very part at the identity. Assemblies, names, colours,
shared displays and the public API are unchanged. step_orientation_errors lists the faces
the STEP reader turns over (their loops disagree with their same_sense).
Export: each body's record is written by solidcraft_step::write::topology as the exact
B-rep (solids per material region, open shells as a surface model, the record's pcurves);
step_out writes products, units, colours and assemblies around it with Writer. The truck
writer and every post-processing pass (split-face merging, sheet trimming, analytic
recognition, short-edge collapse, the re-read fallback) are deleted. The context's
uncertainty is the loosest record tolerance exported.
Tests: ported to the record API with their assertions. Deleted, as tests of deleted
internals: conic_tests extruded_ellipse_seam_uses_profile_angles_for_oblique_sweeps and
conic_arcs_are_exact (truck geometry reader), tests offset_surface_analytic_geometry_and_
orientation, offset_surfaces_nested_and_hostile and periodic_knot_bsplines_are_read_on_
their_domain (truck geometry reader), corpus_truck_and_schema_4_counts (truck comparison);
the orientation counter asserts (crate::body::ORIENTED, gone with orienting by mesh).
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
A placed revolution is written exactly whenever its placement maps revolutions about the
axis onto revolutions (one scale across the axis, another along it, then a rotation or
reflection), its profile placed with it; a conic profile stays a conic under a similarity.
A void's CLOSED_SHELL keeps the record's sides (normals out of the material, into the void)
through an ORIENTED_CLOSED_SHELL .T., as SolidCraft has written voids. Reader::frame reads an
assembly placement (AXIS2_PLACEMENT_3D, or _2D in the XY plane).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
write::topology writes each material region as a MANIFOLD_SOLID_BREP (BREP_WITH_VOIDS
with its voids as ORIENTED_CLOSED_SHELLs), open shells as a SHELL_BASED_SURFACE_MODEL,
faces as ADVANCED_FACEs on their exact surface with FACE_OUTER_BOUND/FACE_BOUND of
EDGE_LOOPs and VERTEX_LOOPs, edges as EDGE_CURVEs on their exact curve over the record's
interval, and the record's exact pcurves as PCURVEs of SURFACE_CURVE/SEAM_CURVE. A record
surface's (u, v) map linearly onto STEP's (planes on their orthonormal frame, narrowing
cones turned over, revolutions angle first), and pcurves go through the same map.
Writer::add_distinct writes topology entities unshared. topology::Solid lists the faces
the reader turned over (their loops disagree with their same_sense).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
doc's FeatureResult has no boolean_diagnostics any more (truck's Boolean
retry reports, gone with truck; SMLib's boolean has no retries). The
timeline.inspect and doc.inspect replies drop the key.
Tests of the removed reports: tests/boolean_diagnostics.rs is deleted (it
checked truck's retry events and their survival through the cache, undo and
reopen); the assertions that a feature's report had no events go from
features_more_tests, patterns_tests, hole_face_tests and tests/rim_cut (the
rest of each test stays). The CLI corpus's expected replies
(move-bodies, issue-489-stacked-join, issue-616-lid-ribs) drop the key; the
issue-616 one listed a planar_fallback event. docs/robustness.md: its
section on retries becomes one on SMLib's booleans, which have none.
Left to the blends work: engine fuzz.rs (its retry-event counts) and
clearance/interference (capture_boolean_diagnostics, coaxial_overlap,
with_attempt_budget).
Not built: base in progress (kernel-smlib/no-truck 66ab6b7f does not build).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
The kernel's BooleanDiagnostics and capture_boolean_diagnostics are gone
with truck: they reported the retries and fallbacks truck's booleans took
(shifted operands, refined tolerances, a planar fallback), and SMLib's
boolean has none. Model::evaluate ran every feature inside
capture_boolean_diagnostics, warned with its summary and kept the report
in FeatureResult, its cache entry and the saved model ("diagnostics").
The feature runs as it is, FeatureResult and CachedEval lose the field, and
the saved model neither writes nor reads "diagnostics" (a model saved with
it still opens: the key is not looked at).
Callers outside doc that read FeatureResult::boolean_diagnostics change
with it: engine's timeline.inspect reply here; engine's fuzz report and
clearance/interference belong to the blends work.
Not built: base in progress (kernel-smlib/no-truck 66ab6b7f does not build).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
The vendored truck-geometry they pinned is gone; the same finite-difference checks, degrees
2 to 5 and a rational surface, now pin SurfaceEval::second, which every curvature the kernel
reads comes from.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
The helpers read every face of the fill as a record surface over its box, the loops'
(u, v) polygons from their exact pcurves, the rim from the free edges and curvature from
SurfaceEval::second; check_face takes the fill's faces (one, or the patches about a centre)
whose free edges lie on the body's edge curves. Expectations changed by the coordinator's
decision on loops of five or more edges: the pentagon fills as five patches (each rim edge
in halves, five spokes: at least 15 edges), the hexagon through a point as six patches with
18 edges. Every other assertion is kept.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
finish lays out the faces left and added (each stored relative to its surface's natural
normal with its pcurves and box, now one function, stored()), the source's shells and
regions (a region whose outer shell lost every face gone) and the edges and vertices as
they are, then calls Brep::canonical; its own ordering walk is deleted. check_geometry
and the face and edge maps are kept.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
sweeps_along_3d_paths asserted at most 8 faces for a 41-point path: one wall
per profile segment fitted through the points, which the exact construction
no longer makes (no curve is fitted through samples). A point path is the
polyline its points make, swept line by line and mitred at each point, so the
circle's two arcs give two walls along each of the 40 lines, and two caps:
82 faces. The volume check stands (a mitred sweep of a profile centred on its
path keeps area × length).
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
An Iso link along an explicit direction on a solid now takes
kernel::face_section_along, the face cut by the plane holding its exact normal
and the direction, instead of the triangles' section. With the projection, the
u/v iso curves and the base's exact intersection edges, every linked 3D curve
on a solid keeps its exact curves (Wire::exact); curves that meet end to end
become one wire (joined_wires, shared by the projection and the iso curves).
Mesh bodies, which have only their triangles, keep the triangle-based curves.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
face_section_along cuts a face through a point by the plane that holds the
face's exact normal there and a direction (Brep::face_section): the iso curve
"along a direction" of a link, as record curves on their intervals, the
B-splines SMLib made. The projection and the section share the picking reach,
the curve tolerance, the error words and the conversion to record curves.
(Intersection links take the base's meeting_edges, SMLib's imprint.)
lib.rs (coordinator): export point_path::face_section_along.
(not built: base in progress; no error in these files)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
Brep::face_section (smlib_face_section: one face cut by a plane) hands back
the NURBS SMLib made with their intervals, through one reader of smlib_curves
(take_curves) shared with project_curves. The face-pick errors map to
NoMatch/Ambiguous in one place (picked). SMLIB_REV at fork eedfa51.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
LinkSource::Iso with `u` or `v` on a solid now takes kernel::iso_curves: the
face's isoparametric curve through the point, exactly, cut by the face's
loops, each piece a wire with its exact curve. An explicit direction (the face
cut by a plane: an intersection curve, waiting for SMLib's exact SSI curves)
and a mesh body still use the triangles' section.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
iso_curves gives the isoparametric curve of a body's face through a point, along
its first or second parameter, as record curves: on a B-spline surface the
surface's own row at the point's other parameter (each control point its
column evaluated there, homogeneous, so exact for rational nets), on an
analytic surface its line or circle. It is cut where it crosses the face's
loops: each crossing solved on the loop's pcurve itself (bracketed on samples,
then bisected on the pcurve), the pieces between kept where their middle lies
inside the face (even-odd over the loops), neighbouring inside pieces joined.
A revolved surface record is not supported yet.
lib.rs (coordinator): export point_path::iso_curves.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
A sketch curve linked onto a face (LinkSource::OnSurface) was projected onto
the face's display triangles, so the wire was a polyline on the mesh. On a
solid it is now kernel::project_onto_face of the curve's exact segments, along
the sketch normal turned toward the face: the wire's exact curves are the
B-splines SMLib made, pieces meeting end to end one wire, the points sampled
from them for display. A mesh body, which has only its triangles, is still
projected onto them.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
project_onto_face projects sketch segments along a direction onto the face of a
body at a point through Brep::project_curves (smlib_project_curves), each
projected piece the B-spline SMLib made, returned as a record curve
(RationalSpline) on its interval, within a millionth of the body's size.
lib.rs (coordinator): export point_path::project_onto_face.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
The base no longer links truck, so build.rs and sweep_path.rs drop what was
kept only for other modules: chain and profile wires, the profile face,
loft wires and their ruled and smooth faces, across/section_parameters, the
cubic interpolations and NetFit, the uniform wires, the six sphere patch
faces, and sweep_path's ruled_sheet and smooth_sheet with the station helpers
only they used. Their callers switch to planar_face_record,
smlib_sweeps::{chain_curves, body_from_record, sphere}, sketch_record_curve,
the SMLib sweeps with open ends, and bspline::CurveN::interpolate.
offset_backend and polyhedron pick faces through provenance::closest_on_tri,
boolean_guard being gone.
Callers left to switch (other ports): surfaces.rs, loft_rails.rs,
surface_offset.rs, surface_ruled.rs, step_in/brep.rs, trimmed_face_mesh_tests.rs.
(not built: base in progress; no error in these files)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
The FFI for smlib_project_curves and the smlib_curves result (fork 5f9af50),
and the safe call: a curve list projected along a direction onto the picked
face, back as Curve::Nurbs with each curve's interval. SMLIB_REV at 5f9af50
(fork integration head 1934b57 + the untrim status fix + the projection shim).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
Rulings that are constant, or keep their angle to an arc's axis, move the edge by
an affine map: the far edge is the edge's exact image and the strip exact. Any
other ruling field (a normal turning along a free-form face, a tangent carried
round a free-form curve) ends on an offset curve, which has no exact NURBS form
in general: SMLib holds one only implicitly (SmOffsetCurve) or approximates it
(NL_CrvOffset.h, N_CrvOffsetApprox), and its ruled surface (SmApiCreateRuledSurface)
takes two B-spline curves it is given. Such a strip was a B-spline fitted within
1e-3; it is now refused by name. The fitted-strip test checks the refusal.
The round-corner cases count one face per corner: SMLib's revolve makes a quarter
turn one face, where truck's cone builder made two (12 faces and joins, now 8).
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
SMLib is the only kernel now. cargo xtask kernel-cases ran every case once
per kernel asked for (--kernel default|smlib|both), setting
SOLIDCRAFT_KERNEL per run, and wrote a column per kernel; solidcraft-cli no
longer reads that variable.
The rig and the ladder run each case once, through solidcraft-cli built with
--features smlib (cargo run passes it), and report one result per case:
--kernel and the env var are gone. Each run has an output folder (--out,
default target/kernel-cases, target/kernel-ladder for the ladder) holding
results.json (every case's full result, which --results used to write on
request) and dumps/<area>-<case>/: every case runs with
solidcraft-cli kernel-cases --dumps=<out>/dumps, so a failed SMLib call
leaves its inputs for replay.
The ladder's golden holds one entry per case: golden.json is the last
recording's smlib entries, which predate SMLib running every case (its
reason says so); record it again after the first SMLib-only run.
docs/kernel-cases.md (until the next run regenerates it),
tests/kernel-cases/README.md, docs/kernel-smlib-sweeps-shell.md (its truck
column and comparisons dropped), xtask's and solidcraft-cli's usage text:
one kernel. Nothing was run.
clippy -p xtask --all-targets: clean.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
The helpers that read a face's surface, its edges and its seam shape read the record
(SurfaceEval, CurveEval, matchsurf's Patch) instead of truck faces; every assertion is
kept.
(not compiled: the kernel's test target waits on the base's step_*, build, sweep_path and
surface_ruled ports)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
Before sewing, each edge of one input is split exactly (Brep::split_edges) at every vertex
of another input that lies on it within the stitch tolerance away from its own ends, so a
patch whose corner meets a body's edge part way (the five-plus-sided fill's midpoints)
sews with no T-junction. The pieces carry their edge's history. The search is the nearest
of 64 samples refined by golden section, over the vertices within a chord's reach of the
edge's samples. Nothing else in stitch changes.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
Each piece keeps the edge's curve on a sub-interval, a new vertex sits on the curve at each
split, every use becomes uses of the pieces with its pcurve cut at the same parameters
(bspline::segment), wire edges likewise; the result is in canonical order with each
edge's source edge. What a sheet needs so that another's vertex on one of its edges is a
vertex of both.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
sew::assemble and surfaces::Parts::canonical each lay out their record as its parts stand
(regions, shells, faces, edges with no uses, vertices) and end in Brep::canonical; their own
ordering walks are deleted. spline_conv::tensor_face (no callers left) is deleted in favour
of surfaces::tensor_sheet, and fill's copy of the spline surface record in favour of
surfaces::spline_surface.
(not type-checked: the kernel stops at name resolution in step_*, build, sweep_path and
surface_ruled)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
part()'s walk becomes renumbered(): the record of given source regions in canonical order.
part() hands it the regions it cuts; canonical() hands it every region as it is, open,
wire and vertex shells included, for records builders put together in their own order.
Each edge's uses come from the walk; a source list naming exactly those uses keeps its
radial order (turned to start at the primary use), as part() did.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
The strips keep their model (exact where the rulings move the edge by an affine
map, a ruled B-spline fitted within 1e-3 otherwise; mitred or rounded corners;
an inside corner cut back). Each strip is built on its own on the record: the
chain edge as its exact NURBS (a circle or ellipse arc rational quadratic), the
far edge its image (its control points mapped) or the fit's, the surface a plane
or the ruled NURBS between them with straight pcurves along its parameter lines.
A mitre's triangles are flat polygons; a round corner's sector is SMLib's revolve
of the incoming side about the corner's axis. The faces are stitched by SMLib
(surfaces::sheet_of, which now takes the operation's operands), each strip made
in place of its edge, each corner face in place of the two edges there. Tests
read the record; the check that the strips stand on the box's own edges now
looks for edges lying along them, as the result is a body of its own.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
A surface sweep along a path with corners was refused. Each smooth run is now
swept on its own with open ends by the solid sweep's corner model: carried on
straight past each corner, imprinted with the planes halving the corners and the
pieces between them kept (a point inside each face, smlib_face_points), the
profile turned through each corner onto the next run; the runs are stitched.
Only moving along the path, the runs meet as they are. Each wall keeps the
segments its uncut face came from through SMLib's tags. Sweep options along a
path with corners are refused as the solid sweep refuses them. The sheet
builders use smlib_sweeps' curve and path_curve; their own copies are gone.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
smlib_sweeps' loft_rails kept its own copy of the rail law with the anchoring
4056 was refused by (a rail lying in the last section's plane met at its first
crossing there). It now builds the sections with loft_rails::Section and takes
the sections and stations loft_rails::railed gives, so the law and its fix live
in one place. path_curve is exported beside curve for the sheet builders.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
The doc puts exact tools into SMLib's boolean as drawn, so nothing asks whether a touching tool
can be joined, batches extrusions, or probes for room to grow a profile.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
machine_bores cut with the drill clipped to the panel and, refused (coincident faces at the
panel's rims), cut again with a longer cylinder a hair past the panel. SMLib's boolean takes
the flush ends exactly, so the clipped drill is the one cut; its refusal is passed on.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
A lip tried kernel::raise_band and, refused, joined an extruded band in its place (whose
walls coincide with the walls below); a groove tried kernel::rim_band and, refused, cut a
band offset from the rim face's display-mesh loop (a sampled outline). Both second paths are
gone: a refusal of the exact band is the feature's refusal. offset_left, which only the
sampled band used, goes too. The rim and opening checks are unchanged.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
SMLib's boolean takes touching and coplanar faces exactly, so the tools no longer bend
around them, and no tool is tried a second way after a refusal:
- extend_for_coplanar / grow_profile_for_coplanar (a cut or join tool run on past faces it
lies on, its profile grown out of walls it touches), Surroundings and its clearance probe,
fill_void_holes (holes over empty space taken into the profile, #1360),
trim_embedded_join_ends (a join's buried ends cut off, #2059), the touching-face checks
(kernel::can_join_touching_faces / can_join_all_touching_faces) that decided when the
exact tool could go in, the profile that "grows wherever the samples find room" when the
build failed, region_samples, and the revolve's grown profiles;
- a tapered tool's run-on into the face it stands on (taper_run_on_fits, face_level_at) and
its straight TAPER_FOOT: the tapered tool is the profile drafted over its length;
- apply_traced's batched boolean that, when refused, put the model back and ran the tools
one by one (and common_join_target, which only it used): the tools run as the operation
always runs them;
- a pattern's copy of a reduced fillet tried again as a new fit when the copied radii were
refused: the copy uses the radii the original was built with;
- union_apart / join_apart errors are passed on instead of leaving the tools apart.
The command behaviour stays: the same tools, the same lineage, the same at-once boolean of
tools apart. The tests of the deleted growth and trimming (coplanar_growth_tests) go with
them.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
thread_groove built the faceted mesh groove truck cut; nothing calls it since the thread
cut is SMLib's screw sweep (kernel::sweep_helix) and a B-rep boolean. With it go
GrooveShape's facet count and the refusal it fed ("the modelled thread is too fine for this
diameter"): an exact groove has no chord error, so a fine thread on a large diameter is cut
as drawn. Dimensions that are not finite are still refused.
kernel::sweep_helix_mesh is now called only by crates/engine/src/thread_tests.rs.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
loft_blend hands its net to surfaces::tensor_sheet (the bridge's own one-face sheet);
section_frames picks the face that bounds the whole chain and faces the run best from the
record's edge uses and the face's SurfaceEval normal, and reads its frames with
bridge::frames. Behaviour and messages unchanged.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
match_surface and seam_continuity read faces as record surfaces (SurfaceEval over the
face's domain), pick the face and its kept side's edges from the record, chain and frame
the target through bridge::chain/frames, keep the crown whose bridge strays least from the
original, and turn the bridge face to the target's sense by building it again turned
(surfaces::Parts). The history is over [body, target]: the face modified from the body's,
its edges new. Behaviour, constants and messages unchanged.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
general_fill takes loops of three to sixteen edges. quilt_body assembles fill_iso's
patches into one sheet: each loop edge whole, or for five or more its two halves at the
middle of its interval, both on the edge's exact curve record and sharing a midpoint
vertex; each spoke a new edge from that vertex to the centre; every pcurve the straight
line in (u, v) of its side. The history marks every face generated, each edge or half a
piece of the body's own edge, each spoke new. A reversed loop edge's knots keep the
interval's ends exactly, so pieces name the edge's own vertices.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
A loop of N >= 5 edges is N four-sided patches about a centre point: each edge split at
the middle of its parameter interval, a spoke from each midpoint to the centre, patch k
on the second half of edge k-1, the first half of edge k and the two spokes beside them.
All patches share one compatible space, so each spoke is the same control points in both
patches it divides and the centre one point; the least-squares solve takes them once
and adds rows opposing the two patches' derivatives across each spoke (tangent there).
The one- and three-/four-sided fill is the one-patch case of the same model. The result
lists each patch's sides (edge pieces with their parameter ranges, or spokes) and the
spoke curves; every pcurve is a straight line in (u, v).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
sketch.intersection_curve (LinkSource::Intersection, crates/doc/src/
project.rs) intersected the two bodies' display meshes triangle by triangle
and chained the segments into polylines: a curve known only as points, off
the true intersection by the meshes' chord.
kernel::meeting_edges(a, a_face, b, b_face, chord) takes each side whole or
as one face (that face alone as a surface body, surfaces::taken), tags both
and imprints the first by the second in SMLib (smlib_imprint: "each of its
faces that `tool` meets cut along the intersection", capi/include/smlib.h).
SMLib intersects the faces' surfaces and trims each curve to both faces, so
the edges the imprint makes are exactly where they meet; its own history
says which they are (an edge no edge of either operand became). Each comes
back as its record curve on its interval, from SMLib's export of the
imprinted body, with its points from that body's mesh at `chord`. Sides that
do not meet give none.
The intersection link now stores each edge as a wire with its exact curve
(Wire::exact, the existing WireCurve; no new type or format change), its
points at 1/1000 of the larger body. project3d::mesh_intersection, its
triangle/triangle test and segment chaining go; project3d::mesh_of becomes
part_of (the body and, for a face reference, the face index).
Needs in crates/kernel/src/lib.rs (the coordinator's): `mod intersection;`
and `pub use intersection::{MeetingEdge, meeting_edges};`.
Not built: base in progress (kernel-smlib/no-truck 513ebe47 does not build).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
A rig case whose SMLib call fails left nothing to replay it from: nothing called
solidcraft_smlib::set_dump_dir. `solidcraft-cli kernel-cases --dumps=DIR` now points SMLib's
dump folder at DIR/<area>-<case> before each case runs, so a failing call leaves its
arguments and B-reps there (smlib_brep_read reads them back into a scratch C program), and
turns it off after the run. Off without the flag. The kernel exposes it as
smlib_dump_dir, beside smlib_built (the CLI reaches SMLib only through the kernel).
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
truck-modeling, -topology, -shapeops, -stepio and the vendored truck-geometry, -meshalgo,
-shapeops, -stepio and matext4cgmath (with their attribution rows and vendor notes) are removed.
The kernel-cases runner has one kernel, SMLib, and no build-mismatch check; a modelled thread is
cut by SMLib's exact screw-swept groove (the faceted groove path is gone).
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
Edge chains are the body's record edges, walked along their curves the way the
chain runs; G1/G2 conditions read the open edge's face on the record with its
exact first and second derivatives (SurfaceEval::derivs, ::second). The face is
built on the record: each side the network surface's boundary row on its knots,
split at the chains' inner vertices into edges over parts of the side's interval
(no knot insertion), each with its straight pcurve; a collapsed side is left out.
boundary_join counts the record's edges. Tests ported.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
ssi::intersect took a sample count and gave each intersection curve as
samples: its 3D points, its UV points on each surface and the surfaces at
them. The fork's 947eedc hands out the curves SMLib's intersectors return,
exactly (smlib_ssi_curve_nurbs: degree, knots, control points, weights), and
drops the samples; SMLIB_ABI_VERSION 4.
SsiCurve now holds the 3D curve as a schema 4 Curve::Spline or
Curve::RationalSpline (rational where a weight is not 1) and each UV curve
the method returned as a Curve2, with SMLib's type, deviation estimate and
the 3D curve's natural interval; ssi::intersect loses its sample count. A
curve SMLib does not hold as a B-spline is Error::Unsupported (it is never
approximated); a B-spline whose knot count is not points + degree + 1 is an
argument error.
The SSI corpus scorer (tests/ssi_corpus.rs) samples the exact curves itself
where the corpus runner samples them: 4001 parameters spread evenly over the
3D curve's natural interval and over each UV curve's interval, the surfaces
evaluated at the UV samples, samples that cannot be evaluated dropped. The
unit test plane_through_sphere_is_a_circle evaluates the exact curve.
Nothing else used the samples. SMLIB_REV: the fork at 947eedc.
clippy -p solidcraft-smlib --all-targets, with and without native: clean.
The corpus gate (smlib_global_intersect_at_1e_6) is not run here.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
bridge::{chain, frames, frames_across, chain_closes} and surfaces take
body.record() instead of encoding one; a surface body is Body::from_record of the
canonical record, a stitched one Body::from_smlib_record of SMLib's export, its
history matched to the input record when SMLib's import numbers it alike.
record::attach takes the new form.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
The bridge core was already its own geometry; its readings went through truck.
Chains are edges of the body's record (index, direction), measured along each
edge's record curve the way the chain runs; a support face is a record face whose
surface is evaluated with its exact first derivatives (SurfaceEval::derivs) where
truck's were finite differences; the station's parameters come from SurfaceEval's
projection. The bridge face is surfaces::tensor_sheet, and blend_between records
it as new over [a, b]. frames, frames_across and chain_closes take the body and
face index. Boundary patches go through the same bridge. Tests ported.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
surfaces.rs gains the record pieces NURBS faces are built from: a NURBS surface
and curve as record geometry, a pcurve along a parameter line, a whole tensor face
bounded by its net's boundary rows and columns (exact for a clamped surface), and
all_new for a face new to an operation. tspline_sheet makes a regular T-spline
that tensor face and an irregular one its Bézier elements, each side split at the
T-points, each edge an exact Bézier piece of its side with a straight pcurve on
every patch it bounds, shared between neighbours. Tests ported to the record.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
Copy, unstitch, reverse and remove faces, Patch (a sketch region, or a planar loop
of a body's edges) and Extend work on the body's record: Parts puts any faces,
edges and vertices into canonical order, and each face taken is the body's face
(Kept), its edges the body's. Sheets are SMLib's sweeps with no caps (extrude,
revolve, curve sweep, stations for twist/scale/orientation/rails), a chain at a
time; a loft lofts each column of matched segments and stitches the columns.
History: a wall comes from the segments its edges in the start plane lie along.
Stitch joins the bodies' records and sews them with smlib_stitch, faces and edges
carried back to the bodies through SMLib's tags. Offset Surface offsets each face
on its own with smlib_offset_sheet and stitches the offsets within the tolerance:
smooth neighbours stay joined, sharp ones come apart, as before; the fitted
offset surfaces and their fold check are gone. Thicken is SMLib's thicken.
Not yet: a surface sweep along a path with corners (refused). Tests ported;
the fold-radius message test now checks only the refusal.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
loft_rails.rs placed stations between truck wires. Its law now works on the
sections' exact NURBS curves (Section, from the sketch segments' record curves)
and returns the sections and stations, each a curve list a loft is skinned
through; nothing of truck is left.
Case 4056 (a keel rail lying in the bow's sketch plane): rail() anchored every
section at the rail's first crossing of the section's plane after the section
before. A rail lying in the last section's plane crosses it all along, first at
the far section, 100 mm from the bow's curve, and the loft was refused ("a guide
rail crosses section 2's plane"). A rail runs from the first section to the
last, so the last section is met where the rail ends; the sections between are
met at their first crossing, as before.
smlib_sweeps.rs's solid loft_rails keeps its own copy of the anchoring and has
the same cause; it should call loft_rails::railed.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
The safe wrappers of the fork's smlib_stitch (a body's faces sewn at a tolerance,
oriented, with whether it closed) and smlib_offset_sheet (a sheet's faces onto
their offsets), for the kernel's Stitch and Offset Surface.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
freeform.rs turned each free-form sketch segment into a truck edge. It now gives
every segment (lines, arcs, Béziers, conics) as a record curve and its pcurve on
the sketch plane's own surface, on one parameter with the same knots and weights,
so the pcurve lifts onto the edge exactly.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
trim_keep told each piece's side of the tool from the tool's field at the
centres of its mesh triangles. Each piece now takes one point on its own
surface inside its trims (SMLib's CalculateAnInternalPoint, through
smlib_face_points), mapped to the record's face order through SMLib's
numbering of the split body; the tool's field there says the side. A piece
whose side can't be told is an error, never guessed.
(not built: base in progress; no errors in this file)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
Each face's point from SmFace::CalculateAnInternalPoint, in SMLib's face
order; the fork at 89a1933 (also: smlib_extend_sheet extends every surface
as SMLib's B-spline, its analytic kind given back).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
planar_regularize now calls the fork's smlib_merge_faces as it is
(SmBrep::RemoveTopologicalEdgesAndVertices with the edges under the kept points
staying): every edge the lineage does not choose is kept by a point at its
middle, so SMLib joins the faces across the chosen ones only. A body with more
kept edges than one call takes stays as it is, as the other budgets leave it.
splitface, planar_sources and planar_regularize read the body's record in place
(Body::record) and a face's use from Body::face_forward; the two-lump test body
is Body::from_record of the two records side by side.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
planar_sources reads each face's oriented plane from the body's record
(actual_planes: the surface's plane, turned with the face's use) instead of
truck faces; the lineage rules are unchanged. planar_regularize picks the edges
to remove as before (two faces of one shell on one certified plane, from one
source unless generated walls, off every split line) from the record's edge
uses, and SMLib joins the faces across them (Brep::merge_faces: each edge
removed where SmEdge::IsTopological finds the faces' surfaces coincide), so the
merged face is SMLib's and the history its own tags (Merged), composed through
the body's. SmBrep::Simplify is not this operation: it refits curves and
surfaces by knot removal and sampling.
The planar_sources tests read face points, edges and planes from the record;
the two-lump body is built from the two records side by side, each face given
the source of its own operand's face on that plane. Deleted:
planar_regularize's alternate_adjacency_path_cannot_remove_protected_internal_edge,
a test of the truck face builder merged_face (only listed edges are removed now,
so no other path can remove a protected one).
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
coplanar.rs (coincident faces pushed apart, faces glued back to back, bores and
insets joined, imprint unions), seam_faces.rs (round faces halved before a
retried boolean) and planar_faces.rs (flat B-spline faces made planes so the
coplanar strategies see them) existed to get round the mesh-based boolean's
coincident faces and seam loops. SMLib's boolean classifies coincident faces
itself (SmMerge::ManifoldBoolean, step 2), so these are retries and second
paths around the operation, not operations: deleted, not ported.
Their tests of what the boolean gives keep their volume, lump and validity
assertions and now run against the boolean itself (coplanar_tests.rs and
seam_faces_tests.rs need their own mod lines in lib.rs); the assertions on the
strategies used, and the tests of push_faces, grow_faces_exact, trim_exact,
planarized, coincident_planes and halved, go with them.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
A tool is now a set of schema 4 record surfaces, each over a parameter box,
unbounded where the tool is: a plane; a face's surface over its own box; a
sketch curve as one patch per segment swept along the direction (a line a plane
strip, an arc swept square to its sketch a cylinder strip, any other segment its
exact rational Bezier extruded), an open curve continued along its end tangents
past the body. SMLib cuts the faces where the patches meet them
(Brep::split_faces: its intersection curves trimmed to each face by
MergeCurvesOnSurface) and slices a body with one patch (Brep::split_body); the
history is SMLib's own tags. Nothing is traced on a mesh, sampled or fitted.
Which side of the tool a point is on is its offset along the normal of the
nearest patch, each patch's surface prepared once with its projection grid
(ToolSide), never per point. ToolSide::of and side_of_point take the body the
tool must reach past; face_side becomes face_sides (every face of a body, one
mesh); analytic_field becomes analytic_face (a face of a body, on its record);
split_any returns the face map instead of the truck imprint. split_edges_at and
fit (a Catmull-Rom fit through samples) are deleted with the truck code.
ssi::Surface::from_record turns a record surface over a box into SMLib's.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
split_faces cuts faces (SMLib face order) where ssi::Surface tools meet them and
says per face how many faces it became; split_body cuts a solid in two by a
surface, the part behind it and the part in front. SMLIB_REV moves to the fork
commit that adds smlib_split_faces and smlib_split_body.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
face_params and outline are gone (no callers on the record). The fork head adds the 2D planar
boolean (smlib_planar_faces, smlib_boolean2d), the grazing-curve crossing rule (solidcore#480) and
untrim's parameter-box status.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
It imprinted two bodies touching back to back on each other along the outline of their
contact and glued them, for the old boolean's coplanar unions that could not join the pieces
its own imprint left. SMLib's boolean is the one path, and nothing calls it any more. Its tests
of the union itself (a lip swept on a round rim joins it, the lip's foot is a plane) stay as
boolean tests, without the old retry diagnostics.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
Its sampled parameter loops (points projected back onto the surface, the outer loop guessed by
area) and its iso-curves of truck surfaces served Untrim and Extend, which no longer use them;
on the schema 4 record a face's loops in (u, v) are its exact pcurves, the outer loop the one
running counter-clockwise about the natural normal. The only use left is a truck test in
native.rs's seam fixtures.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
geom's NURBS curves and surfaces become the record's rational splines, weights kept.
tensor_face builds a whole tensor surface as a one-face sheet (assemble's new Assembly::sheet:
one open shell in the infinite region): the net's first and last rows and columns as edges on
the surface's own knots, sharing the corners, each with its exact pcurve (an iso-line, the
edge's parameter being the surface's along it), and returns the body.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
plane_through gives a plane record (its natural normal turning with the loop); EdgeSampler
samples a record edge through CurveEval in the direction a loop runs along it (an intersection
curve traced as the record holds it, with the evaluator's own hint); planar_face certifies a
loop of record edges from their records (lines by their ends, circles and ellipses by their
frames, polylines and splines by their points with positive weights, intersection curves by a
plane among their surfaces) and returns the plane, the caller building the face on the record.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
A face's reach into a region comes from its record surface: planes (as offset::surf_of reads
them) lie in their triangles, a spline face's control net bounds it (its hull, read off the
record's points and positive weights), walls along the direction are prism::wall_along's, and
round faces keep their span and side. Truck's surfaces and the guard around them are gone.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
The exact step of the distance between bodies works on the record: analytic faces in closed
form as before, other faces through SurfaceEval::project, edges by a bracketed golden-section
search of the record curve's own points from the nearest of evenly spaced ones (one method for
every curve kind, traced intersections included), the direction there from the curve's
derivative. Truck's point inversion is gone with it.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
face_surface is the record face's analytic surface (offset::surf_of); edge_circle takes a
circle record's centre, axis and angle exactly (its parameter is the angle about the frame's
z), and for any other curve keeps the test that its points all lie on one circle (SMLib holds
its primitives' circles as rational splines). The spindle torus's signed major radius is gone
with the old kernel: the record's tori are ring tori.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
Seams and merged topology tell faces on one surface apart by the record's own surfaces
(offset::surf_of: plane, cylinder, sphere, cone, torus) and, for free-form faces, by the very
same surface record, never by fitting circles, spheres and cones to mesh vertices or by
comparing mesh normals along an edge. Edges are welded by their record vertices and middle
point, split lines and pinches read the record edge's points, a cone's apex is checked against
its faces' record vertices. The mesh still gives faces of no area and a cylinder face's extent
along its axis; a cylinder's side (hole or boss) is the record's.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
planar_regions_boolean replaced each free-form loop (a font's curves, an ellipse) with arcs
fitted within PLANAR_FIT_TOL before its own line/arc arrangement, and a loop the operation
cut kept those arcs: a cut free-form outline was extruded inexactly. Now each operand is a
sheet of planar faces built from its loops' own curves (Brep::planar_faces; lines, arcs and
the Béziers and conics as NURBS, exactly) and SM_API's 2D boolean combines them
(Brep::boolean2d): SMLib's topology intersector, the one the solid booleans use, splits the
operands' edges where they cross and the result's edges are copies of those curves. The
faces read back exactly (prism_curve::projected: lines, arcs, each Bézier span as the
segment it is). The Rust arrangement (crossings, ray parity, chaining, the fit and the
"exact again" restoration) is deleted: one source, no fitting.
extrude_planar_regions unites its regions the same way (balanced unions of one-region
sheets) and refuses pieces of the union that share a vertex, read off the result's
topology instead of a line/arc crossing test on fitted arcs.
Signatures stay (doc/sheet.rs and mesh_convert call them as before); `tolerance` is the gap
a loop may close within and the least tolerance edges are read back at. PLANAR_FIT_TOL
stays for doc/engine's flat patterns, which fit their own loops. smlib_sweeps::curve (the
Seg2 to SMLib curve conversion) is made pub(crate) for the sheets.
Tests: those of the deleted helpers (crossings, ray parity, closest_param, segment boxes)
are gone; the free-form test now asserts what the exact boolean gives (the half-ellipse
notch is the ellipse's own conics, area exact to 1e-6; the joined ellipses are conics), and
the fitted-arc budget assertion is dropped. Without the smlib feature the booleans are
refused ("not supported yet").
(not built: base in progress; cargo check shows no errors in prism.rs or smlib_sweeps.rs
with and without the smlib feature)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
Wrappers of the fork's smlib_planar_faces (a sheet of planar faces from closed curve loops in
one plane, nested by SMLib) and smlib_boolean2d (two such sheets combined as regions of the
plane by SM_API's 2D boolean, the inputs' own curves split where they cross; an empty result
is None). SMLIB_REV moves to the fork commit that adds them (78617dd).
clippy -p solidcraft-smlib --features native --all-targets -D warnings: clean.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
The general fill (G1/G2 patches, patches through points, loops that bound no height
field) is solidcraft_geom::fill_iso's patch on the loop's own edges: each line or spline
edge, on its interval and run the loop's way, is a side, so its pcurve is a straight line
in (u, v), exact. The frames across a G1/G2 edge are read off the one face beside it in
the record: its outward normal, the way it leaves the edge, and for G2 its normal
curvature from the surface's exact second derivatives. Corners whose neighbours' tangent
planes disagree are exempt from the angle tolerance. Loops of five or more edges, and
conic, rational or traced edges, are refused by name.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
The loop's edges become the sides of the unit square (three sides: the fourth collapses
to the first corner, a pole), each mapped affinely onto [0, 1]. Opposite sides are made
compatible exactly (split into Bezier pieces at every break, raised to the higher degree,
rejoined), the bilinearly blended Coons patch is the start, and with the boundary rows
held the interior control points solve the G1/G2 rows, the points to pass through and a
vanishing multiple of the thin-plate energy by least squares, refined by halving spans.
Every edge lies on the patch exactly and its pcurve is a straight line in (u, v), affine
in the edge's own parameter: no pcurve is fitted.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
A solid body's volume, area and centre are SMLib's mass properties at its documented 1e-4 and its
box SMLib's exact one; a body SMLib cannot measure is an error. The three-mesh measure and the
mesh cross-check beside SMLib's numbers are gone, and with them the kernel switch
(SOLIDCRAFT_KERNEL, Backend): SMLib is the kernel. The smlib feature gates in the crate root, the
validity check and the offset backend go, since SMLib's crate is always linked (answering not
built without the feature).
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
Encoding writes the body's own record and decoding makes the body from it: the adapter to and
from the old kernel is gone. A record goes into SMLib as given (SMLib's own form); one SMLib
refuses is an error that names why, never sent through SMLib's healer. A body made by SMLib keeps
the SMLib body. The bounded preview of a decoded body is a coarse mesh from the planner, charged
to its triangle budget.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
A boolean is SMLib's boolean, its history SMLib's tags: the jittered retries, tool nudges, prism
and coaxial routes, the retry result guard and their diagnostics are gone. A rigid placement moves
the record; any other matrix goes through SMLib's transform (new Brep::transformed over
smlib_brep_transform). Bodies apart join as their records side by side (brep part::compound),
with each piece's faces, sources and history; apart means their exact boxes do not meet. A split
is the intersection with a half-space box, with no faces pushed off the plane.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
The fork head carries untrim and extend shims with their history tags, the local solvers that
take no value from a failed evaluation (solidcore#481), the B-spline curve radius check
(#475), the torus minor-interval check (#482), the blend rail along its face's rim (#485) and the
intersection path's statuses.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
What stays is the composition of a multi-step operation's histories (composed, placed, kept,
through, operand, of_pair, Traced). healed(body) is crate::heal::heal with the body's split
lines kept, its history over [body] SMLib's, each face keeping the construction source its
faces shared and the body its regularization protection (as the prism result's healing did).
Deleted with the old kernel: heal_build, truck_result, heal_body and heal_prism_result (heal
and record::after replace them), Shapeops and shapeops (truck's boolean history), edges_evaluate
(sampling truck's intersection curves), copied and void (truck copies and the void boolean,
no callers left), join (records apart join through brep::part::compound) and parts_of (a lump's
history is history::of_part). Tests: the truck-retry tests (shifted attempts, the nudged tool)
deleted; shell counts read the record.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
Body::from_record takes the finished record as the body, so its faces and edges are the
record's and the history needs no round trip through SMLib's numbering. The edge origins
(kept edges, pieces) go to record::attach, which gives every other edge its faces' meeting.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
An operation that builds its result says, per result face, what it is made from (an operand
face it is the whole of or a piece of, profile segments, caps, operand edges a blend replaces),
and per result edge the operand edges it is or is a piece of (pieces_of); of_faces and attach
make the history of the result's record from that, every other edge the meeting of its two
faces, operand faces under several result faces marked Split. That is the one model in place
of the identity-based Operand, Rebuild/Was, traced/build/build_placed, edge_index/face_index/
edge_origins/edge_provs/edges_by_identity, from_faces, solid_counts and rebuilt/rebuilt_body,
and of the truck sweep followers (ruled, follow, columns, Column, swept_face), all deleted.
The face constructors, regions, counts, after and meeting stay. Tests read edge_faces of the
body's record.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
The SMLib point sweep refused a polyline whose points turn gently (a smooth run
of more than two points), a branch on the shape of the input: a polyline is
the path its points make, and SMLib's cornered sweep mitres it at each point.
Curves with an exact form no longer reach the kernel as points (previous
commit); what still does (curves projected onto a face, intersection and iso
curves, sweep_path's point lists) is followed as those points.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
A sweep path through 3D sketch curves sampled every planar sketch curve in it
into a 0.01 mm polyline, and took every linked 3D curve as the points its link
stored, so SMLib got a many-cornered polyline (and refused a smooth one). Now:
- a planar sketch curve in such a path is its exact segments
(PathPiece::Segs of PathSeg::of_sketch over exact_segs);
- a linked curve whose source has an exact curve keeps it: Wire::exact holds
the record curves (WireCurve: schema 4 curve + interval) end to end along the
wire, set with the wire when the link is resolved: an included body edge its
record edge (kernel::brep_record), an included sketch curve leaving the plane
its segments (kernel::sketch_record_curve). Wire::map carries them with a
placement. The sweep follows them through kernel::curve_path (line, arc,
ellipse as rational quadratic spans, polyline, B-spline as Bézier spans).
- curves known only as points (projected onto a face, intersection and iso
curves: the link resolves them on the mesh) stay points.
Kernel, for the sheet and blend ports: planar_face_record (a profile face as a
schema 4 sheet record with exact pcurves), smlib_sweeps::chain_curves (a
segment chain as SMLib curves), body_from_record (any record into SMLib,
checked), sketch_record_curve; record curves from design files are checked in
curve_path. Format: pending/wire-exact-curves.rs.
lib.rs (coordinator): export SpaceBezier, curve_path, edge_path,
sketch_record_curve and planar_face_record from the kernel.
(not built: base in progress; kernel and sketch check clean, doc not reachable)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
PathSeg::Bezier(SpaceBezier) replaces PathSeg::Cubic: a rational Bézier span in
space of degree 1 to 9 (homogeneous control points), so a drawn spline's cubic
spans and an edge's own curve are one kind of segment, swept by SMLib as the
NURBS it is. SpaceBezier evaluates, differentiates (quotient rule on the
hodograph), measures and walks by length (Gauss-Legendre), reverses and maps.
edge_path gives a body edge's record curve as path segments exactly: a line,
an arc, an ellipse as rational quadratic spans, a polyline's lines, a B-spline
as its Bézier spans between knots (bspline::segment); an intersection curve
(no exact curve in the record) is refused. PathPiece::Segs carries such exact
curves in a point path; PathSeg gains reversed, mapped (a placement) and
of_sketch (a sketch segment on its plane). The cubic_* helpers are deleted.
surfaces.rs: its one PathSeg::Cubic arm follows the rename.
lib.rs (coordinator): export SpaceBezier and edge_path from point_path.
(not built: base in progress; cargo check shows no error in these files)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
extend_surface keeps its signature, options and error messages. One model:
SMLib extends the surface past a side of the face's parameter box
(smlib_extend_sheet, CreateExtendedSurface: natural continues the end spans,
tangent G1, curvature G2) and the face stays one face on it, tagged so the
face is Modified and its sides keep their edges. Several picked sides grow
the box on each. Up to a target, the face is extended 50 body sizes past
its edge and trimmed back with trim_keep (SMLib's exact intersection),
keeping the piece the face lies in. Back to the bounds is untrim of the
picked edge's face, in place, with its holes; one already there is
refused. A plane's straight edges with neighbours lengthened still go
through surfaces::extend. Edges are picked on the schema 4 record (samples
of each edge's curve), an edge two faces share or of a hole refused as before.
Not ported (every far edge there was a cubic fitted through marched
samples, which the exact-B-splines rule forbids): an edge that is not a
whole side of its surface's box (trimmed edges, curved planar edges such as
a disc's, a notch), mitred corners on such faces, sides run square to the
edge on a non-box face, and bodies of more than one face. These now answer
"not supported yet: ...". Tangent and curvature no longer add a separate
run-off face: SMLib's G1/G2 extension is one face (the engine's
surface.extend description says so).
Tests ported keeping their assertions: the planar extension, the cylinder
strip along its axis, around and both (now an extruded arc, not a truck
revolution), the extruded strip, the parabola extended naturally (now a
conic extruded), back to bounds (the saddle from loft_sheet and trim),
hostile requests. Deleted, as what they test no longer exists:
neighbours_lengthened_or_square, self_intersecting_extensions_are_refused,
a_disc_grows_by_its_curved_edges, neighbouring_faces_extend_together, the
tangent/curvature run-off half of the B-spline test, and
a_continued_bspline_is_unchanged_on_its_range (the deleted continue_span).
SMLIB_REV: fork 9531966 (tags carried through untrim and extend).
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
untrim keeps its signature and messages. The face is picked in SMLib by a
point inside it (the centre of its largest mesh triangle), holes by their
points; SMLib deletes the holes or rebuilds the face over its surface's
parameter box with the holes kept (fork c6c7fb4). The body goes tagged as
operand 0, so faces and edges come back with their origins; the untrimmed
face is Modified. A face whose span goes all the way round its surface now
closes on the seam instead of being refused.
solidcraft-smlib: Brep::untrim_face (ffi/trim.rs, trim.rs) and
Error::NotExact for SMLIB_ERR_NOT_EXACT.
Tests: ported to the record (loops counted on brep_record; the saddle made by
loft_sheet and trim instead of truck types; the torus face copied out by a
point). Deleted: the_outer_loop_is_found_whatever_order_the_loops_are_in: it
built a truck face listing its hole first; SMLib's import always puts the
outer loop first, so the case no longer exists.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
trim / trim_keep / mutual_trim keep their signatures and behaviour; the
truck walk over the split solid is gone. The body is split where the tool
meets it (splitface::split_any), each piece's side is the tool's field at
the centre of its mesh triangle where the field is largest (the record
mesher), regions come from splitface::regions, and the pieces not kept go
through remove_faces, whose history record::after carries back to the
body. A mutual trim's nearest boundary edge is found on the schema 4
record: edges one face uses once, their middles through CurveEval.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
A solid body holds its record (canonical faces, edges and vertices are the body's everywhere) and
builds its SMLib body from it on first use, or keeps the one the operation made. Queries read the
record: planar faces, outline and exact bounds, counts, closed shells, lumps from its material
regions (record parts, with their history), shell nesting from its regions. The orientation mesh,
the revolved-face rephasing, kept tolerances and the old kernel's mesh caches are gone. History's
edge faces come from the record's edge uses. The kernel no longer depends on the old kernel's
crates; SMLib's crate is a plain dependency (without the smlib feature it answers not built).
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
compound concatenates the records and takes the part of all their material, so the result is
in canonical order with each face, edge and vertex numbered from its input. part now keeps an
island inside a void when both its region and the void's material are taken.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
patch_loop picks the closed loop among the record's edges, certifies a plane (lines by
their ends, splines by their control points, conics by centre and tilt, traced curves by
a planar support) or fits the height field, and assembles one face on the body's own edge
records; the height field's parameters are plane coordinates, so each line or spline
edge's pcurve is its exact projection (segmented to the edge's interval). The history
marks the face generated and each edge the body's own. A fit on circular, elliptic or
traced edges, whose pcurves on the spline have no exact form, is refused by name, as is
the general fill (G1/G2, points, loops bounding no height field) until it is ported.
Tests ported to the record; the general-fill ones stay and fail until then.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
corner_g2_patch builds the same tensor patch and returns CornerPatch: the B-spline
surface record, its v = 0 boundary line (the net's first column on the same u knots)
and each side's interval of it, so the seams lie on the patch exactly without cutting
the curve. The fold check and seam_error read the record surface through SurfaceEval.
Tests ported (the rolling ball is a sphere record).
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
Edges, the faces each bounds and each face's outward side come from the schema 4
record; stations on the edge's curve (CurveEval::derivs for its tangent) are projected
onto each face's SurfaceEval, and the normal curvature across the seam is read from the
surface's exact second derivatives (SurfaceEval::second). Behaviour, budgets and
messages unchanged.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
Closed forms on cylinders, cones, spheres and tori; on a spline the basis functions' own
second derivatives (local_basis) through the quotient rule for the weights; zero on a
plane. A revolution has none (its profile evaluator carries first derivatives only).
The seam continuity measure reads normal curvatures from them.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
fair_bspline_curve/_surface and fair_nurbs_curve/_surface take and give the schema 4
record's Spline and RationalSpline kinds (the weights kept, the knots unchanged).
fair_faces fairs the picked faces' surfaces in the body's record, keeps its loops,
edges, vertices and pcurves, and has SMLib build the body; its history marks the
faired faces modified and every edge kept when SMLib keeps the record's order, and is
left off otherwise. Tests ported to the record types with their assertions.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
The faces' descriptions become a record with exactly the topology they give: vertices
and edges shared by key (lines, circles or flat arcs as their exact rational quadratic,
Bezier chains as B-splines), planes about the boundary's mean, revolved lines as
cylinders, cones or planes, extruded arcs as cylinders, ruled walls as B-splines with
exact iso-line pcurves. assemble() groups faces into shells, puts closed shells in
regions (a cavity where the outward normals enclose negative volume, in the solid whose
winding number about it is one), orders everything canonically and validates it.
SMLib imports the record as trusted; the body and the face each body face came from
follow SMLib's order. The edge-sheet and vertex-fan logic for touching bodies is kept.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
assemble (records rebuilt after removing and adding faces) joins; the boolean guards that re-ran
a failed boolean with a changed tool (bore_guard, candidate_reach, sphere_lens, tangent_cylinders,
touching_walls) are gone; the lens-cut result stays as a boolean test. SMLIB_REV at the fork's
integration head with smlib_merge_faces.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
heal: a body's faces on one surface merged and its edges on one curve joined by SMLib
(Brep::merge_faces, SmBrep::RemoveTopologicalEdgesAndVertices), the edges along its split lines
kept, with SMLib's history over the body. Its booleans already end the same way
(SmMerge::BooleanPostProcess). The truck healing is deleted with what only it did: coplanar and
collinear merges by hand, flat surfaces rebuilt as planes, and approximate edges refitted as
lines or arcs from samples. on_split_line stays; edge_points reads a record edge.
Deleted, with no port: the retries around the old boolean's failures (touching_walls,
bore_guard, tangent_cylinders, sphere_lens, tool_reseam, candidate_reach). Each re-ran a failed
boolean with a changed tool or split faces; SMLib's boolean is the one path, and a case it
fails is its defect to fix there. Their own tests go with them (the helpers' unit tests in
issue_788_tests, bore_union_tests, candidate_reach_tests, and sphere_lens' relaxed-tool test);
the #2750 lens cut's result test stays, as a boolean test, without the retry diagnostics.
Heal's tests built truck prisms and a truck spline edge: deleted.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
The wrapper of the fork's smlib_merge_faces (SmBrep::RemoveTopologicalEdgesAndVertices): faces
on one surface meeting along an edge become one, edges on one curve meeting at a vertex nothing
else uses become one, and the edges under the given points stay. SMLIB_REV moves to the fork
commit that adds it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
The neighbours of the deleted faces are rebuilt from the body's record: each keeps its own
plane (every moved corner lies on it) and its edges away from the gap; corners on the gap move
to where the neighbouring planes meet, and the gap closes with straight edges shared between
the rebuilt faces. Moved and restored edges are recorded as pieces of the edges they replace
(assemble.rs: Assembly::piece), so the history is as before: untouched faces kept, neighbours
modified, edges kept, pieces of their edges, or where their faces meet.
Test deleted: delete_pocket_keeps_an_imported_face_around_it bowed the edges of a truck body in
place to show that a face losing only whole loops keeps its surface; a record body has no such
in-place edit, and every rebuilt face now keeps its own surface.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
The band is built on the body's record: the face keeps its other loop and the band's edge, the
walls rise along the face's loop (continuing the walls below) and along the band's edge
(planes along lines, cylinders along arcs), and the band's top is the face's plane moved up.
Each face is given with its outside, so no orientation is tried: the eight flips the old
construction tried in turn are gone. rim_band reads the loop's lines and arcs from the record.
History as before (the trimmed face, each wall from its loop edge, the top an offset).
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
The emboss is built from the body's record: the wall's face loses the profiles' footprints,
each profile adds planar walls and its cap on the wall's cylinder at the new radius, and SMLib
builds the body from the finished record (assemble.rs: a record taken apart and finished again
in canonical order, pcurves from the record's routine for new uses, the record's own for kept
ones). surf_of and with_same_surface read the record's analytic surfaces; the topological
offset and draft that only the old kernel used are deleted (SMLib's offset faces and draft in
offset_backend replace them).
#3782: the saved pick had to lie on the half of the wall the sketch is tangent to (its angle
inside that face's span). The wall is every exterior cylindrical face of the body (a stepped or
interrupted cylinder is refused before), so the pick is checked on the cylinder between the
endcaps. The sleeve test's far-side pick now succeeds; a pick on the bore is still refused.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
A lump of a body is the part of one of its material regions: its outer shell, its open and wire
shells and a void for each closed inner shell, renumbered in the record's canonical order, with
the source index of each face, edge and vertex for history. Islands inside those voids are parts
of their own. Read from the regions the record already holds, with no mesh or ray test.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
The fork's shims now hold an operation SMLib reports done to having done
something (SMLIB_ERR_NO_EFFECT, -1107: a blend that made no face, a face
move or draft that moved no face). It maps to Error::NoEffect, and the
kernel says "SMLib made no change: ..." for blends and for offset, shell
and draft. Case 1080 (chamfer over openings) returned an unchanged body
as success.
The fork pin moves to 6bb2938: the chamfer side fix of the piecewise
merge, the no-effect contract, and SmStatus marked must-use with the
dropped statuses of the shims and of the fillet, boolean, offset and sweep code passed on.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
faceted_boolean (a body with a closed triangle mesh) faceted the body's curved faces and ran
its own BSP polygon boolean, then rebuilt a truck solid. It now builds the mesh into a
solid: each run of coplanar triangles sharing edges (corners within `tol` of each other's
planes) one planar face, its boundary chained into loops (split where a loop passes a vertex
twice, holes given to the innermost outer loop), sewn with sew_touching; SMLib's boolean
takes it with the body, whose faces stay exact. The history over [a, mesh] is the boolean's
over [a, tool] with the tool's own over the mesh substituted: each tool face from its
triangles, each tool edge the meeting of the runs either side.
Deleted with the BSP and the rebuild: planar_boolean and sliced_planar_boolean (the truck
boolean's exact fallback for touching planar faces: on SMLib the boolean is one path),
reassembled and split_beside (prism_local's), components_in_order (truck shell order) and
the tests of what no longer exists (face_planes diagnostics, the planar fallback beside a
plate's small rounds).
lib.rs (coordinator): `pub use polybool::faceted_boolean;` (planar_boolean is gone).
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
The prism module kept two things: the 2D arrangement of planar regions
(planar_regions_boolean, and extrude_planar_regions, which normalises the material with it,
proves the pieces apart and extrudes them with crate::extrude, SMLib's extrusion with its
face sources), and a second route to the solid boolean: prism operands read section by
section, the result sewn and its history rebuilt from section tags (prism_boolean,
prism_union_between_caps, the stacked and free-form variants, prism_lineage.rs) and the
column-local variant (prism_local.rs). On SMLib a boolean is smlib_boolean, with SMLib's
own history: the second route is deleted, with its tests (prism_spline_tests.rs, the
stack/prism tests in planar_tests) of what no longer exists.
The section tags shrink to what the arrangement uses: the free-form segment a fitted arc
stands for. wall_along reads a record surface (cylinder, revolved line, spline net) for
clearance.rs. The 2D tests and the wall test keep their assertions.
lib.rs (coordinator): drop `mod prism_local;`.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
certified_prism_equivalent proves two bodies the same uniform prism from their records
(crate::native::brep_record): caps are the planar faces square to a candidate direction,
their outward side from the shell's oriented faces, their loops run about the outward
normal and read by prism_curve; walls are planes, cylinders (their axial extent from the
face's domain), revolutions of a line or ruled spline nets, each bounded as before. The
interval arithmetic, loop matching and separation proof are unchanged. Tests build their
altered bodies by editing the record (a wall's surface swapped or moved, a cap plane's
origin moved far away) instead of truck faces, with the same assertions.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
prism_curve::segment and ::projected take a Run (a record edge's curve over its
interval, run one way, with the vertex points it must reach) instead of a truck edge.
Lines and circles are read exactly as the record holds them; a polyline as its lines; a
B-spline or NURBS curve span by span (clamped to the interval with Boehm insertion, then
split into Bezier spans), certified by the existing whole-span Bernstein proofs; an
ellipse as its exact rational quadratic spans of at most a quarter turn. segment_fitted
(arcs fitted to a spline, only the prism boolean's free-form route used it) is deleted.
The existing tests run on record curves; the part of the aliasing test that asked the
deleted prism boolean to decline is dropped.
Callers in body.rs, bore_guard.rs, sphere_lens.rs (other owners) build a Run with
prism_curve::Run::of(record, edge, forward) or Run { curve, interval, forward, ends }.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
measure_backend asked SMLib for mass properties at 1e-8, the finest its
integrator allows and below the range SmApiBrepComputeMassProperties
documents ("Relative accuracy, clamped to [1e-4, 1e-1]", SmApiQueries.h,
whose cost is "governed by dRelativeAccuracy"). The tight request was there
because the documented range did not hold on faces bounded by circles
(KNOWN_ISSUES.md); the fork's dcbb07d integrates each trim-curve knot span
on its own, and such faces now meet it (a cylinder's volume 1.8e-6 off at
1e-4). At 1e-8 SMLib's measure was most of the regression rig's time on a
modelled thread (threads/602).
The measure now asks 1e-4: ten times inside the 1e-3 it is held to (AGREE
against the mesh measure, and the rig's volume and area tolerance). NURBS
spheres and tori can still miss 1e-4 by a small factor (tangency-labs/
solidcore#384; a torus's volume 2.5e-4 at 1e-4), inside that 1e-3.
Brep::mass_properties keeps MEASURE_ACCURACY (1e-8) as its tests' default.
SMLIB_REV: the fork at dcbb07d.
Not built: base in progress (kernel-smlib/no-truck 52f25ca3 does not build).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
A rotation and a translation move every point, axis and control point and leave parameters,
pcurves, tolerances, orientation and the canonical order as they are: the same B-rep in other
coordinates. Placing a body (assembly instances, patterns) no longer needs a kernel round trip.
Reflections and scalings change parameters or geometry kinds and go to the kernel.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
SMLib's blend builds rolling-ball rounds, corners, loops and vertex spheres in one call; the
modules that built them on the old kernel were deleted by the blends port.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
A join is hidden when both faces are clamped Bezier B-spline surfaces swept by one
linear translation (read from the record's spline net, the face's side from its shell)
and the edge is a straight line on a ruling of both, their normals agreeing within the
certified angle, as before. The edges are the record's, in the order the mesh has them.
Tests take the record (a closed edge's equal end vertices, the ruled face by its spline
net, ruled() on record control nets); the case that bowed a truck edge in place is
removed (a record edge cannot be changed under a body).
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
curveblend.rs (rolling-ball rounds and chamfers of curved edges, their corners, the law
and chord variants), curvecorner.rs, loopblend.rs (blends round whole face loops) and
blend_vertex.rs (a sphere at three rounded edges) built blends on truck; SMLib's blend
makes all of these in its one call, with its own corners. curvecorner_tests.rs tests
fillet and chamfer through the public functions only, so it stays, mounted from blend.rs.
curveblend_tests.rs and curveblend_law_tests.rs go with the builder: they test its
internals (fit_sections, curve_blend_with_limit, ROLLS, its NURBS surfaces and contacts).
lib.rs needs `mod curveblend;`, `mod loopblend;` and `mod blend_vertex;` removed.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
fillet_variable, fillet_variable_points and fillet_variable_spline round the edge with
SMLib's variable-radius solver (smlib_fillet_variable) on any edge; fillet_chord is
SMLib's constant-chord round (smlib_blend, SMLIB_BLEND_CHORD). On a straight edge
between planar faces a radius law whose band runs past the faces at any of 256 stations
is refused as too large before SMLib runs, as before. The edge setup, the band check and
the taper's room read the body's schema 4 record: planar faces' outward normals, the
directions into them, side edges' exact tangents at the ends; a curved boundary is
divided to within the clearance for the containment test. RadiusSpline evaluates with
the geometry crate's B-spline basis.
The truck variable-radius surface builder and the rolling-ball law and chord blends are
gone. taper_mesh_tests keeps its mesh-accuracy test; its three tests of truck's mesher
on a surface with an arbitrary pole are removed (that mesher no longer exists).
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
The corner builder (one, two or three rounds at a vertex of planar faces, taking earlier
rounds off and blending them again) is gone: SMLib's blend makes those corners itself,
with each edge's radius. The tests check through the record (curved faces' normals along
their shared edges, vertex points, planar faces' vertices on their planes). Removed: the
assertion that a concave edge meeting a convex one is refused, a limit of the deleted
builder.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
fillet, fillet_each, fillet_g2, chamfer and chamfer_sides blend every picked edge in one
SMLib call (smlib_blend / smlib_chamfer_sides), which builds the rounds, their tangent
chains and the corners where they meet. The #1080 fit check (blend_fit) reads the body's
schema 4 record: planar faces' outward normals, the direction into a face across a
straight edge, edge tangents at the ends. It now runs before SMLib, so a blend that runs
past its faces is TooLarge with the largest size that fits (fillet_max_each, the taper
and the doc's reduce path rely on that), and the volume and wrong-way checks after it.
fillet_max_each groups the edges by their faces and ends in the record. fillet_g2_corners
is refused: SMLib's corners are a sphere or a Coons patch, not G2.
The local truck blends, their reorder search and every truck helper they used are gone.
Tests: blend.rs's tests call fillet/chamfer instead of the deleted internal `blend`; the
assertions on the deleted quintic construction's surface and curve parameters and on
extension_fits (deleted) are removed, the analytic volumes kept.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
Every builder in build.rs keeps its signature and is SMLib's: extrude and
extrude_whole_sides (smlib_extrude), revolve and revolve_whole (smlib_revolve;
SMLib makes one face per profile segment and cap, so the two agree), the
tapered extrude (smlib_extrude's draft), loft, loft_with_rails, loft_regions
(smlib_loft, smlib_sweep_stations for rails), sweep and sweep_with
(smlib_sweep / smlib_sweep_placed, controlled ones smlib_sweep_stations). Box,
cylinder and torus are built through those, keeping their face sources and
history; sphere is SMLib's own (smlib_make_sphere), each face from the half
disc's arc as before.
Deleted: every face-by-face build (tsweep/rsweep shells, the revolve-on-axis and
touching-axis builders, poles, reseams, the healed whole revolve, the six-patch
sphere and its rotated variant, the tapered side faces, cap_and_close,
close_sweep, the full-circle sweep), and the taper's crossing pre-check and curve
splitting that only that path used (offset_crosses, offset_splits,
offset_error, offset_tolerance). Wire, loft-face and interpolation helpers other
modules still build on stay until those are ported.
(not built: base in progress; cargo check shows no error in this file)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
sweep_path_with is SMLib's sweep along the path's lines (smlib_sweep_points
through sweep_with, corners mitred). Deleted: the B-spline walls fitted through
sampled stations (smooth_walls, smooth_closed_walls), the ruled walls between
stations (ruled), and the helpers only they used (rotated_wire, start_cos,
swept_volume). The open walls of chains (ruled_sheet, smooth_sheet) stay for
surfaces.rs's sheet sweeps until those are ported.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
Brep::sweep_placed (smlib_sweep_placed, fork f6f428b) returns the rigid motions
carrying the profile onto the sweep's first, middle and last sections. Each run
of a path with corners now takes its end pose from the last motion (less the
straight lead-out along the end tangent) and its inside seeds from the middle
one, for every path segment kind: the 3D sketch spline next to a corner is no
longer refused. Deleted: the predicted carry along a run (carried) and
point_path::cubic_split, which only it used. SMLIB_REV at f6f428b.
Fork: build + ctest, only smlib_flat_roundtrip's known incline failure.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
convex_polyhedron builds its schema 4 record straight from the planes (corners
at triple-plane intersections, line edges, planar faces with exact line pcurves,
canonical order) and SMLib takes it (Brep::from_record, trusted) and checks it.
shell, draft and offset_faces are SMLib's local operations (smlib_shell,
smlib_draft, smlib_offset_faces through offset_backend).
Deleted: the half-space shell and draft of convex bodies, the planar-offset
cavity shells (barrel, opening overreach, opening sweep), the non-convex draft
walls, the split-piece press after a failed offset, round_all_edges and the
helpers only they used, and the test of the deleted rim pre-check
(rim_preflight_tests).
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
sweep_helix is SMLib's screw sweep (smlib_screw_sweep) and loft_to_point SMLib's
loft to a point (smlib_loft_to_point), with their checks and history as before.
Deleted: the B-spline walls fitted through sampled stations (smooth_helix), the
ruled walls between stations and the face-by-face pyramid, and the Pappus
estimate only they used.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
The case expected two bodies for a combine join of an arm 0.01 mm clear of a
ring. A join's tool that meets no target goes into the target as a separate
lump and the tool body is consumed (doc eval Operation::Join; the engine test
join_meeting_nothing_keeps_the_first_body): one body, Ring, of two shells,
with the volumes' sum. The case's point, nothing fuses, is kept: shells 2 and
the summed volume.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
ladder/05/011 expected 8 faces (the stock's 6 and one per hole). With equal
radii the two walls cross along two ellipses that meet at the two points
where the walls are tangent (x = 25 and 35, y = 20, z = 10), so each wall is
left in two pieces that touch only at those points, with no edge between
them: separate faces, 10 in all. SMLib makes those 10 (volume exact); truck's
8 came with an invalid record. Derivation in the case's method.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
With no targets picked, an extrude's Join, Cut or Intersect changed every body
of the active component it met, shown or hidden: a hidden coincident copy was
joined in and disappeared. Where some bodies of the active component are
hidden, the shown ones become the feature's participants, kept with it, so
showing or hiding bodies later doesn't change the model. Explicit targets and
participants, and a face's or a face sketch's own body, still win.
Test: the issue's plate with a hidden copy and a rim joined on.
Main reached the same fix for Cut and Intersect in #3961 (its targets-based
shown_scope in extrude); this one, which also covers Join and keeps the shown
bodies as participants, replaces it. Its test stays.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
A closed path was always followed from the start of its first picked curve,
wherever the profile stood on it. A profile drawn at the middle of a line was
then carried round the path standing off it by the distance between the two
(walls offset, the rounds turned the wrong way, on both kernels). Now the
closed chain begins where the profile's plane crosses it nearest the profile,
the curve there split in two (or at the joint there); open paths and paths
that already start on the profile's plane are unchanged.
Test: a 4 x 3 profile at the middle of the bottom line of a rounded rectangle
swept round it: Pappus volume and the tube within 2 mm of the path.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
Replaying a Mirror or Pattern feature asked it for its tools, which only primitives
and sketch features have: 'Mirror1 cannot be patterned or mirrored yet' (#3652). A
copy of a pattern or mirror of features now replays that feature's own features with
its moves followed by these (a mirror of Mirror1 reflects the hole Mirror1 made),
nested at most 8 deep, never through itself, and to at most MAX_INSTANCES copies in all.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
Face capture estimated its work as every face times every triangle and refused a
body past 2M (#3914, a threaded block: 'face capture work limit exceeded'), though
only planar faces through the point scan the mesh. Each such scan is now counted
when made.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
solid.revolve and surface.revolve took any other axis string as a sketch line id,
so a construction axis by name failed with 'unknown sketch line' (#2516). A name
that is no line of the profile's sketch and names a construction axis is that
axis where it is now, as picking it in the view already passes it ({origin, dir}).
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
Three defects in restating trimmed surfaces (144/143) as STEP, kernel-agnostic:
- A boundary loop is one closed curve (IGES 5.3 composite curve: each piece ends
where the next starts), but each piece's ends were sewn into vertices by
distance alone, so pieces that miss by more than the sewing tolerance left the
loop open and the face was dropped (#3845). Surfaces are now read first and sewn
after: every meeting point of two pieces is one vertex (union of the two), the
STEP reader then carries the distance as the vertex's tolerance.
- With no parameter-space curve to give the start, a composite whose first piece is
written end to start kept that direction, so the second piece did not connect
(#3913). The first piece now runs from its end away from the second.
- All sewn surfaces were written as one shell, so two separate closed boxes came in
as one body of two shells that SMLib's check refuses (#3972). Each connected set
of faces is now its own shell and body (Body1, Body2, ...); a shell writes only
the vertices its edges use, in the sewer's order.
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
EvalSurface::wrap asked uv::closed whether a spline closes on itself every
time it evaluated a point outside the knot interval, and that test walks the
whole control net (its extent, then the first and last rows). A tessellation
of a closed spline unwraps its parameters across the seam, so about half its
evaluations are outside: on a coil's helical tube (thousands of control
points) the test was 80% of the tessellation's time, 30 s of the coil
command on SMLib (sweeps/3832, sweeps/793).
EvalSurface::Nurbs now carries `closed`, set by EvalSurface::nurbs from the
same test; wrap and uv::domain read it. An affine map of the surface keeps it
(closedness does not change under one). The answers are the same as before. The constructor's callers in
crates/kernel/src/tess (size.rs, surface.rs) change with it.
Not built: base in progress (rebased onto kernel-smlib/no-truck 41adb372).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
The tests in tess/ build their bodies as before and plan crate::brep_record of them; the
assertions stay. Changed where what they compared is gone:
- surface.rs: each face evaluates through eval_surface and its record-parameter map as the
record's own evaluator (SurfaceEval) evaluates it, point and natural normal over the face's
box (was: as truck evaluates it); the kinds counted are the record's (planes and analytic
surfaces; SMLib's primitives have no spline faces, which truck's sphere was).
- edges.rs: edges are the record's; the intersection-node test becomes: every edge between two
curved faces puts each node, through each face's pcurve at the node's curve parameter, on that
face's surface at the node, within the edge's tolerance (was: Newton's per-node parameters
within 1e-7, which tess/ssi.rs no longer computes).
- tests.rs: "reference mesher" comparisons are against Body::mesh (the same mesher on the same
record, at a finer tolerance for the cross-hole volume). Removed the assertion that
seam::turns_more_than_once finds the thread's winding walls: that test of which mesher to use
no longer exists.
(not built: base in progress) tess/ has no errors under cargo check --tests.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
Each edge node keeps its curve parameter; each face reads its nodes' parameters from its own
pcurve of the edge at that parameter, so nothing on the boundary is projected and a seam's two
uses (each with its pcurve) are its two sides: the cases the projection could not tell apart
("boundary winds around the surface", sides that cross where projection snapped them, poles).
The record's (u, v) go to the evaluator's in closed form (tess::surface::Params): the same for
planes, splines and revolutions; (θ, v) to (−v, θ) on a cylinder's or cone's generator; on a
sphere or torus (θ, φ) to (1 − s(φ), θ), s the rational meridian's parameter, from
tan(φ'/2) running linearly over each span (φ' from the span's middle).
A pcurve that does not cover its edge's interval, or places a node farther from the edge than
ten times the chord tolerance plus the edge's own tolerance, is an error naming the face and the
edge: the record is wrong there (for an analytic face, a trim left in SMLib's internal NURBS
parameters rather than the record's would show here).
(not built: base in progress) tess/ has no errors under cargo check.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
On kernel-smlib/no-truck: sweep_point_path_with goes straight to SMLib's sweep (no truck
branch), and PathSeg::flattened (truck's polyline of a path) takes no Cubic arm (the wildcard
keeps the segment).
(not built: base in progress)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
A drawn 3D spline reached the kernel only as its sampled polyline (Wire.pts), so SMLib refused
to sweep along it ("not supported yet: SMLib sweep along a smooth path of points"). The doc
holds the spline's fit points; the curve is the centripetal Catmull-Rom spline that
fit_polyline samples. Each span of it is a cubic (Barry-Goldman), and its derivative at a fit
point depends only on that point, its neighbours and the two knot intervals, so neighbouring
spans share it: the spline is exactly one cubic Bézier per span, C1 across the spans.
- geom: catmull_rom holds the curve: samples() (fit_polyline's arithmetic, moved verbatim;
sketch::fit_polyline now calls it) and beziers(), the exact spans; ArcLength on CurveN
(Gauss-Legendre per knot span, Newton for the parameter at a length).
- kernel: PathSeg::Cubic, a cubic Bézier in space (the 3D counterpart of PathSeg::Curve, which
is planar), with its arms wherever PathSeg is matched (start/end, tangents, length, point at
a length, turn, SMLib curve as a degree-3 NURBS, halving). PointPath / PathPiece carry a path
through 3D sketch curves: polylines as points, drawn splines as their fit points (reversed
when the path runs them backwards); PointPath::segs gives SMLib the spans and the lines;
sweep_point_path_with sweeps it (SMLib through sweep_with, so corners, twist, scale, rails and
orientation take the existing routes). A smooth polyline piece (a projected or linked curve,
which the kernel only has as points) is still refused on SMLib.
- doc: path_points builds the PointPath (a wire with three or more fit points is a spline
piece); solid sweep and pipe call sweep_point_path_with; rails, surface sweeps and curve
networks take its points as before.
Checked in scratch (not committed): the spans pass through every fit point and every
fit_polyline sample at its parameter (1e-12), C1 at the joints and round a closed spline;
samples() is bit-identical to the old fit_polyline over 1180 random open and closed inputs;
SMLib sweeps of a radius-2 circle along an open spline and round a closed one match
pi r^2 L (L by independent quadrature of the curve's definition) to 1e-7 and 3e-8.
sketch/wire.rs: the existing closed-spline test reads SPAN_SAMPLES from its new home.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
A Join with one target takes every tool, whichever it meets, but it grew the
target by one tool at a time: each union took the whole result so far, and
each step first meshed it to see whether the tool met it (which with one
target decides nothing). n tools cost n^2 in every per-body step of a
boolean (converting the operands, checking the result, exporting it back),
whichever kernel runs it: a combine of 64 separate pegs (booleans/3455) took
400 s on SMLib, of 36 lofted blades and a disk (crashes/2992, sweeps/1856)
485 s and 97 s.
With one target, the target and the tools are now unioned pairwise, level by
level, so each body takes part in about log2(n) unions. The result is the
same union under the target's name, with the lineage of every union. Several
targets keep the absorption order they need. The doc and engine join and
combine tests passed and failed on SMLib as before (measured before the
rebase).
Not built: base in progress (rebased onto kernel-smlib/no-truck 41adb372).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
uv::project, given no hint that converges within `accept`, evaluated a grid
of up to 16384 points of the whole surface for every point it placed, then
sorted all of them by distance. The grid is the same for every point of a
surface, and a face's pcurves place hundreds of points on one surface: on a
modelled thread's helical faces that grid was most of a boolean's time on
SMLib, in the operands' records, SMLib's export of each body and the
result's (threads/2526, the ladder's threads).
uv::Starts keeps the grid, filled on first use; uv::project_with takes it,
and a face's pcurve fit (pcurve::On) keeps one per face. The 32 nearest
starts are picked with a partial select instead of a full sort, in the same
order (nearest first, grid order where equally near), so every point gets
the parameters it got before. (The tessellation's boundary projection can
take the same grid; crates/kernel/src/tess is the mesh agent's.)
Not built: base in progress (rebased onto kernel-smlib/no-truck 41adb372).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
On a B-spline face the export now takes each edgeuse's UV trim exactly as
SMLib holds it (EDGEUSE_NURBS_*): the face's parameters are SMLib's, so the
trim is the pcurve, reversed exactly (knots t -> a + b - t) where the
edgeuse runs against its edge, its knots mapped onto the edge record's
parameter where that is an affine image of SMLib's (identity for spline
edges, as_line's map for NURBS lines, the C side's map for lines), and its
end knots set to the edge interval where they differ by rounding (within
the schema's 1e-9 slack, else an error). Changed: export.rs `curves`
(per-edge TrimMap), new `trims`, `mapped`, `Face::given`,
`Edge::trim_map`, the face loop in `native_ordered`, `pcurves`,
`outer_area`.
Analytic faces and circle/ellipse edges keep brep::pcurve: SMLib keeps an
analytic face's trims on its internal rational B-spline (SmCylinder.h:
"the map from one to the other is not linear") and a circle's on its NURBS
parameter, neither an exact B-spline in the record's angle parameters.
brep::pcurve::EdgeUse gains `given`, a producer's exact pcurve taken as it
is (structure and interval checked, moved by whole periods with its loop,
never refitted). Existing construction sites (STEP reader, tests, truck
adapter) pass `given: None`; the existing tests change only for the new
field.
Built, clippy-clean and tested on 4b2c0eaf before the rebase onto
kernel-smlib/no-truck (not built: base in progress).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
tess::plan takes a brep::Brep: faces, loops, shells' face sides and edges in the record's
order. Surfaces go to the evaluator's form from the record (planes, splines and revolutions
through SurfaceEval; a cylinder, cone, sphere or torus as the exact revolution of its line or
rational-arc generator about its axis). Edges are sampled on the record's own curve evaluator
(CurveEval), an intersection curve included, so tess/ssi.rs and the per-node parameters it
carried are gone; every boundary node's parameters come from projection.
No fallback is left in the planner's path: a curve that does not evaluate on its interval is
an error naming the edge (it was a two-point chord, or truck's evaluation); a surface the
evaluator cannot express an error naming the face and its kind. Errors name the face, its
surface kind and, for a node off the surface, the loop, node and point. The module doc states
the order: a cheaper layout where the face suits one, else constrained Delaunay in (u, v),
else an error.
MAX_ANGLE_BOUNDARY and MAX_RELAX are tess::size's own. Removed with truck: the winding test
and pole-to-pole seam test that chose between this planner and truck's mesher, and
boundaries_on_surfaces (truck blends). The tests in tess/ still build truck bodies and are
left for the record-based Body.
(not built: base in progress) tess/ has no errors under cargo check; the rest of the crate is
the no-truck branch's.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
Body::mesh / mesh_plan / mesh_of and MeshTolerance (chord, display, display_of, export_of)
replace tessellate, tessellate_with, display_mesh*, display_plan*, reference_display_mesh_angular;
every caller in kernel, doc, engine, io, ui-egui, gpu and the CLI renamed mechanically; the
truck-mesher fallback, mesh_shells*, refined* removed; Body::new orients from the planner;
truck-meshalgo dropped from Cargo.toml with the tests of its hooks. Still to fix: trait imports
in tess/*, splitface/lumps/preview/step_in/boolean_record meshalgo uses, measure.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
Over the fork's new smlib_brep_bounds (SmBrep::CalculateTightBoundingBox): the box of a body
from its exact curves and surfaces, for measuring without a mesh on the SMLib kernel.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
Through SMLib, in place of "not supported yet":
- A sweep along a path with corners: each smooth run swept on its own and
the runs joined at each corner in a mitre (each run swept on straight past
the corner and cut back to the plane halving it, where the next meets it
face to face), including the corner where a closed path closes; only
moving along the path, the runs meet on the profile. History: walls from
their segments (found half-way along each run), caps where the path ends.
- A free-form path curve (a spline's Bézier pieces, conics) reaches the
kernel as PathSeg::Curve, its exact piece, instead of the sketch's
polyline of lines: SMLib sweeps along the curve itself; truck's sweeps
flatten it as before (now the piece's own polyline within 0.01 mm, which
turns ladder 04/004 into a pass for truck too). Patterns along a path
flatten it and measure as before. A sweep that twists, scales or follows
rails places its stations by length along the curve.
(Such a controlled sweep still refuses a path with corners.)
- A loft through sections with holes: each section's outline and holes are
one SMLib profile, the holes matched as for truck.
- A loft to a point: SMLib's pyramid (smlib_loft_to_point).
- A draft extrusion with a straight foot: the foot's prism and the drafted
part (sloping from the foot's top to the far end the taper gives) joined
face to face; each segment names its foot and its sloping wall.
Cases now passing on SMLib: booleans/3633, sweeps/1184, 2435, 3111, 3006,
3505, 561, 96, ladder 04/003 and 004.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
The fork's new smlib_loft_to_point (a pyramid from a planar section of lines
to an apex) as Brep::loft_to_point. The pin brings the sweeps' other
changes: a loft's section may hold holes (loops lofted loop to loop), a
sweep along a straight path is an extrusion and one turning with arcs about
one axis a revolution (exact walls), and a sweep round a closed path closes
its walls on each other, without caps.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
The case's own method says one body with an inner shell (the void of
radius 18.5 inside the ball of radius 40), but without a "shells" entry
the rig asks one shell per body. It now asks two, as the method derives.
SMLib still fails the case on its volume: 294558 mm3, near the sum of
the two balls (294604) rather than their difference (241561), so the
inner shell is not taken as a void.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
Two SMLib fixes (tangency-labs/smlib r-shell-fillet):
- b0e84f4: faces an extended offset already mated are not intersected
again in the offset's merge (rig shell/3103, a two-half cone frustum
shelled open at the top, now one valid solid at the closed-form
volume).
- ffaf4e8: an intersection edge's end goes to its own vertex when its
ProtoVertex resolved into several (rig fillets/1488, the slab joined
with a nudged pleated loft, valid again; booleans/2801 passes too).
Every rig case that passed on SMLib at 2d7c7ed still passes.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
On SMLib a sweep with a twist, an end scale, an orientation direction
or guide rails, and a loft with guide rails, were refused. They now
place the profile at stations by the laws the kernel already defines
for them (sweep_path::controlled_stations / railed_stations, and the
loft_rails law: plain loft between the sections moved onto the rails),
each section the profile's exact image, and SMLib skins the walls
through them (Brep::sweep_stations, Brep::loft). The path is sampled
exactly on its lines and arcs, a station per degree of turn: SMLib's
skin interpolates with free ends, its error falling as the square of
the step (a quarter-twisted square is 2e-7 off in volume at 1.4
degrees, 2e-6 at 2.8). Round a closed path the last section has to
land on the first (closing_offset, as for truck) and the ends are
joined. A railed loft needs each section's curves to pair with the
others' (same kind), else "not supported yet".
A path of points (3D sketch curves) was refused outright on SMLib; a
line or a polyline with corners is now swept as its lines (the
corner refusal still applies), and only a smooth polyline of more
points (a drawn 3D spline) stays "not supported yet".
History in the builders' vocabulary: caps from the start and end
section planes, walls from the profile segments (round a closed path,
from points inside the walls at the middle station).
Kernel cases now passing on SMLib: sweeps/1269-sweep-twisted-square-
ninety-degrees, 2005-closed-sweep-twisted-cut-inside-a-torus,
2005-closed-sweep-twisted-new-body, 201-loft-one-guide-rail-cone-
frustum, 2862-three-pipes-meeting-at-one-point, 2891-twisted-sweep-
cut-through-a-tube, 771-sweep-end-scale-cone-frustum, 771-sweep-one-
and -two-guide-rail(s)-cone-frustum.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
The wrapper of the fork's new shim (61ee7f5): a planar profile placed
by an affine map at each station, the walls skinned through the
sections, the ends capped, open, or joined round a closed path
(Ends). Tests: a twisted square (V = A L), a scaled disc (frustum), a
square carried round a circle with its ends joined (Pappus), and
singular or too few stations refused.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
SMLIB_REV moves from 276b509 to capi-solidcraft 2d7c7ed: a fillet crash at an
unsupported corner (#453), rounds ending on a tangent seam (#418), radius laws
with a corner (#430) or that cannot be evaluated (#458), a round over a hole
(#422), a sphere's own patches kept apart (#423), offset surfaces extended the
same way whatever was evaluated first (#419), swept walls sharing their planes
(#434), the internal thread's last vertex gap (#410), shells across rounds
thinner than the wall (#397), nested shells imported in any order (#388) and
the tessellator held to its chord tolerance (#390).
Three tests follow: a radius law with a corner is now built, so the SMLib
tests check its volume (8000 - (1 - pi/4) 20 28/3) and that a law pinching to
zero inside the edge is refused; the split coil's halves now measure within
1e-5 of the closed form, so they are held to it rather than to the whole
coil's mesh, which is only within 3e-3.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
The kernel accepts `truck` (as well as unset) for its truck backend, and
`boolean_kernel()` reports that backend as `default`. The rig compared
the raw setting with that name, so a run with SOLIDCRAFT_KERNEL=truck
reported every case as "this build runs booleans on the default kernel,
not truck" instead of grading it. The rig now names unset, empty and
`truck` alike as `default`.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
A face's grid lines are thinned to MAX_FACE_GRID points (and now to at most that, where the
rounding of thin() could leave it a little over), but the cut grid adds the face's motorcycle
traces to them and then refused when its cells came out over the cap. The face fell through to
Delaunay, whose refinement budget a face of that size is far past: a split coil's wall at the
measuring tolerance got 90 000 triangles where it needs 320 000, and the halves of #793's coil
measured 1.5% short of the whole. The cut grid now thins its full lines (the same evenly spaced
choice as the face's grid, moved into grid.rs) until the cells fit.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
SMLib writes a modelled thread's groove walls as splines winding once per pitch, and splits the
bore or shaft into one face per turn, so no face of revolution has a loop turning more than once
and turns_more_than_once missed the body. Truck's mesher then took the winding walls: meshes
reaching 1.4 mm past the block (#1995, #2526, #3311, ladder 06/004), volumes of -1.8e7 and boxes
120 m wide (#2038 join, ladder 06/003), or spade's "!previous_region.is_empty()" assertion inside
its constrained triangulation (#3952, ladder 06/001, 06/002). A spline face now has an axis too:
the mean binormal of an iso-line that winds more than once about it, through the iso-line's
centre; a boundary loop turning more than once about that axis routes the body to the display
plan, as a helical trim on a cylinder already did.
Truck's own coils (sweep_helix's spline walls) go the same way; their walls are longer than a
grid's 1024 lines resolve at the measuring tolerance (three turns of a 20 mm coil need ~1200),
so a direction may now have 8192, the grid as a whole still capped at MAX_FACE_GRID.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
A thread's root band that runs out through an end face (a strip a quarter pitch wide winding
ten turns, ending obliquely, so it has no four corners to blend) fell through to the butterfly
of a round face. Its cuts ran lengthwise through the strip, seeded the whole way: ~200 000
points whose triangles zigzagged along the band, six times its area and up to 1.6x the chord
tolerance off the surface. A curved face whose division across one parameter has no inner line
(straight and within a side there) and with no room for a lattice seed now skips the patch and
cut-grid layouts and goes straight to Delaunay of its boundary nodes with sag refinement:
11 600 triangles for the whole part instead of 438 000, within the tolerance, the triangles'
area matching the surface's. A fillet narrower than a side but curved across keeps its layouts
(Delaunay from its boundary alone runs out of refinement budget at fine tolerances).
cdt::has_room tells "no seed fits" apart from "the lattice is too large to look through".
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
Each loop of a face is projected on its own, so along a closed direction a
hole can come out a whole period away from the outer loop. A revolved
dome (rational spline closed in v, bounded by its rim, its seam both ways
and the pole) has its outer loop opened at the pole into v in [-1, 0],
while a hole cut by a ball next to the seam projected into [0, 1]: the
triangulation covered the hole as well, and the cut measured 48118.36 mm³
instead of SMLib's 46424.50 (tangency-labs/solidcore#433, kernel case
sweeps/3528-revolved-dome-cut-by-a-ball-on-its-seam). Every other loop is
now moved by whole periods to the copy nearest the outer loop.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
On a thread's root band (1.4 mm tall at a pitch of 1.5) a point on the band's lower rim lies
0.1 mm from the rim of the turn below. The search's starts are dense across the band and
sparse along it, so its four nearest starts all lay on the turn below, Gauss-Newton settled
there, and the pcurve fit refused the edge ("the curve at 0 lies 0.1008 mm off the surface",
ladder/06-threads/007). The search now goes on through the nearest 32 starts until one
converges within the accepted distance, and stops at the first that does.
The test strips now put their knots at other angles on each turn (7.3 control points a
turn), as SMLib's screw sweeps do.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
SMLib's intersection curves carry knots of full multiplicity where the curve is in fact
differentiable (its derivative the same either side). The pcurve fit took every such knot
for a corner and fitted the two sides apart; on a thread's flank, whose u runs hundreds of
times as fast as its v, the pieces met at up to 1.4 deg in (u, v), and SMLib's check refused
the record read back (Test #7 Bad CurveKink, offset 0.9997 against cos 1 deg).
A knot that leaves a spline only continuous by its multiplicity now gets a cubic with a
tangent there when the spline's one-sided derivatives (EvalCurve::sides) agree within 1e-9
of their size. Knots where the curve does turn are corners as before.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
A thread cut by SMLib's screw sweep leaves flanks that are cubic splines of hundreds of knot
spans along the helix (an M6 through 20 mm: about twenty turns over u in [0, 1]). With no
hint (an edge's first sample), the projection started from a 17 x 17 grid over the parameter
box: one start every turn and a quarter, so the nearest starts lay on the turns beside the
point's own, Gauss-Newton settled there, and the pcurve fit gave up with "the curve at 0
lies 0.87 mm off the surface" (pitch x cos 30 deg, the next turn's flank). Every modelled
thread failed its export that way.
The search now starts, along each direction where the surface has its own knots (a
spline's, a revolution's profile's), from each knot span's start and two points inside it as
well as the 16 even steps, capped at 16384 points of the surface, so every turn is searched.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
Without the native feature nothing reads a sweep's curve list, and clippy -D warnings
refused its two fields as dead code. The list is built through List::new in both builds;
only the native build keeps the slices the C API reads.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
SMLIB_REV moves from e1ac3c3 to capi-solidcraft 276b509: thread groove
booleans (#435, #410), a holed profile swept along a bent path (#411), a
revolution a turn past its range (#428), shell and offset faces (#402, #380,
#403), the check linear in the body (#431), a far box that leaked (#377),
fillets and chamfers where a neighbouring round collapses (#416, #417, #420,
#379), tangent faces round a non-manifold edge (#383) and split faces of an
exact NURBS surface (#387).
The last one is why the SMLib block-and-cylinder decode test no longer finds a
spline edge on part of its curve: SMLib keeps a split face's parameterization
now. The test keeps its volume check; the decode of such edges stays covered
by spline_edges_on_part_of_their_curve_load_as_that_piece.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
An SMLib result where one shell uses an edge four or more times (a hole tangent to the outline,
touching holes, stepped cuts touching along a line) was refused as "not supported yet: a solid
touching itself along an edge". The export now reads SMLib's radial order round each edge
(EDGEUSE_NEXT_RADIAL, EDGEUSE_RADIAL_ENTRY) and the side of each face its material is on, and
gives each pair of faces across one sector its own copy of the edge: the pairs across material,
so the surface is cut apart round each wedge of material, unless one face would get two copies
(a face on both sides of the line), which SMLib's check refuses as coincident edges (tests 33,
34); then the pairs across the empty sectors, so that face keeps one edge on both sides, as
SMLib's crack edges do. The vertices at the ends stay shared: copies would give a face passing
the point twice two coincident vertices, which SMLib refuses too (test 32). Geometry unchanged;
each copy keeps its edge's tolerance and history (Order.pieces). The radial arrays are checked
as hostile input (in range, cycles on their own edge).
Tests: a hole tangent to a block's outline exports with the line copied once per wedge (each
copy joining faces on one side of it), every edge two uses, and goes back into SMLib valid at
the same volume; a blind hole tangent to a side leaves the side a crack; through SMLib both come
back as one solid with verified history and empty validity.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
After a parameter edit, a feature's stored face point is moved onto the
face its name finds. That used the face's nearest point to the old pick,
which lies on the face's boundary whenever the pick no longer lies on the
face: a shell opened at the end of a bar picked (150,15,10), on the edge
it shares with the bottom face, so truck opened the wrong face and SMLib
refused the pick (#2531).
FaceHit::pick_point keeps the point where it still lies on the face clear
of its edges, and otherwise takes the face's nearest point among points at
least a margin inside its triangles (a few pick tolerances, capped at half
the roomiest triangle's inradius on narrow faces).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
With SOLIDCRAFT_KERNEL=smlib, kernel::draft hands the picked faces (a point inside each,
from the face under each pick) to Brep::draft, with SMLib's own history: the tilted faces are
the faces themselves (Modified). Faces SMLib can't draft (a round wall, a face not parallel to
the pull) are "not supported yet", never truck. Tested in modify_history_tests: a 40 x 30 x 20
block's side at 5 degrees removes 20 x 20 tan 5 deg / 2 x 30, with its history checked against
the geometry.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Flat faces tilted by an angle about the line where each meets a neutral plane, leaning in along
the pull, and the faces around them extended or trimmed to meet them
(tangency-labs/smlib@e1ac3c3, SMLib's local operation). A face that isn't flat or isn't parallel
to the pull is Error::Unsupported. The test drafts a cube side by +-5 degrees, removing or adding
the analytic wedge to 1e-6.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
cargo xtask kernel-cases --kernel both, solidcraft-cli built with smlib
at c65fc91a (fork bf7c272), SMLib through SOLIDCRAFT_KERNEL=smlib. 372
cases: default 235 pass, smlib 269. SMLib's gains are booleans (50 to
66), fillets (32 to 41), shell (5 to 11) and STEP import (13 to 17, its
solids now SMLib bodies); its losses are sweeps (54 to 51 pass, 15 not
supported yet on SMLib) and threads (17 fail, of which the default kernel
hangs on 4).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A face on a B-spline surface whose first and last control columns are the
same (closed around u), bounded by loops that go once around without a seam
edge, was refused ("a loop across a closed spline surface's seam"). It now
gets a seam as cylinders and cones do, along the surface's own boundary
column (u at the start of its knots, an exact iso-curve of the net), each
loop split where it crosses that column when it has no vertex on it; the
period is the knots' width. At a pole a loop may jump across u, where the
seam's two uses meet a period apart.
The step-conformance NURBS cylinder, dome and torus ring now read. With
SOLIDCRAFT_KERNEL=smlib all 17 parts import into SMLib with their exact
volumes and face counts. A spline closed in v only, or both ways, is still
refused.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A gap the boolean fixed on one side only left the freed edge in its common-edge map, and the next
pass read it: a square-wire coil cut into the wall of a bore crashed the process on SMLib
(sweeps/2552). It now fails with an error.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SMLib leaves a corner patch where blends meet untagged, and blends() matches no single edge to
it, so it had no origin, and the edges between two blend faces (two chamfers' mitre) none
either. The history checks refused both (modify_history_tests' corner, whole-box and mitre
cases on SMLib). Now a patch without origin is made in place of all the edges of the blend
faces beside it, as truck records a corner, and every edge of a face new to the blend is where
its two faces meet.
modify_history_tests with SOLIDCRAFT_KERNEL=smlib: the three blend cases pass (28 of 30; the
painted shell and the painted box cut's pieces are the shell's and boolean's). Truck: 30 of 30.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
With SOLIDCRAFT_KERNEL=smlib, chamfer_sides (two distances, or a distance and an angle) runs
SMLib's new unequal chamfer instead of being refused: `d1` back along the face facing up most
(down most with `flip`, as truck's chamfer_sides picks its first face), the other side by the
distance or angle, with the body's history as for the other blends. A radius law SMLib refuses
as having a corner is "not supported yet", never truck's round.
Tests (with the feature): 5 and 2 on a cube edge either way round (the top face keeps 15 or 18
of its 20, the chamfer face comes from the edge), 5 at 45 degrees, and the corner law refused.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Brep::chamfer_sides reaches the fork's smlib_chamfer_sides: `distance` back along the face
whose outward normal leans most along a given direction, the other side by a second distance
(ChamferSecond::Distance) or at an angle to the first face (ChamferSecond::Angle). The fork's
smlib_fillet_variable refuses a radius law with a corner with SMLIB_ERR_UNSUPPORTED, which the
crate reads as Error::Unsupported ("not supported yet"): SMLib's section fit ran smoothly
across the corner and missed the law (4 -> 2 -> 4 on a 20 mm edge took 35.1 mm3 for 40.1;
tangency-labs/solidcore#430). Both are in the fork at the pinned bf7c272.
Tests (ops_tests.rs), against analytic values: 5 and 2 either way round (the centroid tells
which face took the 5), 5 at 30 degrees, rejected arguments; a quadratic law 4, 1, 4 and a law
down to zero (1e-5), the corner law refused and the same points joined C1 built.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
With SOLIDCRAFT_KERNEL=smlib, kernel::measure and measure_mass take volume, area and centroid
from SMLib's Brep::mass_properties (integrated on the exact surfaces, accuracy 1e-8). The mesh
measure is still made, as an independent check. Where SMLib disagrees with it beyond the mesh's
own accuracy (1e-3; tangency-labs/solidcore#384), or can't take the body, the mesh measure
stands and the measurement says why. BodyMeasure and MassMeasure carry `measured_by` (smlib |
mesh) and `notes`, and inspect.measure shows both. The box and topology counts stay the mesh's.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SMLib's tolerance update now fixes the vertex gaps its check reports (gaps over half a vertex's
tolerance), and every boolean, blend, shell, offset and sweep result grows its vertex and edge
tolerances over gaps below SMLib's own rounding bound before it is handed out. A thread's groove
cut from a shaft no longer fails SMLib's check on vertex gaps of about 1e-5 mm, and an offset
sphere face no longer fails it on an edge gap of 5.015e-6 against 5e-6 (shell/2939).
Also carries the fork's blend commits since ca2559f (second offset per edge, two-setback
chamfers, variable radius laws with a corner refused) and the IGES knot check.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Where two edge uses of a loop meet at a pole (meridians of a sphere), the periodic parameter's
jump there is free, and the pcurves took whichever jump made the loop counter-clockwise. Two
meridians a three-quarter turn apart bound a quarter of the sphere or three quarters of it, and
the loop alone can't tell which: a half disc revolved 270 degrees on SMLib came back as a quarter
ball turned inside out (sweeps/2667, V = -226 against 678.6).
pcurve::pcurves_within takes the face's parameter box, as SMLib gives it, and picks the jumps
whose extent in that parameter is nearest the box's; pcurves is unchanged.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Each solid item of a STEP file goes through the schema 4 reader
(solidcraft_step::topology, at the file's units and uncertainty) into
SMLib through the flat converter, healed where SMLib's check refuses it,
and comes back as a kernel body; its faces keep the file faces they came
from. A solid the reader or SMLib refuses is not imported, with the
reason: there is no truck fallback on this path. truck's own reader is
unchanged and stays the default.
Test: the 17 step-conformance parts read into SMLib with their exact
volumes and face counts, every face traced to an ADVANCED_FACE; the three
NURBS parts stay refused by the reader (a loop across a closed spline
surface's seam), as on schema 4 today.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
smlib_record_ordered is smlib_body_ordered for a record of any origin (a
STEP file's, not only a body's): SMLib's body of it, healed where SMLib's
check refuses it as given, with where each of SMLib's faces and edges is in
the record's order. A record SMLib refuses outright now goes through the
healer too before the import gives up.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Schema 4 lets a circle or ellipse edge run up to one turn past its seam
(a quarter arc after the seam is [2π, 2.5π]); SMLib's circles take angles
within [-2π, 2π], and the flat import refused the whole body as invalid
input. The mapping now gives SMLib the same arc a whole turn back, and moves
the edge's pcurves on B-spline faces by the same amount, since their
parameter is the edge's. step-conformance's plate_100_holes now imports.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Solid::face_origin lists the ADVANCED_FACE or FACE_SURFACE entity of each
of the record's faces, in the record's face order, so a body made from the
record (in another kernel) can trace its faces to the file, as the truck
import's face_origin does.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Imprint cuts each face of a body where a tool body meets it (the fork's
smlib_imprint, SMLib's imprinting boolean) and gives None where the tool
crosses no face. Trim builds on it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
169 rig and ladder cases on both kernels, graded against each case's own answer: where SMLib
fails, grouped by what goes wrong (wrong geometry, a crash, the thread groove's boolean failing
SMLib's check, shell refusals, sweeps with no SMLib path yet).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SolidCraft's own record of a body SMLib made (the rig's record check, the saved body, the next
SMLib import) re-fitted every pcurve at the kernel's working tolerance, 1e-5 mm. SMLib's fillet
and chamfer surfaces lie some 2e-5 to 2e-4 mm off their faces, so 15 fillet and chamfer cases
failed that check although SMLib's own passed. And SMLib reported one tolerance for a whole body,
the largest any part of it needed, so one loose edge (a pocket cut left one at 0.23 mm) made the
whole body loose on its way back into SMLib.
Now the tolerances go per edge and per vertex, both ways:
- solidcraft-smlib reads and writes the fork's new SMLIB_FLAT_EDGE_TOLERANCE and
VERTEX_TOLERANCE arrays. Export gives each edge and vertex record its own (never below the
floor, which becomes the body's). Where those understate what an approximated edge needs on
its face (SMLib holds a blend's end curve 2.3e-5 mm off its plane at 2e-5), the export falls
back to SMLib's largest everywhere, as before. Import writes each record edge's and vertex's
tolerance.
- `geom::brep::pcurve::EdgeUse` carries its edge record's tolerance, and a pcurve is fitted to
it where it is larger than the face's.
- The kernel's decoded body keeps its record's edge and vertex tolerances
(`Body::tolerances`, in its edge and vertex order) after an SMLib operation and a saved body's
decode, and keeps them through a rigid placement. Its record writes them again; anything that
builds a new solid drops them.
SMLIB_REV moves to the fork commit that adds the arrays (smlib-blends-abi2 4a67471, ABI 2).
Rig and ladder fillet and chamfer cases on SMLib: 43 pass before, 60 now, none lost. Tests: a
pcurve fitted to its use's own tolerance, and the ladder's 08/006 cylinder rim chamfer whose
record, saved body and placed copy all stay valid and SMLib's check takes back.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
A pick at the vertex where a cylinder's seam meets its rim lies on both edges. The body's
nearest-edge order took the seam on SMLib-made bodies, and SMLib refused to chamfer it
(the ladder's part chamfer, step 22, SM_ERR_INVALID_INPUT). A seam or a tangent join is never a
blend's edge, so a pick as near to one as to a sharp edge takes the sharp edge; anywhere else the
nearest edge stands.
Test: every pick round a cylinder's top rim, the seam's end among them, takes the rim.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
Every blend entry point asks `backend()` and, on SMLib, hands its arguments to blend_smlib.rs:
fillet, fillet_each and fillet_radii (a radius per edge), fillet_g2 (SMLib's G2 blend-curve
section between the round's contacts), fillet_chord (constant-width section), chamfer, and
fillet_variable_spline (the radius law as an SMLib B-spline law; fillet_variable and
fillet_variable_points reach it, and fillet_max, fillet_max_each and fillet_tapered run on these).
Options SMLib has no construction for are refused as "not supported yet", never built by truck:
G2 corner patches, and chamfers with two different setbacks (distance and distance, or distance
and angle; equal setbacks are the equal-distance chamfer).
Each pick takes the body's nearest edge in its own edge order, as truck's blends do, and SMLib is
given that edge's midpoint, so a pick at a vertex never leaves SMLib to choose between edges. The
body goes in tagged as operand 0, SMLib's check must pass, and the decoded result carries SMLib's
history in the body's orders, the blend faces given FaceOrigin::Edge of the edge each replaced
(the picked edges and the rest of their tangent chains). The truck path is unchanged.
Tests (with the feature): a round's volume and its face's origin, a size per edge for rounds and
chamfers, a linear law from either end, refused sizes and picks.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
The Rust side of the fork's smlib_blend and smlib_fillet_variable, which the kernel's fillets and
chamfers need on SMLib: `Brep::blend` takes a size per picked edge and a `Blend` (circular round,
curvature-continuous round between the round's contacts, constant-chord round, equal-distance
chamfer); `Brep::fillet_variable` rounds one edge with a clamped B-spline radius law from the end
nearest a start point. Selection errors map as for the other picking operations.
SMLIB_REV moves to the fork commit that adds them (smlib-blends, on capi-solidcraft ffcf56d).
Tests: per-edge rounds and chamfers and the chord round against analytic volumes, the linear law
from either end, and refused laws and picks.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
The fork's booleans now hand out closed non-manifold results (SMLIB_REV e87e9b3, ABI 3): solids
touching each other along an edge or at a vertex, which the C API refused as "not a closed
solid". The SMLib → schema 4 mapping now gives each closed boundary its own record shell: the
faces sharing one runtime shell on the empty side and one on the material side, so solids that
share their empty side's runtime shell get a shell each. An edge or vertex faces of more than
one shell use is split into one copy per shell (same curve, interval and point), so every
shell is a closed manifold boundary; regions list each shell as before. The history follows: an
Order's `pieces` give each record edge of a split SMLib edge with the faces it bounds, and each
piece keeps the edge's origins.
SMLib's own check refuses the radial order of faces round an edge solids share, so a
non-manifold result is checked as the separate solids it becomes (imported as given). A solid
touching itself along an edge (one shell using an edge more than twice) is still refused, now
as "not supported yet: a solid touching itself along an edge".
Tests: cubes sharing an edge or a vertex unite into two shells of 1000 mm³ each, every face and
edge's history verified against the geometry; two opposite quarters cut off a slab leave two
solids. Of the pinch tests run through SMLib, cut_leaving_pieces_meeting_along_a_line now
passes; the other nine are solids touching themselves.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
The kernel runs exact helical sweeps and never resizes; the check that
refuses a thread off its hole's or shaft's size is the engine's sugar
(AGENTS.md). So the seven cases (995, 1443, 2152, 2969, 3366, 2369,
2705) go back to expecting that refusal and its message, as 1375e905 had
them, reversing 1588dd70.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
On SOLIDCRAFT_KERNEL=smlib the thread's groove (the ISO 68-1 trapezoid, as before) is a B-rep
screw sweep (kernel::sweep_helix, SMLib's screw sweep) cut from the body by the B-rep boolean,
whose history carries the threaded face's names on. Truck keeps the faceted groove and the
faceted boolean. thread_groove_shape holds what both build from; the size checks before it
(a hole or shaft off the thread's size is refused with the size to use) are unchanged, so
neither kernel fits a thread to a face that is too large or too small.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
With SOLIDCRAFT_KERNEL=smlib, extrude (and extrude_whole_sides, so boxes and cylinders too),
revolve and revolve_whole, extrude_tapered(_between), sweep and sweep_with, loft,
loft_with_rails, loft_regions and sweep_helix (coils, and the threads' grooves) build their
bodies with the fork's sweeps (smlib_sweeps.rs): the profile's segments go to SMLib as curves
(lines, arcs, Béziers and conics as NURBS), the result comes back through its schema 4 record,
and one SMLib's own check refuses is an error. What SMLib has no sweep for answers "not
supported yet", never truck's sweep: twists, end scales, guide rails and orientation
directions; paths with corners and paths of points; lofts with holes or to a point; draft
extrusions of profiles with holes or with a straight foot.
History is in the builders' vocabulary, found from the result's geometry as provenance.rs does
for operations without exact history: a wall comes from the segments its start edge runs along
(and, for extrusions and revolutions, whose middles it holds half-way), the face in the start
plane where the profile bounds it is the start cap, the one at the end the end cap. Straight
extrusions also carry their faces' construction sources (ExtrudeCap, ExtrudeSide), which the
box and cylinder certificates need. The loft's section matching is truck's own, now
loft_numbered_loops (split out of loft_numbered_wires, unchanged), so both kernels pair the
same vertices.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
Brep::extrude (straight or drafted), Brep::revolve, Brep::sweep (turning with the path or only
moving along it), Brep::loft and Brep::screw_sweep wrap the fork's new smlib_sweeps.cpp shims.
Profiles, paths and sections are lists of sweeps::Curve (lines, circular arcs, NURBS), turned
into the C API's curve lists here; the FFI is ffi/sweeps.rs. SMLIB_REV moves to the fork head
that has the shims (c33df0f, on capi-solidcraft 1499681).
Tests check each sweep against closed-form volumes and SMLib's check, and hostile curve lists.
(The crate's test build currently stops at import/tests.rs, which calls import::surface without
its new analytic_planes argument; that is the import's, not this change's.)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
The SMLib shell passed the user's pick points to SMLib, which refuses a point as near to two
faces; a pick on a hole's wall at the line between its two halves (kernel-cases shell/4010)
failed. The open faces are now picked as truck's shell picks them (the face of the nearest
triangle), grown by the faces on the same surface joined to them (offset::with_same_surface:
a round wall stored in pieces opens whole), and SMLib gets one point inside each.
Offset faces keeps its design on both kernels: when moving the faces fails on a body with
split lines, the chosen pieces are pressed (swept and joined or cut) instead, as truck's path
always did; the booleans of the press run on the selected kernel.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
smlib_body_ordered keeps SMLib's face and edge order for history only where SMLib's export
numbers the body as its record does, and compared each loop edge for edge in the same order
and direction. SMLib walks a face whose surface it turned (a hole's wall, a concave cylinder)
the other way round and may start the loop elsewhere, so a plate with a hole lost its history
through every SMLib boolean and shell although its faces and edges are numbered alike. A loop
now matches when it walks the same edges in the same cyclic order, or in the opposite order
with every edge reversed.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
With SOLIDCRAFT_KERNEL=smlib (the one kernel switch), shell, offset_faces and thicken send
the body to SMLib tagged as operand 0 (offset_backend.rs) and bring the result back with
SMLib's own history, as booleans do. A result SMLib's check refuses is an error.
SMLib's tags travel through the copies its offset makes, so a shell's inner wall and a
thickened sheet's moved copy read as pieces (Split) of the face they came from. A result face
lying more than half the operation's distance from its tagged face is recorded as that face's
offset (FaceOrigin::Offset) and its edges as where its faces meet; a thickened sheet's walls,
new to SMLib, are recorded as made in place of the sheet edge their edges are tagged with, as
truck's thicken records them. Offset faces pick the faces truck's path picks (a round wall's
pieces together) and pass SMLib one point inside each; the moved faces are Modified.
The histories are checked against the geometry as truck's are (modify_history_tests), with
the analytic volumes, the thicken direction, and the refusal of walls past the L-shaped body's
inradius (8.79) that its box (half extent 10) let through before.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
Brep::offset_faces and Brep::thicken reach the fork's new smlib_offset_faces and
smlib_thicken; SMLIB_REV moves to the fork commit that adds them. The shim now refuses an
inward wall that leaves no room inside the body with its own status, Error::NoRoom, instead of
an argument error, so callers can say what is wrong; the test that a wall thicker than the box
fails now expects exactly that.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
The analytic mapping refused every revolution that is none of SMLib's plane, cylinder, cone,
sphere or torus (a profile of any other curve, a placement that is no rigid motion), which
now also kept those faces from kernel-smlib's exact rational B-spline import (da7ccba9). Such a
face now stays a revolution, so the import sends it as its B-spline; the analytic surfaces are
still taken wherever they fit.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
All operations move to SMLib at once, so the selector is no longer the booleans' own:
`SOLIDCRAFT_KERNEL=smlib|truck` (read once, unset is truck, the same refusals for an unknown
value or SMLib in a build without it) is answered by `solidcraft_kernel::backend()`
(crates/kernel/src/backend.rs), which every operation's dispatch calls. The boolean's SMLib path
moves to smlib_boolean.rs. The regression rig's kernel check (`boolean_kernel`) now answers from
the switch, and the rig and CLI set SOLIDCRAFT_KERNEL.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
The record of a truck body is built to the body's working tolerance (1e-6 of its size, at
least 1e-5 mm), and truck's offsets and blends leave some edges a few times farther than that
from a face they bound: no pcurve fits, so the record and every SMLib boolean on the body
failed ("pcurve of loop 0 use 0 ...: the curve at 0 lies 3.2e-5 mm off the surface" in a
shelled revolve of the robustness generator). The record for SMLib now retries at ten and a
hundred times the working tolerance for the body, its edges and vertices before refusing; the
saved native body keeps the working tolerance. Robustness seed 64 (a filleted extrusion
joined to a cylinder), refused this way before, now builds as truck does to 1.6e-6 of its
volume.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
An SMLib cylinder, cone, sphere or torus decoded as a truck revolution with its parameters
swapped (angle, profile), which truck's own revolutions never have. The tessellator then put a
cone's apex at the wrong angle: a drill point through SMLib and back meshed 41 % too large and
oracle cases 18, 55 and 56 measured wrong areas and volumes. The profile now runs against the
record's v, unswapped, which keeps the record's natural normal and truck's (profile, angle).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
Truck's bodies are trusted into SMLib as given, but some miss SMLib's rules by a little (an
edge's vertex 4.4e-5 mm off it against a tolerance of 3.3e-5 after a truck operation), and
every boolean on them was refused by the check of its result. An operand whose trusted import
fails SMLib's check is imported again through SMLib's healer, and the healed body is used only
where SMLib then finds it valid; its numbering is checked against the record as before, so a
heal that renumbers leaves the result without history rather than with a wrong one.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
A revolve's flat ends (a line square to the axis turned about it) were refused, so any
revolved profile off the axis could not reach SMLib (oracle case 29). Such a face now goes as
SMLib's plane square to the axis, its range the box round the sector the line sweeps.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
kernel-smlib already gives solidcraft-engine and solidcraft-cli an `smlib` feature (for the
regression rig); the note on SOLIDCRAFT_BOOLEANS now says they are how the oracle, the naming
corpus and the robustness goldens run their booleans through SMLib.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
The export takes a closed boundary's faces from the side in the empty region and skipped
every use there that is not `same`, a rule meant only for a sheet (a shell that is its own
mate). It tested the chosen side against the mate instead of the shell against itself, so a
cavity's shell, taken from the void's side, lost its faces whose uses run opposite to their
surfaces: "a face no shell uses" for every cut that leaves a void.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
Truck extrudes a circle into rational splines, so every truck cylinder reached SMLib as
splines, and a box cut by one came back with edges 0.78 mm off their faces (SMLib's own check
refused it). A rational spline that is a circular arc swept straight along its axis (one
direction linear, the second row the first moved by one vector square to the arc's circle,
weights alike) now goes as SMLib's cylinder with the face's range on it.
The revolution mapping becomes one module for both (import/analytic.rs): each candidate face's
analytic surface is checked against the record's at 25 points of its domain, each point placed
on the analytic surface by its own (u, v), and turned over where the normals disagree.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
Truck's planes run through three points, their axes the face's sides, so the SMLib import sent
every truck planar face as a bilinear NURBS patch: SMLib then intersected splines where it has
planes. A plane on any axes now goes as SMLib's plane on unit axes along U and at right angles
in the plane, its range the record's domain on those axes (a face's range need not be tight;
SMLib rebuilds an analytic face's trims from its edges).
A revolution's analytic frame turns to the face's first angle so u starts at 0: SMLib's check
refuses a cylinder whose range ends past 360°. A failed SMLib check of a boolean's result now
says whether an operand already fails it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
Truck holds every round surface as a placed revolution, and a body SMLib made comes back from
truck that way too, so the SMLib import refused spheres, tori and any second boolean on a
first one's result. The import now turns each revolution of a line along or through the axis,
or of a circle centred on it or in a plane through it, under a rigid placement, into SMLib's
analytic surface: the face's range mapped from the revolution's parameters (angles moved into
the first turn: SMLib's torus breaks on a tube range below zero), checked against the
revolution at 25 points, and the face turned over (loops reversed, shell uses flipped) where
the analytic normal runs the other way. Other revolutions are still refused.
A result body's order is checked by each face's boundary edges as well as its identity:
Body::new rephases revolved faces onto new faces with the same edges.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
With the `smlib` feature, SOLIDCRAFT_BOOLEANS=smlib (read once per process, default truck)
sends every kernel::boolean through SMLib: each operand's schema 4 record imported and tagged
as operand 0 or 1, SmBrep's boolean, SMLib's check at every level, the result exported and
decoded (with its geometry check). A result either check refuses is an error. The setting
naming SMLib in a build without it, or anything unknown, fails every boolean instead of
quietly running truck, so a comparison never compares truck with itself.
The history is SMLib's tags renumbered into Body::history's index spaces. The export now
reports where each SMLib face and edge lands in canonical order (its arrays follow
SmBrep::GetFaces/GetEdges, the order the tags use). The result's order is checked against the
decoded solid by face and edge identity, the operands' by re-exporting the imported body and
comparing its numbering with the record's; where either differs the result has no history
rather than a wrong one. The result gets the operands' regularization protection and planar
roles as truck's does.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
The owner's rule for the kernel-smlib branch: the kernel runs exact
operations and refuses what it cannot do exactly; sizes, standards tables,
defaults, pre-checks and conveniences live in the engine and doc. Threads
as the example: a helical sweep in the kernel, while the size table, the
off-size refusal and multi-start threads are sugar.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
Only the Delaunay layout checked its triangles against the surface. The
grid divides each parameter direction within the tolerance, but on a
doubly curved surface the two sags add up in a cell's middle, along its
diagonal (SMLib torus 1.16x at 0.01, truck sphere 1.23x at 0.1, truck torus
1.40x at 0.01); the patches round a pocket cut into a sphere at its pole
fan out from the cut with no check at all (4.34x at 0.1, 1.90x at 0.01).
Every curved face's finished triangulation now goes through tess::sag:
each triangle is measured at its centroid and at the middle of each side
inside the face, across the surface (along the normal at the point of the
same parameters, which near a pole need not be the nearest), and the side
that leaves the surface most is split, both triangles on it together, so
the face stays conforming. Boundary sides are never split: they carry the
edges' own nodes, shared with the neighbouring face. At a pole the free
parameter of a midpoint comes from the other corners.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
A sphere from SMLib cut through its centre keeps one face bounded by its
rim and by its seam from the pole up to the rim, used both ways. Unwrapped
along the loop, both runs of the seam landed on one parameter line and the
loop came out one period short, so the planner took it for a face winding
round the sphere and cut it along a new line of its own. The two seam runs
stayed inside that strip as a slit of zero width, triangulated on each side
separately: open edges along the seam up to the rim (gaps up to 9.5e-3 mm
at chord 0.1), a zero-angle triangle and a non-manifold edge at the pole.
Such a loop is now unwrapped from the node after the pole round to it and
started at the node before it: the seam's uses lie a period apart on either
side of the face's parameter box, which then meshes like any sphere patch,
both uses on the seam's own nodes. It is kept as it was unless the opened
loop spans at most a period with a positive area and no longer winds.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
Eight are hand-written synthetic files (MIT OR Apache-2.0). The other eight are byte copies of
CC0 files from tests/step-conformance and say so. Each row names the issue its case comes from.
cargo xtask assets passes again.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SMLIB_REV moves to tangency-labs/smlib capi-solidcraft 1499681, eight SMLib
commits for surface/surface intersection: an empty curve is no longer
reverse-traced (SM_ERR_NULL_POINTER), tangent curves are traced once, curves
split at singular crossings, interior tangential contact points, tangential
curves and branches through tangent nodes, small loops above tolerance, and
high-order contact curves covered across their band. The corpus test's pass
list grows from 81 to 111 cases; the 8 still failing are all below SMLib's
1e-5 zone tolerance (angles 1e-6..1e-8, offsets 1e-7, loops of 2e-6 or less).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
With the native feature, smlib_global_intersect_at_1e_6 builds both
surfaces of every case through solidcraft_smlib::ssi, intersects them
at approximation tolerance 1e-6 with the corpus runner's 4001 samples
per curve, turns the answer into what the runner writes for gsi, and
scores it. It asserts the exact set of passing cases (81, as score.py
grades the runner: 81 PASS, 25 INCOMPLETE, 11 WRONG TOPOLOGY, 2 ERROR),
so a regression and an improvement both fail until the list changes.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ffi/ssi.rs declares the C API's SSI block; ssi.rs wraps it: Surface
(plane, cylinder, cone, sphere, torus, NURBS, with the SSI corpus's
fields, angles in degrees), Method (Global, Advanced, Basic) and
intersect(), which returns every curve's type, UV flags, deviation,
interval and samples (xyz, uv on each surface, each surface at its uv)
and the isolated points. Without the native feature every call returns
NotBuilt.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ssi_score::score_case grades an engine result (sampled curves with xyz,
uv1, uv2, both surfaces at the UV samples and the curve type; points;
status; or a crash) against a corpus case: CRASH, ERROR, INCOMPLETE,
WRONG TOPOLOGY, INACCURATE or PASS, with score.py's flags and numbers.
ssi_corpus.rs checks every case parses, every NURBS surface lies on its
truth, the truth itself passes (bar unsplit singular points), and the
verdict rules. The ignored parity test scores the corpus runner's raw
outputs and compares with score.py: 119/119 identical verdicts and
flags for SMLib GlobalSurfaceIntersect at 1e-6 (81 PASS).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Test-support port of the parts of the SSI corpus's ssi_geom.py and
score.py the scorer needs: exact distances to the implicit truths, the
Gauss-Newton closest point on traced param patches, B-spline/NURBS
evaluation of the case surfaces, and score.py's segment-hash polyline
set, polyline distance, components, free ends and topology signature,
following numpy's arithmetic order.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The 119 surface/surface intersection cases of jyviko/ssi-corpus (b04c8a6,
MIT OR Apache-2.0), gzip-compressed, with its licence texts and a README
on the case format and the scoring rules. The 25 y23 cases come from
Yang, Jia & Yan 2023 (ACM TOG 42(6) Art. 211, CC-BY 4.0); both are in
ATTRIBUTION.md.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A PlacedRevolution record goes to SMLib as its exact rational B-spline
surface: each profile control point swept round the axis by a full circle of
four rational quadratic quarters starting at the face's first angle, then
mapped by the placement. The circle's parameter is not the angle, so the
face's angle range is converted pointwise and its pcurves are not carried
(SMLib rebuilds the trims). Where the placement mirrors, the record's natural
normal is the opposite of the map's, so the directions swap.
The B-spline matches the record's surface to 1e-12 with the same normal,
forward or not, mirrored or not; truck's sphere and torus now reach SMLib
with their analytic volume (1e-6) as manifold solids.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
784, 1753 and the two 1666 lofts came from holes in exported meshes, so
each now also requires a mesh with no open or over-shared edge. On today's
kernel 784 and both lofts are watertight; 1753's bowl, its rim cut by a
cylinder, still has 3 open mesh edges.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Two faults made simple curved solids look open (#818's blind hole: 80 open edges, a stadium
slot: 52):
- It meshed with `refine`, the measuring mesh, which splits triangles across curved faces on
their own and leaves T-junctions on the edges they share with neighbours. It now checks the
display mesh, whose faces share each edge's points.
- It matched vertices by rounding to a 1e-6 mm grid, which splits points a rounding error apart
across a cell boundary. It now joins vertices closer than `tolerance.weld_mm` (default 1e-4 mm).
Both cases now have 0 open edges, also with the weld at 1e-6 mm.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2822, 3952 and 4149 cut long modelled threads into filleted or revolved
bodies; each takes minutes on today's kernel, so they get timeout_s 600
instead of the default 180.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
For the history areas' cases (threads, tessellation):
- A count may be an inclusive range `[min, max]`, where the geometry only bounds it (a modelled
thread's faces).
- `"watertight": true` meshes each body (chord tolerance `tolerance.mesh_mm`, default 0.01 mm)
and requires no open and no over-shared edges, with vertices matched by position.
- `"timeout_s"` gives a case longer than the run's timeout, at most 30 min.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
372 cases. The default kernel passes 232. smlib reports "not supported yet" for every case
until the SMLib boolean switch lands.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- tests/kernel-cases/sources.json gives each looked-at number's kind: an open or closed issue, a
merged PR, one of the frozen truck-geometry PRs, a kernel-paused PR. The report's coverage by
source counts how many of each were looked at, became cases or were skipped.
- crashes/2357: one join of a ring of 90 overlapping cylinder segments. The right answer is one
closed ring body. The old kernel still panics in its intersection curves and runs past the
timeout.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2969's description named another product's behaviour; 1443's and 2152's
still described the refusal. Each now says the hole is drawn at the
thread's nominal size and gets the fitted thread.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Reverts 1375e905. A modelled thread fits by default: a hole too wide for it
is filled to the tap drill, a shaft too thick is turned down to the major
diameter, so the seven cases (995, 1443, 2152, 2969, 3366, 2369, 2705) go
back to expecting the fitted thread and its volume.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A modelled thread never changes the size of the hole or shaft it is on
(#1018, #2853): one that isn't the thread's size is refused, naming the
size to use. The seven cases that expected the hole filled to the tap
drill or the shaft turned down to the major diameter (995, 1443, 2152,
2969, 3366, 2369, 2705) now expect that refusal, with its numbers worked
out from ISO 68-1 and the message in `refusal`. An opt-in fit option, if
it comes, gets cases of its own.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Runs are compared with the golden's times, so a run sharing the machine between cases flags
slowdowns that are only contention (seen with --jobs 4: four cases two to ten times slower).
--jobs still overrides it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
Tiers: primitives; booleans in the degeneracy classes (coincident and coplanar faces, edge-on-edge,
vertex-on-face, tangent along a line and a circle, near-tangent gaps and overlaps of 1e-3 and
1e-6 mm, seam and pole crossings) and cuts that end in a single line (a knife-edge wedge, a V
groove and a cylinder that pinch the part in two, a hole tangent to a face, a notch flush with an
end); line-and-arc extrudes and revolves (partial, touching the axis); spline profiles, sweeps
and lofts; holes and tapped holes (blind, drilled, counterbore, countersink, M5-M8 taps, into a
curved face, near and tangent to an edge, crossing); modelled threads (external, fine, partial,
to a shoulder, internal, into a chamfer, at a filleted shoulder); fillets (constant, tangent
chains, convex and concave, variable down to 1e-3 and to 0 at a vertex, corners with equal and
unequal radii, g2 corners); chamfers (two distances, angle, three- and two-edge corners, curved);
shells and offsets; patterns and mirrors (overlapping instances that cut a core free); and
cumulative parts.
A running part grows one tier at a time through `base` (back wall, revolved boss and slot,
spline window, tapped holes, rounds, chamfers, shell, vents), and the last case adds its thread:
it carries every tier. Answers are analytic wherever the geometry has them (Pappus, Steinmetz,
ISO 68-1 basic thread profiles, exact Gauss quadrature of Bezier profiles, inclusion-exclusion
for chamfered corners), otherwise invariants; each `method` gives the derivation, and
tools/kernel-ladder/cases.py (standard-library Python, like tools/oracle-analytic) writes them.
Capabilities SolidCraft lacks are `missing` cases: multi-start threads, thread runout lengths,
fillet corner setbacks.
The golden is the first recording on truck, each tier sorted by its time. SMLib booleans are
not on this branch yet, so the smlib column records "not supported yet" for every case.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
The ladder orders kernel operations by complexity instead of by random goldens: a manifest
(tests/kernel-cases/ladder/ladder.json) lists tiers in order and each tier's cases in order;
every case is graded against its own answer like any rig case, and a golden
(tests/kernel-cases/ladder/golden.json) records per case and kernel the status, the commands'
time and what the kernel made. A run compares with the golden and flags slowdowns (over twice the
time and 0.25 s more), status changes and changed counts. `--record REASON` re-measures one case
at a time, rewrites the golden with its reason and sorts each tier by the first kernel's time.
The report, docs/kernel-ladder.md, gives per tier and kernel the counts per status and the
frontier: the first case in ladder order the kernel fails. It reuses the rig's process-per-case
runner, timeout and cells; results now carry their path under tests/kernel-cases/ so cases from
other areas can be listed in a tier. The README documents `base`, `missing` and the ladder.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
What the complexity ladder needs from the rig's case runner, kept in the one runner:
- A script may name a `base` case directory: that case's commands (and its own base's, up to
32 deep) run first, so a ladder case starts from the previous tier's finished part without
copying its commands. `$CASE` is each recipe's own directory; `$OUT` is the running case's
scratch directory, in its bases too.
- `missing` in expected.json reports the case as not supported yet without running it: a
capability with no command or parameter (multi-start threads, fillet setbacks) stays visible
instead of being faked with a stand-in.
- Each result carries `seconds` (the commands' own time, without process start or grading) and
`measured` (body count, face/edge/vertex counts, volume, area), for the ladder's golden.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
A revolved cone tip with an exact volume and area; auto-reports without
a design are listed in the skipped.json files.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
A tray with seven rounded edges, both rim rounds of a tube, a chamfer on
a joined L-shaped body, and a circular pattern of a chamfered hole, each
with an analytic volume.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
An M8x1 thread in a 7 mm hole, and three booleans of finely faceted
prisms (1000 and 1200 flat faces) with planar and curved partners, each
with a closed-form volume. Three auto-reports without geometry are
listed in skipped.json.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
`"outcome": "solid_or_refused"` takes a clean refusal, or else grades the result as usual. Two
bodies that touch along a circle only (#168, #3841) have no one-solid union: a refusal or the two
bodies left apart are both right; fusing them is wrong. The two cases said opposite things
(two bodies, a refusal) and now agree.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- `"shells": N` in expected.json grades the total number of shells: a body with a sealed void
holds two, and some joins keep several lumps in one body. Those cases (#3175, #3455, #3526,
#3730) are graded on validity again instead of being marked not valid.
- When SMLib's record conversion says "not supported yet" (revolved surfaces, traced intersection
curves), its check gives no verdict. That's shown but not graded, since it isn't a fault of the
body. solidcraft_kernel::SmlibCheck carries the three outcomes.
- `$OUT` in a recipe is a scratch directory outside the repository, for files a case writes. The
two STEP-export crash cases write there instead of /tmp.
- cargo xtask kernel-cases --results FILE keeps every result as JSON.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Every other sweep, loft, revolve, pipe, coil and rib issue and PR, one line each: auto-filed reports that carry only command parameters, reports cut off in the source, UI and dialog items, feature requests, and failures that belong to import, shell, fillets, booleans or tessellation.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Coils split and trimmed by a plane, cut with a negative pitch, joined flush round a cylinder, intersected with a cylinder, cut as a thread groove into a bore, and placed with a square wire outside the diameter (screw-motion Pappus); surface revolve, sweep and loft sheets with areas worked out by integration, and a rail-guided surface loft in either section order.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
End faces of a loft, a sweep and a coil extruded, closed twisted sweeps round a torus, a twisted square cut through a tube, a ring swept along a short arc and joined to a collar, two overlapping swept arc walls, a rib grown along the sketch normal, and three pipes meeting at a point.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
End scale, parallel orientation and guide rails on straight paths (frustums and a sheared cylinder), a rectangle swept round a mitred corner, a profile mid-line on a closed rounded rectangle, second sweeps from a plane along a closed circle, hollow and cutting pipes, and a flat wall of a swept corner extruded.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Refusals for a profile across the axis and an axis outside the sketch plane, a construction axis picked by name, a cone left by a revolve cut, revolve joins and cuts whose end faces lie in a face of the target, a dome cut by a ball on its seam, a horn-torus turn, and half-disc revolves with a refused hostile sweep scale.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Spherical shell sketched off the origin, adjacent profiles on the axis, whole planar faces of full and partial turns and a face pick on a fresh revolve, a half slot turned about its centreline (alone and as a cut), a torus cut by an overlapping ring, and a 300 degree revolve crossed by a plate.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Added: 451 (block inside / crossing a hollow spherical-shell tool), 1107 (hollow hub joined
with nine blades), 1140 (spiral hollow lofted tube cut in half and joined), 2928 (cap-touching
lips with 0.0001 mm offset walls), 3850 with 3741 (cross cut touching a round side, and the
hole after it), 1984 (near-coaxial pin and rivet overlaps). #3573 is now a source of
shell/3576. Their lines are gone from the skipped files; #2259, #3518 and #3602 stay skipped
with corrected reasons.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Hollow elbows lofted along a bend (Pappus), hollow bands halved and joined, a flange touching the end of a bent tapered loft, tapered and twisted lofted blades patterned round a disk, and a loft joined into a window that it overhangs, alone and mirrored on a hollow case.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
A shallow loft cut from a slab top face, a loft cut whose sections touch the block sides given in either order, circles lofted into a cone on a turned-over plane, a loft guided by a rail, a circle lofted to a comb outline, a square lofted to a circle, and a circle-to-rectangle loft joined to a cylinder.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Ruled lofts of zig-zag outlines worked out with the prismatoid formula, rotated rectangle sections turning through half a turn (Pappus), ring sections with round and rectangular holes, a cone loft meeting a cylinder wall near its top, a loft standing on a box face, a loft cut limited by targets, and a refusal for sections in one plane.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The rest of the thread cases (holes at the nominal size, shafts and holes
off the thread's size, the crash and sketch-attachment repros) and the
triage of the sources that are not kernel geometry.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
External and internal modelled threads, tapped holes and threads beside
other features, each graded against the ISO 68-1 groove volume (Pappus)
and the part's own closed-form volume.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
SMLib bounds an intersection edge on a piece of its spline (seed 32 intersect:
a block and a cylinder, the top disc's edges), and the truck decode refused
such an edge ("not supported yet: a spline or intersection edge on part of its
curve"), since truck bounds an edge by its curve's whole range.
bspline::segment cuts a B-spline to a sub-interval of its domain exactly:
Boehm insertion of both ends until each has multiplicity p, then the knots and
control points between them, clamped on the interval. The same points at the
same parameters, so the edge keeps its interval and the record its numbers.
load_edge_curve loads a spline or rational spline edge on part of its curve as
that piece; an intersection edge on part of its curve is still refused. Our
own records (interval = the curve's range) load as before.
Tests: segments of a rational cubic with a double knot, inside a span, across
knots, from or to a domain end, match the whole curve within 1e-12; both
spline kinds load on a piece with that range and the same points, and beyond
the domain are refused; SMLib's block ∩ cylinder decodes (it was refused) with
π r² h within 1e-3.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
The adapter loads an analytic torus as truck's revolution of the whole profile
circle, a rational quadratic closed on itself, so an SMLib torus is one face
bounded by its two seam circles, each used both ways. The display evaluator's
domain gave a revolution a period around its axis only: projected along the
profile the loop jumped from one end of the knot interval to the other at its
start vertex, the plan failed ("boundary crosses itself") and the body fell
back to truck's mesher, which meshes a sphere bounded by its seam alone as
nothing (seed 60 union, a torus beside a sphere: 925.0 of 990.7 mm³).
tess::uv::closed_curve detects a closed profile the way closed does a closed
spline surface (clamped knots, first and last control point and weight the
same within 1e-9 of the polygon's extent; the shared checks are factored out),
the domain then has period = the profile's knot interval along it, and
EvalSurface::wrap/derivs wrap that parameter back into the interval, so the
plan's projection, unwrapping and both evaluators treat it as periodic. A
cylinder's or cone's line profile is unchanged.
Tests: a revolved whole circle, either parameter order, has both periods and
evaluates a period away as inside; SMLib's torus, alone and beside a sphere,
decodes without meshing to orient it, plans every face and measures within
1e-3 of 2π²Rr² (+ 4/3 πr³). With the closed profile undone the torus plan
fails as above.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
Results of SMLib booleans on its own spheres came back wrong through
body_from_smlib (side-by-side runner: seed 13 cut −1611.9, seed 61 cut −252.4
against SMLib's 4056.9, seeds 46/61 union 80 % short). The schema 4 records were
right (check_geometry passes, outer loops counter-clockwise, shells out of the
material); three things on the truck side were not:
- Body::new orients a solid by the volume of truck's coarse mesh, and truck's
mesher meshes a sphere bounded by its seam alone as nothing: the rest of the
body set the sign and turned it inside out. A foreign record is oriented by
its shells, so body_from_smlib now builds the body with Body::oriented
(revolved faces turned as before, orientation kept, nothing meshed).
- rephase_revolved turns each revolved face so it sits around angle π. A face
that uses its seam both ways goes all the way round; turning its surface ran
the wrap through the face's hole, the display plan failed and the sphere
meshed as nothing. Such faces now keep their wrap on their seam (truck's own
primitives have none: their round faces are split).
- The display plan opened only a loop of one seam used both ways. A sphere face
whose meridian a trim splits uses each piece both ways, turning back at each
pole, and projected onto one parameter line ("boundary crosses itself"), so
the whole body fell back to truck's mesher and lost its sphere faces. A loop
through both poles that turns straight back at one now has its run between
the poles moved one period along, whichever way keeps it within one period
with a positive area (poles split as the planner splits them); the routing
check finds such loops too.
Test: SMLib's sphere less a box cap beside its seam, across it (seam split) and
a bar bored into its side away from the seam decode without meshing to orient,
oriented as recorded, every face meshed, within 1e-3 of the exact volume.
Before, the decode meshed the body to orient it; with only the plan's pole
handling undone the −x cap measures 50.3 of 469.1 mm³, with only the
rephase undone the bored ball 252.4 of 4059.5.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
Every other fillet, chamfer and blend issue and PR, one line each: auto-filed reports from private designs (picks and error only), sketch fillets and chamfers, UI, previews and navigation, feature and fit-option requests, reference cases that already exist in tests/oracle, surface modelling, and failures that belong to booleans, shell, import, tessellation, sheet-metal or threads.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The graded volume was right; the derivation text quoted the union as 46476.5 instead of 45571.7.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Copies of filleted and chamfered features (a pasted block, a pattern of pockets with corner rounds, a pattern of chamfered bosses), a grille of rib roots, a join that needs a boolean retry followed by a fillet, and curvature-continuous fillets worked out from the documented quintic section.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Rounds along curved outlines, with the removed volume worked out by Pappus or by integration: merged cylinders, a D prism, a rounded rectangle with 0.02 mm end edges, a long box beside quarter turns, vertical corners after bottom rounds, a bent tube end, a boss's bottom arc, bars running into a boss, an edge ending on a curved wall, and the knife-edge arc corner.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Rounds with their own right answers: a radius larger than the ring it runs along (refused), a pick on a smooth seam (refused), a far edge pick (refused), a round that uses up an end face or a wall, a round over a hole, rounds on both sides of a thin wall and concentric with an inner one, a round on a sphere's flat cut, an edge ending on a tangent seam, and rims on B-spline ramps.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Chamfers on boxes, plates, discs and sectors with closed-form volumes: all twelve edges in the order that was refused, a concave chamfer that adds material, a chamfer next to square openings and one that runs into them, a hole rim tangent to the bottom face, a hex hole's corner bevels, a one-pick chain on a large part, a bottom loop as wide as the corner round, two distances on a circular rim, the end outlines of a rounded prism, a chamfer over a joined pin, and the equal chamfer of a slanted plug. Spline-sided pillar (invariants only) for chamfer and fillet.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Cases: mirror of a cut under a wall (#4011), coplanar intersect (#3671), multi-lump
intersect (#3526), split along a face plane (#3447), 64-peg join (#3455), boss on a rod
(#3485), collinear cylinders and pin in a bore (#3497), swept G2 cut (#3604), spokes
tangent to a hub (#3612), sphere and pyramid (#3633), column in a channel (#3665),
extrude to a point on an edge (#3729), emboss on a cylinder (#3782), circle-only join
(#3841), ring on a perforated plate (#3887), symmetric revolve cut (#4008), walls round a
floor (#4058), slab beside a bore (#4095), and others. The rest are skipped with a reason
in skipped-c.json.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Every other sheet-metal-keyword issue and PR, one line each: UI, docs, file
format, naming and attachments, DXF output, feature requests, user designs
with no repro, and failures that belong to booleans, fillets, shell, sweeps
or threads.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Trays at 72 degrees and with four angles and heights, a tray shrunk by a
parameter and unfolded, an L bracket unfolded and refolded, opposite flanges
at 105 and 120 degrees, torn corners folded, and a rhombus whose square
reliefs would overlap.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Unfolded trays graded by the flat size W + 2(H - BD): torn, round and square
relieved corners, per-feature reliefs, rounded plate corners; a shelled tray
and a bracket converted at their bends; an L converted to the rule's radius.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
A flange beside the leg of an L, along what a cut-out leaves of an edge,
beside a ledge as tall as its setback, a return on a flange's far edge, a
round hole, a slanted slot and an ellipse across a bend, a hundred slots with
four folds, and the refusal of rule values sheet.flange would ignore.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Cut-outs folded and refolded, a hole square to a 45 degree flange, a slot
that parts a flange from its base, an inside flange on a plate turned
62 degrees, cuts after cuts, a hole beside two adjacent flanges and a flange
on a flange's side edge; refusals for a flange on a bend line and a flat
pattern after a fillet; a mirrored sheet body that must stay sheet metal.
Volumes by hand (K = 0.5 folds: flat area * t; otherwise bend volumes).
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Plates converted to sheet metal (holes, long thin strips, engraving, a
channel with modelled bends, position kept) and holes and cut-outs
through or into a sheet; volumes by hand from the plate and the holes.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Folds of tabs and plates, graded by closed form: a fold keeps the blank's
flat length, so V = flat area * t + theta * w * t^2 * (1/2 - K). Tabs
on one line (#264, #638), a tab on an L's inside edge (#639), a fold just
inside a tab root and a refusal at the root (#262), a fixed point on the
top face of a large plate (#685).
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Cases for the near-contact gap join, a countersunk hole beside a distant
body, a perforated plate under a ring, a sealed void, a rim and tooth join,
a frustum cut, a line-to-line pin, a flush notch, spoke patterns and a join
into a rotated occurrence. The rest of the bundle is in skipped-b.json with
one line each.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Hand-derived cases for tapered and collinear extrudes, pattern and mirror
copies keeping their targets, a cut up to a face, a prism joined to a
round-cornered slab, a clip round a small hole, and near-contact joins.
2564, 2583, 2601, 2754, 2755 (pattern, mirror), 2801, 2810, 2826, 2580,
2896 (overlap)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Spheres cut twice (#1717), box/cylinder intersect (#1647), crossing cylinders
moved far (#1649), coaxial cut from a thin disc (#500), coincident cylinder
walls (#114, #2008, #1910, #1865), rim touching a coin (#168), holes along
walls and beside rounds (#559, #562, #1279, #1355, #2055), tangent holes
(#307), blind cut in a cylinder (#308), through-all cut (#423), shallow cuts
(#1858), skin left by a short cut (#1730), delete face (#1927), collinear
extrude sides (#1949), hidden bodies (#2464), mirror and patterns (#2003,
#2524, #2076), tapered extrudes (#831), text cut (#1195), split (#13).
Every other item in the bundle is in skipped-a.json with its reason.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Every other tessellation-keyword issue and PR, with one line each:
rendering and GPU drawing, UI, performance, display-plan plumbing, and
failures that belong to booleans, fillets, threads, import, shell,
sheet metal or crashes.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
311 ramp cut across a round blank, 784/811 filleted and drilled bodies
for STL export, 818 blind hole in a filleted ring, 819/921 pocket that
splits a wall seam, 1263 concave arc with a knife-edge tip, 1615/1653
crossed lofted tubes, 1648/1850 sphere touching a box edge, 1666/1670
two twisted lofts, 1753 bowl rim cut by a cylinder, 1813/2712 lens face
thinner than the tolerance, 2069 notched ring moved far away, 2528
slot joined with an overlapping cylinder.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
140 join with a pad hanging past the edge, 1219 bore fillet then grooves,
1985/2243 STEP export of two enclosures, 3540 cut with a coincident cylinder
face, 3685/1559 delete a fillet face, 4092 loft + ribs + pad union (two
recipes), 2992 disk and 36 twisted loft blades. Everything else is skipped
with a reason (private designs, other areas, UI, perf only).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
4009 closed shell, 4010 shell open at a hole wall, 2531 point pick after an edit,
3468/3898 offset next to a fillet, 12 split face piece, 566 swept bar, 745/3893
freeform boss (two variants), 3103 tapered cylinder, 3669/2990 loft, 3283/3650
and 2939 curved offsets, 3506 and 1972 split then shell, 3576, 391, 1494, 1525.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Cases: #3702 (a board in the cavity of a case with a filleted rim, cut leaves the case
unchanged) and #258 (STEP cone to a point, with and without an apex vertex, and the 0.5 mm
pin). Everything else in the bundle is skipped with a reason in skipped-other.json.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- solidcraft-cli and solidcraft-engine forward an `smlib` feature to solidcraft-kernel/smlib, so
`cargo build -p solidcraft-cli --features smlib` gives the rig SMLib's check.
- solidcraft_kernel::boolean_kernel() says which kernel this process runs booleans on.
`default` until the SMLib switch (SOLIDCRAFT_BOOLEANS=smlib) lands and answers there. An smlib
run on a build without the switch reports "not supported yet" instead of grading the default
kernel under SMLib's name.
- An area may keep its skipped list in parts (skipped-<part>.json).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Rows without an analytic volume (the fuzz seeds) get one from the
primitives' definitions, by no kernel: along each vertical line both
operands are exact z intervals, combined exactly, integrated over a grid
whose cell edges include every straight face, with the half-resolution
grid bounding what error is left. Each kernel's volume is graded against
it (within 1e-3 relative or 3x that bound), in the JSON per row and in the
report's summary.
On 64 seeds truck is right on all 192 rows. SMLib's own measure is wrong on
13, all with cylinders or spheres, although truck's measure of the same
exported bodies is right on every one of them; 5 give no closed solid.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Every geometry case the old kernel got wrong becomes tests/kernel-cases/<area>/<id>/: an
engine script or oracle recipe, and expected.json with the right answer, from analysis or a
hand calculation, or else the invariants. Never a kernel's output.
- solidcraft-cli kernel-cases <dir>...: runs a case and grades it. The checks are the outcome
(succeeds, or refuses cleanly), the body count, and one closed shell per body that passes the
record's structure and geometry checks and, with SMLib built, SMLib's check(All). Counts,
volume, area, centroid and box are graded where the case gives them. Each run is pass, fail,
not supported yet or crash.
- cargo xtask kernel-cases [--kernel default|smlib|both]: one process per case, so a native crash
or a hang (--timeout) is that case's result. It writes docs/kernel-cases.md: coverage per area
and source, results per kernel, and the sources looked at and skipped (<area>/skipped.json).
- solidcraft_kernel::validity and smlib_built, which the rig's checks use.
tests/kernel-cases/README.md gives the format.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
When SMLib's volume of a boolean result differs from truck's, the report could
not tell a wrong body from a wrong SMLib measure. The runner now measures the
result it exports back to truck as well, keeps that volume in the JSON, and
shows it in the export column wherever it leaves SMLib's own measure or SMLib
could not measure the body at all.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
The side-by-side runner now reports how long each boolean takes on truck and
on SMLib (the call alone), and apart from that the SMLib side's conversions:
the operands' truck→SMLib import and the result's SMLib→truck export, which
the app pays while truck still holds the bodies. The report gains a times
summary (median, worst, total), solid counts, the analytic volume of each named
case's union, intersection and cut, and how many results land on it.
It also runs the "each cut gets slower" case from TASK_kernel-smlib-booleans as
a named sequence: a 63.6 × 31.7 × 9.5 block, a Ø20 × 10 boss joined on top, a
slot front to back, a Ø6 cross hole through the boss and a slot that splits
the block, each step on the previous result. SMLib keeps its own results from
step to step (only the tools come from truck), in a child process like the
cases, and every step's volume is checked against its closed form.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
The smlib_booleans example answered "not supported yet" for every SMLib case.
Now it runs solidcraft_smlib::Brep::boolean on the tagged operands (cut maps
to Subtract, None is an empty result), reads the result's history from the
tags, and measures its volume with mass_properties at MEASURE_ACCURACY, so the
report compares truck and SMLib on real results.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
truck lists some planar faces' hole loops before the outer loop, so the
rule that loops[0] is the outer loop never held for truck's records; moving
it in the adapter would renumber those faces' edges, which history and
names stand on. The outer loop is the one that runs counter-clockwise about
the natural normal (what check_geometry checks); the order is the
producer's, and SMLib's import puts the outer loop first, as SMLib needs.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
check_geometry compared pcurve ends with edge points only, so a loop whose
pcurves enclose nothing passed whenever its uses lift onto the same 3D points:
SMLib's hole-rim fillet with both seam uses on u = 0, or a whole sphere whose
pole-to-pole seam has both uses on one line (the continuity check skips the
pole). Such a face has no surface and meshes to nothing.
Each edge loop's signed (u, v) area is now taken over 16 points of each use's
pcurve: a loop within 1e-9 of the square of its extent of zero is refused
(Problem::Empty), and each face must have exactly one counter-clockwise loop
about the natural normal, the rest clockwise (Problem::Turn). Outer and inner
are told apart by area rather than position, because the truck adapter writes a
face's wires in truck's order, which puts a hole first on some planar faces of
the sample designs (the model cache test caught it).
Fixtures: the pole-to-pole seam on one line, and a sheet whose plane axes are
swapped so its loop runs clockwise; a seamed sphere passes.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
A spline surface whose first and last control rows coincide in a direction
(points and weights, knots clamped there) closes on itself, but the display
evaluator's domain gave NURBS no period. The pcurve routine therefore never
moved a seam's second use by a period: SMLib's fillet round a hole's rim (a
rational spline closed in u) got both seam pcurves on u = 0, its outer loop
enclosed no (u, v) area, the decoded face tessellated to nothing and the body
measured 6839.73 mm3 against SMLib's 6989.00.
tess::uv::closed detects the closure from the record, within 1e-9 of the
control net's extent; the domain then has period = the active knot interval's
width, and the evaluator wraps a parameter outside that interval back inside
it, so pcurves, projection, sizing and the display plan all treat the direction
as periodic. The record stays as it is. The display plan hands both evaluators
wrapped parameters (the GPU does not wrap).
Tests: a rational torus band, a NURBS cylinder and a NURBS dome with a pole,
each bounded by a seam used twice, get seam pcurves one period apart; a record
of the band passes check_geometry and its seam uses on one line are refused;
SMLib's hole-rim fillet decodes with every face meshed and SMLib's volume
within 1e-3.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
Brep::boolean (union, subtract, intersect; Ok(None) for an empty result), Brep::solid_count,
Brep::fillet, Brep::chamfer and Brep::shell, over the fork's smlib_ops.cpp shims (ffi/ops.rs).
Edges and faces are chosen by points, each the nearest within a tolerance; a point that
selects nothing or cannot decide is Error::NoMatch / Error::Ambiguous with its index, and a
solid input that gives anything but a closed solid is Error::NotSolid. Fillets and chamfers
take whole tangent chains; a chamfer distance is the setback along each face; a shell's
thickness is negative inward.
The C API with these shims is version 2 (the fork's capi-flat line), so ABI_VERSION is 2.
Tests (ops_tests.rs) against analytic volumes and counts, SMLib's own check at every level on
each result, and history through a tagged box minus box: union 9000 mm3 [11, 24, 16]; slot
6000 [10, 24, 16]; intersection 1000; empty results; a split body (2 solids); a cube with all
12 edges rounded r = 2 against the Minkowski formula; one chamfer (7910, [7, 15, 10]); shells
open at the top inward (3392), outward (4672) and closed; a tangent chain from one pick equal
to picking all three edges; hostile sizes, tolerances, points and counts.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
build.rs asked Cargo to rerun only when capi/ changed, so a fix in the fork's source/ (SMLib
or SM_API) left the old objects linked: the tests kept crashing on a kernel bug already fixed
on disk. It now watches source/ too.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
The hyperbola and parabola cone pieces and the revolved cylinder, read by solidcraft-step into
schema 4 and built back into truck bodies, keep their closed-form volumes with their faces
pointing out.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SURFACE_OF_REVOLUTION reads as a placed revolution (u the angle, v the profile's parameter,
STEP's normal); SURFACE_OF_LINEAR_EXTRUSION as an exact spline surface, the profile as a
(rational) B-spline times degree 1 along the vector; a circle extruded along its axis or
revolved in a plane through the axis as the cylinder or ring torus it is. Line, conic and
open-conic profiles are bounded by the face (a closed conic's seam outside it, a revolved
profile stopped at the axis). OFFSET_SURFACE of the analytic kinds reads as the moved
surface, checked at each level. Hyperbola and parabola edges read as exact rational
quadratic pieces and a Bezier on STEP's parameter. Faces winding around a revolution get
seams along its profile. Every mapping is checked point by point and normal by normal
against STEP's own surface.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Schema 4 counts every pcurve's control points as items, which schema 3 had
none of, so a body that fitted the old 1,000,000 no longer does (a STEP
plate of 50k faces). The binary envelope's own caps on bytes, values and
entries per collection still bound a body.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
A face winding around a closed (non-periodic) spline surface without a seam edge has loops
that jump across the surface's domain; it is refused for now instead of making a record whose
loops do not close. The step-conformance parts are read in a test, and the kernel's ignored
corpus comparison builds each record back into a truck solid to compare volumes.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A face on a cylinder, cone or sphere bounded by loops that go round the axis (a band
between two circles, a dome on its equator, a cone on its base and apex) gets a seam:
a ruling or meridian from one loop to the other (split where it has no vertex at that
angle) or to the pole it covers, so every loop closes in (u, v) as schema 4 requires.
Pcurves may be fitted up to 1 mm off for edges that lie off their surfaces. The kernel
gets an ignored corpus test comparing truck's face and edge counts with schema 4's.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
read_solids walks MANIFOLD_SOLID_BREP, BREP_WITH_VOIDS and SHELL_BASED_SURFACE_MODEL
into solidcraft_geom::brep records: lines, conics, B-splines and polylines; planes, the
analytic surfaces and B-spline surfaces; edge intervals from the vertices' parameters;
loops relative to the surface's natural normal; outer loops, regions, voids and sheets;
pcurves from the 3D edges; the canonical order. Unsupported geometry refuses its solid
with a reason and the rest of the file is still read.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Boxes and cylinders go into SMLib as truck's own B-reps, through their
schema 4 records (smlib_body), so both kernels start from the same input
whatever the axis. Spheres and tori are SMLib's primitives about +Z, like
truck's, since the import doesn't take truck's revolved surfaces yet. All
41 cases' operands now build; only the boolean itself waits for its shim.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Cylinders (also against oracle 02 and 38's expected.json), spheres, cones, frustums and tori,
at the origin and 2e5 mm out: area, volume, centroid, moments and products within 1e-6.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SMLib B-reps leave the C API as its flat arrays, read through the crate's
one flat wrapper (crate::flat::Flat, copied out as import::Arrays), and
become schema 4 records: shell pairs merged, sheets collapsed, radial cycles
normalised, analytic surfaces as their kinds (narrowing cones kept), loops
reversed where SMLib's surface is inside out, every pcurve from
brep::pcurve, canonical order, then validate() and check_geometry(). Edges
arrive as their own kinds; NURBS edges that are lines or circular arcs (the
primitives' circles) are recognised as a fallback and counted. With the
kernel's `smlib` feature, body_from_smlib() decodes them into a Body.
Adds the cylinder, sphere, cone and torus primitives. Each primitive passes
SMLib's own check at every level, its volume from the exact mass properties
matches the closed form, and it goes round SMLib -> schema 4 -> SMLib with
its counts, volume and a clean check. Truck now meshes a whole sphere
bounded only by its seam (SMLib's sphere) through the display plan.
SMLIB_REV moves to the fork's capi-primitives (the primitives on capi-flat
40bb855).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
SMLIB_REV moves to the fork's capi-static 40bb855 (flat arrays, C ABI 2).
flat.rs wraps them (Flat: arrays by id, Brep::export, Flat::import,
Brep::is_manifold_solid; FFI in ffi/flat.rs). import.rs lays a schema 4 record
out as those arrays: a closed shell becomes one SMLib shell per region it
separates, a sheet's shell holds both sides of each face, the infinite region
is marked void as SMLib has it, pcurves become UV trims on B-spline faces only
(reversed for edgeuses against their edge), planes with non-unit axes go as
their exact bilinear patch. Brep::from_record builds the SMLib body.
kernel: brep_record(body) gives a body's schema 4 record, and smlib_body
(feature smlib) its SMLib body, trusted (no healer: healing moved a
cylinder's volume by 9e-7). Box, cylinder and tilted cylinder keep their
analytic volume in SMLib (1e-9, 1e-6) and are manifold solids; truck's
spheres and tori are revolutions, refused with "not supported yet" for now.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A whole sphere bounded only by its seam (SMLib's sphere: one meridian
used twice) came out with both uses on the same u line, a loop that
encloses nothing. Two causes in the per-loop closure:
- The pole-junction search took any positive signed area as the right
turn. With the two uses on one line the area is rounding, and in most
frames that rounding is a tiny positive number, so "no shift" won over
the period shift. A turn now needs more than 1e-9 of the loop's
period box.
- Junctions counted as poles only where the surface collapses exactly.
Ends within the tolerance of a pole (as a kernel's records have them)
were closed to the nearest period instead. A junction is now free
where moving its periodic parameter by half a period stays within the
tolerance, and fit samples within a quarter of it take their free
parameter from a neighbour, so the pcurve runs straight into the pole.
Tests: the sphere bounded by its seam in four frames, three meridian
angles, circle and NURBS meridians, both loop orders, ends at or a tenth
of the tolerance off the poles; and a torus bounded by its two seams.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
Area, volume, centroid, and inertia and products about the centroid (with inertia_tensor()),
integrated by SMLib on the exact surfaces, through the fork's smlib_brep_mass_properties and
smlib_brep_area. MEASURE_ACCURACY = 1e-8, the finest SMLib allows. At that accuracy the fork's
own test puts boxes, cylinders, spheres, cones and tori within 2e-7 of their closed forms.
Tests: tests/oracle/01-box against its expected.json (to 1e-12), a box 2e5 mm out keeping its
inertia, and accuracy arguments. SMLIB_REV moves to the fork's measure commit (3e95b79).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ValidatePointers, then AssertValid over the whole topology graph (the fork's
smlib_brep_check), at CheckLevel::Basic, Geometry or All. A body that fails is still Ok, with
the failed tests counted and one line each in the CheckReport; Err means the check could not
run. Tests run it on every SMLib result and import.
SMLIB_REV moves to the fork's check commit (39f398e), which also fixes a seam-curve leak that
AssertValid hit on every periodic face.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
decode builds topology with Edge::new_unchecked and Face::new_unchecked,
so a record whose curves miss their vertices or whose pcurves miss their
edges loaded and failed later inside truck. It now runs check_geometry
after validate and refuses such a record (a cache miss at the IO
boundary). Only our own cache feeds it today; STEP and SMLib exports will.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
validate() is structural only, and a kernel adapter that builds topology
from the records without its own checks (truck's new_unchecked) would take
an edge whose curve misses its vertices and fail later inside the kernel.
check_geometry spot-checks what it assumes, each against the record's own
tolerance: every edge's curve meets its vertices at its interval's ends;
every oriented edge's pcurve, lifted through its face's surface, lies on
the edge's curve at the interval's ends and middle and continues the use
before it on the same period; every vertex loop's vertex lies on its
surface. A fixed number of evaluations per record, so linear in the item
budget; a point that cannot be evaluated is an error (Mismatch, naming the
record), never a panic.
The schema fixtures now carry real planes and pcurves (from
pcurve::pcurves), so every form passes; one-defect fixtures and hostile
records cover the refusals.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
SMLib makes a fillet or chamfer face with no tag, so history::blends gives
each Generated face FaceOrigin::Edge for every blended edge whose two faces
both lie next to it and no longer meet directly. For the fillet shim's
history once it lands; a corner patch between blends keeps no origin.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
examples/smlib_booleans runs truck and SMLib on the same cases (named pairs
whose results are known by hand, then fuzz::boolean_shapes for N seeds),
each as union, intersection and cut, and compares volume, face and edge
counts and the shape of the history (how many faces Kept, Modified, Split,
Merged, Generated; edges from an operand edge, new, or without origin). It
writes a JSON and a Markdown report and never changes the default kernel.
SMLib runs in a child process per case, so a crash inside it is reported as
that case's result. Its primitives and booleans arrive with the operation
shims; until a call exists the case is reported as not run on SMLib.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Brep::tagged gives a copy whose faces and edges are tagged as one operand's;
after an operation on tagged copies, Brep::history reads back each result
face's origins and change (Kept, Modified, Split, Merged, Generated) and each
edge's faces and origin edges, as SMLib itself carried them through the
operation's splits, merges, copies and coincidences. Raw::history turns that
into solidcraft_geom's History, renumbered into canonical order by each
body's Order, with a new edge recorded as where its two faces meet.
The FFI declarations are in src/ffi/history.rs, beside ffi.rs. Tests cover
the C layout, hostile records, the meeting edges, renumbering and bad
orders, and (with SMLib built) a tagged box.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A new crate, solidcraft-step (L1, no modelling backend), holds the Part 21
parser (moved from the kernel, which now reads through it) and STEP geometry
as plain data: lines, conics, B-splines (rational and implied knots),
polylines, trimmed curves, surface curves with their pcurves, 3D offset
curves; planes, cylinders, cones, spheres, tori (degenerate too), B-spline
surfaces, revolutions, linear extrusions, offset and rectangular trimmed
surfaces. Each keeps STEP's own definition and parameterisation, in mm and
radians, with pcurves scaled by their surface's parameter units. Shared
entities stay shared. A writer emits the same entities back, deduplicated.
Tests per entity check values against analytic points, units, round trips
and hostile input; an ignored test reads and round-trips every edge curve
and face surface of the tangency-labs/models STEP files.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ffi::line was a safe public function reading any raw pointer. The log
callback now lives in ffi.rs, reads the C string there, and hands the
crate a String through a safe sink, so no safe function takes a pointer.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
A new crate (L1, only the kernel uses it) builds tangency-labs/smlib's SMLib,
SM_API and C API with the cc crate when its `native` feature is on, from the
commit in crates/smlib/SMLIB_REV (scripts/fetch-smlib.sh fetches just those
sources). The kernel's `smlib` feature turns it on. Without it nothing C++
is built and every call returns NotBuilt, so workspace builds need no C++
toolchain.
unsafe is confined to src/ffi.rs. The wrapper owns handles, maps statuses to
errors, checks the C API version, and sends SMLib's per-call log to the log
crate. Crash reports note the native kernel call in flight.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SMLib makes narrowing cones with a negative half angle; schema 4 now takes
them as they are (r(v) = r0 + v tan a already covers them), with the
natural v range below the apex. The check that no region lists a shell
twice was quadratic per region (about 1e9 comparisons at the caps); it now
remembers the last region that listed each shell.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
The adapter now saves each edge's curve record and interval when the edge first appears and
computes every face's pcurves from those records and the surface record it writes, with the
shared plain-record routine; the truck-face version in native/pcurve.rs is deleted. Loops go
in as the record keeps them (relative to the surface), so a reversed face no longer has its
wires reversed and back again.
The native tests are ported (adapter::face_alone gives one face's record for them). The cut
body's intersection pcurves now fit at 1e-6 mm too: the routine follows the converged
intersection, and truck's own points are within its 1e-6 mm of it, which the lift check
allows for on intersection edges. docs/native-brep.md says where pcurves come from and what
a surface intersection's point at t is.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
solidcraft_geom::brep::pcurve::pcurves(surface, loops, tolerance) computes every edge use's
pcurve from our own records: the surface record and, per loop, each use's curve record,
interval and direction. No backend's parameter space is involved, so the truck adapter and an
SMLib conversion can share it (owner decision 2026-10-21).
brep::eval evaluates every schema 4 kind: planes, splines and revolutions through the display
evaluator (EvalSurface, EvalCurve, tess::uv), cylinders, cones, spheres and tori in closed
form in angle and height, and a surface intersection as the point of both surfaces in the
leader's normal plane (what truck's subs converges to), by Newton's method.
Exact in our parameters: lines, polylines and whole splines on planes; a circle about the axis
of a cylinder, cone, sphere or torus (a u-line); a line along a cylinder's or cone's ruling (a
v-line). Each exact pcurve is checked by lifting it; everything else is the cubic B-spline fit
the kernel had, with its span and round caps. Curve2::eval moves here from the kernel.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
The parameter box, the projection of a point onto an evaluator surface (closed form on a
plane, damped Gauss-Newton elsewhere), unwrapping and the pole test work on geom's
EvalSurface alone. They move from the kernel's tessellator to solidcraft_geom::tess::uv so a
pcurve routine on plain B-rep records can use them without truck; the kernel re-exports them
and its tessellation is unchanged.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
A test over every design the repository keeps (the action matrix's
corpus: old design files, examples, regressions, demo and typical
designs, the oracle recipes; plus the sample designs, the engine's
design fixtures and the older designs of the hole matrix, taper and
projection tests: 154 designs). Each is rebuilt and recorded in
tests/naming/<group>/<design>.txt: per body the names of its faces and
edges with whether each follows exact history, and every stored name
(feature face picks, fillet/chamfer/bend edges, sheet metal edges, the
face a sketch is attached to) with the face or edge it finds now. A
difference fails with the design and the changed lines; record an
intended change with NAMING_CORPUS_BLESS=1, as FEATURE_WALK_BLESS does.
Face and edge indices are left out on purpose. They are the kernel's
order: truck already gives a fillet's or a boolean's faces in another
order from one process to the next (oracle 07 and 37 changed on every
run), and SMLib will order them differently again, while what must not
change is the names and what references find. Names are listed sorted.
One design's names themselves change between runs on truck
(closed_sweep_torus_cut: level wall halves numbered #1/#2 in kernel
face order); it is listed in UNSTABLE with the reason and its
difference printed instead of failed on.
Records made on this branch (truck), macOS. The whole corpus builds in
about 20 s on 14 cores (designs run side by side).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
The corpus naming test (next commit) records what every stored face and
edge name resolves to, and must find it exactly as a rebuild does. Three
lookups were crate-private: `locate_face_on_body` (a feature's face
points, tried on the body the feature names first), `blend_target` (the
body a fillet or chamfer rounds) and `Document::anchored_face_indices`
(the faces a face-attached sketch is on). Visibility only; no behaviour
changes.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
docs/native-brep.md describes schema 4: the records with their SMLib and
STEP names, regions and shells, the loop convention, every edge's uses,
the canonical order (a reversed face walked backwards), each curve and
surface kind's parameterisation, pcurve rules, validation, history, the
SCBREP05 envelope and what the truck adapter writes and refuses.
A test lifts every pcurve of a box, a filleted box with a bore and a
sphere onto its face and checks it is its own edge at both ends and the
middle; with a reversed face's pcurves left in truck's oriented order it
fails by 30 mm.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
Edges, vertices and the body carry the face tolerance (10^-6 of the
body's size, at least 10^-5 mm): truck's traced intersection edges sit
about 1e-6 mm off their surfaces, so the linear tolerance is too tight for
a pcurve to lift onto them. The box-and-fillet golden fixture is the
schema 4 envelope now (NATIVE_BREP_BLESS=1 rewrites it), and the adapter
tests cover a pair of lumps. The model cache's producer revision becomes
solidcraft-truck-adapter/4.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
The plain B-rep follows SMLib's flat form with STEP's names: regions
(infinite first), face/wire/vertex shells, oriented faces, faces with a
domain and edge or vertex loops, oriented edges with a pcurve each, edges
with an interval, a tolerance and their list of uses, vertices with a
tolerance. Curves and surfaces are unbounded; their bounds are the edge
interval and the face domain. Loops are relative to the surface's natural
normal. Schema 3's read-only intersection and revolution records go.
The validator keeps schema 3's caps and adds the structural rules:
references, loop shape and connectivity, regions and closed shells, the
pcurve interval, natural parameter ranges, every edge's uses (primary
first, upper = !forward) and the canonical order of shells, faces, edges
and vertices. A reversed face is walked backwards, as truck's edge_iter
walks it, so truck's face and edge indices are the canonical ones.
The truck adapter writes truck's absolute wires as the loops, numbers
everything as the kernel does, and builds regions from the shells (a
tessellated nesting test only when there are several closed shells).
Pcurves come from pcurve::pcurves only; until it supports a face, encode
fails and the body is a cache miss. The envelope signature becomes
SCBREP05.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
FaceOrigin, Change, FaceProv, Side, EdgeOrigin, EdgeProv and History move
unchanged (fields, serde derives) to solidcraft-geom, so a backend can
report history without depending on solidcraft-kernel. The pure methods
(composition, renumbering, count checks, mark_shared_split) move with
them and return brep::history::Failed, which converts to
KernelError::Failed with the same "history: …" message.
What needs a kernel body (History::identity, check, face_sources) stays
in the kernel as the BodyHistory trait; solidcraft_kernel::history
re-exports the types, so existing paths keep working.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
A band of a cylinder bounded by two full circles and no seam cannot close
in (u, v): each loop's pcurve runs one period. The test records that such
loops come back continuous and a period open (the caller needs a seam
there), and that a hostile tolerance is refused.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
Each sample of an intersection curve is one of truck's double projections
(about 0.13 ms in a release build), and a fit evaluates the curve at every
sample and halfway between. Starting from four samples a span instead of
eight halves that; the checks stay at eight points a span, and the knots
at the curve's own breaks already carry the shape. The cylinder cut by a
tilted box now takes 70 ms at 1e-3 mm and 149 ms at 1e-5 mm for all its
faces (release), from 183 and 638 ms.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
Faces with seams as imported faces have them (the kernel's own
revolutions come in pieces): a cylinder whose seam line is used twice
between two full circles, each a closed edge on one vertex, and a sphere
bounded by one meridian used twice from pole to pole. Their seam uses come
out a period apart, in the base period. The checks now also require every
face's outer loop to turn counter-clockwise in (u, v) for a face along its
surface's normal and clockwise against it, holes the other way: the rule
the pole junctions rely on, which every test body follows.
With SOLIDCRAFT_PCURVE_SVG=<dir>, a test writes each test body's face
loops in (u, v) as SVG for review.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
Every edge not exact on a plane gets a cubic 2D B-spline on its curve's own
parameter: through the parameters of the curve's ends, least squares
through samples between (banded normal equations), with spans halved and
sampled twice as densely wherever the lift misses the curve by more than
half the tolerance, at the samples or halfway between them. Knots start
where the curve's parameterisation is less smooth: a spline's own knots
and the vertices of an intersection curve's leader polyline, with the
multiplicity a cubic needs there (without them the cylinder-minus-box
intersection curves took 400 spans at 1e-3 mm). Spans and rounds are
capped; a fit that does not converge, or a curve farther from the surface
than the tolerance allows, fails naming the wire, edge and distance.
Samples are projected with the kernel's own surface parameter search (the
evaluator's form, parameterised as truck parameterises it; truck's search
for surfaces it does not take), each from the one before, unwrapped along
periodic directions. Where the surface collapses (a pole) the undefined
parameter comes from the nearest sample that defines it, so a pcurve runs
straight into the pole. Each wire's uses are then moved by whole periods so
each starts where the one before it ends, starting after a pole junction
if there is one; at further pole junctions the offset that gives the loop
a boundary's turn is taken. The wire then moves into the base period. A
seam edge used twice is fitted once.
Truck places intersection curves on their surfaces to about 1e-6 mm, so
their pcurves need a tolerance of 1e-5 mm or more; the test records that.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
A plane's parameters are affine in space, so the pcurve of a line or a
(rational) B-spline on a plane is the curve's own knots and weights with
its control points mapped into (u, v): no fit. Curved surfaces and
intersection curves still return "not supported yet". A test helper checks
every pcurve the way the schema validator does, its interval against the
curve's range, the lift error and the wire's closure in (u, v); the box's
line pcurves lift onto their lines' ends bit for bit.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
The shared base for the schema 4 types and the truck pcurves: 2D B-spline
pcurves as SMLib keeps its UV trim curves, and the truck adapter's pcurve
function, not supported yet.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT
What you clicked or typed, in order. For a problem on a particular design, `solidcraft-cli script design.sc --out repro.json` turns its history into a script that `solidcraft-cli eval repro.json` replays; attach it, trimmed to the failing step if you can.
What you clicked or typed, in order. For a problem on a particular design, `solidcraft-cli script design.solidcraft --out repro.json` turns its history into a script that `solidcraft-cli eval repro.json` replays; attach it, trimmed to the failing step if you can.
Using an AI agent with SolidCraft's MCP server? The `solidcraft-reporting` skill in [`skills/`](https://github.com/tangency-labs/solidcraft/tree/main/skills) has it reproduce the problem in a fresh design and write these steps for you.
# `ci` job still runs and reports the commit's real result (see the `ci` job): the merge queue
# reads `ci` from the newest run of a commit, so a run without it would block a PR that passed.
# Cross-compilation is opt-in through Run workflow; release builds remain in release.yml.
# The release gate (release-gate.yml) calls this workflow (workflow_call) as a Run workflow with
# cross-compilation on.
# Every Linux job runs on Blacksmith's Ubuntu 24.04 runners (blacksmith-<N>vcpu-ubuntu-2404), sized
# per job: 32 vCPU for the tests, 16 for Clippy, the GPU path tests, the archive build (nightly) and the merge queue's, 8 for compiles, doc and reference tests, 4 for the light checks, 2 for Select checks and ci.
# The Windows shader job runs on Blacksmith's Windows Server 2025 runners (blacksmith-8vcpu-windows-2025);
@@ -48,10 +50,14 @@ on:
# only (other labels are skipped, see the top of this file).
# Pull requests test the affected packages (scripts/ci/affected.py).
scope=(--workspace)
if [ "$FULL" != true ]; then scope=(); for p in $PACKAGES; do scope+=(-p "$p"); done; fi
status=0
# The GPU path tracer's tests run in their own job (GPU path tests): one at a time, they
# took about 36 of this job's 45 minutes.
# A failed test does not fail the step by itself: the tests known to fail today
# (tests/KNOWN_FAILING_TESTS) may fail, any other fails it, and so does a listed test
# that passes. nextest's exit code 100 is "tests failed"; any other is its own error
# (a build error, a bad filter) and fails the step at once.
status=0
cargo nextest run "${scope[@]}" --cargo-profile ci --locked --profile ci --no-tests=pass \
--ignore-default-filter -E "($base) & not (package(=solidcraft-gpu) & test(/^path::/))" || status=1
if [ "$status" != 0 ]; then
# A failed golden gets the hint to re-record it (junit.xml lists the failures).
if [ -f "$junit" ] && tr '\n' ' ' < "$junit" | grep -q '<testcase name="tests::robustness_goldens::[^"]*"[^>]*>[[:space:]]*<failure'; then
echo "::error::A robustness golden changed. If the new result is intended, re-record it in this pull request and say why:"
echo "::error::ROBUSTNESS_GOLDENS_BLESS=\"why it changed\" cargo test --profile ci -p solidcraft-engine --lib robustness_goldens:: (see docs/robustness.md)"
fi
exit 1
fi
--ignore-default-filter -E "($base) & not (package(=solidcraft-gpu) & test(/^path::/))" || status=$?
if [ "$status" -ne 0 ] && [ "$status" -ne 100 ]; then exit "$status"; fi
@@ -10,6 +10,7 @@ Work: ROADMAP.md, "Where help is wanted most" in CONTRIBUTING.md, issues labelle
- No GPL/LGPL/AGPL code, not even reading it (OpenCASCADE, FreeCAD, SolveSpace, CadQuery, LibreCAD, QCAD): `cargo xtask licences --check`.
- Every asset is original or openly licensed with a row in ATTRIBUTION.md; read `assets/AGENTS.md` before icon work: `cargo xtask assets`, `cargo xtask icons`.
- Never crash: no unwrap/expect/panic/unsafe in non-test code (unsafe allowlist in crash-safety), errors are `Result`, input is hostile: clippy `-D warnings`, `hostile_params_never_panic`.
- Model decisions (what an operation does, which bodies it touches, which face or edge a point or name means, depths, nearness) use exact geometry; a mesh is for display, export, previews and mesh bodies (`xtask/mesh-decisions.txt` only shrinks): `cargo xtask mesh-decisions`.
- Everything is a command and programmatic calls never open dialogs: `skills/solidcraft-commands/SKILL.md`.
@@ -101,6 +101,22 @@ Editable drawing code, native projects and shipped exports are collected under `
| tests/step-conformance/tiny_pin.step | step-conformance contributors | generated from formulas by https://github.com/dan335/step-conformance (corpus/generated, 96f30bb); import regression fixture | CC0-1.0 |
| tests/step-conformance/torus_ring_nurbs.step | step-conformance contributors | generated from formulas by https://github.com/dan335/step-conformance (corpus/generated, 96f30bb); import regression fixture | CC0-1.0 |
| tests/step-conformance/washer.step | step-conformance contributors | generated from formulas by https://github.com/dan335/step-conformance (corpus/generated, 96f30bb); import regression fixture | CC0-1.0 |
| tests/kernel-cases/import/1721-closed-bspline-tube-face/input.step | step-conformance contributors | copy of tests/step-conformance/cylinder_nurbs.step (generated from formulas by https://github.com/dan335/step-conformance, corpus/generated, 96f30bb); kernel regression case for tangency-labs/solidcraft#1721 | CC0-1.0 |
| tests/kernel-cases/import/2043-outer-bound-opposing-surface-sense/input.step | SolidCraft contributors | synthetic STEP file written by hand from ISO 10303-21 for the kernel regression case of tangency-labs/solidcraft#2043 | MIT OR Apache-2.0 |
| tests/kernel-cases/import/258-cone-point-vertex/input.step | step-conformance contributors | copy of tests/step-conformance/cone_point_vertex.step (generated from formulas by https://github.com/dan335/step-conformance, corpus/generated, 96f30bb); kernel regression case for tangency-labs/solidcraft#258 | CC0-1.0 |
| tests/kernel-cases/import/258-cone-to-point/input.step | step-conformance contributors | copy of tests/step-conformance/cone_point.step (generated from formulas by https://github.com/dan335/step-conformance, corpus/generated, 96f30bb); kernel regression case for tangency-labs/solidcraft#258 | CC0-1.0 |
| tests/kernel-cases/import/258-tiny-pin/input.step | step-conformance contributors | copy of tests/step-conformance/tiny_pin.step (generated from formulas by https://github.com/dan335/step-conformance, corpus/generated, 96f30bb); kernel regression case for tangency-labs/solidcraft#258 | CC0-1.0 |
| tests/kernel-cases/import/3098-bspline-edges-over-tiny-knot-span/input.step | SolidCraft contributors | synthetic STEP file written by hand from ISO 10303-21 for the kernel regression case of tangency-labs/solidcraft#3098 | MIT OR Apache-2.0 |
| tests/kernel-cases/import/3208-extruded-ellipse-face-over-parameter-seam/input.step | SolidCraft contributors | synthetic STEP file written by hand from ISO 10303-21 for the kernel regression case of tangency-labs/solidcraft#3208 | MIT OR Apache-2.0 |
| tests/kernel-cases/import/3352-vertex-off-its-edge-curve/input.step | SolidCraft contributors | synthetic STEP file written by hand from ISO 10303-21 for the kernel regression case of tangency-labs/solidcraft#3352 | MIT OR Apache-2.0 |
| tests/kernel-cases/import/3730-void-oriented-shell-false/input.step | SolidCraft contributors | synthetic STEP file written by hand from ISO 10303-21 for the kernel regression case of tangency-labs/solidcraft#3730 | MIT OR Apache-2.0 |
| tests/kernel-cases/import/3880-cylinder-seam-edge/input.step | step-conformance contributors | copy of tests/step-conformance/cylinder_seam.step (generated from formulas by https://github.com/dan335/step-conformance, corpus/generated, 96f30bb); kernel regression case for tangency-labs/solidcraft#3880 | CC0-1.0 |
| tests/kernel-cases/import/3880-nurbs-hemisphere-dome/input.step | step-conformance contributors | copy of tests/step-conformance/dome_nurbs.step (generated from formulas by https://github.com/dan335/step-conformance, corpus/generated, 96f30bb); kernel regression case for tangency-labs/solidcraft#3880 | CC0-1.0 |
| tests/kernel-cases/import/3963-closed-spline-edge-vertex-past-start/input.step | SolidCraft contributors | synthetic STEP file written by hand from ISO 10303-21 for the kernel regression case of tangency-labs/solidcraft#3963 | MIT OR Apache-2.0 |
| tests/kernel-cases/import/4005-cylinder-written-as-near-zero-cone/input.step | SolidCraft contributors | synthetic STEP file written by hand from ISO 10303-21 for the kernel regression case of tangency-labs/solidcraft#4005 | MIT OR Apache-2.0 |
| tests/kernel-cases/import/4006-plane-written-as-cone-of-nearly-right-angle/input.step | SolidCraft contributors | synthetic STEP file written by hand from ISO 10303-21 for the kernel regression case of tangency-labs/solidcraft#4006 | MIT OR Apache-2.0 |
| tests/ssi-corpus/cases/*.json.gz, tests/ssi-corpus/LICENSE-MIT, tests/ssi-corpus/LICENSE-APACHE | ssi-corpus contributors (jyviko) | 119 surface/surface intersection cases with exact ground truth from https://github.com/jyviko/ssi-corpus (cases/data, b04c8a6), gzip-compressed, unchanged; SSI scorer fixtures (tests/ssi-corpus/README.md) | MIT OR Apache-2.0 |
| tests/ssi-corpus/cases/y23_*.json.gz | Yang, Jia and Yan (paper authors: published surfaces, figures and topology); ssi-corpus contributors (reconstructions and truth) | 25 cases built from Yang, Jia & Yan 2023, "Topology Guaranteed B-Spline Surface/Surface Intersection", ACM Transactions on Graphics 42(6), Article 211; each cites the paper in its `source` field | CC-BY 4.0 (paper); MIT OR Apache-2.0 (case files) |
| tests/step-regressions/rod_doubled_edge.step | SolidCraft contributors | written by SolidCraft from the commands of #4598 (a bored rod moved 100 mm and exported); import regression fixture | MIT OR Apache-2.0 |
| tests/oracle/17-loft/reference.stl | SolidCraft contributors | triangulation of our own recipe (tests/oracle/17-loft/recipe.json) built with FreeCAD as an external tool by tools/freecad-oracle | MIT OR Apache-2.0 |
| tests/oracle/23-bracket-multifeature/reference.stl | SolidCraft contributors | triangulation of our own recipe (tests/oracle/23-bracket-multifeature/recipe.json) built with FreeCAD as an external tool by tools/freecad-oracle | MIT OR Apache-2.0 |
@@ -128,14 +144,14 @@ Editable drawing code, native projects and shipped exports are collected under `
| assets/fonts/ibm-plex-mono/OFL.txt | IBM Corp. | Unmodified accompanying font licence | SIL OFL 1.1 |
| assets/fonts/ibm-plex-sans/OFL.txt | IBM Corp. | Unmodified accompanying font licence | SIL OFL 1.1 |
| assets/fonts/liberation-sans/OFL.txt | Red Hat, Inc.; Liberation Fonts contributors | Unmodified accompanying font licence | SIL OFL 1.1 |
| assets/icons/app/linux/exports/hicolor/128x128/apps/io.tangencylabs.solidcraft.png | SolidCraft contributors | Generated from assets/icons/app/shared/source/app_icon.rs with the original CLI/ICO encoders | MIT OR Apache-2.0 |
| assets/icons/app/linux/exports/hicolor/16x16/apps/io.tangencylabs.solidcraft.png | SolidCraft contributors | Generated from assets/icons/app/shared/source/app_icon.rs with the original CLI/ICO encoders | MIT OR Apache-2.0 |
| assets/icons/app/linux/exports/hicolor/24x24/apps/io.tangencylabs.solidcraft.png | SolidCraft contributors | Generated from assets/icons/app/shared/source/app_icon.rs with the original CLI/ICO encoders | MIT OR Apache-2.0 |
| assets/icons/app/linux/exports/hicolor/256x256/apps/io.tangencylabs.solidcraft.png | SolidCraft contributors | Generated from assets/icons/app/shared/source/app_icon.rs with the original CLI/ICO encoders | MIT OR Apache-2.0 |
| assets/icons/app/linux/exports/hicolor/32x32/apps/io.tangencylabs.solidcraft.png | SolidCraft contributors | Generated from assets/icons/app/shared/source/app_icon.rs with the original CLI/ICO encoders | MIT OR Apache-2.0 |
| assets/icons/app/linux/exports/hicolor/48x48/apps/io.tangencylabs.solidcraft.png | SolidCraft contributors | Generated from assets/icons/app/shared/source/app_icon.rs with the original CLI/ICO encoders | MIT OR Apache-2.0 |
| assets/icons/app/linux/exports/hicolor/512x512/apps/io.tangencylabs.solidcraft.png | SolidCraft contributors | Generated from assets/icons/app/shared/source/app_icon.rs with the original CLI/ICO encoders | MIT OR Apache-2.0 |
| assets/icons/app/linux/exports/hicolor/64x64/apps/io.tangencylabs.solidcraft.png | SolidCraft contributors | Generated from assets/icons/app/shared/source/app_icon.rs with the original CLI/ICO encoders | MIT OR Apache-2.0 |
| assets/icons/app/linux/exports/hicolor/128x128/apps/ai.storyteller.solidcraft.png | SolidCraft contributors | Generated from assets/icons/app/shared/source/app_icon.rs with the original CLI/ICO encoders | MIT OR Apache-2.0 |
| assets/icons/app/linux/exports/hicolor/16x16/apps/ai.storyteller.solidcraft.png | SolidCraft contributors | Generated from assets/icons/app/shared/source/app_icon.rs with the original CLI/ICO encoders | MIT OR Apache-2.0 |
| assets/icons/app/linux/exports/hicolor/24x24/apps/ai.storyteller.solidcraft.png | SolidCraft contributors | Generated from assets/icons/app/shared/source/app_icon.rs with the original CLI/ICO encoders | MIT OR Apache-2.0 |
| assets/icons/app/linux/exports/hicolor/256x256/apps/ai.storyteller.solidcraft.png | SolidCraft contributors | Generated from assets/icons/app/shared/source/app_icon.rs with the original CLI/ICO encoders | MIT OR Apache-2.0 |
| assets/icons/app/linux/exports/hicolor/32x32/apps/ai.storyteller.solidcraft.png | SolidCraft contributors | Generated from assets/icons/app/shared/source/app_icon.rs with the original CLI/ICO encoders | MIT OR Apache-2.0 |
| assets/icons/app/linux/exports/hicolor/48x48/apps/ai.storyteller.solidcraft.png | SolidCraft contributors | Generated from assets/icons/app/shared/source/app_icon.rs with the original CLI/ICO encoders | MIT OR Apache-2.0 |
| assets/icons/app/linux/exports/hicolor/512x512/apps/ai.storyteller.solidcraft.png | SolidCraft contributors | Generated from assets/icons/app/shared/source/app_icon.rs with the original CLI/ICO encoders | MIT OR Apache-2.0 |
| assets/icons/app/linux/exports/hicolor/64x64/apps/ai.storyteller.solidcraft.png | SolidCraft contributors | Generated from assets/icons/app/shared/source/app_icon.rs with the original CLI/ICO encoders | MIT OR Apache-2.0 |
| assets/icons/app/shared/source/app_icon.rs | SolidCraft contributors | Original SolidCraft drawing code: the borderless mark, drawn from the faces and gradients of assets/icons/app/macos/source/SolidCraft.icon/Assets/03-solid-blue-cutout.svg | MIT OR Apache-2.0 |
| assets/icons/app/shared/source/windows_ico.rs | SolidCraft contributors | Original SolidCraft resource data or drawing code, collected without redesign | MIT OR Apache-2.0 |
| assets/icons/app/windows/exports/solidcraft-executable.ico | SolidCraft contributors | Generated from assets/icons/app/shared/source/app_icon.rs with the original CLI/ICO encoders | MIT OR Apache-2.0 |
@@ -171,9 +187,9 @@ Editable drawing code, native projects and shipped exports are collected under `
| assets/locales/zh.json | SolidCraft contributors | Original SolidCraft resource data or drawing code, collected without redesign | MIT OR Apache-2.0 |
| assets/locales/zh-TW.json | SolidCraft contributors | Original Traditional Chinese (Taiwan) translation of SolidCraft's English catalog; no commercial CAD text used | MIT OR Apache-2.0 |
| assets/materials/library.rs | SolidCraft contributors | Original SolidCraft resource data or drawing code, collected without redesign | MIT OR Apache-2.0 |
| assets/platforms/macos/dmg/background.tiff | SolidCraft contributors | original disk image window background (blueprint sheet: grid, double border, circles, centre lines, leader arrow, title block) drawn by assets/platforms/macos/dmg/make_background.py in IBM Plex Sans/Mono; 1x and 2x representations | MIT OR Apache-2.0 |
| assets/platforms/macos/dmg/make_background.py | SolidCraft contributors | authoring script that draws the disk image background (Pillow); not part of any build | MIT OR Apache-2.0 |
| assets/platforms/macos/dmg/layout.json | SolidCraft contributors | disk image window size, icon size and icon positions shared by the background script and settings.py | MIT OR Apache-2.0 |
@@ -292,53 +308,6 @@ Editable drawing code, native projects and shipped exports are collected under `
| assets/icons/ui/design/svg/model/colored_components_off.svg | SolidCraft contributors | original icon master (64 grid) | MIT OR Apache-2.0 |
| assets/icons/ui/design/svg/model/combine.svg | SolidCraft contributors | two-tone modelling icon master (64 grid), original SolidCraft artwork | MIT OR Apache-2.0 |
| assets/icons/ui/design/svg/model/component.svg | SolidCraft contributors | two-tone modelling icon master (64 grid), original SolidCraft artwork | MIT OR Apache-2.0 |
### Render workspace icon drafts
Original SolidCraft drawings, Open for owner review; no runtime assignments.
| File | Author | Source | Licence |
|---|---|---|---|
| assets/icons/ui/design/svg/model/render_all_shots.svg | SolidCraft contributors | original Camera icon master (64 grid): stacked camera bodies with a lower-right play badge | MIT OR Apache-2.0 |
| assets/icons/ui/design/svg/model/render_appearance.svg | SolidCraft contributors | original Looks icon master (64 grid): shaded look sphere on the top corner of an accent-shaded cube | MIT OR Apache-2.0 |
| assets/icons/ui/design/svg/model/render_aspect_frame.svg | SolidCraft contributors | original Camera icon master (64 grid): wide rounded frame with two opposite corner brackets | MIT OR Apache-2.0 |
| assets/icons/ui/design/svg/model/render_backdrop.svg | SolidCraft contributors | original Studio icon master (64 grid): grey cube in front of a tall upright accent panel | MIT OR Apache-2.0 |
| assets/icons/ui/design/svg/model/render_cancel.svg | SolidCraft contributors | original Output icon master (64 grid): picture with a lower-right round stop badge | MIT OR Apache-2.0 |
| assets/icons/ui/design/svg/model/render_check.svg | SolidCraft contributors | original Output icon master (64 grid): picture with a lower-right round check badge | MIT OR Apache-2.0 |
| assets/icons/ui/design/svg/model/render_compare.svg | SolidCraft contributors | original Output icon master (64 grid): two grey pictures split by a vertical slider with opposed arrows | MIT OR Apache-2.0 |
| assets/icons/ui/design/svg/model/render_copy_look.svg | SolidCraft contributors | original Looks icon master (64 grid): look sphere in a square frame offset from a second frame outline | MIT OR Apache-2.0 |
| assets/icons/ui/design/svg/model/render_execute.svg | SolidCraft contributors | original Output icon master (64 grid): picture with a lower-right round play badge | MIT OR Apache-2.0 |
| assets/icons/ui/design/svg/model/render_export_image.svg | SolidCraft contributors | original Output icon master (64 grid): picture with a large outward diagonal arrow at the upper right | MIT OR Apache-2.0 |
| assets/icons/ui/design/svg/model/render_exposure.svg | SolidCraft contributors | original Camera icon master (64 grid): split light and accent disc with plus and minus marks | MIT OR Apache-2.0 |
| assets/icons/ui/design/svg/model/render_fit_product.svg | SolidCraft contributors | original Camera icon master (64 grid): grey cube inside four corner brackets | MIT OR Apache-2.0 |
| assets/icons/ui/design/svg/model/render_frame_guides.svg | SolidCraft contributors | original Camera icon master (64 grid): rounded frame with a rule-of-thirds grid and four accent nodes | MIT OR Apache-2.0 |
| assets/icons/ui/design/svg/model/render_from_material.svg | SolidCraft contributors | original Looks icon master (64 grid): look sphere struck through above a plain grey slab | MIT OR Apache-2.0 |
| assets/icons/ui/design/svg/model/render_ground.svg | SolidCraft contributors | original Studio icon master (64 grid): grey cube on a slab with an accent contact patch | MIT OR Apache-2.0 |
| assets/icons/ui/design/svg/model/render_lens.svg | SolidCraft contributors | original Camera icon master (64 grid): concentric lens rings around an accent centre | MIT OR Apache-2.0 |
| assets/icons/ui/design/svg/model/render_library.svg | SolidCraft contributors | original Studio icon master (64 grid): row of three look spheres, middle one accent, on a shelf bar | MIT OR Apache-2.0 |
| assets/icons/ui/design/svg/model/render_light_area.svg | SolidCraft contributors | original Lights icon master (64 grid): slanted flat panel above a dotted accent stem | MIT OR Apache-2.0 |
| assets/icons/ui/design/svg/model/render_light_by_highlight.svg | SolidCraft contributors | original Lights icon master (64 grid): shaded sphere with a ringed highlight target and dotted stem arriving from above | MIT OR Apache-2.0 |
| assets/icons/ui/design/svg/model/render_light_point.svg | SolidCraft contributors | original Lights icon master (64 grid): round source disc with centre dot above a dotted accent stem | MIT OR Apache-2.0 |
| assets/icons/ui/design/svg/model/render_light_spot.svg | SolidCraft contributors | original Lights icon master (64 grid): cone source with curved rim above a dotted accent stem | MIT OR Apache-2.0 |
| assets/icons/ui/design/svg/model/render_lighting_presets.svg | SolidCraft contributors | original Studio icon master (64 grid): two stacked cards, the front one holding a light bulb | MIT OR Apache-2.0 |
| assets/icons/ui/design/svg/model/render_output_size.svg | SolidCraft contributors | original Output icon master (64 grid): picture frame with a diagonal double-headed dimension arrow | MIT OR Apache-2.0 |
| assets/icons/ui/design/svg/model/render_paint.svg | SolidCraft contributors | original Looks icon master (64 grid): flat brush with an accent tip, light ferrule and slate handle | MIT OR Apache-2.0 |
| assets/icons/ui/design/svg/model/render_pick_up.svg | SolidCraft contributors | original Looks icon master (64 grid): eyedropper with a grey bulb, slate crossbar and accent sampling tip | MIT OR Apache-2.0 |
| assets/icons/ui/design/svg/model/render_quality.svg | SolidCraft contributors | original Output icon master (64 grid): three rising bars, the tallest in accent | MIT OR Apache-2.0 |
| assets/icons/ui/design/svg/model/render_replace_all.svg | SolidCraft contributors | original Looks icon master (64 grid): grey sample sphere with an arrow to an accent sphere beside a second one | MIT OR Apache-2.0 |
| assets/icons/ui/design/svg/model/render_results.svg | SolidCraft contributors | original Output icon master (64 grid): stack of two pictures, the front one showing a landscape | MIT OR Apache-2.0 |
| assets/icons/ui/design/svg/model/render_same_look.svg | SolidCraft contributors | original Looks icon master (64 grid): look sphere and three cubes, the two matching cubes ringed | MIT OR Apache-2.0 |
| assets/icons/ui/design/svg/model/render_shot.svg | SolidCraft contributors | original Camera icon master (64 grid): camera body with a lower-right plus badge | MIT OR Apache-2.0 |
| assets/icons/ui/design/svg/model/render_shots_strip.svg | SolidCraft contributors | original Camera icon master (64 grid): strip of three small frames, the middle one in accent | MIT OR Apache-2.0 |
| assets/icons/ui/design/svg/model/render_solo_light.svg | SolidCraft contributors | original Lights icon master (64 grid): point source and dotted stem inside four corner focus brackets | MIT OR Apache-2.0 |
| assets/icons/ui/design/svg/model/render_sun.svg | SolidCraft contributors | original Lights icon master (64 grid): source disc with eight short radial rays | MIT OR Apache-2.0 |
| assets/icons/ui/design/svg/model/render_transparent_background.svg | SolidCraft contributors | original Output icon master (64 grid): grey cube on a checker tile | MIT OR Apache-2.0 |
| assets/icons/ui/design/svg/model/render_update_shot.svg | SolidCraft contributors | original Camera icon master (64 grid): camera body with a lower-right refresh badge | MIT OR Apache-2.0 |
### UI icon masters (continued)
| File | Author | Source | Licence |
|---|---|---|---|
| assets/icons/ui/design/svg/model/compute.svg | SolidCraft contributors | two-tone modelling icon master (64 grid), original SolidCraft artwork | MIT OR Apache-2.0 |
| assets/icons/ui/design/svg/model/configuration_table.svg | SolidCraft contributors | two-tone modelling icon master (64 grid), original SolidCraft artwork | MIT OR Apache-2.0 |
| assets/icons/ui/design/svg/model/conic.svg | SolidCraft contributors | two-tone modelling icon master (64 grid), original SolidCraft artwork | MIT OR Apache-2.0 |
@@ -428,21 +397,6 @@ Original SolidCraft drawings, Open for owner review; no runtime assignments.
| assets/icons/ui/design/svg/flat/shield.svg | SolidCraft contributors | original icon master (64 grid) | MIT OR Apache-2.0 |
| assets/icons/ui/design/svg/model/status_recovery.svg | SolidCraft contributors | original icon master (64 grid) | MIT OR Apache-2.0 |
| assets/icons/ui/design/svg/model/frame_member.svg | SolidCraft contributors | original icon master (64 grid) | MIT OR Apache-2.0 |
| assets/icons/ui/design/svg/model/render_environment.svg | SolidCraft contributors | original Studio icon master (64 grid): dome with a grey cube inside | MIT OR Apache-2.0 |
| assets/icons/ui/design/svg/flat/style_shaded.svg | SolidCraft contributors | original icon master (64 grid) | MIT OR Apache-2.0 |
| assets/icons/ui/design/svg/flat/style_wireframe.svg | SolidCraft contributors | original icon master (64 grid) | MIT OR Apache-2.0 |
| assets/icons/ui/design/svg/flat/style_hidden_edges.svg | SolidCraft contributors | original icon master (64 grid) | MIT OR Apache-2.0 |
| assets/icons/ui/design/svg/flat/style_translucent.svg | SolidCraft contributors | original icon master (64 grid) | MIT OR Apache-2.0 |
| assets/icons/ui/design/svg/flat/select_faces_edges.svg | SolidCraft contributors | original icon master (64 grid) | MIT OR Apache-2.0 |
| assets/icons/ui/design/svg/flat/select_bodies.svg | SolidCraft contributors | original icon master (64 grid) | MIT OR Apache-2.0 |
| assets/icons/ui/design/svg/flat/select_features.svg | SolidCraft contributors | original icon master (64 grid) | MIT OR Apache-2.0 |
| assets/icons/ui/design/svg/flat/select_parts.svg | SolidCraft contributors | original icon master (64 grid) | MIT OR Apache-2.0 |
| assets/icons/ui/design/svg/flat/select_components.svg | SolidCraft contributors | original icon master (64 grid) | MIT OR Apache-2.0 |
| assets/icons/ui/design/svg/flat/select_sketch.svg | SolidCraft contributors | original icon master (64 grid) | MIT OR Apache-2.0 |
| assets/icons/ui/design/svg/flat/display.svg | SolidCraft contributors | original icon master (64 grid) | MIT OR Apache-2.0 |
| assets/icons/ui/design/svg/flat/grid.svg | SolidCraft contributors | original icon master (64 grid) | MIT OR Apache-2.0 |
| assets/icons/ui/design/svg/flat/ground_shadow.svg | SolidCraft contributors | original icon master (64 grid) | MIT OR Apache-2.0 |
| assets/icons/ui/design/svg/flat/ambient_occlusion.svg | SolidCraft contributors | original icon master (64 grid) | MIT OR Apache-2.0 |
| assets/icons/ui/design/svg/model/placeholder.svg | SolidCraft contributors | two-tone modelling icon master (64 grid), original SolidCraft artwork | MIT OR Apache-2.0 |
| assets/icons/ui/design/svg/model/plane.svg | SolidCraft contributors | two-tone modelling icon master (64 grid), original SolidCraft artwork | MIT OR Apache-2.0 |
| assets/icons/ui/design/svg/model/plane_angle.svg | SolidCraft contributors | two-tone modelling icon master (64 grid), original SolidCraft artwork | MIT OR Apache-2.0 |
@@ -592,16 +546,6 @@ Original SolidCraft drawings, Open for owner review; no runtime assignments.
| assets/icons/ui/design/svg/model/cone.svg | SolidCraft contributors | original icon master (64 grid) | MIT OR Apache-2.0 |
| assets/locales/ar.json | Abdullah (A-AL-ANAZI) | Original Arabic translation of SolidCraft's English catalog; no commercial CAD text used | MIT OR Apache-2.0 |
| assets/locales/he.json | SolidCraft contributors | Original Hebrew translation of SolidCraft's English catalog; no commercial CAD text used | MIT OR Apache-2.0 |
| assets/styles/ui/themes/cga.json | SolidCraft contributors | original SolidCraft theme file using the 16 colours of the IBM Color Graphics Adapter (black, cyan, magenta, and white of its high-intensity palette 1 for the interface) | MIT OR Apache-2.0 |
| assets/styles/ui/themes/1-bit.json | SolidCraft contributors | original SolidCraft theme file | MIT OR Apache-2.0 |
| assets/styles/ui/themes/1-bit-dark.json | SolidCraft contributors | original SolidCraft theme file | MIT OR Apache-2.0 |
| `assets/locales/pending/navbar-customisation.json` | SolidCraft contributors | Original navigation bar editor translations | MIT OR Apache-2.0 |
| `assets/locales/pending/navbar-slots.json` | SolidCraft contributors | Original navigation slot translations | MIT OR Apache-2.0 |
| assets/locales/bs.json | Tarik Sijercic (tsijercic1) | Original Bosnian translation of SolidCraft's English catalog; no commercial CAD text used | MIT OR Apache-2.0 |
| assets/locales/hr.json | Tarik Sijercic (tsijercic1) | Original Croatian translation of SolidCraft's English catalog; no commercial CAD text used | MIT OR Apache-2.0 |
| assets/locales/sr.json | Tarik Sijercic (tsijercic1) | Original Serbian (ekavian, Cyrillic) translation of SolidCraft's English catalog; no commercial CAD text used | MIT OR Apache-2.0 |
| assets/icons/ui/design/svg/model/finish_edit.svg | SolidCraft contributors | original icon master (64 grid) | MIT OR Apache-2.0 |
| `assets/locales/pending/sketch-tracking-guides.json` | SolidCraft contributors | Original alignment-guide preference labels and help text | MIT OR Apache-2.0 |
| vendor/truck-shapeops | truck-shapeops 0.4.0, https://github.com/ricosjp/truck (RICOS Co. Ltd.) | Apache-2.0 | robust meshing and nearest-parameter fallback in booleans; degenerate intersection-curve rejection; face and edge history of booleans; trace macro; corner choice at vertices several intersection curves end on; reuse of an operand's meshes (vendor/README.md) |
| vendor/truck-geometry | truck-geometry 0.5.0, https://github.com/ricosjp/truck (RICOS Co. Ltd.) | Apache-2.0 | intersection curves divided from their neighbours' surface parameters; surface second derivatives (vendor/README.md) |
The naming corpus checks persistent names: every name a corpus design stores still finds a face or
an edge, and two builds name its faces and edges alike
(`cargo test --profile ci -p solidcraft-cli --test naming_corpus`).
[docs/mutation-testing.md](docs/mutation-testing.md) shows how to find kernel behaviour these
black-box suites miss.
@@ -220,8 +221,7 @@ Pull requests skip a few heavy tests (one to twelve minutes each), which run in
Check that validation after merging. They are listed in
`.config/nextest.toml` and the [testing page](docs/book/src/dev/testing.md):
- `solidcraft-engine`: `tests::hostile_params_never_panic`, everything in `tests::robustness` and
the seeds of `tests::robustness_goldens` (`seed_00` … `seed_95`; pull requests that change the kernel, truck or the goldens run all but the slowest, `SLOW_SEEDS` in `ci.yml`),
- `solidcraft-engine`: `tests::hostile_params_never_panic`, everything in `tests::robustness`,
- **Parameters and configurations** with unit-aware expressions.
- **Assemblies** with joints, motion studies, contact sets, interference and mass properties.
- **Sheet metal** with flanges, hems, fold/unfold and flat patterns, and plastic enclosure features.
- **Files:** STEP, IGES, 3MF, STL, OBJ and glTF in and out where supported, URDF export, `.sc` designs (`.solidcraft` files from earlier releases still open).
- **Files:** STEP, IGES, 3MF, STL, OBJ and glTF in and out where supported, URDF export, `.solidcraft` designs.
- **Desktop app, browser app, headless CLI and MCP server**, all running the same commands.
The full list is in [docs/capabilities.md](docs/capabilities.md) and [docs/features.md](docs/features.md);
@@ -121,12 +121,6 @@ the clean-room and licence rules, and where help is wanted most. Open work is in
SolidCraft's continuous integration runs on [Blacksmith](https://www.blacksmith.sh), which
sponsors its CI minutes.
## Disclaimer
The files in this repository are provided as is, without warranty, liability or indemnity, and
Tangency Labs and the contributors accept no responsibility for any harmful or unlawful use of
them: read [DISCLAIMER.md](DISCLAIMER.md).
## Licence
MIT OR Apache-2.0, at your option. Developed under the
constUSAGE_RUN: &str=" solidcraft-cli run <script.json|design.sc|part.step> [--in design.sc|part.step] [--out FILE]... [--save FILE] [--quiet] [--results] [--timings] [--profile] [--json-out FILE] [--allow-errors]\n solidcraft-cli run --in <design.sc|part.step> [--out FILE]...\n (a timeline feature that fails fails the run and nothing is written; --allow-errors writes anyway)\n (--timings prints {timings: [{index, command, ms}], total_ms} for a script, with --results its results too;\n --profile adds each command's profile: {boolean_ms, tessellate_ms, other_ms}, the kernel's share)\n";
constUSAGE_RUN: &str=" solidcraft-cli run <script.json|design.solidcraft|part.step> [--in design.solidcraft|part.step] [--out FILE]... [--save FILE] [--quiet] [--results] [--timings] [--profile] [--profile-out trace.json] [--json-out FILE] [--allow-errors] [--validation each_step|each_feature|off]\n solidcraft-cli run --in <design.solidcraft|part.step> [--out FILE]...\n (a timeline feature that fails fails the run and nothing is written; --allow-errors writes anyway)\n (--validation: when SMLib's full check runs on the features computed (diagnostics.validation), default each_feature)\n (--timings prints {timings: [{index, command, ms}], total_ms} for a script, with --results its results too;\n --profile adds each command's profile: {boolean_ms, tessellate_ms, other_ms}, the kernel's share)\n (--profile also records where the time goes, SMLib's calls, kernel operations, features, commands and import stages,\n and prints the table to stderr: count, total, self time and longest per span; --profile-out FILE writes the spans\n as a Chrome trace for chrome://tracing or ui.perfetto.dev; SOLIDCRAFT_PROFILE=1 does the same for any command)\n";
/// `eval`'s lines in the usage.
constUSAGE_EVAL: &str=" solidcraft-cli eval <script.json|design.sc|part.step> [--in design.sc|part.step] [--json-out FILE] (alias: inspect)\n solidcraft-cli eval --in <script.json|design.sc|part.step> [--json-out FILE]\n (with both inputs, runs the positional script on --in before measuring; does not automatically save the modified design)\n (--json-out FILE writes the JSON that run (with --results, else the measurement) and eval print to FILE instead of stdout,\n as plain UTF-8: a shell's > can re-encode it, e.g. Windows PowerShell adds a byte-order mark)\n";
constUSAGE_EVAL: &str=" solidcraft-cli eval <script.json|design.solidcraft|part.step> [--in design.solidcraft|part.step] [--json-out FILE] [--profile] [--profile-out trace.json] (alias: inspect)\n solidcraft-cli eval --in <script.json|design.solidcraft|part.step> [--json-out FILE]\n (with both inputs, runs the positional script on --in before measuring; does not automatically save the modified design)\n (--json-out FILE writes the JSON that run (with --results, else the measurement) and eval print to FILE instead of stdout,\n as plain UTF-8: a shell's > can re-encode it, e.g. Windows PowerShell adds a byte-order mark)\n (--profile and --profile-out as for run)\n";
/// `script`'s lines in the usage.
constUSAGE_SCRIPT: &str=" solidcraft-cli script <design.sc|script.json> [--out script.json]\n (the design's history as a command script that eval and run replay)\n";
constUSAGE_SCRIPT: &str=" solidcraft-cli script <design.solidcraft|script.json> [--out script.json]\n (the design's history as a command script that eval and run replay)\n";
/// `bench-open`'s lines in the usage.
constUSAGE_BENCH_OPEN: &str=" solidcraft-cli bench-open <design.sc | part.step> [--parse-only] [--save OUT.sc] [--display LEVEL [--edit NAME EXPR]] [--ops script.json]\n (--ops: after opening, run each command of the script and undo it, timing the command, the\n evaluations it caused and the view it leaves: placing and meshing what changed)\n";
constUSAGE_BENCH_OPEN: &str=" solidcraft-cli bench-open <design.solidcraft | part.step> [--parse-only] [--save OUT.solidcraft] [--display LEVEL [--edit NAME EXPR]] [--ops script.json] [--profile] [--profile-out trace.json]\n (--profile and --profile-out as for run)\n (--ops: after opening, run each command of the script and undo it, timing the command, the\n evaluations it caused and the view it leaves: placing and meshing what changed)\n";
constUSAGE_SNAPSHOT: &str=" solidcraft-cli snapshot <script|design> [--in design.sc|part.step] --out shot.png [--width W] [--height H] [--view NAME | --camera JSON] [--no-grid] [--no-axes]\n [--body NAME:opacity=0.3,color=#rrggbb]... [--tool NAME]... [--section z=27]\n solidcraft-cli snapshot --in <design.sc|part.step> --out shot.png ...\n (as with run, --in starts from a design and the script runs on top of it; an option snapshot doesn't take is an error;\n --view: iso, front, back, top, bottom, left, right, or the name of a view saved in the design with view.save;\n --camera: {target: [x,y,z], yaw, pitch, distance, fov?} in mm and radians, as the MCP screenshot takes it (docs/mcp.md);\n --no-grid and --no-axes leave the ground grid (on Z 0) and the origin's axes out of the picture;\n --body: how one body is drawn, as appearance.assign takes it: opacity 0-1 (below 1 is see-through, so what is inside\n it shows) and color #rrggbb, either or both, once per body;\n --tool: draw this body solid in the tool colour and every other body see-through, so a cut's or a join's tool body\n is visible inside the material it meets; a later --body overrides it;\n --section: cut the model as inspect.section does, so the inside shows: z=27 (the plane through that world\n coordinate, keeping the smaller side), add ,flip to keep the other side, or XY, XZ, YZ, or its own JSON)\n";
constUSAGE_SNAPSHOT: &str=" solidcraft-cli snapshot <script|design> [--in design.solidcraft|part.step] --out shot.png [--width W] [--height H] [--view NAME | --camera JSON] [--no-grid] [--no-axes]\n [--body NAME:opacity=0.3,color=#rrggbb]... [--tool NAME]... [--section z=27] [--quality coarse|normal|fine|ultra]\n solidcraft-cli snapshot --in <design.solidcraft|part.step> --out shot.png ...\n (as with run, --in starts from a design and the script runs on top of it; an option snapshot doesn't take is an error;\n --view: iso, front, back, top, bottom, left, right, or the name of a view saved in the design with view.save;\n --camera: {target: [x,y,z], yaw, pitch, distance, fov?} in mm and radians, as the MCP screenshot takes it (docs/mcp.md);\n --no-grid and --no-axes leave the ground grid (on Z 0) and the origin's axes out of the picture;\n --body: how one body is drawn, as appearance.assign takes it: opacity 0-1 (below 1 is see-through, so what is inside\n it shows) and color #rrggbb, either or both, once per body;\n --tool: draw this body solid in the tool colour and every other body see-through, so a cut's or a join's tool body\n is visible inside the material it meets; a later --body overrides it;\n --section: cut the model as inspect.section does, so the inside shows: z=27 (the plane through that world\n coordinate, keeping the smaller side), add ,flip to keep the other side, or XY, XZ, YZ, or its own JSON;\n --quality: the display quality the bodies are meshed at, as the app's setting (default normal))\n";
constUSAGE_KERNEL_CASES: &str=" solidcraft-cli kernel-cases <case-dir>... [--json] [--dumps=DIR] [--validation=each_step|each_feature|off]\n (the kernel regression rig, tests/kernel-cases, on SMLib; --dumps: each case's\n failing SMLib calls leave their inputs for replay in DIR/<area>-<case>; --validation: when SMLib's\n full check runs (diagnostics.validation), default each_feature)\n";
out.push(format!("{n} at {x:?}, then {m} at {y:?}"));
}
}
for((r,_),(q,_))ina.refs.iter().zip(&b.refs){
ifr!=q{
out.push(format!("{r}, then {q}"));
}
}
ifa.refs.len()!=b.refs.len(){
out.push(format!("{} stored names, then {}",a.refs.len(),b.refs.len()));
}
out.truncate(cap);
out
}
/// Designs whose names differ from one build to the next today: (design, why). Their
/// differences are printed, not failed on, until the cause is fixed; a stored name that finds
/// nothing still fails.
constUNSTABLE: [(&str,&str);1]=[(
"regressions/closed_sweep_torus_cut",
"the halves of each swept wall lie level along every axis, so which is `#1` and which `#2` follows the order the kernel gives the faces in, which changes from one build to the next",
"Mozilla/5.0 (iPhone; CPU iPhone OS 18_5 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/18.5 Mobile/15E148 Safari/604.1";
letmac="Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/18.5 Safari/605.1.15";
letchrome_ios="Mozilla/5.0 (iPhone; CPU iPhone OS 18_5 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) CriOS/138.0.7204.156 Mobile/15E148 Safari/604.1";
letchrome="Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/141.0.0.0 Safari/537.36";
assert!(apple_touch(iphone,5));
assert!(apple_touch(chrome_ios,5),"every browser on iOS has the same picker");
assert!(apple_touch(mac,5),"an iPad presents itself as a Mac");
assert!(!apple_touch(mac,0),"a Mac has no touch screen");
assert!(!apple_touch(chrome,10),"a touch screen elsewhere filters as before");
assert!(!apple_touch("",0),"hostile input is just not an iPhone");
| AppImage | Uses the Linux 256 px image and `.DirIcon` alias |
| FreeBSD | Shares Linux hicolor images and freedesktop metadata |
| Web | HTML/Trunk and `manifest.webmanifest` stay in `apps/solidcraft-web/`; copies Japanese font/licence to `fonts/`, uses the collected CSS, and copies the Linux 32/256/512 px images to `icons/` for the favicon and installed app |
All ids below are **Open** for owner review, except `render_scene` and `render_image`,
which are existing accepted icons used only as references. No commands, toolbar
entries, browser selectors or runtime request manifests are changed by this draft set.
`render_remove_override` is the one remaining alias (of `render_from_material`);
`render_execute`, `render_environment` and `render_fit_product` now have their own
masters in `design/svg/model/`. Accepted source masters stay unchanged.
Review with `python3 -B assets/icons/ui/design/tools/icon_status.py --serve`,
search `render_`, and select Open. See [STYLE_GUIDE.md](STYLE_GUIDE.md) for
acceptance; drafts do not imply implemented commands.
The finished references in each row were read and previewed in both themes
before authoring. Draft contact sheets (96, 24 and 16 px, both themes) are local
review evidence, not shipped assets. The icons are grouped in five families, each
with one shared design rule.
## Lights
Rule: a slate source glyph with light passive fill, 2.55-unit outlines and a dotted
accent stem (three dots, 4.25 diameter, 7 units apart) showing the direction.
| Meaning | Id | Finished references | Drawing |
|---|---|---|---|
| Light area | `render_light_area` | `box`, `camera` | Slanted flat panel on the canonical axes above the dotted stem. |
| Light spot | `render_light_spot` | `camera`, `material` | Cone with a curved rim above the dotted stem. |
| Light point | `render_light_point` | `camera`, `material` | Round source disc with a centre dot above the dotted stem. |
| Sun | `render_sun` | `sphere`, `camera` | Source disc of the same size with eight short radial rays instead of a stem. |
| Light by highlight | `render_light_by_highlight` | `sphere`, `material` | Shaded sphere with a ringed highlight target; the dotted stem arrives from above. |
| Solo light | `render_solo_light` | `fit`, `camera` | Point source and stem inside four corner focus brackets. |
## Looks
Rule: the lit look sphere (top-left highlight, bottom-right shade) plus one cue that
says what happens to it; receiving bodies stay canonical grey or cube shapes.
| Meaning | Id | Finished references | Drawing |
|---|---|---|---|
| Appearance | `render_appearance` | `material`, `box` | Shaded look sphere on the top corner of an accent-shaded cube: a look assigned to a body. |
| Paint | `render_paint` | `material`, `paste` | Flat brush with an accent tip, light ferrule and slate handle. |
| Pick up | `render_pick_up` | `material`, `copy` | Eyedropper with a grey bulb, slate crossbar and accent sampling tip. |
| Replace all | `render_replace_all` | `copy`, `box` | Grey sample sphere with an arrow to an accent sphere, beside a second accent sphere. |
| Copy look | `render_copy_look` | `material`, `copy` | Look sphere in a square frame, offset from a second frame outline. |
| Remove override | `render_remove_override` | `appearance`, `box` | Alias of `render_from_material`: the custom look is crossed off. |
| Same look | `render_same_look` | `select`, `box` | Look sphere and three cubes; the two matching cubes are ringed. |
| From material | `render_from_material` | `material`, `extrude` | Look sphere struck through above a plain grey slab, so the material shows. |
## Studio
Rule: the standard grey cube stands in the set-up it is lit or placed in.
| Meaning | Id | Finished references | Drawing |
|---|---|---|---|
| Library | `render_library` | `library`, `copy` | Row of three look spheres, the middle one accent, on a shelf bar. |
| Lighting presets | `render_lighting_presets` | `new`, `render_scene` | Two stacked cards, the front one holding a light bulb. |
| Environment | `render_environment` | `environment_map`, `render_scene` | Dome with a grey cube inside. |
| Ground | `render_ground` | `box`, `render_scene` | Grey cube on a slab with an accent contact patch. |
| Backdrop | `render_backdrop` | `render_scene`, `render_image` | Grey cube in front of a tall upright accent panel. |
## Camera and shots
Rule: one chunky camera body with a lower-right round badge for shot actions; the
other camera icons are simple frames.
| Meaning | Id | Finished references | Drawing |
|---|---|---|---|
| Shot | `render_shot` | `camera`, `new` | Camera body with a plus badge: save a shot. |
| Update shot | `render_update_shot` | `camera`, `undo` | Camera body with a refresh badge. |
| Render all shots | `render_all_shots` | `copy`, `render_image` | Stacked camera bodies with a play badge. |
| Shots strip | `render_shots_strip` | `camera`, `copy` | Strip of three small frames, the middle one in accent. |
| Fit product | `render_fit_product` | `fit`, `camera` | Grey cube inside four corner brackets. |
| Lens / field of view | `render_lens` | `camera`, `fit` | Concentric lens rings around an accent centre. |
| Exposure | `render_exposure` | `material`, `environment_map` | Disc split light and accent, with plus and minus marks. |
| Aspect frame | `render_aspect_frame` | `render_image`, `fit` | Wide rounded frame with two opposite corner brackets. |
| Frame guides | `render_frame_guides` | `render_image`, `fit` | Rounded frame with a rule-of-thirds grid and four accent nodes. |
## Output and result
Rule: one picture base (frame with landscape) with a lower-right round badge; the
size, background and quality icons draw their own simple subject.
| Meaning | Id | Finished references | Drawing |
|---|---|---|---|
| Render image | `render_execute` | `render_image`, `camera` | Picture with a play badge: create a rendered image. |
| Render output size | `render_output_size` | `render_image`, `fit` | Picture frame with a diagonal double-headed dimension arrow. |
| Transparent background | `render_transparent_background` | `material`, `render_image` | Grey cube on a checker tile. |
| Quality | `render_quality` | `list`, `library` | Three rising bars, the tallest in accent. |
| Check render | `render_check` | `render_image`, `new` | Picture with a check badge. |
| Cancel render | `render_cancel` | `render_image`, `delete` | Picture with a square stop badge. |
| Export image | `render_export_image` | `render_image`, `copy` | Picture with a large outward diagonal arrow at the upper right. |
| Compare | `render_compare` | `render_image`, `material` | Two grey pictures split by a vertical slider with opposed arrows. |
| Results | `render_results` | `render_image`, `copy` | Stack of two pictures, the front one showing a landscape. |
Some files were not shown because too many files have changed in this diff
Show More
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
jyviko
