* wip(render): reconcile completed material and image pipeline source with 0.20 (#5493) Source-only integration reference for staged review, not a merge-ready aggregate. Donor: 0xlillith/solidcraft@aea20b0115. Upstream:858e5995d6. Retain original CPU/material contracts and explicit GPU donor provenance in docs/render-materials-lab.md (#2067, #2191, #2780, #3306). Preserve released format migrations and current navigation/startup/shell behavior. New saved records use pending descriptors. The physical-card descriptor follows the maintainer's material-engineering-cards naming request, with a legacy-lab format-29 regression. Replace raw new panel hosts with shared containers. Repository checks, complete workspace/all-target Clippy, and the independent physical/resource authoring checks pass for this source. The fresh full local CI invocation has reached test compilation and is not yet complete. Do not transfer donor native output or prior test totals to this integration. Generated review screenshots, video, package ZIP and machine logs remain at the immutable personal evidence pin. Uncommitted geometric displacement is backed up separately, not silently included. No kernel/vendor change, direct main write, release or independent contributor-branch rewrite. Co-authored-by: Christian Svensson <blue@cmd.nu> * test(cli): pin the Compact camera-sample admission diagnostic (#5493) The bounded request still refuses 1024x1024x64 samples before host initialization and writes no output. Update only the stale expected diagnostic to the existing Compact budget wording; production limits and code are unchanged. Exact-tree CLI regression suite: 14 passed, 0 failed. The full repository gate has been invoked separately and is not yet complete. * Normalize UI container violation paths across platforms Report repository-relative paths with forward slashes so diagnostics and the existing nested-package regression assertions agree on Windows and Unix. Keep the container detection rules unchanged. Validation: official ui-containers gate and all seven focused xtask tests passed; rustfmt and diff checks passed. Only xtask/dependencies were compiled; no application build or heavy tests. (cherry picked from commit44b58d8e10) * fix(render): preserve camera contracts and correct acceptance regressions (#5493) Preserve Design view.apply semantics with a separate strict Render camera command. Retain existing translations when English-only aliases collide; add material-axis entries and camera-specific pitch labels. Compare complete validated engineering cards and retain job handles before cancellation. Focused and native acceptance is pinned to treef8a423b21f. Full CI has been invoked separately and is not claimed green. Landing follows the render integration policy in #5493. * fix(render): resolve showcase licence and upstream resource hygiene (#5493) Record SychPL's explicit MIT OR Apache-2.0 grant, retaining source/model bytes and the Ubuntu lettering notice. Remove 80 absent attribution rows, personal fork records, dead delivery attributes and three fork/resource-only workflows. Existing xtask assets now performs bounded offline hash checks and rejects orphan render attribution; no parallel draft CI or package installation. Original authoring reproduction remains explicit. Scoped xtask tests, assets, Clippy, formatting and prepared SELENE validation pass; no application or renderer-wide result is inferred. * fix(render): align saved bounds and progressive sample resolution (#5493) Address review r4364211669/r4364211677/r4364211681/r4364211691/r4364211695. Persisted light/frame domains respect the existing 1e9 document bound; related LED/rectangle/direction cases use the same bound. Workstation primary resolve shares the 4096 admission cap and film counters use checked conversions. Exact candidate: 485 CPU render tests, 21 render document tests and strict scoped Clippy pass, including positive boundary round trips and 2048/4096 end-to-end checkpoints. No released format/migration edits, relaxed test limits or full-stack acceptance claim. * wip(render): isolate optional resources and harden sample handling (#5493) Review work in progress: opt-in encoded render library with reproducible runtime catalog exports; native-only robust dependency through the workspace; checked bloom slices; per-sample point-light diagnostics; independent area-light spatial/film keys. Resource-module binaries in both configurations, generation, Cargo production feature graphs and attribution checks pass. Full engine/render regression and combined acceptance are pending: do not merge this donor as a constituent or treat scoped resource proof as runtime acceptance. * fix(gpu): preserve donor allocations through the scope-safety repair (#5722) Port the native-validated #5723 scope-cleanup correction into the experimental donor, retaining its adaptive, volume, aging, photographic and bloom allocations. Same reverse-drain helper and regression cases; the donor combination still needs its own compile/test gate and is not covered retroactively by render-base results. * claim: #1369 * Reject unknown pending concepts after format folding (#1369) * test(render): close bounded sampling and bloom review regressions (#5493) Validate the optional-resource/lighting/dependency donor at its exact tree. Required Vulkan GPU 127/0/3; CPU renderer 487/0; engine Render 72/0; document render 21/0; lean library 7/0; strict scoped Clippy, assets/layers/lists/containers and lean-engine WASM pass. Preserve original failed controller/typing attempts. This is the draft donor/disposition source, not a replacement for constituent render PRs or final main acceptance. * wip(render): preserve stable aging target validation candidate Exact staged source from prior review work on donor3b892eab5e. This is a recovery/review checkpoint, NOT accepted delivery. An actual command-path regression currently fails because the selected executor refuses ordered surface aging. No assertion, capability or admission limit is weakened. Native/UI/full combination acceptance remains pending. Saved/runtime split adds one pending descriptor and retains original file scope; no main/render branch is changed. * test(render): preserve numeric setup intent at the admitted coordinate bound Follow up jyviko review on #5494 without weakening the corrected saved-coordinate contract. The positive clicked fixture uses 1e9 instead of inadmissible 2e9; explicit out-of-range cases still refuse, and the full saved setup round-trips through JSON and the native container. Exact-source Render workspace 95/0 and strict all-target UI Clippy pass. This does not incorporate the separately failing stable-aging candidate or claim full current-render acceptance. * test(render): use the real GPU executor for saved aging Move successful native cold-reopen Check/Start coverage from the CPU-backed protocol fixture into the production GPU executor tests. Verify capture-index changes preserve the stable target and that enabling aging changes both PNG and raw EXR output. Retain explicit, allocation-free refusal coverage for executors without aging support. Production capabilities and admission checks are unchanged. * fix(render): persist stable identities for targeted aging (#5493) Separate saved RenderBodyTarget identities from captured mesh ordinals. Reject legacy ambiguous targets, resolve Check/Start after visibility changes and preserve native reopening, copies and undo. Unsupported executors still refuse; real AMD Vulkan regression completes saved aging after reordered capture. Source tree6b84c8adpasses document 23, engine Render 75, GPU effects 5 and Render UI 95 with no failures; scoped strict Clippy, WASM and repository gates pass. Fresh CLI/native reopen and clean/aged GPU exports pass with identical physical totals and inspected actual images. Whole current-render integration is separate. * fix(render): reconcile combined CPU/GPU contracts on current upstream Unify captured resources/status and CPU-vs-GPU request schemas after the real two-parent integration; remove obsolete duplicate Vulkan selector and retain combined platform-filter regression. Deduplicate only identical or superseded test definitions, retaining the stronger card metadata and reserved-executor assertions. No assertions, admission limits or feature refusals are weakened. All targets of render dependencies, GPU, engine, UI, CLI and native app pass cargo check with raytrace-cpu and bundled-render-library at treec70d00d1. Native executable tests and full current-source acceptance remain pending. This is a private integration rehearsal for subsequent constituent PRs, not an aggregate official render/main merge. * test(render): retain one complete host lifetime regression set Deduplicate byte-identical DropProbe/task-lifetime tests and retain the adapted environment/texture ownership regressions with every assertion and complete memory estimate. Keep the registered-geometry admission regression once; only struct field order differed. Replace a one-element diagnostic loop with its equivalent block, preserving all wrap/width assertions. Test-only integration repair. Formatting and diff checks pass; refreshed executable validation is required. No production behavior, limits, assertions or ignores changed. * fix(doc): recognize the proven format-29 card descriptor alias Normalize only the historical format-29 physical-material-cards spelling, and only when material-engineering-cards is registered. Admission and migration de-duplication use the same identity. Unknown concepts, wrong versions and incapable readers still refuse before mutation. Six controlled-history Rust regressions and actual CLI migration/no-clobber acceptance pass. No version, released migration or CI changes. Refs #5793, #1369, #5493. * test(render): preserve grounding refusal before explicit instance moves Update the two Render binding fixtures for upstream first-occurrence grounding. Verify grounded movement refuses without changing document/history, then explicitly unground through the public command before the intended move. Retain every target, resource, copy and persistence assertion. Refs #5493. --------- Co-authored-by: Christian Svensson <blue@cmd.nu> Co-authored-by: Victor Santos Oliveira <56417388+Vittuu@users.noreply.github.com> Co-authored-by: cfaulkingham <colin.faulkingham@gmail.com>
Prepared SELENE demonstration scenes
This directory contains 12 shot specifications, 10 stages and 33 semantic roles for the improved SELENE model. They are editable authoring inputs with status specified_unbound. The native source is now pinned in source-lock.json; the complete catalog's semantic roles and renderer resources still require explicit binding. None of these specifications substitutes old rover component or feature IDs for a reviewed selection.
The files prepare composition, lighting ownership, material intent and review gates. They do not install a renderer, create native geometry, simulate a catch or demonstrate a finished image.
Files and authorities
| File | Authority |
|---|---|
| shots.json | Shot composition, camera/framing recipes, output intent, comparisons and presentation/planning sequences. |
| stages.json | Explicit stage overrides, Sun/ambient/background ownership, generated geometry roles and clearance rules. |
| roles.json | Semantic selection targets, candidate material concepts, scope limits and native opaque-proxy eligibility. |
| ../source-lock.json | Accepted source identity and admission review, owned by the model-preparation workflow. |
The existing render/materials catalog remains authoritative for MAT, ENVSET, STU, Q and SCENE concepts. Stage geometry resolves the referenced environment-presets.json record and then applies only its declared overrides. This directory does not maintain a second copy of every terrain or room parameter. Metadata records hashes of the catalog files used to author the recipes; update those locks deliberately after a reviewed catalog revision.
reference_scene_id records design lineage. It is not an instruction to apply an entire catalog scene and then apply this shot again. Effective composition comes from the shot's explicit quality, studio, stage, roles and source policies. Existing catalog and scene IDs remain unchanged.
Source and native-body preparation
Run from the repository root, using the pinned improved native file:
python3 assets/render/selene/tools/prepare.py inspect --model assets/render/selene/source/SELENE-showcase.solidcraft --out target/render-selene/inspection.json
python3 assets/render/selene/tools/prepare.py template --model assets/render/selene/source/SELENE-showcase.solidcraft --out target/render-selene/bindings.json
Inspection and template generation do not approve a model. Review the source identity, license/admission record and exact body selections. Preserve the unreviewed template and save the reviewed bindings separately. The source lock contains active_source.status = "pinned_native" and records the accepted file's SHA-256, byte size, format, units and Z-up frame. It must match the selected file exactly. Reviewed body bindings remain necessary before compilation.
After those checks, the prepared opaque-body subset can be compiled:
python3 assets/render/selene/tools/prepare.py compile --model assets/render/selene/source/SELENE-showcase.solidcraft --bindings target/render-selene/bindings-reviewed.json --lock assets/render/selene/source-lock.json --out target/render-selene/opaque-overlay.json
The tool does not overwrite outputs. Use a new output path for a new inspection, review or compilation. The compiled overlay is a reviewed native BODY-only opaque diagnostic subset. It does not apply these complete shot specifications, create terrain, reproduce layered materials or enable a future renderer.
Eligible roles satisfy all three conditions: kind == "appearance", owner == "subject", and opaque_proxy_allowed == true. Optics, emitters, dust layers, framing regions, interaction regions and generated stage geometry remain outside that compiler. A reviewed body must be appropriate for a uniform opaque proxy; face-level or multilayer targets cannot be silently converted to whole-body assignments. Preserve the source's engineering material and physical properties.
The current native BODY appearance command styles a shared body definition. An appearance selected through one occurrence can affect every copy, so the review must cover all affected occurrences. This subset does not provide independent per-occurrence styling. The compiler accepts feature-declared body names; generated viewport instance names are not automatic binding targets. Resolve conflicting role appearances explicitly before compiling a shared definition.
The prepared-package check is:
python3 assets/render/selene/tools/validate_prepared.py --json
The existing catalog check remains separate:
python3 docs/render-materials/validate_catalog.py --json
Data validation establishes reference and specification consistency. The source-inspection report, native evaluation, actual images and future simulation evidence are separate results. Keep generated reports, overlays, previews and caches under target/render-selene/; do not commit them as resource masters.
Shot list
| Shot | Stage | Purpose | Quality / studio |
|---|---|---|---|
SELENE-SHOT-001 |
SELENE-STAGE-001 |
Low-Sun hero with native scale and terrain contact. | Q-006 / STU-021 |
SELENE-SHOT-002 |
SELENE-STAGE-002 |
High-Sun comparison, sharing the first shot's terrain, camera, materials and exposure. | Q-006 / STU-023 |
SELENE-SHOT-003 |
SELENE-STAGE-003 |
Sampling tool and terrain contact macro. | Q-007 / STU-023 |
SELENE-SHOT-004 |
SELENE-STAGE-004 |
LED-off/LED-on diagnosis of a genuinely solar-shadowed work patch. | Q-005 / STU-023 |
SELENE-SHOT-005 |
SELENE-STAGE-005 |
Rover in a generic polar-ridge setting with grazing sunlight. | Q-006 / STU-021 |
SELENE-SHOT-006 |
SELENE-STAGE-006 |
Arm, container, storage and transfer-station coverage. | Q-007 / STU-023 |
SELENE-SHOT-007 |
SELENE-STAGE-006 |
Static release/capture planning poses, including a possible miss. | Q-007 / STU-023 |
SELENE-SHOT-008 |
SELENE-STAGE-007 |
Shadow-interval audit with hardware lights off. | Q-006 / STU-023 |
SELENE-SHOT-009 |
SELENE-STAGE-008 |
Neutral studio diagnosis of the reviewed rover finishes. | Q-010 / STU-002 |
SELENE-SHOT-010 |
SELENE-STAGE-009 |
Eight presentation angles on a fixed studio stage. | Q-003 / STU-002 |
SELENE-SHOT-011 |
SELENE-STAGE-010 |
Explicitly labeled editorial hero with one declared fill rig. | Q-006 / STU-024 |
SELENE-SHOT-012 |
SELENE-STAGE-006 |
Vial walls, lid, contents and closure detail. | Q-007 / STU-023 |
The quality IDs are future authoring targets. They are not settings objects accepted by the current native command interface. In particular, do not submit the large lunar-master resolutions as current baseline setup commands without an independently verified executor contract.
Coordinates, framing and scale
Lengths use millimeters and angles use radians. +Z is up. The -Y front / +X right labels are an authored presentation-stage convention, not an observation of the improved rover's heading. Review and record its source-to-stage instance alignment before resolving a shot. Camera and Sun azimuths refer to that stage frame; they are not geographic east/north or a lunar site ephemeris.
Cameras specify a target role, a zero target offset, a viewing azimuth/elevation, vertical field of view and frame-fill fraction. A future adapter derives target coordinates, distance and clip planes from reviewed role bounds, output aspect and the complete scene. It fits once on explicit request, respects camera locks and never rescales the model. The files contain no claimed native camera transform.
The sampling macro fits the actual contact region, while retaining the rest of the rover for shadows and reflections. It must not squeeze the whole rover into a small macro patch. The low/high-Sun pair shares the low-Sun geometry reference and seed so that the comparison changes illumination rather than terrain. The turntable has explicitly authored stage dimensions; the entire rotating subject envelope must fit with clearance before use.
The eight-view turntable rotates render instances of the rover and platform about the reviewed platform axis. Camera, room and rig remain fixed; internal joint poses remain frozen. These are presentation stills, not a mechanical turntable simulation or a lunar vehicle maneuver. The recipe requests no motion blur and makes no dynamics claim.
Sun, vacuum and source ownership
Lunar stages use one environment-owned Sun. It is a finite-angular disk represented directionally at infinity for the local stage: direction and angular diameter are explicit, while a local XYZ light position is inapplicable. The local directional approximation has no stage-distance attenuation. The disk shown to the camera, if visible, must represent that same source. Do not add a second solar disk in an environment map or a second directional light in the studio rig.
The inherited draft diameter is 0.009250245036 radians, approximately 0.53 degrees. It remains an authored approximation, not a calculated lunar ephemeris. For context, the NASA Sun Fact Sheet gives an apparent diameter of 1,919 arcseconds at 1 AU and variation with observing distance. The table does not calibrate these particular lunar shots. The recipe's irradiance value 1.0 is a dimensionless reference; it is not watts, lux, lumens or a measured exposure.
Physical lunar stages have zero sky radiance and no atmospheric scattering, fog, clouds, rain or wind. This is the surface-rendering approximation described in the SELENE plan, not a claim that the Moon has literally no exosphere. Geometry and reflected light can still illuminate shadows. Earth and stars remain disabled until separately reviewed celestial placement, visibility, radiance and exposure are available. An arbitrary oversized Earth or dense star overlay cannot be added to a physical shot.
The LED work patch retains the Sun and uses terrain to block its direct illumination. It needs exactly one calibrated subject-owned rover_task_led. Its visible emitter, analytic sampling proxy and optic must share the intended source path without duplicated power. The shadow-interval audit also retains the Sun behind geometry, disables all hardware sources and accepts a nearly black image.
Editorial staging keeps the vacuum rules but deliberately permits STU-024 fill and an editorial fidelity label. The stage explicitly overrides the base ENVSET-024 ambient fill to zero so that this demonstration uses one declared fill rig. It must remain distinguishable from the physical lunar shots.
Role decisions that need explicit review
lunar_rocksis a generated geometry set;lunar_highland_rockassigns the existingMAT-545appearance to that set. Every generated rock has an owner and appearance even when a base environment omitted a material-role field.rover_dust_overlayusesMAT-551as a bounded surface layer. Its host appearance remains intact. It is outside the native opaque compiler and does not create atmospheric dust or assign contact parameters.task_led_emitterandtask_led_opticare separate. The existing candidateMAT-456specifically describes a scattering silicone light tube. If the improved model uses a different optical construction, choose a matching concept through a recorded shot-level override; do not treat that ID as a generic lens.sample_scooprequires an actual sampling tool or an approved derivative. A gripper alone does not fulfill a scoop/contact shot.sample_containeridentifies a reviewed vial assembly. The retaining grommet remains with the rack. Free-flight work requires an independent container identity, explicit closure and suitable collision geometry.- A scene can record an absent or not-visible optional role. A required camera, tool, source or interaction role cannot resolve to absent. Unresolved roles must remain visible in the preparation report.
Staged animation work
- Source and appearance diagnosis. Verify the pinned native source, review semantic selections, compile the eligible opaque body subset and inspect native scale. No dynamics is involved.
- Still-image reference. Bind stage geometry, materials, the Sun and optional hardware source. Review the physical hero, macro, lighting comparison and shadow audit before using the scene as an animation reference.
- Planning poses. Use
SELENE-SHOT-007to inspect release, candidate flight, capture/miss and storage coverage. Joint limits, clearances, closure and reach remain explicit checks. The file assigns no physical event times or launch velocities. - Independent physical validation. Establish mass/inertia, contact, actuation, constraint transitions and the millimeter/SI boundary. Use lunar-physics-fixtures.json as analytic checks, not as a ready-made rover trajectory. Rendering roughness does not determine friction or restitution.
- Approved bake and image sequence. After the 36 simulation requirements are satisfied for the chosen approximation, record an immutable bake and source/resource hashes. The future
SCENE-020,Q-008andQ-009references define preview/final intent. Preserve misses and solver failures, and keep physics timing independent of output frame rate.
These catalog specifications prepare those stages. Source admission is recorded separately in the source lock; native derivative results and concrete showcase renders are reported by their own build and validation records. The catalog itself does not establish contact simulation, complete renderer binding or final images for all 12 shots.