mirror of
https://github.com/bherbruck/solidcraft.git
synced 2026-11-07 04:12:15 +00:00
jyviko
9a79588575
doc: world_state, world_state_reusing, state_in_frame_at, state_in_frame, face_point_state, face_point_names and construction_state return Result. A body that could not be placed, a frame that could not be inverted, a sketch plane or thread axis that did not survive the placement, or a failed placing worker used to leave things where they were without a word; now the call fails with what could not be placed. is_placement is the one test of an occurrence's placement (finite, a rotation that does not mirror, a translation within 1e9 mm). Opening a design names every occurrence that fails it; add_occurrence refuses one; a joint solution that would place an occurrence outside one is not applied and the joints placing it report it. engine: Session::world_state returns Result and keeps a failure in its cache as it keeps a placed model. bounds, home_camera, open_sketch_plane, the scene builders, the world previews, frames::to_local and auto_operation pass the error on; helpers answering "not found" take the placed model from their caller. Commands setting a placement check it (valid_position, exploded view, fastener at a point, STEP insert matrix). ui: panels, picks and hovers read the session's placed model through open_meshing::session_world; a model that cannot be placed shows no placed bodies, and the viewport says why across its bottom. Pictures and the control channel report the error. cli, mcp: snapshots, renders, benches and the oracle report the error; the kernel-case rig records it as the case's failure. Tests read the new Results with unwrap. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017itGh5fpMEousnZ91cYcVt
74 lines
3.4 KiB
Rust
74 lines
3.4 KiB
Rust
//! Save caches survive a filename-driven rename. Display caches are never warmed for a save
|
|
//! nor certified for placements that do not match the document being saved; the model cache
|
|
//! (the timeline's bodies, before placement) needs no warm display.
|
|
use serde_json::json;
|
|
use solidcraft_doc::Document;
|
|
use solidcraft_engine::Session;
|
|
|
|
fn assembly() -> Session {
|
|
let mut session = Session::new(Document::new("Untitled"));
|
|
session.execute("component.create", &json!({"name":"PlacedPart"})).unwrap();
|
|
session.execute("solid.box", &json!({"length":2,"width":3,"height":4})).unwrap();
|
|
session
|
|
}
|
|
|
|
fn warm(session: &Session) {
|
|
for body in &session.world_state().unwrap().bodies {
|
|
body.mesh();
|
|
}
|
|
}
|
|
|
|
fn save(session: &mut Session, label: &str) -> Vec<u8> {
|
|
let path = std::env::temp_dir().join(format!("solidcraft-save-as-{label}-{}.solidcraft", std::process::id()));
|
|
session.execute("file.save_as", &json!({"path":path,"cache":true,"preview":true})).unwrap();
|
|
let bytes = std::fs::read(&path).unwrap();
|
|
assert_eq!(solidcraft_io::read_design(&bytes).unwrap().name, path.file_stem().unwrap().to_string_lossy());
|
|
std::fs::remove_file(&path).unwrap();
|
|
let _ = std::fs::remove_file(format!("{}.bak", path.display()));
|
|
bytes
|
|
}
|
|
|
|
/// Whether the file holds saved display meshes (a picture is also drawn from the model cache).
|
|
fn saved_display(bytes: &[u8]) -> bool {
|
|
bytes.windows(b"cache/preview.bin".len()).any(|entry| entry == b"cache/preview.bin")
|
|
}
|
|
|
|
#[test]
|
|
fn a_filename_rename_preserves_opted_in_warm_assembly_caches() {
|
|
let mut session = assembly();
|
|
warm(&session);
|
|
for label in ["first-warm", "renamed-warm"] {
|
|
let bytes = save(&mut session, label);
|
|
let geometry = solidcraft_io::read_design_geometry(&bytes).expect("warm geometry survives the rename");
|
|
assert_eq!(geometry.bodies.len(), 1);
|
|
assert!((solidcraft_kernel::measure(&geometry.bodies[0].body).unwrap().volume - 24.0).abs() < 1e-9);
|
|
assert!(solidcraft_io::read_design_preview(&bytes).is_some(), "warm display meshes survive the rename");
|
|
warm(&session);
|
|
}
|
|
}
|
|
|
|
#[test]
|
|
fn naming_a_design_does_not_warm_cold_or_revalidate_stale_placements() {
|
|
let original = assembly();
|
|
let mut cold = Session::new((*original.doc).clone());
|
|
let bytes = save(&mut cold, "cold");
|
|
assert!(solidcraft_io::read_design_geometry(&bytes).is_some(), "the model needs no warm display");
|
|
assert!(!saved_display(&bytes));
|
|
|
|
let mut stale = assembly();
|
|
warm(&stale);
|
|
stale.doc_mut().occurrences.first_mut().unwrap().transform[3][0] = 25.0;
|
|
let bytes = save(&mut stale, "stale");
|
|
assert!(solidcraft_io::read_design_geometry(&bytes).is_some(), "a placement is not part of the timeline's bodies");
|
|
assert!(!saved_display(&bytes), "old placements must not be certified for a changed document");
|
|
|
|
// A document edited without an evaluation since is not saved with the old one's bodies.
|
|
let mut edited = assembly();
|
|
let feature = edited.doc.features.last().unwrap().id;
|
|
if let solidcraft_doc::FeatureKind::Box { length, .. } = &mut edited.doc_mut().features.iter_mut().find(|f| f.id == feature).unwrap().kind {
|
|
*length = "20".into();
|
|
}
|
|
let bytes = save(&mut edited, "edited");
|
|
assert!(solidcraft_io::read_design_geometry(&bytes).is_none(), "bodies of another document must not be saved as this one's");
|
|
}
|