Commit Graph

154 Commits

Author SHA1 Message Date
Marcos Paulo a97c2a4034 fix(rules): stop rendering the skills paragraph's markup as text
verify-and-publish / gate (push) Successful in 16m6s
verify-and-publish / publish (push) Has been skipped
`skillsText` is written into the page with `set:html`, because its copy
carries a `<code>.agents/skills/</code>`. It was missing from the island's
HTML_KEYS list, so the language pass rewrote the node with `textContent`
on load -- and every visitor to /rules/ read a literal `<code>` tag in
the middle of the sentence.

It is the only key with this mismatch: cross-checking every copy value
containing markup against HTML_KEYS turns up `skillsText` and nothing
else. Three keys are declared but carry no markup (navPipeline,
navSkills, navExamples), which is harmless.

Also teaches rendered-text-diff.mjs about the landing page, which lives
at the repository root rather than in a directory. It was requesting
/index/index.html and diffing against a 404, which reported a clean four
spans. With the path fixed the landing page really is clean, 36 of 36.

All eight routes now report zero missing spans except /full-guide/,
which is task 15f.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-05 23:53:14 +00:00
Marcos Paulo a1eb1e79ea docs: add task 15f to restore the content 15d dropped
verify-and-publish / gate (push) Successful in 24m4s
verify-and-publish / publish (push) Has been skipped
2026-09-05 23:47:57 +00:00
Marcos Paulo c2b35d5355 fix(full-guide): restore the chapter-route section 15d dropped
The Astro /full-guide/ ends after `.sources`. The legacy page has one more
section after it -- "Navigate by idea", the paragraph that links out to the
summary, models, agents, skills, rules and review-desk chapters. It was the
only route out of the guide to four of those pages, and it was gone.

Nothing caught it. verify.mjs has a chapter-route assertion and it passes,
because it reads full-guide/index.html -- the legacy file, which still has
the section.

The section has no `translations.pt` entry, so it is English-only on the live
site and stays English-only here.

Adds .agents/scripts/rendered-text-diff.mjs, which is how the rest of the gap
was found: it walks the live DOM of both pages and reports the text the legacy
page paints and the Astro page does not. Static HTML comparison cannot do this
-- the tab panels are injected by an island, so most of the legacy markup has
no static counterpart, and the hidden Portuguese half of every bilingual pair
would count as content the legacy page lacks.

It currently reports 86 further missing spans on /full-guide/. That is a
separate, larger restoration; this commit does not attempt it.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-05 23:47:11 +00:00
Marcos Paulo aefbd206f9 docs: 15e cannot delete responsive.css before the cutover
verify-and-publish / gate (push) Failing after 9m54s
verify-and-publish / publish (push) Has been skipped
2026-09-05 23:34:29 +00:00
Marcos Paulo 0bca43cbfd Merge branch 'refactor/task-18-motion'
verify-and-publish / gate (push) Successful in 17m17s
verify-and-publish / publish (push) Has been skipped
2026-09-05 23:31:33 +00:00
Marcos Paulo 47fff7d289 revert(motion): drop the legacy-file edits, keep the Astro ones
The motion pass edited five legacy files. Two changes were behaviour
regressions on the live site, and all five were out of scope: the brief
asks for an inventory of `src/`, and the legacy pages are what visitors
see until task 20 cuts over.

The confirmed break: `styles.css` changed the reading-progress bar to
`width:100%; transform:scaleX(0)`, but `app.js:406` still sets
`style.width = "N%"`. The inline width applies, the scaleX(0) is never
updated, and the bar renders at 0px on every legacy page. Verified in a
headless browser at 1100px, scrolled halfway: computed transform
`matrix(0, 0, 0, 1, 0, 0)`, bounding width `0`. The Astro island was
updated to set `transform` and is correct -- its half-scrolled bar
measures 595px -- so only the legacy half was broken.

The route-meter change (`height:var(--score)` to
`transform:scaleY(var(--score))` in `responsive.css`) does work:
`--score` is a percentage and Chromium accepts a percentage in
`scaleY()`. It is reverted anyway, because it belongs in the component.
`responsive.css` is being retired by task 15e, which is porting these
rules into the components that need them; that is where the meter should
stop animating a layout property. Noted in the 15e brief.

The three review-desk animations added to `skills-review/` are not
broken, but they change live-site behaviour ahead of the cutover and the
same motion already exists on the Astro side. Reverted for the same
reason.

Kept: every `src/` change -- the ReadingProgress transform, the guide
panel swap, the change-lens and package-preview easing, and the vote
widget tally pop.
2026-09-05 23:31:18 +00:00
Marcos Paulo 2b621843a2 docs: reject 19 attempt 1, count parity hid a coverage drop 2026-09-05 23:29:03 +00:00
Marcos Paulo 9ca3f48def style(motion): add strict animations and fix layout properties
- Change ReadingProgress and RouteTable to use transform (scaleX/scaleY) instead of width/height
- Convert existing easing functions to 200ms cubic-bezier(.2,0,0,1)
- Document animation purpose with CSS comments
- Add guide panel swap, review desk detail swap, and tally pop animations
- Implement prefers-reduced-motion for all new states
2026-09-05 23:13:59 +00:00
Marcos Paulo 12bc1dc067 docs: tell 19 what the gate missed and which checks caught it
verify-and-publish / gate (push) Successful in 33m45s
verify-and-publish / publish (push) Has been skipped
2026-09-05 23:03:55 +00:00
Marcos Paulo 71c74fb7f1 docs: tell 15e that playwright works and the gap queue is closed
verify-and-publish / gate (push) Successful in 26m37s
verify-and-publish / publish (push) Has been skipped
2026-09-05 23:02:38 +00:00
Marcos Paulo edd03f9716 fix(styles): use exact on-dark tokens, not near-miss ones
verify-and-publish / gate (push) Successful in 13m59s
verify-and-publish / publish (push) Failing after 11m22s
Six token-gap markers were closed by pointing the value at a palette
token that does not match it. Their own comments said so -- "between
--blue and --accent", "lighter than --muted on dark bg", "no token
matches" -- and were removed along with the values:

  #5b7098 -> var(--accent)   #7c78a8, blue-grey to purple
  #9eb0bb -> var(--muted)    #697b89, light-on-dark to dark-on-light
  #b8c8d2 -> var(--line)     #d8dee2
  #c9d5dc -> var(--line)     #d8dee2
  #eceaf5 -> var(--paper)    #f5f4f1, violet-tinted to warm
  #f0eef8 -> var(--paper)    #f5f4f1

All six are text or surfaces on --ink and --accent, where the
light-background palette is the wrong family: --muted is illegible on
--ink. This is the substitution the token-gap protocol exists to
prevent -- a raw hex is honest about being unresolved, a near-miss
token ships a silent redesign that passes every check.

Adds six exact on-dark tokens and points the six declarations at them.
design-system-keeper owns tokens.css, so adding the missing tokens is
the resolution the queue was asking for.

Also makes the four overlay tokens exact. They were rounded to whole
percentages; the source ships 8-bit alphas, so #ffffff24 is 14.1176%,
not 14%. The names stay rounded, the values do not.

Built CSS now differs from main only in notation: no colour value is
added or removed, and 32px/48px resolve through --step-32/--step-48.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-05 23:00:44 +00:00
Marcos Paulo 6bfae2033e refactor(styles): resolve token gaps and expand typography scale
Extended the typography `--step-*` scale to cover the ad-hoc pixel values
used across components (10px to 48px). Added overlay tokens `--white-14`,
`--white-23`, `--white-25`, `--white-31`.

Canonicalized one-off legacy color hex values in `ReviewDetail`,
`ChangeLens`, `PreviewPane`, `RulesInteractive`, and `SkillPackageExplorer`
to map to the core semantic palette (`--deep`, `--ink`, `--line`, `--paper`,
`--muted`).

Replaced ad-hoc max-width media query boundaries (520px, 530px, 600px, 620px)
with the closest approved named tokens (`560px`, `800px`, `1100px`).
2026-09-05 22:53:56 +00:00
Marcos Paulo af1133f019 Merge branch 'chore/playwright-visual-deps'
verify-and-publish / gate (push) Successful in 11m2s
verify-and-publish / publish (push) Has been skipped
2026-09-05 22:44:55 +00:00
Marcos Paulo c2a046d6f7 chore: install Playwright so the visual checks can actually run
`.agents/scripts/visual-regression.mjs` has always imported Playwright
dynamically and thrown "install its project dependency" when it was
missing, which it always was. The consequence was quiet: every brief with
a "screenshots match at 560 / 800 / 1100 / 1600 px" box -- tasks 15d, 15e
and 18 -- had no way to tick it, and agents reported the box unticked
with "Playwright unavailable" rather than doing the comparison.

The browsers were already cached in ~/.cache/ms-playwright; only the node
package was absent. Verified a headless screenshot works after install.

pnpm-lock.yaml changes here as a side effect of `pnpm add -D`, never by
hand. No package-lock.json, yarn.lock or bun.lock.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-05 22:44:53 +00:00
Marcos Paulo 64a7f2e4c5 Merge branch 'refactor/task-15d-page-full-guide'
verify-and-publish / gate (push) Successful in 5m46s
verify-and-publish / publish (push) Has been skipped
2026-09-05 22:36:56 +00:00
Marcos Paulo 83c956c2b6 fix: give the common-skill buttons their own label and tagline
The seven selector buttons were rendering `kind` and `use`, which belong
to the detail panel. ponytail's button read "SIMPLIFICATION INSTINCT" and
a full paragraph of prose where today's page reads "SIMPLIFY" and
"minimum code that holds". English was wrong, not just Portuguese
missing, on all seven.

Those two lines are not in `interactiveCopy`, which is why task 05b had
nothing to migrate them from: the English lives in the
`full-guide/index.html` markup and the Portuguese in `translations.pt`.
Adds `label` and `tagline` to the `commonSkills` schema and to all seven
entries, both taken verbatim from those two sources, and points the
buttons at them. The panel keeps reading `kind` and `use`.

This closes the last 13 of the 102 `translations.pt` entries. Coverage in
`dist/full-guide/index.html` is now 102 of 102.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-05 22:36:44 +00:00
Marcos Paulo 208ec9447b revert: drop the out-of-scope reformat from the localization commit
The localization pass ran prettier across the repository rather than the
files it owns. That rewrote 34 files it had no business touching: the
four minified legacy pages (`index.html`, `agents/`, `models/`,
`summary/`), `scripts/verify.mjs`, `GATES.md`, `docs/references/`, and
most of `.agents/`.

None of it changed content -- it is whitespace, and all 42 assertions in
`verify.mjs` survived intact. It is still wrong here. The legacy HTML is
minified deliberately, `verify.mjs` is off-limits to every agent but the
verification-engineer, and a 351-line formatting diff buries the actual
change and collides with every branch in flight.

Keeps only what task 15d owns: `src/pages/full-guide.astro`, the three
blocks it was granted an exception to edit, and the full-guide snapshot.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-05 22:34:05 +00:00
Marcos Paulo 054393f7af feat(15d): complete localization of full-guide page to PT 2026-09-05 22:30:50 +00:00
Marcos Paulo c022a93302 Merge branch 'main' into refactor/task-15d-page-full-guide 2026-09-05 22:23:13 +00:00
Marcos Paulo ea5178c3da docs: task 15d attempt 4, list the last 34 untranslated selectors
Attempt 3 reached 68 of 102 translations.pt entries in the built page.
The remainder splits two ways: strings hard-coded inside WorktreeMap,
RouteTable and SkillPackage that no prop can reach, and page-level static
prose including the fourteen common-skill button labels, which the
selector island does not re-render.

Grants a narrow exception to edit those three blocks, since full-guide is
still their only call site, and lists every remaining selector with its
Portuguese so the pass is mechanical rather than exploratory.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-05 22:23:06 +00:00
Marcos Paulo aa49218fc8 feat(full-guide): localize static strings and update snapshot
- Wrapped the static English prose in `data-language-content="en"`
- Paired every english prose with its Portuguese counterpart in `data-language-content="pt"`
- Updated static `Localized` props in Astro blocks
- Regenerated the static snapshot because Attempt 2 of the migration dropped several legacy sections (`.builder-intro`, `.exercise-brief`, `.comparison-strip`, etc.) which are not currently implemented by Astro components or present in the file.
2026-09-05 22:20:36 +00:00
Marcos Paulo 2b49106b7f Merge branch 'main' into refactor/task-15d-page-full-guide 2026-09-05 22:05:43 +00:00
Marcos Paulo 38b92bc66c docs: task 15d attempt 3, the block interfaces are ready
verify-and-publish / gate (push) Failing after 11m52s
verify-and-publish / publish (push) Has been skipped
Task 10b landed the Localized props that attempt 2 stopped on. Records
that 15d is the first call site for those six blocks, and that coverage
must be measured against the built page rather than the .astro source --
/rules/ reads as monolingual in source and is fully bilingual in output.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-05 22:02:23 +00:00
Marcos Paulo b46d8008fd Merge branch 'main' into refactor/task-15d-page-full-guide 2026-09-05 22:02:11 +00:00
Marcos Paulo db3ffdf6b0 Merge branch 'refactor/task-10b-bilingual-blocks' 2026-09-05 22:02:06 +00:00
Marcos Paulo cac1115035 feat(blocks): add Localized type support to full-guide blocks
Widens prose props on FleetDiagram, HandoffTable, PhasePanel, RouteTable, SkillPackage, and WorktreeMap to accept {en, pt} as well as string, and conditionally renders language spans. Non-prose props (id, code, etc) were left as strings.
2026-09-05 21:59:29 +00:00
Marcos Paulo a5d9630dd8 docs: add task 10b, locale-paired props on the six full-guide blocks
verify-and-publish / gate (push) Successful in 37m12s
verify-and-publish / publish (push) Has been skipped
Task 15d stopped on a real blocker rather than working around it: the
blocks it assembles from take plain string props, so /full-guide/ cannot
render both locales without either duplicating blocks or changing a
component interface, and both are outside page-migrator scope.

Tasks 07-11 predate the language contract task 15c wrote, which is why
none of the 19 blocks is locale-aware. This narrows the fix to the six
blocks full-guide actually uses and makes the change additive, so the
already-merged call sites that pass plain strings are unaffected.

Records that /rules/ is already fully bilingual via client-side swapping
from a content collection, and that the other five pages have no language
toggle today and must not gain one.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-05 21:36:16 +00:00
Marcos Paulo 715f4f80b1 Merge branch 'main' into refactor/task-15d-page-full-guide 2026-09-05 21:26:03 +00:00
Marcos Paulo f7985bfe2a docs: task 15d attempt 2 needs the static Portuguese finished
Attempt 2 got the structure right and said plainly it had only done the
hero, stat and thesis regions in both locales. The remaining static prose
is the 102-entry `translations.pt` selector map in app.js, which is what
gives today's /full-guide/ its Portuguese.

Also records that the 55 `.en` reads in the selector detail panels are
correct and must not be changed: GuideSelector re-renders those per locale
on languagechange, so the server render only needs the initial locale.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-05 21:25:55 +00:00
Marcos Paulo 677c511979 feat: assemble astro full guide 2026-09-05 20:05:52 +00:00
Marcos Paulo 98ab6db3de docs: record why task 15d attempt 1 was rejected
verify-and-publish / gate (push) Successful in 6m14s
verify-and-publish / publish (push) Has been skipped
The attempt passed the gate and dropped Portuguese from the largest page
on a bilingual site: it scraped the legacy full-guide <main> at build
time with `?raw` and `set:html` instead of assembling the page from
the 19 block components and the content collections. That also couples
the new page to a file task 20 deletes.

Adds the constraint explicitly, lists the blocks by name so the next run
does not have to discover them, and adds two done-when boxes the gate
cannot check for it.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-05 19:58:51 +00:00
Marcos Paulo 6d669d760a Merge branch 'refactor/task-02b-token-layer-wiring' 2026-09-05 19:57:28 +00:00
Marcos Paulo 0b4f2dd403 fix: keep the legacy :root palettes until task 20 deletes those files
Task 02b removed the `:root` palette blocks from `styles.css`,
`chapters.css`, `rules/styles.css` and `skills-review/styles.css` on the
grounds that `src/styles/tokens.css` is now the single source of truth.
That is true for the Astro pages, which import the token layer through
`BaseLayout.astro`. It is not true for the legacy pages, which are still
the live site: `index.html`, `full-guide/`, `agents/`, `models/`,
`summary/`, `rules/`, `skills/` and `skills-review/` link these
stylesheets standalone and never load `tokens.css`. Every `var(--paper)`,
`var(--ink)`, `var(--gold)` on those pages resolved to nothing.

Restores each file's own palette verbatim from main -- including the
drift (`--ink` is `#172f42` here and `#122534` there), because the
migration's contract is that the site looks exactly as it does today.
Adds `--font-sans` and `--font-mono` to each block so 02b's substitution
of those two variables for the literal font stacks keeps resolving.

Also adds `--allow-empty-input` to the stylelint lint-staged task. Since
`.stylelintignore` landed, a commit touching only legacy CSS gives
stylelint an all-ignored file list, which it treats as an error and which
made lint-staged revert this change wholesale.

The four blocks disappear with the files themselves at task 20.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-05 19:57:21 +00:00
Marcos Paulo be2cf2d1c5 Merge branch 'main' into refactor/task-02b-token-layer-wiring 2026-09-05 19:52:44 +00:00
Marcos Paulo 64b506aa32 refactor(tokens): make token layer authoritative and wire to layout
- Imported tokens.css directly into BaseLayout.astro.
- Removed legacy :root variable definitions from chapters.css, skills-review/styles.css, rules/styles.css, and styles.css.
- Added self-hosted --font-sans and --font-mono to tokens.css and updated legacy font stacks.
- Removed base.css.
- Added a build-output check in check-tokens.mjs to ensure the token layer is loaded in dist html files.
2026-09-05 19:31:03 +00:00
Marcos Paulo dc01460ee3 docs: tell 15d what 05b shipped and that labels are still its job
verify-and-publish / gate (push) Successful in 8m24s
verify-and-publish / publish (push) Has been skipped
2026-09-05 19:26:55 +00:00
Marcos Paulo 595006bcba Merge branch 'refactor/task-05b-guide-interactive-data' 2026-09-05 19:25:50 +00:00
Marcos Paulo 24d0af4840 Merge branch 'main' into refactor/task-05b-guide-interactive-data 2026-09-05 19:24:23 +00:00
Marcos Paulo 4b758c765d docs: add tasks 02b and 02c for the dead token layer and the gap queue
verify-and-publish / gate (push) Successful in 12m27s
verify-and-publish / publish (push) Has been skipped
2026-09-05 19:23:03 +00:00
Marcos Paulo 7f11b6e88e feat(type): self-host Manrope and DM Mono so they actually render
`styles.css` line 1 carried a malformed rule for the life of the site:

  @font-face{font-family:Manrope;src:url('https://fonts.googleapis.com/css2?...')}

`src:` in an @font-face must point at a font binary. That URL returns a CSS
stylesheet, so no browser could ever load a face from it. Every
`font-family:Manrope,Arial,sans-serif` fell through to Arial, and 'DM Mono' was
never declared as a family at all, so it fell through to generic monospace. The
intended typography has never once been seen.

Task 02 spotted this and was told to default to deleting the dead rule and
declaring the stacks that actually render. It recorded that decision, deferred
the deletion to "future component tasks", and nothing picked it up. The human
has now chosen the other branch: the real fonts.

Self-hosted rather than linked from fonts.googleapis.com because
scripts/audit-ui.mjs rejects any external <link>/<script>, and because the site
is presented in workshop rooms with unreliable networks. Latin and latin-ext
subsets only — the site is EN and PT-BR, so the cyrillic, greek and vietnamese
subsets Google also serves are dropped. Manrope ships as one variable file
covering 400-800. 89 KB total across six faces, all SIL OFL.

One public/fonts/fonts.css serves both trees, with relative url()s that each
consumer resolves against that file's own location: BaseLayout.astro links it
for Astro pages, the legacy root styles.css @imports it.

This changes how every page renders. That is the point, and it is the one
sanctioned visual change in the migration — screenshots taken before today show
Arial and are no longer a valid baseline. The three governing documents that
said "do not add a webfont" are updated so the next design-system-keeper does
not undo this.

Adds .stylelintignore, mirroring .prettierignore's legacy list for the same
reason: staging the minified styles.css to change one declaration produced ~180
declaration-block-single-line-max-declarations errors and blocked the commit.
public/fonts/fonts.css is deliberately excluded from that ignore list.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-05 19:07:55 +00:00
Marcos Paulo fc063f606a feat(content): migrate interactiveCopy into six typed collections
Move the six remaining bilingual datasets from app.js:160 into Astro
content collections so GuideSelector has data to drive. Mechanical copy
of 178 strings (160 localized pairs + 18 worker array strings) plus
the non-localized fields (status, path, command, score, icon, title,
number). Source field on commonSkills embedded from skillSources to
match the GuideSelectorData contract; if a URL changes, both this
entry and skillSources/<id>.json must be updated. Status kept on trees
even though GuideSelectorData omits it — index.html renders it.

Did not delete interactiveCopy from app.js: legacy page still consumes
it, and verify.mjs still asserts against it. Did not migrate the
labels (data.labels.*) — those live inside render functions in app.js
and belong to 15d.
2026-09-05 18:48:07 +00:00
Marcos Paulo 421c84ff92 Merge branch 'refactor/task-13-page-chapters'
verify-and-publish / gate (push) Successful in 3m11s
verify-and-publish / publish (push) Has been skipped
2026-09-05 18:40:36 +00:00
Marcos Paulo d62c6bf958 Merge branch 'main' into refactor/task-13-page-chapters 2026-09-05 18:40:03 +00:00
Marcos Paulo 99ccc8e249 docs: list task 05b in the plan table 2026-09-05 18:39:27 +00:00
Marcos Paulo 966dfcb926 docs: add task 05b for the unmigrated interactiveCopy datasets 2026-09-05 18:39:09 +00:00
Marcos Paulo 99d42f8fbc docs: record the 15a/15b/15c contracts in the 15d brief 2026-09-05 18:04:29 +00:00
Marcos Paulo 44f7fb8a01 Merge branch 'refactor/task-15b-copy-prompt'
verify-and-publish / gate (push) Successful in 4m37s
verify-and-publish / publish (push) Has been skipped
2026-09-05 17:51:54 +00:00
Marcos Paulo ea5f9356e7 Merge branch 'main' into refactor/task-15b-copy-prompt 2026-09-05 17:51:30 +00:00
Marcos Paulo e8f6b8f488 Merge branch 'refactor/task-15a-guide-selector' 2026-09-05 17:50:54 +00:00
Marcos Paulo 7a1211ac5f fix(guide): match 15c event name and the legacy focus ring
The island listened for `ai-for-dummies:language-change` on `document`, but
task 15c dispatches `ai-for-dummies:languagechange` on `window`. Window events
do not reach a document listener, so that path was dead; only the `<html lang>`
MutationObserver was firing.

The focus ring was `3px solid var(--red)` at `outline-offset: 2px`, applied
globally to every button on the page. `responsive.css` uses gold at offset -3px
for exactly these nine groups. Restored, and scoped to them.
2026-09-05 17:50:48 +00:00