Marcos Paulo
48c31dc1b3
Ten git worktrees each carried their own 225 MB node_modules (1.1 GB across five) and paid 11s per `npm ci`. pnpm hardlinks from a shared store: the same five worktrees cost ~250 MB total, and a fresh install is 4s. What changed beyond the mechanical rename: - `overrides` moved to `pnpm-workspace.yaml`. pnpm 11 does not read the `pnpm` field in package.json *or* npm's top-level `overrides`, and it fails silently — the vite/defu/language-server pins would have quietly stopped applying. - Build scripts are blocked by default in pnpm; esbuild and sharp are allowed explicitly via `allowBuilds` (renamed from `onlyBuiltDependencies` in 11). - `packageManager` + `engines` pin the toolchain. - gate.sh rejects a package-lock.json/yarn.lock/bun.lock outright, so an agent running `npm install` out of habit fails loudly instead of building a second, divergent dependency tree. - CI bootstraps pnpm with `npm install --global pnpm@11.25.0` rather than corepack (unbundled as of Node 25) or pnpm/action-setup (this self-hosted act-runner has never run a job; fetching a third-party action is not something to discover on the first one). Two pre-existing CI bugs fixed while in the file: - the gate installed with `npm install --package-lock=false`, which discarded the lockfile the previous session had just fixed. - the visual-regression step imported `playwright`, which is not a dependency, and `visual-regression.mjs` has no compare mode anyway — in CI it overwrote its own baselines and passed unconditionally. Removed with a comment; it comes back when it can diff. The `publish` job is now manual (`workflow_dispatch`). During the migration dist/ holds three HTML files against the live pages branch's ten, so publishing on every push to main would take the site down to a stub. Restore at task 20. HANDOVER.md's incident log still says npm where it describes what happened at the time; that is history, not a missed rename. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
21 lines
1.0 KiB
Markdown
21 lines
1.0 KiB
Markdown
# Checklist: before you call a page migrated
|
|
|
|
- [ ] URL identical to the old one, **trailing slash included**
|
|
- [ ] Any query params the old page honoured still work (`?author=`, `?skill=`,
|
|
`?view=`, `?file=`, `?compare=`, `?render=`)
|
|
- [ ] Rendered text content diffs clean against the pre-migration snapshot — or
|
|
every difference is listed and justified
|
|
- [ ] Same number of JS bytes or fewer; a previously-zero-JS page still ships
|
|
zero
|
|
- [ ] `<title>`, `<meta name="description">`, and `<meta name="viewport">`
|
|
preserved
|
|
- [ ] One `<h1>`; heading levels do not skip
|
|
- [ ] Every ARIA attribute from the original survived (`verify.mjs` asserts
|
|
several)
|
|
- [ ] No external `<script>`, `<link>`, `@import`, or `url()` —
|
|
`node scripts/audit-ui.mjs` green
|
|
- [ ] Internal links go through `BASE_URL`, not hand-written absolute paths
|
|
- [ ] Screenshots at 560 / 800 / 1100 / 1600 px compared against the old page
|
|
- [ ] `<html lang>` correct and still switching with the language toggle
|
|
- [ ] `pnpm run verify` green with no assertion deleted
|