Marcos Paulo
48c31dc1b3
Ten git worktrees each carried their own 225 MB node_modules (1.1 GB across five) and paid 11s per `npm ci`. pnpm hardlinks from a shared store: the same five worktrees cost ~250 MB total, and a fresh install is 4s. What changed beyond the mechanical rename: - `overrides` moved to `pnpm-workspace.yaml`. pnpm 11 does not read the `pnpm` field in package.json *or* npm's top-level `overrides`, and it fails silently — the vite/defu/language-server pins would have quietly stopped applying. - Build scripts are blocked by default in pnpm; esbuild and sharp are allowed explicitly via `allowBuilds` (renamed from `onlyBuiltDependencies` in 11). - `packageManager` + `engines` pin the toolchain. - gate.sh rejects a package-lock.json/yarn.lock/bun.lock outright, so an agent running `npm install` out of habit fails loudly instead of building a second, divergent dependency tree. - CI bootstraps pnpm with `npm install --global pnpm@11.25.0` rather than corepack (unbundled as of Node 25) or pnpm/action-setup (this self-hosted act-runner has never run a job; fetching a third-party action is not something to discover on the first one). Two pre-existing CI bugs fixed while in the file: - the gate installed with `npm install --package-lock=false`, which discarded the lockfile the previous session had just fixed. - the visual-regression step imported `playwright`, which is not a dependency, and `visual-regression.mjs` has no compare mode anyway — in CI it overwrote its own baselines and passed unconditionally. Removed with a comment; it comes back when it can diff. The `publish` job is now manual (`workflow_dispatch`). During the migration dist/ holds three HTML files against the live pages branch's ten, so publishing on every push to main would take the site down to a stub. Restore at task 20. HANDOVER.md's incident log still says npm where it describes what happened at the time; that is history, not a missed rename. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
52 lines
1.3 KiB
Bash
Executable File
52 lines
1.3 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
# Guards the silent-failure mode described in .agents/rules/gates.md.
|
|
#
|
|
# Husky points core.hooksPath at `.husky/_`, but that directory is GENERATED by
|
|
# `pnpm install` and is NOT committed. A fresh `git worktree add` therefore has
|
|
# hooks configured and the directory missing — so every hook silently does
|
|
# nothing and every commit passes unchecked.
|
|
#
|
|
# Run this in any worktree you did not create with worktree.sh.
|
|
set -euo pipefail
|
|
|
|
cd "$(git rev-parse --show-toplevel)"
|
|
fail=0
|
|
|
|
path=$(git config --get core.hooksPath || true)
|
|
if [ -z "$path" ]; then
|
|
echo "✗ core.hooksPath is unset — husky was never installed here"
|
|
fail=1
|
|
else
|
|
echo "✓ core.hooksPath = $path"
|
|
fi
|
|
|
|
if [ ! -d "${path:-.husky/_}" ]; then
|
|
echo "✗ ${path:-.husky/_}/ does not exist — HOOKS ARE NOT RUNNING"
|
|
fail=1
|
|
else
|
|
echo "✓ ${path} exists"
|
|
fi
|
|
|
|
for hook in pre-commit commit-msg pre-push; do
|
|
if [ -f ".husky/$hook" ]; then
|
|
echo "✓ .husky/$hook present"
|
|
else
|
|
echo "✗ .husky/$hook missing"
|
|
fail=1
|
|
fi
|
|
done
|
|
|
|
if [ ! -d node_modules ]; then
|
|
echo "✗ node_modules missing — lint-staged and astro check cannot run"
|
|
fail=1
|
|
fi
|
|
|
|
if [ "$fail" -ne 0 ]; then
|
|
echo
|
|
echo "Fix: pnpm install --frozen-lockfile (its prepare script regenerates .husky/_)"
|
|
exit 1
|
|
fi
|
|
|
|
echo
|
|
echo "hooks are live in this worktree"
|