580293867d
Deletes the pre-Astro pages, scripts, and stylesheets that the migration replaced, and moves the ones it did not replace out of the way. Deleted (32 files): app.js, responsive.css, landing.css, rules/app.js, rules/styles.css, skills/app.js, the ten route index.html files, and the root hands-on/ copy, which is byte-identical to public/hands-on/ -- the one the build actually ships. Moved to legacy/ (12 files): styles.css, full-guide/audit.css, chapters.css, skills/styles.css, skills-review/styles.css, skills-review/change-lens.css, and the skills-review/app.js module graph. These are not dead. The Astro pages import them and the build fails without them, which the plan had not accounted for. They go to legacy/ rather than src/ because check-tokens.mjs sweeps src, and these files are full of raw hex and unnamed breakpoints: moving one into src/ should mean migrating it to tokens in the same change, not adding a scan exclusion. The prettier, stylelint, and eslint ignore lists that already named these files at their old paths now name legacy/ instead. verify.mjs no longer reads app.js. The 102 Portuguese strings were extracted from its translations.pt object before deletion into .agents/snapshots/full-guide-pt.json -- a legacy capture, not a snapshot of the Astro build, so the assertion still compares against an independent source. The brace-matching helper's assertion is replaced by one that rejects an empty snapshot entry, without which trimming the snapshot would make the presence check pass vacuously. Count stays at 84. audit-ui.mjs reads the ten pages from dist/ and resolves Astro's base-absolute hrefs against it. Before deleting anything, rendered-text-diff was run across all ten routes plus both Portuguese pages: every one at parity, 0 missing and 0 extra. That comparison is not repeatable once the legacy files are gone. computed-style-diff on /full-guide/ stays at 32 differences, so the moves are style-neutral. Docs updated to match: README, AGENTS.md, GATES.md, the architecture context, the operations guide's lab instructions, and the three skills that told you to serve the vanilla site. Publishing is not part of this commit. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
77 lines
2.8 KiB
Markdown
77 lines
2.8 KiB
Markdown
---
|
|
name: design-tokens
|
|
description:
|
|
Extract, name, and enforce the design token layer for the ai-for-dummies site.
|
|
Use when touching any colour, font size, spacing value, or breakpoint, when
|
|
consolidating the three drifted palettes, or when a check-tokens failure needs
|
|
resolving.
|
|
---
|
|
|
|
# Design tokens
|
|
|
|
## Before anything
|
|
|
|
Read [`../../context/design-system.md`](../../context/design-system.md). This
|
|
site has **three drifting palettes** and a **broken `@font-face`**. Both are
|
|
traps. If you have not read that file, you will "preserve the styles" by copying
|
|
a bug.
|
|
|
|
## Extracting
|
|
|
|
```bash
|
|
python3 - <<'PY'
|
|
import re
|
|
files=['legacy/styles/guide.css','legacy/styles/chapters.css','legacy/styles/skills.css',
|
|
'legacy/styles/skills-review.css','legacy/styles/change-lens.css',
|
|
'legacy/styles/audit.css','public/hands-on/starter/styles.css',
|
|
'public/hands-on/rules/styles.css']
|
|
seen={}
|
|
for f in files:
|
|
for m in re.finditer(r'--([a-z-]+):\s*([^;}]+)', open(f).read()):
|
|
seen.setdefault(m.group(1),{}).setdefault(m.group(2).strip(),[]).append(f)
|
|
for k,v in sorted(seen.items()):
|
|
print(f"--{k}:")
|
|
for val,fs in v.items(): print(f" {val:12} <- {', '.join(fs)}")
|
|
PY
|
|
```
|
|
|
|
Re-run this after any consolidation. Every token should print exactly one value.
|
|
|
|
## Consolidating a drifted token
|
|
|
|
1. List every value and where it is used (above).
|
|
2. Compute the perceptual delta. Sub-perceptual (a few units per channel) →
|
|
canonicalize freely. Visible (`--blue`: `#527f9f` vs `#215675`) → screenshot
|
|
both, get a human decision, record it in the task file.
|
|
3. Pick the canonical value. Prefer the one used on the most-visited surface.
|
|
4. Replace, then screenshot every affected page at 560/800/1100/1600 px.
|
|
5. Attach before/after images to the task report. "It looked fine to me" is not
|
|
evidence.
|
|
|
|
## Naming
|
|
|
|
Semantic, matching the existing vocabulary — `--ink`, `--paper`, `--muted`,
|
|
`--line`, `--accent`, `--gold`, `--blue`, `--deep`. Never numeric scales. New
|
|
surfaces extend semantically: `--surface-lab`, `--ink-inverse`.
|
|
|
|
## Type scale and breakpoints
|
|
|
|
Collapse the 14 ad-hoc `clamp()` triples to named steps and the 16 breakpoints
|
|
to five, per [`../../rules/theming.md`](../../rules/theming.md). When collapsing
|
|
a breakpoint, **screenshot at the old value** — that is where the regression is.
|
|
|
|
## Enforcing
|
|
|
|
```bash
|
|
node .agents/scripts/check-tokens.mjs # fails on raw hex outside tokens.css
|
|
```
|
|
|
|
Wire it into `pnpm run verify`. A rule nobody checks is a suggestion.
|
|
|
|
## The font decision
|
|
|
|
Do not self-host Manrope/DM Mono as part of a refactor task. The intended fonts
|
|
have never rendered, so adopting them is a visual redesign. Default to matching
|
|
what renders today (Arial / generic monospace) and delete the dead `@font-face`.
|
|
If a human wants the real fonts, that is its own task with its own screenshots.
|