580293867d
Deletes the pre-Astro pages, scripts, and stylesheets that the migration replaced, and moves the ones it did not replace out of the way. Deleted (32 files): app.js, responsive.css, landing.css, rules/app.js, rules/styles.css, skills/app.js, the ten route index.html files, and the root hands-on/ copy, which is byte-identical to public/hands-on/ -- the one the build actually ships. Moved to legacy/ (12 files): styles.css, full-guide/audit.css, chapters.css, skills/styles.css, skills-review/styles.css, skills-review/change-lens.css, and the skills-review/app.js module graph. These are not dead. The Astro pages import them and the build fails without them, which the plan had not accounted for. They go to legacy/ rather than src/ because check-tokens.mjs sweeps src, and these files are full of raw hex and unnamed breakpoints: moving one into src/ should mean migrating it to tokens in the same change, not adding a scan exclusion. The prettier, stylelint, and eslint ignore lists that already named these files at their old paths now name legacy/ instead. verify.mjs no longer reads app.js. The 102 Portuguese strings were extracted from its translations.pt object before deletion into .agents/snapshots/full-guide-pt.json -- a legacy capture, not a snapshot of the Astro build, so the assertion still compares against an independent source. The brace-matching helper's assertion is replaced by one that rejects an empty snapshot entry, without which trimming the snapshot would make the presence check pass vacuously. Count stays at 84. audit-ui.mjs reads the ten pages from dist/ and resolves Astro's base-absolute hrefs against it. Before deleting anything, rendered-text-diff was run across all ten routes plus both Portuguese pages: every one at parity, 0 missing and 0 extra. That comparison is not repeatable once the legacy files are gone. computed-style-diff on /full-guide/ stays at 32 differences, so the moves are style-neutral. Docs updated to match: README, AGENTS.md, GATES.md, the architecture context, the operations guide's lab instructions, and the three skills that told you to serve the vanilla site. Publishing is not part of this commit. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
42 lines
2.2 KiB
Markdown
42 lines
2.2 KiB
Markdown
# Gates: review desk privacy and improved-draft audit
|
|
|
|
OWNS: src/pages/skills-review.astro, src/components/blocks/{ReviewDetail,
|
|
ChangeLens,VoteWidget,PreviewPane,FileTabs}.astro, legacy/skills-review/**,
|
|
submitted-skills/Anonymous Operational Submission/**,
|
|
skill-reviews/improved/ndo-repro/**, scripts/verify.mjs
|
|
|
|
The gate commands below now read `dist/`; run `pnpm run build` before them.
|
|
|
|
Scope: Redact the operational submission's identity and URLs from the published
|
|
review desk, keep package files usable in either preview mode, and explain each
|
|
improved draft as a concrete diff.
|
|
|
|
- [x] G1: the published operational submission contains no personal name,
|
|
original source URL, email address, or host-specific path CHECK: node
|
|
scripts/verify.mjs EXPECT: review privacy verification passed EVIDENCE:
|
|
exit=0; shell=/bin/sh; cwd=/home/marcos/Projects/ai-for-dummies;
|
|
path=d3551337f830/34 entries; EXPECT=matched;
|
|
output-sha256=180e8cd0d18968e2a4244ede959c3459b5ce80b836fc5a0df00961907e5d15a1;
|
|
output-bytes=481
|
|
|
|
- [x] G2: every package file remains selectable in Original and Improved draft
|
|
modes without resetting the selected preview CHECK: node
|
|
scripts/verify.mjs EXPECT: review file-mode verification passed EVIDENCE:
|
|
exit=0; shell=/bin/sh; cwd=/home/marcos/Projects/ai-for-dummies;
|
|
path=d3551337f830/34 entries; EXPECT=matched;
|
|
output-sha256=180e8cd0d18968e2a4244ede959c3459b5ce80b836fc5a0df00961907e5d15a1;
|
|
output-bytes=481
|
|
|
|
- [x] G3: every improved draft has an interactive change lens that explains
|
|
changed guidance and its rationale CHECK: node scripts/verify.mjs EXPECT:
|
|
review change-lens verification passed EVIDENCE: exit=0; shell=/bin/sh;
|
|
cwd=/home/marcos/Projects/ai-for-dummies; path=d3551337f830/34 entries;
|
|
EXPECT=matched;
|
|
output-sha256=180e8cd0d18968e2a4244ede959c3459b5ce80b836fc5a0df00961907e5d15a1;
|
|
output-bytes=481
|
|
|
|
- [x] G4: the review desk works at mobile, Full HD, and 4K widths without page
|
|
errors or horizontal overflow EVIDENCE: Playwright audit on 2026-09-04:
|
|
320, 390, 1280, 1920, and 3840px passed with Improved Draft and Change
|
|
lens rendered; no horizontal overflow or page errors.
|