Marcos Paulo
48c31dc1b3
Ten git worktrees each carried their own 225 MB node_modules (1.1 GB across five) and paid 11s per `npm ci`. pnpm hardlinks from a shared store: the same five worktrees cost ~250 MB total, and a fresh install is 4s. What changed beyond the mechanical rename: - `overrides` moved to `pnpm-workspace.yaml`. pnpm 11 does not read the `pnpm` field in package.json *or* npm's top-level `overrides`, and it fails silently — the vite/defu/language-server pins would have quietly stopped applying. - Build scripts are blocked by default in pnpm; esbuild and sharp are allowed explicitly via `allowBuilds` (renamed from `onlyBuiltDependencies` in 11). - `packageManager` + `engines` pin the toolchain. - gate.sh rejects a package-lock.json/yarn.lock/bun.lock outright, so an agent running `npm install` out of habit fails loudly instead of building a second, divergent dependency tree. - CI bootstraps pnpm with `npm install --global pnpm@11.25.0` rather than corepack (unbundled as of Node 25) or pnpm/action-setup (this self-hosted act-runner has never run a job; fetching a third-party action is not something to discover on the first one). Two pre-existing CI bugs fixed while in the file: - the gate installed with `npm install --package-lock=false`, which discarded the lockfile the previous session had just fixed. - the visual-regression step imported `playwright`, which is not a dependency, and `visual-regression.mjs` has no compare mode anyway — in CI it overwrote its own baselines and passed unconditionally. Removed with a comment; it comes back when it can diff. The `publish` job is now manual (`workflow_dispatch`). During the migration dist/ holds three HTML files against the live pages branch's ten, so publishing on every push to main would take the site down to a stub. Restore at task 20. HANDOVER.md's incident log still says npm where it describes what happened at the time; that is history, not a missed rename. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
71 lines
2.4 KiB
Bash
Executable File
71 lines
2.4 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
# Tier 2 gate: types, build, content contracts, dependency audit, tokens.
|
|
# Invoked by .husky/pre-push, and safe to run by hand at any time.
|
|
#
|
|
# Parallel-safe: takes a lock in the SHARED git dir, so ten agents pushing from
|
|
# ten worktrees queue instead of running ten concurrent Astro builds and
|
|
# thrashing the machine. Waiters block; they do not fail.
|
|
set -euo pipefail
|
|
|
|
root=$(git rev-parse --show-toplevel)
|
|
cd "$root"
|
|
|
|
# --git-common-dir resolves to the ONE shared .git across all worktrees, which
|
|
# is exactly the scope we want the lock to cover.
|
|
common=$(git rev-parse --git-common-dir)
|
|
lock="$common/af-gate.lock"
|
|
|
|
exec 9>"$lock"
|
|
if ! flock -n 9; then
|
|
echo "gate: another worktree is running the gate — waiting for it…"
|
|
flock 9
|
|
fi
|
|
|
|
started=$(date +%s)
|
|
step() { printf '\n\033[1m▸ %s\033[0m\n' "$1"; }
|
|
|
|
# Fail loudly rather than passing vacuously when the toolchain is not installed.
|
|
if [ ! -d node_modules ]; then
|
|
echo "gate: node_modules missing — run 'pnpm install --frozen-lockfile' first" >&2
|
|
exit 1
|
|
fi
|
|
|
|
# This project is pnpm-only. An agent that runs `npm install` out of habit gets
|
|
# a second, divergent dependency tree and a lockfile nobody reads — the same
|
|
# class of failure that cost two sessions during phase 0. Catch it here.
|
|
if [ -f package-lock.json ] || [ -f yarn.lock ] || [ -f bun.lock ] || [ -f bun.lockb ]; then
|
|
echo "gate: a non-pnpm lockfile is present. This project uses pnpm only." >&2
|
|
echo " Delete it, then run 'pnpm install --frozen-lockfile'." >&2
|
|
exit 1
|
|
fi
|
|
|
|
step "types"
|
|
pnpm exec astro check
|
|
|
|
step "build"
|
|
pnpm run build
|
|
|
|
step "content contracts"
|
|
pnpm run verify
|
|
|
|
# The assertion count is the thing agents are most tempted to "fix" downward.
|
|
# Compare against origin/main and refuse a silent reduction.
|
|
step "assertion coverage"
|
|
current=$(grep -c 'throw new Error' scripts/verify.mjs)
|
|
baseline=$(git show origin/main:scripts/verify.mjs 2>/dev/null | grep -c 'throw new Error' || echo "$current")
|
|
if [ "$current" -lt "$baseline" ]; then
|
|
echo "gate: verify.mjs coverage fell from $baseline to $current assertions." >&2
|
|
echo " Only verification-engineer may reduce it, with a reason per removal." >&2
|
|
echo " See .agents/context/verification.md" >&2
|
|
exit 1
|
|
fi
|
|
echo " $current assertions (baseline $baseline)"
|
|
|
|
step "runtime dependency audit"
|
|
node scripts/audit-ui.mjs
|
|
|
|
step "design tokens"
|
|
node .agents/scripts/check-tokens.mjs
|
|
|
|
printf '\n\033[32mgate passed\033[0m in %ss\n' "$(( $(date +%s) - started ))"
|