Files

T

Marcos Paulo 48c31dc1b3 build: migrate from npm to pnpm

Ten git worktrees each carried their own 225 MB node_modules (1.1 GB across
five) and paid 11s per `npm ci`. pnpm hardlinks from a shared store: the same
five worktrees cost ~250 MB total, and a fresh install is 4s.

What changed beyond the mechanical rename:

- `overrides` moved to `pnpm-workspace.yaml`. pnpm 11 does not read the `pnpm`
  field in package.json *or* npm's top-level `overrides`, and it fails silently
  — the vite/defu/language-server pins would have quietly stopped applying.
- Build scripts are blocked by default in pnpm; esbuild and sharp are allowed
  explicitly via `allowBuilds` (renamed from `onlyBuiltDependencies` in 11).
- `packageManager` + `engines` pin the toolchain.
- gate.sh rejects a package-lock.json/yarn.lock/bun.lock outright, so an agent
  running `npm install` out of habit fails loudly instead of building a second,
  divergent dependency tree.
- CI bootstraps pnpm with `npm install --global pnpm@11.25.0` rather than
  corepack (unbundled as of Node 25) or pnpm/action-setup (this self-hosted
  act-runner has never run a job; fetching a third-party action is not
  something to discover on the first one).

Two pre-existing CI bugs fixed while in the file:

- the gate installed with `npm install --package-lock=false`, which discarded
  the lockfile the previous session had just fixed.
- the visual-regression step imported `playwright`, which is not a dependency,
  and `visual-regression.mjs` has no compare mode anyway — in CI it overwrote
  its own baselines and passed unconditionally. Removed with a comment; it
  comes back when it can diff.

The `publish` job is now manual (`workflow_dispatch`). During the migration
dist/ holds three HTML files against the live pages branch's ten, so publishing
on every push to main would take the site down to a stub. Restore at task 20.

HANDOVER.md's incident log still says npm where it describes what happened at
the time; that is history, not a missed rename.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

2026-09-05 04:29:42 +00:00

1.7 KiB

Raw Blame History

Task 11 — Review-desk blocks

Agent: component-builder · Model: MiniMax-M3 Depends on: 07 · Parallel with: 08, 09, 10 · Blocks: 16 Worktree: .agents/scripts/worktree.sh start 11 review-blocks

Goal

Review-desk furniture as static components. Interactivity is task 16.

Scope

src/components/blocks/ — SkillList.astro, ReviewDetail.astro, FileTabs.astro, PreviewPane.astro, ChangeLens.astro, VoteWidget.astro (markup only).

Source

skills-review/index.html, app.js (20 KB), styles.css, change-lens.css, vote.js.

One component, 24 entries

The 24 reviews are data, not 24 components. One SkillReviewCard iterating the collection. If you are writing the second near-identical component, stop.

CSS tokens asserted by verify.mjs

.change-lens, .change-rows, .skill-diff, .diff-lines, .markdown-preview, max-height:540px, .markdown-table-wrap, .markdown-frontmatter, .markdown-toc, .preview-title, .preview-markdown, grid-template-columns:minmax(0,1fr), height:120px, -webkit-line-clamp:2, .vote-widget, .vote-buttons, [aria-pressed="true"].

Class names may move into scoped <style> blocks, but each must still exist and task 19 must be able to assert it. Coordinate names with the verification engineer rather than renaming freely.

Watch for

aria-pressed on the vote buttons and preview switcher is how state reaches assistive tech. Colour alone is not enough. It is also asserted.

Done when

All listed CSS hooks present
aria-pressed, role="group", aria-label preserved
Static render matches current desk at four widths
Checklist complete; pnpm run gate green

1.7 KiB Raw Blame History