storytold/filmcraft
2
0
Fork 0
mirror of https://github.com/storytold/filmcraft.git synced 2026-11-02 18:09:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

Reject out-of-range SCC timecode fields (#3659)

Browse Source 
Found while testing crates/captions/src/scc.rs:37

Co-authored-by: GPT-6-Luna <noreply@openai.com>
This commit is contained in:
Max Mittelstädt
2026-10-30 06:42:30 +01:00
committed by GitHub
parent 4d57c52ab6
commit 7270ae8a8c
1 changed files with 12 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/captions/src/scc.rs
+12 -1
View File
@@ -35,7 +35,11 @@ pub fn parse_timecode(s: &str) -> Option<i64> {
let parts: Vec<&str> = s.split([':', ';', '.', ',']).collect();
let [h, m, sec, f] = parts.as_slice() else { return None };
let n = |p: &str| if (1..=3).contains(&p.len()) && p.bytes().all(|b| b.is_ascii_digit()) { p.parse::<i64>().ok() } else { None };
Some(fields_to_frames(n(h)?, n(m)?, n(sec)?, n(f)?, RATE, df))
let (h, m, sec, f) = (n(h)?, n(m)?, n(sec)?, n(f)?);
if m >= 60 || sec >= 60 || f >= 30 {
return None;
}
Some(fields_to_frames(h, m, sec, f, RATE, df))
}
pub fn format_timecode(frame: i64, drop_frame: bool) -> String {
@@ -503,6 +507,13 @@ mod tests {
assert_eq!(parse_timecode("00:00:01:00"), Some(30));
}
#[test]
fn timecode_rejects_out_of_range_fields() {
assert_eq!(parse_timecode("00:60:00:00"), None);
assert_eq!(parse_timecode("00:00:60:00"), None);
assert_eq!(parse_timecode("00:00:00:30"), None);
}
#[test]
fn timecodes() {
assert_eq!(parse_timecode("00:01:00;02"), Some(1800));