storytold/spark
2
0
Fork 0
mirror of https://github.com/storytold/spark.git synced 2026-10-09 00:09:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

For compressed SS PLY, make min/max_r/g/b chunk properties optional (defaulting to 0..1) since older SuperSplat 1.* seems to export without those, and defaults to 0..1 according to source code. (#82)

Browse Source
This commit is contained in:
Andreas Sundquist
2025-06-30 14:54:19 -07:00
committed by GitHub
parent 1c6e05ea97
commit 16bc076db7
1 changed files with 15 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ply.ts
+15 -22
View File
@@ -326,12 +326,6 @@ export class PlyReader {
max_scale_x,
max_scale_y,
max_scale_z,
min_r,
min_g,
min_b,
max_r,
max_g,
max_b,
} = element.properties;
if (
!min_x ||
@@ -345,13 +339,7 @@ export class PlyReader {
!min_scale_z ||
!max_scale_x ||
!max_scale_y ||
!max_scale_z ||
!min_r ||
!min_g ||
!min_b ||
!max_r ||
!max_g ||
!max_b
!max_scale_z
) {
throw new Error("Missing PLY chunk properties");
}
@@ -490,11 +478,16 @@ export class PlyReader {
);
const r =
(((packed_color >>> 24) & 255) / 255) * (max_r - min_r) + min_r;
(((packed_color >>> 24) & 255) / 255) *
((max_r ?? 1) - (min_r ?? 0)) +
(min_r ?? 0);
const g =
(((packed_color >>> 16) & 255) / 255) * (max_g - min_g) + min_g;
(((packed_color >>> 16) & 255) / 255) *
((max_g ?? 1) - (min_g ?? 0)) +
(min_g ?? 0);
const b =
(((packed_color >>> 8) & 255) / 255) * (max_b - min_b) + min_b;
(((packed_color >>> 8) & 255) / 255) * ((max_b ?? 1) - (min_b ?? 0)) +
(min_b ?? 0);
const opacity = (packed_color & 255) / 255;
splatCallback(
@@ -919,10 +912,10 @@ type SSChunk = {
max_scale_x: number;
max_scale_y: number;
max_scale_z: number;
min_r: number;
min_g: number;
min_b: number;
max_r: number;
max_g: number;
max_b: number;
min_r?: number;
min_g?: number;
min_b?: number;
max_r?: number;
max_g?: number;
max_b?: number;
};