masi/solvecraft
1
0
Fork 0
mirror of https://github.com/bherbruck/solidcraft.git synced 2026-11-08 13:01:52 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity

plan: WR-464 addendum: the fork's test needs a test-only surface subclass

Browse Source 
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PqrY3KqUA9vpCbwBCMF1av
This commit is contained in:
Thijs Damsma
2026-10-31 05:38:08 +01:00
parent b3ba5da172
commit 58aeab658d
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plan/findings/general--flag-pin-wr464-missing-surface-inert-by-construction--addendum-2026-10-31-fork-test.md
+5
View File
@@ -0,0 +1,5 @@
# General: WR-464 addendum: the fork's own test needs a test-only surface subclass (2026-10-31)
Updates: plan/findings/general--flag-pin-wr464-missing-surface-inert-by-construction.md
The fork's capi test (758829c) makes the missing offset with `NoOffsetCylinder`, a test-only `SmCylinder` subclass whose `CreateOffsetSurface` returns no surface. The port's closed `Surface` enum cannot express that, so the test cannot be ported. Reverting the hunk on the fork does not link either: it removes `OffsetCollapses`, which the test calls.